[PATCH 2/2] cli: pick the user's address in a group list as from address

2012-01-15 Thread Tomi Ollila
On Sat, 14 Jan 2012 23:49:50 +0200, Jani Nikula  wrote:
> Messages received to a group list were not replied to using the from
> address in the list. Fix it.
> 
> Signed-off-by: Jani Nikula 
> ---

Both LGTM.

Tomi


Re: [PATCH 2/2] cli: pick the user's address in a group list as from address

2012-01-15 Thread Tomi Ollila
On Sat, 14 Jan 2012 23:49:50 +0200, Jani Nikula j...@nikula.org wrote:
 Messages received to a group list were not replied to using the from
 address in the list. Fix it.
 
 Signed-off-by: Jani Nikula j...@nikula.org
 ---

Both LGTM.

Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


[PATCH 2/2] cli: pick the user's address in a group list as from address

2012-01-14 Thread Jani Nikula
Messages received to a group list were not replied to using the from
address in the list. Fix it.

Signed-off-by: Jani Nikula 
---
 notmuch-reply.c |2 +-
 test/reply  |1 -
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/notmuch-reply.c b/notmuch-reply.c
index da3acce..0f682db 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -203,7 +203,7 @@ scan_address_list (InternetAddressList *list,
if (group_list == NULL)
continue;

-   n += scan_address_list (group_list, config, message, type, NULL);
+   n += scan_address_list (group_list, config, message, type, 
user_from);
} else {
InternetAddressMailbox *mailbox;
const char *name;
diff --git a/test/reply b/test/reply
index 196535a..e4e16eb 100755
--- a/test/reply
+++ b/test/reply
@@ -73,7 +73,6 @@ On Tue, 05 Jan 2010 15:43:56 -, Sender  wrote:
 > reply from alternate address"

 test_begin_subtest "Reply from address in named group list"
-test_subtest_known_broken
 add_message '[from]="Sender "' \
 '[to]=group:test_suite at notmuchmail.org,someone at 
example.com\;' \
  [cc]=test_suite_other at notmuchmail.org \
-- 
1.7.5.4



[PATCH 2/2] cli: pick the user's address in a group list as from address

2012-01-14 Thread Austin Clements
Quoth Jani Nikula on Jan 14 at 11:49 pm:
> Messages received to a group list were not replied to using the from
> address in the list. Fix it.
> 
> Signed-off-by: Jani Nikula 

Both LGTM.


[PATCH 2/2] cli: pick the user's address in a group list as from address

2012-01-14 Thread Jani Nikula
Messages received to a group list were not replied to using the from
address in the list. Fix it.

Signed-off-by: Jani Nikula j...@nikula.org
---
 notmuch-reply.c |2 +-
 test/reply  |1 -
 2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/notmuch-reply.c b/notmuch-reply.c
index da3acce..0f682db 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -203,7 +203,7 @@ scan_address_list (InternetAddressList *list,
if (group_list == NULL)
continue;
 
-   n += scan_address_list (group_list, config, message, type, NULL);
+   n += scan_address_list (group_list, config, message, type, 
user_from);
} else {
InternetAddressMailbox *mailbox;
const char *name;
diff --git a/test/reply b/test/reply
index 196535a..e4e16eb 100755
--- a/test/reply
+++ b/test/reply
@@ -73,7 +73,6 @@ On Tue, 05 Jan 2010 15:43:56 -, Sender 
sen...@example.com wrote:
  reply from alternate address
 
 test_begin_subtest Reply from address in named group list
-test_subtest_known_broken
 add_message '[from]=Sender sen...@example.com' \
 '[to]=group:test_su...@notmuchmail.org,some...@example.com\;' \
  [cc]=test_suite_ot...@notmuchmail.org \
-- 
1.7.5.4

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Re: [PATCH 2/2] cli: pick the user's address in a group list as from address

2012-01-14 Thread Austin Clements
Quoth Jani Nikula on Jan 14 at 11:49 pm:
 Messages received to a group list were not replied to using the from
 address in the list. Fix it.
 
 Signed-off-by: Jani Nikula j...@nikula.org

Both LGTM.
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch