[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-22 Thread Jameson Graef Rollins 
Since message-ids necessarily match just a single message, there's no
reason to do a search for the id before viewing the actual message;
the search just becomes an extra screen to click through.  Clicking on
an id: links now just jumps straight to the message itself.
---
This just fixes the subject of the patch, which had a typo.  Sorry.

 emacs/notmuch-show.el |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 98db8f2..623d521 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -803,7 +803,7 @@ a corresponding notmuch search."
   (remove-overlays (match-beginning 0) (match-end 0) 'goto-address t)
   (make-text-button (match-beginning 0) (match-end 0)
'action `(lambda (arg)
-  (notmuch-search ,(match-string-no-properties 
0)))
+  (notmuch-show ,(match-string-no-properties 
0)))
'follow-link t
'help-echo "Mouse-1, RET: search for this message"
'face goto-address-mail-face
-- 
1.7.7.3

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread David Edmondson 
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins  wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through.  Clicking on
> an id: links now just jumps straight to the message itself.

It's often useful to see a message in context, particularly as it's
common for people to reference id:'s when referring to a thread (thread:
is instance local, as I recall).

Is there a simple way from `notmuch-show' to jump out to the result of
`notmuch-search' for the current id:? Maybe we could bind ^ to something
like `notmuch-show-in-context'.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread Xavier Maillard 
Hi David,

On Fri, 23 Dec 2011 07:48:49 +, David Edmondson  wrote:
> On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins  finestructure.net> wrote:
> > Since message-ids necessarily match just a single message, there's no
> > reason to do a search for the id before viewing the actual message;
> > the search just becomes an extra screen to click through.  Clicking on
> > an id: links now just jumps straight to the message itself.
> 
> It's often useful to see a message in context, particularly as it's
> common for people to reference id:'s when referring to a thread (thread:
> is instance local, as I recall).
> 
> Is there a simple way from `notmuch-show' to jump out to the result of
> `notmuch-search' for the current id:? Maybe we could bind ^ to something
> like `notmuch-show-in-context'.

Why not use a prefix argument to do different thing:

C-u RET -> show in context
RET -> show single message

WDYT ?

/Xavier

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread David Edmondson 
On Fri, 23 Dec 2011 11:10:53 +0100, Xavier Maillard  
wrote:
> Hi David,
> 
> On Fri, 23 Dec 2011 07:48:49 +, David Edmondson  wrote:
> > On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins  > finestructure.net> wrote:
> > > Since message-ids necessarily match just a single message, there's no
> > > reason to do a search for the id before viewing the actual message;
> > > the search just becomes an extra screen to click through.  Clicking on
> > > an id: links now just jumps straight to the message itself.
> > 
> > It's often useful to see a message in context, particularly as it's
> > common for people to reference id:'s when referring to a thread (thread:
> > is instance local, as I recall).
> > 
> > Is there a simple way from `notmuch-show' to jump out to the result of
> > `notmuch-search' for the current id:? Maybe we could bind ^ to something
> > like `notmuch-show-in-context'.
> 
> Why not use a prefix argument to do different thing:
> 
> C-u RET -> show in context
> RET -> show single message
> 
> WDYT ?

I was talking nonsense. `notmuch-show' will show the full thread but
only the matching message open.

Jesse: Sorry for the noise - the patch looks good to me.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-24 Thread David Bremner 
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins  wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through.  Clicking on
> an id: links now just jumps straight to the message itself.

Pushed.

d

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2012-01-12 Thread Pieter Praet 
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins  wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through.  Clicking on
> an id: links now just jumps straight to the message itself.
> ---
> This just fixes the subject of the patch, which had a typo.  Sorry.
> 
>  emacs/notmuch-show.el |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 98db8f2..623d521 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -803,7 +803,7 @@ a corresponding notmuch search."
>(remove-overlays (match-beginning 0) (match-end 0) 'goto-address t)
>(make-text-button (match-beginning 0) (match-end 0)
>   'action `(lambda (arg)
> -(notmuch-search ,(match-string-no-properties 
> 0)))
> +(notmuch-show ,(match-string-no-properties 
> 0)))
>   'follow-link t
>   'help-echo "Mouse-1, RET: search for this message"
>   'face goto-address-mail-face
> -- 
> 1.7.7.3

Anti-RSI FTW!

However...  If no message with that id: exists, `notmuch-show'
will drop us to a blank screen.

See id:"87lisjzrsc.fsf at kepler.schwinge.homeip.net" for some mock
'id:' links which demonstrate this nicely.

Patches follow.


Peace

-- 
Pieter

[PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-22 Thread Jameson Graef Rollins 
Since message-ids necessarily match just a single message, there's no
reason to do a search for the id before viewing the actual message;
the search just becomes an extra screen to click through.  Clicking on
an id: links now just jumps straight to the message itself.
---
This just fixes the subject of the patch, which had a typo.  Sorry.

 emacs/notmuch-show.el |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 98db8f2..623d521 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -803,7 +803,7 @@ a corresponding notmuch search."
   (remove-overlays (match-beginning 0) (match-end 0) 'goto-address t)
   (make-text-button (match-beginning 0) (match-end 0)
'action `(lambda (arg)
-  (notmuch-search ,(match-string-no-properties 
0)))
+  (notmuch-show ,(match-string-no-properties 
0)))
'follow-link t
'help-echo "Mouse-1, RET: search for this message"
'face goto-address-mail-face
-- 
1.7.7.3

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2012-01-12 Thread Pieter Praet 
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins 
 wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through.  Clicking on
> an id: links now just jumps straight to the message itself.
> ---
> This just fixes the subject of the patch, which had a typo.  Sorry.
> 
>  emacs/notmuch-show.el |2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 98db8f2..623d521 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -803,7 +803,7 @@ a corresponding notmuch search."
>(remove-overlays (match-beginning 0) (match-end 0) 'goto-address t)
>(make-text-button (match-beginning 0) (match-end 0)
>   'action `(lambda (arg)
> -(notmuch-search ,(match-string-no-properties 
> 0)))
> +(notmuch-show ,(match-string-no-properties 
> 0)))
>   'follow-link t
>   'help-echo "Mouse-1, RET: search for this message"
>   'face goto-address-mail-face
> -- 
> 1.7.7.3

Anti-RSI FTW!

However...  If no message with that id: exists, `notmuch-show'
will drop us to a blank screen.

See id:"87lisjzrsc@kepler.schwinge.homeip.net" for some mock
'id:' links which demonstrate this nicely.

Patches follow.


Peace

-- 
Pieter
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-22 Thread David Edmondson 
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins 
 wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through.  Clicking on
> an id: links now just jumps straight to the message itself.

It's often useful to see a message in context, particularly as it's
common for people to reference id:'s when referring to a thread (thread:
is instance local, as I recall).

Is there a simple way from `notmuch-show' to jump out to the result of
`notmuch-search' for the current id:? Maybe we could bind ^ to something
like `notmuch-show-in-context'.


pgpzm0vBdtU4S.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread Xavier Maillard 
Hi David,

On Fri, 23 Dec 2011 07:48:49 +, David Edmondson  wrote:
> On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins 
>  wrote:
> > Since message-ids necessarily match just a single message, there's no
> > reason to do a search for the id before viewing the actual message;
> > the search just becomes an extra screen to click through.  Clicking on
> > an id: links now just jumps straight to the message itself.
> 
> It's often useful to see a message in context, particularly as it's
> common for people to reference id:'s when referring to a thread (thread:
> is instance local, as I recall).
> 
> Is there a simple way from `notmuch-show' to jump out to the result of
> `notmuch-search' for the current id:? Maybe we could bind ^ to something
> like `notmuch-show-in-context'.

Why not use a prefix argument to do different thing:

C-u RET -> show in context
RET -> show single message

WDYT ?

/Xavier
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-23 Thread David Edmondson 
On Fri, 23 Dec 2011 11:10:53 +0100, Xavier Maillard  wrote:
> Hi David,
> 
> On Fri, 23 Dec 2011 07:48:49 +, David Edmondson  wrote:
> > On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins 
> >  wrote:
> > > Since message-ids necessarily match just a single message, there's no
> > > reason to do a search for the id before viewing the actual message;
> > > the search just becomes an extra screen to click through.  Clicking on
> > > an id: links now just jumps straight to the message itself.
> > 
> > It's often useful to see a message in context, particularly as it's
> > common for people to reference id:'s when referring to a thread (thread:
> > is instance local, as I recall).
> > 
> > Is there a simple way from `notmuch-show' to jump out to the result of
> > `notmuch-search' for the current id:? Maybe we could bind ^ to something
> > like `notmuch-show-in-context'.
> 
> Why not use a prefix argument to do different thing:
> 
> C-u RET -> show in context
> RET -> show single message
> 
> WDYT ?

I was talking nonsense. `notmuch-show' will show the full thread but
only the matching message open.

Jesse: Sorry for the noise - the patch looks good to me.


pgpf9Wd72vNeD.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2011-12-24 Thread David Bremner 
On Thu, 22 Dec 2011 20:59:12 -0800, Jameson Graef Rollins 
 wrote:
> Since message-ids necessarily match just a single message, there's no
> reason to do a search for the id before viewing the actual message;
> the search just becomes an extra screen to click through.  Clicking on
> an id: links now just jumps straight to the message itself.

Pushed.

d
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH v2] emacs: call notmuch-show instead of notmuch-search in buttonised id: links

2017-03-05 Thread David Bremner 
Pieter Praet  writes:

>
> Anti-RSI FTW!
>
> However...  If no message with that id: exists, `notmuch-show'
> will drop us to a blank screen.
>
> See id:"87lisjzrsc@kepler.schwinge.homeip.net" for some mock
> 'id:' links which demonstrate this nicely.

This old bug seems fixed to me in current notmuch (0.23.7-131-g85df8b39)

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch