Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate
Tomi Ollila writes: > NEWS for notmuch 0.29 says that: > > " > The minimum supported major version of Emacs is now 24. > > Support for GNU Emacs older than 25.1 is deprecated with this release, > and may be removed in a future release. > " > > So we have 3 options: > > 1) apply this patch and now drop support for emacs 24 > > 2) apply this patch and somehow infor emacs 24 users to install cl-lib from > ELPA I'm fine with either of these options. I'd hope we can specify what versions we need in emacs/notmuch-pkg.el.templ d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate
On Thu, Aug 06 2020, Jonas Bernoulli wrote: > David Bremner writes: >> "cl-incf is a Lisp macro in ‘aquamacs-tools.el’." >> >> What the actual heck? > > Indeed. Did you follow the link to the definition to figure out what's > going on? > > Ah... I found this: https://github.com/dholm/tabbar/commit/6d5a6935879. > IMO it's wrong to do that, but that is of no concern here. > >> Anyway, that aside, what version of emacs is this available from? > > Emacs 24.3. A forward compatibility implementation for older versions > is available at https://elpa.gnu.org/packages/cl-lib.html. > > I didn't find any information about what minimal Emacs version Notmuch > expects but https://notmuchmail.org/emacstips/#index1h2 implies that it > is 24.1. > > IMO it would be reasonable to expect at least 24.3, 24.5 or even 25.1. > See https://www.gnu.org/software/emacs/history.html for release dates. NEWS for notmuch 0.29 says that: " The minimum supported major version of Emacs is now 24. Support for GNU Emacs older than 25.1 is deprecated with this release, and may be removed in a future release. " So we have 3 options: 1) apply this patch and now drop support for emacs 24 2) apply this patch and somehow infor emacs 24 users to install cl-lib from ELPA 3) hold this particular patch until notmuch 0.31 is released and drop support for emacs 24 then (would that mean quite a few following patches not to apply anymore ;/ Anyway, the patch series V2 looked good to me (on terminal) Tomi > > Or you might want to just drop this commit. Or we could update the FAQ > to mention that one has to install cl-lib from GNU ELPA if one uses such > an ancient Emacs release. > > Jonas ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate
David Bremner writes: > "cl-incf is a Lisp macro in ‘aquamacs-tools.el’." > > What the actual heck? Indeed. Did you follow the link to the definition to figure out what's going on? Ah... I found this: https://github.com/dholm/tabbar/commit/6d5a6935879. IMO it's wrong to do that, but that is of no concern here. > Anyway, that aside, what version of emacs is this available from? Emacs 24.3. A forward compatibility implementation for older versions is available at https://elpa.gnu.org/packages/cl-lib.html. I didn't find any information about what minimal Emacs version Notmuch expects but https://notmuchmail.org/emacstips/#index1h2 implies that it is 24.1. IMO it would be reasonable to expect at least 24.3, 24.5 or even 25.1. See https://www.gnu.org/software/emacs/history.html for release dates. Or you might want to just drop this commit. Or we could update the FAQ to mention that one has to install cl-lib from GNU ELPA if one uses such an ancient Emacs release. Jonas ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
Re: [PATCH v2 06/23] emacs: Use cl-incf where appropriate
Jonas Bernoulli writes: > It's shorter. That's it pretty much. > --- > emacs/notmuch-hello.el | 2 +- > emacs/notmuch-lib.el | 2 +- "cl-incf is a Lisp macro in ‘aquamacs-tools.el’." What the actual heck? Anyway, that aside, what version of emacs is this available from? d ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
[PATCH v2 06/23] emacs: Use cl-incf where appropriate
It's shorter. That's it pretty much. --- emacs/notmuch-hello.el | 2 +- emacs/notmuch-lib.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el index 89e03c36..1c084bf7 100644 --- a/emacs/notmuch-hello.el +++ b/emacs/notmuch-hello.el @@ -609,7 +609,7 @@ (defun notmuch-hello-insert-buttons (searches) name) (setq column-indent (1+ (max 0 (- column-width (length name))) - (setq count (1+ count)) + (cl-incf count) (when (eq (% count tags-per-line) 0) (setq column-indent 0) (widget-insert "\n"))) diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el index 886da99f..5d0c373a 100644 --- a/emacs/notmuch-lib.el +++ b/emacs/notmuch-lib.el @@ -417,7 +417,7 @@ (defun notmuch-subkeymap-help () (i 0)) (while (< i (length prefix)) (aset prefix i (aref key i)) - (setq i (1+ i))) + (cl-incf i)) (let* ((subkeymap (key-binding prefix)) (ua-keys (where-is-internal 'universal-argument nil t)) (prefix-string (notmuch-prefix-key-description prefix)) -- 2.28.0 ___ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-le...@notmuchmail.org
