[PATCH v5 2/2] emacs: `notmuch-search-operate-all' code cleanup, no functional changes

2012-01-27 Thread David Bremner 
On Thu, 26 Jan 2012 21:34:49 +0400, Dmitry Kurochkin  wrote:
> ---
>  emacs/notmuch.el |   11 +--
>  1 files changed, 5 insertions(+), 6 deletions(-)

Pushed, 

d.

Re: [PATCH v5 2/2] emacs: `notmuch-search-operate-all' code cleanup, no functional changes

2012-01-27 Thread David Bremner 
On Thu, 26 Jan 2012 21:34:49 +0400, Dmitry Kurochkin 
 wrote:
> ---
>  emacs/notmuch.el |   11 +--
>  1 files changed, 5 insertions(+), 6 deletions(-)

Pushed, 

d.

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch

[PATCH v5 2/2] emacs: `notmuch-search-operate-all' code cleanup, no functional changes

2012-01-26 Thread Dmitry Kurochkin 
---
 emacs/notmuch.el |   11 +--
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 291eca2..72f78ed 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -891,12 +891,11 @@ characters as well as `_.+-'.
"Operations (+add -drop): notmuch tag "
'("+" "-")))
   ;; Perform some validation
-  (let ((words actions))
-(when (null words) (error "No operations given"))
-(while words
-  (unless (string-match-p "^[-+][-+_.[:word:]]+$" (car words))
-   (error "Action must be of the form `+this_tag' or `-that_tag'"))
-  (setq words (cdr words
+  (when (null actions) (error "No operations given"))
+  (mapc (lambda (action)
+ (unless (string-match-p "^[-+][-+_.[:word:]]+$" action)
+   (error "Action must be of the form `+this_tag' or `-that_tag'")))
+   actions)
   (apply 'notmuch-tag notmuch-search-query-string actions))

 (defun notmuch-search-buffer-title (query)
-- 
1.7.8.3

[PATCH v5 2/2] emacs: `notmuch-search-operate-all' code cleanup, no functional changes

2012-01-26 Thread Dmitry Kurochkin 
---
 emacs/notmuch.el |   11 +--
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 291eca2..72f78ed 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -891,12 +891,11 @@ characters as well as `_.+-'.
"Operations (+add -drop): notmuch tag "
'("+" "-")))
   ;; Perform some validation
-  (let ((words actions))
-(when (null words) (error "No operations given"))
-(while words
-  (unless (string-match-p "^[-+][-+_.[:word:]]+$" (car words))
-   (error "Action must be of the form `+this_tag' or `-that_tag'"))
-  (setq words (cdr words
+  (when (null actions) (error "No operations given"))
+  (mapc (lambda (action)
+ (unless (string-match-p "^[-+][-+_.[:word:]]+$" action)
+   (error "Action must be of the form `+this_tag' or `-that_tag'")))
+   actions)
   (apply 'notmuch-tag notmuch-search-query-string actions))
 
 (defun notmuch-search-buffer-title (query)
-- 
1.7.8.3

___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch