Re: Possible bug in notmuch_thread_get_authors ?

[David Bremner]

Róman Joost  writes:

> Checking other bindings it seems there is an explicit check for NULL and
> we're wondering if that is really necessary.  Perhaps a patch could
> initialize `*authors` in the _resolve_thread_authors_string function to an
> empty string OR at least mention it in the API documentation that the
> return value can be NULL?

Certainly the documentation update is fine. It's not clear to me without
diving into the code whether returning NULL is signalling an error, or
just a bug.

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch

Possible bug in notmuch_thread_get_authors ?

[Róman Joost]

Hi,

we're currently working on Haskell bindings for notmuch[1] and stumbled
over an oddity in relation to the function notmuch_thread_get_authors in
that it can be NULL.

Checking other bindings it seems there is an explicit check for NULL and
we're wondering if that is really necessary.  Perhaps a patch could
initialize `*authors` in the _resolve_thread_authors_string function to an
empty string OR at least mention it in the API documentation that the
return value can be NULL?

Any thoughts?

[1] - https://github.com/purebred-mua/hs-notmuch

Kind Regards,
-- 
Róman Joost
email: ro...@bromeco.de
GPG key: 3A765B52


signature.asc
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch