Re: [PATCH 1/2] add notmuch keybinding 'd'
On Fri, 06 Jan 2012 16:51:51 -0400, David Bremner da...@tethera.net wrote: On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupré anar...@koumbit.org wrote: On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula j...@nikula.org wrote: * lib: add 'safe' setting for flags * lib: Add back the synchronization of 'T' flag with deleted tag * run notmuch-hello-mode-hook at the end of the hello mode setup Most of those do not change the current behavior, and I have been running them for more than 4 months. I'd very much like to get help to get this in... Hi Antoine; I understand your frustration; it's not very motivating to feel ignored. Over the last few months we have been working to develop a patch review process for notmuch [1], but as you can see from [2] there is still a backlog of patches that have not been reviewed, the two lib patches you mention among them. More reviewers are always welcome ;). Hi, Thanks for the nice words. I am sorry I whined on the list like this. :) I guess I was a bit tired and disappointed no progress had been done on those patches, but I understand how hard it is to keep up with the crazy flood on the list. [1]: http://notmuchmail.org/nmbug/ [2]: http://nmbug.tethera.net/status/ This is a great initiative! I am glad to see my patches still sitting there at least! ;) And I am also happy to see Jamie's patches for the delete key there, if I had more time I would actually go through and review them, unfortunately, I have very little time to review stuff that, honestly, just works for me right now. ;) Sorry again for the outburst, keep up the good work! A. -- La guerre, c'est le massacre d'hommes qui ne se connaissent pas, au profit d'hommes qui se connaissent mais ne se massacreront pas. - Paul Valéry pgpYinAvqsFLV.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] add notmuch keybinding 'd'
On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula j...@nikula.org wrote: I wouldn't use it either, and I don't use deleted tag in the first place. And even if I used it, I'd still like to keep the distinction between deleted after reading and deleted unread, which this patch loses by removing the unread tag. I have been using this for months now. But honestly, I don't care much anymore: the hard part is not the tag, it's what you do with it after (hint: just remove the damn file). Most patches I have submitted here haven't been accepted and I have to painfully reroll my own packages every time there's a new release, which has been a very frustrating experience. To see such a trivial patch obsoleted tops it. For the curious, those (other) patches are: * lib: add 'safe' setting for flags * lib: Add back the synchronization of 'T' flag with deleted tag * run notmuch-hello-mode-hook at the end of the hello mode setup Most of those do not change the current behavior, and I have been running them for more than 4 months. I'd very much like to get help to get this in... A. pgpBBUYcqd9cb.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] add notmuch keybinding 'd'
On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupré anar...@koumbit.org wrote: Most patches I have submitted here haven't been accepted and I have to painfully reroll my own packages every time there's a new release, which has been a very frustrating experience. To see such a trivial patch obsoleted tops it. Don't be too over dramatic, Antoine. A lot of patches have sat fallow for a long time, and a lot of us maintain our own stuff on top what's in master. There's also been discussion on this particular topic since long before you showed up. cworth pushed back on adding a delete key until we had a more integrated solution. I think the same thing is happening here. I'm going to take a crack at an implementation of this functionality this weekend that I think will satisfy most of out needs. jamie. pgphahDsuLqNp.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] add notmuch keybinding 'd'
On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupré anar...@koumbit.org wrote: On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula j...@nikula.org wrote: * lib: add 'safe' setting for flags * lib: Add back the synchronization of 'T' flag with deleted tag * run notmuch-hello-mode-hook at the end of the hello mode setup Most of those do not change the current behavior, and I have been running them for more than 4 months. I'd very much like to get help to get this in... Hi Antoine; I understand your frustration; it's not very motivating to feel ignored. Over the last few months we have been working to develop a patch review process for notmuch [1], but as you can see from [2] there is still a backlog of patches that have not been reviewed, the two lib patches you mention among them. More reviewers are always welcome ;). David [1]: http://notmuchmail.org/nmbug/ [2]: http://nmbug.tethera.net/status/ ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] add notmuch keybinding 'd'
On Fri, 06 Jan 2012 15:10:57 -0500, Antoine Beaupré anar...@koumbit.org wrote: For the curious, those (other) patches are: * lib: add 'safe' setting for flags * lib: Add back the synchronization of 'T' flag with deleted tag * run notmuch-hello-mode-hook at the end of the hello mode setup To add other replies, there are now notmuch-hello-mode-hook and notmuch-hello-refresh-hook impmelented. Most of those do not change the current behavior, and I have been running them for more than 4 months. I'd very much like to get help to get this in... A. Tomi ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] add notmuch keybinding 'd'
On Tue, 03 Jan 2012 14:56:50 +, David Edmondson d...@dme.org wrote: On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupré anar...@koumbit.org wrote: It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It works in show as well as in search mode Various people have asked for a keybinding to add a 'delete' tag. Is this version the right one to choose? No-one has spoken up in favour of this particular change (and the removal of unread seems questionable) so I plan to mark it 'obsolete'. If anyone would like to bring it back, please post an updated version of the patch and argue for it. pgpRhtaJ74rNA.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] add notmuch keybinding 'd'
On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupré anar...@koumbit.org wrote: It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It works in show as well as in search mode Various people have asked for a keybinding to add a 'delete' tag. Is this version the right one to choose? It seems sane to me (though I won't use it). pgpwGU12vOd5F.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] add notmuch keybinding 'd'
On Tue, 03 Jan 2012 14:56:50 +, David Edmondson d...@dme.org wrote: On Sat, 16 Jul 2011 14:39:59 -0400, Antoine Beaupré anar...@koumbit.org wrote: It adds a tag 'deleted' and removes the tags 'inbox' and 'unread'. It works in show as well as in search mode Various people have asked for a keybinding to add a 'delete' tag. Is this version the right one to choose? The code's there, and talk is cheap... but I'd rather like to see a solution that would make it easy for users to add arbitrary tagging operations to key bindings, instead of a fixed binding for deleted. That way perhaps adding a default 'd' for deleted wouldn't feel so special either. It seems sane to me (though I won't use it). I wouldn't use it either, and I don't use deleted tag in the first place. And even if I used it, I'd still like to keep the distinction between deleted after reading and deleted unread, which this patch loses by removing the unread tag. BR, Jani. ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
Re: [PATCH 1/2] add notmuch keybinding 'd'
On Tue, 03 Jan 2012 21:57:22 +0200, Jani Nikula j...@nikula.org wrote: The code's there, and talk is cheap... but I'd rather like to see a solution that would make it easy for users to add arbitrary tagging operations to key bindings, instead of a fixed binding for deleted. It's already easy for users to add arbitrary key bindings. It's emacs, and the whole point of which is that it's infinitely extensible [0]: (define-key notmuch-show-mode-map d (lambda () Delete current message and advance to next message. (interactive) (notmuch-show-add-tag delete) (notmuch-show-next-open-message-or-pop))) There really can't be an easier solution to add a key binding other than just adding the above to your .emacs, and I really don't think it would be worth it to try to make one. The fact that it's already so easy to customize the key bindings is why I've been reluctant (or even against) getting into protracted discussions about what the default key bindings should be. Everyone is going to want a different behavior, and since it's easy enough to customize, just let users define what they want. I wouldn't use it either, and I don't use deleted tag in the first place. And even if I used it, I'd still like to keep the distinction between deleted after reading and deleted unread, which this patch loses by removing the unread tag. Beyond what I just said about letting everyone customize things themselves, I agree that I don't personally want other tags added or removed when I delete a message. The key binding above is actually the one I use. jamie. [0] http://notmuchmail.org/emacstips/#index6h2 pgpEHraO8ovZi.pgp Description: PGP signature ___ notmuch mailing list notmuch@notmuchmail.org http://notmuchmail.org/mailman/listinfo/notmuch
