Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address
Tomi Ollila writes:
>> I can live with the current argument syntax, but since a certain a mount
>> of bikeshedding is expected, here is an alternative suggestion
>>
>> --deduplication={none|mailbox|address}
>
> (is s/deduplicate/deduplication/ intended or accidental change?)
accidental. hmm. well,
--deduplicate={no|mailbox|address}
is a few characters shorter.
> Is this complete alternative to --deduplicate={no|yes|address},
> respectively?
Yes
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address
On Sun, Aug 30 2015, David Bremner wrote:
> Jani Nikula writes:
>
>> Consider all variants of an email address as one, and print the most
>> common variant.
>
> Other than the quibbles already mentioned, the series looks ok to
> me. For production it should have one or two tests I guess. Oh, and man
> page updates. But you knew that I guess.
>
> I can live with the current argument syntax, but since a certain a mount
> of bikeshedding is expected, here is an alternative suggestion
>
> --deduplication={none|mailbox|address}
(is s/deduplicate/deduplication/ intended or accidental change?)
Is this complete alternative to --deduplicate={no|yes|address}, respectively?
If it is it looks somewhat better to me (provided that it is accurate)
anyway, the user command line interface looks good to me.
Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
Re: [RFC PATCH 5/5] cli: add support for deduplicating based on case insensitive address
Jani Nikula writes:
> Consider all variants of an email address as one, and print the most
> common variant.
Other than the quibbles already mentioned, the series looks ok to
me. For production it should have one or two tests I guess. Oh, and man
page updates. But you knew that I guess.
I can live with the current argument syntax, but since a certain a mount
of bikeshedding is expected, here is an alternative suggestion
--deduplication={none|mailbox|address}
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch
