patches for 0.4

2010-06-07 Thread David Edmondson
On Thu, 03 Jun 2010 19:20:54 -0700, Carl Worth  wrote:
> > [PATCH 09/13] emacs: Avoid runtime use of `cl'.
> 
> Perhaps it's just fine now that you've been testing it a while, but at
> least in your original email you said you wanted some additional review,
> so I planned to do that.

I have not noticed any oddities when using the changes. It would still
make sense for there to be careful review.

dme.
-- 
David Edmondson, http://dme.org
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: 



Re: patches for 0.4

2010-06-07 Thread David Edmondson
On Thu, 03 Jun 2010 19:20:54 -0700, Carl Worth cwo...@cworth.org wrote:
  [PATCH 09/13] emacs: Avoid runtime use of `cl'.
 
 Perhaps it's just fine now that you've been testing it a while, but at
 least in your original email you said you wanted some additional review,
 so I planned to do that.

I have not noticed any oddities when using the changes. It would still
make sense for there to be careful review.

dme.
-- 
David Edmondson, http://dme.org


pgpmzSIVVnPGp.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


Re: patches for 0.4

2010-06-03 Thread Carl Worth
On Wed, 19 May 2010 08:03:27 +0100, David Edmondson d...@dme.org wrote:
 This is a set of small feature and cleanup patches. The only
 particularly significant one is patch 2, as it fixes a memory
 corruption bug in notmuch.

Thanks, David.

Most of these I had already picked up in my recent scan of my
queue. Specifically:

 [PATCH 01/13] emacs: Usability improvements for `notmuch-hello'.
 [PATCH 02/13] notmuch: Fix off-by-one errors if a header is 200 characters 
 long.
 [PATCH 04/13] emacs: Display non-matching authors with a different face.
 [PATCH 05/13] emacs: Set the `face' property rather than `font-lock-face'.
 [PATCH 06/13] emacs: Allow control over faces for search mode columns.
 [PATCH 07/13] emacs: Allow tuning of the tag/saved search layout.
 [PATCH 08/13] emacs: Reuse rather than reinvent message header filtering
 [PATCH 11/13] emacs: Pretty print the numbers of matching messages.
 [PATCH 13/13] emacs: Allow the display of absolute dates in the header line.

I did find three new patches here, which I've now committed:

 [PATCH 03/13] emacs: Adjust comment to avoid confusing font-lock.
 [PATCH 10/13] emacs: In search mode, truncate authors using invisible text.
 [PATCH 12/13] emacs: Tags should be shown with `notmuch-tag-face'.

Finally, there is this one patch in the series that I have tagged for a
closer review:

 [PATCH 09/13] emacs: Avoid runtime use of `cl'.

Perhaps it's just fine now that you've been testing it a while, but at
least in your original email you said you wanted some additional review,
so I planned to do that.

Thanks for sending this list, (and for all of your work on these
features!).

-Carl

-- 
carl.d.wo...@intel.com


pgpJzrKpq8Btv.pgp
Description: PGP signature
___
notmuch mailing list
notmuch@notmuchmail.org
http://notmuchmail.org/mailman/listinfo/notmuch


patches for 0.4

2010-05-19 Thread David Edmondson
This is a set of small feature and cleanup patches. The only
particularly significant one is patch 2, as it fixes a memory
corruption bug in notmuch.

dme.

[PATCH 01/13] emacs: Usability improvements for `notmuch-hello'.
[PATCH 02/13] notmuch: Fix off-by-one errors if a header is >200 characters 
long.
[PATCH 03/13] emacs: Adjust comment to avoid confusing font-lock.
[PATCH 04/13] emacs: Display non-matching authors with a different face.
[PATCH 05/13] emacs: Set the `face' property rather than `font-lock-face'.
[PATCH 06/13] emacs: Allow control over faces for search mode columns.
[PATCH 07/13] emacs: Allow tuning of the tag/saved search layout.
[PATCH 08/13] emacs: Reuse rather than reinvent message header filtering
[PATCH 09/13] emacs: Avoid runtime use of `cl'.
[PATCH 10/13] emacs: In search mode, truncate authors using invisible text.
[PATCH 11/13] emacs: Pretty print the numbers of matching messages.
[PATCH 12/13] emacs: Tags should be shown with `notmuch-tag-face'.
[PATCH 13/13] emacs: Allow the display of absolute dates in the header line.