Re: version 4: Retrieve GPG keys asynchronously.

2019-12-14 Thread David Bremner
Daniel Kahn Gillmor  writes:

> In id:87blw1rldy@tethera.net, bremner identified two of my edits
> breaking dme's series that permits asynchronous retrieval of OpenPGP
> keys.
>
> This is a revision of that series that should apply to the current
> master, taking into account my earlier fixes.
>
> dme, if you could review i would appreciate it.  I think i've done
> what you would have done, but as usual my elisp skills are weaker than
> yours, so i welcome your feedback.  The test suite passes for me at
> least :)
>
> Sorry for contributing to the collision earlier!
>

Series merged to master

d
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: version 4: Retrieve GPG keys asynchronously.

2019-12-12 Thread David Edmondson
On Wednesday, 2019-09-11 at 21:32:56 -04, Daniel Kahn Gillmor wrote:

> In id:87blw1rldy@tethera.net, bremner identified two of my edits
> breaking dme's series that permits asynchronous retrieval of OpenPGP
> keys.
>
> This is a revision of that series that should apply to the current
> master, taking into account my earlier fixes.
>
> dme, if you could review i would appreciate it.  I think i've done
> what you would have done, but as usual my elisp skills are weaker than
> yours, so i welcome your feedback.  The test suite passes for me at
> least :)

The rebased changes look good to me. Sorry for taking so long to review.

dme.
-- 
At least they're not lonely.
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


Re: version 4: Retrieve GPG keys asynchronously.

2019-09-15 Thread Tomi Ollila
On Wed, Sep 11 2019, Daniel Kahn Gillmor wrote:

> In id:87blw1rldy@tethera.net, bremner identified two of my edits
> breaking dme's series that permits asynchronous retrieval of OpenPGP
> keys.
>
> This is a revision of that series that should apply to the current
> master, taking into account my earlier fixes.
>
> dme, if you could review i would appreciate it.  I think i've done
> what you would have done, but as usual my elisp skills are weaker than
> yours, so i welcome your feedback.  The test suite passes for me at
> least :)
>
> Sorry for contributing to the collision earlier!


This series looks good to me. I did not (take time to look how to) test,
but I trust dkg has basically executed all changed code :D. Some of the
code was just style change w/o functional change (one let* context puzzled 
me for a while) -- for better which is good!

>
>   --dkg
>

Tomi
___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch


version 4: Retrieve GPG keys asynchronously.

2019-09-11 Thread Daniel Kahn Gillmor
In id:87blw1rldy@tethera.net, bremner identified two of my edits
breaking dme's series that permits asynchronous retrieval of OpenPGP
keys.

This is a revision of that series that should apply to the current
master, taking into account my earlier fixes.

dme, if you could review i would appreciate it.  I think i've done
what you would have done, but as usual my elisp skills are weaker than
yours, so i welcome your feedback.  The test suite passes for me at
least :)

Sorry for contributing to the collision earlier!

  --dkg



___
notmuch mailing list
notmuch@notmuchmail.org
https://notmuchmail.org/mailman/listinfo/notmuch