Re: [Nouveau] [PATCH] fix:overlay: add missing header dependencies
On Sunday, August 28, 2016 1:02:52 PM CEST Baoyou Xie wrote: > We get 1 warning when build kernel with W=1: > drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous > prototype for 'nouveau_overlay_init' [-Wmissing-prototypes] > > In fact, this function is declared in disp.h, so this patch > add missing header dependencies > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann a few general notes: - please use my a...@arndb.de address on patch submissions, not the linaro address. - for the email subject lines, have a look at what the typical style is for the file. "overlay:" is not a good name here because it's not unique to the driver, so better use "drm/nouveau", which will also get the attention of the right people. - please drop the "fix:" prefix in the subject. Arnd ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH] drm/nouveau/gr: add missing header dependencies
We get 2 warnings when build kernel with W=1: drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:255:1: warning: no previous prototype for 'nv50_grctx_fill' [-Wmissing-prototypes] drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:265:1: warning: no previous prototype for 'nv50_grctx_init' [-Wmissing-prototypes] In fact, these functions are declared in gr/nv50.h, so this patch add missing header dependencies Signed-off-by: Baoyou Xie --- drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c index 1e13278..0490ee8 100644 --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c @@ -109,6 +109,8 @@ #include +#include "nv50.h" + #define IS_NVA3F(x) (((x) > 0xa0 && (x) < 0xaa) || (x) == 0xaf) #define IS_NVAAF(x) ((x) >= 0xaa && (x) <= 0xac) -- 2.7.4 ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH] drm/nouveau: silence warnings reported during builds with W=1
We get some warnings when building kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous
prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:255:1: warning: no previous
prototype for 'nv50_grctx_fill' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c:265:1: warning: no previous
prototype for 'nv50_grctx_init' [-Wmissing-prototypes]
In fact, some functions are only used in the file in which they
are declared and don't need a declaration, but can be made static.
and others are declared in the header files, but need to add
missing header dependencies.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/dispnv04/overlay.c | 2 +-
drivers/gpu/drm/nouveau/nouveau_display.c | 2 +-
drivers/gpu/drm/nouveau/nv10_fence.c| 2 +-
drivers/gpu/drm/nouveau/nvkm/core/firmware.c| 1 +
drivers/gpu/drm/nouveau/nvkm/engine/device/user.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c | 8
drivers/gpu/drm/nouveau/nvkm/engine/disp/rootnv50.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c | 4 ++--
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxnv50.c| 2 ++
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 4 ++--
drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c | 4 ++--
drivers/gpu/drm/nouveau/nvkm/subdev/bios/fan.c | 4 ++--
drivers/gpu/drm/nouveau/nvkm/subdev/clk/gt215.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/subdev/fb/ramgt215.c | 8
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr2.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/fb/sddr3.c | 1 +
drivers/gpu/drm/nouveau/nvkm/subdev/gpio/gk104.c| 2 +-
drivers/gpu/drm/nouveau/nvkm/subdev/secboot/gm200.c | 2 +-
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk104.c| 4 ++--
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gpio.c | 2 ++
23 files changed, 36 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
index ec444ea..a79514d 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
@@ -33,7 +33,7 @@
#include "nouveau_connector.h"
#include "nouveau_display.h"
#include "nvreg.h"
-
+#include "disp.h"
struct nouveau_plane {
struct drm_plane base;
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c
b/drivers/gpu/drm/nouveau/nouveau_display.c
index afbf557..b60ee21 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -92,7 +92,7 @@ calc(int blanks, int blanke, int total, int line)
return line;
}
-int
+static int
nouveau_display_scanoutpos_head(struct drm_crtc *crtc, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime)
{
diff --git a/drivers/gpu/drm/nouveau/nv10_fence.c
b/drivers/gpu/drm/nouveau/nv10_fence.c
index 4e3de34..619f79d 100644
--- a/drivers/gpu/drm/nouveau/nv10_fence.c
+++ b/drivers/gpu/drm/nouveau/nv10_fence.c
@@ -66,7 +66,7 @@ nv10_fence_context_del(struct nouveau_channel *chan)
nouveau_fence_context_free(&fctx->base);
}
-int
+static int
nv10_fence_context_new(struct nouveau_channel *chan)
{
struct nv10_fence_chan *fctx;
diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
index 34ecd4a..058ff46 100644
--- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
+++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c
@@ -20,6 +20,7 @@
* DEALINGS IN THE SOFTWARE.
*/
#include
+#include
/**
* nvkm_firmware_get - load firmware from the official nvidia/chip/ directory
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
b/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
index 79a8f71..513ee6b 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/device/user.c
@@ -326,7 +326,7 @@ nvkm_udevice = {
.sclass = nvkm_udevice_child_get,
};
-int
+static int
nvkm_udevice_new(const struct nvkm_oclass *oclass, void *data, u32 size,
struct nvkm_object **pobject)
{
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
b/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
index dd2953b..26990d4 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/channv50.c
@@ -153,7 +153,7 @@ nv50_disp_chan_uevent = {
.fini = nv50_disp_chan_uevent_fini,
};
-int
+static int
nv50_disp_chan_rd32(struct nvkm_object *object, u64 addr, u32 *data)
{
struct nv50_disp_chan *chan = nv50_disp_chan(object);
@@ -163,7 +163,7 @@ nv50_disp_chan_rd32(struct nvkm_object *object, u64 addr,
u32 *data)
[Nouveau] [PATCH v2] drm/nouveau/pm: mark nvkm_perfsig_find() static
We get 2 warnings when build kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:75:1: warning: no previous
prototype for 'nvkm_perfsig_find' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:703:1: warning: no previous
prototype for 'nvkm_perfsrc_new' [-Wmissing-prototypes]
In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
index 8616636..dde89a4 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
@@ -71,7 +71,7 @@ nvkm_perfdom_find(struct nvkm_pm *pm, int di)
return NULL;
}
-struct nvkm_perfsig *
+static struct nvkm_perfsig *
nvkm_perfsig_find(struct nvkm_pm *pm, u8 di, u8 si, struct nvkm_perfdom **pdom)
{
struct nvkm_perfdom *dom = *pdom;
@@ -699,7 +699,7 @@ nvkm_pm_oclass_get(struct nvkm_oclass *oclass, int index,
return 1;
}
-int
+static int
nvkm_perfsrc_new(struct nvkm_pm *pm, struct nvkm_perfsig *sig,
const struct nvkm_specsrc *spec)
{
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static
On 30 August 2016 at 00:01, Sean Paul wrote:
> On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie wrote:
> > We get 1 warning when build kernel with W=1:
> > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no
> previous prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
> >
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > so this patch marks this function with 'static'.
> >
>
> It would make things a lot easier if you either consolidated all of
> these static changes into one patch, or released them as a series.
>
>
Do you mean that I need to consolidate all of them into one patch this
time? or next time?
> Sean
>
>
> > Signed-off-by: Baoyou Xie
> > ---
> > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> > index 6d3c501..4c4b5ab 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> > @@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx
> *info)
> > }
> > }
> >
> > -void
> > +static void
> > gm107_grctx_generate_tpcid(struct gf100_gr *gr)
> > {
> > struct nvkm_device *device = gr->base.engine.subdev.device;
> > --
> > 2.7.4
> >
>
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH] drm/nouveau/gr/gf117-: mark symbols static where possible
We get 1 warning when biuld kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous
prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
index c925ade..74a64e3 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
@@ -218,7 +218,7 @@ gf117_grctx_generate_attrib(struct gf100_grctx *info)
}
}
-void
+static void
gf117_grctx_generate_main(struct gf100_gr *gr, struct gf100_grctx *info)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH] drm/nouveau/pm: mark symbols static where possible
We get 2 warnings when biuld kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:75:1: warning: no previous
prototype for 'nvkm_perfsig_find' [-Wmissing-prototypes]
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c:703:1: warning: no previous
prototype for 'nvkm_perfsrc_new' [-Wmissing-prototypes]
In fact, these functions are only used in the file in which they are
declared and don't need a declaration, but can be made static.
so this patch marks these functions with 'static'.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
index 8616636..dde89a4 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/pm/base.c
@@ -71,7 +71,7 @@ nvkm_perfdom_find(struct nvkm_pm *pm, int di)
return NULL;
}
-struct nvkm_perfsig *
+static struct nvkm_perfsig *
nvkm_perfsig_find(struct nvkm_pm *pm, u8 di, u8 si, struct nvkm_perfdom **pdom)
{
struct nvkm_perfdom *dom = *pdom;
@@ -699,7 +699,7 @@ nvkm_pm_oclass_get(struct nvkm_oclass *oclass, int index,
return 1;
}
-int
+static int
nvkm_perfsrc_new(struct nvkm_pm *pm, struct nvkm_perfsig *sig,
const struct nvkm_specsrc *spec)
{
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH] fix:nv10_fence: mark symbols static where possible
We get 1 warning about global functions without a declaration
in the nouveau nv10_fence driver when building with W=1:
drivers/gpu/drm/nouveau/nv10_fence.c:70:1: warning: no previous prototype for
'nv10_fence_context_new' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared
and don't need a declaration, but can be made static.
so this patch marks it 'static'.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/nv10_fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nv10_fence.c
b/drivers/gpu/drm/nouveau/nv10_fence.c
index 4e3de34..619f79d 100644
--- a/drivers/gpu/drm/nouveau/nv10_fence.c
+++ b/drivers/gpu/drm/nouveau/nv10_fence.c
@@ -66,7 +66,7 @@ nv10_fence_context_del(struct nouveau_channel *chan)
nouveau_fence_context_free(&fctx->base);
}
-int
+static int
nv10_fence_context_new(struct nouveau_channel *chan)
{
struct nv10_fence_chan *fctx;
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static
dear all: I have resend a patch, which consolidate the 'nouveau' changes into it, its subject is "drm/nouveau: silence warnings reported during builds with W=1". FYI. On 30 August 2016 at 20:40, Arnd Bergmann wrote: > On Tuesday 30 August 2016, Baoyou Xie wrote: > > On 30 August 2016 at 00:01, Sean Paul wrote: > > > > > On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie > wrote: > > > > We get 1 warning when build kernel with W=1: > > > > drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no > > > previous prototype for 'gm107_grctx_generate_tpcid' > [-Wmissing-prototypes] > > > > > > > > In fact, this function is only used in the file in which it is > > > > declared and don't need a declaration, but can be made static. > > > > so this patch marks this function with 'static'. > > > > > > > > > > It would make things a lot easier if you either consolidated all of > > > these static changes into one patch, or released them as a series. > > > > > > > > Do you mean that I need to consolidate all of them into one patch this > > time? or next time? > > I'd suggest consolidating the 'nouveau' changes into a single patch, > as this is one (very big) driver and resend that one. > > Arnd > ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH] fix:overlay: add missing header dependencies
We get 1 warning when build kernel with W=1:
drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous
prototype for 'nouveau_overlay_init' [-Wmissing-prototypes]
In fact, this function is declared in disp.h, so this patch
add missing header dependencies
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/dispnv04/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
index ec444ea..a79514d 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
@@ -33,7 +33,7 @@
#include "nouveau_connector.h"
#include "nouveau_display.h"
#include "nvreg.h"
-
+#include "disp.h"
struct nouveau_plane {
struct drm_plane base;
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH] fix:nouveau_display: mark symbols static where possible
We get 1 warning about global functions without a declaration
in the nouveau nouveau_display driver when building with W=1:
drivers/gpu/drm/nouveau/nouveau_display.c:96:1: warning: no previous prototype
for 'nouveau_display_scanoutpos_head' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is declared
and don't need a declaration, but can be made static.
so this patch marks it 'static'.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/nouveau_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c
b/drivers/gpu/drm/nouveau/nouveau_display.c
index afbf557..b60ee21 100644
--- a/drivers/gpu/drm/nouveau/nouveau_display.c
+++ b/drivers/gpu/drm/nouveau/nouveau_display.c
@@ -92,7 +92,7 @@ calc(int blanks, int blanke, int total, int line)
return line;
}
-int
+static int
nouveau_display_scanoutpos_head(struct drm_crtc *crtc, int *vpos, int *hpos,
ktime_t *stime, ktime_t *etime)
{
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static
We get 1 warning when build kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous
prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
index 6d3c501..4c4b5ab 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
@@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info)
}
}
-void
+static void
gm107_grctx_generate_tpcid(struct gf100_gr *gr)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH] drm/nouveau/gr: mark symbols static where possible
We get 1 warning when biuld kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous
prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
index 6d3c501..4c4b5ab 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
@@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info)
}
}
-void
+static void
gm107_grctx_generate_tpcid(struct gf100_gr *gr)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH] drm/nouveau/gr/gm107: mark symbols static where possible
We get 1 warning when build kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c:312:1: warning: no previous
prototype for 'gm107_gr_init' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
index 45f965f..2c67fac 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gm107.c
@@ -308,7 +308,7 @@ gm107_gr_init_bios(struct gf100_gr *gr)
}
}
-int
+static int
gm107_gr_init(struct gf100_gr *gr)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH v2] drm/nouveau: add missing header dependencies
We get 1 warning when build kernel with W=1:
drivers/gpu/drm/nouveau/dispnv04/overlay.c:496:1: warning: no previous
prototype for 'nouveau_overlay_init' [-Wmissing-prototypes]
In fact, this function is declared in disp.h, so this patch
add missing header dependencies
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/dispnv04/overlay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
index ec444ea..a79514d 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/overlay.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/overlay.c
@@ -33,7 +33,7 @@
#include "nouveau_connector.h"
#include "nouveau_display.h"
#include "nvreg.h"
-
+#include "disp.h"
struct nouveau_plane {
struct drm_plane base;
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [PATCH v2] drm/nouveau/gr/gf117-: mark symbols static where possible
We get 1 warning when build kernel with W=1:
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c:222:1: warning: no previous
prototype for 'gf117_grctx_generate_main' [-Wmissing-prototypes]
In fact, this function is only used in the file in which it is
declared and don't need a declaration, but can be made static.
so this patch marks this function with 'static'.
Signed-off-by: Baoyou Xie
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
index c925ade..74a64e3 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgf117.c
@@ -218,7 +218,7 @@ gf117_grctx_generate_attrib(struct gf100_grctx *info)
}
}
-void
+static void
gf117_grctx_generate_main(struct gf100_gr *gr, struct gf100_grctx *info)
{
struct nvkm_device *device = gr->base.engine.subdev.device;
--
2.7.4
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [PATCH v2] drm/nouveau/gr: mark gm107_grctx_generate_tpcid() static
On Mon, Aug 29, 2016 at 9:02 AM, Baoyou Xie wrote:
> We get 1 warning when build kernel with W=1:
> drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c:937:1: warning: no previous
> prototype for 'gm107_grctx_generate_tpcid' [-Wmissing-prototypes]
>
> In fact, this function is only used in the file in which it is
> declared and don't need a declaration, but can be made static.
> so this patch marks this function with 'static'.
>
It would make things a lot easier if you either consolidated all of
these static changes into one patch, or released them as a series.
Sean
> Signed-off-by: Baoyou Xie
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> index 6d3c501..4c4b5ab 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/gr/ctxgm107.c
> @@ -933,7 +933,7 @@ gm107_grctx_generate_attrib(struct gf100_grctx *info)
> }
> }
>
> -void
> +static void
> gm107_grctx_generate_tpcid(struct gf100_gr *gr)
> {
> struct nvkm_device *device = gr->base.engine.subdev.device;
> --
> 2.7.4
>
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 97021] Screen locks up randomly while only mouse pointer moves, system responsive via ssh
https://bugs.freedesktop.org/show_bug.cgi?id=97021 --- Comment #1 from Ali Parsai --- Created attachment 126143 --> https://bugs.freedesktop.org/attachment.cgi?id=126143&action=edit another complete dmesg I retrieved using ssh on another instance -- You are receiving this mail because: You are the assignee for the bug.___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 92306] GL Excess demo renders incorrectly on nv43
https://bugs.freedesktop.org/show_bug.cgi?id=92306 Andrew Randrianasulu changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #18 from Andrew Randrianasulu --- Fixed with mesa git, thanks Ilia! -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] [Bug 97462] Graphics deadlock "ILLEGAL_MTHD" in nouveau with mesa version 11.2.2 when visiting Google Maps with firefox 49.0b5
https://bugs.freedesktop.org/show_bug.cgi?id=97462 --- Comment #6 from wa...@mailbox.hu --- Sorry that I did not manage a proper install till today. Seems that things changed somewhat. Symptom is the same, but the message is now different. Now I have this: Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 000c [INVALID_BITFIELD] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0808 data 8585 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 000c [INVALID_BITFIELD] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 080c data 20010586 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 000c [INVALID_BITFIELD] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0810 data 0404 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 000c [INVALID_BITFIELD] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0814 data 2002035d Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 0004 [INVALID_VALUE] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 081c data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: fifo: PBDMA0: 0004 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 mthd 1618 data 0404 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 000c [INVALID_BITFIELD] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0820 data 8585 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: fifo: PBDMA0: 0004 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 mthd 0d74 data 0400 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 000d [BEGIN_END_ACTIVE] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 1618 data 0404 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: fifo: PBDMA0: 0004 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 mthd data Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 000d [BEGIN_END_ACTIVE] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 1614 data Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 000d [BEGIN_END_ACTIVE] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 1614 data Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 000c [INVALID_BITFIELD] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 1618 data 84b3 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed000 Compositor[5572]] subc 0 class 9297 mthd 0d78 data 0006 Aug 31 16:41:52 terra kernel: nouveau :01:00.0: gr: DATA_ERROR 00d2 [] ch 7 [007f9ed00
[Nouveau] [Bug 97462] Graphics deadlock "ILLEGAL_MTHD" in nouveau with mesa version 11.2.2 when visiting Google Maps with firefox 49.0b5
https://bugs.freedesktop.org/show_bug.cgi?id=97462 --- Comment #7 from wa...@mailbox.hu --- Please let me know if it would be better to attach logs next time instead of pasting them (for me it'd be more complicated to look inside them, even so that no "mime type" for files without extensions). -- You are receiving this mail because: You are the assignee for the bug.___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
