date:20210721

[Nouveau] [PATCH] drivers/gpu/drm/nouveau/dispnv50/headc57d.c: mark headc57d_olut() as static

2021-07-21 Thread zhaoxiao

Fixes the following W=1 kernel build warning(s):

drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous 
prototype for ‘headc57d_olut’ [-Wmissing-prototypes]
headc57d_olut(struct nv50_head *head, struct nv50_head_atom *asyh, int size)

And no header file define a prototype for this function, so we should
mark it as static.

Signed-off-by: zhaoxiao 
---
 drivers/gpu/drm/nouveau/dispnv50/headc57d.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/headc57d.c 
b/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
index fd51527b56b8..bdcfd240d61c 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
@@ -169,7 +169,7 @@ headc57d_olut_load(struct drm_color_lut *in, int size, void 
__iomem *mem)
writew(readw(mem - 4), mem + 4);
 }
 
-bool
+static bool
 headc57d_olut(struct nv50_head *head, struct nv50_head_atom *asyh, int size)
 {
if (size != 0 && size != 256 && size != 1024)
-- 
2.20.1



___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [PATCH] drivers/gpu/drm/nouveau/nouveau_bo: Remove a bunch of unused variables

2021-07-21 Thread zhaoxiao

Fixes the following W=1 kernel build warning(s):

drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’:
drivers/gpu/drm/nouveau/nouveau_bo.c:1245:17: warning: variable ‘dev’ set but 
not used [-Wunused-but-set-variable]
  struct device *dev;
 ^~~
drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_unpopulate’:
drivers/gpu/drm/nouveau/nouveau_bo.c:1268:17: warning: variable ‘dev’ set but 
not used [-Wunused-but-set-variable]
  struct device *dev;
 ^~~
Signed-off-by: zhaoxiao 
---
 drivers/gpu/drm/nouveau/nouveau_bo.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c 
b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 4f3a5357dd56..692d63d08b5a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -1242,7 +1242,7 @@ nouveau_ttm_tt_populate(struct ttm_device *bdev,
 {
struct ttm_tt *ttm_dma = (void *)ttm;
struct nouveau_drm *drm;
-   struct device *dev;
+
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
 
if (ttm_tt_is_populated(ttm))
@@ -1255,7 +1255,6 @@ nouveau_ttm_tt_populate(struct ttm_device *bdev,
}
 
drm = nouveau_bdev(bdev);
-   dev = drm->dev->dev;
 
return ttm_pool_alloc(>ttm.bdev.pool, ttm, ctx);
 }
@@ -1265,14 +1264,12 @@ nouveau_ttm_tt_unpopulate(struct ttm_device *bdev,
  struct ttm_tt *ttm)
 {
struct nouveau_drm *drm;
-   struct device *dev;
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
 
if (slave)
return;
 
drm = nouveau_bdev(bdev);
-   dev = drm->dev->dev;
 
return ttm_pool_free(>ttm.bdev.pool, ttm);
 }
-- 
2.20.1



___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

2021-07-21 Thread Ratchanan Srirattanamet

The call site of nouveau_dsm_pci_probe() uses single set of output
variables for all invocations. So, we must not write anything to them
until we think this is an NVIDIA device of interest. Otherwise, if we
are called with another device after the NVIDIA device, we'll clober the
result of the NVIDIA device.

In this case, if the other device doesn't have _PR3 resources, the
detection later would miss the presence of power resource support, and
the rest of the code will keep using Optimus DSM, breaking power
management for that machine. In particular, this fixes power management
of the NVIDIA card in Lenovo Legion 5-15ARH05... well, at least
partially. New error shows up, but this patch is correct in itself
anyway.

As a bonus, we'll also stop preventing _PR3 usage from the bridge for
unrelated devices, which is always nice, I guess.

As noted in commit ccfc2d5cdb024 ("drm/nouveau: Use generic helper to
check _PR3 presence"), care is taken to leave the _PR3 detection outside
of the optimus_func condition.

https://gitlab.freedesktop.org/drm/nouveau/-/issues/79

Fixes: ccfc2d5cdb024 ("drm/nouveau: Use generic helper to check _PR3
presence")
Signed-off-by: Ratchanan Srirattanamet 
---

Hello,

This is my first time submitting a Linux patch. I've done a
number of PR/MR workflows on GitHub or GitLab, but never done any
email-oriented development. So, please excuse me if I'm doing something
incorrectly.

 drivers/gpu/drm/nouveau/nouveau_acpi.c | 18 +-
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_acpi.c 
b/drivers/gpu/drm/nouveau/nouveau_acpi.c
index 7c15f6448428..c88bda3ac820 100644
--- a/drivers/gpu/drm/nouveau/nouveau_acpi.c
+++ b/drivers/gpu/drm/nouveau/nouveau_acpi.c
@@ -220,15 +220,6 @@ static void nouveau_dsm_pci_probe(struct pci_dev *pdev, 
acpi_handle *dhandle_out
int optimus_funcs;
struct pci_dev *parent_pdev;
 
-   *has_pr3 = false;
-   parent_pdev = pci_upstream_bridge(pdev);
-   if (parent_pdev) {
-   if (parent_pdev->bridge_d3)
-   *has_pr3 = pci_pr3_present(parent_pdev);
-   else
-   pci_d3cold_disable(pdev);
-   }
-
dhandle = ACPI_HANDLE(>dev);
if (!dhandle)
return;
@@ -249,6 +240,15 @@ static void nouveau_dsm_pci_probe(struct pci_dev *pdev, 
acpi_handle *dhandle_out
*has_opt = !!optimus_funcs;
*has_opt_flags = optimus_funcs & (1 << NOUVEAU_DSM_OPTIMUS_FLAGS);
 
+   *has_pr3 = false;
+   parent_pdev = pci_upstream_bridge(pdev);
+   if (parent_pdev) {
+   if (parent_pdev->bridge_d3)
+   *has_pr3 = pci_pr3_present(parent_pdev);
+   else
+   pci_d3cold_disable(pdev);
+   }
+
if (optimus_funcs) {
uint32_t result;
nouveau_optimus_dsm(dhandle, NOUVEAU_DSM_OPTIMUS_CAPS, 0,
-- 
2.25.1

___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [PATCH] drivers/gpu/drm/nouveau/nouveau_bo: Remove a bunch of unused variables

2021-07-21 Thread zhaoxiao

Fixes the following W=1 kernel build warning(s):

drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_populate’:
drivers/gpu/drm/nouveau/nouveau_bo.c:1245:17: warning: variable ‘dev’ set but 
not used [-Wunused-but-set-variable]
  struct device *dev;
 ^~~
drivers/gpu/drm/nouveau/nouveau_bo.c: In function ‘nouveau_ttm_tt_unpopulate’:
drivers/gpu/drm/nouveau/nouveau_bo.c:1268:17: warning: variable ‘dev’ set but 
not used [-Wunused-but-set-variable]
  struct device *dev;
 ^~~
Signed-off-by: zhaoxiao 
---
 drivers/gpu/drm/nouveau/nouveau_bo.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c 
b/drivers/gpu/drm/nouveau/nouveau_bo.c
index 4f3a5357dd56..692d63d08b5a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_bo.c
+++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
@@ -1242,7 +1242,7 @@ nouveau_ttm_tt_populate(struct ttm_device *bdev,
 {
struct ttm_tt *ttm_dma = (void *)ttm;
struct nouveau_drm *drm;
-   struct device *dev;
+
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
 
if (ttm_tt_is_populated(ttm))
@@ -1255,7 +1255,6 @@ nouveau_ttm_tt_populate(struct ttm_device *bdev,
}
 
drm = nouveau_bdev(bdev);
-   dev = drm->dev->dev;
 
return ttm_pool_alloc(>ttm.bdev.pool, ttm, ctx);
 }
@@ -1265,14 +1264,12 @@ nouveau_ttm_tt_unpopulate(struct ttm_device *bdev,
  struct ttm_tt *ttm)
 {
struct nouveau_drm *drm;
-   struct device *dev;
bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG);
 
if (slave)
return;
 
drm = nouveau_bdev(bdev);
-   dev = drm->dev->dev;
 
return ttm_pool_free(>ttm.bdev.pool, ttm);
 }
-- 
2.20.1



___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [PATCH] drivers/gpu/drm/nouveau/dispnv50/headc57d.c: mark headc57d_olut() as static

2021-07-21 Thread zhaoxiao

Fixes the following W=1 kernel build warning(s):

drivers/gpu/drm/nouveau/dispnv50/headc57d.c:173:1: warning: no previous 
prototype for ‘headc57d_olut’ [-Wmissing-prototypes]
headc57d_olut(struct nv50_head *head, struct nv50_head_atom *asyh, int size)

And no header file define a prototype for this function, so we should
mark it as static.

Signed-off-by: zhaoxiao 
---
 drivers/gpu/drm/nouveau/dispnv50/headc57d.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv50/headc57d.c 
b/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
index fd51527b56b8..bdcfd240d61c 100644
--- a/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
+++ b/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
@@ -169,7 +169,7 @@ headc57d_olut_load(struct drm_color_lut *in, int size, void 
__iomem *mem)
writew(readw(mem - 4), mem + 4);
 }
 
-bool
+static bool
 headc57d_olut(struct nv50_head *head, struct nv50_head_atom *asyh, int size)
 {
if (size != 0 && size != 256 && size != 1024)
-- 
2.20.1



___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

2021-07-21 Thread Sid Boyce


Excellent, thanks.
I could have done a git bisect from another box. I didn't think of it.
Regards
Sid.

On 21/07/2021 14:16, Karol Herbst wrote:

actually.. it was already found in this thread:
https://lore.kernel.org/lkml/YOC4uekpD7iA3xPi@Red/T/ fixes incoming.

On Wed, Jul 21, 2021 at 3:13 PM Karol Herbst  wrote:

fyi: I am able to reproduce it on my machine and will figure out
what's wrong. Thanks!

On Mon, Jul 19, 2021 at 10:53 PM Sid Boyce  wrote:

Also sent this to kernel mailing list.

I saw an earlier kernel mailing list post (week 8 - 15 July) that so far
hasn't made it into 5.14-rc.


GPU's are GeForce GTX 1650, and 2 with GeForce GTX 1050 Ti.

3 systems affected, nothing displayed during boot up. I use ssh from a
running system to look at dmesg output.

[Mon Jul 19 00:02:06 2021] hid-generic 0003:0CCD:0028.0004:
input,hidraw3: USB HID v1.00 Device [USB Audio] on usb-:05:00.3-4/input3
[Mon Jul 19 00:02:06 2021] usb 5-6: new full-speed USB device number 4
using xhci_hcd
[Mon Jul 19 00:02:06 2021] usb 5-6: config 1 has an invalid interface
number: 2 but max is 1
[Mon Jul 19 00:02:06 2021] usb 5-6: config 1 has no interface number 1
[Mon Jul 19 00:02:06 2021] usb 5-6: New USB device found, idVendor=0b05,
idProduct=18f3, bcdDevice= 1.00
[Mon Jul 19 00:02:06 2021] usb 5-6: New USB device strings: Mfr=1,
Product=2, SerialNumber=3
[Mon Jul 19 00:02:06 2021] usb 5-6: Product: AURA LED Controller
[Mon Jul 19 00:02:06 2021] usb 5-6: Manufacturer: AsusTek Computer Inc.
[Mon Jul 19 00:02:06 2021] usb 5-6: SerialNumber: 9876543210
[Mon Jul 19 00:02:06 2021] hid-generic 0003:0B05:18F3.0005:
hiddev96,hidraw4: USB HID v1.11 Device [AsusTek Computer Inc. AURA LED
Controller] on usb-:05:00.3-6/input2
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: VRAM: 4096 MiB
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: GART: 1048576 MiB
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: TMDS table version 2.0
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB version 4.0
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 00:
02000300 
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 01:
01000302 00020030
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 02:
04011380 
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 03:
08011382 00020030
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 04:
02022362 00020010
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB conn 00: 1030
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB conn 01: 0100
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB conn 02: 2261
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: failed to
initialise sync subsystem, -28
[Mon Jul 19 00:02:07 2021] nouveau :08:00.0: bus: MMIO write of
0002 FAULT at 13c154 [ PRIVRING ]
[Mon Jul 19 00:02:07 2021] nouveau: probe of :08:00.0 failed with
error -28
[Mon Jul 19 00:02:08 2021] EXT4-fs (sda2): mounted filesystem with
ordered data mode. Opts: (null). Quota mode: none.
[Mon Jul 19 00:02:08 2021] systemd-journald[286]: Received SIGTERM from
PID 1 (systemd).
[Mon Jul 19 00:02:09 2021] systemd[1]: systemd 248.3+suse.30.ge9a23d9e06
running in system mode. (+PAM +AUDIT +SELINUX +APPARMOR -IMA -SMACK
+SECCOMP +GCRYPT +GNUTLS +OPENSSL +ACL +BLKID +CURL +ELFUTILS +FIDO2
+IDN2 -IDN -IPTC +KMOD +LIBCRYPTSETUP +LIBFDISK +PCRE2 +PWQUALITY
+P11KIT +QRENCODE +BZIP2 +LZ4 +XZ +ZLIB +ZSTD -XKBCOMMON +UTMP +SYSVINIT
default-hierarchy=unified)
[Mon Jul 19 00:02:09 2021] systemd[1]: Detected architecture x86-64.
[Mon Jul 19 00:02:21 2021] systemd-sysv-generator[619]: SysV service
'/etc/init.d/vmware-USBArbitrator' lacks a native systemd unit file.
Automatically generating a unit file for compatibility. Please update
package to include a native systemd unit file, in order to make it more
safe and robust.
[Mon Jul 19 00:02:21 2021] systemd-sysv-generator[619]: SysV service
'/etc/init.d/webmin' lacks a native systemd unit file. Automatically
generating a unit file for compatibility. Please update package to
include a native systemd unit file, in order to make it more safe and
robust.
[Mon Jul 19 00:02:21 2021] systemd-sysv-generator[619]: SysV service
'/etc/init.d/vmware' lacks a native systemd unit file. Automatically
generating a unit file for compatibility. Please update package to
include a native systemd unit file, in order to make it more safe and
robust.
[Mon Jul 19 00:02:22 2021] systemd[1]: /etc/systemd/system/tmp.mount:
symlinks are not allowed for units of this type, rejecting.
[Mon Jul 19 00:02:23 2021] systemd[1]:
/usr/lib/systemd/system/netdata.service:14: PIDFile= references a path
below legacy directory /var/run/, updating /var/run/netdata/netdata.pid
â†’ /run/netdata/netdata.pid; please update the unit file accordingly.
[Mon Jul 19 00:02:23 2021] systemd[1]:
/usr/lib/systemd/system/plymouth-start.service:15: Unit configured to
use KillMode=none. This is unsafe, as

[Nouveau] [RESEND PATCH v6 08/14] drm/nouveau: Change debug checks to specifically target syslog

2021-07-21 Thread Sean Paul

From: Sean Paul 

Since the logs protected by these checks specifically target syslog,
use the new drm_debug_syslog_enabled() call to avoid triggering
these prints when only trace is enabled.

Signed-off-by: Sean Paul 
Link: 
https://patchwork.freedesktop.org/patch/msgid/20200608210505.48519-9-s...@poorly.run
 #v5

Changes in v5:
-Added to the set
Changes in v6:
-Rebased on drm-tip, changes in dispnv50/disp.h were rebased out
---
 drivers/gpu/drm/nouveau/nouveau_drv.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h 
b/drivers/gpu/drm/nouveau/nouveau_drv.h
index ba65f136cf48..2caa5720f451 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drv.h
+++ b/drivers/gpu/drm/nouveau/nouveau_drv.h
@@ -260,11 +260,11 @@ void nouveau_drm_device_remove(struct drm_device *dev);
 #define NV_INFO(drm,f,a...) NV_PRINTK(info, &(drm)->client, f, ##a)
 
 #define NV_DEBUG(drm,f,a...) do {  
\
-   if (drm_debug_enabled(DRM_UT_DRIVER))  \
+   if (drm_debug_syslog_enabled(DRM_UT_DRIVER))
  \
NV_PRINTK(info, &(drm)->client, f, ##a);   \
 } while(0)
 #define NV_ATOMIC(drm,f,a...) do { 
\
-   if (drm_debug_enabled(DRM_UT_ATOMIC))  \
+   if (drm_debug_syslog_enabled(DRM_UT_ATOMIC))
  \
NV_PRINTK(info, &(drm)->client, f, ##a);   \
 } while(0)
 
-- 
Sean Paul, Software Engineer, Google / Chromium OS

___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

2021-07-21 Thread Karol Herbst

actually.. it was already found in this thread:
https://lore.kernel.org/lkml/YOC4uekpD7iA3xPi@Red/T/ fixes incoming.

On Wed, Jul 21, 2021 at 3:13 PM Karol Herbst  wrote:
>
> fyi: I am able to reproduce it on my machine and will figure out
> what's wrong. Thanks!
>
> On Mon, Jul 19, 2021 at 10:53 PM Sid Boyce  wrote:
> >
> > Also sent this to kernel mailing list.
> >
> > I saw an earlier kernel mailing list post (week 8 - 15 July) that so far
> > hasn't made it into 5.14-rc.
> >
> >
> > GPU's are GeForce GTX 1650, and 2 with GeForce GTX 1050 Ti.
> >
> > 3 systems affected, nothing displayed during boot up. I use ssh from a
> > running system to look at dmesg output.
> >
> > [Mon Jul 19 00:02:06 2021] hid-generic 0003:0CCD:0028.0004:
> > input,hidraw3: USB HID v1.00 Device [USB Audio] on usb-:05:00.3-4/input3
> > [Mon Jul 19 00:02:06 2021] usb 5-6: new full-speed USB device number 4
> > using xhci_hcd
> > [Mon Jul 19 00:02:06 2021] usb 5-6: config 1 has an invalid interface
> > number: 2 but max is 1
> > [Mon Jul 19 00:02:06 2021] usb 5-6: config 1 has no interface number 1
> > [Mon Jul 19 00:02:06 2021] usb 5-6: New USB device found, idVendor=0b05,
> > idProduct=18f3, bcdDevice= 1.00
> > [Mon Jul 19 00:02:06 2021] usb 5-6: New USB device strings: Mfr=1,
> > Product=2, SerialNumber=3
> > [Mon Jul 19 00:02:06 2021] usb 5-6: Product: AURA LED Controller
> > [Mon Jul 19 00:02:06 2021] usb 5-6: Manufacturer: AsusTek Computer Inc.
> > [Mon Jul 19 00:02:06 2021] usb 5-6: SerialNumber: 9876543210
> > [Mon Jul 19 00:02:06 2021] hid-generic 0003:0B05:18F3.0005:
> > hiddev96,hidraw4: USB HID v1.11 Device [AsusTek Computer Inc. AURA LED
> > Controller] on usb-:05:00.3-6/input2
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: VRAM: 4096 MiB
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: GART: 1048576 MiB
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: TMDS table version 2.0
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB version 4.0
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 00:
> > 02000300 
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 01:
> > 01000302 00020030
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 02:
> > 04011380 
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 03:
> > 08011382 00020030
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 04:
> > 02022362 00020010
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB conn 00: 1030
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB conn 01: 0100
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB conn 02: 2261
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: failed to
> > initialise sync subsystem, -28
> > [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: bus: MMIO write of
> > 0002 FAULT at 13c154 [ PRIVRING ]
> > [Mon Jul 19 00:02:07 2021] nouveau: probe of :08:00.0 failed with
> > error -28
> > [Mon Jul 19 00:02:08 2021] EXT4-fs (sda2): mounted filesystem with
> > ordered data mode. Opts: (null). Quota mode: none.
> > [Mon Jul 19 00:02:08 2021] systemd-journald[286]: Received SIGTERM from
> > PID 1 (systemd).
> > [Mon Jul 19 00:02:09 2021] systemd[1]: systemd 248.3+suse.30.ge9a23d9e06
> > running in system mode. (+PAM +AUDIT +SELINUX +APPARMOR -IMA -SMACK
> > +SECCOMP +GCRYPT +GNUTLS +OPENSSL +ACL +BLKID +CURL +ELFUTILS +FIDO2
> > +IDN2 -IDN -IPTC +KMOD +LIBCRYPTSETUP +LIBFDISK +PCRE2 +PWQUALITY
> > +P11KIT +QRENCODE +BZIP2 +LZ4 +XZ +ZLIB +ZSTD -XKBCOMMON +UTMP +SYSVINIT
> > default-hierarchy=unified)
> > [Mon Jul 19 00:02:09 2021] systemd[1]: Detected architecture x86-64.
> > [Mon Jul 19 00:02:21 2021] systemd-sysv-generator[619]: SysV service
> > '/etc/init.d/vmware-USBArbitrator' lacks a native systemd unit file.
> > Automatically generating a unit file for compatibility. Please update
> > package to include a native systemd unit file, in order to make it more
> > safe and robust.
> > [Mon Jul 19 00:02:21 2021] systemd-sysv-generator[619]: SysV service
> > '/etc/init.d/webmin' lacks a native systemd unit file. Automatically
> > generating a unit file for compatibility. Please update package to
> > include a native systemd unit file, in order to make it more safe and
> > robust.
> > [Mon Jul 19 00:02:21 2021] systemd-sysv-generator[619]: SysV service
> > '/etc/init.d/vmware' lacks a native systemd unit file. Automatically
> > generating a unit file for compatibility. Please update package to
> > include a native systemd unit file, in order to make it more safe and
> > robust.
> > [Mon Jul 19 00:02:22 2021] systemd[1]: /etc/systemd/system/tmp.mount:
> > symlinks are not allowed for units of this type, rejecting.
> > [Mon Jul 19 00:02:23 2021] systemd[1]:
> > /usr/lib/systemd/system/netdata.service:14: PIDFile= references a path
> > below legacy directory /var/run/, updating /var/run/netdata/netdata.pid
> > → /run/netdata/netdata.pid;

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

2021-07-21 Thread Karol Herbst

fyi: I am able to reproduce it on my machine and will figure out
what's wrong. Thanks!

On Mon, Jul 19, 2021 at 10:53 PM Sid Boyce  wrote:
>
> Also sent this to kernel mailing list.
>
> I saw an earlier kernel mailing list post (week 8 - 15 July) that so far
> hasn't made it into 5.14-rc.
>
>
> GPU's are GeForce GTX 1650, and 2 with GeForce GTX 1050 Ti.
>
> 3 systems affected, nothing displayed during boot up. I use ssh from a
> running system to look at dmesg output.
>
> [Mon Jul 19 00:02:06 2021] hid-generic 0003:0CCD:0028.0004:
> input,hidraw3: USB HID v1.00 Device [USB Audio] on usb-:05:00.3-4/input3
> [Mon Jul 19 00:02:06 2021] usb 5-6: new full-speed USB device number 4
> using xhci_hcd
> [Mon Jul 19 00:02:06 2021] usb 5-6: config 1 has an invalid interface
> number: 2 but max is 1
> [Mon Jul 19 00:02:06 2021] usb 5-6: config 1 has no interface number 1
> [Mon Jul 19 00:02:06 2021] usb 5-6: New USB device found, idVendor=0b05,
> idProduct=18f3, bcdDevice= 1.00
> [Mon Jul 19 00:02:06 2021] usb 5-6: New USB device strings: Mfr=1,
> Product=2, SerialNumber=3
> [Mon Jul 19 00:02:06 2021] usb 5-6: Product: AURA LED Controller
> [Mon Jul 19 00:02:06 2021] usb 5-6: Manufacturer: AsusTek Computer Inc.
> [Mon Jul 19 00:02:06 2021] usb 5-6: SerialNumber: 9876543210
> [Mon Jul 19 00:02:06 2021] hid-generic 0003:0B05:18F3.0005:
> hiddev96,hidraw4: USB HID v1.11 Device [AsusTek Computer Inc. AURA LED
> Controller] on usb-:05:00.3-6/input2
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: VRAM: 4096 MiB
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: GART: 1048576 MiB
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: TMDS table version 2.0
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB version 4.0
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 00:
> 02000300 
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 01:
> 01000302 00020030
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 02:
> 04011380 
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 03:
> 08011382 00020030
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB outp 04:
> 02022362 00020010
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB conn 00: 1030
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB conn 01: 0100
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: DCB conn 02: 2261
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: DRM: failed to
> initialise sync subsystem, -28
> [Mon Jul 19 00:02:07 2021] nouveau :08:00.0: bus: MMIO write of
> 0002 FAULT at 13c154 [ PRIVRING ]
> [Mon Jul 19 00:02:07 2021] nouveau: probe of :08:00.0 failed with
> error -28
> [Mon Jul 19 00:02:08 2021] EXT4-fs (sda2): mounted filesystem with
> ordered data mode. Opts: (null). Quota mode: none.
> [Mon Jul 19 00:02:08 2021] systemd-journald[286]: Received SIGTERM from
> PID 1 (systemd).
> [Mon Jul 19 00:02:09 2021] systemd[1]: systemd 248.3+suse.30.ge9a23d9e06
> running in system mode. (+PAM +AUDIT +SELINUX +APPARMOR -IMA -SMACK
> +SECCOMP +GCRYPT +GNUTLS +OPENSSL +ACL +BLKID +CURL +ELFUTILS +FIDO2
> +IDN2 -IDN -IPTC +KMOD +LIBCRYPTSETUP +LIBFDISK +PCRE2 +PWQUALITY
> +P11KIT +QRENCODE +BZIP2 +LZ4 +XZ +ZLIB +ZSTD -XKBCOMMON +UTMP +SYSVINIT
> default-hierarchy=unified)
> [Mon Jul 19 00:02:09 2021] systemd[1]: Detected architecture x86-64.
> [Mon Jul 19 00:02:21 2021] systemd-sysv-generator[619]: SysV service
> '/etc/init.d/vmware-USBArbitrator' lacks a native systemd unit file.
> Automatically generating a unit file for compatibility. Please update
> package to include a native systemd unit file, in order to make it more
> safe and robust.
> [Mon Jul 19 00:02:21 2021] systemd-sysv-generator[619]: SysV service
> '/etc/init.d/webmin' lacks a native systemd unit file. Automatically
> generating a unit file for compatibility. Please update package to
> include a native systemd unit file, in order to make it more safe and
> robust.
> [Mon Jul 19 00:02:21 2021] systemd-sysv-generator[619]: SysV service
> '/etc/init.d/vmware' lacks a native systemd unit file. Automatically
> generating a unit file for compatibility. Please update package to
> include a native systemd unit file, in order to make it more safe and
> robust.
> [Mon Jul 19 00:02:22 2021] systemd[1]: /etc/systemd/system/tmp.mount:
> symlinks are not allowed for units of this type, rejecting.
> [Mon Jul 19 00:02:23 2021] systemd[1]:
> /usr/lib/systemd/system/netdata.service:14: PIDFile= references a path
> below legacy directory /var/run/, updating /var/run/netdata/netdata.pid
> → /run/netdata/netdata.pid; please update the unit file accordingly.
> [Mon Jul 19 00:02:23 2021] systemd[1]:
> /usr/lib/systemd/system/plymouth-start.service:15: Unit configured to
> use KillMode=none. This is unsafe, as it disables systemd's process
> lifecycle management for the service. Please update your service to use
> a safer KillMode=, such as 'mixed' or

Re: [Nouveau] [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE

2021-07-21 Thread Christian König




Am 20.07.21 um 15:50 schrieb Daniel Vetter:

On Fri, Jul 16, 2021 at 09:14:02AM +0200, Christian König wrote:

Am 16.07.21 um 08:16 schrieb Christoph Hellwig:

The define is entirely unused.

Signed-off-by: Christoph Hellwig 

I'm not an expert for this particular code, but at least of hand everything
you do here makes totally sense.

Whole series is Acked-by: Christian König 

Care to also push this into drm-misc-next since you looked already?


Done.

Christian.


-Daniel


Regards,
Christian.


---
   include/linux/vgaarb.h | 6 --
   1 file changed, 6 deletions(-)

diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h
index dc6ddce92066..26ec8a057d2a 100644
--- a/include/linux/vgaarb.h
+++ b/include/linux/vgaarb.h
@@ -42,12 +42,6 @@
   #define VGA_RSRC_NORMAL_IO 0x04
   #define VGA_RSRC_NORMAL_MEM0x08
-/* Passing that instead of a pci_dev to use the system "default"
- * device, that is the one used by vgacon. Archs will probably
- * have to provide their own vga_default_device();
- */
-#define VGA_DEFAULT_DEVICE (NULL)
-
   struct pci_dev;
   /* For use by clients */


___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

[Nouveau] [PATCH] drivers/gpu/drm/nouveau/dispnv50/headc57d.c: mark headc57d_olut() as static

[Nouveau] [PATCH] drivers/gpu/drm/nouveau/nouveau_bo: Remove a bunch of unused variables

[Nouveau] [PATCH] drm/nouveau: don't touch has_pr3 for likely-non-NVIDIA device

[Nouveau] [PATCH] drivers/gpu/drm/nouveau/nouveau_bo: Remove a bunch of unused variables

[Nouveau] [PATCH] drivers/gpu/drm/nouveau/dispnv50/headc57d.c: mark headc57d_olut() as static

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

[Nouveau] [RESEND PATCH v6 08/14] drm/nouveau: Change debug checks to specifically target syslog

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

Re: [Nouveau] nouveau failure 5.14-rc1 and -rc2

Re: [Nouveau] [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE

10 matches

Site Navigation

Mail list logo

Footer information