Re: [Nouveau] [PATCH v2 2/9] iommu: Add dummy dev_iommu_fwspec_get() helper
Hi Thierry,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.4-rc5 next-20191031]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Thierry-Reding/drm-nouveau-Various-fixes-for-GP10B/20191103-125101
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
56cfd2507d3e720f4b1dbf9513e00680516a0826
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
In file included from arch/x86/kernel/pci-dma.c:4:0:
>> include/linux/iommu.h:615:8: error: redefinition of 'struct iommu_fwspec'
struct iommu_fwspec {};
^~~~
In file included from include/linux/dma-mapping.h:7:0,
from include/linux/dma-direct.h:5,
from arch/x86/kernel/pci-dma.c:2:
include/linux/device.h:43:8: note: originally defined here
struct iommu_fwspec;
^~~~
vim +615 include/linux/iommu.h
4a77a6cf6d9bf9 Joerg Roedel2008-11-26 612
39d4ebb9592504 Joerg Roedel2011-09-06 613 struct iommu_ops {};
d72e31c9374627 Alex Williamson 2012-05-30 614 struct iommu_group {};
57f98d2f61e191 Robin Murphy2016-09-13 @615 struct iommu_fwspec {};
b0119e870837dc Joerg Roedel2017-02-01 616 struct iommu_device {};
4e32348ba5269a Jacob Pan 2019-06-03 617 struct iommu_fault_param {};
a7d20dc19d9ea7 Will Deacon 2019-07-02 618 struct iommu_iotlb_gather {};
4a77a6cf6d9bf9 Joerg Roedel2008-11-26 619
:: The code at line 615 was first introduced by commit
:: 57f98d2f61e191ef9d06863c9ce3f8621f3671ef iommu: Introduce iommu_fwspec
:: TO: Robin Murphy
:: CC: Will Deacon
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [PATCH 1/2] drm/nouveau: Disable atomic support on a per-device basis
Hi Ville,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.19-rc3 next-20180913]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-nouveau-Disable-atomic-support-on-a-per-device-basis/20180914-111059
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/gpu/drm/nouveau/dispnv04/disp.c: In function 'nv04_display_create':
>> drivers/gpu/drm/nouveau/dispnv04/disp.c:59:5: error: 'struct drm_device' has
>> no member named 'driver_features'
dev->driver_features &= ~DRIVER_ATOMIC;
^~
vim +59 drivers/gpu/drm/nouveau/dispnv04/disp.c
33
34 int
35 nv04_display_create(struct drm_device *dev)
36 {
37 struct nouveau_drm *drm = nouveau_drm(dev);
38 struct nvkm_i2c *i2c = nvxx_i2c(>client.device);
39 struct dcb_table *dcb = >vbios.dcb;
40 struct drm_connector *connector, *ct;
41 struct drm_encoder *encoder;
42 struct nouveau_encoder *nv_encoder;
43 struct nouveau_crtc *crtc;
44 struct nv04_display *disp;
45 int i, ret;
46
47 disp = kzalloc(sizeof(*disp), GFP_KERNEL);
48 if (!disp)
49 return -ENOMEM;
50
51 nvif_object_map(>client.device.object, NULL, 0);
52
53 nouveau_display(dev)->priv = disp;
54 nouveau_display(dev)->dtor = nv04_display_destroy;
55 nouveau_display(dev)->init = nv04_display_init;
56 nouveau_display(dev)->fini = nv04_display_fini;
57
58 /* Pre-nv50 doesn't support atomic, so don't expose the ioctls
*/
> 59 dev->driver_features &= ~DRIVER_ATOMIC;
60
61 nouveau_hw_save_vga_fonts(dev, 1);
62
63 nv04_crtc_create(dev, 0);
64 if (nv_two_heads(dev))
65 nv04_crtc_create(dev, 1);
66
67 for (i = 0; i < dcb->entries; i++) {
68 struct dcb_output *dcbent = >entry[i];
69
70 connector = nouveau_connector_create(dev,
dcbent->connector);
71 if (IS_ERR(connector))
72 continue;
73
74 switch (dcbent->type) {
75 case DCB_OUTPUT_ANALOG:
76 ret = nv04_dac_create(connector, dcbent);
77 break;
78 case DCB_OUTPUT_LVDS:
79 case DCB_OUTPUT_TMDS:
80 ret = nv04_dfp_create(connector, dcbent);
81 break;
82 case DCB_OUTPUT_TV:
83 if (dcbent->location == DCB_LOC_ON_CHIP)
84 ret = nv17_tv_create(connector, dcbent);
85 else
86 ret = nv04_tv_create(connector, dcbent);
87 break;
88 default:
89 NV_WARN(drm, "DCB type %d not known\n",
dcbent->type);
90 continue;
91 }
92
93 if (ret)
94 continue;
95 }
96
97 list_for_each_entry_safe(connector, ct,
98 >mode_config.connector_list,
head) {
99 if (!connector->encoder_ids[0]) {
100 NV_WARN(drm, "%s has no encoders, removing\n",
101 connector->name);
102 connector->funcs->destroy(connector);
103 }
104 }
105
106 list_for_each_entry(encoder, >mode_config.encoder_list,
head) {
107 struct nouveau_encoder *nv_encoder =
nouveau_encoder(encoder);
108 struct nvkm_i2c_bus *bus =
109 nvkm_i2c_bus_find(i2c,
nv_encoder->dcb->i2c_index);
110 nv_encoder->i2c = bus ? >i2c : NULL;
111 }
112
113 /* Save previous state */
114 list_for_each_entry(crtc, >mode_config.crtc_list,
base.head)
115 crtc->save(>base);
116
117 list_for_each_entry(nv_encoder, >mode_config.encoder_list,
base.base.head)
118 nv_encoder->enc_save(_encoder->base.base);
119
120 nouveau_overlay_init(dev);
121
122 return 0;
123 }
124
---
0-DAY kernel test infrastructureOpen Source Technology
Re: [Nouveau] [PATCH] PCI: add prefetch quirk to work around Asus/Nvidia suspend issues
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pci/next]
[also build test WARNING on v4.19-rc2 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Daniel-Drake/PCI-add-prefetch-quirk-to-work-around-Asus-Nvidia-suspend-issues/20180901-043245
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-s5-09031857 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
:: branch date: 3 days ago
:: commit date: 3 days ago
All warnings (new ones prefixed by >>):
In file included from include/linux/export.h:45:0,
from include/linux/linkage.h:7,
from include/linux/kernel.h:7,
from drivers/pci/quirks.c:16:
drivers/pci/quirks.c: In function 'quirk_asus_pci_prefetch':
drivers/pci/quirks.c:5134:6: warning: argument 1 null where non-null
expected [-Wnonnull]
if (strcmp(sys_vendor, "ASUSTeK COMPUTER INC.") != 0)
^~~
include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/pci/quirks.c:5134:2: note: in expansion of macro 'if'
if (strcmp(sys_vendor, "ASUSTeK COMPUTER INC.") != 0)
^~
In file included from include/linux/uuid.h:20:0,
from include/linux/mod_devicetable.h:13,
from include/linux/pci.h:21,
from drivers/pci/quirks.c:18:
include/linux/string.h:44:12: note: in a call to function 'strcmp' declared
here
extern int strcmp(const char *,const char *);
^~
#
https://github.com/0day-ci/linux/commit/eccd2a8c40e1a705a666e6fe1c52aca3f2130984
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout eccd2a8c40e1a705a666e6fe1c52aca3f2130984
vim +/if +5134 drivers/pci/quirks.c
e7aaf90f9 Bjorn Helgaas 2018-08-15 4983
e7aaf90f9 Bjorn Helgaas 2018-08-15 4984 /*
ad281ecf1 Doug Meyer2018-05-23 4985 * Microsemi Switchtec NTB uses devfn
proxy IDs to move TLPs between
ad281ecf1 Doug Meyer2018-05-23 4986 * NT endpoints via the internal
switch fabric. These IDs replace the
ad281ecf1 Doug Meyer2018-05-23 4987 * originating requestor ID TLPs
which access host memory on peer NTB
ad281ecf1 Doug Meyer2018-05-23 4988 * ports. Therefore, all proxy IDs
must be aliased to the NTB device
ad281ecf1 Doug Meyer2018-05-23 4989 * to permit access when the IOMMU is
turned on.
ad281ecf1 Doug Meyer2018-05-23 4990 */
ad281ecf1 Doug Meyer2018-05-23 4991 static void
quirk_switchtec_ntb_dma_alias(struct pci_dev *pdev)
ad281ecf1 Doug Meyer2018-05-23 4992 {
ad281ecf1 Doug Meyer2018-05-23 4993void __iomem *mmio;
ad281ecf1 Doug Meyer2018-05-23 4994struct ntb_info_regs __iomem
*mmio_ntb;
ad281ecf1 Doug Meyer2018-05-23 4995struct ntb_ctrl_regs __iomem
*mmio_ctrl;
ad281ecf1 Doug Meyer2018-05-23 4996struct sys_info_regs __iomem
*mmio_sys_info;
ad281ecf1 Doug Meyer2018-05-23 4997u64 partition_map;
ad281ecf1 Doug Meyer2018-05-23 4998u8 partition;
ad281ecf1 Doug Meyer2018-05-23 4999int pp;
ad281ecf1 Doug Meyer2018-05-23 5000
ad281ecf1 Doug Meyer2018-05-23 5001if (pci_enable_device(pdev)) {
ad281ecf1 Doug Meyer2018-05-23 5002pci_err(pdev, "Cannot
enable Switchtec device\n");
ad281ecf1 Doug Meyer2018-05-23 5003return;
ad281ecf1 Doug Meyer2018-05-23 5004}
ad281ecf1 Doug Meyer2018-05-23 5005
ad281ecf1 Doug Meyer2018-05-23 5006mmio = pci_iomap(pdev, 0, 0);
ad281ecf1 Doug Meyer2018-05-23 5007if (mmio == NULL) {
ad281ecf1 Doug Meyer2018-05-23 5008
pci_disable_device(pdev);
ad281ecf1 Doug Meyer2018-05-23 5009pci_err(pdev, "Cannot
iomap Switchtec device\n");
ad281ecf1 Doug Meyer2018-05-23 5010return;
ad281ecf1 Doug Meyer2018-05-23 5011}
ad281ecf1 Doug Meyer2018-05-23 5012
ad281ecf1 Doug Meyer2018-05-23 5013pci_info(pdev, "Setting
Switchtec proxy ID aliases\n");
ad281ecf1 Doug Meyer2018-05-23 5014
ad281ecf1 Doug Meyer2018-05-23 5015mmio_ntb = mmio +
SWITCHTEC_GAS_NTB_OFFSET;
ad281ecf1 Doug Meyer2018-05-23 5016mmio_ctrl = (void __iomem *)
mmio_ntb + SWITCHTEC_NTB_REG_CTRL_OFFSET;
ad281ecf1 Doug Meyer2018-05-23 5017mmio_sys_info = mmio +
SWITCHTEC_GAS_SYS_INFO_OFFSET;
ad281ecf1 Doug Meyer2018-05-23 5018
ad281ecf1 Doug Meyer2018-05-23 5019partition =
Re: [Nouveau] [PATCH] PCI: add prefetch quirk to work around Asus/Nvidia suspend issues
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on pci/next]
[also build test WARNING on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Daniel-Drake/PCI-add-prefetch-quirk-to-work-around-Asus-Nvidia-suspend-issues/20180901-043245
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: x86_64-randconfig-x000-201834 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
drivers/pci/quirks.c: In function 'quirk_asus_pci_prefetch':
>> drivers/pci/quirks.c:5134:6: warning: argument 1 null where non-null
>> expected [-Wnonnull]
if (strcmp(sys_vendor, "ASUSTeK COMPUTER INC.") != 0)
^~~
In file included from include/linux/uuid.h:20:0,
from include/linux/mod_devicetable.h:13,
from include/linux/pci.h:21,
from drivers/pci/quirks.c:18:
include/linux/string.h:44:12: note: in a call to function 'strcmp' declared
here
extern int strcmp(const char *,const char *);
^~
vim +5134 drivers/pci/quirks.c
4983
4984 /*
4985 * Microsemi Switchtec NTB uses devfn proxy IDs to move TLPs between
4986 * NT endpoints via the internal switch fabric. These IDs replace the
4987 * originating requestor ID TLPs which access host memory on peer NTB
4988 * ports. Therefore, all proxy IDs must be aliased to the NTB device
4989 * to permit access when the IOMMU is turned on.
4990 */
4991 static void quirk_switchtec_ntb_dma_alias(struct pci_dev *pdev)
4992 {
4993 void __iomem *mmio;
4994 struct ntb_info_regs __iomem *mmio_ntb;
4995 struct ntb_ctrl_regs __iomem *mmio_ctrl;
4996 struct sys_info_regs __iomem *mmio_sys_info;
4997 u64 partition_map;
4998 u8 partition;
4999 int pp;
5000
5001 if (pci_enable_device(pdev)) {
5002 pci_err(pdev, "Cannot enable Switchtec device\n");
5003 return;
5004 }
5005
5006 mmio = pci_iomap(pdev, 0, 0);
5007 if (mmio == NULL) {
5008 pci_disable_device(pdev);
5009 pci_err(pdev, "Cannot iomap Switchtec device\n");
5010 return;
5011 }
5012
5013 pci_info(pdev, "Setting Switchtec proxy ID aliases\n");
5014
5015 mmio_ntb = mmio + SWITCHTEC_GAS_NTB_OFFSET;
5016 mmio_ctrl = (void __iomem *) mmio_ntb +
SWITCHTEC_NTB_REG_CTRL_OFFSET;
5017 mmio_sys_info = mmio + SWITCHTEC_GAS_SYS_INFO_OFFSET;
5018
5019 partition = ioread8(_ntb->partition_id);
5020
5021 partition_map = ioread32(_ntb->ep_map);
5022 partition_map |= ((u64) ioread32(_ntb->ep_map + 4)) << 32;
5023 partition_map &= ~(1ULL << partition);
5024
5025 for (pp = 0; pp < (sizeof(partition_map) * 8); pp++) {
5026 struct ntb_ctrl_regs __iomem *mmio_peer_ctrl;
5027 u32 table_sz = 0;
5028 int te;
5029
5030 if (!(partition_map & (1ULL << pp)))
5031 continue;
5032
5033 pci_dbg(pdev, "Processing partition %d\n", pp);
5034
5035 mmio_peer_ctrl = _ctrl[pp];
5036
5037 table_sz = ioread16(_peer_ctrl->req_id_table_size);
5038 if (!table_sz) {
5039 pci_warn(pdev, "Partition %d table_sz 0\n", pp);
5040 continue;
5041 }
5042
5043 if (table_sz > 512) {
5044 pci_warn(pdev,
5045 "Invalid Switchtec partition %d
table_sz %d\n",
5046 pp, table_sz);
5047 continue;
5048 }
5049
5050 for (te = 0; te < table_sz; te++) {
5051 u32 rid_entry;
5052 u8 devfn;
5053
5054 rid_entry =
ioread32(_peer_ctrl->req_id_table[te]);
5055 devfn = (rid_entry >> 1) & 0xFF;
5056 pci_dbg(pdev,
5057 "Aliasing Partition %d Proxy ID
%02x.%d\n",
5058 pp, PCI_SLOT(devfn), PCI_FUNC(devfn));
5059 pci_add_dma_alias(pdev, devfn);
5060 }
5061 }
5062
5063 pci_iounmap(pdev, mmio);
5064 pci_disable_device(pdev);
5065 }
5066
Re: [Nouveau] [Intel-gfx] [PATCH 2/4] drm/dp_mst: Pass entire connector to drm_dp_mst_topology_mgr_init()
Hi Lyude, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.19-rc1 next-20180828] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lyude-Paul/drm-dp_mst-Add-DP-MST-debugfs-nodes-for-all-drivers/20180828-083742 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:977: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' include/linux/mod_devicetable.h:763: warning: Function parameter or member 'driver_data' not described in 'typec_device_id' kernel/sched/fair.c:3371: warning: Function parameter or member 'flags' not described in 'attach_entity_load_avg' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'i' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:84: warning: Excess function parameter 'v' description in 'arch_atomic_sub_and_test' arch/x86/include/asm/atomic.h:96: warning: Excess function parameter 'v' description in 'arch_atomic_inc' arch/x86/include/asm/atomic.h:109: warning: Excess function parameter 'v' description in 'arch_atomic_dec' arch/x86/include/asm/atomic.h:124: warning: Excess function parameter 'v' description in
Re: [Nouveau] [PATCH v3 3/8] drm/fb_helper: Introduce hotplug_suspend/resume()
Hi Lyude, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.18-rc7] [cannot apply to next-20180731] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Lyude-Paul/Fix-connector-probing-deadlocks-from-RPM-bugs/20180801-153816 reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) mm/mempool.c:228: warning: Function parameter or member 'pool' not described in 'mempool_init' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4279: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2282: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2282: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:955: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:955: warning: Function parameter or member 'pad' not described
Re: [Nouveau] [PATCH] drm/nouveau: Fix potential memory access error in nouveau_debugfs_pstate_get()
Hi Lyude,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.18-rc7 next-20180731]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Lyude-Paul/drm-nouveau-Fix-potential-memory-access-error-in-nouveau_debugfs_pstate_get/20180801-155246
config: i386-randconfig-a1-201830 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/gpu//drm/nouveau/nouveau_debugfs.c: In function
'nouveau_debugfs_pstate_get':
>> drivers/gpu//drm/nouveau/nouveau_debugfs.c:54:22: warning: 'debugfs' is used
>> uninitialized in this function [-Wuninitialized]
struct nvif_object *ctrl = >ctrl;
^
vim +/debugfs +54 drivers/gpu//drm/nouveau/nouveau_debugfs.c
33b903e8 Marcin Slusarz 2013-02-08 48
6e9fc177 Karol Herbst 2015-07-30 49 static int
6e9fc177 Karol Herbst 2015-07-30 50 nouveau_debugfs_pstate_get(struct
seq_file *m, void *data)
6e9fc177 Karol Herbst 2015-07-30 51 {
1a54082a Noralf Trønnes 2017-01-26 52 struct drm_device *drm =
m->private;
11a2501e Lyude Paul 2018-07-30 53 struct nouveau_debugfs *debugfs;
6e9fc177 Karol Herbst 2015-07-30 @54 struct nvif_object *ctrl =
>ctrl;
6e9fc177 Karol Herbst 2015-07-30 55 struct
nvif_control_pstate_info_v0 info = {};
6e9fc177 Karol Herbst 2015-07-30 56 int ret, i;
6e9fc177 Karol Herbst 2015-07-30 57
11a2501e Lyude Paul 2018-07-30 58 if (!drm)
6e9fc177 Karol Herbst 2015-07-30 59 return -ENODEV;
11a2501e Lyude Paul 2018-07-30 60 debugfs = nouveau_debugfs(drm);
6e9fc177 Karol Herbst 2015-07-30 61
6e9fc177 Karol Herbst 2015-07-30 62 ret = nvif_mthd(ctrl,
NVIF_CONTROL_PSTATE_INFO, , sizeof(info));
6e9fc177 Karol Herbst 2015-07-30 63 if (ret)
6e9fc177 Karol Herbst 2015-07-30 64 return ret;
6e9fc177 Karol Herbst 2015-07-30 65
6e9fc177 Karol Herbst 2015-07-30 66 for (i = 0; i < info.count + 1;
i++) {
6e9fc177 Karol Herbst 2015-07-30 67 const s32 state = i <
info.count ? i :
6e9fc177 Karol Herbst 2015-07-30 68
NVIF_CONTROL_PSTATE_ATTR_V0_STATE_CURRENT;
6e9fc177 Karol Herbst 2015-07-30 69 struct
nvif_control_pstate_attr_v0 attr = {
6e9fc177 Karol Herbst 2015-07-30 70 .state = state,
6e9fc177 Karol Herbst 2015-07-30 71 .index = 0,
6e9fc177 Karol Herbst 2015-07-30 72 };
6e9fc177 Karol Herbst 2015-07-30 73
6e9fc177 Karol Herbst 2015-07-30 74 ret = nvif_mthd(ctrl,
NVIF_CONTROL_PSTATE_ATTR,
6e9fc177 Karol Herbst 2015-07-30 75 ,
sizeof(attr));
6e9fc177 Karol Herbst 2015-07-30 76 if (ret)
6e9fc177 Karol Herbst 2015-07-30 77 return ret;
6e9fc177 Karol Herbst 2015-07-30 78
6e9fc177 Karol Herbst 2015-07-30 79 if (i < info.count)
6e9fc177 Karol Herbst 2015-07-30 80 seq_printf(m,
"%02x:", attr.state);
6e9fc177 Karol Herbst 2015-07-30 81 else
6e9fc177 Karol Herbst 2015-07-30 82 seq_printf(m,
"%s:", info.pwrsrc == 0 ? "DC" :
6e9fc177 Karol Herbst 2015-07-30 83
info.pwrsrc == 1 ? "AC" : "--");
6e9fc177 Karol Herbst 2015-07-30 84
6e9fc177 Karol Herbst 2015-07-30 85 attr.index = 0;
6e9fc177 Karol Herbst 2015-07-30 86 do {
6e9fc177 Karol Herbst 2015-07-30 87 attr.state =
state;
6e9fc177 Karol Herbst 2015-07-30 88 ret =
nvif_mthd(ctrl, NVIF_CONTROL_PSTATE_ATTR,
6e9fc177 Karol Herbst 2015-07-30 89
, sizeof(attr));
6e9fc177 Karol Herbst 2015-07-30 90 if (ret)
6e9fc177 Karol Herbst 2015-07-30 91 return
ret;
6e9fc177 Karol Herbst 2015-07-30 92
6e9fc177 Karol Herbst 2015-07-30 93 seq_printf(m, "
%s %d", attr.name, attr.min);
6e9fc177 Karol Herbst 2015-07-30 94 if (attr.min !=
attr.max)
6e9fc177 Karol Herbst 2015-07-30 95
seq_printf(m, "-%d", attr.max);
6e9fc177 Karol Herbst 2015-07-30 96 seq_printf(m, "
%s", attr.unit);
6e9fc177 Karol Herbst 2015-07-30 97 } while (attr.index);
6e9fc177 Karol Herbst 2015-07-30 98
6e9fc177 Karol Herbst 2015-07-30 99 if (state >= 0) {
6e9fc177 Karol
Re: [Nouveau] [PATCH v3 3/8] drm/fb_helper: Introduce hotplug_suspend/resume()
Hi Lyude,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.18-rc7]
[cannot apply to next-20180731]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Lyude-Paul/Fix-connector-probing-deadlocks-from-RPM-bugs/20180801-153816
config: x86_64-randconfig-x014-201830 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from drivers/gpu//drm/drm_crtc_helper.c:42:0:
include/drm/drm_fb_helper.h: In function 'drm_fb_helper_suspend_hotplug':
>> include/drm/drm_fb_helper.h:586:1: warning: no return statement in function
>> returning non-void [-Wreturn-type]
}
^
vim +586 include/drm/drm_fb_helper.h
578
579 static inline void
580 drm_fb_helper_resume_hotplug(struct drm_fb_helper *fb_helper)
581 {
582 }
583 static inline bool
584 drm_fb_helper_suspend_hotplug(struct drm_fb_helper *fb_helper)
585 {
> 586 }
587 #endif
588
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [PATCH 2/2] drm/nouveau: Prevent redundant connector probes from ACPI
Hi Lyude,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc7 next-20180727]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Lyude-Paul/drm-nouveau-Print-debug-message-on-ACPI-probe-event/20180731-150343
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:10:0,
from include/linux/list.h:9,
from include/linux/agp_backend.h:33,
from include/drm/drmP.h:35,
from drivers/gpu/drm/nouveau/nouveau_display.c:28:
drivers/gpu/drm/nouveau/nouveau_display.c: In function
'nouveau_display_init':
>> drivers/gpu/drm/nouveau/nouveau_display.c:431:16: error: 'struct
>> nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, false);
^
include/linux/compiler.h:275:17: note: in definition of macro 'WRITE_ONCE'
union { typeof(x) __val; char __c[1]; } __u = \
^
>> drivers/gpu/drm/nouveau/nouveau_display.c:431:16: error: 'struct
>> nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, false);
^
include/linux/compiler.h:276:30: note: in definition of macro 'WRITE_ONCE'
{ .__val = (__force typeof(x)) (val) }; \
^
>> drivers/gpu/drm/nouveau/nouveau_display.c:431:16: error: 'struct
>> nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, false);
^
include/linux/compiler.h:277:22: note: in definition of macro 'WRITE_ONCE'
__write_once_size(&(x), __u.__c, sizeof(x)); \
^
>> drivers/gpu/drm/nouveau/nouveau_display.c:431:16: error: 'struct
>> nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, false);
^
include/linux/compiler.h:277:42: note: in definition of macro 'WRITE_ONCE'
__write_once_size(&(x), __u.__c, sizeof(x)); \
^
drivers/gpu/drm/nouveau/nouveau_display.c: In function
'nouveau_display_fini':
drivers/gpu/drm/nouveau/nouveau_display.c:458:17: error: 'struct
nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, true);
^
include/linux/compiler.h:275:17: note: in definition of macro 'WRITE_ONCE'
union { typeof(x) __val; char __c[1]; } __u = \
^
drivers/gpu/drm/nouveau/nouveau_display.c:458:17: error: 'struct
nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, true);
^
include/linux/compiler.h:276:30: note: in definition of macro 'WRITE_ONCE'
{ .__val = (__force typeof(x)) (val) }; \
^
drivers/gpu/drm/nouveau/nouveau_display.c:458:17: error: 'struct
nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, true);
^
include/linux/compiler.h:277:22: note: in definition of macro 'WRITE_ONCE'
__write_once_size(&(x), __u.__c, sizeof(x)); \
^
drivers/gpu/drm/nouveau/nouveau_display.c:458:17: error: 'struct
nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, true);
^
include/linux/compiler.h:277:42: note: in definition of macro 'WRITE_ONCE'
__write_once_size(&(x), __u.__c, sizeof(x)); \
^
vim +431 drivers/gpu/drm/nouveau/nouveau_display.c
404
405 int
406 nouveau_display_init(struct drm_device *dev, bool runtime)
407 {
408 struct nouveau_display *disp = nouveau_display(dev);
409 struct nouveau_drm *drm = nouveau_drm(dev);
410 struct drm_connector *connector;
411 struct drm_connector_list_iter conn_iter;
412 int ret;
413
414 ret = disp->init(dev);
415 if (ret)
416 return ret;
417
418 /* enable hotplug interrupts */
419 drm_connector_list_iter_begin(dev, _iter);
420 nouveau_for_each_non_mst_connector_iter(connector, _iter) {
421 struct nouveau_connector *conn =
nouveau_connector(connector);
422 nvif_notify_get(>hpd);
423 }
424 drm_connector_list_iter_end(_iter);
425
426
Re: [Nouveau] [Intel-gfx] [PATCH 6/8] drm/nouveau: Use drm_for_each_connector_encoder_ids()
Hi Ville,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm/drm-next]
[also build test WARNING on v4.18-rc2 next-20180626]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-Second-attempt-at-fixing-the-fb-helper-best_encoder-mess/20180627-024018
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: x86_64-randconfig-x012-201825 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/gpu//drm/nouveau/nouveau_connector.c: In function
'nouveau_connector_detect':
>> drivers/gpu//drm/nouveau/nouveau_connector.c:606:33: warning: 'nv_encoder'
>> may be used uninitialized in this function [-Wmaybe-uninitialized]
if (nv_partner && ((nv_encoder->dcb->type == DCB_OUTPUT_ANALOG &&
~~^
vim +/nv_encoder +606 drivers/gpu//drm/nouveau/nouveau_connector.c
6ee73861 Ben Skeggs2009-12-11 546
6ee73861 Ben Skeggs2009-12-11 547 static enum drm_connector_status
930a9e28 Chris Wilson 2010-09-14 548 nouveau_connector_detect(struct
drm_connector *connector, bool force)
6ee73861 Ben Skeggs2009-12-11 549 {
6ee73861 Ben Skeggs2009-12-11 550 struct drm_device *dev =
connector->dev;
77145f1c Ben Skeggs2012-07-31 551 struct nouveau_drm *drm =
nouveau_drm(dev);
6ee73861 Ben Skeggs2009-12-11 552 struct nouveau_connector
*nv_connector = nouveau_connector(connector);
6ee73861 Ben Skeggs2009-12-11 553 struct nouveau_encoder
*nv_encoder = NULL;
e19b20bb Ben Skeggs2011-07-12 554 struct nouveau_encoder
*nv_partner;
2aa5eac5 Ben Skeggs2015-08-20 555 struct i2c_adapter *i2c;
03cd06ca Francisco Jerez 2010-07-20 556 int type;
5addcf0a Dave Airlie 2012-09-10 557 int ret;
5addcf0a Dave Airlie 2012-09-10 558 enum drm_connector_status
conn_status = connector_status_disconnected;
6ee73861 Ben Skeggs2009-12-11 559
b8780e2a Francisco Jerez 2010-01-14 560 /* Cleanup the previous EDID
block. */
b8780e2a Francisco Jerez 2010-01-14 561 if (nv_connector->edid) {
b8780e2a Francisco Jerez 2010-01-14 562
drm_mode_connector_update_edid_property(connector, NULL);
c8ebe275 Xavier Chantry2010-01-11 563
kfree(nv_connector->edid);
c8ebe275 Xavier Chantry2010-01-11 564 nv_connector->edid =
NULL;
b8780e2a Francisco Jerez 2010-01-14 565 }
c8ebe275 Xavier Chantry2010-01-11 566
d61a5c10 Lukas Wunner 2018-02-11 567 /* Outputs are only polled
while runtime active, so acquiring a
d61a5c10 Lukas Wunner 2018-02-11 568 * runtime PM ref here is
unnecessary (and would deadlock upon
d61a5c10 Lukas Wunner 2018-02-11 569 * runtime suspend because it
waits for polling to finish).
d61a5c10 Lukas Wunner 2018-02-11 570 */
d61a5c10 Lukas Wunner 2018-02-11 571 if
(!drm_kms_helper_is_poll_worker()) {
5addcf0a Dave Airlie 2012-09-10 572 ret =
pm_runtime_get_sync(connector->dev->dev);
b6c4285a Alexandre Courbot 2014-02-12 573 if (ret < 0 && ret !=
-EACCES)
5addcf0a Dave Airlie 2012-09-10 574 return
conn_status;
d61a5c10 Lukas Wunner 2018-02-11 575 }
5addcf0a Dave Airlie 2012-09-10 576
8777c5c1 Ben Skeggs2014-06-06 577 nv_encoder =
nouveau_connector_ddc_detect(connector);
8777c5c1 Ben Skeggs2014-06-06 578 if (nv_encoder && (i2c =
nv_encoder->i2c) != NULL) {
39c1c901 Lukas Wunner 2016-01-11 579 if
((vga_switcheroo_handler_flags() &
39c1c901 Lukas Wunner 2016-01-11 580
VGA_SWITCHEROO_CAN_SWITCH_DDC) &&
39c1c901 Lukas Wunner 2016-01-11 581 nv_connector->type
== DCB_CONNECTOR_LVDS)
39c1c901 Lukas Wunner 2016-01-11 582
nv_connector->edid = drm_get_edid_switcheroo(connector,
39c1c901 Lukas Wunner 2016-01-11 583
i2c);
39c1c901 Lukas Wunner 2016-01-11 584 else
2aa5eac5 Ben Skeggs2015-08-20 585
nv_connector->edid = drm_get_edid(connector, i2c);
39c1c901 Lukas Wunner 2016-01-11 586
6ee73861 Ben Skeggs2009-12-11 587
drm_mode_connector_update_edid_property(connector,
6ee73861 Ben Skeggs2009-12-11 588
nv_connector->edid);
6ee73861 Ben Skeggs2009-12-11 589
Re: [Nouveau] [PATCH 1/3] drm/connector: Add generic underscan properties
Hi Boris,
I love your patch! Yet something to improve:
[auto build test ERROR on anholt/for-next]
[also build test ERROR on v4.17-rc4 next-20180507]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Boris-Brezillon/drm-connector-Provide-generic-support-for-underscan/20180508-022336
base: https://github.com/anholt/linux for-next
config: x86_64-randconfig-x010-201818 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
drivers/gpu//drm/drm_connector.c: In function
'drm_connector_attach_underscan_properties':
>> drivers/gpu//drm/drm_connector.c:1188:50: warning: passing argument 3 of
>> 'drm_property_add_enum' makes integer from pointer without a cast
>> [-Wint-conversion]
ret = drm_property_add_enum(prop, entry->type, entry->name);
^
In file included from include/drm/drm_crtc.h:42:0,
from include/drm/drmP.h:69,
from drivers/gpu//drm/drm_connector.c:23:
include/drm/drm_property.h:263:5: note: expected 'uint64_t {aka long long
unsigned int}' but argument is of type 'const char * const'
int drm_property_add_enum(struct drm_property *property, int index,
^
>> drivers/gpu//drm/drm_connector.c:1188:9: error: too few arguments to
>> function 'drm_property_add_enum'
ret = drm_property_add_enum(prop, entry->type, entry->name);
^
In file included from include/drm/drm_crtc.h:42:0,
from include/drm/drmP.h:69,
from drivers/gpu//drm/drm_connector.c:23:
include/drm/drm_property.h:263:5: note: declared here
int drm_property_add_enum(struct drm_property *property, int index,
^
vim +/drm_property_add_enum +1188 drivers/gpu//drm/drm_connector.c
1141
1142 /**
1143 * drm_connector_attach_underscan_properties - attach atomic underscan
1144 * properties
1145 * @connector: connector to attach underscan mode properties on.
1146 * @mode_mask: bitmask of %DRM_UNDERSCAN_XX modes encoding the supported
1147 * underscan modes.
1148 * @max_hborder: maximum size of the horizontal border expressed in
pixels.
1149 * Should be > 0.
1150 * @max_vborder: maximum size of the vertical border expressed in
pixels.
1151 * Should be > 0.
1152 *
1153 * This is used to add support for underscan to atomic drivers.
1154 * The underscan config will be set to _connector_state.underscan
1155 * and can be used from _connector_helper_funcs->atomic_check for
1156 * validation.
1157 *
1158 * Returns:
1159 * Zero on success, negative errno on failure.
1160 */
1161 int drm_connector_attach_underscan_properties(struct drm_connector
*connector,
1162u32 mode_mask, u64
max_hborder,
1163u64 max_vborder)
1164 {
1165 unsigned int i, nmodes =
ARRAY_SIZE(drm_underscan_mode_enum_list);
1166 struct drm_device *dev = connector->dev;
1167 struct drm_property *prop;
1168
1169 if (!max_hborder || !max_vborder)
1170 return -EINVAL;
1171
1172 if (!hweight32(mode_mask) || (mode_mask & ~GENMASK(nmodes - 1,
0)))
1173 return -EINVAL;
1174
1175 prop = drm_property_create(dev, DRM_MODE_PROP_ENUM, "underscan",
1176 hweight32(mode_mask));
1177 if (!prop)
1178 return -ENOMEM;
1179
1180 for (i = 0; i < ARRAY_SIZE(drm_underscan_mode_enum_list); i++) {
1181 const struct drm_prop_enum_list *entry;
1182 int ret;
1183
1184 if (!(BIT(i) & mode_mask))
1185 continue;
1186
1187 entry = _underscan_mode_enum_list[i];
> 1188 ret = drm_property_add_enum(prop, entry->type,
> entry->name);
1189 if (ret)
1190 goto err_free_mode_prop;
1191 }
1192
1193 connector->underscan_mode_property = prop;
1194
1195 prop = drm_property_create_range(dev, 0, "underscan hborder", 0,
1196 max_hborder);
1197 if (!prop)
1198 goto err_free_mode_prop;
1199
1200 connector->underscan_hborder_property = prop;
1201
1202 prop = drm_property_create_range(dev, 0, "underscan vborder", 0,
1203
Re: [Nouveau] [PATCH 3/4] ARM: dma-mapping: Implement arch_iommu_detach_device()
Hi Thierry,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Thierry-Reding/drm-nouveau-tegra-Detach-from-ARM-DMA-IOMMU-mapping/20180426-140854
config: arm-omap2plus_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All error/warnings (new ones prefixed by >>):
arch/arm/mm/dma-mapping.c: In function 'arch_iommu_detach_device':
>> arch/arm/mm/dma-mapping.c:2380:12: error: implicit declaration of function
>> 'arm_get_dma_map_ops'; did you mean 'arm_get_iommu_dma_map_ops'?
>> [-Werror=implicit-function-declaration]
dma_ops = arm_get_dma_map_ops(dev->archdata.dma_coherent);
^~~
arm_get_iommu_dma_map_ops
>> arch/arm/mm/dma-mapping.c:2380:10: warning: assignment makes pointer from
>> integer without a cast [-Wint-conversion]
dma_ops = arm_get_dma_map_ops(dev->archdata.dma_coherent);
^
arch/arm/mm/dma-mapping.c: At top level:
>> arch/arm/mm/dma-mapping.c:2402:34: error: conflicting types for
>> 'arm_get_dma_map_ops'
static const struct dma_map_ops *arm_get_dma_map_ops(bool coherent)
^~~
arch/arm/mm/dma-mapping.c:2380:12: note: previous implicit declaration of
'arm_get_dma_map_ops' was here
dma_ops = arm_get_dma_map_ops(dev->archdata.dma_coherent);
^~~
cc1: some warnings being treated as errors
vim +2380 arch/arm/mm/dma-mapping.c
2368
2369 void arch_iommu_detach_device(struct device *dev)
2370 {
2371 struct dma_iommu_mapping *mapping = to_dma_iommu_mapping(dev);
2372 const struct dma_map_ops *dma_ops;
2373
2374 if (!mapping)
2375 return;
2376
2377 arm_iommu_release_mapping(mapping);
2378 arm_iommu_detach_device(dev);
2379
> 2380 dma_ops = arm_get_dma_map_ops(dev->archdata.dma_coherent);
2381 set_dma_ops(dev, dma_ops);
2382 }
2383
2384 #else
2385
2386 static bool arm_setup_iommu_dma_ops(struct device *dev, u64 dma_base,
u64 size,
2387 const struct iommu_ops *iommu)
2388 {
2389 return false;
2390 }
2391
2392 static void arm_teardown_iommu_dma_ops(struct device *dev) { }
2393
2394 #define arm_get_iommu_dma_map_ops arm_get_dma_map_ops
2395
2396 void arch_iommu_detach_device(struct device *dev)
2397 {
2398 }
2399
2400 #endif /* CONFIG_ARM_DMA_USE_IOMMU */
2401
> 2402 static const struct dma_map_ops *arm_get_dma_map_ops(bool coherent)
2403 {
2404 return coherent ? _coherent_dma_ops : _dma_ops;
2405 }
2406
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [PATCH] drm/nouveau: Replace the iturbt_709 prop with the standarad COLOR_ENCODNIG prop
Hi Ville,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.16-rc2 next-20180220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-nouveau-Replace-the-iturbt_709-prop-with-the-standarad-COLOR_ENCODNIG-prop/20180220-230332
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: x86_64-allyesdebian (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:56:26: error: field
>> 'color_encoding' has incomplete type
enum drm_color_encoding color_encoding;
^~
drivers/gpu/drm/nouveau/dispnv04/overlay.c: In function 'nv10_update_plane':
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:168:34: error:
>> 'DRM_COLOR_YCBCR_BT709' undeclared (first use in this function)
if (nv_plane->color_encoding == DRM_COLOR_YCBCR_BT709)
^
drivers/gpu/drm/nouveau/dispnv04/overlay.c:168:34: note: each undeclared
identifier is reported only once for each function it appears in
drivers/gpu/drm/nouveau/dispnv04/overlay.c: In function 'nv10_set_params':
drivers/gpu/drm/nouveau/dispnv04/overlay.c:231:32: error:
'DRM_COLOR_YCBCR_BT709' undeclared (first use in this function)
if (plane->color_encoding == DRM_COLOR_YCBCR_BT709)
^
drivers/gpu/drm/nouveau/dispnv04/overlay.c: In function 'nv_set_property':
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:260:38: error: 'struct drm_plane'
>> has no member named 'color_encoding_property'; did you mean
>> 'rotation_property'?
else if (property == nv_plane->base.color_encoding_property)
^~~
rotation_property
drivers/gpu/drm/nouveau/dispnv04/overlay.c: In function 'nv10_overlay_init':
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:342:26: error:
>> 'DRM_COLOR_YCBCR_BT601' undeclared (first use in this function)
plane->color_encoding = DRM_COLOR_YCBCR_BT601;
^
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:343:2: error: implicit
>> declaration of function 'drm_plane_create_color_properties'; did you mean
>> 'drm_plane_create_zpos_property'? [-Werror=implicit-function-declaration]
drm_plane_create_color_properties(>base,
^
drm_plane_create_zpos_property
In file included from include/linux/kernel.h:11:0,
from include/linux/list.h:9,
from include/linux/agp_backend.h:33,
from include/drm/drmP.h:35,
from drivers/gpu/drm/nouveau/dispnv04/overlay.c:26:
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:345:12: error:
>> 'DRM_COLOR_YCBCR_BT709' undeclared (first use in this function); did you
>> mean 'DRM_COLOR_YCBCR_BT601'?
BIT(DRM_COLOR_YCBCR_BT709),
^
include/linux/bitops.h:7:28: note: in definition of macro 'BIT'
#define BIT(nr) (1UL << (nr))
^~
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:346:12: error:
>> 'DRM_COLOR_YCBCR_LIMITED_RANGE' undeclared (first use in this function); did
>> you mean 'DRM_COLOR_YCBCR_BT709'?
BIT(DRM_COLOR_YCBCR_LIMITED_RANGE),
^
include/linux/bitops.h:7:28: note: in definition of macro 'BIT'
#define BIT(nr) (1UL << (nr))
^~
cc1: some warnings being treated as errors
vim +/color_encoding +56 drivers/gpu/drm/nouveau/dispnv04/overlay.c
> 26 #include
27 #include
28 #include
29
30 #include "nouveau_drv.h"
31
32 #include "nouveau_bo.h"
33 #include "nouveau_connector.h"
34 #include "nouveau_display.h"
35 #include "nvreg.h"
36 #include "disp.h"
37
38 struct nouveau_plane {
39 struct drm_plane base;
40 bool flip;
41 struct nouveau_bo *cur;
42
43 struct {
44 struct drm_property *colorkey;
45 struct drm_property *contrast;
46 struct drm_property *brightness;
47 struct drm_property *hue;
48 struct drm_property *saturation;
49 } props;
50
51 int colorkey;
52 int contrast;
53 int brightness;
54 int hue;
55 int saturation;
> 56 enum drm_color_encoding color_encoding;
57
58 void (*set_params)(struct nouveau_plane *);
59 };
60
61 static uint32_t
Re: [Nouveau] [PATCH] drm/nouveau: Replace the iturbt_709 prop with the standarad COLOR_ENCODNIG prop
Hi Ville,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.16-rc2 next-20180220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ville-Syrjala/drm-nouveau-Replace-the-iturbt_709-prop-with-the-standarad-COLOR_ENCODNIG-prop/20180220-230332
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: i386-randconfig-a1-201807 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/gpu/drm/nouveau/dispnv04/overlay.c:56:26: error: field
'color_encoding' has incomplete type
enum drm_color_encoding color_encoding;
^
drivers/gpu/drm/nouveau/dispnv04/overlay.c: In function 'nv10_update_plane':
drivers/gpu/drm/nouveau/dispnv04/overlay.c:168:34: error:
'DRM_COLOR_YCBCR_BT709' undeclared (first use in this function)
if (nv_plane->color_encoding == DRM_COLOR_YCBCR_BT709)
^
drivers/gpu/drm/nouveau/dispnv04/overlay.c:168:34: note: each undeclared
identifier is reported only once for each function it appears in
drivers/gpu/drm/nouveau/dispnv04/overlay.c: In function 'nv10_set_params':
drivers/gpu/drm/nouveau/dispnv04/overlay.c:231:32: error:
'DRM_COLOR_YCBCR_BT709' undeclared (first use in this function)
if (plane->color_encoding == DRM_COLOR_YCBCR_BT709)
^
drivers/gpu/drm/nouveau/dispnv04/overlay.c: In function 'nv_set_property':
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:260:37: error: 'struct drm_plane'
>> has no member named 'color_encoding_property'
else if (property == nv_plane->base.color_encoding_property)
^
drivers/gpu/drm/nouveau/dispnv04/overlay.c: In function 'nv10_overlay_init':
drivers/gpu/drm/nouveau/dispnv04/overlay.c:342:26: error:
'DRM_COLOR_YCBCR_BT601' undeclared (first use in this function)
plane->color_encoding = DRM_COLOR_YCBCR_BT601;
^
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:343:2: error: implicit
>> declaration of function 'drm_plane_create_color_properties'
>> [-Werror=implicit-function-declaration]
drm_plane_create_color_properties(>base,
^
In file included from include/linux/kernel.h:11:0,
from include/linux/list.h:9,
from include/linux/agp_backend.h:33,
from include/drm/drmP.h:35,
from drivers/gpu/drm/nouveau/dispnv04/overlay.c:26:
drivers/gpu/drm/nouveau/dispnv04/overlay.c:345:12: error:
'DRM_COLOR_YCBCR_BT709' undeclared (first use in this function)
BIT(DRM_COLOR_YCBCR_BT709),
^
include/linux/bitops.h:7:28: note: in definition of macro 'BIT'
#define BIT(nr) (1UL << (nr))
^
>> drivers/gpu/drm/nouveau/dispnv04/overlay.c:346:12: error:
>> 'DRM_COLOR_YCBCR_LIMITED_RANGE' undeclared (first use in this function)
BIT(DRM_COLOR_YCBCR_LIMITED_RANGE),
^
include/linux/bitops.h:7:28: note: in definition of macro 'BIT'
#define BIT(nr) (1UL << (nr))
^
cc1: some warnings being treated as errors
vim +260 drivers/gpu/drm/nouveau/dispnv04/overlay.c
111
112 static int
113 nv10_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
114struct drm_framebuffer *fb, int crtc_x, int crtc_y,
115unsigned int crtc_w, unsigned int crtc_h,
116uint32_t src_x, uint32_t src_y,
117uint32_t src_w, uint32_t src_h,
118struct drm_modeset_acquire_ctx *ctx)
119 {
120 struct nouveau_drm *drm = nouveau_drm(plane->dev);
121 struct nvif_object *dev = >client.device.object;
122 struct nouveau_plane *nv_plane =
123 container_of(plane, struct nouveau_plane, base);
124 struct nouveau_framebuffer *nv_fb = nouveau_framebuffer(fb);
125 struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
126 struct nouveau_bo *cur = nv_plane->cur;
127 bool flip = nv_plane->flip;
128 int soff = NV_PCRTC0_SIZE * nv_crtc->index;
129 int soff2 = NV_PCRTC0_SIZE * !nv_crtc->index;
130 unsigned shift = drm->client.device.info.chipset >= 0x30 ? 1 :
3;
131 unsigned format = 0;
132 int ret;
133
134 /* Source parameters given in 16.16 fixed point, ignore
fractional. */
135 src_x >>= 16;
136 src_y >>= 16;
137 src_w >>= 16;
138 src_h >>= 16;
139
140 ret = verify_scaling(fb, shift, 0, 0, src_w, src_h,
Re: [Nouveau] [PATCH 11/11] drm: remove unused and redundant callbacks
Hi Peter,
[auto build test ERROR on drm/drm-next]
[also build test ERROR on next-20170621]
[cannot apply to v4.12-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Peter-Rosin/improve-the-fb_setcmap-helper/20170621-205441
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
>> drivers/gpu//drm/armada/armada_fbdev.c:121:2: error: unknown field
>> 'gamma_set' specified in initializer
.gamma_set = armada_drm_crtc_gamma_set,
^
>> drivers/gpu//drm/armada/armada_fbdev.c:121:15: error: initialization from
>> incompatible pointer type [-Werror=incompatible-pointer-types]
.gamma_set = armada_drm_crtc_gamma_set,
^
drivers/gpu//drm/armada/armada_fbdev.c:121:15: note: (near initialization
for 'armada_fb_helper_funcs.fb_probe')
>> drivers/gpu//drm/armada/armada_fbdev.c:122:2: error: unknown field
>> 'gamma_get' specified in initializer
.gamma_get = armada_drm_crtc_gamma_get,
^
drivers/gpu//drm/armada/armada_fbdev.c:122:15: error: initialization from
incompatible pointer type [-Werror=incompatible-pointer-types]
.gamma_get = armada_drm_crtc_gamma_get,
^
drivers/gpu//drm/armada/armada_fbdev.c:122:15: note: (near initialization
for 'armada_fb_helper_funcs.initial_config')
cc1: some warnings being treated as errors
vim +/gamma_set +121 drivers/gpu//drm/armada/armada_fbdev.c
96f60e37 Russell King 2012-08-15 115 ret = 1;
96f60e37 Russell King 2012-08-15 116 }
96f60e37 Russell King 2012-08-15 117 return ret;
96f60e37 Russell King 2012-08-15 118 }
96f60e37 Russell King 2012-08-15 119
3a493879 Thierry Reding 2014-06-27 120 static const struct
drm_fb_helper_funcs armada_fb_helper_funcs = {
96f60e37 Russell King 2012-08-15 @121 .gamma_set =
armada_drm_crtc_gamma_set,
96f60e37 Russell King 2012-08-15 @122 .gamma_get =
armada_drm_crtc_gamma_get,
96f60e37 Russell King 2012-08-15 123 .fb_probe =
armada_fb_probe,
96f60e37 Russell King 2012-08-15 124 };
96f60e37 Russell King 2012-08-15 125
:: The code at line 121 was first introduced by commit
:: 96f60e37dc66091bde8d5de136ff6fda09f2d799 DRM: Armada: Add Armada DRM
driver
:: TO: Russell King
:: CC: Russell King
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [PATCH 1/4] drm/vc4: Allow vblank_disable_immediate on non-fw-kms.
Hi Mario, [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.12-rc6 next-20170621] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mario-Kleiner/drm-vc4-Allow-vblank_disable_immediate-on-non-fw-kms/20170622-013723 base: git://people.freedesktop.org/~airlied/linux.git drm-next config: x86_64-allyesconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): drivers/gpu//drm/vc4/vc4_kms.c: In function 'vc4_kms_load': >> drivers/gpu//drm/vc4/vc4_kms.c:220:10: error: 'struct vc4_dev' has no member >> named 'firmware_kms' if (!vc4->firmware_kms) ^~ vim +220 drivers/gpu//drm/vc4/vc4_kms.c 214 struct vc4_dev *vc4 = to_vc4_dev(dev); 215 int ret; 216 217 sema_init(>async_modeset, 1); 218 219 /* Set support for vblank irq fast disable, before drm_vblank_init() */ > 220 if (!vc4->firmware_kms) 221 dev->vblank_disable_immediate = true; 222 223 ret = drm_vblank_init(dev, dev->mode_config.num_crtc); --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [PATCH v8 2/5] nouveau/hwmon: Add nouveau_hwmon_ops structure with .is_visible/.read_string
Hi Oscar,
[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.12-rc2 next-20170526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Oscar-Salvador/replace-hwmon_device_register-for-hwmon_device_register_with_info/20170519-053456
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/nouveau/nouveau_hwmon.c:922:17: error: initialization from
>> incompatible pointer type [-Werror=incompatible-pointer-types]
.read_string = nouveau_read_string,
^~~
drivers/gpu/drm/nouveau/nouveau_hwmon.c:922:17: note: (near initialization
for 'nouveau_hwmon_ops.read_string')
cc1: some warnings being treated as errors
vim +922 drivers/gpu/drm/nouveau/nouveau_hwmon.c
916 return -EOPNOTSUPP;
917 }
918
919 static const struct hwmon_ops nouveau_hwmon_ops = {
920 .is_visible = nouveau_is_visible,
921 .read = NULL,
> 922 .read_string = nouveau_read_string,
923 .write = NULL,
924 };
925
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [Intel-gfx] [PATCH v1] ACPI: Switch to use generic UUID API
Hi Andy,
[auto build test ERROR on next-20170503]
[cannot apply to pm/linux-next linus/master linux/master v4.9-rc8 v4.9-rc7
v4.9-rc6 v4.11]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Andy-Shevchenko/ACPI-Switch-to-use-generic-UUID-API/20170505-134225
config: i386-tinyconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from init/main.c:29:0:
>> include/linux/acpi.h:744:16: error: unknown type name 'uuid_le'
const uuid_le *uuid,
^~~
vim +/uuid_le +744 include/linux/acpi.h
738 const struct device_driver
*drv)
739 {
740 return false;
741 }
742
743 static inline union acpi_object *acpi_evaluate_dsm(acpi_handle handle,
> 744 const uuid_le *uuid,
745 int rev, int func,
746 union acpi_object
*argv4)
747 {
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [PATCH v3 4/5] nouveau_hwmon: Add support for auto_point attributes
Hi Oscar,
[auto build test WARNING on drm/drm-next]
[also build test WARNING on v4.11-rc7 next-20170421]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Oscar-Salvador/replace-hwmon_device_register-for-hwmon_device_register_with_info/20170422-064646
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget
https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm64
All warnings (new ones prefixed by >>):
In file included from include/linux/kobject.h:21:0,
from include/linux/device.h:17,
from include/linux/acpi.h:27,
from drivers/gpu/drm/nouveau/nouveau_hwmon.c:26:
drivers/gpu/drm/nouveau/nouveau_hwmon.c:366:18: error: initialization from
incompatible pointer type [-Werror=incompatible-pointer-types]
ATTRIBUTE_GROUPS(pwm_fan_sensor);
^
include/linux/sysfs.h:148:11: note: in definition of macro 'ATTRIBUTE_GROUPS'
.attrs = _name##_attrs, \
^
drivers/gpu/drm/nouveau/nouveau_hwmon.c:366:18: note: (near initialization
for 'pwm_fan_sensor_group.attrs')
ATTRIBUTE_GROUPS(pwm_fan_sensor);
^
include/linux/sysfs.h:148:11: note: in definition of macro 'ATTRIBUTE_GROUPS'
.attrs = _name##_attrs, \
^
drivers/gpu/drm/nouveau/nouveau_hwmon.c:374:18: error: initialization from
incompatible pointer type [-Werror=incompatible-pointer-types]
ATTRIBUTE_GROUPS(temp1_auto_point_sensor);
^
include/linux/sysfs.h:148:11: note: in definition of macro 'ATTRIBUTE_GROUPS'
.attrs = _name##_attrs, \
^
drivers/gpu/drm/nouveau/nouveau_hwmon.c:374:18: note: (near initialization
for 'temp1_auto_point_sensor_group.attrs')
ATTRIBUTE_GROUPS(temp1_auto_point_sensor);
^
include/linux/sysfs.h:148:11: note: in definition of macro 'ATTRIBUTE_GROUPS'
.attrs = _name##_attrs, \
^
drivers/gpu/drm/nouveau/nouveau_hwmon.c: In function 'nouveau_read_string':
drivers/gpu/drm/nouveau/nouveau_hwmon.c:754:8: warning: assignment discards
'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
*buf = input_label;
^
In file included from include/linux/kobject.h:21:0,
from include/linux/device.h:17,
from include/linux/acpi.h:27,
from drivers/gpu/drm/nouveau/nouveau_hwmon.c:26:
At top level:
drivers/gpu/drm/nouveau/nouveau_hwmon.c:374:18: warning:
'temp1_auto_point_sensor_groups' defined but not used [-Wunused-variable]
ATTRIBUTE_GROUPS(temp1_auto_point_sensor);
^
include/linux/sysfs.h:141:38: note: in definition of macro
'__ATTRIBUTE_GROUPS'
static const struct attribute_group *_name##_groups[] = { \
^
>> drivers/gpu/drm/nouveau/nouveau_hwmon.c:374:1: note: in expansion of macro
>> 'ATTRIBUTE_GROUPS'
ATTRIBUTE_GROUPS(temp1_auto_point_sensor);
^~~~
drivers/gpu/drm/nouveau/nouveau_hwmon.c:366:18: warning:
'pwm_fan_sensor_groups' defined but not used [-Wunused-variable]
ATTRIBUTE_GROUPS(pwm_fan_sensor);
^
include/linux/sysfs.h:141:38: note: in definition of macro
'__ATTRIBUTE_GROUPS'
static const struct attribute_group *_name##_groups[] = { \
^
drivers/gpu/drm/nouveau/nouveau_hwmon.c:366:1: note: in expansion of macro
'ATTRIBUTE_GROUPS'
ATTRIBUTE_GROUPS(pwm_fan_sensor);
^~~~
cc1: some warnings being treated as errors
vim +/ATTRIBUTE_GROUPS +374 drivers/gpu/drm/nouveau/nouveau_hwmon.c
358 return iccsense->power_w_crit;
359 }
360
361 static const struct attribute *pwm_fan_sensor_attrs[] = {
362 _dev_attr_pwm1_min.dev_attr.attr,
363 _dev_attr_pwm1_max.dev_attr.attr,
364 NULL
365 };
366 ATTRIBUTE_GROUPS(pwm_fan_sensor);
367
368 static const struct attribute *temp1_auto_point_sensor_attrs[] = {
369 _dev_attr_temp1_auto_point1_pwm.dev_attr.attr,
370 _dev_attr_temp1_auto_point1_temp.dev_attr.attr,
371 _dev_attr_temp1_auto_point1_temp_hyst.dev_attr.attr,
372 NULL
373 };
> 374 ATTRIBUTE_GROUPS(temp1_auto_point_sensor);
375
376 #define N_ATTR_GROUPS 3
377
378
379 static const u32 nouveau_config_chip[] = {
380 HWMON_C_UPDATE_INTERVAL,
381 0
382 };
---
0-DAY kernel test infrastructure
Re: [Nouveau] [PATCH v2 09/10] drm/nouveau: Handle frame-packing mode geometry and timing effects
Hi Alastair, [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.11-rc4 next-20170327] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alastair-Bridgewater/Enable-HDMI-Stereoscopy/20170328-090906 base: git://people.freedesktop.org/~airlied/linux.git drm-next config: i386-randconfig-s0-201713 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/gpu/drm/nouveau/nv50_display.c: In function 'nv50_head_atomic_check_view': >> drivers/gpu/drm/nouveau/nv50_display.c:1995:2: error: implicit declaration >> of function 'drm_crtc_get_hv_timing' [-Werror=implicit-function-declaration] drm_crtc_get_hv_timing(omode, _hdisplay, _vdisplay); ^~ cc1: some warnings being treated as errors vim +/drm_crtc_get_hv_timing +1995 drivers/gpu/drm/nouveau/nv50_display.c 1989 umode_vdisplay = umode->vdisplay; 1990 if ((umode->flags & DRM_MODE_FLAG_3D_MASK) == DRM_MODE_FLAG_3D_FRAME_PACKING) 1991 umode_vdisplay += umode->vtotal; 1992 asyh->view.iW = umode->hdisplay; 1993 asyh->view.iH = umode_vdisplay; 1994 /* For the ouput mode, we can just use the stock helper. */ > 1995 drm_crtc_get_hv_timing(omode, _hdisplay, _vdisplay); 1996 asyh->view.oW = omode_hdisplay; 1997 asyh->view.oH = omode_vdisplay; 1998 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip ___ Nouveau mailing list Nouveau@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [Intel-gfx] [PATCH v2 1/2] drm: Wrap the check for atomic_commit implementation
Hi Dhinakaran,
[auto build test ERROR on drm/drm-next]
[also build test ERROR on next-20161222]
[cannot apply to v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Dhinakaran-Pandiyan/drm-Wrap-the-check-for-atomic_commit-implementation/20161222-153523
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: i386-randconfig-s1-201651 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c:19:0:
include/drm/drm_atomic.h: In function 'drm_drv_uses_atomic_modeset':
>> include/drm/drm_atomic.h:436:12: error: dereferencing pointer to incomplete
>> type 'struct drm_device'
return dev->mode_config.funcs->atomic_commit ? true : false;
^~
vim +436 include/drm/drm_atomic.h
430 *
431 * This check is useful if drivers do not have DRIVER_ATOMIC set but
432 * have atomic modesetting internally implemented.
433 */
434 static inline bool drm_drv_uses_atomic_modeset(struct drm_device *dev)
435 {
> 436 return dev->mode_config.funcs->atomic_commit ? true : false;
437 }
438
439 #endif /* DRM_ATOMIC_H_ */
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] [Intel-gfx] [PATCH v3 1/2] drm: Wrap the check for atomic_commit implementation
Hi Dhinakaran,
[auto build test ERROR on drm/drm-next]
[also build test ERROR on next-20161222]
[cannot apply to v4.9]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Dhinakaran-Pandiyan/drm-Wrap-the-check-for-atomic_commit-implementation/20161222-174536
base: git://people.freedesktop.org/~airlied/linux.git drm-next
config: openrisc-allmodconfig (attached as .config)
compiler: or32-linux-gcc (GCC) 4.5.1-or32-1.0rc1
reproduce:
wget
https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross
-O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=openrisc
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/vc4/vc4_crtc.c:34:0:
include/drm/drm_atomic.h: In function 'drm_drv_uses_atomic_modeset':
>> include/drm/drm_atomic.h:437:12: error: dereferencing pointer to incomplete
>> type
vim +437 include/drm/drm_atomic.h
431 *
432 * This check is useful if drivers do not have DRIVER_ATOMIC set but
433 * have atomic modesetting internally implemented.
434 */
435 static inline bool drm_drv_uses_atomic_modeset(struct drm_device *dev)
436 {
> 437 return dev->mode_config.funcs->atomic_commit != NULL;
438 }
439
440 #endif /* DRM_ATOMIC_H_ */
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
___
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau
