Re: [Nouveau] nouveau_class.h
On Fri, Apr 9, 2010 at 8:51 AM, Ben Skeggs wrote: > So, with all the nouveau_class.h changes lately it's become rather > difficult to keep libdrm synced up with a particular mesa version. > > This is much like what happens when we break our kernel ABI, but on a > far more regular basis so it has a larger impact. > > I'm proposing we drop nouveau_class.h from libdrm again, and move it > back to the ddx and mesa trees where it can be updated at the same time > the code that uses it is. > > Any objections / other suggestions? > I did several times mesa bisection across one or more nouveau_class.h changes , that was a bit painful. So that change would be most welcome. And that would also obsolete the regular build failures from users who forgot to update libdrm. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] nouveau_class.h
On Fri, 2010-04-09 at 00:33 -0700, Stephane Marchesin wrote: > On Thu, Apr 8, 2010 at 23:51, Ben Skeggs wrote: > > So, with all the nouveau_class.h changes lately it's become rather > > difficult to keep libdrm synced up with a particular mesa version. > > > > This is much like what happens when we break our kernel ABI, but on a > > far more regular basis so it has a larger impact. > > > > I'm proposing we drop nouveau_class.h from libdrm again, and move it > > back to the ddx and mesa trees where it can be updated at the same time > > the code that uses it is. > > > > Any objections / other suggestions? > > > > Agreed. We don't need more interfaces, we need less interfaces. Great, I probably have some time to kill tonight so I'll probably get it done in the next couple of hours. Ben. > > Stephane ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] nouveau_class.h
On Fri, 2010-04-09 at 09:24 +0200, Maarten Maathuis wrote: > On Fri, Apr 9, 2010 at 8:51 AM, Ben Skeggs wrote: > > So, with all the nouveau_class.h changes lately it's become rather > > difficult to keep libdrm synced up with a particular mesa version. > > > > This is much like what happens when we break our kernel ABI, but on a > > far more regular basis so it has a larger impact. > > > > I'm proposing we drop nouveau_class.h from libdrm again, and move it > > back to the ddx and mesa trees where it can be updated at the same time > > the code that uses it is. > > > > Any objections / other suggestions? > > As long as it's autogenerated and not manually modified, it's fine by me. Of course, I'm not proposing changing from how we currently generate nouveau_class.h from renouveau at all, just that we ship a version with the ddx/mesa that matches what the code actually uses. Ben. > > > > > Ben. > > > > ___ > > Nouveau mailing list > > Nouveau@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/nouveau > > ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] nouveau_class.h
On Thu, Apr 8, 2010 at 23:51, Ben Skeggs wrote: > So, with all the nouveau_class.h changes lately it's become rather > difficult to keep libdrm synced up with a particular mesa version. > > This is much like what happens when we break our kernel ABI, but on a > far more regular basis so it has a larger impact. > > I'm proposing we drop nouveau_class.h from libdrm again, and move it > back to the ddx and mesa trees where it can be updated at the same time > the code that uses it is. > > Any objections / other suggestions? > Agreed. We don't need more interfaces, we need less interfaces. Stephane ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
Re: [Nouveau] nouveau_class.h
On Fri, Apr 9, 2010 at 8:51 AM, Ben Skeggs wrote: > So, with all the nouveau_class.h changes lately it's become rather > difficult to keep libdrm synced up with a particular mesa version. > > This is much like what happens when we break our kernel ABI, but on a > far more regular basis so it has a larger impact. > > I'm proposing we drop nouveau_class.h from libdrm again, and move it > back to the ddx and mesa trees where it can be updated at the same time > the code that uses it is. > > Any objections / other suggestions? As long as it's autogenerated and not manually modified, it's fine by me. > > Ben. > > ___ > Nouveau mailing list > Nouveau@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/nouveau > ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
[Nouveau] nouveau_class.h
So, with all the nouveau_class.h changes lately it's become rather difficult to keep libdrm synced up with a particular mesa version. This is much like what happens when we break our kernel ABI, but on a far more regular basis so it has a larger impact. I'm proposing we drop nouveau_class.h from libdrm again, and move it back to the ddx and mesa trees where it can be updated at the same time the code that uses it is. Any objections / other suggestions? Ben. ___ Nouveau mailing list Nouveau@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/nouveau
