Re: [nox-dev] Help modifying some Nox code for the first time
I may have found a bug with the new Error_event class you added recently. I notice that when I set the xid of a flow mod, the xid in an error event is different. Perhaps its not converted back from network format? I'm not sure where that code is, but it is being converted to network format on the way out in pycontext.cc. -Derek On 12/17/2010 04:07 PM, Derek Cormier wrote: It works =) On 12/17/2010 04:03 PM, Murphy McCauley wrote: Ugh, I have actually been sitting on a patch forever that add support for xids all the way through Python; I really should nail it down and commit it. Sorry. Change send_flow_command() in context.i also. -- Murphy On Dec 16, 2010, at 10:52 PM, Derek Cormier wrote: Hello, I'm modifying some Nox code so that core.py's *install_datapath_flow* takes another argument- the xid for the flow mod request. def install_datapath_flow(self, dp_id, attrs, idle_timeout, hard_timeout, actions, buffer_id=None, priority=openflow.OFP_DEFAULT_PRIORITY, inport=None, packet=None, xid=0): I also changed *send_flow_command*... def send_flow_command(self, dp_id, command, attrs, priority=openflow.OFP_DEFAULT_PRIORITY, add_args=None, hard_timeout=openflow.OFP_FLOW_PERMANENT, xid=0): ... and its call self.ctxt.send_flow_command(dp_id, command, m, idle_timeout, hard_timeout, oactions, buffer_id, priority, xid) I also made the argument changes in *pycontext.hh* and *pycontext.c*. However, when I run a Nox component that calls that method, I get the error: File ./nox/coreapps/pyrt/pycomponent.py, line 589, in send_flow_command def send_flow_command(self, *args): return _pycomponent.PyContext_send_flow_command(self, *args) TypeError: PyContext_send_flow_command() *takes exactly 9 arguments (10 given)* I did recompile the source. *pycomponent.py* seems to be created after building, so there is some other step I'm missing. I think it has to do with swig? Thanks for your help, Derek ___ nox-dev mailing list nox-dev@noxrepo.org mailto:nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
Re: [nox-dev] Help modifying some Nox code for the first time
This isn't just with the Error_event event -- it just behaves the same as all the other Python events that currently keep the xid information, and also the same as the C++ API which does not byte-swap header fields. I agree it's probably not the most *desirable* behavior, but it is *consistent* (for some values of consistent anyway). So I think the easy thing to do is for you to probably NOT convert to network order in your new pycontext code, and leave it up to the user to do it (or not -- since they're opaque, it generally shouldn't matter if they do it or not as long as they're consistent). The user may just be you in this case, in which case do whatever you want. :) It's altogether possible that I actually do conversion on all Python-side xids in my as-yet-uncommitted xid patch, but I don't remember. I don't immediately see a reason why it would be problematic. (Of the code currently in the repo, this is at least the event converters in pyrt.cc, though it may pop up in a few other places too.) -- Murphy On Fri, 2010-12-17 at 17:52 +0900, Derek Cormier wrote: I may have found a bug with the new Error_event class you added recently. I notice that when I set the xid of a flow mod, the xid in an error event is different. Perhaps its not converted back from network format? I'm not sure where that code is, but it is being converted to network format on the way out in pycontext.cc. -Derek On 12/17/2010 04:07 PM, Derek Cormier wrote: It works =) On 12/17/2010 04:03 PM, Murphy McCauley wrote: Ugh, I have actually been sitting on a patch forever that add support for xids all the way through Python; I really should nail it down and commit it. Sorry. Change send_flow_command() in context.i also. -- Murphy On Dec 16, 2010, at 10:52 PM, Derek Cormier wrote: Hello, I'm modifying some Nox code so that core.py's install_datapath_flow takes another argument- the xid for the flow mod request. def install_datapath_flow(self, dp_id, attrs, idle_timeout, hard_timeout, actions, buffer_id=None, priority=openflow.OFP_DEFAULT_PRIORITY, inport=None, packet=None, xid=0): I also changed send_flow_command... def send_flow_command(self, dp_id, command, attrs, priority=openflow.OFP_DEFAULT_PRIORITY, add_args=None, hard_timeout=openflow.OFP_FLOW_PERMANENT, xid=0): ... and its call self.ctxt.send_flow_command(dp_id, command, m, idle_timeout, hard_timeout, oactions, buffer_id, priority, xid) I also made the argument changes in pycontext.hh and pycontext.c. However, when I run a Nox component that calls that method, I get the error: File ./nox/coreapps/pyrt/pycomponent.py, line 589, in send_flow_command def send_flow_command(self, *args): return _pycomponent.PyContext_send_flow_command(self, *args) TypeError: PyContext_send_flow_command() takes exactly 9 arguments (10 given) I did recompile the source. pycomponent.py seems to be created after building, so there is some other step I'm missing. I think it has to do with swig? Thanks for your help, Derek ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
Re: [nox-dev] ERR:Application 'python' description not found when running latest NOX
Hi, I tried running with --with-python=no and the result of that runs (and connects to the switch). But that nox_core piece contains no application: linux-ojon:/home/openflow/nox/nox-no-python/build # src/nox_core -v -i ptcp:6364 packetdump 1|nox|INFO:Starting nox_core (/home/openflow/nox/nox-no-python/build/src/.libs/nox_core) 2|nox|DBG:Application installation report: 3|nox|DBG:built-in DSO deployer: Current state: INSTALLED Required state: INSTALLED Dependencies: 4|nox|DBG:built-in event dispatcher: Current state: INSTALLED Required state: INSTALLED Dependencies: 5|nox|ERR:Application 'packetdump' description not found. Are all the apps dependent on python to run? This is on SUSE (with the recommended addition of all the packages including python-devel python-twisted and python-curses) - is it possible whatever Python version is being used for NOX no longer works with SUSE? Thanks, - Stephen -Original Message- From: nox-dev-boun...@noxrepo.org [mailto:nox-dev-boun...@noxrepo.org] On Behalf Of Stephen Wong Sent: Friday, December 17, 2010 9:41 AM To: 'James Murphy McCauley' Cc: 'nox-dev' Subject: Re: [nox-dev] ERR:Application 'python' description not found when running latest NOX Hi Murphy, See attached. Appreciate your help. Thanks! Thanks, - Stephen -Original Message- From: James Murphy McCauley [mailto:jam...@nau.edu] Sent: Thursday, December 16, 2010 6:54 PM To: Stephen Wong Cc: 'nox-dev' Subject: Re: [nox-dev] ERR:Application 'python' description not found when running latest NOX Could you please post your config.log? -- Murphy On Thu, 2010-12-16 at 17:57 -0800, Stephen Wong wrote: Hi Derek, Yes, I did: linux-ojon:/home/openflow/nox/nox/build # grep -n python * config.h:109:/* Provide macro indicating that twisted python was enabled */ config.log:7: $ ../configure --with-python=yes -- config.log:997:configure:15817: checking for python config.log:998:configure:15835: found /usr/bin/python config.log:999:configure:15847: result: /usr/bin/python config.log:1007:configure:15948: result: -I/usr/include/python2.6 config.log:1009:configure:15977: result: -L/usr/lib64/python2.6/config -lpython2.6 config.log:1011:configure:15990: result: /usr/lib/python2.6/site-packages [snip the rest] What is the 'python' application? Should I try it without python? Thanks, - Stephen -Original Message- From: nox-dev-boun...@noxrepo.org [mailto:nox-dev-boun...@noxrepo.org] On Behalf Of Derek Cormier Sent: Thursday, December 16, 2010 5:24 PM To: nox-dev Subject: Re: [nox-dev] ERR:Application 'python' description not found when running latest NOX Did you call the configure script with python? ./configure --with-python=yes -Derek On 12/17/2010 10:18 AM, Stephen Wong wrote: Hi, I just compiled NOX from the latest repository (make/make check/make install all succeed), but when I tried to run it, I got the following error: openf...@linux-ojon:~/nox/nox/build src/nox_core -i ptcp:6634 -v 1|nox|INFO:Starting nox_core (/home/openflow/nox/nox/build/src/.libs/nox_core) 2|nox|ERR:Application 'python' description not found. And here is the NOX version number: openf...@linux-ojon:~/nox/nox/build src/nox_core -V NOX 0.9.0(zaku)~full~beta (nox_core), compiled Dec 16 2010 16:18:05 Compiled with OpenFlow 0x01 Any help is appreciated. Thanks! Thanks, - Stephen ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
Re: [nox-dev] ERR:Application 'python' description not found when running latest NOX
Ah. Try running nox from its directory. cd src ; ./nox_core -i ptcp:6634 -v -- Murphy On Dec 17, 2010, at 7:03 PM, Stephen Wong wrote: Hi, I tried running with --with-python=no and the result of that runs (and connects to the switch). But that nox_core piece contains no application: linux-ojon:/home/openflow/nox/nox-no-python/build # src/nox_core -v -i ptcp:6364 packetdump 1|nox|INFO:Starting nox_core (/home/openflow/nox/nox-no-python/build/src/.libs/nox_core) 2|nox|DBG:Application installation report: 3|nox|DBG:built-in DSO deployer: Current state: INSTALLED Required state: INSTALLED Dependencies: 4|nox|DBG:built-in event dispatcher: Current state: INSTALLED Required state: INSTALLED Dependencies: 5|nox|ERR:Application 'packetdump' description not found. Are all the apps dependent on python to run? This is on SUSE (with the recommended addition of all the packages including python-devel python-twisted and python-curses) - is it possible whatever Python version is being used for NOX no longer works with SUSE? Thanks, - Stephen -Original Message- From: nox-dev-boun...@noxrepo.org [mailto:nox-dev-boun...@noxrepo.org] On Behalf Of Stephen Wong Sent: Friday, December 17, 2010 9:41 AM To: 'James Murphy McCauley' Cc: 'nox-dev' Subject: Re: [nox-dev] ERR:Application 'python' description not found when running latest NOX Hi Murphy, See attached. Appreciate your help. Thanks! Thanks, - Stephen -Original Message- From: James Murphy McCauley [mailto:jam...@nau.edu] Sent: Thursday, December 16, 2010 6:54 PM To: Stephen Wong Cc: 'nox-dev' Subject: Re: [nox-dev] ERR:Application 'python' description not found when running latest NOX Could you please post your config.log? -- Murphy On Thu, 2010-12-16 at 17:57 -0800, Stephen Wong wrote: Hi Derek, Yes, I did: linux-ojon:/home/openflow/nox/nox/build # grep -n python * config.h:109:/* Provide macro indicating that twisted python was enabled */ config.log:7: $ ../configure --with-python=yes -- config.log:997:configure:15817: checking for python config.log:998:configure:15835: found /usr/bin/python config.log:999:configure:15847: result: /usr/bin/python config.log:1007:configure:15948: result: -I/usr/include/python2.6 config.log:1009:configure:15977: result: -L/usr/lib64/python2.6/config -lpython2.6 config.log:1011:configure:15990: result: /usr/lib/python2.6/site-packages [snip the rest] What is the 'python' application? Should I try it without python? Thanks, - Stephen -Original Message- From: nox-dev-boun...@noxrepo.org [mailto:nox-dev-boun...@noxrepo.org] On Behalf Of Derek Cormier Sent: Thursday, December 16, 2010 5:24 PM To: nox-dev Subject: Re: [nox-dev] ERR:Application 'python' description not found when running latest NOX Did you call the configure script with python? ./configure --with-python=yes -Derek On 12/17/2010 10:18 AM, Stephen Wong wrote: Hi, I just compiled NOX from the latest repository (make/make check/make install all succeed), but when I tried to run it, I got the following error: openf...@linux-ojon:~/nox/nox/build src/nox_core -i ptcp:6634 -v 1|nox|INFO:Starting nox_core (/home/openflow/nox/nox/build/src/.libs/nox_core) 2|nox|ERR:Application 'python' description not found. And here is the NOX version number: openf...@linux-ojon:~/nox/nox/build src/nox_core -V NOX 0.9.0(zaku)~full~beta (nox_core), compiled Dec 16 2010 16:18:05 Compiled with OpenFlow 0x01 Any help is appreciated. Thanks! Thanks, - Stephen ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org ___ nox-dev mailing list nox-dev@noxrepo.org http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
