Re: [nox-dev] buffer_id in flow_mod messages

2008-08-10 Thread Glen Gibb
My mistake here. UINT32_MAX is the same as -1 for signed numbers. :-)

Thanks for pointing that out Brandon.



Glen Gibb wrote:
> Hi all,
>
> In install_datapath_flow in core.py we have:
>
> def install_datapath_flow(self, dp_id, attrs, max_idle, actions,
>   buffer_id=None,
>   priority=openflow.OFP_DEFAULT_PRIORITY,
>   inport=None, packet=None):
> if buffer_id == None:
> buffer_id = UINT32_MAX
>
>
> Here the buffer_id is set to UINT32_MAX if there is no buffer to apply 
> the flow to. This disagrees with the 0.8.1 spec where it states that the 
> buffer_id should be -1 if the flow isn't to be applied to a buffer.
>
> Glen
>
> ___
> nox-dev mailing list
> nox-dev@noxrepo.org
> http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org
>
>   


___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org


[nox-dev] buffer_id in flow_mod messages

2008-08-10 Thread Glen Gibb
Hi all,

In install_datapath_flow in core.py we have:

def install_datapath_flow(self, dp_id, attrs, max_idle, actions,
  buffer_id=None,
  priority=openflow.OFP_DEFAULT_PRIORITY,
  inport=None, packet=None):
if buffer_id == None:
buffer_id = UINT32_MAX


Here the buffer_id is set to UINT32_MAX if there is no buffer to apply 
the flow to. This disagrees with the 0.8.1 spec where it states that the 
buffer_id should be -1 if the flow isn't to be applied to a buffer.

Glen

___
nox-dev mailing list
nox-dev@noxrepo.org
http://noxrepo.org/mailman/listinfo/nox-dev_noxrepo.org