[NTG-context] [font-otn] bug in node mode
Hi Hans, at least the Plain format breaks as soon as you define a font in node mode: \font \testfont = "lmroman10-regular.otf:mode=node" \testfont foo \bye Patch attached. Best regards, Philipp --- font-otn.lua.orig 2014-03-14 07:42:18.494017054 +0100 +++ font-otn.lua 2014-03-14 07:42:52.937495772 +0100 @@ -2054,8 +2054,8 @@ local features = sequence.features if features then -- for kind, scripts in next, features do -for i=1,#order do -- -local kind = order[i] -- +for i=1,#features do -- +local kind = features[i] -- local valid = enabled[kind] if valid then local scripts = features[kind] -- pgpxgsAvh3VHL.pgp Description: PGP signature ___ If your question is of interest to others as well, please add an entry to the Wiki! maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context webpage : http://www.pragma-ade.nl / http://tex.aanhet.net archive : http://foundry.supelec.fr/projects/contextrev/ wiki : http://contextgarden.net ___
Re: [NTG-context] [font-otn] bug in node mode
On 3/14/2014 7:48 AM, Philipp Gesang wrote: Hi Hans, at least the Plain format breaks as soon as you define a font in node mode: \font \testfont = "lmroman10-regular.otf:mode=node" \testfont foo \bye no, it's: local order = features.order for i=1,#order do -- local kind = order[i] -- - Hans Hagen | PRAGMA ADE Ridderstraat 27 | 8061 GH Hasselt | The Netherlands tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com | www.pragma-pod.nl - ___ If your question is of interest to others as well, please add an entry to the Wiki! maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context webpage : http://www.pragma-ade.nl / http://tex.aanhet.net archive : http://foundry.supelec.fr/projects/contextrev/ wiki : http://contextgarden.net ___
Re: [NTG-context] [font-otn] bug in node mode
· > On 3/14/2014 7:48 AM, Philipp Gesang wrote: > > Hi Hans, > > > > at least the Plain format breaks as soon as you define a font in > > node mode: > > > > \font \testfont = "lmroman10-regular.otf:mode=node" > > \testfont foo > > \bye > > no, it's: > > local order = features.order > for i=1,#order do -- > local kind = order[i] -- D’oh. I shouldn’t patch things before breakfast. Thanks! Philipp pgpr_YHJvb1DM.pgp Description: PGP signature ___ If your question is of interest to others as well, please add an entry to the Wiki! maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context webpage : http://www.pragma-ade.nl / http://tex.aanhet.net archive : http://foundry.supelec.fr/projects/contextrev/ wiki : http://contextgarden.net ___
Re: [NTG-context] [font-otn] bug in node mode
Hi Hans, I’m afraid I have to bother you again with this issue. Consider this code: \font \mainface = "file:EBGaramond12-Regular.otf:mode=node" \mainface foo \bye This breaks with the latest fontloader because in font-otn local function initialize(sequence,script,language,enabled) local features = sequence.features if features then local order = features.order for i=1,#order do -- ... the table “features” never has a field “order”; “sequence” has one occasionally, though not always. Best, Philipp · > On 3/14/2014 7:48 AM, Philipp Gesang wrote: > > Hi Hans, > > > > at least the Plain format breaks as soon as you define a font in > > node mode: > > > > \font \testfont = "lmroman10-regular.otf:mode=node" > > \testfont foo > > \bye > > no, it's: > > local order = features.order > for i=1,#order do -- > local kind = order[i] -- > > > - >Hans Hagen | PRAGMA ADE >Ridderstraat 27 | 8061 GH Hasselt | The Netherlands > tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com > | www.pragma-pod.nl > - > ___ > If your question is of interest to others as well, please add an entry to the > Wiki! > > maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context > webpage : http://www.pragma-ade.nl / http://tex.aanhet.net > archive : http://foundry.supelec.fr/projects/contextrev/ > wiki : http://contextgarden.net > ___ pgpiX_opg32FN.pgp Description: PGP signature ___ If your question is of interest to others as well, please add an entry to the Wiki! maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context webpage : http://www.pragma-ade.nl / http://tex.aanhet.net archive : http://foundry.supelec.fr/projects/contextrev/ wiki : http://contextgarden.net ___
Re: [NTG-context] [font-otn] bug in node mode
On 3/24/2014 8:40 PM, Philipp Gesang wrote: Hi Hans, I’m afraid I have to bother you again with this issue. Consider this code: \font \mainface = "file:EBGaramond12-Regular.otf:mode=node" \mainface foo \bye This breaks with the latest fontloader because in font-otn local function initialize(sequence,script,language,enabled) local features = sequence.features if features then local order = features.order for i=1,#order do -- ... the table “features” never has a field “order”; “sequence” has one occasionally, though not always. should be local function initialize(sequence,script,language,enabled) local features = sequence.features if features then local order = sequence.order if order then for i=1,#order do end else -- can't happen end end return false end went unnoticed as context uses a variant Hans - Hans Hagen | PRAGMA ADE Ridderstraat 27 | 8061 GH Hasselt | The Netherlands tel: 038 477 53 69 | voip: 087 875 68 74 | www.pragma-ade.com | www.pragma-pod.nl - ___ If your question is of interest to others as well, please add an entry to the Wiki! maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context webpage : http://www.pragma-ade.nl / http://tex.aanhet.net archive : http://foundry.supelec.fr/projects/contextrev/ wiki : http://contextgarden.net ___
Re: [NTG-context] [font-otn] bug in node mode
· > On 3/24/2014 8:40 PM, Philipp Gesang wrote: > > Hi Hans, > > > > I’m afraid I have to bother you again with this issue. Consider > > this code: > > > > \font \mainface = "file:EBGaramond12-Regular.otf:mode=node" > > \mainface foo > > \bye > > > > This breaks with the latest fontloader because in font-otn > > > > local function initialize(sequence,script,language,enabled) > > local features = sequence.features > > if features then > > local order = features.order > > for i=1,#order do -- > > ... > > > > the table “features” never has a field “order”; “sequence” has > > one occasionally, though not always. > > should be > > local function initialize(sequence,script,language,enabled) > local features = sequence.features > if features then > local order = sequence.order > if order then > for i=1,#order do > > end > else > -- can't happen > end > end > return false > end > > went unnoticed as context uses a variant This time it’s exactly as I patched it =) Thanks for fixing, Philipp pgp_wRqikBeNA.pgp Description: PGP signature ___ If your question is of interest to others as well, please add an entry to the Wiki! maillist : ntg-context@ntg.nl / http://www.ntg.nl/mailman/listinfo/ntg-context webpage : http://www.pragma-ade.nl / http://tex.aanhet.net archive : http://foundry.supelec.fr/projects/contextrev/ wiki : http://contextgarden.net ___
