Re: [Numpy-discussion] py3k.os_fspath enforces inconsist rules with python3 os.fspath
Will do.
On Mon, Jan 14, 2019 at 7:10 PM Eric Wieser
wrote:
> This looks like a bug to me - can you file it on the issue tracker.
>
> Evidently I did not consider python 2 behavior when backporting
> `os.fspath` from python 3.
>
> Eric
>
> On Mon, 14 Jan 2019 at 16:28 Stuart Reynolds
> wrote:
>
>> After a recent upgrade of numpy (1.13.1 -> 1.6.0), my code is failing
>> where I provide unicode objects as filenames.
>> Previously they were allowed. Now that are not, and I *must* provide a
>> (py2) str or bytearray only.
>>
>> # str is OK
>> $ python2.7 -c "from numpy.compat import py3k; print
>> py3k.os_fspath('123')"
>> 123
>>
>> # unicode is not
>> $ python -c "from numpy.compat import py3k; print py3k.os_fspath(u'123')"
>> Traceback (most recent call last):
>> File "", line 1, in
>> File "/usr/local/lib/python2.7/dist-packages/numpy/compat/py3k.py",
>> line 237, in os_fspath
>> "not " + path_type.__name__)
>> TypeError: expected str, bytes or os.PathLike object, not unicode
>>
>> But this enforcement of "str, bytes or os.PathLike" comes from:
>>https://docs.python.org/3/library/os.html
>> where in Python 3 str is a unicode, and moreover, os.fspath allows
>>
>> $ python3 -c "import os; print(os.fspath(u'123'))" # unicode str
>> 123
>> $ python3 -c "import os; print(os.fspath('123'))" # also unicode str
>> 123
>>
>> so... shouldn't py3k.os_fspath allow py2 unicode obejcts.
>>
>> - Stu
>>
> ___
>> NumPy-Discussion mailing list
>> NumPy-Discussion@python.org
>> https://mail.python.org/mailman/listinfo/numpy-discussion
>>
> ___
> NumPy-Discussion mailing list
> NumPy-Discussion@python.org
> https://mail.python.org/mailman/listinfo/numpy-discussion
>
___
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion
Re: [Numpy-discussion] py3k.os_fspath enforces inconsist rules with python3 os.fspath
Was recently already submitted:
https://github.com/numpy/numpy/issues/12749
On Tue, Jan 15, 2019 at 8:08 AM Stuart Reynolds
wrote:
> Will do.
>
> On Mon, Jan 14, 2019 at 7:10 PM Eric Wieser
> wrote:
>
>> This looks like a bug to me - can you file it on the issue tracker.
>>
>> Evidently I did not consider python 2 behavior when backporting
>> `os.fspath` from python 3.
>>
>> Eric
>>
>> On Mon, 14 Jan 2019 at 16:28 Stuart Reynolds
>> wrote:
>>
>>> After a recent upgrade of numpy (1.13.1 -> 1.6.0), my code is failing
>>> where I provide unicode objects as filenames.
>>> Previously they were allowed. Now that are not, and I *must* provide a
>>> (py2) str or bytearray only.
>>>
>>> # str is OK
>>> $ python2.7 -c "from numpy.compat import py3k; print
>>> py3k.os_fspath('123')"
>>> 123
>>>
>>> # unicode is not
>>> $ python -c "from numpy.compat import py3k; print py3k.os_fspath(u'123')"
>>> Traceback (most recent call last):
>>> File "", line 1, in
>>> File "/usr/local/lib/python2.7/dist-packages/numpy/compat/py3k.py",
>>> line 237, in os_fspath
>>> "not " + path_type.__name__)
>>> TypeError: expected str, bytes or os.PathLike object, not unicode
>>>
>>> But this enforcement of "str, bytes or os.PathLike" comes from:
>>>https://docs.python.org/3/library/os.html
>>> where in Python 3 str is a unicode, and moreover, os.fspath allows
>>>
>>> $ python3 -c "import os; print(os.fspath(u'123'))" # unicode str
>>> 123
>>> $ python3 -c "import os; print(os.fspath('123'))" # also unicode str
>>> 123
>>>
>>> so... shouldn't py3k.os_fspath allow py2 unicode obejcts.
>>>
>>> - Stu
>>>
>> ___
>>> NumPy-Discussion mailing list
>>> NumPy-Discussion@python.org
>>> https://mail.python.org/mailman/listinfo/numpy-discussion
>>>
>> ___
>> NumPy-Discussion mailing list
>> NumPy-Discussion@python.org
>> https://mail.python.org/mailman/listinfo/numpy-discussion
>>
>
___
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion
[Numpy-discussion] Reminder: weekly status meeting Jan 16 at 12:00 pacific time
The draft agenda is at https://hackmd.io/D_0X2QCjRpS-ENiFWokc-g?both# There is a section for community suggested topics, feel free to join the conversation and add in topics that need attention. The BIDS team ___ NumPy-Discussion mailing list NumPy-Discussion@python.org https://mail.python.org/mailman/listinfo/numpy-discussion
