Re: [Numpy-discussion] Failure in test_iterator.py at Travis

2012-12-14 Thread Ondřej Čertík
On Fri, Dec 14, 2012 at 9:49 AM, Nathaniel Smith  wrote:
> The top of the build log has the actual git command they used to check out
> the source - it's some clever GitHub thing that gives the same thing as
> pressing the green button would iirc. You could copy the commands from the
> log to check that out locally though and see what the .travis.tml actually
> says. And if it's wrong poke around in the git history to figure out why.

You are right! I followed the one:

https://travis-ci.org/numpy/numpy/jobs/3330235

and .travis.yml indeed contains the old "python setup.py install"!
I just don't understand why. My strong suspicion is that the actual
commands are *not* equivalent to the github green merge button.

It took the latest patches from the PR (which do not contain the .travis.yml
fix), and merged into:

commit 089bfa5865cd39e2b40099755e8563d8f0d04f5f
Merge: 1065cc5 df2958e
Author: Ralf Gommers 
Date:   Sat Nov 24 02:54:48 2012 -0800

Merge pull request #2766 from g2p/master

Assume we can use sys.stdout.fileno() and friends.


I have no idea why. Unless --- it is merging into the master,
which was current at the time the PR was created. That would explain
it this particular failure.


Ok. And finally, the one at certik/numpy fails, because that one is
checking out the sources
from certik/numpy, but those do not have the improvement. It is then
the Travis's bug, that it links to certik/numpy log
for PRs at numpy/numpy.

So I think that all is explained now.

Ondrej
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Failure in test_iterator.py at Travis

2012-12-14 Thread Nathaniel Smith
The top of the build log has the actual git command they used to check out
the source - it's some clever GitHub thing that gives the same thing as
pressing the green button would iirc. You could copy the commands from the
log to check that out locally though and see what the .travis.tml actually
says. And if it's wrong poke around in the git history to figure out why.

-n
On 14 Dec 2012 17:20, "Ondřej Čertík"  wrote:

> On Fri, Dec 14, 2012 at 12:32 AM, Nathaniel Smith  wrote:
> > I only checked this build:
> > https://secure.travis-ci.org/#!/certik/numpy/jobs/3656960
> > But that log clearly shows 'python setup.py install' being used instead
> of
> > 'pip install'. How certain are you that your branch actually has my fix?
>
> Right. So is this one (using "python setup.py install"):
>
> https://travis-ci.org/numpy/numpy/jobs/3330235
>
> No wonder that it fails. Since I rebased this on top of master and the
> master
> has this fix, and so does the 1.7 branch, I can't explain it. I know that
> the master at certik/numpy github does not have that fix (since I didn't
> push in
> there lately), but I don't see how that could matter, unless there is
> a bug at Travis.
> The branches that I created the pull requests from should have that fix.
>
>
> Ondrej
> ___
> NumPy-Discussion mailing list
> NumPy-Discussion@scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion
>
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Failure in test_iterator.py at Travis

2012-12-14 Thread Ondřej Čertík
On Fri, Dec 14, 2012 at 12:32 AM, Nathaniel Smith  wrote:
> I only checked this build:
> https://secure.travis-ci.org/#!/certik/numpy/jobs/3656960
> But that log clearly shows 'python setup.py install' being used instead of
> 'pip install'. How certain are you that your branch actually has my fix?

Right. So is this one (using "python setup.py install"):

https://travis-ci.org/numpy/numpy/jobs/3330235

No wonder that it fails. Since I rebased this on top of master and the master
has this fix, and so does the 1.7 branch, I can't explain it. I know that
the master at certik/numpy github does not have that fix (since I didn't push in
there lately), but I don't see how that could matter, unless there is
a bug at Travis.
The branches that I created the pull requests from should have that fix.


Ondrej
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Failure in test_iterator.py at Travis

2012-12-14 Thread Nathaniel Smith
I only checked this build:
https://secure.travis-ci.org/#!/certik/numpy/jobs/3656960
But that log clearly shows 'python setup.py install' being used instead of
'pip install'. How certain are you that your branch actually has my fix?
-n
On 14 Dec 2012 03:49, "Ondřej Čertík"  wrote:

> On Thu, Dec 13, 2012 at 7:16 PM, Charles R Harris
>  wrote:
> >
> >
> > On Thu, Dec 13, 2012 at 8:04 PM, Charles R Harris
> >  wrote:
> >>
> >>
> >>
> >> On Thu, Dec 13, 2012 at 7:23 PM, Ondřej Čertík  >
> >> wrote:
> >>>
> >>> Hi,
> >>>
> >>> Another weird bug sometimes happen in
> >>> numpy/core/tests/test_iterator.py, it looks like this:
> >>>
> >>> ==
> >>> FAIL: test_iterator.test_iter_array_cast
> >>> --
> >>> Traceback (most recent call last):
> >>>   File
> >>>
> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/nose/case.py",
> >>> line 197, in runTest
> >>> self.test(*self.arg)
> >>>   File
> >>>
> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/core/tests/test_iterator.py",
> >>> line 836, in test_iter_array_cast
> >>> assert_equal(i.operands[0].strides, (-96,8,-32))
> >>>   File
> >>>
> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
> >>> line 252, in assert_equal
> >>> assert_equal(actual[k], desired[k], 'item=%r\n%s' % (k,err_msg),
> >>> verbose)
> >>>   File
> >>>
> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
> >>> line 314, in assert_equal
> >>> raise AssertionError(msg)
> >>> AssertionError:
> >>> Items are not equal:
> >>> item=0
> >>>
> >>>  ACTUAL: 96
> >>>  DESIRED: -96
> >>>
> >>> --
> >>>
> >>>
> >>> But the problem is that there is no numpy/core/tests/test_iterator.py
> >>> file in current branches This error was triggered for example by
> >>> these PRs:
> >>>
> >>> https://github.com/numpy/numpy/pull/2765
> >>> https://github.com/numpy/numpy/pull/2815
> >>>
> >>> and here are links to the failing Travis tests:
> >>>
> >>> https://travis-ci.org/certik/numpy/builds/3656959
> >>> https://travis-ci.org/numpy/numpy/builds/3330234
> >>>
> >>>
> >>> Any idea what is happening here and how to fix it?
> >>>
> >>
> >> That should have been fixed by Nathaniel's travis fix. Hmm...
> >>
> >
> > And a quick check here shows pip not removing a previous 1.6.2 install.
> > Maybe it is a pip version problem, pip 1.0.2 here.
>
> That's what I thought as well. I think we need to update the Travis
> script to manually remove the installed numpy.
>
> Btw, Travis seems to be using pip 1.2.1, at least according to:
>
> https://travis-ci.org/numpy/numpy/jobs/3330236
>
> Ondrej
> ___
> NumPy-Discussion mailing list
> NumPy-Discussion@scipy.org
> http://mail.scipy.org/mailman/listinfo/numpy-discussion
>
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Failure in test_iterator.py at Travis

2012-12-13 Thread Ondřej Čertík
On Thu, Dec 13, 2012 at 7:16 PM, Charles R Harris
 wrote:
>
>
> On Thu, Dec 13, 2012 at 8:04 PM, Charles R Harris
>  wrote:
>>
>>
>>
>> On Thu, Dec 13, 2012 at 7:23 PM, Ondřej Čertík 
>> wrote:
>>>
>>> Hi,
>>>
>>> Another weird bug sometimes happen in
>>> numpy/core/tests/test_iterator.py, it looks like this:
>>>
>>> ==
>>> FAIL: test_iterator.test_iter_array_cast
>>> --
>>> Traceback (most recent call last):
>>>   File
>>> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/nose/case.py",
>>> line 197, in runTest
>>> self.test(*self.arg)
>>>   File
>>> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/core/tests/test_iterator.py",
>>> line 836, in test_iter_array_cast
>>> assert_equal(i.operands[0].strides, (-96,8,-32))
>>>   File
>>> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
>>> line 252, in assert_equal
>>> assert_equal(actual[k], desired[k], 'item=%r\n%s' % (k,err_msg),
>>> verbose)
>>>   File
>>> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
>>> line 314, in assert_equal
>>> raise AssertionError(msg)
>>> AssertionError:
>>> Items are not equal:
>>> item=0
>>>
>>>  ACTUAL: 96
>>>  DESIRED: -96
>>>
>>> --
>>>
>>>
>>> But the problem is that there is no numpy/core/tests/test_iterator.py
>>> file in current branches This error was triggered for example by
>>> these PRs:
>>>
>>> https://github.com/numpy/numpy/pull/2765
>>> https://github.com/numpy/numpy/pull/2815
>>>
>>> and here are links to the failing Travis tests:
>>>
>>> https://travis-ci.org/certik/numpy/builds/3656959
>>> https://travis-ci.org/numpy/numpy/builds/3330234
>>>
>>>
>>> Any idea what is happening here and how to fix it?
>>>
>>
>> That should have been fixed by Nathaniel's travis fix. Hmm...
>>
>
> And a quick check here shows pip not removing a previous 1.6.2 install.
> Maybe it is a pip version problem, pip 1.0.2 here.

That's what I thought as well. I think we need to update the Travis
script to manually remove the installed numpy.

Btw, Travis seems to be using pip 1.2.1, at least according to:

https://travis-ci.org/numpy/numpy/jobs/3330236

Ondrej
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Failure in test_iterator.py at Travis

2012-12-13 Thread Charles R Harris
On Thu, Dec 13, 2012 at 8:04 PM, Charles R Harris  wrote:

>
>
> On Thu, Dec 13, 2012 at 7:23 PM, Ondřej Čertík wrote:
>
>> Hi,
>>
>> Another weird bug sometimes happen in
>> numpy/core/tests/test_iterator.py, it looks like this:
>>
>> ==
>> FAIL: test_iterator.test_iter_array_cast
>> --
>> Traceback (most recent call last):
>>   File
>> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/nose/case.py",
>> line 197, in runTest
>> self.test(*self.arg)
>>   File
>> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/core/tests/test_iterator.py",
>> line 836, in test_iter_array_cast
>> assert_equal(i.operands[0].strides, (-96,8,-32))
>>   File
>> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
>> line 252, in assert_equal
>> assert_equal(actual[k], desired[k], 'item=%r\n%s' % (k,err_msg),
>> verbose)
>>   File
>> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
>> line 314, in assert_equal
>> raise AssertionError(msg)
>> AssertionError:
>> Items are not equal:
>> item=0
>>
>>  ACTUAL: 96
>>  DESIRED: -96
>>
>> --
>>
>>
>> But the problem is that there is no numpy/core/tests/test_iterator.py
>> file in current branches This error was triggered for example by
>> these PRs:
>>
>> https://github.com/numpy/numpy/pull/2765
>> https://github.com/numpy/numpy/pull/2815
>>
>> and here are links to the failing Travis tests:
>>
>> https://travis-ci.org/certik/numpy/builds/3656959
>> https://travis-ci.org/numpy/numpy/builds/3330234
>>
>>
>> Any idea what is happening here and how to fix it?
>>
>>
> That should have been fixed by Nathaniel's travis fix. Hmm...
>
>
And a quick check here shows pip not removing a previous 1.6.2 install.
Maybe it is a pip version problem, pip 1.0.2 here.

Chuck
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Failure in test_iterator.py at Travis

2012-12-13 Thread Charles R Harris
On Thu, Dec 13, 2012 at 7:23 PM, Ondřej Čertík wrote:

> Hi,
>
> Another weird bug sometimes happen in
> numpy/core/tests/test_iterator.py, it looks like this:
>
> ==
> FAIL: test_iterator.test_iter_array_cast
> --
> Traceback (most recent call last):
>   File
> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/nose/case.py",
> line 197, in runTest
> self.test(*self.arg)
>   File
> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/core/tests/test_iterator.py",
> line 836, in test_iter_array_cast
> assert_equal(i.operands[0].strides, (-96,8,-32))
>   File
> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
> line 252, in assert_equal
> assert_equal(actual[k], desired[k], 'item=%r\n%s' % (k,err_msg),
> verbose)
>   File
> "/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
> line 314, in assert_equal
> raise AssertionError(msg)
> AssertionError:
> Items are not equal:
> item=0
>
>  ACTUAL: 96
>  DESIRED: -96
>
> --
>
>
> But the problem is that there is no numpy/core/tests/test_iterator.py
> file in current branches This error was triggered for example by
> these PRs:
>
> https://github.com/numpy/numpy/pull/2765
> https://github.com/numpy/numpy/pull/2815
>
> and here are links to the failing Travis tests:
>
> https://travis-ci.org/certik/numpy/builds/3656959
> https://travis-ci.org/numpy/numpy/builds/3330234
>
>
> Any idea what is happening here and how to fix it?
>
>
That should have been fixed by Nathaniel's travis fix. Hmm...

Chuck
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


[Numpy-discussion] Failure in test_iterator.py at Travis

2012-12-13 Thread Ondřej Čertík
Hi,

Another weird bug sometimes happen in
numpy/core/tests/test_iterator.py, it looks like this:

==
FAIL: test_iterator.test_iter_array_cast
--
Traceback (most recent call last):
  File 
"/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/nose/case.py",
line 197, in runTest
self.test(*self.arg)
  File 
"/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/core/tests/test_iterator.py",
line 836, in test_iter_array_cast
assert_equal(i.operands[0].strides, (-96,8,-32))
  File 
"/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
line 252, in assert_equal
assert_equal(actual[k], desired[k], 'item=%r\n%s' % (k,err_msg), verbose)
  File 
"/home/travis/virtualenv/python2.5/lib/python2.5/site-packages/numpy/testing/utils.py",
line 314, in assert_equal
raise AssertionError(msg)
AssertionError:
Items are not equal:
item=0

 ACTUAL: 96
 DESIRED: -96

--


But the problem is that there is no numpy/core/tests/test_iterator.py
file in current branches This error was triggered for example by
these PRs:

https://github.com/numpy/numpy/pull/2765
https://github.com/numpy/numpy/pull/2815

and here are links to the failing Travis tests:

https://travis-ci.org/certik/numpy/builds/3656959
https://travis-ci.org/numpy/numpy/builds/3330234


Any idea what is happening here and how to fix it?

Ondrej
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion