Re: [Numpy-discussion] Numpy trunk and 1.4.x branch fail to build with VS2008

2009-11-28 Thread Charles R Harris
On Sat, Nov 28, 2009 at 12:32 PM, Christoph Gohlke  wrote:

> Commenting out the declaration in line 16 of decriptor.h works.
>
>
OK, I went ahead and committed this change.

Chuck
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


[Numpy-discussion] Numpy trunk and 1.4.x branch fail to build with VS2008

2009-11-28 Thread Christoph Gohlke
Commenting out the declaration in line 16 of decriptor.h works.

Christoph
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Numpy trunk and 1.4.x branch fail to build with VS2008

2009-11-28 Thread Charles R Harris
On Sat, Nov 28, 2009 at 12:21 PM, Charles R Harris <
charlesr.har...@gmail.com> wrote:

>
>
> On Sat, Nov 28, 2009 at 12:07 PM, Christoph Gohlke wrote:
>
>> Changing *_datetime_strings[] to **_datetime_strings in descriptor.h
>> results in the following compiler error:
>>
>> numpy\core\src\multiarray\descriptor.c(472) : error C2372:
>> '_datetime_strings' : redefinition; different types of indirection
>>
>> numpy\core\src\multiarray\descriptor.h(16) : see declaration of
>> '_datetime_strings'
>>
>>
> The problem is that the bit in the header looks like a declaration. Try
> commenting out the line like so:
>
> /*NPY_NO_EXPORT char *_datetime_strings[];*/
>
>
In case that wasn't precise enough, it should look like this:

#ifdef NPY_ENABLE_SEPARATE_COMPILATION
extern NPY_NO_EXPORT char *_datetime_strings[];
#else
/*NPY_NO_EXPORT char *_datetime_strings[];*/
#endif

Chuck
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Numpy trunk and 1.4.x branch fail to build with VS2008

2009-11-28 Thread Charles R Harris
On Sat, Nov 28, 2009 at 12:07 PM, Christoph Gohlke  wrote:

> Changing *_datetime_strings[] to **_datetime_strings in descriptor.h
> results in the following compiler error:
>
> numpy\core\src\multiarray\descriptor.c(472) : error C2372:
> '_datetime_strings' : redefinition; different types of indirection
>
> numpy\core\src\multiarray\descriptor.h(16) : see declaration of
> '_datetime_strings'
>
>
The problem is that the bit in the header looks like a declaration. Try
commenting out the line like so:

/*NPY_NO_EXPORT char *_datetime_strings[];*/

Chuck
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


[Numpy-discussion] Numpy trunk and 1.4.x branch fail to build with VS2008

2009-11-28 Thread Christoph Gohlke
Changing *_datetime_strings[] to **_datetime_strings in descriptor.h 
results in the following compiler error:

numpy\core\src\multiarray\descriptor.c(472) : error C2372: 
'_datetime_strings' : redefinition; different types of indirection

numpy\core\src\multiarray\descriptor.h(16) : see declaration of 
'_datetime_strings'

Christoph
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


Re: [Numpy-discussion] Numpy trunk and 1.4.x branch fail to build with VS2008

2009-11-28 Thread Charles R Harris
On Sat, Nov 28, 2009 at 11:27 AM, Christoph Gohlke  wrote:

> The current numpy sources from svn trunk (r7772 or newer) and the 1.4.x
> branch fail to build with Visual Studio 2008 with the following compiler
> error:
>
> numpy\core\src\multiarray\descriptor.h(16) : error C2133:
> '_datetime_strings' : unknown size
>
> A quick fix is to specify the size of the _datetime_strings array, e.g.
> _datetime_strings[14].
>
>
What happens if you just replace:

*_datetime_strings[];

by

**_datetime_strings;

Chuck
___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion


[Numpy-discussion] Numpy trunk and 1.4.x branch fail to build with VS2008

2009-11-28 Thread Christoph Gohlke
The current numpy sources from svn trunk (r7772 or newer) and the 1.4.x 
branch fail to build with Visual Studio 2008 with the following compiler 
error:

numpy\core\src\multiarray\descriptor.h(16) : error C2133: 
'_datetime_strings' : unknown size

A quick fix is to specify the size of the _datetime_strings array, e.g. 
_datetime_strings[14].

Christoph

___
NumPy-Discussion mailing list
NumPy-Discussion@scipy.org
http://mail.scipy.org/mailman/listinfo/numpy-discussion