Re: [PR] OAK-10904: change token refresh executor to use daemon thread [jackrabbit-oak]

[via GitHub]

t-rana commented on code in PR #1545:
URL: https://github.com/apache/jackrabbit-oak/pull/1545#discussion_r1648425265


##
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java:
##
@@ -74,7 +74,12 @@ public final class AzureUtilities {
 private static final long TOKEN_REFRESHER_DELAY = 1L;
 
 private static final Logger log = 
LoggerFactory.getLogger(AzureUtilities.class);
-private static final ScheduledExecutorService executorService = 
Executors.newSingleThreadScheduledExecutor();
+
+private static final ScheduledExecutorService executorService = 
Executors.newSingleThreadScheduledExecutor(runnable -> {

Review Comment:
   > Not closing it properly could cause random issues in tests for example
   
   I did not face any issues in the test suite run, can you please elaborate so 
that I can handle the same? I guess the framework running test terminates the 
JVM and shutdown method is executed which will close this exectuor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GH] (jackrabbit-oak): Workflow run "SonarCloud" failed!

[GitBox]

The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has failed.
Run started by GitHub user rishabhdaim (triggered by rishabhdaim).

Head commit for run:
6a6864d29a3b866964e4d69458444f4efae1fab4 / Rishabh Kumar 
OAK-10912 : make fullGc include/exclude configurable via OSGI config

Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/9612530777

With regards,
GitHub Actions via GitBox

[GH] (jackrabbit-oak): Workflow run "SonarCloud" is working again!

[GitBox]

The GitHub Actions job "SonarCloud" on jackrabbit-oak.git has succeeded.
Run started by GitHub user nfsantos (triggered by nfsantos).

Head commit for run:
60901a78e79c87e964c78851072eb303369d7c83 / Nuno Santos 
Merge remote-tracking branch 'upstream/trunk' into OAK-10901

Report URL: https://github.com/apache/jackrabbit-oak/actions/runs/9611044599

With regards,
GitHub Actions via GitBox