Re: parent pom env.OAK_INTEGRATION_TESTING

2016-03-23 Thread Davide Giannella 
On 23/03/2016 11:18, Jukka Zitting wrote:
> See https://issues.apache.org/jira/browse/OAK-163 for original discussion
> about the environment flag.
>
> Back then the integration tests were only just becoming too long to run as
> a part of the regular build, so it made sense to keep that option around
> for people who wanted the earlier behavior. But I'd be surprised if someone
> still uses the flag.
>
>
Thanks Jukka. Nice to see you again ;)

Speaking of CI, none of the CIs we currently have in place that I'm
aware are using such flag. It feels safe therefore to change it.

Last call: any objections? :)

Davide

Re: parent pom env.OAK_INTEGRATION_TESTING

2016-03-23 Thread Jukka Zitting 
See https://issues.apache.org/jira/browse/OAK-163 for original discussion
about the environment flag.

Back then the integration tests were only just becoming too long to run as
a part of the regular build, so it made sense to keep that option around
for people who wanted the earlier behavior. But I'd be surprised if someone
still uses the flag.

Best,

Jukka


On Wed, Mar 23, 2016 at 5:03 AM Davide Giannella  wrote:

> On 23/03/2016 03:11, Chetan Mehrotra wrote:
> > On Tue, Mar 22, 2016 at 9:49 PM, Davide Giannella 
> wrote:
> >> I can't really recall why and if we use this.
> > Its referred to in main README.md so as to allow a developer to always
> > enable running of integration test
> >
> Thanks Chetan.
>
> Is anyone using this, or aware of any process using this?
>
> Objections if I replace it with something else?
>
> Thanks
> Davide
>

Re: parent pom env.OAK_INTEGRATION_TESTING

2016-03-23 Thread Davide Giannella 
On 23/03/2016 03:11, Chetan Mehrotra wrote:
> On Tue, Mar 22, 2016 at 9:49 PM, Davide Giannella  wrote:
>> I can't really recall why and if we use this.
> Its referred to in main README.md so as to allow a developer to always
> enable running of integration test
>
Thanks Chetan.

Is anyone using this, or aware of any process using this?

Objections if I replace it with something else?

Thanks
Davide

Re: parent pom env.OAK_INTEGRATION_TESTING

2016-03-22 Thread Chetan Mehrotra 
On Tue, Mar 22, 2016 at 9:49 PM, Davide Giannella  wrote:
> I can't really recall why and if we use this.

Its referred to in main README.md so as to allow a developer to always
enable running of integration test

Chetan Mehrotra

parent pom env.OAK_INTEGRATION_TESTING

2016-03-22 Thread Davide Giannella 
hello team

I was trying to achieve https://issues.apache.org/jira/browse/OAK-4136
by enabling multiple profiles using the same property when I stumbled
upon the variable `env.OAK_INTEGRATION_TESTING` for the
`integrationTesting` profile

https://github.com/apache/jackrabbit-oak/blob/8af23571f44055ba28b850c45b17de8818fbbff6/oak-parent/pom.xml#L566

I can't really recall why and if we use this.

I didn't find any references in the apache jenkins as well.

Do you think it's something safe to remove? Where is it used if it is?

Thanks
Davide