[jira] [Created] (OAK-305) Updated Oak site layout
Jukka Zitting created OAK-305: - Summary: Updated Oak site layout Key: OAK-305 URL: https://issues.apache.org/jira/browse/OAK-305 Project: Jackrabbit Oak Issue Type: Improvement Reporter: Jukka Zitting Assignee: Jukka Zitting Priority: Minor As discussed on oak-dev@ (http://markmail.org/message/e2pzcdtrxv7aqd6f), a designer at Adobe has contributed an updated site layout for us. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-6) Setup integration tests and TCK tests
[ https://issues.apache.org/jira/browse/OAK-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455763#comment-13455763 ] Michael Dürig commented on OAK-6: - TCK status: Tests: 1906, Errors: 196, Failures: 55 > Setup integration tests and TCK tests > - > > Key: OAK-6 > URL: https://issues.apache.org/jira/browse/OAK-6 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: it >Reporter: Michael Dürig > Labels: test > Fix For: 0.1 > > > See discussion here [1] and here [2] > [1] > http://markmail.org/message/km64ybgh5g7hvtiy?q=Jackrabbit+Oak+0.1+release+plan+%28Was:+[jr3]+Release+roadmap%29 > [2] http://markmail.org/message/pwtxszvupvxyagk5?q=Integration+Tests+with+TCK -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-66) JCR Node Type Management
[ https://issues.apache.org/jira/browse/OAK-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455752#comment-13455752 ] Michael Dürig commented on OAK-66: -- bq. TCK test content is insufficient for full test coverage. At revision 1384406 test content is sufficient to get full coverage of all node type tests. Revision 1384741 fixes all additional issues which have surfaced except for OAK-302. > JCR Node Type Management > > > Key: OAK-66 > URL: https://issues.apache.org/jira/browse/OAK-66 > Project: Jackrabbit Oak > Issue Type: Task > Components: core, jcr >Reporter: angela > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-304) Rename ContentSession.getCurrentRoot()
[ https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-304: --- Summary: Rename ContentSession.getCurrentRoot() (was: Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()) > Rename ContentSession.getCurrentRoot() > -- > > Key: OAK-304 > URL: https://issues.apache.org/jira/browse/OAK-304 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Attachments: OAK-304.patch > > > Renaming the method would make it clear that the method is potentially > expensive and the returned object reflects the head of the repository at the > time the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
[ https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455750#comment-13455750 ] Thomas Mueller commented on OAK-304: > -1 to adding even more words to the method name. My idea was: the longer the name, the more careful people are to call it :-) Given that the method is rather expensive, that would be actually an advantage in this case. OK just joking. getLatestRoot() is fine for me. > OAK-201 Thanks. I initially created OAK-201 because of explicit Session.refresh calls which seem to be gone now thanks to Marcels patch. But it seems there might still be potential to speed things up, by not calling getCurrentRoot / getLatestRoot for each getPrefix or getURI. > Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot() > -- > > Key: OAK-304 > URL: https://issues.apache.org/jira/browse/OAK-304 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Attachments: OAK-304.patch > > > Renaming the method would make it clear that the method is potentially > expensive and the returned object reflects the head of the repository at the > time the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
[
https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455720#comment-13455720
]
Michael Dürig commented on OAK-304:
---
Ok lets settle for {{getLatestRoot()}} then and not introduce new terminology.
> Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
> --
>
> Key: OAK-304
> URL: https://issues.apache.org/jira/browse/OAK-304
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
> Attachments: OAK-304.patch
>
>
> Renaming the method would make it clear that the method is potentially
> expensive and the returned object reflects the head of the repository at the
> time the method is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
[ https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455716#comment-13455716 ] Jukka Zitting commented on OAK-304: --- The term "head" is currently not used anywhere above the MicroKernel. I'd rather not introduce the term but if we want to do so, I'd simply name the method getHead(), with the definition that the "head" is the "latest root". > Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot() > -- > > Key: OAK-304 > URL: https://issues.apache.org/jira/browse/OAK-304 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Attachments: OAK-304.patch > > > Renaming the method would make it clear that the method is potentially > expensive and the returned object reflects the head of the repository at the > time the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
[
https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455711#comment-13455711
]
Michael Dürig commented on OAK-304:
---
+1 for renaming but -1 for the name {{getCurrentHeadRoot}}.
Either {{getHeadRoot}} or {{getLatestRoot}} with a slight preference for the
former would be fine for me.
> Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
> --
>
> Key: OAK-304
> URL: https://issues.apache.org/jira/browse/OAK-304
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
> Attachments: OAK-304.patch
>
>
> Renaming the method would make it clear that the method is potentially
> expensive and the returned object reflects the head of the repository at the
> time the method is called.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
[ https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455708#comment-13455708 ] Jukka Zitting commented on OAK-304: --- -1 to adding even more words to the method name. Would getLatestRoot() be clearer? > Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot() > -- > > Key: OAK-304 > URL: https://issues.apache.org/jira/browse/OAK-304 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Attachments: OAK-304.patch > > > Renaming the method would make it clear that the method is potentially > expensive and the returned object reflects the head of the repository at the > time the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
[ https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455707#comment-13455707 ] Michael Dürig commented on OAK-304: --- bq. It seems to me that some existing code might call getCurrentRoot() / getCurrentHeadRoot() unnecessarily, see also OAK-201 > Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot() > -- > > Key: OAK-304 > URL: https://issues.apache.org/jira/browse/OAK-304 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Attachments: OAK-304.patch > > > Renaming the method would make it clear that the method is potentially > expensive and the returned object reflects the head of the repository at the > time the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
[ https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455702#comment-13455702 ] Thomas Mueller commented on OAK-304: It seems to me that some existing code might call getCurrentRoot() / getCurrentHeadRoot() unnecessarily, such as NamespaceRegistryImpl.getURI(String prefix) and getPrefix(String uri). This is specially a problem because those methods are called from the oak-jcr SessionNameMapper.getOakPrefix() and this is called from SessionDelegate.getOakNameOrThrow() and so on. But maybe I'm wrong and it is in fact important that those methods always operate on the head? > Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot() > -- > > Key: OAK-304 > URL: https://issues.apache.org/jira/browse/OAK-304 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Attachments: OAK-304.patch > > > Renaming the method would make it clear that the method is potentially > expensive and the returned object reflects the head of the repository at the > time the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
[ https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-304: --- Attachment: OAK-304.patch > Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot() > -- > > Key: OAK-304 > URL: https://issues.apache.org/jira/browse/OAK-304 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller > Attachments: OAK-304.patch > > > Renaming the method would make it clear that the method is potentially > expensive and the returned object reflects the head of the repository at the > time the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
Thomas Mueller created OAK-304: -- Summary: Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot() Key: OAK-304 URL: https://issues.apache.org/jira/browse/OAK-304 Project: Jackrabbit Oak Issue Type: Improvement Reporter: Thomas Mueller Renaming the method would make it clear that the method is potentially expensive and the returned object reflects the head of the repository at the time the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (OAK-304) Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot()
[ https://issues.apache.org/jira/browse/OAK-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller reassigned OAK-304: -- Assignee: Thomas Mueller > Rename ContentSession.getCurrentRoot() to getCurrentHeadRoot() > -- > > Key: OAK-304 > URL: https://issues.apache.org/jira/browse/OAK-304 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller > > Renaming the method would make it clear that the method is potentially > expensive and the returned object reflects the head of the repository at the > time the method is called. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OAK-303) The query engine should use a stable root (not always the head)
[ https://issues.apache.org/jira/browse/OAK-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-303: --- Description: Currently the query engine re-acquires the head root for each read operation. It should use a stable root instead. > The query engine should use a stable root (not always the head) > --- > > Key: OAK-303 > URL: https://issues.apache.org/jira/browse/OAK-303 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core, jcr >Reporter: Thomas Mueller > > Currently the query engine re-acquires the head root for each read operation. > It should use a stable root instead. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OAK-303) The query engine should use a stable root (not always the head)
Thomas Mueller created OAK-303: -- Summary: The query engine should use a stable root (not always the head) Key: OAK-303 URL: https://issues.apache.org/jira/browse/OAK-303 Project: Jackrabbit Oak Issue Type: Improvement Components: core, jcr Reporter: Thomas Mueller -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-302) Incorrect results when converting binary values
[
https://issues.apache.org/jira/browse/OAK-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455676#comment-13455676
]
Michael Dürig commented on OAK-302:
---
It seems {{ValueImpl}} doesn't correctly convert to a string value first when
converting to any other value than a string value. Instead it relies on the
{{getString()}} method of the underlying {{CoreValue}} which simply returns the
{{binaryID}}.
> Incorrect results when converting binary values
> ---
>
> Key: OAK-302
> URL: https://issues.apache.org/jira/browse/OAK-302
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
>Reporter: Michael Dürig
>
> {code}
> Value bin = valueFactory.createValue("123", PropertyType.BINARY);
> System.out.println(bin.getString());
> System.out.println(bin.getLong());
> System.out.println(bin.getDouble());
> {code}
> results in
> {code}
> 123
> 3313233
> 3313233.0
> {code}
> it should however be
> {code}
> 123
> 123
> 123.0
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (OAK-302) Incorrect results when converting binary values
Michael Dürig created OAK-302:
-
Summary: Incorrect results when converting binary values
Key: OAK-302
URL: https://issues.apache.org/jira/browse/OAK-302
Project: Jackrabbit Oak
Issue Type: Bug
Components: jcr
Reporter: Michael Dürig
{code}
Value bin = valueFactory.createValue("123", PropertyType.BINARY);
System.out.println(bin.getString());
System.out.println(bin.getLong());
System.out.println(bin.getDouble());
{code}
results in
{code}
123
3313233
3313233.0
{code}
it should however be
{code}
123
123
123.0
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
