[jira] [Commented] (OAK-4067) AssertionError thrown for Lucene index with empty suggest disctionary
[
https://issues.apache.org/jira/browse/OAK-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107439#comment-16107439
]
Vikas Saurabh commented on OAK-4067:
Backported [r1732418|https://svn.apache.org/r1732418] and
[r1732435|https://svn.apache.org/r1732435] from trunk to 1.2 branch in
[r1803544|https://svn.apache.org/1803544].
> AssertionError thrown for Lucene index with empty suggest disctionary
> --
>
> Key: OAK-4067
> URL: https://issues.apache.org/jira/browse/OAK-4067
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Reporter: Chetan Mehrotra
>Assignee: Tommaso Teofili
>Priority: Critical
> Labels: candidate_oak_1_2
> Fix For: 1.4, 1.2.27
>
>
> Create an index where one field is enabled for suggestion but no content is
> indexed for that index i.e. no matching content. Then while performing any
> query following exception is thrown
> {noformat}
> java.lang.AssertionError
> at
> org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.(AnalyzingInfixSuggester.java:167)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper$2.(SuggestHelper.java:127)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper.getLookup(SuggestHelper.java:127)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper.getLookup(SuggestHelper.java:123)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexNode.(IndexNode.java:109)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexNode.open(IndexNode.java:69)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.findIndexNode(IndexTracker.java:162)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.acquireIndexNode(IndexTracker.java:137)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex.getPlans(LucenePropertyIndex.java:249)
> at
> org.apache.jackrabbit.oak.query.QueryImpl.getBestSelectorExecutionPlan(QueryImpl.java:1016)
> at
> org.apache.jackrabbit.oak.query.QueryImpl.getBestSelectorExecutionPlan(QueryImpl.java:949)
> at
> org.apache.jackrabbit.oak.query.ast.SelectorImpl.prepare(SelectorImpl.java:288)
> {noformat}
> This happens with {{-ea}} flag i.e. java assertions enabled. It caused
> [here|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/4.7.1/lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/AnalyzingInfixSuggester.java#L167]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-4067) AssertionError thrown for Lucene index with empty suggest disctionary
[
https://issues.apache.org/jira/browse/OAK-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-4067:
---
Fix Version/s: 1.2.27
> AssertionError thrown for Lucene index with empty suggest disctionary
> --
>
> Key: OAK-4067
> URL: https://issues.apache.org/jira/browse/OAK-4067
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Reporter: Chetan Mehrotra
>Assignee: Tommaso Teofili
>Priority: Critical
> Labels: candidate_oak_1_2
> Fix For: 1.4, 1.2.27
>
>
> Create an index where one field is enabled for suggestion but no content is
> indexed for that index i.e. no matching content. Then while performing any
> query following exception is thrown
> {noformat}
> java.lang.AssertionError
> at
> org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.(AnalyzingInfixSuggester.java:167)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper$2.(SuggestHelper.java:127)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper.getLookup(SuggestHelper.java:127)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper.getLookup(SuggestHelper.java:123)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexNode.(IndexNode.java:109)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexNode.open(IndexNode.java:69)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.findIndexNode(IndexTracker.java:162)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.acquireIndexNode(IndexTracker.java:137)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex.getPlans(LucenePropertyIndex.java:249)
> at
> org.apache.jackrabbit.oak.query.QueryImpl.getBestSelectorExecutionPlan(QueryImpl.java:1016)
> at
> org.apache.jackrabbit.oak.query.QueryImpl.getBestSelectorExecutionPlan(QueryImpl.java:949)
> at
> org.apache.jackrabbit.oak.query.ast.SelectorImpl.prepare(SelectorImpl.java:288)
> {noformat}
> This happens with {{-ea}} flag i.e. java assertions enabled. It caused
> [here|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/4.7.1/lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/AnalyzingInfixSuggester.java#L167]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-6503) Active deletion of blobs tries to delete sub-16k inlined blobs in case of seg-tar
[
https://issues.apache.org/jira/browse/OAK-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-6503:
---
Fix Version/s: (was: 1.7.5)
1.7.6
> Active deletion of blobs tries to delete sub-16k inlined blobs in case of
> seg-tar
> -
>
> Key: OAK-6503
> URL: https://issues.apache.org/jira/browse/OAK-6503
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.7.1
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.8, 1.7.6
>
>
> {{OakDirectory#deleteFile}} registers a blob as deleted for actively purged
> even if {{blob.getContentIdentity}} is null \[0]. That leads to active purge
> trying to purge an inlined blob and hitting a bening warn in the log (and of
> course a perf issue to "find" that the blob couldn't really be purged)
> \[0]:
> https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.7.1/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/OakDirectory.java#L168-L173
> {code}
> String blobId = b.getContentIdentity();
> if (blobId == null) {
> blobId = b.toString();
> }
> blobDeletionCallback.deleted(blobId,
> Lists.newArrayList(definition.getIndexPath(),
> dataNodeName, name));
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Resolved] (OAK-6503) Active deletion of blobs tries to delete sub-16k inlined blobs in case of seg-tar
[
https://issues.apache.org/jira/browse/OAK-6503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh resolved OAK-6503.
Resolution: Fixed
Fix Version/s: 1.7.5
Fixed in trunk at [r1803532|https://svn.apache.org/r1803532].
> Active deletion of blobs tries to delete sub-16k inlined blobs in case of
> seg-tar
> -
>
> Key: OAK-6503
> URL: https://issues.apache.org/jira/browse/OAK-6503
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.7.1
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.8, 1.7.5
>
>
> {{OakDirectory#deleteFile}} registers a blob as deleted for actively purged
> even if {{blob.getContentIdentity}} is null \[0]. That leads to active purge
> trying to purge an inlined blob and hitting a bening warn in the log (and of
> course a perf issue to "find" that the blob couldn't really be purged)
> \[0]:
> https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.7.1/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/OakDirectory.java#L168-L173
> {code}
> String blobId = b.getContentIdentity();
> if (blobId == null) {
> blobId = b.toString();
> }
> blobDeletionCallback.deleted(blobId,
> Lists.newArrayList(definition.getIndexPath(),
> dataNodeName, name));
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-4067) AssertionError thrown for Lucene index with empty suggest disctionary
[
https://issues.apache.org/jira/browse/OAK-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107193#comment-16107193
]
Tommaso Teofili commented on OAK-4067:
--
+1
> AssertionError thrown for Lucene index with empty suggest disctionary
> --
>
> Key: OAK-4067
> URL: https://issues.apache.org/jira/browse/OAK-4067
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Reporter: Chetan Mehrotra
>Assignee: Tommaso Teofili
>Priority: Critical
> Labels: candidate_oak_1_2
> Fix For: 1.4
>
>
> Create an index where one field is enabled for suggestion but no content is
> indexed for that index i.e. no matching content. Then while performing any
> query following exception is thrown
> {noformat}
> java.lang.AssertionError
> at
> org.apache.lucene.search.suggest.analyzing.AnalyzingInfixSuggester.(AnalyzingInfixSuggester.java:167)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper$2.(SuggestHelper.java:127)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper.getLookup(SuggestHelper.java:127)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.util.SuggestHelper.getLookup(SuggestHelper.java:123)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexNode.(IndexNode.java:109)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexNode.open(IndexNode.java:69)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.findIndexNode(IndexTracker.java:162)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.acquireIndexNode(IndexTracker.java:137)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LucenePropertyIndex.getPlans(LucenePropertyIndex.java:249)
> at
> org.apache.jackrabbit.oak.query.QueryImpl.getBestSelectorExecutionPlan(QueryImpl.java:1016)
> at
> org.apache.jackrabbit.oak.query.QueryImpl.getBestSelectorExecutionPlan(QueryImpl.java:949)
> at
> org.apache.jackrabbit.oak.query.ast.SelectorImpl.prepare(SelectorImpl.java:288)
> {noformat}
> This happens with {{-ea}} flag i.e. java assertions enabled. It caused
> [here|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/4.7.1/lucene/suggest/src/java/org/apache/lucene/search/suggest/analyzing/AnalyzingInfixSuggester.java#L167]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (OAK-4891) Mount-time sanity checks for mounted NodeStore instances
[ https://issues.apache.org/jira/browse/OAK-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107123#comment-16107123 ] Robert Munteanu edited comment on OAK-4891 at 7/31/17 10:42 AM: Right, referenceable nodes will have to be disabled by default, but IIRC there was some discussion about moving to oak:resource which is not referenceable. Will have to dig that up. was (Author: rombert): Right, referenceable nodes will have to be disabled by default, but IIRC there was some discussion about moving to oak:resources which is not referenceable. Will have to dig that up. > Mount-time sanity checks for mounted NodeStore instances > > > Key: OAK-4891 > URL: https://issues.apache.org/jira/browse/OAK-4891 > Project: Jackrabbit Oak > Issue Type: Task > Components: core >Reporter: Robert Munteanu >Assignee: Tomek Rękawek > Fix For: 1.8, 1.7.6 > > > When mounting a NodeStore we should be able to run a quick sanity check to > make sure that it does not use any features which are troublesome, notably > those which would contribute to one of the 'global' states of Oak: > - versioned nodes > - referenceable nodes > - etc ( more TDB ) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-4891) Mount-time sanity checks for mounted NodeStore instances
[ https://issues.apache.org/jira/browse/OAK-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107123#comment-16107123 ] Robert Munteanu commented on OAK-4891: -- Right, referenceable nodes will have to be disabled by default, but IIRC there was some discussion about moving to oak:resources which is not referenceable. Will have to dig that up. > Mount-time sanity checks for mounted NodeStore instances > > > Key: OAK-4891 > URL: https://issues.apache.org/jira/browse/OAK-4891 > Project: Jackrabbit Oak > Issue Type: Task > Components: core >Reporter: Robert Munteanu >Assignee: Tomek Rękawek > Fix For: 1.8, 1.7.6 > > > When mounting a NodeStore we should be able to run a quick sanity check to > make sure that it does not use any features which are troublesome, notably > those which would contribute to one of the 'global' states of Oak: > - versioned nodes > - referenceable nodes > - etc ( more TDB ) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6506) Ensure unique property indexes are consistent when mounting NodeStores
[ https://issues.apache.org/jira/browse/OAK-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated OAK-6506: - Summary: Ensure unique property indexes are consistent when mounting NodeStores (was: Ensure unique property indexes are consitent when mounting NodeStores) > Ensure unique property indexes are consistent when mounting NodeStores > -- > > Key: OAK-6506 > URL: https://issues.apache.org/jira/browse/OAK-6506 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: composite >Reporter: Robert Munteanu > Fix For: 1.8, 1.7.6 > > > When mounting a NodeStore in a composite setup, we should validate that the > unique property indexes do not contain duplicate entries across all the node > stores. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-4891) Mount-time sanity checks for mounted NodeStore instances
[
https://issues.apache.org/jira/browse/OAK-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107115#comment-16107115
]
Tomek Rękawek commented on OAK-4891:
[~rombert] - sure. I'd say that the runtime checks are covered:
* the CrossMountReferenceValidator takes care of the cross-mount references
OAK-6256,
* ReferenceEditorProvider won't allow to create a reference with missing target,
* PropertyIndexEditorProvider doesn't allow to create duplicate entries on two
different mounts.
With regards to the mount-time checks, I think we can't forbid the
referenceable nodes completely, as the {{nt:file}} is referenceable. That's why
the OAK-6256 looks for cross-mount references, not for any referenceable nodes.
I think it'd be good to use the same logic in the mount time as well (as in my
comment to OAK-6445 - it'll work even without a commit).
+1 to the uniqueness. I don't have any other mount-time tests in mind right now.
> Mount-time sanity checks for mounted NodeStore instances
>
>
> Key: OAK-4891
> URL: https://issues.apache.org/jira/browse/OAK-4891
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: core
>Reporter: Robert Munteanu
>Assignee: Tomek Rękawek
> Fix For: 1.8, 1.7.6
>
>
> When mounting a NodeStore we should be able to run a quick sanity check to
> make sure that it does not use any features which are troublesome, notably
> those which would contribute to one of the 'global' states of Oak:
> - versioned nodes
> - referenceable nodes
> - etc ( more TDB )
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OAK-937) Query engine index selection tweaks: shortcut and hint
[ https://issues.apache.org/jira/browse/OAK-937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107080#comment-16107080 ] Tommaso Teofili commented on OAK-937: - I think this is a somewhat sensitive feature, my concern is that it can be easily misused, as it exposes implementation details in a sort of API (the query language syntax). On the other hand I have seen cases where users would have liked to have such syntax. At the moment IMHO we are in a sort of middle ground where users can / have to know how to define and use indexes but we also suggest not to touch certain configurations or reindex in most of the cases. Probably we should decide whether users should be caring about indexes or not, or at least mark some features as experimental or expert so that users are less unaware that they could shoot themselves in their feet. > Query engine index selection tweaks: shortcut and hint > -- > > Key: OAK-937 > URL: https://issues.apache.org/jira/browse/OAK-937 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: query >Reporter: Alex Deparvu >Assignee: Thomas Mueller >Priority: Critical > Labels: performance > Fix For: 1.8 > > > This issue covers 2 different changes related to the way the QueryEngine > selects a query index: > Firstly there could be a way to end the index selection process early via a > known constant value: if an index returns a known value token (like -1000) > then the query engine would effectively stop iterating through the existing > index impls and use that index directly. > Secondly it would be nice to be able to specify a desired index (if one is > known to perform better) thus skipping the existing selection mechanism (cost > calculation and comparison). This could be done via certain query hints [0]. > [0] http://en.wikipedia.org/wiki/Hint_(SQL) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OAK-6506) Ensure unique property indexes are consitent when mounting NodeStores
Robert Munteanu created OAK-6506: Summary: Ensure unique property indexes are consitent when mounting NodeStores Key: OAK-6506 URL: https://issues.apache.org/jira/browse/OAK-6506 Project: Jackrabbit Oak Issue Type: Technical task Components: composite Reporter: Robert Munteanu Fix For: 1.8, 1.7.6 When mounting a NodeStore in a composite setup, we should validate that the unique property indexes do not contain duplicate entries across all the node stores. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (OAK-6505) Ensure mounted node stores don't contain referenceable nodes
Robert Munteanu created OAK-6505: Summary: Ensure mounted node stores don't contain referenceable nodes Key: OAK-6505 URL: https://issues.apache.org/jira/browse/OAK-6505 Project: Jackrabbit Oak Issue Type: Technical task Components: composite Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: 1.8, 1.7.6 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-4891) Mount-time sanity checks for mounted NodeStore instances
[ https://issues.apache.org/jira/browse/OAK-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated OAK-4891: - Fix Version/s: 1.7.6 1.8 > Mount-time sanity checks for mounted NodeStore instances > > > Key: OAK-4891 > URL: https://issues.apache.org/jira/browse/OAK-4891 > Project: Jackrabbit Oak > Issue Type: Task > Components: core >Reporter: Robert Munteanu >Assignee: Tomek Rękawek > Fix For: 1.8, 1.7.6 > > > When mounting a NodeStore we should be able to run a quick sanity check to > make sure that it does not use any features which are troublesome, notably > those which would contribute to one of the 'global' states of Oak: > - versioned nodes > - referenceable nodes > - etc ( more TDB ) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OAK-4891) Mount-time sanity checks for mounted NodeStore instances
[ https://issues.apache.org/jira/browse/OAK-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107077#comment-16107077 ] Robert Munteanu commented on OAK-4891: -- [~tomek.rekawek] - I suggest that we split the approach in two: - mount-time checks ( this task ), which will validate that the mounted node stores are provisioned correctly - runtime checks ( new task ), which will validate that no incorrect content is added For this task I intended to add checks for referenceable nodes and entries in unique indexes. Do you see anything else that we can check at mount time? > Mount-time sanity checks for mounted NodeStore instances > > > Key: OAK-4891 > URL: https://issues.apache.org/jira/browse/OAK-4891 > Project: Jackrabbit Oak > Issue Type: Task > Components: core >Reporter: Robert Munteanu >Assignee: Tomek Rękawek > > When mounting a NodeStore we should be able to run a quick sanity check to > make sure that it does not use any features which are troublesome, notably > those which would contribute to one of the 'global' states of Oak: > - versioned nodes > - referenceable nodes > - etc ( more TDB ) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (OAK-6445) Ensure mounted node stores don't contain versionable nodes
[ https://issues.apache.org/jira/browse/OAK-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved OAK-6445. -- Resolution: Fixed Fixed in [r1803501|https://svn.apache.org/r1803501] > Ensure mounted node stores don't contain versionable nodes > -- > > Key: OAK-6445 > URL: https://issues.apache.org/jira/browse/OAK-6445 > Project: Jackrabbit Oak > Issue Type: Sub-task > Components: composite >Reporter: Robert Munteanu >Assignee: Robert Munteanu > Fix For: 1.8, 1.7.6 > > Attachments: > 0001-OAK-6445-Ensure-mounted-node-stores-don-t-contain-ve.patch > > > Since versioning does not work with the CompositeNodeStore mounts, we should > validate that no versionable nodes exist at mount time. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-5763) Improve LockException message on org.apache.jackrabbit.oak.jcr.lock.LockManagerImpl unlock
[
https://issues.apache.org/jira/browse/OAK-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-5763:
--
Fix Version/s: (was: 1.7.5)
1.7.6
> Improve LockException message on
> org.apache.jackrabbit.oak.jcr.lock.LockManagerImpl unlock
> --
>
> Key: OAK-5763
> URL: https://issues.apache.org/jira/browse/OAK-5763
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: jcr
>Affects Versions: 1.3.3
>Reporter: Borja Clemente
> Fix For: 1.8, 1.7.6
>
>
> The error message on LockManagerImpl unlock method could also include
> information about the user attempting to unlock the node as well as the
> actual lock owner.
> Current exception is:
> {code}
> LockException("Not an owner of the lock " + path)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-6449) Stop using the maven-scr-plugin
[ https://issues.apache.org/jira/browse/OAK-6449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-6449: -- Fix Version/s: (was: 1.7.5) 1.7.6 > Stop using the maven-scr-plugin > --- > > Key: OAK-6449 > URL: https://issues.apache.org/jira/browse/OAK-6449 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Robert Munteanu >Assignee: Robert Munteanu > Fix For: 1.8, 1.7.6 > > > With the maven-bundle-plugin now being able to generate SCR metadata there is > no point in continuing to use the maven-scr-plugin. > Also, the Eclipse integration for the maven-scr-plugin relies on m2e-tycho, > which is becoming problematic and is not very well maintained. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-5884) Evaluate utility of RepositoryGrowthTest benchmark
[
https://issues.apache.org/jira/browse/OAK-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-5884:
--
Fix Version/s: (was: 1.7.5)
1.7.6
> Evaluate utility of RepositoryGrowthTest benchmark
> --
>
> Key: OAK-5884
> URL: https://issues.apache.org/jira/browse/OAK-5884
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: run
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Fix For: 1.8, 1.7.6
>
>
> {{RepositoryGrowthTest}} is a benchmark which makes use of the deprecated
> {{SegmentFixture}}. Since OAK-5834 removes the old {{oak-segment}} module and
> the code associated with it, {{RepositoryGrowthTest}} was also removed. If
> there's value in it, we can adapt it to work with the new
> {{SegmentTarFixture}}.
> /cc [~chetanm]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-5998) Clarify and complete missing stuff in current Oak documentation
[ https://issues.apache.org/jira/browse/OAK-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5998: -- Fix Version/s: (was: 1.7.5) 1.7.6 > Clarify and complete missing stuff in current Oak documentation > --- > > Key: OAK-5998 > URL: https://issues.apache.org/jira/browse/OAK-5998 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: doc >Reporter: Chetan Mehrotra > Fix For: 1.8, 1.7.6 > > > Current Oak documentation [1] is missing details around certain aspects of > Oak which makes it difficult for a new person to get up and running and more > important operate Oak in productions easily. Purpose of this task is list out > topic which must be documented to enable easier usage of Oak > * Getting Started - Getting Oak with all features properly is tricky and not > easily possible with our [current getting > started|https://jackrabbit.apache.org/oak/docs/construct.html] specially for > prod setup. > ** Possibly refer or move doc of current examples here > ** For a new user not aware of JCR but aware of document storage a brief > overview on the JCR and how its the api for Oak which is to be used > * Maintenance and Operations - > ** Oak being MVCC storage requires certain maintenance task like RevisionGC > and BlobGC to be run periodically. > ** Then related MBean should be documented. Note some part is covered in > [Segment > docs|https://jackrabbit.apache.org/oak/docs/nodestore/segment/overview.html#garbage-collection] > but we need to complete it for Document and also provide an overview > ** System requirements in terms of RAM due to memory mapped usage, cloned > index files and persistent cache > * How clustering works in Oak - [Clustering > doc|https://jackrabbit.apache.org/oak/docs/clustering.html] should provide > details on > ** how it works > ** importance of background read and background write > ** Effect of eventual consistency in cluster setup > ** Sticky session requirement (as per usecase) > * Observation > ** How it works > ** How external and local events are generated > ** Queue behaviour and overflow > * Clarify requirement from host application wrt > ** scheduling singleton jobs used in Oak and how they should be executed > ** Scheduling maintenance operations via MBeans > * Document various OSGi config - May be generate a doc for all OSGi config in > Oak via some tooling > Note list above is tentative and would be edited to determine important > topics in coming days and then specific sub task can be created to complete > it. Once any list item is completed add (/) against the list entry > [1] https://jackrabbit.apache.org/oak/docs/ -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-5877) Oak upgrade usage note refers to oak-run
[
https://issues.apache.org/jira/browse/OAK-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-5877:
--
Fix Version/s: (was: 1.7.5)
1.7.6
> Oak upgrade usage note refers to oak-run
>
>
> Key: OAK-5877
> URL: https://issues.apache.org/jira/browse/OAK-5877
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Reporter: Michael Dürig
>Priority: Minor
> Labels: production, tooling, usability
> Fix For: 1.8, 1.7.6
>
>
> Running {{java -jar oak-upgrade*.jar}} prints
> {noformat}
> Usage: java -jar oak-run-*-jr2.jar upgrade [options] jcr2_source [destination]
>(to upgrade a JCR 2 repository)
>java -jar oak-run-*-jr2.jar upgrade [options] source destination
>(to migrate an Oak repository)
> {noformat}
> Which incorrectly refers to {{oak-run upgrade}}. The latter will send me back
> to {{oak-run}}: "This command was moved to the oak-upgrade module".
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-6457) Increment the segment version number
[ https://issues.apache.org/jira/browse/OAK-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-6457: -- Fix Version/s: (was: 1.7.5) 1.7.6 > Increment the segment version number > > > Key: OAK-6457 > URL: https://issues.apache.org/jira/browse/OAK-6457 > Project: Jackrabbit Oak > Issue Type: New Feature > Components: segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari > Fix For: 1.8, 1.7.6 > > > OAK-3349 introduced the tail generation number in the segment header. This > change assigns semantics to a portion of the header that was previously not > used. As such, the segment version should be incremented. Proper checks > should also be put in place to transparently migrate segments from the old to > the new version number. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6483) Segment-based composite node store performance degradation
[
https://issues.apache.org/jira/browse/OAK-6483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-6483:
--
Fix Version/s: (was: 1.7.5)
1.7.6
> Segment-based composite node store performance degradation
> --
>
> Key: OAK-6483
> URL: https://issues.apache.org/jira/browse/OAK-6483
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: composite
>Affects Versions: 1.7.4
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Critical
> Fix For: 1.8, 1.7.6
>
>
> It seems that the OAK-4732 is not compatible with the composite node store
> using a segment node store as the main (writeable) store. The OAK-4732
> measures how much does it usually take to apply commit hooks and merge the
> new root. However, the composite node store plugs into the commit hook and
> reads other node store states. As a result, it may take quite a while and the
> measured values are big. They are then used to tune the lock inside the
> LockBasedScheduler#getHeadNodeState() method. Since the times are big, the
> method also waits a long time for the semaphore before it gives up. This
> causes performance degradation.
> The {{-Doak.scheduler.fetch.commitDelayQuantile=0}} parameter can be used to
> disable the OAK-4732.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-5896) fix typo in Not condition handling
[ https://issues.apache.org/jira/browse/OAK-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5896: -- Fix Version/s: (was: 1.7.5) 1.7.6 > fix typo in Not condition handling > -- > > Key: OAK-5896 > URL: https://issues.apache.org/jira/browse/OAK-5896 > Project: Jackrabbit Oak > Issue Type: Bug > Components: query >Affects Versions: 1.6.1 >Reporter: Dave Brosius >Assignee: Dave Brosius >Priority: Trivial > Fix For: 1.8, 1.7.6 > > Attachments: 5896.txt > > > code stutters the same condition twice, looks like a typo. patch attached. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-5976) Document enhancements in 1.6 release
[ https://issues.apache.org/jira/browse/OAK-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5976: -- Fix Version/s: (was: 1.7.5) 1.7.6 > Document enhancements in 1.6 release > > > Key: OAK-5976 > URL: https://issues.apache.org/jira/browse/OAK-5976 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: doc >Reporter: Chetan Mehrotra > Fix For: 1.8, 1.7.6 > > > We should document all the enhancement that have been done in Oak 1.6 release > and refer to them in main doc > * 1.6.0 Release Notes - > https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.6.0/RELEASE-NOTES.txt -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-5965) Support path exclusion in secondary nodestore
[ https://issues.apache.org/jira/browse/OAK-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5965: -- Fix Version/s: (was: 1.7.5) 1.7.6 > Support path exclusion in secondary nodestore > - > > Key: OAK-5965 > URL: https://issues.apache.org/jira/browse/OAK-5965 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra > Labels: secondary-nodestore > Fix For: 1.8, 1.7.6 > > > Secondary NodeStore feature (OAK-4180) for now currently supports path > inclusion. It would be useful to have support for path exclusion also. > Using this a user can can include all content under / but exclude > /oak:index/uuid/:index entries. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-5902) Cold standby should allow syncing of blobs bigger than 2.2 GB
[
https://issues.apache.org/jira/browse/OAK-5902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-5902:
--
Fix Version/s: (was: 1.7.5)
1.7.6
> Cold standby should allow syncing of blobs bigger than 2.2 GB
> -
>
> Key: OAK-5902
> URL: https://issues.apache.org/jira/browse/OAK-5902
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.6.1
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Minor
> Fix For: 1.8, 1.7.6
>
>
> Currently there is a limitation for the maximum binary size (in bytes) to be
> synced between primary and standby instances. This matches
> {{Integer.MAX_VALUE}} (2,147,483,647) bytes and no binaries bigger than this
> limit can be synced between the instances.
> Per comment at [1], the current protocol needs to be changed to allow sending
> of binaries in chunks, to surpass this limitation.
> [1]
> https://github.com/apache/jackrabbit-oak/blob/1.6/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/standby/client/StandbyClient.java#L125
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-5455) Specify versions for maven plugins used in build for ensuring stable builds
[
https://issues.apache.org/jira/browse/OAK-5455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-5455:
--
Fix Version/s: (was: 1.7.5)
1.7.6
> Specify versions for maven plugins used in build for ensuring stable builds
> ---
>
> Key: OAK-5455
> URL: https://issues.apache.org/jira/browse/OAK-5455
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: parent
>Reporter: Chetan Mehrotra
>Assignee: Julian Reschke
> Fix For: 1.8, 1.7.6
>
> Attachments: enforce.diff, OAK-5455-v1.patch
>
>
> Running a check for plugin versions used in oak build
> {noformat}
> mvn versions:display-plugin-updates
> {noformat}
> leads to following warning
> {noformat}
> [INFO] The following plugin updates are available:
> [INFO] org.apache.felix:maven-scr-plugin .. 1.16.0 -> 1.21.0
> [INFO]
> [WARNING] The following plugins do not have their version specified:
> [WARNING] maven-compiler-plugin .. 2.0.2
> [WARNING] maven-deploy-plugin . (from super-pom) 2.4
> [WARNING] maven-failsafe-plugin . 2.12.4
> [WARNING] maven-jar-plugin . 2.1
> [WARNING] maven-javadoc-plugin . 2.0
> [WARNING] maven-release-plugin . (from super-pom) 2.0-beta-4
> [WARNING] maven-resources-plugin ... 2.2
> [WARNING] maven-surefire-plugin .. 2.4.2
> [INFO]
> [WARNING] Project does not define minimum Maven version, default is: 2.0
> [INFO] Plugins require minimum Maven version of: 3.0.5
> [INFO] Note: the super-pom from Maven 3.3.9 defines some of the plugin
> [INFO] versions and may be influencing the plugins required minimum
> Maven
> [INFO] version.
> [INFO]
> [ERROR] Project does not define required minimum version of Maven.
> [ERROR] Update the pom.xml to contain
> [ERROR]
> [ERROR] 3.0.5
> [ERROR]
> {noformat}
> As a fix we should
> # Specify version for all maven plugin in use
> # Specify minimum version of maven to be used (version used in CI is 3.2.1)
> # Configure enforcer plugin to ensure that in future no plugin is used
> without specifying the version [1]
> [1] http://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-5975) Document enhancements in Observation in 1.6
[ https://issues.apache.org/jira/browse/OAK-5975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5975: -- Fix Version/s: (was: 1.7.5) 1.7.6 > Document enhancements in Observation in 1.6 > --- > > Key: OAK-5975 > URL: https://issues.apache.org/jira/browse/OAK-5975 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: doc >Reporter: Chetan Mehrotra > Fix For: 1.8, 1.7.6 > > > This task is meant to collect and refer work done in 1.6 release which needs > to be documented in Oak docs wrt JCR Observation area > * OAK-4796 - filter events before adding to ChangeProcessor's queue > * OAK-5020 - Improved support for node removals > * OAK-5021 - Improve observation of files -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-5963) Disable S3 proactive caching by default
[ https://issues.apache.org/jira/browse/OAK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5963: -- Fix Version/s: (was: 1.7.5) 1.7.6 > Disable S3 proactive caching by default > --- > > Key: OAK-5963 > URL: https://issues.apache.org/jira/browse/OAK-5963 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: blob >Reporter: Amit Jain >Assignee: Amit Jain > Labels: candidate_oak_1_2, candidate_oak_1_4, candidate_oak_1_6 > Fix For: 1.8, 1.7.6 > > > The older JR2 CachingDataStore which is extended by S3DataStore enables > proactive caching by default which leads to many binaries being downloaded > twice. This should be disabled by default in Oak. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6445) Ensure mounted node stores don't contain versionable nodes
[ https://issues.apache.org/jira/browse/OAK-6445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-6445: -- Fix Version/s: (was: 1.7.5) 1.7.6 > Ensure mounted node stores don't contain versionable nodes > -- > > Key: OAK-6445 > URL: https://issues.apache.org/jira/browse/OAK-6445 > Project: Jackrabbit Oak > Issue Type: Sub-task > Components: composite >Reporter: Robert Munteanu >Assignee: Robert Munteanu > Fix For: 1.8, 1.7.6 > > Attachments: > 0001-OAK-6445-Ensure-mounted-node-stores-don-t-contain-ve.patch > > > Since versioning does not work with the CompositeNodeStore mounts, we should > validate that no versionable nodes exist at mount time. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6450) Stop relying on the service.pid property in SecurityProviderRegistration
[
https://issues.apache.org/jira/browse/OAK-6450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-6450:
--
Fix Version/s: (was: 1.7.5)
1.7.6
> Stop relying on the service.pid property in SecurityProviderRegistration
>
>
> Key: OAK-6450
> URL: https://issues.apache.org/jira/browse/OAK-6450
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: security
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.8, 1.7.6
>
> Attachments:
> 0001-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch,
> 0002-OAK-6450-Stop-relying-on-the-service.pid-property-in.patch,
> OAK-6450-v3.patch
>
>
> As discussed in OAK-6111, we should stop relying on the {{service.pid}} OSGi
> property for tracking required services as it was incorrectly set so far by
> the {{maven-scr-plugin}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-5918) Document enhancements in DocumentNodeStore in 1.6
[ https://issues.apache.org/jira/browse/OAK-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5918: -- Fix Version/s: (was: 1.7.5) 1.7.6 > Document enhancements in DocumentNodeStore in 1.6 > - > > Key: OAK-5918 > URL: https://issues.apache.org/jira/browse/OAK-5918 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: doc >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra > Fix For: 1.8, 1.7.6 > > > This task is meant to collect and refer work done in 1.6 release which needs > to be documented in Oak docs. Specially those enhancements which impact > system administration or new features which need be to enabled as per > requirements should be documented > Issues in documentmk, mongomk, rdbmk > [jql|https://issues.apache.org/jira/issues/?jql=project%20%3D%20OAK%20AND%20fixVersion%20%3D%201.6.0%20and%20component%20in%20(documentmk%2C%20mongomk%2C%20rdbmk)%20ORDER%20BY%20updated%20DESC%2C%20priority%20DESC%2C%20created%20ASC&startIndex=200] > * OAK-1312 - Bundle nodes into a document (/) > * OAK-4180 - Use another NodeStore as a local cache for a remote Document > store (/) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (OAK-6416) Test failure: MapRecordTest.testOak1104
[
https://issues.apache.org/jira/browse/OAK-6416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-6416:
--
Fix Version/s: (was: 1.7.5)
1.7.6
> Test failure: MapRecordTest.testOak1104
> ---
>
> Key: OAK-6416
> URL: https://issues.apache.org/jira/browse/OAK-6416
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: continuous integration, segment-tar
>Affects Versions: 1.7.3
>Reporter: Hudson
> Fix For: 1.8, 1.7.6
>
>
> Jenkins CI failure: https://builds.apache.org/view/J/job/Jackrabbit%20Oak/
> The build Jackrabbit Oak #499 has failed.
> First failed run: [Jackrabbit Oak
> #499|https://builds.apache.org/job/Jackrabbit%20Oak/499/] [console
> log|https://builds.apache.org/job/Jackrabbit%20Oak/499/console]
> The initial build failure is:
> {noformat}
> [ERROR] testOak1104(org.apache.jackrabbit.oak.segment.MapRecordTest) Time
> elapsed: 0.014 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.jackrabbit.oak.segment.MapRecordTest.testOak1104(MapRecordTest.java:93)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (OAK-6500) NRTIndex leaks file handles due to unclosed IndexReader
[
https://issues.apache.org/jira/browse/OAK-6500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-6500:
--
Fix Version/s: (was: 1.7.5)
1.7.6
> NRTIndex leaks file handles due to unclosed IndexReader
> ---
>
> Key: OAK-6500
> URL: https://issues.apache.org/jira/browse/OAK-6500
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Affects Versions: 1.6.0
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Critical
> Fix For: 1.8, 1.7.6, 1.6.4
>
> Attachments: OAK-6500-approach-a-v1.patch, OAK-6500-v1.patch
>
>
> On some setups under stress it has been seen that NRTIndex leaks file handles
> over time.
> Checking with lsof indicates that more than 3 nrt folders per index are being
> used. However per design there can be max 3 and after system is not in use
> max 1 should be present.
> {noformat}
> $ lsof -p 9550 | grep '/nrt' | gawk 'match($0,
> /.*crx-quickstart\/repository\/index\/(.*?)\/\_.*$/, m) { print m[1]; }' |
> sort | uniq
> cqPageLucene-1501065263331/nrt1501065335930
> cqPageLucene-1501065263331/nrt1501065374667
> cqPageLucene-1501065263331/nrt1501065392492
> cqPageLucene-1501065263331/nrt1501065440955
> cqPageLucene-1501065263331/nrt1501065473286
> cqPageLucene-1501065263331/nrt1501065507345
> slingeventJob-1501065263330/nrt1501065356975
> slingeventJob-1501065263330/nrt1501065373229
> slingeventJob-1501065263330/nrt1501065394142
> slingeventJob-1501065263330/nrt1501065440953
> slingeventJob-1501065263330/nrt1501065473282
> slingeventJob-1501065263330/nrt1501065507342
> versionStoreIndex-1501065263332/nrt1501065335925
> versionStoreIndex-1501065263332/nrt1501065366781
> versionStoreIndex-1501065263332/nrt1501065392490
> versionStoreIndex-1501065263332/nrt1501065441232
> versionStoreIndex-1501065263332/nrt1501065473285
> {noformat}
> Further actually checking index folder indicates that those folder are
> actually deleted. So some where the file handle is still referring them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
