[jira] [Commented] (OAK-7210) Build Jackrabbit Oak #1207 failed
[ https://issues.apache.org/jira/browse/OAK-7210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341970#comment-16341970 ] Hudson commented on OAK-7210: - Build is still failing. Failed run: [Jackrabbit Oak #1208|https://builds.apache.org/job/Jackrabbit%20Oak/1208/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1208/console] > Build Jackrabbit Oak #1207 failed > - > > Key: OAK-7210 > URL: https://issues.apache.org/jira/browse/OAK-7210 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #1207 has failed. > First failed run: [Jackrabbit Oak > #1207|https://builds.apache.org/job/Jackrabbit%20Oak/1207/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/1207/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7198) Index rule with REGEX_ALL_PROPS includes relative node
[ https://issues.apache.org/jira/browse/OAK-7198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341969#comment-16341969 ] Vikas Saurabh commented on OAK-7198: [~mreutegg], thanks for reporting this. Unfortunately, I am also not very comfortable with aggregation expectation - I'd rather [~chetanm] takes a shot at reviewing. > Index rule with REGEX_ALL_PROPS includes relative node > -- > > Key: OAK-7198 > URL: https://issues.apache.org/jira/browse/OAK-7198 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Affects Versions: 1.8.0 >Reporter: Marcel Reutegger >Priority: Minor > Fix For: 1.10 > > Attachments: OAK-7198.patch > > > A lucene index with an index rule that includes properties with > {{LuceneIndexConstants.REGEX_ALL_PROPS}} also includes some child node. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-7200) Sync propery indexes don't get planned if /:async exists but indexing lane hasn't completed its first cycle
[ https://issues.apache.org/jira/browse/OAK-7200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Saurabh resolved OAK-7200. Resolution: Fixed Fix Version/s: 1.10 1.9.0 Resolved mostly at [r1822372|https://svn.apache.org/r1822372] - technically, for a new/failing index despite async lane working, we should probably plan for "sync" indexes. But, that case is too general/complicated-to-fix to be in purview of this issue. > Sync propery indexes don't get planned if /:async exists but indexing lane > hasn't completed its first cycle > --- > > Key: OAK-7200 > URL: https://issues.apache.org/jira/browse/OAK-7200 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.9.0, 1.10 > > Attachments: OAK-7200.patch > > > In some cases (one example at \[0]), the repository might have a visible > {{/:async}} node but first indexing lane isn't completed yet. In this > situation sync property definitions (which are part of unfinished first > indexing cycle) don't participate in query planning. > The issue is basically that {{IndexNodeManager#open}} just looks at existence > of {{/:async}} node to see if first indexing cycle is finished. It should > also verify that the corresponding indexing lane is also done at least once > (e.g. {{/:async/@}} exists. > \[0]: > Startup a 2 node (N1 and N2) cluster with async indexing being run on say N1 > - consider async lane = {{some-lane-async}} > * N1 takes lease for {{some-lane-async}} and hence creates {{/:async}} > * N1 starts first indexing cycle for {{some-lane-async}} > * required background udpates happen such that N2 sees these updates from N1 > * N2 tries to a address a query which "should" get answered by a sync prop > defn that is to be indexed in {{some-lane-async}} > * N2 see {{/:async}} and assumes that first cycle is finished for the lane > and hence expects some indexed data for the index definition (which isn't > there yet) > * Thus N2 doesn't utilize the index definition while planning -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341911#comment-16341911 ] Alexander Klimetschek commented on OAK-4857: LGTM, thanks. > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-4857-tests.patch > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-7210) Build Jackrabbit Oak #1207 failed
Hudson created OAK-7210: --- Summary: Build Jackrabbit Oak #1207 failed Key: OAK-7210 URL: https://issues.apache.org/jira/browse/OAK-7210 Project: Jackrabbit Oak Issue Type: Bug Components: continuous integration Reporter: Hudson No description is provided The build Jackrabbit Oak #1207 has failed. First failed run: [Jackrabbit Oak #1207|https://builds.apache.org/job/Jackrabbit%20Oak/1207/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1207/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341334#comment-16341334 ] Julian Reschke commented on OAK-4857: - trunk: [r1822332|http://svn.apache.org/r1822332] > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-4857-tests.patch > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341333#comment-16341333 ] Julian Reschke commented on OAK-4857: - Changed the code not to reject these characters, but left in a config know to restore the previous behavior. > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-4857-tests.patch > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-4857. - Resolution: Fixed Fix Version/s: 1.9.0 > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-4857-tests.patch > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Issue Comment Deleted] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4857: Comment: was deleted (was: Proposed patch: https://issues.apache.org/jira/secure/attachment/12907885/OAK-4857.diff) > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-4857-tests.patch > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4857: Labels: candidate_oak_1_8 (was: ) > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-4857-tests.patch > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4857: Attachment: (was: OAK-4857.diff) > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-4857-tests.patch > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7205) Build Jackrabbit Oak #1203 failed
[ https://issues.apache.org/jira/browse/OAK-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341144#comment-16341144 ] Hudson commented on OAK-7205: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #1206|https://builds.apache.org/job/Jackrabbit%20Oak/1206/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1206/console] > Build Jackrabbit Oak #1203 failed > - > > Key: OAK-7205 > URL: https://issues.apache.org/jira/browse/OAK-7205 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #1203 has failed. > First failed run: [Jackrabbit Oak > #1203|https://builds.apache.org/job/Jackrabbit%20Oak/1203/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/1203/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4857: Attachment: OAK-4857.diff > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Fix For: 1.10 > > Attachments: OAK-4857-tests.patch, OAK-4857.diff > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341074#comment-16341074 ] Julian Reschke commented on OAK-4857: - Proposed patch: https://issues.apache.org/jira/secure/attachment/12907885/OAK-4857.diff > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Fix For: 1.10 > > Attachments: OAK-4857-tests.patch, OAK-4857.diff > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7205) Build Jackrabbit Oak #1203 failed
[ https://issues.apache.org/jira/browse/OAK-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341065#comment-16341065 ] Hudson commented on OAK-7205: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #1205|https://builds.apache.org/job/Jackrabbit%20Oak/1205/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1205/console] > Build Jackrabbit Oak #1203 failed > - > > Key: OAK-7205 > URL: https://issues.apache.org/jira/browse/OAK-7205 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #1203 has failed. > First failed run: [Jackrabbit Oak > #1203|https://builds.apache.org/job/Jackrabbit%20Oak/1203/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/1203/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-7203) AuthorizationConfigurationImpl is losing its MountInfoProvider
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved OAK-7203. -- Resolution: Not A Problem > AuthorizationConfigurationImpl is losing its MountInfoProvider > -- > > Key: OAK-7203 > URL: https://issues.apache.org/jira/browse/OAK-7203 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core >Affects Versions: 1.8.1 >Reporter: Oliver Lietz >Priority: Major > > While testing Sling with Oak 1.8 I've observed that > AuthorizationConfigurationImpl is losing its MountInfoProvider: > {noformat} > @Reference > private MountInfoProvider mountInfoProvider = > Mounts.defaultMountInfoProvider(); > {noformat} > {noformat} > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Bundleorg.apache.jackrabbit.oak-core (63) > Implementation Class > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Default State enabled > Activationdelayed > Configuration Policy optional > Service Type singleton > Services > org.apache.jackrabbit.oak.spi.security.authorization.AuthorizationConfiguration > org.apache.jackrabbit.oak.spi.security.SecurityConfiguration > PID > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Reference mountInfoProvider Unsatisfied > Service Name: org.apache.jackrabbit.oak.spi.mount.MountInfoProvider > Cardinality: 1..1 > Policy: static > Policy Option: reluctant > No Services bound > Propertiescomponent.id = 35 > component.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > configurationRanking = 100 > importBehavior = abort > oak.security.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > readPaths = [/jcr:system/rep:namespaces, /jcr:system/jcr:nodeTypes, > /jcr:system/rep:privileges] > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7203) AuthorizationConfigurationImpl is losing its MountInfoProvider
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341020#comment-16341020 ] Oliver Lietz commented on OAK-7203: --- If it works as designed... sure. > AuthorizationConfigurationImpl is losing its MountInfoProvider > -- > > Key: OAK-7203 > URL: https://issues.apache.org/jira/browse/OAK-7203 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core >Affects Versions: 1.8.1 >Reporter: Oliver Lietz >Priority: Major > > While testing Sling with Oak 1.8 I've observed that > AuthorizationConfigurationImpl is losing its MountInfoProvider: > {noformat} > @Reference > private MountInfoProvider mountInfoProvider = > Mounts.defaultMountInfoProvider(); > {noformat} > {noformat} > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Bundleorg.apache.jackrabbit.oak-core (63) > Implementation Class > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Default State enabled > Activationdelayed > Configuration Policy optional > Service Type singleton > Services > org.apache.jackrabbit.oak.spi.security.authorization.AuthorizationConfiguration > org.apache.jackrabbit.oak.spi.security.SecurityConfiguration > PID > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Reference mountInfoProvider Unsatisfied > Service Name: org.apache.jackrabbit.oak.spi.mount.MountInfoProvider > Cardinality: 1..1 > Policy: static > Policy Option: reluctant > No Services bound > Propertiescomponent.id = 35 > component.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > configurationRanking = 100 > importBehavior = abort > oak.security.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > readPaths = [/jcr:system/rep:namespaces, /jcr:system/jcr:nodeTypes, > /jcr:system/rep:privileges] > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7203) AuthorizationConfigurationImpl is losing its MountInfoProvider
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16341011#comment-16341011 ] Robert Munteanu commented on OAK-7203: -- Good catch, added in [r1822291|https://svn.apache.org/r1822291] . Should this be resolved then? > AuthorizationConfigurationImpl is losing its MountInfoProvider > -- > > Key: OAK-7203 > URL: https://issues.apache.org/jira/browse/OAK-7203 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core >Affects Versions: 1.8.1 >Reporter: Oliver Lietz >Priority: Major > > While testing Sling with Oak 1.8 I've observed that > AuthorizationConfigurationImpl is losing its MountInfoProvider: > {noformat} > @Reference > private MountInfoProvider mountInfoProvider = > Mounts.defaultMountInfoProvider(); > {noformat} > {noformat} > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Bundleorg.apache.jackrabbit.oak-core (63) > Implementation Class > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Default State enabled > Activationdelayed > Configuration Policy optional > Service Type singleton > Services > org.apache.jackrabbit.oak.spi.security.authorization.AuthorizationConfiguration > org.apache.jackrabbit.oak.spi.security.SecurityConfiguration > PID > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Reference mountInfoProvider Unsatisfied > Service Name: org.apache.jackrabbit.oak.spi.mount.MountInfoProvider > Cardinality: 1..1 > Policy: static > Policy Option: reluctant > No Services bound > Propertiescomponent.id = 35 > component.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > configurationRanking = 100 > importBehavior = abort > oak.security.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > readPaths = [/jcr:system/rep:namespaces, /jcr:system/jcr:nodeTypes, > /jcr:system/rep:privileges] > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7208) Various disallowed control characters are accepted in item names
[ https://issues.apache.org/jira/browse/OAK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7208: Summary: Various disallowed control characters are accepted in item names (was: Various disallowed control characters are accepted in node names) > Various disallowed control characters are accepted in item names > > > Key: OAK-7208 > URL: https://issues.apache.org/jira/browse/OAK-7208 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-7208.diff > > > Our node name check currently allow control characters other than CR, LF and > TAB. This is a bug according to JCR, names being restricted to XML characters. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-5506) reject item names with unpaired surrogates early
[ https://issues.apache.org/jira/browse/OAK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-5506: Summary: reject item names with unpaired surrogates early (was: reject node names with unpaired surrogates early) > reject item names with unpaired surrogates early > > > Key: OAK-5506 > URL: https://issues.apache.org/jira/browse/OAK-5506 > Project: Jackrabbit Oak > Issue Type: Wish > Components: core, jcr, segment-tar >Affects Versions: 1.5.18 >Reporter: Julian Reschke >Assignee: Francesco Mari >Priority: Minor > Fix For: 1.10 > > Attachments: OAK-5506-01.patch, OAK-5506-02.patch, OAK-5506-4.diff, > OAK-5506-bench.diff, OAK-5506-name-conversion.diff, OAK-5506-segment.diff, > OAK-5506.diff, ValidNamesTest.java > > > Apparently, the following node name is accepted: >{{"foo\ud800"}} > but a subsequent {{getPath()}} call fails: > {noformat} > javax.jcr.InvalidItemStateException: This item [/test_node/foo?] does not > exist anymore > at > org.apache.jackrabbit.oak.jcr.delegate.ItemDelegate.checkAlive(ItemDelegate.java:86) > at > org.apache.jackrabbit.oak.jcr.session.operation.ItemOperation.checkPreconditions(ItemOperation.java:34) > at > org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.prePerform(SessionDelegate.java:615) > at > org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:205) > at > org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112) > at > org.apache.jackrabbit.oak.jcr.session.ItemImpl.getPath(ItemImpl.java:140) > at > org.apache.jackrabbit.oak.jcr.session.NodeImpl.getPath(NodeImpl.java:106) > at > org.apache.jackrabbit.oak.jcr.ValidNamesTest.nameTest(ValidNamesTest.java:271) > at > org.apache.jackrabbit.oak.jcr.ValidNamesTest.testUnpairedSurrogate(ValidNamesTest.java:259) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source){noformat} > (test case follows) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-4857) Support space chars common in CJK inside item names
[ https://issues.apache.org/jira/browse/OAK-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-4857: Summary: Support space chars common in CJK inside item names (was: Support space chars common in CJK inside node names) > Support space chars common in CJK inside item names > --- > > Key: OAK-4857 > URL: https://issues.apache.org/jira/browse/OAK-4857 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core >Affects Versions: 1.4.7, 1.5.10 >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Fix For: 1.10 > > Attachments: OAK-4857-tests.patch > > > Oak (like Jackrabbit) does not allow spaces commonly used in CJK like > {{u3000}} (ideographic space) or {{u00A0}} (no-break space) _inside_ a node > name, while allowing some of them (the non breaking spaces) at the _beginning > or end_. > They should be supported for better globalization readiness, and filesystems > allow them, making common filesystem to JCR mappings unnecessarily hard. > Escaping would be an option for applications, but there is currently no > utility method for it > ([Text.escapeIllegalJcrChars|https://jackrabbit.apache.org/api/2.8/org/apache/jackrabbit/util/Text.html#escapeIllegalJcrChars(java.lang.String)] > will not escape these spaces), nor is it documented for applications how to > do so. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7203) AuthorizationConfigurationImpl is losing its MountInfoProvider
[ https://issues.apache.org/jira/browse/OAK-7203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340982#comment-16340982 ] Oliver Lietz commented on OAK-7203: --- That works (Sling runs with Oak 1.8.1). Thanks, [~rombert]. So {{oak-store-composite}} is mandatory for Oak on OSGi, right? Is that the intended behavior or a bug? {{oak-store-composite}} is not listed in {{dev_getting_started.md}} – can you add it, please? > AuthorizationConfigurationImpl is losing its MountInfoProvider > -- > > Key: OAK-7203 > URL: https://issues.apache.org/jira/browse/OAK-7203 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core >Affects Versions: 1.8.1 >Reporter: Oliver Lietz >Priority: Major > > While testing Sling with Oak 1.8 I've observed that > AuthorizationConfigurationImpl is losing its MountInfoProvider: > {noformat} > @Reference > private MountInfoProvider mountInfoProvider = > Mounts.defaultMountInfoProvider(); > {noformat} > {noformat} > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Bundleorg.apache.jackrabbit.oak-core (63) > Implementation Class > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Default State enabled > Activationdelayed > Configuration Policy optional > Service Type singleton > Services > org.apache.jackrabbit.oak.spi.security.authorization.AuthorizationConfiguration > org.apache.jackrabbit.oak.spi.security.SecurityConfiguration > PID > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > Reference mountInfoProvider Unsatisfied > Service Name: org.apache.jackrabbit.oak.spi.mount.MountInfoProvider > Cardinality: 1..1 > Policy: static > Policy Option: reluctant > No Services bound > Propertiescomponent.id = 35 > component.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > configurationRanking = 100 > importBehavior = abort > oak.security.name = > org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl > readPaths = [/jcr:system/rep:namespaces, /jcr:system/jcr:nodeTypes, > /jcr:system/rep:privileges] > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7205) Build Jackrabbit Oak #1203 failed
[ https://issues.apache.org/jira/browse/OAK-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340968#comment-16340968 ] Hudson commented on OAK-7205: - Build is still failing. Failed run: [Jackrabbit Oak #1204|https://builds.apache.org/job/Jackrabbit%20Oak/1204/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1204/console] > Build Jackrabbit Oak #1203 failed > - > > Key: OAK-7205 > URL: https://issues.apache.org/jira/browse/OAK-7205 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #1203 has failed. > First failed run: [Jackrabbit Oak > #1203|https://builds.apache.org/job/Jackrabbit%20Oak/1203/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/1203/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-7208) Various disallowed control characters are accepted in node names
[ https://issues.apache.org/jira/browse/OAK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339486#comment-16339486 ] Julian Reschke edited comment on OAK-7208 at 1/26/18 12:02 PM: --- https://issues.apache.org/jira/secure/attachment/12907731/OAK-7208.diff - test case and fix. Note that this might break cases where people currently rely on these characters. EDIT: made it configurable (sad). was (Author: reschke): https://issues.apache.org/jira/secure/attachment/12907731/OAK-7208.diff - test case and fix. Note that this might break cases where people currently rely on these characters. > Various disallowed control characters are accepted in node names > > > Key: OAK-7208 > URL: https://issues.apache.org/jira/browse/OAK-7208 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-7208.diff > > > Our node name check currently allow control characters other than CR, LF and > TAB. This is a bug according to JCR, names being restricted to XML characters. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7208) Various disallowed control characters are accepted in node names
[ https://issues.apache.org/jira/browse/OAK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340961#comment-16340961 ] Julian Reschke commented on OAK-7208: - trunk: [r1822279|http://svn.apache.org/r1822279] > Various disallowed control characters are accepted in node names > > > Key: OAK-7208 > URL: https://issues.apache.org/jira/browse/OAK-7208 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-7208.diff > > > Our node name check currently allow control characters other than CR, LF and > TAB. This is a bug according to JCR, names being restricted to XML characters. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-7208) Various disallowed control characters are accepted in node names
[ https://issues.apache.org/jira/browse/OAK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-7208. - Resolution: Fixed Fix Version/s: 1.10 1.9.0 > Various disallowed control characters are accepted in node names > > > Key: OAK-7208 > URL: https://issues.apache.org/jira/browse/OAK-7208 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10 > > Attachments: OAK-7208.diff > > > Our node name check currently allow control characters other than CR, LF and > TAB. This is a bug according to JCR, names being restricted to XML characters. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-6898) Query: grammar documentation / annotated railroad diagrams
[ https://issues.apache.org/jira/browse/OAK-6898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-6898. - Resolution: Fixed I consider this done, even thought more examples, and actual railroad diagrams would be nice. > Query: grammar documentation / annotated railroad diagrams > -- > > Key: OAK-6898 > URL: https://issues.apache.org/jira/browse/OAK-6898 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Fix For: 1.10 > > > I think we need to add a proper query grammar documentation with detailed > recommendations, similar to how it is done in relational databases. This is > needed for XPath, and SQL-2. The only thing we have right now is [railroad > diagrams|http://www.h2database.com/jcr/grammar.html], without annotation. > That's not sufficient. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-6217) Document tricky statements
[ https://issues.apache.org/jira/browse/OAK-6217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-6217. - Resolution: Fixed I consider this done (see also OAK-6898). > Document tricky statements > -- > > Key: OAK-6217 > URL: https://issues.apache.org/jira/browse/OAK-6217 > Project: Jackrabbit Oak > Issue Type: Bug > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Fix For: 1.10 > > > There are some cases, specially if fulltext conditions and aggregation are > used, where a query sometimes returns no results even thought with the right > index it does return the results. This is a bit hard to understand, because > it doesn't match the rule "indexes should only affect performance, not > results". One such example is if a query uses one or the other index, but not > both. Or if a query uses fulltext conditions on different nodes (parent and > child). Examples: > {noformat} > /jcr:root/home//element(*, rep:User) > [jcr:contains(.,'Kerr*') > and jcr:like(@rep:impersonators, '%ccibu%')]/profile > /jcr:root/home//element(*, rep:User) > [jcr:contains(profile,'Kerr*') > and jcr:like(@rep:impersonators, '%ccibu%')]/profile > {noformat} > Related is the usage of relative properties in indexes, excluded / included > paths. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-5473) Document fulltext search grammer ("contains")
[ https://issues.apache.org/jira/browse/OAK-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-5473. - Resolution: Fixed I consider this done now (see also OAK-6898) > Document fulltext search grammer ("contains") > - > > Key: OAK-5473 > URL: https://issues.apache.org/jira/browse/OAK-5473 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: query >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Fix For: 1.10 > > > The grammar supported and the semantics of fulltext queries ("jcr:contains" > for XPath, "contains" for SQL-2) are not clearly documented yet. This is > specially applies to escaping (which characters), rules (how to avoid syntax > errors), and compatibility (which version supports which grammar). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-6058) Avoid accessing remote binaries when migration involves S3
[ https://issues.apache.org/jira/browse/OAK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340906#comment-16340906 ] Francesco Mari commented on OAK-6058: - One example of problematic execution is represented by the following call stack {noformat} at com.google.common.io.ByteSource.contentEquals(ByteSource.java:301) at org.apache.jackrabbit.oak.plugins.memory.AbstractBlob.equal(AbstractBlob.java:67) at org.apache.jackrabbit.oak.plugins.segment.SegmentBlob.equals(SegmentBlob.java:228) at com.google.common.base.Objects.equal(Objects.java:55) at org.apache.jackrabbit.oak.plugins.memory.AbstractPropertyState.equal(AbstractPropertyState.java:53) at org.apache.jackrabbit.oak.plugins.segment.SegmentPropertyState.equals(SegmentPropertyState.java:243) at org.apache.jackrabbit.oak.upgrade.nodestate.NodeStateCopier.copyProperties(NodeStateCopier.java:135) {noformat} In short, the content identity of the BLOB is {{null}} for one or both the BLOBs. This forces {{org.apache.jackrabbit.oak.plugins.memory.AbstractBlob#equal}} into accessing the content of the BLOBs and perform a byte-to-byte comparison. In case of the {{S3DataStore}}, this involves reading the content of the BLOBs from S3. > Avoid accessing remote binaries when migration involves S3 > -- > > Key: OAK-6058 > URL: https://issues.apache.org/jira/browse/OAK-6058 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Francesco Mari >Priority: Major > > When migrating (sidegrade) a repository referencing the S3DataStore, we > should avoid accessing the binaries themselves and use their identifiers > instead. > In particular: > * it should be possible to copy a a nodestore referencing S3DataStore without > accessing/configuring S3 at all (copy binaries by the references), > * if the S3DataStore is configured for the migration and the destination > already exists, the blob identifiers should be used in the equals() method, > not the whole binary input stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7208) Various disallowed control characters are accepted in node names
[ https://issues.apache.org/jira/browse/OAK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7208: Labels: candidate_oak_1_8 (was: ) > Various disallowed control characters are accepted in node names > > > Key: OAK-7208 > URL: https://issues.apache.org/jira/browse/OAK-7208 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Attachments: OAK-7208.diff > > > Our node name check currently allow control characters other than CR, LF and > TAB. This is a bug according to JCR, names being restricted to XML characters. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OAK-6058) Avoid accessing remote binaries when migration involves S3
[ https://issues.apache.org/jira/browse/OAK-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Mari reassigned OAK-6058: --- Assignee: Francesco Mari > Avoid accessing remote binaries when migration involves S3 > -- > > Key: OAK-6058 > URL: https://issues.apache.org/jira/browse/OAK-6058 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: upgrade >Reporter: Tomek Rękawek >Assignee: Francesco Mari >Priority: Major > > When migrating (sidegrade) a repository referencing the S3DataStore, we > should avoid accessing the binaries themselves and use their identifiers > instead. > In particular: > * it should be possible to copy a a nodestore referencing S3DataStore without > accessing/configuring S3 at all (copy binaries by the references), > * if the S3DataStore is configured for the migration and the destination > already exists, the blob identifiers should be used in the equals() method, > not the whole binary input stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-5089) Document illegal item names in Oak
[ https://issues.apache.org/jira/browse/OAK-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340891#comment-16340891 ] Julian Reschke commented on OAK-5089: - trunk: [r1822267|http://svn.apache.org/r1822267] > Document illegal item names in Oak > -- > > Key: OAK-5089 > URL: https://issues.apache.org/jira/browse/OAK-5089 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: doc >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Fix For: 1.9.0, 1.10 > > Attachments: OAK-5089.diff > > > From OAK-4857. Oak like Jackrabbit 2 has limits on valid node/property names > in addition to the illegal chars from the JCR spec. This isn't documented yet. > Here is what I know so far: > * illegal node name if entire name is empty or {{.}} or {{..}} > * no length limit (\?) > * otherwise name can have all unicode chars except: > * JCR illegal chars {{/ : \[ ] | *}} > * > [Character.isWhitespace()|https://docs.oracle.com/javase/7/docs/api/java/lang/Character.html#isWhitespace(char)], > except for regular space {{u20}} which is allowed, except first or last char -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-5089) Document illegal item names in Oak
[ https://issues.apache.org/jira/browse/OAK-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-5089. - Resolution: Fixed Fix Version/s: 1.9.0 > Document illegal item names in Oak > -- > > Key: OAK-5089 > URL: https://issues.apache.org/jira/browse/OAK-5089 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: doc >Reporter: Alexander Klimetschek >Assignee: Julian Reschke >Priority: Major > Fix For: 1.9.0, 1.10 > > Attachments: OAK-5089.diff > > > From OAK-4857. Oak like Jackrabbit 2 has limits on valid node/property names > in addition to the illegal chars from the JCR spec. This isn't documented yet. > Here is what I know so far: > * illegal node name if entire name is empty or {{.}} or {{..}} > * no length limit (\?) > * otherwise name can have all unicode chars except: > * JCR illegal chars {{/ : \[ ] | *}} > * > [Character.isWhitespace()|https://docs.oracle.com/javase/7/docs/api/java/lang/Character.html#isWhitespace(char)], > except for regular space {{u20}} which is allowed, except first or last char -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7208) Various disallowed control characters are accepted in node names
[ https://issues.apache.org/jira/browse/OAK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7208: Description: Our node name check currently allow control characters other than CR, LF and TAB. This is a bug according to JCR, names being restricted to XML characters. (was: Our node name check currently allow control characters other than CR, LF and TAB. This is a bug according to JCR names being restricted to XML characters.) > Various disallowed control characters are accepted in node names > > > Key: OAK-7208 > URL: https://issues.apache.org/jira/browse/OAK-7208 > Project: Jackrabbit Oak > Issue Type: Bug > Components: jcr >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Attachments: OAK-7208.diff > > > Our node name check currently allow control characters other than CR, LF and > TAB. This is a bug according to JCR, names being restricted to XML characters. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7168) The debug command returns a zero exit code on error
[ https://issues.apache.org/jira/browse/OAK-7168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7168. - Bulk close 1.8.1 > The debug command returns a zero exit code on error > --- > > Key: OAK-7168 > URL: https://issues.apache.org/jira/browse/OAK-7168 > Project: Jackrabbit Oak > Issue Type: Bug > Components: run, segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10, 1.8.1 > > > The debug command should return a non-zero exit code if it fails with an > exception. Moreover, every error message should be printed on the standard > error. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-4401) Excerpt Highlighting for a property is not correct
[ https://issues.apache.org/jira/browse/OAK-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-4401. - Bulk close 1.8.1 > Excerpt Highlighting for a property is not correct > --- > > Key: OAK-4401 > URL: https://issues.apache.org/jira/browse/OAK-4401 > Project: Jackrabbit Oak > Issue Type: Bug > Components: query >Affects Versions: 1.5.2 >Reporter: Ankit Agarwal >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.9.0, 1.10, 1.8.1 > > Attachments: > 0001-OAK-4401-Excerpt-Highlighting-for-a-property-is-not-.patch > > > if we have following text at property > /jcr:content/text > === > A state agency’s Conflict of Interest Code must reflect the current structure > of the organization and properly identify officials andemployees > = > and if rep:excerpt(/jcr:content/text) is been calling after search then > == > officials will be in output , which is incorrect. > == -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7172) Document TarMK specific MBeans
[ https://issues.apache.org/jira/browse/OAK-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7172. - Bulk close 1.8.1 > Document TarMK specific MBeans > -- > > Key: OAK-7172 > URL: https://issues.apache.org/jira/browse/OAK-7172 > Project: Jackrabbit Oak > Issue Type: Task > Components: doc, segment-tar >Reporter: Michael Dürig >Assignee: Michael Dürig >Priority: Major > Labels: documentation > Fix For: 1.9.0, 1.10, 1.8.1 > > > Currently the [TarMK > documentation|http://jackrabbit.apache.org/oak/docs/nodestore/segment/overview.html#monitoring-via-jmx] > only mentions {{SegmentRevisionGarbageCollection}}. We should review that > paragraph and also include documentation for all other relevant JMX endpoints. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7147) Oak run LuceneIndexer indexes excluded parent nodes
[ https://issues.apache.org/jira/browse/OAK-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7147. - Bulk close 1.8.1 > Oak run LuceneIndexer indexes excluded parent nodes > --- > > Key: OAK-7147 > URL: https://issues.apache.org/jira/browse/OAK-7147 > Project: Jackrabbit Oak > Issue Type: Bug > Components: indexing, run >Affects Versions: 1.8.0 >Reporter: Chetan Mehrotra >Assignee: Chetan Mehrotra >Priority: Minor > Fix For: 1.9.0, 1.10, 1.8.1 > > > {{LuceneIndexer}} currently indexes parent nodes which are not included by > includedPaths. This happens because the LuceneIndexer#index does not check > for path filter result and proceeds to index any node handed to it by the > DocumentStoreIndexer > As a fix it should check if the filter result is PathFilter.Result.INCLUDE -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7141) Remove unused metatype.properties
[ https://issues.apache.org/jira/browse/OAK-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7141. - Bulk close 1.8.1 > Remove unused metatype.properties > - > > Key: OAK-7141 > URL: https://issues.apache.org/jira/browse/OAK-7141 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: core, documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.9.0, 1.10, 1.8.1 > > > See also discussion in OAK-7138. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-6964) Document tail compaction
[ https://issues.apache.org/jira/browse/OAK-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-6964. - Bulk close 1.8.1 > Document tail compaction > > > Key: OAK-6964 > URL: https://issues.apache.org/jira/browse/OAK-6964 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: doc, segment-tar >Reporter: Michael Dürig >Assignee: Michael Dürig >Priority: Major > Labels: documentation > Fix For: 1.9.0, 1.10, 1.8.1 > > > We need to add documentation of tail compaction: > * What is it, how does it work? > * How is it configured and scheduled? > * How can it be monitored, what are the related log entries? > * What are its limitations? > * What if it fails? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7158) Users shouldn't be able to change the number of retained generations
[ https://issues.apache.org/jira/browse/OAK-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7158. - Bulk close 1.8.1 > Users shouldn't be able to change the number of retained generations > > > Key: OAK-7158 > URL: https://issues.apache.org/jira/browse/OAK-7158 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10, 1.8.1 > > Attachments: OAK-7158-01.diff, OAK-7158-02.diff, OAK-7158-03.diff > > > Currently, {{SegmentGCOptions}} implements a validation check on the number > of retained generations that prevents callers to set it to a value smaller > than two. Instead, some subsystems might benefit from having a number of > retained generations smaller than two - see OAK-7157 as an example. > The check performed by {{SegmentGCOptions}} should be moved to > {{SegmentNodeStoreService}} to prevent users from setting the number of > retained generations to a an invalid value. Internal subsystems should be > allowed to set the number of retained generations to a lower value, if needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7157) Minimize the amount of generations retained by the Cold Standby
[ https://issues.apache.org/jira/browse/OAK-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7157. - Bulk close 1.8.1 > Minimize the amount of generations retained by the Cold Standby > --- > > Key: OAK-7157 > URL: https://issues.apache.org/jira/browse/OAK-7157 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10, 1.8.1 > > > The standby should be able to work while retaining only one full generation. > Since the standby only guarantees the availability of the latest head state > from the primary, no functionality should be impacted if only the latest full > generation is retained. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7171) The history command returns a zero exit code on error
[ https://issues.apache.org/jira/browse/OAK-7171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7171. - Bulk close 1.8.1 > The history command returns a zero exit code on error > - > > Key: OAK-7171 > URL: https://issues.apache.org/jira/browse/OAK-7171 > Project: Jackrabbit Oak > Issue Type: Bug > Components: run, segment-tar >Reporter: Francesco Mari >Assignee: Francesco Mari >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10, 1.8.1 > > > The history command should return a non-zero exit code if it fails with an > exception. Moreover, every error message should be printed on the standard > error. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7130) Update README.md with Java 8 requirement
[ https://issues.apache.org/jira/browse/OAK-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7130. - Bulk close 1.8.1 > Update README.md with Java 8 requirement > > > Key: OAK-7130 > URL: https://issues.apache.org/jira/browse/OAK-7130 > Project: Jackrabbit Oak > Issue Type: Task >Affects Versions: 1.8.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.9.0, 1.10, 1.8.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7060) RDBDocumentStore.getStats() for SQLServer
[ https://issues.apache.org/jira/browse/OAK-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7060. - Bulk close 1.8.1 > RDBDocumentStore.getStats() for SQLServer > - > > Key: OAK-7060 > URL: https://issues.apache.org/jira/browse/OAK-7060 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.9.0, 1.10, 1.8.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7131) xpath to sql2 conversion drops order by clause for some cases
[ https://issues.apache.org/jira/browse/OAK-7131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7131. - Bulk close 1.8.1 > xpath to sql2 conversion drops order by clause for some cases > - > > Key: OAK-7131 > URL: https://issues.apache.org/jira/browse/OAK-7131 > Project: Jackrabbit Oak > Issue Type: Bug > Components: query >Affects Versions: 1.6.0, 1.8.0 >Reporter: Vikas Saurabh >Assignee: Thomas Mueller >Priority: Critical > Fix For: 1.9.0, 1.10, 1.8.1, 1.6.9 > > > When xpath has OR-ed primary type and a couple of OR-ed property constraint > (e.g. \[0]), the converted sql statement doesn't get ordering clause. > \[0]: > {noformat} > //(element(*, type1) | element(*, type2))[@a='b' or @c='d'] order by @foo > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7169) The datastorecheck returns a zero exit code on error
[ https://issues.apache.org/jira/browse/OAK-7169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7169. - Bulk close 1.8.1 > The datastorecheck returns a zero exit code on error > > > Key: OAK-7169 > URL: https://issues.apache.org/jira/browse/OAK-7169 > Project: Jackrabbit Oak > Issue Type: Bug > Components: run >Reporter: Francesco Mari >Assignee: Francesco Mari >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.9.0, 1.10, 1.8.1 > > > The datastorecheck command should return a non-zero exit code if it fails > with an exception. Moreover, every error message should be printed on the > standard error. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7176) RevisionVector from empty string throws StringIndexOutOfBoundsException
[ https://issues.apache.org/jira/browse/OAK-7176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7176. - Bulk close 1.8.1 > RevisionVector from empty string throws StringIndexOutOfBoundsException > --- > > Key: OAK-7176 > URL: https://issues.apache.org/jira/browse/OAK-7176 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Affects Versions: 1.4, 1.6.0, 1.8.0 >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Fix For: 1.9.0, 1.10, 1.4.20, 1.8.1, 1.6.9 > > > According to {{RevisionVector.fromString()}} the method will parse the result > of {{RevisionVector.asString()}}. This round-tripping fails for an empty > {{RevisionVector}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7142) RDBDocumentStoreDB: use try-with-resources in new code introduced for getStats()
[ https://issues.apache.org/jira/browse/OAK-7142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7142. - Bulk close 1.8.1 > RDBDocumentStoreDB: use try-with-resources in new code introduced for > getStats() > > > Key: OAK-7142 > URL: https://issues.apache.org/jira/browse/OAK-7142 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Fix For: 1.9.0, 1.10, 1.8.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7138) Move metatype files in source control to correct location
[ https://issues.apache.org/jira/browse/OAK-7138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7138. - Bulk close 1.8.1 > Move metatype files in source control to correct location > - > > Key: OAK-7138 > URL: https://issues.apache.org/jira/browse/OAK-7138 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: 1.9.0, 1.10, 1.8.1 > > > The following files should be stored under {{OSGI-INF/l10n}}: > {noformat}find -name metatype.properties | grep -v target > ./oak-core/src/main/resources/OSGI-INF/metatype/metatype.properties > ./oak-store-document/src/main/resources/OSGI-INF/metatype/metatype.properties > ./oak-segment-tar/src/main/resources/OSGI-INF/metatype/metatype.properties > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7137) Upgrade to scr bnd plugin that places the metatype files in the correct location
[ https://issues.apache.org/jira/browse/OAK-7137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7137. - Bulk close 1.8.1 > Upgrade to scr bnd plugin that places the metatype files in the correct > location > > > Key: OAK-7137 > URL: https://issues.apache.org/jira/browse/OAK-7137 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: 1.9.0, 1.10, 1.8.1 > > > This should be a simple upgrade, but blocked by FELIX-5771 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7132) SNFE after full compaction
[ https://issues.apache.org/jira/browse/OAK-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7132. - Bulk close 1.8.1 > SNFE after full compaction > -- > > Key: OAK-7132 > URL: https://issues.apache.org/jira/browse/OAK-7132 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-tar >Affects Versions: 1.8.0 >Reporter: Michael Dürig >Assignee: Michael Dürig >Priority: Blocker > Labels: candidate_oak_1_8, compaction > Fix For: 1.9.0, 1.10, 1.8.1 > > Attachments: size.png > > > In some cases we observed a {{SNFE}} right after a the cleanup following a > full compaction: > {noformat} > 31.12.2017 04:25:19.816 *ERROR* [pool-17-thread-22] > org.apache.jackrabbit.oak.segment.SegmentNotFoundExceptionListener Segment > not found: a82a99a3-f1e9-49b7-a1e0-55e7fec80c41. SegmentId > age=609487478ms,segment-generation=GCGeneration{generation=4,fullGeneration=2,isCompacted=true} > org.apache.jackrabbit.oak.segment.SegmentNotFoundException: Segment > a82a99a3-f1e9-49b7-a1e0-55e7fec80c41 not found > at > org.apache.jackrabbit.oak.segment.file.AbstractFileStore.readSegmentUncached(AbstractFileStore.java:276) > at > org.apache.jackrabbit.oak.segment.file.FileStore.lambda$readSegment$5(FileStore.java:478) > at > org.apache.jackrabbit.oak.segment.SegmentCache.lambda$getSegment$0(SegmentCache.java:116) > at > com.google.common.cache.LocalCache$LocalManualCache$1.load(LocalCache.java:4724) > at > com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3522) > at > com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2315) > at > com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2278) > at > com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2193) > at com.google.common.cache.LocalCache.get(LocalCache.java:3932) > at > com.google.common.cache.LocalCache$LocalManualCache.get(LocalCache.java:4721) > at > org.apache.jackrabbit.oak.segment.SegmentCache.getSegment(SegmentCache.java:113) > at > org.apache.jackrabbit.oak.segment.file.FileStore.readSegment(FileStore.java:478) > at > org.apache.jackrabbit.oak.segment.SegmentId.getSegment(SegmentId.java:154) > at > org.apache.jackrabbit.oak.segment.CachingSegmentReader$1.apply(CachingSegmentReader.java:94) > at > org.apache.jackrabbit.oak.segment.CachingSegmentReader$1.apply(CachingSegmentReader.java:90) > at > org.apache.jackrabbit.oak.segment.ReaderCache.get(ReaderCache.java:118) > at > org.apache.jackrabbit.oak.segment.CachingSegmentReader.readString(CachingSegmentReader.java:90) > at > org.apache.jackrabbit.oak.segment.MapRecord.getEntry(MapRecord.java:220) > at > org.apache.jackrabbit.oak.segment.MapRecord.getEntry(MapRecord.java:173) > at > org.apache.jackrabbit.oak.segment.SegmentNodeState.getChildNode(SegmentNodeState.java:423) > at > org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.(MemoryNodeBuilder.java:143) > at > org.apache.jackrabbit.oak.segment.SegmentNodeBuilder.(SegmentNodeBuilder.java:93) > at > org.apache.jackrabbit.oak.segment.SegmentNodeBuilder.createChildBuilder(SegmentNodeBuilder.java:148) > at > org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.getChildNode(MemoryNodeBuilder.java:331) > at > org.apache.jackrabbit.oak.core.SecureNodeBuilder.(SecureNodeBuilder.java:112) > at > org.apache.jackrabbit.oak.core.SecureNodeBuilder.getChildNode(SecureNodeBuilder.java:329) > at > org.apache.jackrabbit.oak.core.MutableTree.getTree(MutableTree.java:290) > at > org.apache.jackrabbit.oak.core.MutableRoot.getTree(MutableRoot.java:220) > at > org.apache.jackrabbit.oak.core.MutableRoot.getTree(MutableRoot.java:69) > at > org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.getItem(SessionDelegate.java:442) > at > org.apache.jackrabbit.oak.jcr.session.SessionImpl.getItemInternal(SessionImpl.java:167) > at > org.apache.jackrabbit.oak.jcr.session.SessionImpl.access$400(SessionImpl.java:82) > at > org.apache.jackrabbit.oak.jcr.session.SessionImpl$3.performNullable(SessionImpl.java:229) > at > org.apache.jackrabbit.oak.jcr.session.SessionImpl$3.performNullable(SessionImpl.java:226) > at > org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.performNullable(SessionDelegate.java:243) > at > org.apache.jackrabbit.oak.jcr.session.SessionImpl.getItemOrNull(SessionImpl.java:226) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OAK-7075) Document oak-run compact arguments and system properties
[ https://issues.apache.org/jira/browse/OAK-7075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella closed OAK-7075. - Bulk close 1.8.1 > Document oak-run compact arguments and system properties > > > Key: OAK-7075 > URL: https://issues.apache.org/jira/browse/OAK-7075 > Project: Jackrabbit Oak > Issue Type: Task > Components: doc, segment-tar >Reporter: Michael Dürig >Assignee: Michael Dürig >Priority: Major > Labels: documentation > Fix For: 1.9.0, 1.10, 1.8.1 > > > Ensure {{oak-doc}} is up to date with the current version of {{oak-run > compact}}, its current command line arguments and system properties. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-7209) Race condition can resurrect blobs during blob GC
Csaba Varga created OAK-7209: Summary: Race condition can resurrect blobs during blob GC Key: OAK-7209 URL: https://issues.apache.org/jira/browse/OAK-7209 Project: Jackrabbit Oak Issue Type: Bug Components: blob-plugins Affects Versions: 1.6.5 Reporter: Csaba Varga A race condition exists between the scheduled blob ID publishing process and the GC process that can resurrect the blobs being deleted by the GC. This is how it can happen: # MarkSweepGarbageCollector.collectGarbage() starts running. # As part of the preparation for sweeping, BlobIdTracker.globalMerge() is called, which merges all blob ID records from the blob store into the local tracker. # Sweeping begins deleting files. # BlobIdTracker.snapshot() gets called by the scheduler. It pushes all blob ID records that were collected and merged in step 2 back into the blob store, then deletes the local copies. # Sweeping completes and tries to remove the successfully deleted blobs from the tracker. Step 4 already deleted those records from the local files, so nothing gets removed. The end result is that all blobs removed during the GC run will be considered still alive and causes warnings when later GC runs try to remove them again. The risk is higher the longer the sweep runs, but it can happen during a short but badly timed GC run as well. (We've found it during a GC run that took more than 11 hours to complete.) I can see two ways to approach this: # Suspend the execution of BlobIdTracker.snapshot() while Blob GC is in progress. This requires adding new methods to the BlobTracker interface to allow suspending and resuming snapshotting of the tracker. # Have the two overloads of BlobIdTracker.remove() do a globalMerge() before trying to remove anything. This ensures that even if a snapshot() call happened during the GC run, all IDs are "pulled back" into the local tracker and can be removed successfully. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-5506) reject node names with unpaired surrogates early
[ https://issues.apache.org/jira/browse/OAK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337637#comment-16337637 ] Julian Reschke edited comment on OAK-5506 at 1/26/18 10:09 AM: --- Attached rebased version of benchmark, incl updated version of {{DefaultSegmentWriter}} with using a custom encoder. I couldn't measure any significant perf changes. That said, a refactoring might make it possible to avoid copying byte arrays altogether, actually *improving* performance. was (Author: reschke): Attached rebased version of benchmark, please updated version of {{DefaultSegmentWriter}} with using a custom encoder. I couldn't measure any significant perf changes. That said, a refactoring might make it possible to avoid copying byte arrays altogether, actually *improving* performance. > reject node names with unpaired surrogates early > > > Key: OAK-5506 > URL: https://issues.apache.org/jira/browse/OAK-5506 > Project: Jackrabbit Oak > Issue Type: Wish > Components: core, jcr, segment-tar >Affects Versions: 1.5.18 >Reporter: Julian Reschke >Assignee: Francesco Mari >Priority: Minor > Fix For: 1.10 > > Attachments: OAK-5506-01.patch, OAK-5506-02.patch, OAK-5506-4.diff, > OAK-5506-bench.diff, OAK-5506-name-conversion.diff, OAK-5506-segment.diff, > OAK-5506.diff, ValidNamesTest.java > > > Apparently, the following node name is accepted: >{{"foo\ud800"}} > but a subsequent {{getPath()}} call fails: > {noformat} > javax.jcr.InvalidItemStateException: This item [/test_node/foo?] does not > exist anymore > at > org.apache.jackrabbit.oak.jcr.delegate.ItemDelegate.checkAlive(ItemDelegate.java:86) > at > org.apache.jackrabbit.oak.jcr.session.operation.ItemOperation.checkPreconditions(ItemOperation.java:34) > at > org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.prePerform(SessionDelegate.java:615) > at > org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:205) > at > org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112) > at > org.apache.jackrabbit.oak.jcr.session.ItemImpl.getPath(ItemImpl.java:140) > at > org.apache.jackrabbit.oak.jcr.session.NodeImpl.getPath(NodeImpl.java:106) > at > org.apache.jackrabbit.oak.jcr.ValidNamesTest.nameTest(ValidNamesTest.java:271) > at > org.apache.jackrabbit.oak.jcr.ValidNamesTest.testUnpairedSurrogate(ValidNamesTest.java:259) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source){noformat} > (test case follows) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340771#comment-16340771 ] Julian Reschke commented on OAK-7182: - Ack. And no, we don't necessarily have to *remove* those. On the other hand, we should avoid these in the future. The above usage should be safe, see https://google.github.io/guava/releases/20.0/api/docs/com/google/common/base/Predicate.html > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340753#comment-16340753 ] Robert Munteanu commented on OAK-7182: -- There's at least https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/state/NodeState.java#L388-L393 > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340719#comment-16340719 ] Julian Reschke commented on OAK-7182: - bq. the fact that we have Oak APIs exposing Guava APIs Do we? > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340705#comment-16340705 ] Robert Munteanu commented on OAK-7182: -- These changes seem to be compile-time only, we would also need to adjust the OSGi manifests I assume. Also, regading [~frm]'s comment, the fact that we have Oak APIs exposing Guava APIs is going to make it hard to remove those usages. > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)