[jira] [Updated] (OAK-7251) BinaryTextExtractor should not ignore parse exception - they should at least be logged at DEBUG in all cases
[
https://issues.apache.org/jira/browse/OAK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vikas Saurabh updated OAK-7251:
---
Fix Version/s: 1.10
> BinaryTextExtractor should not ignore parse exception - they should at least
> be logged at DEBUG in all cases
>
>
> Key: OAK-7251
> URL: https://issues.apache.org/jira/browse/OAK-7251
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.10
>
>
> BinaryTextExtractor ignores missing library error like:
> {noformat}
> } catch (LinkageError e) {
> // Capture and ignore errors caused by extraction libraries
> // not being present. This is equivalent to disabling
> // selected media types in configuration, so we can simply
> // ignore these errors.
> {noformat}
> or
> {noformat}
> // Capture and report any other full text extraction problems.
> // The special STOP exception is used for normal termination.
> if (!handler.isWriteLimitReached(t)) {
> {noformat}
> We should at not skip these errors - some information should at least be
> available at DEBUG.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7252) Function index for name() and localname() don't allow sorting
[
https://issues.apache.org/jira/browse/OAK-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356454#comment-16356454
]
Vikas Saurabh commented on OAK-7252:
[~tmueller], afaics, {{NodeNameImpl}} should have following to allow sorting on
node name:
{noformat}
diff --git
a/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/NodeNameImpl.java
b/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/NodeNameImpl.java
index cd1a884d9e..b5bce13e11 100644
---
a/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/NodeNameImpl.java
+++
b/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/NodeNameImpl.java
@@ -186,7 +186,7 @@ public class NodeNameImpl extends DynamicOperandImpl {
return null;
}
return new OrderEntry(
-QueryConstants.RESTRICTION_NAME,
+QueryConstants.FUNCTION_RESTRICTION_PREFIX + getFunction(s),
Type.STRING,
o.isDescending() ?
OrderEntry.Order.DESCENDING : OrderEntry.Order.ASCENDING);
{noformat}
(similar change is required for local name too... I just am not sure if I'm
thinking in the right direction)
> Function index for name() and localname() don't allow sorting
> -
>
> Key: OAK-7252
> URL: https://issues.apache.org/jira/browse/OAK-7252
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.10
>
>
> There is no way currently to have indexed based sorting on nodename -
> function index implementation for node name and local name doesn't provide
> correct order entry that would match a property definition for corresponding
> function index.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7252) Function index for name() and localname() don't allow sorting
[ https://issues.apache.org/jira/browse/OAK-7252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vikas Saurabh updated OAK-7252: --- Fix Version/s: 1.10 > Function index for name() and localname() don't allow sorting > - > > Key: OAK-7252 > URL: https://issues.apache.org/jira/browse/OAK-7252 > Project: Jackrabbit Oak > Issue Type: Bug > Components: lucene >Reporter: Vikas Saurabh >Assignee: Vikas Saurabh >Priority: Major > Fix For: 1.10 > > > There is no way currently to have indexed based sorting on nodename - > function index implementation for node name and local name doesn't provide > correct order entry that would match a property definition for corresponding > function index. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-7252) Function index for name() and localname() don't allow sorting
Vikas Saurabh created OAK-7252: -- Summary: Function index for name() and localname() don't allow sorting Key: OAK-7252 URL: https://issues.apache.org/jira/browse/OAK-7252 Project: Jackrabbit Oak Issue Type: Bug Components: lucene Reporter: Vikas Saurabh Assignee: Vikas Saurabh There is no way currently to have indexed based sorting on nodename - function index implementation for node name and local name doesn't provide correct order entry that would match a property definition for corresponding function index. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7251) BinaryTextExtractor should not ignore parse exception - they should at least be logged at DEBUG in all cases
[
https://issues.apache.org/jira/browse/OAK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356451#comment-16356451
]
Vikas Saurabh commented on OAK-7251:
[~chetanm] wdyt?
> BinaryTextExtractor should not ignore parse exception - they should at least
> be logged at DEBUG in all cases
>
>
> Key: OAK-7251
> URL: https://issues.apache.org/jira/browse/OAK-7251
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Major
>
> BinaryTextExtractor ignores missing library error like:
> {noformat}
> } catch (LinkageError e) {
> // Capture and ignore errors caused by extraction libraries
> // not being present. This is equivalent to disabling
> // selected media types in configuration, so we can simply
> // ignore these errors.
> {noformat}
> or
> {noformat}
> // Capture and report any other full text extraction problems.
> // The special STOP exception is used for normal termination.
> if (!handler.isWriteLimitReached(t)) {
> {noformat}
> We should at not skip these errors - some information should at least be
> available at DEBUG.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OAK-7251) BinaryTextExtractor should not ignore parse exception - they should at least be logged at DEBUG in all cases
Vikas Saurabh created OAK-7251:
--
Summary: BinaryTextExtractor should not ignore parse exception -
they should at least be logged at DEBUG in all cases
Key: OAK-7251
URL: https://issues.apache.org/jira/browse/OAK-7251
Project: Jackrabbit Oak
Issue Type: Improvement
Components: lucene
Reporter: Vikas Saurabh
Assignee: Vikas Saurabh
BinaryTextExtractor ignores missing library error like:
{noformat}
} catch (LinkageError e) {
// Capture and ignore errors caused by extraction libraries
// not being present. This is equivalent to disabling
// selected media types in configuration, so we can simply
// ignore these errors.
{noformat}
or
{noformat}
// Capture and report any other full text extraction problems.
// The special STOP exception is used for normal termination.
if (!handler.isWriteLimitReached(t)) {
{noformat}
We should at not skip these errors - some information should at least be
available at DEBUG.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OAK-7182) Make it possible to update Guava
[
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355645#comment-16355645
]
Julian Reschke edited comment on OAK-7182 at 2/7/18 4:35 PM:
-
Looking at classes in {{org.apache.jackrabbit.oak.plugins.index.solr.server}}
it seems that we're indeed running an embedded server. See also
http://jackrabbit.apache.org/oak/docs/query/solr.html
EDIT: running the tests with: {{mvn -Dguava.version=21.0 -DtrimStackTrace=false
clean install}}:
{noformat}
[ERROR] testHightlightFirstWord(org.apache.jackrabbit.core.query.ExcerptTest)
Time elapsed: 0.18 s <<< ERROR!
java.lang.NoSuchMethodError:
com.google.common.base.Objects.firstNonNull(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;
at
org.apache.solr.handler.component.HighlightComponent.prepare(HighlightComponent.java:74)
at
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:246)
at
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:155)
at org.apache.solr.core.SolrCore.execute(SolrCore.java:2102)
at
org.apache.solr.client.solrj.embedded.EmbeddedSolrServer.request(EmbeddedSolrServer.java:178)
at
org.apache.solr.client.solrj.SolrRequest.process(SolrRequest.java:149)
at org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:942)
at org.apache.solr.client.solrj.SolrClient.query(SolrClient.java:957)
at
org.apache.jackrabbit.oak.plugins.index.solr.query.SolrQueryIndex$2.loadDocs(SolrQueryIndex.java:343)
at
org.apache.jackrabbit.oak.plugins.index.solr.query.SolrQueryIndex$2.computeNext(SolrQueryIndex.java:281)
at
org.apache.jackrabbit.oak.plugins.index.solr.query.SolrQueryIndex$2.computeNext(SolrQueryIndex.java:1)
at
com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145)
at
com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:140)
at
org.apache.jackrabbit.oak.plugins.index.solr.query.SolrQueryIndex$SolrRowCursor$1.hasNext(SolrQueryIndex.java:684)
at
org.apache.jackrabbit.oak.plugins.index.Cursors$PathCursor.hasNext(Cursors.java:216)
at
org.apache.jackrabbit.oak.plugins.index.solr.query.SolrQueryIndex$SolrRowCursor.hasNext(SolrQueryIndex.java:706)
at
org.apache.jackrabbit.oak.query.ast.SelectorImpl.next(SelectorImpl.java:435)
at
org.apache.jackrabbit.oak.query.QueryImpl$RowIterator.fetchNext(QueryImpl.java:824)
at
org.apache.jackrabbit.oak.query.QueryImpl$RowIterator.hasNext(QueryImpl.java:851)
at
org.apache.jackrabbit.oak.jcr.query.QueryResultImpl$1.fetch(QueryResultImpl.java:98)
at
org.apache.jackrabbit.oak.jcr.query.QueryResultImpl$1.(QueryResultImpl.java:94)
at
org.apache.jackrabbit.oak.jcr.query.QueryResultImpl.getRows(QueryResultImpl.java:78)
at
org.apache.jackrabbit.core.query.ExcerptTest.checkExcerpt(ExcerptTest.java:277)
at
org.apache.jackrabbit.core.query.ExcerptTest.testHightlightFirstWord(ExcerptTest.java:48)
{noformat}
was (Author: reschke):
Looking at classes in {{org.apache.jackrabbit.oak.plugins.index.solr.server}}
it seems that we're indeed running an embedded server. See also
http://jackrabbit.apache.org/oak/docs/query/solr.html
> Make it possible to update Guava
>
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
> Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in
> order to make updates possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7250) Build Jackrabbit Oak #1232 failed
[ https://issues.apache.org/jira/browse/OAK-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355670#comment-16355670 ] Hudson commented on OAK-7250: - Build is still failing. Failed run: [Jackrabbit Oak #1233|https://builds.apache.org/job/Jackrabbit%20Oak/1233/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1233/console] > Build Jackrabbit Oak #1232 failed > - > > Key: OAK-7250 > URL: https://issues.apache.org/jira/browse/OAK-7250 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #1232 has failed. > First failed run: [Jackrabbit Oak > #1232|https://builds.apache.org/job/Jackrabbit%20Oak/1232/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/1232/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-7182) Make it possible to update Guava
[
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355645#comment-16355645
]
Julian Reschke edited comment on OAK-7182 at 2/7/18 4:12 PM:
-
Looking at classes in {{org.apache.jackrabbit.oak.plugins.index.solr.server}}
it seems that we're indeed running an embedded server. See also
http://jackrabbit.apache.org/oak/docs/query/solr.html
was (Author: reschke):
Looking at classes in {{org.apache.jackrabbit.oak.plugins.index.solr.server}}
it seems that we're indeed running an embedded server.
> Make it possible to update Guava
>
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
> Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in
> order to make updates possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355645#comment-16355645
]
Julian Reschke commented on OAK-7182:
-
Looking at classes in {{org.apache.jackrabbit.oak.plugins.index.solr.server}}
it seems that we're indeed running an embedded server.
> Make it possible to update Guava
>
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
> Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-7182-guava-21.diff, guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in
> order to make updates possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (OAK-7250) Build Jackrabbit Oak #1232 failed
Hudson created OAK-7250: --- Summary: Build Jackrabbit Oak #1232 failed Key: OAK-7250 URL: https://issues.apache.org/jira/browse/OAK-7250 Project: Jackrabbit Oak Issue Type: Bug Components: continuous integration Reporter: Hudson No description is provided The build Jackrabbit Oak #1232 has failed. First failed run: [Jackrabbit Oak #1232|https://builds.apache.org/job/Jackrabbit%20Oak/1232/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/1232/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7112) Update documentation for cold standby
[
https://issues.apache.org/jira/browse/OAK-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355598#comment-16355598
]
Andrei Dulceanu commented on OAK-7112:
--
Backported to 1.8 at r1823480.
> Update documentation for cold standby
> -
>
> Key: OAK-7112
> URL: https://issues.apache.org/jira/browse/OAK-7112
> Project: Jackrabbit Oak
> Issue Type: Documentation
> Components: doc, segment-tar, tarmk-standby
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: documentation
> Fix For: 1.9.0, 1.10, 1.8.3
>
>
> Improve monitoring section of cold standby in {{oak-doc}} to include missing
> MBean screenshots.
> -[~mduerig], [~frm]: How about adding a *Benchmarking* section to the cold
> standby page covering a bit ways to use the new {{Oak-Segment-Tar-Cold}}
> fixture and also running {{ScalabilityStandbySuite}} on top of it?-
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-7112) Update documentation for cold standby
[
https://issues.apache.org/jira/browse/OAK-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulceanu resolved OAK-7112.
--
Resolution: Fixed
> Update documentation for cold standby
> -
>
> Key: OAK-7112
> URL: https://issues.apache.org/jira/browse/OAK-7112
> Project: Jackrabbit Oak
> Issue Type: Documentation
> Components: doc, segment-tar, tarmk-standby
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: documentation
> Fix For: 1.9.0, 1.10, 1.8.3
>
>
> Improve monitoring section of cold standby in {{oak-doc}} to include missing
> MBean screenshots.
> -[~mduerig], [~frm]: How about adding a *Benchmarking* section to the cold
> standby page covering a bit ways to use the new {{Oak-Segment-Tar-Cold}}
> fixture and also running {{ScalabilityStandbySuite}} on top of it?-
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7249) Create charset encoding utility that detects malformed input
[ https://issues.apache.org/jira/browse/OAK-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355592#comment-16355592 ] Julian Reschke commented on OAK-7249: - trunk: [r1823479|http://svn.apache.org/r1823479] > Create charset encoding utility that detects malformed input > > > Key: OAK-7249 > URL: https://issues.apache.org/jira/browse/OAK-7249 > Project: Jackrabbit Oak > Issue Type: Task > Components: segment-tar >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.9.0, 1.10 > > Attachments: OAK-7249.diff > > > For now in segment-tar; might be moved later on. > Include test for: > - wellformed input > - malformed input > - multi-threaded encoding -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-7249) Create charset encoding utility that detects malformed input
[ https://issues.apache.org/jira/browse/OAK-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-7249. - Resolution: Fixed Fix Version/s: 1.9.0 > Create charset encoding utility that detects malformed input > > > Key: OAK-7249 > URL: https://issues.apache.org/jira/browse/OAK-7249 > Project: Jackrabbit Oak > Issue Type: Task > Components: segment-tar >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.9.0, 1.10 > > Attachments: OAK-7249.diff > > > For now in segment-tar; might be moved later on. > Include test for: > - wellformed input > - malformed input > - multi-threaded encoding -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7112) Update documentation for cold standby
[
https://issues.apache.org/jira/browse/OAK-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355585#comment-16355585
]
Andrei Dulceanu commented on OAK-7112:
--
Fixed in trunk at r1823478.
> Update documentation for cold standby
> -
>
> Key: OAK-7112
> URL: https://issues.apache.org/jira/browse/OAK-7112
> Project: Jackrabbit Oak
> Issue Type: Documentation
> Components: doc, segment-tar, tarmk-standby
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: documentation
> Fix For: 1.9.0, 1.10, 1.8.3
>
>
> Improve monitoring section of cold standby in {{oak-doc}} to include missing
> MBean screenshots.
> -[~mduerig], [~frm]: How about adding a *Benchmarking* section to the cold
> standby page covering a bit ways to use the new {{Oak-Segment-Tar-Cold}}
> fixture and also running {{ScalabilityStandbySuite}} on top of it?-
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7112) Update documentation for cold standby
[
https://issues.apache.org/jira/browse/OAK-7112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulceanu updated OAK-7112:
-
Description:
Improve monitoring section of cold standby in {{oak-doc}} to include missing
MBean screenshots.
-[~mduerig], [~frm]: How about adding a *Benchmarking* section to the cold
standby page covering a bit ways to use the new {{Oak-Segment-Tar-Cold}}
fixture and also running {{ScalabilityStandbySuite}} on top of it?-
was:
Improve monitoring section of cold standby in {{oak-doc}} to include missing
MBean screenshots.
[~mduerig], [~frm]: How about adding a *Benchmarking* section to the cold
standby page covering a bit ways to use the new {{Oak-Segment-Tar-Cold}}
fixture and also running {{ScalabilityStandbySuite}} on top of it?
> Update documentation for cold standby
> -
>
> Key: OAK-7112
> URL: https://issues.apache.org/jira/browse/OAK-7112
> Project: Jackrabbit Oak
> Issue Type: Documentation
> Components: doc, segment-tar, tarmk-standby
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: documentation
> Fix For: 1.9.0, 1.10, 1.8.3
>
>
> Improve monitoring section of cold standby in {{oak-doc}} to include missing
> MBean screenshots.
> -[~mduerig], [~frm]: How about adding a *Benchmarking* section to the cold
> standby page covering a bit ways to use the new {{Oak-Segment-Tar-Cold}}
> fixture and also running {{ScalabilityStandbySuite}} on top of it?-
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7173) Update documentation for oak-run check
[
https://issues.apache.org/jira/browse/OAK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355576#comment-16355576
]
Andrei Dulceanu commented on OAK-7173:
--
Backported to 1.8 at r1823475.
> Update documentation for oak-run check
> --
>
> Key: OAK-7173
> URL: https://issues.apache.org/jira/browse/OAK-7173
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: doc, oak-run, segment-tar
>Reporter: Michael Dürig
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: documentation
> Fix For: 1.9.0, 1.10, 1.8.3
>
> Attachments: OAK-7173.patch
>
>
> We should review and update the documentation of [{{oak-run
> check}}|http://jackrabbit.apache.org/oak/docs/nodestore/segment/overview.html#check].
> E.g. to include the new options from OAK-6373.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (OAK-7173) Update documentation for oak-run check
[
https://issues.apache.org/jira/browse/OAK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrei Dulceanu resolved OAK-7173.
--
Resolution: Fixed
> Update documentation for oak-run check
> --
>
> Key: OAK-7173
> URL: https://issues.apache.org/jira/browse/OAK-7173
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: doc, oak-run, segment-tar
>Reporter: Michael Dürig
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: documentation
> Fix For: 1.9.0, 1.10, 1.8.3
>
> Attachments: OAK-7173.patch
>
>
> We should review and update the documentation of [{{oak-run
> check}}|http://jackrabbit.apache.org/oak/docs/nodestore/segment/overview.html#check].
> E.g. to include the new options from OAK-6373.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7249) Create charset encoding utility that detects malformed input
[ https://issues.apache.org/jira/browse/OAK-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355568#comment-16355568 ] Michael Dürig commented on OAK-7249: LGTM > Create charset encoding utility that detects malformed input > > > Key: OAK-7249 > URL: https://issues.apache.org/jira/browse/OAK-7249 > Project: Jackrabbit Oak > Issue Type: Task > Components: segment-tar >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.10 > > Attachments: OAK-7249.diff > > > For now in segment-tar; might be moved later on. > Include test for: > - wellformed input > - malformed input > - multi-threaded encoding -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7249) Create charset encoding utility that detects malformed input
[ https://issues.apache.org/jira/browse/OAK-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355545#comment-16355545 ] Julian Reschke commented on OAK-7249: - Proposed code and test case: https://issues.apache.org/jira/secure/attachment/12909623/OAK-7249.diff cc [~mduerig] > Create charset encoding utility that detects malformed input > > > Key: OAK-7249 > URL: https://issues.apache.org/jira/browse/OAK-7249 > Project: Jackrabbit Oak > Issue Type: Task > Components: segment-tar >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.10 > > Attachments: OAK-7249.diff > > > For now in segment-tar; might be moved later on. > Include test for: > - wellformed input > - malformed input > - multi-threaded encoding -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7249) Create charset encoding utility that detects malformed input
[ https://issues.apache.org/jira/browse/OAK-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7249: Attachment: OAK-7249.diff > Create charset encoding utility that detects malformed input > > > Key: OAK-7249 > URL: https://issues.apache.org/jira/browse/OAK-7249 > Project: Jackrabbit Oak > Issue Type: Task > Components: segment-tar >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.10 > > Attachments: OAK-7249.diff > > > For now in segment-tar; might be moved later on. > Include test for: > - wellformed input > - malformed input > - multi-threaded encoding -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7173) Update documentation for oak-run check
[
https://issues.apache.org/jira/browse/OAK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355478#comment-16355478
]
Andrei Dulceanu commented on OAK-7173:
--
Fixed in trunk at r1823466.
> Update documentation for oak-run check
> --
>
> Key: OAK-7173
> URL: https://issues.apache.org/jira/browse/OAK-7173
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: doc, oak-run, segment-tar
>Reporter: Michael Dürig
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: documentation
> Fix For: 1.9.0, 1.10, 1.8.3
>
> Attachments: OAK-7173.patch
>
>
> We should review and update the documentation of [{{oak-run
> check}}|http://jackrabbit.apache.org/oak/docs/nodestore/segment/overview.html#check].
> E.g. to include the new options from OAK-6373.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7041) Migration progress not logged for some sidegrade cases
[
https://issues.apache.org/jira/browse/OAK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-7041:
--
Fix Version/s: (was: 1.6.9)
> Migration progress not logged for some sidegrade cases
> --
>
> Key: OAK-7041
> URL: https://issues.apache.org/jira/browse/OAK-7041
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Affects Versions: 1.4.16, 1.6.7, 1.0.40, 1.2.28
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.6.10
>
>
> For the sidegrades using segment or segment-tar as the destination the
> progress ({{Copying node #...}}) is not logged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-5458) Test failure: RepositoryBootIT.repositoryLogin
[ https://issues.apache.org/jira/browse/OAK-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5458: -- Fix Version/s: (was: 1.6.9) > Test failure: RepositoryBootIT.repositoryLogin > -- > > Key: OAK-5458 > URL: https://issues.apache.org/jira/browse/OAK-5458 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration, examples >Affects Versions: 1.4, 1.5.18 >Reporter: Hudson >Assignee: Chetan Mehrotra >Priority: Major > Labels: test-failure, ubuntu > Fix For: 1.10, 1.4.20, 1.6.10 > > Attachments: unit-tests-1379.log > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 > (latest),nsfixtures=SEGMENT_MK,profile=integrationTesting #1369 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.8 (latest),nsfixtures=SEGMENT_MK,profile=integrationTesting > #1369|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=SEGMENT_MK,profile=integrationTesting/1369/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=SEGMENT_MK,profile=integrationTesting/1369/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-5458) Test failure: RepositoryBootIT.repositoryLogin
[ https://issues.apache.org/jira/browse/OAK-5458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Davide Giannella updated OAK-5458: -- Fix Version/s: 1.6.10 > Test failure: RepositoryBootIT.repositoryLogin > -- > > Key: OAK-5458 > URL: https://issues.apache.org/jira/browse/OAK-5458 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration, examples >Affects Versions: 1.4, 1.5.18 >Reporter: Hudson >Assignee: Chetan Mehrotra >Priority: Major > Labels: test-failure, ubuntu > Fix For: 1.10, 1.4.20, 1.6.9, 1.6.10 > > Attachments: unit-tests-1379.log > > > Jenkins CI failure: > https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/ > The build Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK 1.8 > (latest),nsfixtures=SEGMENT_MK,profile=integrationTesting #1369 has failed. > First failed run: [Apache Jackrabbit Oak matrix/Ubuntu Slaves=ubuntu,jdk=JDK > 1.8 (latest),nsfixtures=SEGMENT_MK,profile=integrationTesting > #1369|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=SEGMENT_MK,profile=integrationTesting/1369/] > [console > log|https://builds.apache.org/job/Apache%20Jackrabbit%20Oak%20matrix/Ubuntu%20Slaves=ubuntu,jdk=JDK%201.8%20(latest),nsfixtures=SEGMENT_MK,profile=integrationTesting/1369/console] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7041) Migration progress not logged for some sidegrade cases
[
https://issues.apache.org/jira/browse/OAK-7041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Davide Giannella updated OAK-7041:
--
Fix Version/s: 1.6.10
> Migration progress not logged for some sidegrade cases
> --
>
> Key: OAK-7041
> URL: https://issues.apache.org/jira/browse/OAK-7041
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Affects Versions: 1.4.16, 1.6.7, 1.0.40, 1.2.28
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.6.9, 1.6.10
>
>
> For the sidegrades using segment or segment-tar as the destination the
> progress ({{Copying node #...}}) is not logged.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-5272) Expose BlobStore API to provide information whether blob id is content hashed
[ https://issues.apache.org/jira/browse/OAK-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355203#comment-16355203 ] Amit Jain commented on OAK-5272: [~tmueller] Thanks! bq. what about the case where one blob has a SHA-1 content hash, and the other has a SHA-256 content hash? Yeah I missed that in which case the method you added makes sense. We'll need to add the method to the concrete instances (BlobStoreBlob/SegmentBlob) or alternately add it only to the AbstractBlob and then expose the required info from the concrete instances (either the BlobStore or other info directly). Let me work in it including tests and then I can put out a patch. > Expose BlobStore API to provide information whether blob id is content hashed > - > > Key: OAK-5272 > URL: https://issues.apache.org/jira/browse/OAK-5272 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: blob >Reporter: Amit Jain >Priority: Major > > As per discussion in OAK-5253 it's better to have some information from the > BlobStore(s) whether the blob id can be solely relied upon for comparison. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-5272) Expose BlobStore API to provide information whether blob id is content hashed
[
https://issues.apache.org/jira/browse/OAK-5272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355158#comment-16355158
]
Thomas Mueller commented on OAK-5272:
-
[~amitjain] what about the case where one blob has a SHA-1 content hash, and
the other has a SHA-256 content hash?
The content hash is different, but the content could still be the same.
> currently the BlobStore(s) are not aware of the Blob object.
Are blobs aware of the blob store? If yes, what about adding a method "compare
content" to the blob, something like this:
{noformat}
public enum Equality { EQUALS, DIFFERENT, UNKNOWN };
public Equality compareContent(Blob other) {
if (this == other) {
return Equality.EQUALS;
} else if (other == null) {
return Equality.DIFFERENT;
}
if (length() != other.length()) {
return Equality.DIFFERENT;
}
if (!blobStore.hasContentAdressableBlobIds()) {
return Equality.UNKNOWN;
}
// TODO is strict type check needed, or is "instanceof" sufficient?
if (other.getClass() == getClass()) {
BlobStoreBlob otherBlob = (BlobStoreBlob) other;
if (!otherBlob.blobStore.hasContentAdressableBlobIds()) {
return Equality.UNKNOWN;
}
// TODO maybe blobId contains the length? in this case, truncate
that part
if (otherBlob.blobId.length() != blobId.length()) {
return Equality.UNKNOWN;
}
return blobId.equals(otherBlob.blobId) ? Equality.EQUALS :
Equality.DIFFERENT;
}
return Equality.UNKNOWN;
}
{noformat}
I know, many cases...
Your method is still needed, but we would need to extend the description a bit:
{noformat}
/**
*
* Will return true if blob ids are generated from content hash.
* Content hashes of the same length can be used for equality checks
* (content hashes of different length are generated with different
algorithms).
*
* @return true if blobs are content addressable
*/
boolean hasContentAdressableBlobIds();
{noformat}
> Expose BlobStore API to provide information whether blob id is content hashed
> -
>
> Key: OAK-5272
> URL: https://issues.apache.org/jira/browse/OAK-5272
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: blob
>Reporter: Amit Jain
>Priority: Major
>
> As per discussion in OAK-5253 it's better to have some information from the
> BlobStore(s) whether the blob id can be solely relied upon for comparison.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7173) Update documentation for oak-run check
[
https://issues.apache.org/jira/browse/OAK-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16355125#comment-16355125
]
Francesco Mari commented on OAK-7173:
-
LGTM
> Update documentation for oak-run check
> --
>
> Key: OAK-7173
> URL: https://issues.apache.org/jira/browse/OAK-7173
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: doc, oak-run, segment-tar
>Reporter: Michael Dürig
>Assignee: Andrei Dulceanu
>Priority: Major
> Labels: documentation
> Fix For: 1.9.0, 1.10, 1.8.3
>
> Attachments: OAK-7173.patch
>
>
> We should review and update the documentation of [{{oak-run
> check}}|http://jackrabbit.apache.org/oak/docs/nodestore/segment/overview.html#check].
> E.g. to include the new options from OAK-6373.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
