[jira] [Commented] (OAK-7442) Remove dependency to commons-codec
[ https://issues.apache.org/jira/browse/OAK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491928#comment-16491928 ] Julian Reschke commented on OAK-7442: - trunk: [r1830171|http://svn.apache.org/r1830171] 1.8: [r1832322|http://svn.apache.org/r1832322] > Remove dependency to commons-codec > -- > > Key: OAK-7442 > URL: https://issues.apache.org/jira/browse/OAK-7442 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_6, technical_debt > Fix For: 1.10, 1.9.1, 1.8.4 > > > The module oak-store-document currently only uses a single utility method > from commons-codec. It shouldn't be too difficult to remove this dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7442) Remove dependency to commons-codec
[ https://issues.apache.org/jira/browse/OAK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7442: Labels: candidate_oak_1_6 technical_debt (was: candidate_oak_1_8 technical_debt) > Remove dependency to commons-codec > -- > > Key: OAK-7442 > URL: https://issues.apache.org/jira/browse/OAK-7442 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_6, technical_debt > Fix For: 1.10, 1.9.1, 1.8.4 > > > The module oak-store-document currently only uses a single utility method > from commons-codec. It shouldn't be too difficult to remove this dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7442) Remove dependency to commons-codec
[ https://issues.apache.org/jira/browse/OAK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7442: Fix Version/s: 1.8.4 > Remove dependency to commons-codec > -- > > Key: OAK-7442 > URL: https://issues.apache.org/jira/browse/OAK-7442 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_6, technical_debt > Fix For: 1.10, 1.9.1, 1.8.4 > > > The module oak-store-document currently only uses a single utility method > from commons-codec. It shouldn't be too difficult to remove this dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-7160) Update commons-codec dependency to 1.11
[ https://issues.apache.org/jira/browse/OAK-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326864#comment-16326864 ] Julian Reschke edited comment on OAK-7160 at 5/26/18 3:14 PM: -- trunk: [r1829534|http://svn.apache.org/r1829534] [r1821360|http://svn.apache.org/r1821360] [r1821221|http://svn.apache.org/r1821221] 1.8: [r1832315|http://svn.apache.org/r1832315] was (Author: reschke): trunk: [r1829534|http://svn.apache.org/r1829534] [r1821360|http://svn.apache.org/r1821360] [r1821221|http://svn.apache.org/r1821221] > Update commons-codec dependency to 1.11 > --- > > Key: OAK-7160 > URL: https://issues.apache.org/jira/browse/OAK-7160 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10, 1.8.4 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7160) Update commons-codec dependency to 1.11
[ https://issues.apache.org/jira/browse/OAK-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7160: Labels: candidate_oak_1_6 (was: candidate_oak_1_8) > Update commons-codec dependency to 1.11 > --- > > Key: OAK-7160 > URL: https://issues.apache.org/jira/browse/OAK-7160 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10, 1.8.4 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7160) Update commons-codec dependency to 1.11
[ https://issues.apache.org/jira/browse/OAK-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7160: Fix Version/s: 1.8.4 > Update commons-codec dependency to 1.11 > --- > > Key: OAK-7160 > URL: https://issues.apache.org/jira/browse/OAK-7160 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10, 1.8.4 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7442) Remove dependency to commons-codec
[ https://issues.apache.org/jira/browse/OAK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7442: Labels: candidate_oak_1_8 technical_debt (was: technical_debt) > Remove dependency to commons-codec > -- > > Key: OAK-7442 > URL: https://issues.apache.org/jira/browse/OAK-7442 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Marcel Reutegger >Assignee: Marcel Reutegger >Priority: Minor > Labels: candidate_oak_1_8, technical_debt > Fix For: 1.10, 1.9.1 > > > The module oak-store-document currently only uses a single utility method > from commons-codec. It shouldn't be too difficult to remove this dependency. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (OAK-7286) DocumentNodeStoreBranch handling of non-recoverable DocumentStoreExceptions
[
https://issues.apache.org/jira/browse/OAK-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved OAK-7286.
-
Resolution: Fixed
> DocumentNodeStoreBranch handling of non-recoverable DocumentStoreExceptions
> ---
>
> Key: OAK-7286
> URL: https://issues.apache.org/jira/browse/OAK-7286
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Marcel Reutegger
>Priority: Major
> Fix For: 1.10
>
> Attachments: OAK-7286-DocumentStoreException.patch,
> OAK-7286-DocumentStoreException.patch, OAK-7286.diff, OAK-7286.diff
>
>
> In {{DocumentNodeStoreBranch.merge()}}, any {{DocumentStoreException}} is
> mapped to a {{DocumentStoreException}} to a {{CommitFailedException}} of type
> "MERGE", which leads to the operation being retried, and a non-helpful
> exception being generated.
> The effect can be observed by enabling a test in {{ValidNamesTest}}:
> {noformat}
> --- oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ValidNamesTest.java
> (Revision 1825371)
> +++ oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ValidNamesTest.java
> (Arbeitskopie)
> @@ -300,7 +300,6 @@
> public void testUnpairedHighSurrogateEnd() {
> // see OAK-5506
>
> org.junit.Assume.assumeFalse(super.fixture.toString().toLowerCase().contains("segment"));
> -
> org.junit.Assume.assumeFalse(super.fixture.toString().toLowerCase().contains("rdb"));
> nameTest("foo" + SURROGATE_PAIR[0]);
> }
> @@ -336,6 +335,7 @@
> assertEquals("paths should be equal", p.getPath(), n.getPath());
> return p;
> } catch (RepositoryException ex) {
> +ex.printStackTrace();
> fail(ex.getMessage());
> return null;
> }
> {noformat}
> The underlying issue is that {{RDBDocumentStore}} is throwing a
> {{DocumentStoreException}} due to the invalid ID, and repeating the call will
> not help.
> We probably should have a way to dinstinguish between different types of
> problems.
> I hacked {{DocumentNodeStoreBranch}} like that:
> {noformat}
> ---
> oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBranch.java
> (Revision 1825371)
> +++
> oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBranch.java
> (Arbeitskopie)
> @@ -520,8 +520,12 @@
> } catch (ConflictException e) {
> throw e.asCommitFailedException();
> } catch(DocumentStoreException e) {
> -throw new CommitFailedException(MERGE, 1,
> -"Failed to merge changes to the underlying
> store", e);
> +if (e.getMessage().contains("Invalid ID")) {
> +throw new CommitFailedException(OAK, 123,
> +"Failed to store changes in the underlying
> store: " + e.getMessage(), e);
> +} else {
> +throw new CommitFailedException(MERGE, 1, "Failed to
> merge changes to the underlying store", e);
> +}
> } catch (Exception e) {
> throw new CommitFailedException(OAK, 1,
> "Failed to merge changes to the underlying
> store", e);
> {noformat}
> ...which causes the exception to surface immediately (see
> https://issues.apache.org/jira/secure/attachment/12912117/OAK-7286.diff).
> (cc [~mreutegg])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OAK-7331) RDBDocumentStore: add index on _MODIFIED to improve VersionGC performance
[ https://issues.apache.org/jira/browse/OAK-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398740#comment-16398740 ] Julian Reschke edited comment on OAK-7331 at 5/26/18 2:54 PM: -- trunk: [r1826730|http://svn.apache.org/r1826730] 1.8: [r1832314|http://svn.apache.org/r1832314] was (Author: reschke): trunk: [r1826730|http://svn.apache.org/r1826730] > RDBDocumentStore: add index on _MODIFIED to improve VersionGC performance > - > > Key: OAK-7331 > URL: https://issues.apache.org/jira/browse/OAK-7331 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10, 1.8.4 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7331) RDBDocumentStore: add index on _MODIFIED to improve VersionGC performance
[ https://issues.apache.org/jira/browse/OAK-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7331: Fix Version/s: 1.8.4 > RDBDocumentStore: add index on _MODIFIED to improve VersionGC performance > - > > Key: OAK-7331 > URL: https://issues.apache.org/jira/browse/OAK-7331 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10, 1.8.4 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7331) RDBDocumentStore: add index on _MODIFIED to improve VersionGC performance
[ https://issues.apache.org/jira/browse/OAK-7331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7331: Labels: candidate_oak_1_6 (was: candidate_oak_1_8) > RDBDocumentStore: add index on _MODIFIED to improve VersionGC performance > - > > Key: OAK-7331 > URL: https://issues.apache.org/jira/browse/OAK-7331 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10, 1.8.4 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-7186) avoid use of guava Iterators.emptyIterator()
[ https://issues.apache.org/jira/browse/OAK-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335579#comment-16335579 ] Julian Reschke edited comment on OAK-7186 at 5/26/18 11:59 AM: --- trunk: [r1821983|http://svn.apache.org/r1821983] [r1821982|http://svn.apache.org/r1821982] [r1821981|http://svn.apache.org/r1821981] [r1821980|http://svn.apache.org/r1821980] [r1821979|http://svn.apache.org/r1821979] [r1821978|http://svn.apache.org/r1821978] [r1821977|http://svn.apache.org/r1821977] [r1821976|http://svn.apache.org/r1821976] [r1821975|http://svn.apache.org/r1821975] 1.8: [r1832304|http://svn.apache.org/r1832304] was (Author: reschke): trunk: [r1821983|http://svn.apache.org/r1821983] [r1821982|http://svn.apache.org/r1821982] [r1821981|http://svn.apache.org/r1821981] [r1821980|http://svn.apache.org/r1821980] [r1821979|http://svn.apache.org/r1821979] [r1821978|http://svn.apache.org/r1821978] [r1821977|http://svn.apache.org/r1821977] [r1821976|http://svn.apache.org/r1821976] [r1821975|http://svn.apache.org/r1821975] > avoid use of guava Iterators.emptyIterator() > > > Key: OAK-7186 > URL: https://issues.apache.org/jira/browse/OAK-7186 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10, 1.8.4 > > Attachments: OAK-7186.diff > > > Deprecated in Guava 19, removed in 20. > > [https://google.github.io/guava/releases/19.0/api/docs/com/google/common/collect/Iterators.html#emptyIterator()] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7186) avoid use of guava Iterators.emptyIterator()
[ https://issues.apache.org/jira/browse/OAK-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7186: Labels: candidate_oak_1_6 (was: candidate_oak_1_8) > avoid use of guava Iterators.emptyIterator() > > > Key: OAK-7186 > URL: https://issues.apache.org/jira/browse/OAK-7186 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10, 1.8.4 > > Attachments: OAK-7186.diff > > > Deprecated in Guava 19, removed in 20. > > [https://google.github.io/guava/releases/19.0/api/docs/com/google/common/collect/Iterators.html#emptyIterator()] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7186) avoid use of guava Iterators.emptyIterator()
[ https://issues.apache.org/jira/browse/OAK-7186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7186: Fix Version/s: 1.8.4 > avoid use of guava Iterators.emptyIterator() > > > Key: OAK-7186 > URL: https://issues.apache.org/jira/browse/OAK-7186 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Labels: candidate_oak_1_6 > Fix For: 1.9.0, 1.10, 1.8.4 > > Attachments: OAK-7186.diff > > > Deprecated in Guava 19, removed in 20. > > [https://google.github.io/guava/releases/19.0/api/docs/com/google/common/collect/Iterators.html#emptyIterator()] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-7161) LengthCachingDataStore's use of LineIterator.close()
[
https://issues.apache.org/jira/browse/OAK-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327076#comment-16327076
]
Julian Reschke edited comment on OAK-7161 at 5/26/18 9:51 AM:
--
trunk: [r1821237|http://svn.apache.org/r1821237]
1.8: [r1832301|http://svn.apache.org/r1832301]
was (Author: reschke):
trunk: [r1821237|http://svn.apache.org/r1821237]
> LengthCachingDataStore's use of LineIterator.close()
>
>
> Key: OAK-7161
> URL: https://issues.apache.org/jira/browse/OAK-7161
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: upgrade
> Environment: Later versions of commons-io added an exception to
> {{LineIterator.close()}}. See https://issues.apache.org/jira/browse/IO-505.
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Labels: candidate_oak_1_6
> Fix For: 1.9.0, 1.10, 1.8.4
>
> Attachments: OAK-7161.diff
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7161) LengthCachingDataStore's use of LineIterator.close()
[
https://issues.apache.org/jira/browse/OAK-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7161:
Fix Version/s: 1.8.4
> LengthCachingDataStore's use of LineIterator.close()
>
>
> Key: OAK-7161
> URL: https://issues.apache.org/jira/browse/OAK-7161
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: upgrade
> Environment: Later versions of commons-io added an exception to
> {{LineIterator.close()}}. See https://issues.apache.org/jira/browse/IO-505.
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Labels: candidate_oak_1_6
> Fix For: 1.9.0, 1.10, 1.8.4
>
> Attachments: OAK-7161.diff
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7161) LengthCachingDataStore's use of LineIterator.close()
[
https://issues.apache.org/jira/browse/OAK-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7161:
Labels: candidate_oak_1_6 (was: candidate_oak_1_8)
> LengthCachingDataStore's use of LineIterator.close()
>
>
> Key: OAK-7161
> URL: https://issues.apache.org/jira/browse/OAK-7161
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: upgrade
> Environment: Later versions of commons-io added an exception to
> {{LineIterator.close()}}. See https://issues.apache.org/jira/browse/IO-505.
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Labels: candidate_oak_1_6
> Fix For: 1.9.0, 1.10, 1.8.4
>
> Attachments: OAK-7161.diff
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
