[jira] [Commented] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Vikas Saurabh (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689636#comment-16689636
 ] 

Vikas Saurabh commented on OAK-7907:


I just looked that {{_v2}} patch. I think {{@Reference}} annotated variable 
shouldn't be static. Such variables are initialized when say 
{{QueryEngineSettingsService}} is activated. Accessing such variables 
statically feels wrong to me. Also, btw, it feels weird to expose a 
{{markMeter}} method from {{QueryStatsMBean}}.

Where are we planning to invoke {{markMeter}} from btw?

> Exporting total query count with Sling Metrics / DropWizard
> ---
>
> Key: OAK-7907
> URL: https://issues.apache.org/jira/browse/OAK-7907
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing, query
>Reporter: Paul Chibulcuteanu
>Assignee: Paul Chibulcuteanu
>Priority: Major
> Attachments: OAK-7907_v1.patch, OAK-7907_v2.patch
>
>
> Purpose of this task is to evaluate & create a metric which presents the 
> number of queries run in Oak.
> metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Paul Chibulcuteanu (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689634#comment-16689634
 ] 

Paul Chibulcuteanu commented on OAK-7907:
-

Thanks [~teofili]. I think it's a good idea to have the util methods for 
updating query metrics under QueryStatsMBean. I guess we will add more when the 
time comes(for Histograms, Gauges, etc.)

I tested out your patch a bit and it seems that statisticsProvider is _null_ in 
this case, thus resulting in metrics not being collected. Does making 
_statisticsProvider_ static has something to do with this?
Besides that some unused imports from _QueryEngineImpl_ and 
_QueryEngineSettingsService_ should be removed. 



> Exporting total query count with Sling Metrics / DropWizard
> ---
>
> Key: OAK-7907
> URL: https://issues.apache.org/jira/browse/OAK-7907
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing, query
>Reporter: Paul Chibulcuteanu
>Assignee: Paul Chibulcuteanu
>Priority: Major
> Attachments: OAK-7907_v1.patch, OAK-7907_v2.patch
>
>
> Purpose of this task is to evaluate & create a metric which presents the 
> number of queries run in Oak.
> metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Tommaso Teofili (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689598#comment-16689598
 ] 

Tommaso Teofili commented on OAK-7907:
--

thanks a lot [~chibulcu] for your patch, I think {{QuerySettingsService}} is 
the only possible OSGi service already available that can be used to obtain the 
{{StatisticsProvider}} so that's fine.
I have refactored your solution a bit so that the stats can be updated in 
{{QueryStatsMBean}} so that, hopefully, we can update and retrieve stats in a 
single place.
WDYT?

> Exporting total query count with Sling Metrics / DropWizard
> ---
>
> Key: OAK-7907
> URL: https://issues.apache.org/jira/browse/OAK-7907
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing, query
>Reporter: Paul Chibulcuteanu
>Assignee: Paul Chibulcuteanu
>Priority: Major
> Attachments: OAK-7907_v1.patch, OAK-7907_v2.patch
>
>
> Purpose of this task is to evaluate & create a metric which presents the 
> number of queries run in Oak.
> metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Tommaso Teofili (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tommaso Teofili updated OAK-7907:
-
Attachment: OAK-7907_v2.patch

> Exporting total query count with Sling Metrics / DropWizard
> ---
>
> Key: OAK-7907
> URL: https://issues.apache.org/jira/browse/OAK-7907
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing, query
>Reporter: Paul Chibulcuteanu
>Assignee: Paul Chibulcuteanu
>Priority: Major
> Attachments: OAK-7907_v1.patch, OAK-7907_v2.patch
>
>
> Purpose of this task is to evaluate & create a metric which presents the 
> number of queries run in Oak.
> metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-16 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689537#comment-16689537
 ] 

Julian Reschke edited comment on OAK-7906 at 11/16/18 3:57 PM:
---

Maybe 
<[http://mail.openjdk.java.net/pipermail/security-dev/2018-October/018591.html]>?

In particular:
{quote}This change implements AccessController.doPrivileged in Java. This 
 gives a performance improvement while also being useful to Project Loom 
 by removing the Java --> native --> Java transition. One reason 
 doPrivileged has historically been in native is because of the need to 
 guarantee the cleanup of the privileged context when doPrivileged 
 returns. *_To do that in Java, the information that_* 
 *_AccessController.getContext needs is pushed onto the Java stack as_* 
 *_arguments to a method that getContext will recognize during its stack_* 
 *_walk. This allows us to remove the native privileged stack while_* 
 *_guaranteeing that the privileged context goes away when the method returns._*
{quote}


was (Author: reschke):
Maybe 
?

> StackOverFlowError 
> SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12
> -
>
> Key: OAK-7906
> URL: https://issues.apache.org/jira/browse/OAK-7906
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Affects Versions: 1.9.11
>Reporter: Julian Reschke
>Priority: Major
>  Labels: Java12
>
> Happens with version 20 (2018/11/15).
> It appears that the StackOverflowError happens when obtaining many sessions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Issue Comment Deleted] (OAK-7709) DocumentNodeStore dispose aborts when store was disposed due to LeaseUpdate error

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7709:

Comment: was deleted

(was: trunk: [r1840462|http://svn.apache.org/r1840462])

> DocumentNodeStore dispose aborts when store was disposed due to LeaseUpdate 
> error
> -
>
> Key: OAK-7709
> URL: https://issues.apache.org/jira/browse/OAK-7709
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.8.2
> Environment: * Linux
> * IBM JDK 8
>Reporter: Jörg Hoh
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.10, 1.9.9, 1.8.10
>
> Attachments: OAK-7709.diff, OAK-7709.diff
>
>
> During a maintenance of our database system the DocumentNodeStore bundle shut 
> down because of a lease timeout. When we restart the bundle, we ran into 
> these exceptions:
> {code}
> 16.08.2018 11:32:44.139 *INFO* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService 
> Configuring persistent cache to only cache nodes under paths [/libs, /apps, 
> /jcr:system/jcr:nodeTypes, /jcr:system/rep:namespaces]
> 16.08.2018 11:32:44.155 *INFO* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache 
> start, url=/opt/aem/repository/sling/_cqa/cache,size=2048,binary=0
> 16.08.2018 11:32:44.156 *WARN* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.MapFactory Error 
> in the background thread of the persistent cache: 
> java.lang.IllegalStateException: The file is locked: 
> nio:/opt/aem/repository/sling/_cqa/cache/cache-0.data [1.4.194/7]
> 16.08.2018 11:32:44.157 *WARN* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.MapFactory Could 
> not open the store /opt/aem/repository/sling/_cqa/cache/cache-0.data
> java.lang.IllegalStateException: The file is locked: 
> nio:/opta/aem/repository/sling/_cqa/cache/cache-0.data [1.4.194/7]
> at org.h2.mvstore.DataUtils.newIllegalStateException(DataUtils.java:765)
> at org.h2.mvstore.FileStore.open(FileStore.java:168)
> at org.h2.mvstore.MVStore.(MVStore.java:347)
> at org.h2.mvstore.MVStore$Builder.open(MVStore.java:2930)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache$1.openStore(PersistentCache.java:288)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache.createMapFactory(PersistentCache.java:361)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache.(PersistentCache.java:210)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.getPersistentCache(DocumentNodeStoreBuilder.java:648)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildCache(DocumentNodeStoreBuilder.java:627)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildDocumentCache(DocumentNodeStoreBuilder.java:586)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildNodeDocumentCache(DocumentNodeStoreBuilder.java:594)
> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.initialize(RDBDocumentStore.java:967)
> {code}
> It seems that the mvstore wasn't shut down properly during the stop of the 
> DocumentNodeStore. For me it seems that the DocumentNodeStore doesn't use the 
> persistent cache anymore until there was a "hard" restart (on the JVM).
> It would be good if even in this situation the shutdown of the 
> DocumentNodeStore could drop the lock on the mvstore, so a clean restart of 
> the bundle is possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7709) DocumentNodeStore dispose aborts when store was disposed due to LeaseUpdate error

2018-11-16 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689563#comment-16689563
 ] 

Julian Reschke commented on OAK-7709:
-

trunk: [r1840462|http://svn.apache.org/r1840462]
1.8: [r1846721|http://svn.apache.org/r1846721]


> DocumentNodeStore dispose aborts when store was disposed due to LeaseUpdate 
> error
> -
>
> Key: OAK-7709
> URL: https://issues.apache.org/jira/browse/OAK-7709
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.8.2
> Environment: * Linux
> * IBM JDK 8
>Reporter: Jörg Hoh
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.10, 1.9.9, 1.8.10
>
> Attachments: OAK-7709.diff, OAK-7709.diff
>
>
> During a maintenance of our database system the DocumentNodeStore bundle shut 
> down because of a lease timeout. When we restart the bundle, we ran into 
> these exceptions:
> {code}
> 16.08.2018 11:32:44.139 *INFO* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService 
> Configuring persistent cache to only cache nodes under paths [/libs, /apps, 
> /jcr:system/jcr:nodeTypes, /jcr:system/rep:namespaces]
> 16.08.2018 11:32:44.155 *INFO* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache 
> start, url=/opt/aem/repository/sling/_cqa/cache,size=2048,binary=0
> 16.08.2018 11:32:44.156 *WARN* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.MapFactory Error 
> in the background thread of the persistent cache: 
> java.lang.IllegalStateException: The file is locked: 
> nio:/opt/aem/repository/sling/_cqa/cache/cache-0.data [1.4.194/7]
> 16.08.2018 11:32:44.157 *WARN* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.MapFactory Could 
> not open the store /opt/aem/repository/sling/_cqa/cache/cache-0.data
> java.lang.IllegalStateException: The file is locked: 
> nio:/opta/aem/repository/sling/_cqa/cache/cache-0.data [1.4.194/7]
> at org.h2.mvstore.DataUtils.newIllegalStateException(DataUtils.java:765)
> at org.h2.mvstore.FileStore.open(FileStore.java:168)
> at org.h2.mvstore.MVStore.(MVStore.java:347)
> at org.h2.mvstore.MVStore$Builder.open(MVStore.java:2930)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache$1.openStore(PersistentCache.java:288)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache.createMapFactory(PersistentCache.java:361)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache.(PersistentCache.java:210)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.getPersistentCache(DocumentNodeStoreBuilder.java:648)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildCache(DocumentNodeStoreBuilder.java:627)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildDocumentCache(DocumentNodeStoreBuilder.java:586)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildNodeDocumentCache(DocumentNodeStoreBuilder.java:594)
> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.initialize(RDBDocumentStore.java:967)
> {code}
> It seems that the mvstore wasn't shut down properly during the stop of the 
> DocumentNodeStore. For me it seems that the DocumentNodeStore doesn't use the 
> persistent cache anymore until there was a "hard" restart (on the JVM).
> It would be good if even in this situation the shutdown of the 
> DocumentNodeStore could drop the lock on the mvstore, so a clean restart of 
> the bundle is possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7709) DocumentNodeStore dispose aborts when store was disposed due to LeaseUpdate error

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7709:

Labels:   (was: candidate_oak_1_8)

> DocumentNodeStore dispose aborts when store was disposed due to LeaseUpdate 
> error
> -
>
> Key: OAK-7709
> URL: https://issues.apache.org/jira/browse/OAK-7709
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.8.2
> Environment: * Linux
> * IBM JDK 8
>Reporter: Jörg Hoh
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.10, 1.9.9, 1.8.10
>
> Attachments: OAK-7709.diff, OAK-7709.diff
>
>
> During a maintenance of our database system the DocumentNodeStore bundle shut 
> down because of a lease timeout. When we restart the bundle, we ran into 
> these exceptions:
> {code}
> 16.08.2018 11:32:44.139 *INFO* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService 
> Configuring persistent cache to only cache nodes under paths [/libs, /apps, 
> /jcr:system/jcr:nodeTypes, /jcr:system/rep:namespaces]
> 16.08.2018 11:32:44.155 *INFO* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache 
> start, url=/opt/aem/repository/sling/_cqa/cache,size=2048,binary=0
> 16.08.2018 11:32:44.156 *WARN* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.MapFactory Error 
> in the background thread of the persistent cache: 
> java.lang.IllegalStateException: The file is locked: 
> nio:/opt/aem/repository/sling/_cqa/cache/cache-0.data [1.4.194/7]
> 16.08.2018 11:32:44.157 *WARN* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.MapFactory Could 
> not open the store /opt/aem/repository/sling/_cqa/cache/cache-0.data
> java.lang.IllegalStateException: The file is locked: 
> nio:/opta/aem/repository/sling/_cqa/cache/cache-0.data [1.4.194/7]
> at org.h2.mvstore.DataUtils.newIllegalStateException(DataUtils.java:765)
> at org.h2.mvstore.FileStore.open(FileStore.java:168)
> at org.h2.mvstore.MVStore.(MVStore.java:347)
> at org.h2.mvstore.MVStore$Builder.open(MVStore.java:2930)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache$1.openStore(PersistentCache.java:288)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache.createMapFactory(PersistentCache.java:361)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache.(PersistentCache.java:210)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.getPersistentCache(DocumentNodeStoreBuilder.java:648)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildCache(DocumentNodeStoreBuilder.java:627)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildDocumentCache(DocumentNodeStoreBuilder.java:586)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildNodeDocumentCache(DocumentNodeStoreBuilder.java:594)
> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.initialize(RDBDocumentStore.java:967)
> {code}
> It seems that the mvstore wasn't shut down properly during the stop of the 
> DocumentNodeStore. For me it seems that the DocumentNodeStore doesn't use the 
> persistent cache anymore until there was a "hard" restart (on the JVM).
> It would be good if even in this situation the shutdown of the 
> DocumentNodeStore could drop the lock on the mvstore, so a clean restart of 
> the bundle is possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7709) DocumentNodeStore dispose aborts when store was disposed due to LeaseUpdate error

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7709:

Fix Version/s: 1.8.10

> DocumentNodeStore dispose aborts when store was disposed due to LeaseUpdate 
> error
> -
>
> Key: OAK-7709
> URL: https://issues.apache.org/jira/browse/OAK-7709
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.8.2
> Environment: * Linux
> * IBM JDK 8
>Reporter: Jörg Hoh
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.10, 1.9.9, 1.8.10
>
> Attachments: OAK-7709.diff, OAK-7709.diff
>
>
> During a maintenance of our database system the DocumentNodeStore bundle shut 
> down because of a lease timeout. When we restart the bundle, we ran into 
> these exceptions:
> {code}
> 16.08.2018 11:32:44.139 *INFO* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService 
> Configuring persistent cache to only cache nodes under paths [/libs, /apps, 
> /jcr:system/jcr:nodeTypes, /jcr:system/rep:namespaces]
> 16.08.2018 11:32:44.155 *INFO* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache 
> start, url=/opt/aem/repository/sling/_cqa/cache,size=2048,binary=0
> 16.08.2018 11:32:44.156 *WARN* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.MapFactory Error 
> in the background thread of the persistent cache: 
> java.lang.IllegalStateException: The file is locked: 
> nio:/opt/aem/repository/sling/_cqa/cache/cache-0.data [1.4.194/7]
> 16.08.2018 11:32:44.157 *WARN* [Default Executor-thread-20544] 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.MapFactory Could 
> not open the store /opt/aem/repository/sling/_cqa/cache/cache-0.data
> java.lang.IllegalStateException: The file is locked: 
> nio:/opta/aem/repository/sling/_cqa/cache/cache-0.data [1.4.194/7]
> at org.h2.mvstore.DataUtils.newIllegalStateException(DataUtils.java:765)
> at org.h2.mvstore.FileStore.open(FileStore.java:168)
> at org.h2.mvstore.MVStore.(MVStore.java:347)
> at org.h2.mvstore.MVStore$Builder.open(MVStore.java:2930)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache$1.openStore(PersistentCache.java:288)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache.createMapFactory(PersistentCache.java:361)
> at 
> org.apache.jackrabbit.oak.plugins.document.persistentCache.PersistentCache.(PersistentCache.java:210)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.getPersistentCache(DocumentNodeStoreBuilder.java:648)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildCache(DocumentNodeStoreBuilder.java:627)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildDocumentCache(DocumentNodeStoreBuilder.java:586)
> at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.buildNodeDocumentCache(DocumentNodeStoreBuilder.java:594)
> at 
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBDocumentStore.initialize(RDBDocumentStore.java:967)
> {code}
> It seems that the mvstore wasn't shut down properly during the stop of the 
> DocumentNodeStore. For me it seems that the DocumentNodeStore doesn't use the 
> persistent cache anymore until there was a "hard" restart (on the JVM).
> It would be good if even in this situation the shutdown of the 
> DocumentNodeStore could drop the lock on the mvstore, so a clean restart of 
> the bundle is possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Issue Comment Deleted] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7906:

Comment: was deleted

(was: Found . Maybe related?)

> StackOverFlowError 
> SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12
> -
>
> Key: OAK-7906
> URL: https://issues.apache.org/jira/browse/OAK-7906
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Affects Versions: 1.9.11
>Reporter: Julian Reschke
>Priority: Major
>  Labels: Java12
>
> Happens with version 20 (2018/11/15).
> It appears that the StackOverflowError happens when obtaining many sessions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-16 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689537#comment-16689537
 ] 

Julian Reschke commented on OAK-7906:
-

Maybe 
?

> StackOverFlowError 
> SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12
> -
>
> Key: OAK-7906
> URL: https://issues.apache.org/jira/browse/OAK-7906
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Affects Versions: 1.9.11
>Reporter: Julian Reschke
>Priority: Major
>  Labels: Java12
>
> Happens with version 20 (2018/11/15).
> It appears that the StackOverflowError happens when obtaining many sessions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

2018-11-16 Thread Davide Giannella (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689523#comment-16689523
 ] 

Davide Giannella commented on OAK-7182:
---

I'm in favour of reducing our exposure to Guava as much as possible. As it will 
make it easier to deal with breaking upgrade.

Backport speaking we currently have 5 branches. 1.0 and 1.2 we should seriously 
discuss if we want to actively maintain those. Then we have 1.4, 1.6 and 
trunk/1.8.

The question would be. What is the effort of having 1.4 and 1.6 java8 
compatible? I know we have upstream projects to consider but given the support 
policy from Oracle we may have room to negotiate there.

Otherwise wrapping guava's stuff in oak-common may easy any future upgrade.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Paul Chibulcuteanu (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689516#comment-16689516
 ] 

Paul Chibulcuteanu commented on OAK-7907:
-

[~teofili], can you please have a look?  [^OAK-7907_v1.patch] 

> Exporting total query count with Sling Metrics / DropWizard
> ---
>
> Key: OAK-7907
> URL: https://issues.apache.org/jira/browse/OAK-7907
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing, query
>Reporter: Paul Chibulcuteanu
>Assignee: Paul Chibulcuteanu
>Priority: Major
> Attachments: OAK-7907_v1.patch
>
>
> Purpose of this task is to evaluate & create a metric which presents the 
> number of queries run in Oak.
> metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Paul Chibulcuteanu (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Chibulcuteanu updated OAK-7907:

Attachment: OAK-7907_v1.patch

> Exporting total query count with Sling Metrics / DropWizard
> ---
>
> Key: OAK-7907
> URL: https://issues.apache.org/jira/browse/OAK-7907
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing, query
>Reporter: Paul Chibulcuteanu
>Assignee: Paul Chibulcuteanu
>Priority: Major
> Attachments: OAK-7907_v1.patch
>
>
> Purpose of this task is to evaluate & create a metric which presents the 
> number of queries run in Oak.
> metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-16 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689289#comment-16689289
 ] 

Julian Reschke edited comment on OAK-7906 at 11/16/18 2:54 PM:
---

sample stack:

{noformat}
[ERROR] 
testTransientReplaceUUIDSameTree(org.apache.jackrabbit.oak.jcr.xml.ImportTest)  
Time elapsed: 0.435 s  <<< ERROR!
java.lang.StackOverflowError
at 
java.base/java.net.URLStreamHandler.parseURL(URLStreamHandler.java:312)
at java.base/sun.net.www.protocol.file.Handler.parseURL(Handler.java:67)
at java.base/java.net.URL.(URL.java:656)
at java.base/java.net.URL.(URL.java:523)
at 
java.base/jdk.internal.loader.URLClassPath$FileLoader.getResource(URLClassPath.java:1176)
at 
java.base/jdk.internal.loader.URLClassPath$FileLoader.findResource(URLClassPath.java:1165)
at 
java.base/jdk.internal.loader.URLClassPath$1.next(URLClassPath.java:341)
at 
java.base/jdk.internal.loader.URLClassPath$1.hasMoreElements(URLClassPath.java:351)
at 
java.base/jdk.internal.loader.BuiltinClassLoader$1.hasNext(BuiltinClassLoader.java:357)
at 
java.base/jdk.internal.loader.BuiltinClassLoader$1.hasMoreElements(BuiltinClassLoader.java:365)
at java.base/java.lang.CompoundEnumeration.next(ClassLoader.java:3022)
at 
java.base/java.lang.CompoundEnumeration.hasMoreElements(ClassLoader.java:3031)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.nextProviderClass(ServiceLoader.java:1203)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1221)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1265)
at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1300)
at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1385)
at 
java.base/javax.security.auth.login.LoginContext.invoke(LoginContext.java:691)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:665)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:663)
at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:688)
at 
java.base/javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:663)
at 
java.base/javax.security.auth.login.LoginContext.login(LoginContext.java:574)
at 
org.apache.jackrabbit.oak.core.ContentRepositoryImpl.login(ContentRepositoryImpl.java:163)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule$1.run(AbstractLoginModule.java:397)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule$1.run(AbstractLoginModule.java:394)
at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:688)
at java.base/javax.security.auth.Subject.doAs(Subject.java:423)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getRoot(AbstractLoginModule.java:394)
at 
org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.getUserAuthentication(LoginModuleImpl.java:246)
at 
org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.login(LoginModuleImpl.java:125)
at 
java.base/javax.security.auth.login.LoginContext.invoke(LoginContext.java:726)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:665)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:663)
at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:688)
at 
java.base/javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:663)
at 
java.base/javax.security.auth.login.LoginContext.login(LoginContext.java:574)
at 
org.apache.jackrabbit.oak.core.ContentRepositoryImpl.login(ContentRepositoryImpl.java:163)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule$1.run(AbstractLoginModule.java:397)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule$1.run(AbstractLoginModule.java:394)
at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:688)
at java.base/javax.security.auth.Subject.doAs(Subject.java:423)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getRoot(AbstractLoginModule.java:394)
at 
org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.getUserAuthentication(LoginModuleImpl.java:246)
at 
org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.login(LoginModuleImpl.java:125)
at 
java.base/javax.security.auth.login.LoginContext.invoke(LoginContext.java:726)
at

[jira] [Commented] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-16 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689513#comment-16689513
 ] 

Julian Reschke commented on OAK-7906:
-

Found . Maybe related?

> StackOverFlowError 
> SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12
> -
>
> Key: OAK-7906
> URL: https://issues.apache.org/jira/browse/OAK-7906
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Affects Versions: 1.9.11
>Reporter: Julian Reschke
>Priority: Major
>  Labels: Java12
>
> Happens with version 20 (2018/11/15).
> It appears that the StackOverflowError happens when obtaining many sessions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Paul Chibulcuteanu (JIRA) 
Paul Chibulcuteanu created OAK-7907:
---

 Summary: Exporting total query count with Sling Metrics / 
DropWizard
 Key: OAK-7907
 URL: https://issues.apache.org/jira/browse/OAK-7907
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: indexing, query
Reporter: Paul Chibulcuteanu


Purpose of this task is to evaluate & create a metric which presents the number 
of queries run in AEM.

metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Paul Chibulcuteanu (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Chibulcuteanu reassigned OAK-7907:
---

Assignee: Paul Chibulcuteanu

> Exporting total query count with Sling Metrics / DropWizard
> ---
>
> Key: OAK-7907
> URL: https://issues.apache.org/jira/browse/OAK-7907
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing, query
>Reporter: Paul Chibulcuteanu
>Assignee: Paul Chibulcuteanu
>Priority: Major
>
> Purpose of this task is to evaluate & create a metric which presents the 
> number of queries run in Oak.
> metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Paul Chibulcuteanu (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Chibulcuteanu updated OAK-7907:

Description: 
Purpose of this task is to evaluate & create a metric which presents the number 
of queries run in Oak.

metric name: QUERY-COUNT

  was:
Purpose of this task is to evaluate & create a metric which presents the number 
of queries run.

metric name: QUERY-COUNT


> Exporting total query count with Sling Metrics / DropWizard
> ---
>
> Key: OAK-7907
> URL: https://issues.apache.org/jira/browse/OAK-7907
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing, query
>Reporter: Paul Chibulcuteanu
>Priority: Major
>
> Purpose of this task is to evaluate & create a metric which presents the 
> number of queries run in Oak.
> metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7907) Exporting total query count with Sling Metrics / DropWizard

2018-11-16 Thread Paul Chibulcuteanu (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Paul Chibulcuteanu updated OAK-7907:

Description: 
Purpose of this task is to evaluate & create a metric which presents the number 
of queries run.

metric name: QUERY-COUNT

  was:
Purpose of this task is to evaluate & create a metric which presents the number 
of queries run in AEM.

metric name: QUERY-COUNT


> Exporting total query count with Sling Metrics / DropWizard
> ---
>
> Key: OAK-7907
> URL: https://issues.apache.org/jira/browse/OAK-7907
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing, query
>Reporter: Paul Chibulcuteanu
>Priority: Major
>
> Purpose of this task is to evaluate & create a metric which presents the 
> number of queries run.
> metric name: QUERY-COUNT



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7626) Strict lease check mode

2018-11-16 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689429#comment-16689429
 ] 

Julian Reschke commented on OAK-7626:
-

trunk: [r1836101|http://svn.apache.org/r1836101] 
[r1836099|http://svn.apache.org/r1836099]


> Strict lease check mode
> ---
>
> Key: OAK-7626
> URL: https://issues.apache.org/jira/browse/OAK-7626
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
> Fix For: 1.10, 1.9.6
>
>
> Introduce a strict lease check mode. This is a prerequisite for OAK-3883.
> In strict mode, the lease check must not renew the lease when it is 
> considered as expired. The current implementation, which permits a renew even 
> when the lease expired, may still be useful for development when the JVM is 
> in debug mode, but the strict mode should be the new default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7219) Update Logback version to >= 1.2.0, SLF4J accordingly

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7219:

Labels: candidate_oak_1_6  (was: candidate_oak_1_8)

> Update Logback version to >= 1.2.0, SLF4J accordingly
> -
>
> Key: OAK-7219
> URL: https://issues.apache.org/jira/browse/OAK-7219
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>  Labels: candidate_oak_1_6
> Fix For: 1.9.0, 1.10, 1.8.10
>
>
> See https://www.cvedetails.com/cve/CVE-2017-5929/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7219) Update Logback version to >= 1.2.0, SLF4J accordingly

2018-11-16 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689353#comment-16689353
 ] 

Julian Reschke commented on OAK-7219:
-

trunk: [r1822642|http://svn.apache.org/r1822642]
1.8: [r1846709|http://svn.apache.org/r1846709]


> Update Logback version to >= 1.2.0, SLF4J accordingly
> -
>
> Key: OAK-7219
> URL: https://issues.apache.org/jira/browse/OAK-7219
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>  Labels: candidate_oak_1_6
> Fix For: 1.9.0, 1.10, 1.8.10
>
>
> See https://www.cvedetails.com/cve/CVE-2017-5929/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Issue Comment Deleted] (OAK-7219) Update Logback version to >= 1.2.0, SLF4J accordingly

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7219:

Comment: was deleted

(was: trunk: [r1822642|http://svn.apache.org/r1822642]
)

> Update Logback version to >= 1.2.0, SLF4J accordingly
> -
>
> Key: OAK-7219
> URL: https://issues.apache.org/jira/browse/OAK-7219
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>  Labels: candidate_oak_1_6
> Fix For: 1.9.0, 1.10, 1.8.10
>
>
> See https://www.cvedetails.com/cve/CVE-2017-5929/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7219) Update Logback version to >= 1.2.0, SLF4J accordingly

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7219:

Fix Version/s: 1.8.10

> Update Logback version to >= 1.2.0, SLF4J accordingly
> -
>
> Key: OAK-7219
> URL: https://issues.apache.org/jira/browse/OAK-7219
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
>  Labels: candidate_oak_1_6
> Fix For: 1.9.0, 1.10, 1.8.10
>
>
> See https://www.cvedetails.com/cve/CVE-2017-5929/



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7897) Queries with OR simplified to IN shouldn't have alternative UNION query

2018-11-16 Thread Thomas Mueller (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689322#comment-16689322
 ] 

Thomas Mueller commented on OAK-7897:
-

In theory, "UNION" might be faster than "IN" for a few (rare) cases, for 
example:

{noformat}
SELECT [rep:facet(text)] FROM [nt:base] WHERE ([jcr:primaryType] = 'cqDam' OR 
[jcr:primaryType] = 'cqPage')  and ...
{noformat}

I'm not fully sure if there are other cases where UNION might be better.

What I think might be a problem, and I need to test this, is if there are many 
many OR conditions, of the form 

{noformat}
[name]='a' OR [name]='b' OR [name]='c' OR [name]='d' OR ...
{noformat}

Possibly we try out too many variants, so planning might be slow. A workaround 
is to use "IN" in the query directly.

> Queries with OR simplified to IN shouldn't have alternative UNION query
> ---
>
> Key: OAK-7897
> URL: https://issues.apache.org/jira/browse/OAK-7897
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Thomas Mueller
>Priority: Minor
>
> Queries like {noformat} SELECT [rep:facet(text)] FROM [nt:base] WHERE [name] 
> = 'Node1' OR [name] = 'Node2' {noformat} which would get simplified to {{IN}} 
> clause still weigh in cost of alternative query with {{UNION}}. We should 
> avoid that.
> /cc [~tmueller]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (OAK-7897) Queries with OR simplified to IN shouldn't have alternative UNION query

2018-11-16 Thread Thomas Mueller (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller reassigned OAK-7897:
---

Assignee: Thomas Mueller  (was: Vikas Saurabh)

> Queries with OR simplified to IN shouldn't have alternative UNION query
> ---
>
> Key: OAK-7897
> URL: https://issues.apache.org/jira/browse/OAK-7897
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Thomas Mueller
>Priority: Minor
>
> Queries like {noformat} SELECT [rep:facet(text)] FROM [nt:base] WHERE [name] 
> = 'Node1' OR [name] = 'Node2' {noformat} which would get simplified to {{IN}} 
> clause still weigh in cost of alternative query with {{UNION}}. We should 
> avoid that.
> /cc [~tmueller]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7889) Build Jackrabbit Oak #1778 failed

2018-11-16 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689305#comment-16689305
 ] 

Hudson commented on OAK-7889:
-

Build is still failing.
Failed run: [Jackrabbit Oak 
#1794|https://builds.apache.org/job/Jackrabbit%20Oak/1794/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/1794/console]

> Build Jackrabbit Oak #1778 failed
> -
>
> Key: OAK-7889
> URL: https://issues.apache.org/jira/browse/OAK-7889
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #1778 has failed.
> First failed run: [Jackrabbit Oak 
> #1778|https://builds.apache.org/job/Jackrabbit%20Oak/1778/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/1778/console]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

2018-11-16 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689296#comment-16689296
 ] 

Julian Reschke commented on OAK-7182:
-

The downside is that it requires Java 8, so we wouldn't be able to backport.

Maybe stick with Guava, but move it into oak-commons, where there'd be a single 
place to change? (or to use reflection to support old and new Guava?)

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-16 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689289#comment-16689289
 ] 

Julian Reschke commented on OAK-7906:
-

sample stack:

{noformat}
[ERROR] 
testTransientRemoveUUIDSameTree(org.apache.jackrabbit.oak.jcr.xml.ImportTest)  
Time elapsed: 0.27 s  <<< ERROR!
java.lang.StackOverflowError
at 
java.base/java.net.URLStreamHandler.parseURL(URLStreamHandler.java:312)
at java.base/sun.net.www.protocol.file.Handler.parseURL(Handler.java:67)
at java.base/java.net.URL.(URL.java:656)
at java.base/java.net.URL.(URL.java:523)
at 
java.base/jdk.internal.loader.URLClassPath$FileLoader.getResource(URLClassPath.java:1176)
at 
java.base/jdk.internal.loader.URLClassPath$FileLoader.findResource(URLClassPath.java:1165)
at 
java.base/jdk.internal.loader.URLClassPath$1.next(URLClassPath.java:341)
at 
java.base/jdk.internal.loader.URLClassPath$1.hasMoreElements(URLClassPath.java:351)
at 
java.base/jdk.internal.loader.BuiltinClassLoader$1.hasNext(BuiltinClassLoader.java:357)
at 
java.base/jdk.internal.loader.BuiltinClassLoader$1.hasMoreElements(BuiltinClassLoader.java:365)
at java.base/java.lang.CompoundEnumeration.next(ClassLoader.java:3022)
at 
java.base/java.lang.CompoundEnumeration.hasMoreElements(ClassLoader.java:3031)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.nextProviderClass(ServiceLoader.java:1203)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNextService(ServiceLoader.java:1221)
at 
java.base/java.util.ServiceLoader$LazyClassPathLookupIterator.hasNext(ServiceLoader.java:1265)
at java.base/java.util.ServiceLoader$2.hasNext(ServiceLoader.java:1300)
at java.base/java.util.ServiceLoader$3.hasNext(ServiceLoader.java:1385)
at 
java.base/javax.security.auth.login.LoginContext.invoke(LoginContext.java:691)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:665)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:663)
at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:688)
at 
java.base/javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:663)
at 
java.base/javax.security.auth.login.LoginContext.login(LoginContext.java:574)
at 
org.apache.jackrabbit.oak.core.ContentRepositoryImpl.login(ContentRepositoryImpl.java:163)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule$1.run(AbstractLoginModule.java:397)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule$1.run(AbstractLoginModule.java:394)
at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:688)
at java.base/javax.security.auth.Subject.doAs(Subject.java:423)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getRoot(AbstractLoginModule.java:394)
at 
org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.getUserAuthentication(LoginModuleImpl.java:246)
at 
org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.login(LoginModuleImpl.java:125)
at 
java.base/javax.security.auth.login.LoginContext.invoke(LoginContext.java:726)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:665)
at 
java.base/javax.security.auth.login.LoginContext$4.run(LoginContext.java:663)
at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:688)
at 
java.base/javax.security.auth.login.LoginContext.invokePriv(LoginContext.java:663)
at 
java.base/javax.security.auth.login.LoginContext.login(LoginContext.java:574)
at 
org.apache.jackrabbit.oak.core.ContentRepositoryImpl.login(ContentRepositoryImpl.java:163)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule$1.run(AbstractLoginModule.java:397)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule$1.run(AbstractLoginModule.java:394)
at 
java.base/java.security.AccessController.doPrivileged(AccessController.java:688)
at java.base/javax.security.auth.Subject.doAs(Subject.java:423)
at 
org.apache.jackrabbit.oak.spi.security.authentication.AbstractLoginModule.getRoot(AbstractLoginModule.java:394)
at 
org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.getUserAuthentication(LoginModuleImpl.java:246)
at 
org.apache.jackrabbit.oak.security.authentication.user.LoginModuleImpl.login(LoginModuleImpl.java:125)

{noformat}


> StackOverFlowError 
> SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12
>

[jira] [Updated] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7906:

Description: 
Happens with version 20 (2018/11/15).

It appears that the StackOverflowError happens when obtaining many sessions.

  was:
Happens with version 20 (2018/11/15).

It appears that the StackOverflow happens when obtaining many sessions.


> StackOverFlowError 
> SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12
> -
>
> Key: OAK-7906
> URL: https://issues.apache.org/jira/browse/OAK-7906
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Affects Versions: 1.9.11
>Reporter: Julian Reschke
>Priority: Major
>  Labels: Java12
>
> Happens with version 20 (2018/11/15).
> It appears that the StackOverflowError happens when obtaining many sessions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7906:

Description: 
Happens with version 20 (2018/11/15).

It appears that the StackOverflow happens when obtaining many sessions.

  was:
Happens with 20 (2018/11/15).

It appears that the StackOverflow happens when obtaining many sessions.


> StackOverFlowError 
> SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12
> -
>
> Key: OAK-7906
> URL: https://issues.apache.org/jira/browse/OAK-7906
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Affects Versions: 1.9.11
>Reporter: Julian Reschke
>Priority: Major
>  Labels: Java12
>
> Happens with version 20 (2018/11/15).
> It appears that the StackOverflow happens when obtaining many sessions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (OAK-7182) Make it possible to update Guava

2018-11-16 Thread Alex Deparvu (JIRA) 


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689284#comment-16689284
 ] 

Alex Deparvu commented on OAK-7182:
---

In the spirit of replacing guava apis with jdk alternatives I found this idea 
to replace {{MoreObjects.toStringHelper}} with {{StringJoiner}} from jdk8 [0]. 
It seems pretty painful to rewrite all those toString methods but on the upside 
it would greatly reduce the patches for the upgrade. 
I'm curious to see what other think.

[0] 
https://stackoverflow.com/questions/32691387/alternative-to-moreobjects-in-java-8

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (OAK-7906) StackOverFlowError SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12

2018-11-16 Thread Julian Reschke (JIRA) 


 [ 
https://issues.apache.org/jira/browse/OAK-7906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7906:

Description: 
Happens with 20 (2018/11/15).

It appears that the StackOverflow happens when obtaining many sessions.

> StackOverFlowError 
> SessionStatsTest.testInitStackTraceEnabledAfterOpeningManySessions with jdk-12
> -
>
> Key: OAK-7906
> URL: https://issues.apache.org/jira/browse/OAK-7906
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Affects Versions: 1.9.11
>Reporter: Julian Reschke
>Priority: Major
>  Labels: Java12
>
> Happens with 20 (2018/11/15).
> It appears that the StackOverflow happens when obtaining many sessions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)