[jira] [Created] (OAK-8046) Result items are not always correctly counted against the configured read limit if a query uses a lucene index
Georg Henzler created OAK-8046: -- Summary: Result items are not always correctly counted against the configured read limit if a query uses a lucene index Key: OAK-8046 URL: https://issues.apache.org/jira/browse/OAK-8046 Project: Jackrabbit Oak Issue Type: Bug Components: lucene Affects Versions: 1.8.7 Reporter: Georg Henzler There are cases where an index is re-opened during query execution. In that case, already returned entries are read again and skipped, so basically counted twice. This should be fixed to only count entries once (see also [1]) The issue most likely exists since the read limit was introduced with OAK-6875 [1] https://lists.apache.org/thread.html/dddf9834fee0bccb6e48f61ba2a01430e34fc0b464b12809f7dfe2eb@%3Coak-dev.jackrabbit.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8014) Commits carrying over from previous GC generation can block other threads from committing
[
https://issues.apache.org/jira/browse/OAK-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767340#comment-16767340
]
Michael Dürig commented on OAK-8014:
Followed up on the last two bullet points above. [~ahanikel] I think this is
now complete. Please help me with reviewing.
> Commits carrying over from previous GC generation can block other threads
> from committing
> -
>
> Key: OAK-8014
> URL: https://issues.apache.org/jira/browse/OAK-8014
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.10.0, 1.8.11
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Blocker
> Labels: TarMK
> Fix For: 1.12, 1.11.0, 1.8.12
>
> Attachments: OAK-8014.patch
>
>
> A commit that is based on a previous (full) generation can block other
> commits from progressing for a long time. This happens because such a commit
> will do a deep copy of its state to avoid linking to old segments (see
> OAK-3348). Most of the deep copying is usually avoided by the deduplication
> caches. However, in cases where the cache hit rate is not good enough we have
> seen deep copy operations up to several minutes. Sometimes this deep copy
> operation happens inside the commit lock of
> {{LockBasedScheduler.schedule()}}, which then causes all other commits to
> become blocked.
> cc [~rma61...@adobe.com], [~edivad]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8045) Allow for ranking being specified with UserAuthentionFactory implementations
[
https://issues.apache.org/jira/browse/OAK-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767321#comment-16767321
]
Alex Deparvu commented on OAK-8045:
---
bq. we intentionally added the ability to have multiple
UserAuthenticationFactory implementations. but we might use a more generic
issue and review for all parts of the security setup if we should add the
ability to specify a ranking.
right, then this instance is a good one to fix via this issue, and we could
create followup issues for other components, as needed
> Allow for ranking being specified with UserAuthentionFactory implementations
>
>
> Key: OAK-8045
> URL: https://issues.apache.org/jira/browse/OAK-8045
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security-spi
>Reporter: angela
>Priority: Major
>
> Currently the {{SecurityProviderRegistration}} lists
> {{UserAuthenticationFactory}} implementions according to the order they are
> bound. While other parts of the security setup (e.g.
> AuthorizationConfiguration) allow for an explicit ranking to be specified
> this option is missing with {{UserAuthenticationFactory}} as reported in the
> following thread on jackrabbit-users:
> https://markmail.org/message/hieqxfdvsadi3lyr
> [~stillalex], wdyt?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OAK-7894) RDBDocumentStore: add perf logging for JDBC read operations
[ https://issues.apache.org/jira/browse/OAK-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683908#comment-16683908 ] Julian Reschke edited comment on OAK-7894 at 2/13/19 3:21 PM: -- trunk: [r1846429|http://svn.apache.org/r1846429] 1.8: [r1853514|http://svn.apache.org/r1853514] was (Author: reschke): trunk: [r1846429|http://svn.apache.org/r1846429] > RDBDocumentStore: add perf logging for JDBC read operations > --- > > Key: OAK-7894 > URL: https://issues.apache.org/jira/browse/OAK-7894 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.10.0, 1.9.12, 1.8.12 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7894) RDBDocumentStore: add perf logging for JDBC read operations
[ https://issues.apache.org/jira/browse/OAK-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7894: Labels: candidate_oak_1_6 (was: candidate_oak_1_8) > RDBDocumentStore: add perf logging for JDBC read operations > --- > > Key: OAK-7894 > URL: https://issues.apache.org/jira/browse/OAK-7894 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.10.0, 1.9.12, 1.8.12 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-7894) RDBDocumentStore: add perf logging for JDBC read operations
[ https://issues.apache.org/jira/browse/OAK-7894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-7894: Fix Version/s: 1.8.12 > RDBDocumentStore: add perf logging for JDBC read operations > --- > > Key: OAK-7894 > URL: https://issues.apache.org/jira/browse/OAK-7894 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.10.0, 1.9.12, 1.8.12 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8014) Commits carrying over from previous GC generation can block other threads from committing
[
https://issues.apache.org/jira/browse/OAK-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767256#comment-16767256
]
Michael Dürig commented on OAK-8014:
In the meanwhile I refactored more bits:
* Encapsulated the direct usage of the semaphore in the {{LockAdapter}}
* Encapsulated the semaphore itself in the {{LockAdapter}}
* Renamed {{LockAdapter}} to {{WeaCommitkLock}}
* Implemented a {{StrictCommitLock}} exposing the same behaviour that we had
so far by only using the semaphore.
* Extracted the common interface ({{CommitLock}}) and added a feature flag in
{{LockBasedScheduler}} for choosing between {{WeakCommitLock}} and
{{StrictCommitLock}}.
Still missing:
* Unit tests for {{StrictCommitLock}}
* A few bits of Javadoc here and there
> Commits carrying over from previous GC generation can block other threads
> from committing
> -
>
> Key: OAK-8014
> URL: https://issues.apache.org/jira/browse/OAK-8014
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
>Affects Versions: 1.10.0, 1.8.11
>Reporter: Michael Dürig
>Assignee: Michael Dürig
>Priority: Blocker
> Labels: TarMK
> Fix For: 1.12, 1.11.0, 1.8.12
>
> Attachments: OAK-8014.patch
>
>
> A commit that is based on a previous (full) generation can block other
> commits from progressing for a long time. This happens because such a commit
> will do a deep copy of its state to avoid linking to old segments (see
> OAK-3348). Most of the deep copying is usually avoided by the deduplication
> caches. However, in cases where the cache hit rate is not good enough we have
> seen deep copy operations up to several minutes. Sometimes this deep copy
> operation happens inside the commit lock of
> {{LockBasedScheduler.schedule()}}, which then causes all other commits to
> become blocked.
> cc [~rma61...@adobe.com], [~edivad]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-7892) LogCustomizer should support slf4j log levels
[
https://issues.apache.org/jira/browse/OAK-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767194#comment-16767194
]
Julian Reschke commented on OAK-7892:
-
trunk: [r1846396|http://svn.apache.org/r1846396]
1.8: [r1853503|http://svn.apache.org/r1853503]
> LogCustomizer should support slf4j log levels
> -
>
> Key: OAK-7892
> URL: https://issues.apache.org/jira/browse/OAK-7892
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: commons
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_6
> Fix For: 1.10.0, 1.9.11, 1.8.12
>
>
> It's unfortunate that in tests using {{LogCustomizer}}, we need to use
> logback constants, although the rest of the system uses log4f.
> So, in {{LogCustomizerBuilder}}, support SLF4J log levels as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7892) LogCustomizer should support slf4j log levels
[
https://issues.apache.org/jira/browse/OAK-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7892:
Labels: candidate_oak_1_6 (was: candidate_oak_1_8)
> LogCustomizer should support slf4j log levels
> -
>
> Key: OAK-7892
> URL: https://issues.apache.org/jira/browse/OAK-7892
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: commons
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_6
> Fix For: 1.10.0, 1.9.11, 1.8.12
>
>
> It's unfortunate that in tests using {{LogCustomizer}}, we need to use
> logback constants, although the rest of the system uses log4f.
> So, in {{LogCustomizerBuilder}}, support SLF4J log levels as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OAK-7892) LogCustomizer should support slf4j log levels
[
https://issues.apache.org/jira/browse/OAK-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7892:
Fix Version/s: 1.8.12
> LogCustomizer should support slf4j log levels
> -
>
> Key: OAK-7892
> URL: https://issues.apache.org/jira/browse/OAK-7892
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: commons
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_8
> Fix For: 1.10.0, 1.9.11, 1.8.12
>
>
> It's unfortunate that in tests using {{LogCustomizer}}, we need to use
> logback constants, although the rest of the system uses log4f.
> So, in {{LogCustomizerBuilder}}, support SLF4J log levels as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Issue Comment Deleted] (OAK-7892) LogCustomizer should support slf4j log levels
[
https://issues.apache.org/jira/browse/OAK-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7892:
Comment: was deleted
(was: trunk: [r1846396|http://svn.apache.org/r1846396])
> LogCustomizer should support slf4j log levels
> -
>
> Key: OAK-7892
> URL: https://issues.apache.org/jira/browse/OAK-7892
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: commons
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_6
> Fix For: 1.10.0, 1.9.11, 1.8.12
>
>
> It's unfortunate that in tests using {{LogCustomizer}}, we need to use
> logback constants, although the rest of the system uses log4f.
> So, in {{LogCustomizerBuilder}}, support SLF4J log levels as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8045) Allow for ranking being specified with UserAuthentionFactory implementations
[
https://issues.apache.org/jira/browse/OAK-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767139#comment-16767139
]
angela commented on OAK-8045:
-
[~stillalex], if i remember correctly we intentionally added the ability to
have multiple {{UserAuthenticationFactory}} implementations. but we might use a
more generic issue and review for all parts of the security setup if we should
add the ability to specify a ranking.
> Allow for ranking being specified with UserAuthentionFactory implementations
>
>
> Key: OAK-8045
> URL: https://issues.apache.org/jira/browse/OAK-8045
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security-spi
>Reporter: angela
>Priority: Major
>
> Currently the {{SecurityProviderRegistration}} lists
> {{UserAuthenticationFactory}} implementions according to the order they are
> bound. While other parts of the security setup (e.g.
> AuthorizationConfiguration) allow for an explicit ranking to be specified
> this option is missing with {{UserAuthenticationFactory}} as reported in the
> following thread on jackrabbit-users:
> https://markmail.org/message/hieqxfdvsadi3lyr
> [~stillalex], wdyt?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (OAK-8004) oak-run: support "recovery" command for RDBDocumentStore
[ https://issues.apache.org/jira/browse/OAK-8004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752223#comment-16752223 ] Julian Reschke edited comment on OAK-8004 at 2/13/19 11:24 AM: --- trunk: [r1852120|http://svn.apache.org/r1852120] 1.10: [r1853487|http://svn.apache.org/r1853487] 1.8: [r1853490|http://svn.apache.org/r1853490] was (Author: reschke): trunk: [r1852120|http://svn.apache.org/r1852120] 1.10: [r1853487|http://svn.apache.org/r1853487] > oak-run: support "recovery" command for RDBDocumentStore > > > Key: OAK-8004 > URL: https://issues.apache.org/jira/browse/OAK-8004 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk, run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.12, 1.11.0, 1.10.1, 1.8.12 > > Attachments: OAK-8004.diff > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8004) oak-run: support "recovery" command for RDBDocumentStore
[ https://issues.apache.org/jira/browse/OAK-8004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8004: Labels: candidate_oak_1_6 (was: candidate_oak_1_8) > oak-run: support "recovery" command for RDBDocumentStore > > > Key: OAK-8004 > URL: https://issues.apache.org/jira/browse/OAK-8004 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk, run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.12, 1.11.0, 1.10.1, 1.8.12 > > Attachments: OAK-8004.diff > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8004) oak-run: support "recovery" command for RDBDocumentStore
[ https://issues.apache.org/jira/browse/OAK-8004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8004: Fix Version/s: 1.8.12 > oak-run: support "recovery" command for RDBDocumentStore > > > Key: OAK-8004 > URL: https://issues.apache.org/jira/browse/OAK-8004 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk, run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.12, 1.11.0, 1.10.1, 1.8.12 > > Attachments: OAK-8004.diff > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8004) oak-run: support "recovery" command for RDBDocumentStore
[ https://issues.apache.org/jira/browse/OAK-8004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752223#comment-16752223 ] Julian Reschke edited comment on OAK-8004 at 2/13/19 10:50 AM: --- trunk: [r1852120|http://svn.apache.org/r1852120] 1.10: [r1853487|http://svn.apache.org/r1853487] was (Author: reschke): trunk: [r1852120|http://svn.apache.org/r1852120] > oak-run: support "recovery" command for RDBDocumentStore > > > Key: OAK-8004 > URL: https://issues.apache.org/jira/browse/OAK-8004 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk, run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.12, 1.11.0, 1.10.1 > > Attachments: OAK-8004.diff > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8004) oak-run: support "recovery" command for RDBDocumentStore
[ https://issues.apache.org/jira/browse/OAK-8004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8004: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > oak-run: support "recovery" command for RDBDocumentStore > > > Key: OAK-8004 > URL: https://issues.apache.org/jira/browse/OAK-8004 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk, run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.12, 1.11.0, 1.10.1 > > Attachments: OAK-8004.diff > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8004) oak-run: support "recovery" command for RDBDocumentStore
[ https://issues.apache.org/jira/browse/OAK-8004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8004: Fix Version/s: 1.10.1 > oak-run: support "recovery" command for RDBDocumentStore > > > Key: OAK-8004 > URL: https://issues.apache.org/jira/browse/OAK-8004 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk, run >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.12, 1.11.0, 1.10.1 > > Attachments: OAK-8004.diff > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767017#comment-16767017 ] Alex Deparvu commented on OAK-7182: --- bq. or to use reflection to support old and new Guava? I went ahead and added a prototype of this based on the latest patch [0], just to see how crazy it would look. I ended up with 2 classes wrapping the guava apis. The executor stuff is still ok [1], but the toStringHelper is pretty weird [2], we have to remap the entire api footprint, it would be easier to rewrite it (or just copy the code over). I hope this gets the discussion moving again, I would love to see this resolved in some way. [0] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:x-guava-test [1] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:x-guava-test#diff-f1efb305e741d16201cdc8de18d22569 [2] https://github.com/apache/jackrabbit-oak/compare/trunk...stillalex:x-guava-test#diff-fd33259bcb6c3e9c1afd3ab17aca2f1d > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, > OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, > guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8035) Debug logging when two or more indices have same or very close cost amounts doesn't work in case both indices belong to the same type of Query Index
[ https://issues.apache.org/jira/browse/OAK-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767015#comment-16767015 ] Nitin Gupta edited comment on OAK-8035 at 2/13/19 10:09 AM: [~tmueller] - yup - I don't have commit rights . This is actually my first contribution here. So I will be glad if you or [~teofili] can commit for me . Thanks a lot for the help . was (Author: nitigup): [~tmueller] - yup - I don't have commit rights . This is actually my first contribution here. So - yeah you or [~teofili] can commit for me . Thanks a lot for the help . > Debug logging when two or more indices have same or very close cost amounts > doesn't work in case both indices belong to the same type of Query Index > > > Key: OAK-8035 > URL: https://issues.apache.org/jira/browse/OAK-8035 > Project: Jackrabbit Oak > Issue Type: Bug > Components: query >Reporter: Nitin Gupta >Assignee: Nitin Gupta >Priority: Major > Attachments: OAK-8035.patch, OAK-8035_2.patch > > > Steps to reproduce - > # You would need two index definitions of same query index type , let's say > fullText index , having similar cost evaluations. > # Now while the index plan is evaluated you will notice that there should > have been a debug log saying that selected index has similar cost - this > serves as an important warning to either change the index definitions or the > query > ([https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1069#L1072)] > > However If we have a look at this code block here - > [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1017#L1041] > , there is no comparison for near best costs for index plans having same > query index type . > > cc : [~teofili] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8035) Debug logging when two or more indices have same or very close cost amounts doesn't work in case both indices belong to the same type of Query Index
[ https://issues.apache.org/jira/browse/OAK-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767015#comment-16767015 ] Nitin Gupta commented on OAK-8035: -- [~tmueller] - yup - I don't have commit rights . This is actually my first contribution here. So - yeah you or [~teofili] can commit for me . Thanks a lot for the help . > Debug logging when two or more indices have same or very close cost amounts > doesn't work in case both indices belong to the same type of Query Index > > > Key: OAK-8035 > URL: https://issues.apache.org/jira/browse/OAK-8035 > Project: Jackrabbit Oak > Issue Type: Bug > Components: query >Reporter: Nitin Gupta >Assignee: Nitin Gupta >Priority: Major > Attachments: OAK-8035.patch, OAK-8035_2.patch > > > Steps to reproduce - > # You would need two index definitions of same query index type , let's say > fullText index , having similar cost evaluations. > # Now while the index plan is evaluated you will notice that there should > have been a debug log saying that selected index has similar cost - this > serves as an important warning to either change the index definitions or the > query > ([https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1069#L1072)] > > However If we have a look at this code block here - > [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1017#L1041] > , there is no comparison for near best costs for index plans having same > query index type . > > cc : [~teofili] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OAK-8045) Allow for ranking being specified with UserAuthentionFactory implementations
[
https://issues.apache.org/jira/browse/OAK-8045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767012#comment-16767012
]
Alex Deparvu commented on OAK-8045:
---
sounds good to me.
Alternatively we could work on OAK-7419 as a more generic solution. I'm not
sure if the usecase is to support having 2 (or more)
_UserAuthenticationFactory_ services or to just only have the one you need
active.
> Allow for ranking being specified with UserAuthentionFactory implementations
>
>
> Key: OAK-8045
> URL: https://issues.apache.org/jira/browse/OAK-8045
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security-spi
>Reporter: angela
>Priority: Major
>
> Currently the {{SecurityProviderRegistration}} lists
> {{UserAuthenticationFactory}} implementions according to the order they are
> bound. While other parts of the security setup (e.g.
> AuthorizationConfiguration) allow for an explicit ranking to be specified
> this option is missing with {{UserAuthenticationFactory}} as reported in the
> following thread on jackrabbit-users:
> https://markmail.org/message/hieqxfdvsadi3lyr
> [~stillalex], wdyt?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OAK-8035) Debug logging when two or more indices have same or very close cost amounts doesn't work in case both indices belong to the same type of Query Index
[ https://issues.apache.org/jira/browse/OAK-8035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766971#comment-16766971 ] Thomas Mueller commented on OAK-8035: - The patch looks good to me. [~nitigup] you don't have commit rights? I or [~teofili] can commit it if you like. > Debug logging when two or more indices have same or very close cost amounts > doesn't work in case both indices belong to the same type of Query Index > > > Key: OAK-8035 > URL: https://issues.apache.org/jira/browse/OAK-8035 > Project: Jackrabbit Oak > Issue Type: Bug > Components: query >Reporter: Nitin Gupta >Assignee: Nitin Gupta >Priority: Major > Attachments: OAK-8035.patch, OAK-8035_2.patch > > > Steps to reproduce - > # You would need two index definitions of same query index type , let's say > fullText index , having similar cost evaluations. > # Now while the index plan is evaluated you will notice that there should > have been a debug log saying that selected index has similar cost - this > serves as an important warning to either change the index definitions or the > query > ([https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1069#L1072)] > > However If we have a look at this code block here - > [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/query/QueryImpl.java#L1017#L1041] > , there is no comparison for near best costs for index plans having same > query index type . > > cc : [~teofili] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OAK-8043) RDB: expose DDL generation functionality in oak-run
[ https://issues.apache.org/jira/browse/OAK-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766030#comment-16766030 ] Julian Reschke edited comment on OAK-8043 at 2/13/19 8:50 AM: -- trunk: [r1853433|http://svn.apache.org/r1853433] 1.10: [r1853457|http://svn.apache.org/r1853457] 1.8: [r1853477|http://svn.apache.org/r1853477] was (Author: reschke): trunk: [r1853433|http://svn.apache.org/r1853433] > RDB: expose DDL generation functionality in oak-run > --- > > Key: OAK-8043 > URL: https://issues.apache.org/jira/browse/OAK-8043 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: oak-run, rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.12, 1.11.0, 1.10.1, 1.8.12 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8043) RDB: expose DDL generation functionality in oak-run
[ https://issues.apache.org/jira/browse/OAK-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8043: Fix Version/s: 1.8.12 > RDB: expose DDL generation functionality in oak-run > --- > > Key: OAK-8043 > URL: https://issues.apache.org/jira/browse/OAK-8043 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: oak-run, rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.12, 1.11.0, 1.10.1, 1.8.12 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OAK-8043) RDB: expose DDL generation functionality in oak-run
[ https://issues.apache.org/jira/browse/OAK-8043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8043: Labels: candidate_oak_1_6 (was: candidate_oak_1_10) > RDB: expose DDL generation functionality in oak-run > --- > > Key: OAK-8043 > URL: https://issues.apache.org/jira/browse/OAK-8043 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: oak-run, rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_6 > Fix For: 1.12, 1.11.0, 1.10.1, 1.8.12 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OAK-8045) Allow for ranking being specified with UserAuthentionFactory implementations
angela created OAK-8045:
---
Summary: Allow for ranking being specified with
UserAuthentionFactory implementations
Key: OAK-8045
URL: https://issues.apache.org/jira/browse/OAK-8045
Project: Jackrabbit Oak
Issue Type: Improvement
Components: core, security-spi
Reporter: angela
Currently the {{SecurityProviderRegistration}} lists
{{UserAuthenticationFactory}} implementions according to the order they are
bound. While other parts of the security setup (e.g.
AuthorizationConfiguration) allow for an explicit ranking to be specified this
option is missing with {{UserAuthenticationFactory}} as reported in the
following thread on jackrabbit-users:
https://markmail.org/message/hieqxfdvsadi3lyr
[~stillalex], wdyt?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
