[jira] [Commented] (OAK-8244) Build failure: ThreadLeakError

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941506#comment-16941506
 ] 

Julian Reschke commented on OAK-8244:
-

{noformat}
@RunWith(com.carrotsearch.randomizedtesting.RandomizedRunner.class) {noformat}

was added as part of the change for Solr 6.* (see OAK-8235). [~teofili] - 
remember details why this was added here?

> Build failure: ThreadLeakError
> --
>
> Key: OAK-8244
> URL: https://issues.apache.org/jira/browse/OAK-8244
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration, solr
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2091 has failed.
> First failed run: [Jackrabbit Oak 
> #2091|https://builds.apache.org/job/Jackrabbit%20Oak/2091/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2091/console]
> {noformat}
> [ERROR] Tests run: 13, Failures: 0, Errors: 2, Skipped: 2, Time elapsed: 
> 3.402 s <<< FAILURE! - in 
> org.apache.jackrabbit.oak.plugins.index.solr.configuration.DefaultAnalyzersConfigurationTest
> [ERROR] 
> org.apache.jackrabbit.oak.plugins.index.solr.configuration.DefaultAnalyzersConfigurationTest
>   Time elapsed: 3.08 s  <<< ERROR!
> com.carrotsearch.randomizedtesting.ThreadLeakError: 
> 1 thread leaked from SUITE scope at 
> org.apache.jackrabbit.oak.plugins.index.solr.configuration.DefaultAnalyzersConfigurationTest:
>  
>1) Thread[id=143, name=oak-scheduled-executor-61, state=TIMED_WAITING, 
> group=main]
> at sun.misc.Unsafe.park(Native Method)
> at 
> java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
> at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.awaitNanos(AbstractQueuedSynchronizer.java:2078)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.poll(ScheduledThreadPoolExecutor.java:1129)
> at 
> java.util.concurrent.ScheduledThreadPoolExecutor$DelayedWorkQueue.poll(ScheduledThreadPoolExecutor.java:809)
> at 
> java.util.concurrent.ThreadPoolExecutor.getTask(ThreadPoolExecutor.java:1073)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1134)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
>   at __randomizedtesting.SeedInfo.seed([7416B4EE1CED31C6]:0)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8570) RDB*Store: update mssql-jdbc driver reference to 7.4.1.jre8

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912620#comment-16912620
 ] 

Julian Reschke edited comment on OAK-8570 at 10/1/19 3:34 AM:
--

trunk: (1.18.0) [r1865654|http://svn.apache.org/r1865654]
1.10: [r1867820|http://svn.apache.org/r1867820]



was (Author: reschke):
trunk: [r1865654|http://svn.apache.org/r1865654]


> RDB*Store: update mssql-jdbc driver reference to 7.4.1.jre8
> ---
>
> Key: OAK-8570
> URL: https://issues.apache.org/jira/browse/OAK-8570
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8570) RDB*Store: update mssql-jdbc driver reference to 7.4.1.jre8

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8570:

Fix Version/s: 1.10.6

> RDB*Store: update mssql-jdbc driver reference to 7.4.1.jre8
> ---
>
> Key: OAK-8570
> URL: https://issues.apache.org/jira/browse/OAK-8570
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8570) RDB*Store: update mssql-jdbc driver reference to 7.4.1.jre8

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8570:

Labels: candidate_oak_1_8  (was: )

> RDB*Store: update mssql-jdbc driver reference to 7.4.1.jre8
> ---
>
> Key: OAK-8570
> URL: https://issues.apache.org/jira/browse/OAK-8570
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8570) RDB*Store: update mssql-jdbc driver reference to 7.4.1.jre8

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8570:

Labels:   (was: candidate_oak_1_10)

> RDB*Store: update mssql-jdbc driver reference to 7.4.1.jre8
> ---
>
> Key: OAK-8570
> URL: https://issues.apache.org/jira/browse/OAK-8570
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8658) Build Jackrabbit Oak #2414 failed

2019-09-30 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941328#comment-16941328
 ] 

Hudson commented on OAK-8658:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#2415|https://builds.apache.org/job/Jackrabbit%20Oak/2415/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2415/console]

> Build Jackrabbit Oak #2414 failed
> -
>
> Key: OAK-8658
> URL: https://issues.apache.org/jira/browse/OAK-8658
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2414 has failed.
> First failed run: [Jackrabbit Oak 
> #2414|https://builds.apache.org/job/Jackrabbit%20Oak/2414/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2414/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8653) bump up logging for deprecated security APIs to INFO

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941246#comment-16941246
 ] 

Julian Reschke commented on OAK-8653:
-

trunk: [r1867793|http://svn.apache.org/r1867793]

> bump up logging for deprecated security APIs to INFO
> 
>
> Key: OAK-8653
> URL: https://issues.apache.org/jira/browse/OAK-8653
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: security
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-8653) bump up logging for deprecated security APIs to INFO

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved OAK-8653.
-
Resolution: Fixed

> bump up logging for deprecated security APIs to INFO
> 
>
> Key: OAK-8653
> URL: https://issues.apache.org/jira/browse/OAK-8653
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: security
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8568) RDB*Store: update mysql jdbc driver reference to 8.0.17

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8568:

Labels: candidate_oak_1_8  (was: candidate_oak_1_10)

> RDB*Store: update mysql jdbc driver reference to 8.0.17
> ---
>
> Key: OAK-8568
> URL: https://issues.apache.org/jira/browse/OAK-8568
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.18.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8568) RDB*Store: update mysql jdbc driver reference to 8.0.17

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912379#comment-16912379
 ] 

Julian Reschke edited comment on OAK-8568 at 9/30/19 5:20 PM:
--

trunk: (1.18.0) [r1865631|http://svn.apache.org/r1865631]
1.10: [r1867787|http://svn.apache.org/r1867787]


was (Author: reschke):
trunk: [r1865631|http://svn.apache.org/r1865631]

> RDB*Store: update mysql jdbc driver reference to 8.0.17
> ---
>
> Key: OAK-8568
> URL: https://issues.apache.org/jira/browse/OAK-8568
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8658) Build Jackrabbit Oak #2414 failed

2019-09-30 Thread Hudson (Jira)
Hudson created OAK-8658:
---

 Summary: Build Jackrabbit Oak #2414 failed
 Key: OAK-8658
 URL: https://issues.apache.org/jira/browse/OAK-8658
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: continuous integration
Reporter: Hudson


No description is provided

The build Jackrabbit Oak #2414 has failed.
First failed run: [Jackrabbit Oak 
#2414|https://builds.apache.org/job/Jackrabbit%20Oak/2414/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2414/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-7182) Make it possible to update Guava

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941017#comment-16941017
 ] 

Julian Reschke commented on OAK-7182:
-

FWIW, I just realized that the baseline plugin can be used for checking. For 
instance:

{noformat}
fgrep -B7 google */target/baseline.xml
{noformat}
yields:
{noformat}
oak-commons/target/baseline.xml-  
oak-commons/target/baseline.xml-false
oak-commons/target/baseline.xml-1.5.0
oak-commons/target/baseline.xml-1.5.0
oak-commons/target/baseline.xml-1.5.0
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml-  1.5.0
oak-commons/target/baseline.xml:  
com.google.common.base,com.google.common.collect,org.apache.commons.io,org.slf4j
--
oak-commons/target/baseline.xml-  
oak-commons/target/baseline.xml-false
oak-commons/target/baseline.xml-1.0.0
oak-commons/target/baseline.xml-1.0.0
oak-commons/target/baseline.xml-1.0.0
oak-commons/target/baseline.xml-
oak-commons/target/baseline.xml-  1.0.0
oak-commons/target/baseline.xml:  com.google.common.io
--
oak-core-spi/target/baseline.xml-  
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-1.1.0
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-  1.1.0
oak-core-spi/target/baseline.xml:  
com.google.common.cache,com.google.common.collect,org.apache.jackrabbit.oak.api.jmx,org.apache.jackrabbit.oak.commons.jmx
--
oak-core-spi/target/baseline.xml-  
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-  1.0.1
oak-core-spi/target/baseline.xml:  
com.google.common.base,javax.management,javax.management.openmbean,org.apache.jackrabbit.oak.api.jmx
--
oak-core-spi/target/baseline.xml-  
oak-core-spi/target/baseline.xml-false
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-1.0.1
oak-core-spi/target/baseline.xml-
oak-core-spi/target/baseline.xml-  1.0.1
oak-core-spi/target/baseline.xml:  com.google.common.base
--
oak-security-spi/target/baseline.xml-  
oak-security-spi/target/baseline.xml-false
oak-security-spi/target/baseline.xml-2.1.1
oak-security-spi/target/baseline.xml-2.1.1
oak-security-spi/target/baseline.xml-
2.1.1
oak-security-spi/target/baseline.xml-
oak-security-spi/target/baseline.xml-  2.1.1
oak-security-spi/target/baseline.xml:  
com.google.common.collect,javax.jcr
{noformat}

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8657) SimpleCredentialsSupport uses Gauava API in exported API

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8657:

Fix Version/s: 1.24.0

> SimpleCredentialsSupport uses Gauava API in exported API
> 
>
> Key: OAK-8657
> URL: https://issues.apache.org/jira/browse/OAK-8657
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: security-spi
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.24.0
>
>
> {noformat}
> @Override
> @NotNull
> public ImmutableSet getCredentialClasses() {
> return ImmutableSet.of(SimpleCredentials.class);
> }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface). 
> However, this would be an incompatible API change; we could do that in sync 
> with OAK-7358.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8657) SimpleCredentialsSupport uses Gauava API in exported API

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940968#comment-16940968
 ] 

Julian Reschke commented on OAK-8657:
-

[~angela]: feedback appreciated...

> SimpleCredentialsSupport uses Gauava API in exported API
> 
>
> Key: OAK-8657
> URL: https://issues.apache.org/jira/browse/OAK-8657
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: security-spi
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.24.0
>
>
> {noformat}
> @Override
> @NotNull
> public ImmutableSet getCredentialClasses() {
> return ImmutableSet.of(SimpleCredentials.class);
> }
> {noformat}
> We should fix this to use a regular `Set` (as in the implemented interface). 
> However, this would be an incompatible API change; we could do that in sync 
> with OAK-7358.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8657) SimpleCredentialsSupport uses Gauava API in exported API

2019-09-30 Thread Julian Reschke (Jira)
Julian Reschke created OAK-8657:
---

 Summary: SimpleCredentialsSupport uses Gauava API in exported API
 Key: OAK-8657
 URL: https://issues.apache.org/jira/browse/OAK-8657
 Project: Jackrabbit Oak
  Issue Type: Task
  Components: security-spi
Reporter: Julian Reschke
Assignee: Julian Reschke


{noformat}
@Override
@NotNull
public ImmutableSet getCredentialClasses() {
return ImmutableSet.of(SimpleCredentials.class);
}
{noformat}

We should fix this to use a regular `Set` (as in the implemented interface). 
However, this would be an incompatible API change; we could do that in sync 
with OAK-7358.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8567) update tomcat-jdbc dependency to 8.5.43

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912330#comment-16912330
 ] 

Julian Reschke edited comment on OAK-8567 at 9/30/19 1:48 PM:
--

trunk: (1.18.0) [r1865630|http://svn.apache.org/r1865630]
1.10: [r1867774|http://svn.apache.org/r1867774]


was (Author: reschke):
trunk: [r1865630|http://svn.apache.org/r1865630]

> update tomcat-jdbc dependency to 8.5.43
> ---
>
> Key: OAK-8567
> URL: https://issues.apache.org/jira/browse/OAK-8567
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8567) update tomcat-jdbc dependency to 8.5.43

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8567:

Fix Version/s: 1.10.6

> update tomcat-jdbc dependency to 8.5.43
> ---
>
> Key: OAK-8567
> URL: https://issues.apache.org/jira/browse/OAK-8567
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8567) update tomcat-jdbc dependency to 8.5.43

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8567:

Labels: candidate_oak_1_8  (was: candidate_oak_1_10)

> update tomcat-jdbc dependency to 8.5.43
> ---
>
> Key: OAK-8567
> URL: https://issues.apache.org/jira/browse/OAK-8567
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-8656) ListenerStatsData.toCompositeData() throws NPE

2019-09-30 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved OAK-8656.
---
Fix Version/s: 1.20.0
   Resolution: Fixed

Applied to trunk: http://svn.apache.org/r1867773

Thanks again for your contribution.

> ListenerStatsData.toCompositeData() throws NPE
> --
>
> Key: OAK-8656
> URL: https://issues.apache.org/jira/browse/OAK-8656
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: Marcel Reutegger
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: 
> Granite-26986-npe-ListenerStatsData-toCompositeData.patch, OAK-8656.patch
>
>
> Seen recently in an oak-sprout build.
> {noformat}
> 20.08.2019 17:06:17.206 *WARN* 
> [sling-default-3-health-com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck]
>  com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck 
> Exception while getting mBean property: ListenerStats
> javax.management.RuntimeMBeanException: java.lang.NullPointerException
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:829)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:842)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:645)
>   at 
> java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:678)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.getTabularData(ObservationQueueLengthHealthCheck.java:250)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.checkEventListenerStats(ObservationQueueLengthHealthCheck.java:110)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.execute(ObservationQueueLengthHealthCheck.java:83)
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.execute(QueryHealthCheckMetrics.java:257)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.lambda$new$0(QueryHealthCheckMetrics.java:244)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.2]
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.2]
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.NullPointerException: null
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl$ListenerStatsData.toCompositeData(ConsolidatedListenerMBeanImpl.java:423)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl.getListenerStats(ConsolidatedListenerMBeanImpl.java:119)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
>   at jdk.internal.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at java.base/sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:260)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
>   at 
> java.management/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
>   at 
> java.management/com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:83)
>   at 
> java.management/com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:206)
>   at 
> 

[jira] [Commented] (OAK-8656) ListenerStatsData.toCompositeData() throws NPE

2019-09-30 Thread Marcel Reutegger (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940956#comment-16940956
 ] 

Marcel Reutegger commented on OAK-8656:
---

Thanks for the patch. I slightly simplified the boolean expressions in 
{{toCompositeData()}}. See attached [^OAK-8656.patch].

> ListenerStatsData.toCompositeData() throws NPE
> --
>
> Key: OAK-8656
> URL: https://issues.apache.org/jira/browse/OAK-8656
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: Marcel Reutegger
>Priority: Major
> Attachments: 
> Granite-26986-npe-ListenerStatsData-toCompositeData.patch, OAK-8656.patch
>
>
> Seen recently in an oak-sprout build.
> {noformat}
> 20.08.2019 17:06:17.206 *WARN* 
> [sling-default-3-health-com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck]
>  com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck 
> Exception while getting mBean property: ListenerStats
> javax.management.RuntimeMBeanException: java.lang.NullPointerException
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:829)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:842)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:645)
>   at 
> java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:678)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.getTabularData(ObservationQueueLengthHealthCheck.java:250)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.checkEventListenerStats(ObservationQueueLengthHealthCheck.java:110)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.execute(ObservationQueueLengthHealthCheck.java:83)
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.execute(QueryHealthCheckMetrics.java:257)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.lambda$new$0(QueryHealthCheckMetrics.java:244)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.2]
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.2]
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.NullPointerException: null
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl$ListenerStatsData.toCompositeData(ConsolidatedListenerMBeanImpl.java:423)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl.getListenerStats(ConsolidatedListenerMBeanImpl.java:119)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
>   at jdk.internal.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at java.base/sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:260)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
>   at 
> java.management/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
>   at 
> java.management/com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:83)
>   at 
> java.management/com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:206)
>   at 
> 

[jira] [Updated] (OAK-8656) ListenerStatsData.toCompositeData() throws NPE

2019-09-30 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger updated OAK-8656:
--
Attachment: OAK-8656.patch

> ListenerStatsData.toCompositeData() throws NPE
> --
>
> Key: OAK-8656
> URL: https://issues.apache.org/jira/browse/OAK-8656
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: Marcel Reutegger
>Priority: Major
> Attachments: 
> Granite-26986-npe-ListenerStatsData-toCompositeData.patch, OAK-8656.patch
>
>
> Seen recently in an oak-sprout build.
> {noformat}
> 20.08.2019 17:06:17.206 *WARN* 
> [sling-default-3-health-com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck]
>  com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck 
> Exception while getting mBean property: ListenerStats
> javax.management.RuntimeMBeanException: java.lang.NullPointerException
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:829)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:842)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:645)
>   at 
> java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:678)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.getTabularData(ObservationQueueLengthHealthCheck.java:250)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.checkEventListenerStats(ObservationQueueLengthHealthCheck.java:110)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.execute(ObservationQueueLengthHealthCheck.java:83)
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.execute(QueryHealthCheckMetrics.java:257)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.lambda$new$0(QueryHealthCheckMetrics.java:244)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.2]
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.2]
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.NullPointerException: null
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl$ListenerStatsData.toCompositeData(ConsolidatedListenerMBeanImpl.java:423)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl.getListenerStats(ConsolidatedListenerMBeanImpl.java:119)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
>   at jdk.internal.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at java.base/sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:260)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
>   at 
> java.management/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
>   at 
> java.management/com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:83)
>   at 
> java.management/com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:206)
>   at 
> java.management/javax.management.StandardMBean.getAttribute(StandardMBean.java:372)
>   at 
> 

[jira] [Resolved] (OAK-8647) Build Jackrabbit Oak #2407 failed

2019-09-30 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved OAK-8647.
---
Resolution: Duplicate

> Build Jackrabbit Oak #2407 failed
> -
>
> Key: OAK-8647
> URL: https://issues.apache.org/jira/browse/OAK-8647
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2407 has failed.
> First failed run: [Jackrabbit Oak 
> #2407|https://builds.apache.org/job/Jackrabbit%20Oak/2407/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2407/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8647) Build Jackrabbit Oak #2407 failed

2019-09-30 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger closed OAK-8647.
-

> Build Jackrabbit Oak #2407 failed
> -
>
> Key: OAK-8647
> URL: https://issues.apache.org/jira/browse/OAK-8647
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2407 has failed.
> First failed run: [Jackrabbit Oak 
> #2407|https://builds.apache.org/job/Jackrabbit%20Oak/2407/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2407/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8656) ListenerStatsData.toCompositeData() throws NPE

2019-09-30 Thread Jira


[ 
https://issues.apache.org/jira/browse/OAK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940942#comment-16940942
 ] 

José Andrés Cordero Benítez commented on OAK-8656:
--

I have attached a proposed solution for this exception. The solution is based 
in a null-check in like 565 of the same file, which could mean it is expected 
the object could be null in some cases. To avoid the exception I just added 
some null checks for the object.

I added a simple test case to verify the exception is not thrown.

> ListenerStatsData.toCompositeData() throws NPE
> --
>
> Key: OAK-8656
> URL: https://issues.apache.org/jira/browse/OAK-8656
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: Marcel Reutegger
>Priority: Major
> Attachments: Granite-26986-npe-ListenerStatsData-toCompositeData.patch
>
>
> Seen recently in an oak-sprout build.
> {noformat}
> 20.08.2019 17:06:17.206 *WARN* 
> [sling-default-3-health-com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck]
>  com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck 
> Exception while getting mBean property: ListenerStats
> javax.management.RuntimeMBeanException: java.lang.NullPointerException
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:829)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:842)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:645)
>   at 
> java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:678)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.getTabularData(ObservationQueueLengthHealthCheck.java:250)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.checkEventListenerStats(ObservationQueueLengthHealthCheck.java:110)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.execute(ObservationQueueLengthHealthCheck.java:83)
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.execute(QueryHealthCheckMetrics.java:257)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.lambda$new$0(QueryHealthCheckMetrics.java:244)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.2]
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.2]
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.NullPointerException: null
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl$ListenerStatsData.toCompositeData(ConsolidatedListenerMBeanImpl.java:423)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl.getListenerStats(ConsolidatedListenerMBeanImpl.java:119)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
>   at jdk.internal.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at java.base/sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:260)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
>   at 
> java.management/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
>   at 
> 

[jira] [Assigned] (OAK-8656) ListenerStatsData.toCompositeData() throws NPE

2019-09-30 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger reassigned OAK-8656:
-

Assignee: Marcel Reutegger

> ListenerStatsData.toCompositeData() throws NPE
> --
>
> Key: OAK-8656
> URL: https://issues.apache.org/jira/browse/OAK-8656
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: Marcel Reutegger
>Priority: Major
> Attachments: Granite-26986-npe-ListenerStatsData-toCompositeData.patch
>
>
> Seen recently in an oak-sprout build.
> {noformat}
> 20.08.2019 17:06:17.206 *WARN* 
> [sling-default-3-health-com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck]
>  com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck 
> Exception while getting mBean property: ListenerStats
> javax.management.RuntimeMBeanException: java.lang.NullPointerException
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:829)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:842)
>   at 
> java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:645)
>   at 
> java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:678)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.getTabularData(ObservationQueueLengthHealthCheck.java:250)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.checkEventListenerStats(ObservationQueueLengthHealthCheck.java:110)
>   at 
> com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.execute(ObservationQueueLengthHealthCheck.java:83)
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.execute(QueryHealthCheckMetrics.java:257)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.lambda$new$0(QueryHealthCheckMetrics.java:244)
>  [com.adobe.granite.queries:1.0.70]
>   at 
> org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
>  [org.apache.sling.commons.scheduler:2.7.2]
>   at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
> [org.apache.sling.commons.scheduler:2.7.2]
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>   at 
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>   at java.base/java.lang.Thread.run(Thread.java:834)
> Caused by: java.lang.NullPointerException: null
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl$ListenerStatsData.toCompositeData(ConsolidatedListenerMBeanImpl.java:423)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl.getListenerStats(ConsolidatedListenerMBeanImpl.java:119)
>  [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
>   at jdk.internal.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
>   at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>   at java.base/sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:260)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
>   at 
> java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
>   at 
> java.management/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
>   at 
> java.management/com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:83)
>   at 
> java.management/com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:206)
>   at 
> java.management/javax.management.StandardMBean.getAttribute(StandardMBean.java:372)
>   at 
> 

[jira] [Assigned] (OAK-8655) List changes for revisions

2019-09-30 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger reassigned OAK-8655:
-

Assignee: Marcel Reutegger

> List changes for revisions
> --
>
> Key: OAK-8655
> URL: https://issues.apache.org/jira/browse/OAK-8655
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: run
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
> Fix For: 1.20.0
>
>
> Add a utility method to oak-mongo.js that lists the ids of the documents 
> changed by some given revisions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8647) Build Jackrabbit Oak #2407 failed

2019-09-30 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940917#comment-16940917
 ] 

Hudson commented on OAK-8647:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#2412|https://builds.apache.org/job/Jackrabbit%20Oak/2412/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2412/console]

> Build Jackrabbit Oak #2407 failed
> -
>
> Key: OAK-8647
> URL: https://issues.apache.org/jira/browse/OAK-8647
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2407 has failed.
> First failed run: [Jackrabbit Oak 
> #2407|https://builds.apache.org/job/Jackrabbit%20Oak/2407/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2407/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8656) ListenerStatsData.toCompositeData() throws NPE

2019-09-30 Thread Jira
José Andrés Cordero Benítez created OAK-8656:


 Summary: ListenerStatsData.toCompositeData() throws NPE
 Key: OAK-8656
 URL: https://issues.apache.org/jira/browse/OAK-8656
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: documentmk
Reporter: José Andrés Cordero Benítez


Seen recently in an oak-sprout build.
{noformat}
20.08.2019 17:06:17.206 *WARN* 
[sling-default-3-health-com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck]
 com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck 
Exception while getting mBean property: ListenerStats
javax.management.RuntimeMBeanException: java.lang.NullPointerException
at 
java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrow(DefaultMBeanServerInterceptor.java:829)
at 
java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.rethrowMaybeMBeanException(DefaultMBeanServerInterceptor.java:842)
at 
java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:645)
at 
java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.getAttribute(JmxMBeanServer.java:678)
at 
com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.getTabularData(ObservationQueueLengthHealthCheck.java:250)
at 
com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.checkEventListenerStats(ObservationQueueLengthHealthCheck.java:110)
at 
com.adobe.granite.repository.hc.impl.ObservationQueueLengthHealthCheck.execute(ObservationQueueLengthHealthCheck.java:83)
at 
com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.execute(QueryHealthCheckMetrics.java:257)
 [com.adobe.granite.queries:1.0.70]
at 
com.adobe.granite.queries.impl.hc.QueryHealthCheckMetrics$LazyGauge.lambda$new$0(QueryHealthCheckMetrics.java:244)
 [com.adobe.granite.queries:1.0.70]
at 
org.apache.sling.commons.scheduler.impl.QuartzJobExecutor.execute(QuartzJobExecutor.java:347)
 [org.apache.sling.commons.scheduler:2.7.2]
at org.quartz.core.JobRunShell.run(JobRunShell.java:202) 
[org.apache.sling.commons.scheduler:2.7.2]
at 
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at 
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.lang.NullPointerException: null
at 
org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl$ListenerStatsData.toCompositeData(ConsolidatedListenerMBeanImpl.java:423)
 [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
at 
org.apache.jackrabbit.oak.jcr.observation.ConsolidatedListenerMBeanImpl.getListenerStats(ConsolidatedListenerMBeanImpl.java:119)
 [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)
at jdk.internal.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at java.base/sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:260)
at 
java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
at 
java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
at 
java.management/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
at 
java.management/com.sun.jmx.mbeanserver.PerInterface.getAttribute(PerInterface.java:83)
at 
java.management/com.sun.jmx.mbeanserver.MBeanSupport.getAttribute(MBeanSupport.java:206)
at 
java.management/javax.management.StandardMBean.getAttribute(StandardMBean.java:372)
at 
java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getAttribute(DefaultMBeanServerInterceptor.java:641)
... 11 common frames omitted{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8549) Update Tika dependency to 1.22

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908952#comment-16908952
 ] 

Julian Reschke edited comment on OAK-8549 at 9/30/19 12:02 PM:
---

trunk: (1.18.0) [r1865286|http://svn.apache.org/r1865286]
1.10: [r1867768|http://svn.apache.org/r1867768]


was (Author: reschke):
trunk: [r1865286|http://svn.apache.org/r1865286]


> Update Tika dependency to 1.22
> --
>
> Key: OAK-8549
> URL: https://issues.apache.org/jira/browse/OAK-8549
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.18.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8549) Update Tika dependency to 1.22

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8549:

Fix Version/s: 1.10.6

> Update Tika dependency to 1.22
> --
>
> Key: OAK-8549
> URL: https://issues.apache.org/jira/browse/OAK-8549
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8549) Update Tika dependency to 1.22

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8549:

Labels: candidate_oak_1_8  (was: candidate_oak_1_10)

> Update Tika dependency to 1.22
> --
>
> Key: OAK-8549
> URL: https://issues.apache.org/jira/browse/OAK-8549
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.18.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-8655) List changes for revisions

2019-09-30 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved OAK-8655.
---
Fix Version/s: 1.20.0
   Resolution: Fixed

Added to trunk: http://svn.apache.org/r1867767

> List changes for revisions
> --
>
> Key: OAK-8655
> URL: https://issues.apache.org/jira/browse/OAK-8655
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: run
>Reporter: Marcel Reutegger
>Priority: Major
> Fix For: 1.20.0
>
>
> Add a utility method to oak-mongo.js that lists the ids of the documents 
> changed by some given revisions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8655) List changes for revisions

2019-09-30 Thread Marcel Reutegger (Jira)
Marcel Reutegger created OAK-8655:
-

 Summary: List changes for revisions
 Key: OAK-8655
 URL: https://issues.apache.org/jira/browse/OAK-8655
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: run
Reporter: Marcel Reutegger


Add a utility method to oak-mongo.js that lists the ids of the documents 
changed by some given revisions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8647) Build Jackrabbit Oak #2407 failed

2019-09-30 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940824#comment-16940824
 ] 

Hudson commented on OAK-8647:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#2411|https://builds.apache.org/job/Jackrabbit%20Oak/2411/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2411/console]

> Build Jackrabbit Oak #2407 failed
> -
>
> Key: OAK-8647
> URL: https://issues.apache.org/jira/browse/OAK-8647
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2407 has failed.
> First failed run: [Jackrabbit Oak 
> #2407|https://builds.apache.org/job/Jackrabbit%20Oak/2407/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2407/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8648) Log reason why NodeDocumentSweeper.sweep is called

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940819#comment-16940819
 ] 

Julian Reschke commented on OAK-8648:
-

trunk: [r1867763|http://svn.apache.org/r1867763]

> Log reason why NodeDocumentSweeper.sweep is called
> --
>
> Key: OAK-8648
> URL: https://issues.apache.org/jira/browse/OAK-8648
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Vincent Frey
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.20.0
>
> Attachments: OAK-8648.diff
>
>
> It can happen during a  cluster node restart, that a 
> NodeDocumentSweeper.sweep is triggered.
> Depending on the number of nodes, this can delay the start process for 
> several hours.
> In order to understand what caused the sweep, it could be interesting to log 
> (INFO level) the reason why it has been triggered.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-8648) Log reason why NodeDocumentSweeper.sweep is called

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved OAK-8648.
-
Fix Version/s: 1.20.0
   Resolution: Fixed

> Log reason why NodeDocumentSweeper.sweep is called
> --
>
> Key: OAK-8648
> URL: https://issues.apache.org/jira/browse/OAK-8648
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Vincent Frey
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0
>
> Attachments: OAK-8648.diff
>
>
> It can happen during a  cluster node restart, that a 
> NodeDocumentSweeper.sweep is triggered.
> Depending on the number of nodes, this can delay the start process for 
> several hours.
> In order to understand what caused the sweep, it could be interesting to log 
> (INFO level) the reason why it has been triggered.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8648) Log reason why NodeDocumentSweeper.sweep is called

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8648:

Labels: candidate_oak_1_10  (was: )

> Log reason why NodeDocumentSweeper.sweep is called
> --
>
> Key: OAK-8648
> URL: https://issues.apache.org/jira/browse/OAK-8648
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Vincent Frey
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.20.0
>
> Attachments: OAK-8648.diff
>
>
> It can happen during a  cluster node restart, that a 
> NodeDocumentSweeper.sweep is triggered.
> Depending on the number of nodes, this can delay the start process for 
> several hours.
> In order to understand what caused the sweep, it could be interesting to log 
> (INFO level) the reason why it has been triggered.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-8623) Improve collision handling performance

2019-09-30 Thread Marcel Reutegger (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marcel Reutegger resolved OAK-8623.
---
Fix Version/s: 1.20.0
   Resolution: Fixed

Applied most recent patch to trunk: http://svn.apache.org/r1867759

> Improve collision handling performance
> --
>
> Key: OAK-8623
> URL: https://issues.apache.org/jira/browse/OAK-8623
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: OAK-8623-2.patch, OAK-8623.patch
>
>
> The current collision handling on conflict in the DocumentNodeStore can be 
> rather expensive when there are old branch commits which were not merged.
> A commit that includes documents with old branch commits that have not been 
> merged will always attempt to set a collision marker on the commit root 
> document for those changes.
> While it is difficult to tell whether a branch commit will be merged at some 
> point, at least those branch commits that were created before the most recent 
> startup of a cluster node cannot be merged. The collision handling logic 
> could be improved to take the start time of a cluster node into account.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8654) Introduce auto-retry in the SegmentStoreMigrator

2019-09-30 Thread Jira


[ 
https://issues.apache.org/jira/browse/OAK-8654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940748#comment-16940748
 ] 

Tomek Rękawek commented on OAK-8654:


Done in [r1867754|https://svn.apache.org/r1867754].

> Introduce auto-retry in the SegmentStoreMigrator
> 
>
> Key: OAK-8654
> URL: https://issues.apache.org/jira/browse/OAK-8654
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-azure
>Reporter: Tomek Rękawek
>Priority: Major
> Fix For: 1.20.0
>
>
> When migrating a large repository, the timeout exception may happen for 
> various reasons. We should handle them automatically and auto-retry the 
> failed operation a few times before giving up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8654) Introduce auto-retry in the SegmentStoreMigrator

2019-09-30 Thread Jira
Tomek Rękawek created OAK-8654:
--

 Summary: Introduce auto-retry in the SegmentStoreMigrator
 Key: OAK-8654
 URL: https://issues.apache.org/jira/browse/OAK-8654
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: segment-azure
Reporter: Tomek Rękawek
 Fix For: 1.20.0


When migrating a large repository, the timeout exception may happen for various 
reasons. We should handle them automatically and auto-retry the failed 
operation a few times before giving up.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8648) Log reason why NodeDocumentSweeper.sweep is called

2019-09-30 Thread Marcel Reutegger (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940720#comment-16940720
 ] 

Marcel Reutegger commented on OAK-8648:
---

bq. ...or a new cluster id is used, right?

No, there shouldn't be any initial sweep when a new clusterId is created. In 
that case the sweep revision for the new clusterId is set to the initial head 
revision on startup.

You can somewhat construct a case where the implementation will still run an 
initial sweep, when an clusterId entry created by a pre 1.8 version is manually 
removed. The implementation will run an initial sweep when the clusterId is 
resurrected. This is because the decision whether an initial sweep is necessary 
is not based on the data in the clusterNodes collection, but based on the data 
in the root document where the sweep revisions are located.

> Log reason why NodeDocumentSweeper.sweep is called
> --
>
> Key: OAK-8648
> URL: https://issues.apache.org/jira/browse/OAK-8648
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Vincent Frey
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-8648.diff
>
>
> It can happen during a  cluster node restart, that a 
> NodeDocumentSweeper.sweep is triggered.
> Depending on the number of nodes, this can delay the start process for 
> several hours.
> In order to understand what caused the sweep, it could be interesting to log 
> (INFO level) the reason why it has been triggered.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8653) bump up logging for deprecated security APIs to INFO

2019-09-30 Thread Julian Reschke (Jira)
Julian Reschke created OAK-8653:
---

 Summary: bump up logging for deprecated security APIs to INFO
 Key: OAK-8653
 URL: https://issues.apache.org/jira/browse/OAK-8653
 Project: Jackrabbit Oak
  Issue Type: Task
  Components: security
Reporter: Julian Reschke
Assignee: Julian Reschke
 Fix For: 1.20.0






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8549) Update Tika dependency to 1.22

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8549.
---

> Update Tika dependency to 1.22
> --
>
> Key: OAK-8549
> URL: https://issues.apache.org/jira/browse/OAK-8549
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8536) Update JavaDoc for completeBinaryUpload() explaining idempotency

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8536.
---

> Update JavaDoc for completeBinaryUpload() explaining idempotency
> 
>
> Key: OAK-8536
> URL: https://issues.apache.org/jira/browse/OAK-8536
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: jackrabbit-api
>Affects Versions: 1.16.0
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Minor
> Fix For: 1.18.0
>
>
> In OAK-8520 a fix was added in the direct binary upload implementation so 
> that if a client calls {{completeBinaryUpload()}} multiple times with the 
> same upload token, subsequent calls will return the already-uploaded binary 
> without making any change to the backend.  It would be good to reflect this 
> case in the JavaDocs for {{JackrabbitValueFactory.completeBinaryUpload()}}.
> (NOTE:  Copied from JCR-4463 which was put in the wrong project on accident)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8648) Log reason why NodeDocumentSweeper.sweep is called

2019-09-30 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940715#comment-16940715
 ] 

Julian Reschke commented on OAK-8648:
-

[~mreutegg]: just to clarify:

bq. On startup, a sweep will only happen when an existing clusterId is picked 
up that has never been used by an Oak version 1.8 or newer.

...or a new cluster id is used, right?

> Log reason why NodeDocumentSweeper.sweep is called
> --
>
> Key: OAK-8648
> URL: https://issues.apache.org/jira/browse/OAK-8648
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Affects Versions: 1.8.9
>Reporter: Vincent Frey
>Assignee: Julian Reschke
>Priority: Minor
> Attachments: OAK-8648.diff
>
>
> It can happen during a  cluster node restart, that a 
> NodeDocumentSweeper.sweep is triggered.
> Depending on the number of nodes, this can delay the start process for 
> several hours.
> In order to understand what caused the sweep, it could be interesting to log 
> (INFO level) the reason why it has been triggered.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8541) AbstractRestrictionProvider.createRestriction : Include restriction name in error message

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8541.
---

> AbstractRestrictionProvider.createRestriction : Include restriction name in 
> error message
> -
>
> Key: OAK-8541
> URL: https://issues.apache.org/jira/browse/OAK-8541
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: security-spi
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Trivial
> Fix For: 1.18.0
>
>
> when calling {{AbstractRestrictionProvider.createRestriction}} with value 
> cardinality mismatch or values of the wrong type, the error message of the 
> {{AccessControlException}} doesn't indicate the name of restrictions causing 
> the error.
> [~stillalex], fyi



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8328) Bug in index definition can block indexing / cause indexing in a loop

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8328.
---

> Bug in index definition can block indexing / cause indexing in a loop
> -
>
> Key: OAK-8328
> URL: https://issues.apache.org/jira/browse/OAK-8328
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core, lucene
>Reporter: Nitin Gupta
>Assignee: Terry Mueller
>Priority: Major
>  Labels: indexingPatch
> Fix For: 1.18.0
>
> Attachments: OAK-8328.patch, OAK-8328_2.patch, OAK-8328_3.patch, 
> OAK-8328_test.patch
>
>
> If we  set "/oak:index/indexName/entryCount" to a Long multi-valued property. 
> That will cause the system to reindex in a loop... You only see the root 
> cause if debug level logging is enabled. There are likely other such 
> problems. Oak should log a proper meaningful exception for config errors, and 
> if possible not get into this loop. It also blocks other indexes to be 
> updated I think.
>  
>  
> {code:java}
> 29.03.2019 11:58:55.688 *INFO* [async-index-update-async] 
> org.apache.jackrabbit.oak.plugins.index.IndexUpdate Reindexing will be 
> performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:00.691 *INFO* [async-index-update-async] 
> org.apache.jackrabbit.oak.plugins.index.IndexUpdate Reindexing will be 
> performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:05.685 *INFO* [async-index-update-async] 
> org.apache.jackrabbit.oak.plugins.index.IndexUpdate Reindexing will be 
> performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:10.687 *INFO* [async-index-update-async] 
> org.apache.jackrabbit.oak.plugins.index.IndexUpdate Reindexing will be 
> performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:15.685 *INFO* [async-index-update-async] 
> org.apache.jackrabbit.oak.plugins.index.IndexUpdate Reindexing will be 
> performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 11:59:20.688 *INFO* [async-index-update-async] 
> org.apache.jackrabbit.oak.plugins.index.IndexUpdate Reindexing will be 
> performed for following indexes: [/oak:index/unifiedCreatedLucene]
> 29.03.2019 12:13:50.692 *DEBUG* [async-index-update-async] 
> org.apache.jackrabbit.oak.plugins.index.AsyncIndexUpdate [async] The index 
> update is still failing
> java.lang.IllegalStateException: null
>   at 
> com.google.common.base.Preconditions.checkState(Preconditions.java:134)
>   at 
> org.apache.jackrabbit.oak.segment.SegmentPropertyState.getValue(SegmentPropertyState.java:145)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexDefinition.(IndexDefinition.java:358)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexDefinition.(IndexDefinition.java:95)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexDefinition$Builder.build(IndexDefinition.java:314)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexEditorContext.enableReindexMode(LuceneIndexEditorContext.java:184)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexEditor.enter(LuceneIndexEditor.java:118)
>   at 
> org.apache.jackrabbit.oak.spi.commit.ProgressNotificationEditor.enter(ProgressNotificationEditor.java:71)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8521) Add shutdown hook for oak-run commands

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8521.
---

> Add shutdown hook for oak-run commands
> --
>
> Key: OAK-8521
> URL: https://issues.apache.org/jira/browse/OAK-8521
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk, run
>Reporter: Vinod Holani
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.18.0
>
> Attachments: OAK-8521.patch
>
>
> Ensure there are shutdown hooks in place for the various oak-run commands 
> that properly stop the repository and release the clusterId.
> Many command construct a repository, then perform some operation and then 
> shut down the repository again. Shutting down the repository will release the 
> clusterId change the state of the clusterNodes entry back to inactive. In 
> some cases commands execute for a longer period of time and a user might kill 
> the process. When this happens, the clusterId is not released and stays in 
> the active state with a lease that eventually expires. The command 
> implementations should be improved to register a JVM shutdown hook that 
> ensures the repository is shut down, even when the process is killed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8552) Minimize network calls required when creating a direct download URI

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8552.
---

> Minimize network calls required when creating a direct download URI
> ---
>
> Key: OAK-8552
> URL: https://issues.apache.org/jira/browse/OAK-8552
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: blob-cloud, blob-cloud-azure
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Major
> Fix For: 1.18.0
>
> Attachments: OAK-8552_ApiChange.patch
>
>
> We need to isolate and try to optimize network calls required to create a 
> direct download URI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8245) Add column for explained "statement" to "explain" Query result, next to 'plan' column.

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8245.
---

> Add column for explained "statement" to "explain" Query result, next to 
> 'plan' column.
> --
>
> Key: OAK-8245
> URL: https://issues.apache.org/jira/browse/OAK-8245
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: query
>Affects Versions: 1.12.0, 1.8.12, 1.10.2
>Reporter: Mark Adamcin
>Assignee: Terry Mueller
>Priority: Minor
> Fix For: 1.18.0
>
>
> The "explain" behavior of the core Query is very useful for helping to debug 
> JCR query execution planning. For xpath queries, the resulting "plan" column 
> refers to the result of running XPathToSQL2Converter to produce a JCR-SQL2 
> statement for execution. This SQL2 statement should be exposed through the 
> same API as the "plan", by way of an additional column named "statement" in 
> the single result row. 
> At this time, this underlying SQL2 statement is inaccessible to users of the 
> JCR Query interface, which can only provide the original XPath statement.
> To access the converted SQL2 statement, a class targeting the JCR API must 
> implement a regular expression match against a log stream retrieved via slf4j 
> MDC.
> This facility is not very portable, and an effective pattern on one version 
> of Oak may not be effective on a different version of Oak, for any number of 
> reasons.
> Also, the XPathToSQL2Converter package is not exported in an OSGi 
> environment, so client code cannot use that API to reconstruct the SQL2 
> statement in parallel.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8558) Simplify path handling in TopLevelPaths

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8558.
---

> Simplify path handling in TopLevelPaths
> ---
>
> Key: OAK-8558
> URL: https://issues.apache.org/jira/browse/OAK-8558
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: authorization-cug
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8611) Export the oak-segment-azure packages

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8611.
---

> Export the oak-segment-azure packages
> -
>
> Key: OAK-8611
> URL: https://issues.apache.org/jira/browse/OAK-8611
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-azure
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.18.0
>
>
> We need to export the oak-segment-azure, so the AzurePersistence can be used 
> in other bundles.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8538) Incomplete recovery on long running merge with branch commits

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8538.
---

> Incomplete recovery on long running merge with branch commits
> -
>
> Key: OAK-8538
> URL: https://issues.apache.org/jira/browse/OAK-8538
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.16.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
> Fix For: 1.18.0
>
>
> Recovery of a crashed cluster node that was unable to run a background update 
> after a long running merge with branch commits is incomplete. The recovery 
> will use a start date for the candidate documents that is too recent and not 
> take all the documents of the branch commits into account.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8554) IndexCopier#waitForCopyCompletion doesn't reset interrupted flag after catching InterruptedException

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8554.
---

> IndexCopier#waitForCopyCompletion doesn't reset interrupted flag after 
> catching InterruptedException
> 
>
> Key: OAK-8554
> URL: https://issues.apache.org/jira/browse/OAK-8554
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.18.0
>
>
> As noted by [~frm] at https://twitter.com/frm1025/status/1161705351382798336 
> {{IndexCopier#waitForCopyCompletion}} should reset {{interrupt}} status after 
> catching {{InterruptedException}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8579) Composite Node Store: Allow creating an index in the read-only repo first

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8579.
---

> Composite Node Store: Allow creating an index in the read-only repo first
> -
>
> Key: OAK-8579
> URL: https://issues.apache.org/jira/browse/OAK-8579
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: composite, core, indexing, lucene
>Reporter: Terry Mueller
>Assignee: Terry Mueller
>Priority: Major
> Fix For: 1.18.0
>
>
> Currently, it is not allowed to first create a new index in the read-only 
> repository, and then in the read-write repository. Trying to do so will fail 
> with "OakConstraint0001: /oak:index/.../:oak:mount-readOnlyV1-index-data[[]]: 
> The primary type null does not exist"
> See OAK-7917: oak-lucene/src/test/java/org/apache/jackrabbit/oak/composite - 
> CompositeNodeStoreLuceneIndexTest.java 
> tryAddIndexInReadWriteWithIndexExistinginReadOnly line 112. 
> It would be better to allow this use case, to reduce the possibility of 
> problems.
> We should specially test with lucene indexes, but also with property indexes. 
> (If that's more complicated, we can concentrate on the lucene case first.)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8624) oak-run: tests leak mapd temp files

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8624.
---

> oak-run: tests leak mapd temp files
> ---
>
> Key: OAK-8624
> URL: https://issues.apache.org/jira/browse/OAK-8624
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: run
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0
>
> Attachments: OAK-8624.diff
>
>
> This is because {{MapDBMapFactory}} is backed by temporary DB, but that one 
> is never closed.
> Fix:
> - make it {{closeable}}
> - adapt test case and use in {{RecoveryCommand}}
> However, {{RecoveryCommand}} sets the {{MapFactory}} instance globally, and 
> never resets it. Thus, if the factory is indeed closed, subsequent tests will 
> fail. So, in {{RecoveryCommand}}, restore the default factory when done.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8514) CoR should log a warn when opening remote index file when prefetch is enabled

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8514.
---

> CoR should log a warn when opening remote index file when prefetch is enabled
> -
>
> Key: OAK-8514
> URL: https://issues.apache.org/jira/browse/OAK-8514
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.18.0
>
>
> Currently CoR logs almost everything in trace. It'd be useful to investigate 
> issues if at least when prefetch is enabled (hence expectation is that all 
> files should be available locally) then opening index file from remote 
> directory should be logged as a warn.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8616) Leverage oak-search utils in oak-search-elastic where possible

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8616.
---

> Leverage oak-search utils in oak-search-elastic where possible
> --
>
> Key: OAK-8616
> URL: https://issues.apache.org/jira/browse/OAK-8616
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: elastic-search
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>Priority: Major
> Fix For: 1.18.0
>
>
> _oak-search-elasticsearch_ should use _oak-search_ SPIs and utilities as much 
> as possible to reduce code complexity and duplication.
> Even this means changing some methods from *protected* to *public* it should 
> not cause any back-compat concern because nothing is currently exported yet 
> from within _oak-search_ (in fact it's embedded in _oak-lucene_).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8565) Using a lazy blob listing can cause Azure timeout

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8565.
---

> Using a lazy blob listing can cause Azure timeout
> -
>
> Key: OAK-8565
> URL: https://issues.apache.org/jira/browse/OAK-8565
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-azure
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.18.0
>
>
> When trying to list the Azure blob in a lazy way, the API client loads the 
> listing in a few segments. If there's too much time between segment requests 
> (eg. because we're processing each blob), it can result in TimeoutException:
> {noformat}
> [FelixStartLevel] org.apache.jackrabbit.oak-segment-tar bundle 
> org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511 
> (144)[org.apache.jackrabbit.oak.segment.SegmentNodeStoreFactory(204)] : The 
> activate method has thrown an exception (java.util.NoSuchElementException: An 
> error occurred while enumerating the result, check the original exception for 
> details.)
> java.util.NoSuchElementException: An error occurred while enumerating the 
> result, check the original exception for details.
>   at 
> com.microsoft.azure.storage.core.LazySegmentedIterator.hasNext(LazySegmentedIterator.java:113)
>   at java.base/java.util.Iterator.forEachRemaining(Iterator.java:132)
>   at 
> java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
>   at 
> java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
>   at 
> java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
>   at 
> java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
>   at 
> java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
>   at 
> java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
>   at 
> java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:497)
>   at 
> org.apache.jackrabbit.oak.segment.azure.AzureArchiveManager.renameTo(AzureArchiveManager.java:134)
>  [org.apache.jackrabbit.oak-segment-azure:1.16.0.R1864511]
>   at 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader.backupSafely(TarReader.java:208)
>  [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
>   at 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader.collectFileEntries(TarReader.java:154)
>  [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
>   at 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader.open(TarReader.java:99) 
> [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
>   at 
> org.apache.jackrabbit.oak.segment.file.tar.TarFiles.(TarFiles.java:395) 
> [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> ...
> Caused by: com.microsoft.azure.storage.StorageException: The client could not 
> finish the operation within specified maximum execution timeout.
>   at 
> com.microsoft.azure.storage.core.ExecutionEngine.setupStorageRequest(ExecutionEngine.java:277)
>   at 
> com.microsoft.azure.storage.core.ExecutionEngine.executeWithRetry(ExecutionEngine.java:95)
>   at 
> com.microsoft.azure.storage.core.LazySegmentedIterator.hasNext(LazySegmentedIterator.java:109)
>   ... 58 common frames omitted
> Caused by: java.util.concurrent.TimeoutException: The client could not finish 
> the operation within specified maximum execution timeout.
>   at 
> com.microsoft.azure.storage.core.ExecutionEngine.setupStorageRequest(ExecutionEngine.java:276)
>   ... 60 common frames omitted
> {noformat}
> We should update the code to load all blobs into a list and return it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8589) NPE in IndexDefintionBuilder with existing property rule without "name" property

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8589.
---

> NPE in IndexDefintionBuilder with existing property rule without "name" 
> property
> 
>
> Key: OAK-8589
> URL: https://issues.apache.org/jira/browse/OAK-8589
> Project: Jackrabbit Oak
>  Issue Type: Improvement
> Environment: Inde
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.18.0
>
>
> {{IndexDefinitionBuilder#findExisting}} throws NPE when 
> {{IndexDefinitionBuilder}} is initialized with an existing index that has a 
> property rule without {{name}} property defined.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8608) Move the SplitPersistence to the oak-segment-tar SPI

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8608.
---

> Move the SplitPersistence to the oak-segment-tar SPI
> 
>
> Key: OAK-8608
> URL: https://issues.apache.org/jira/browse/OAK-8608
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-tar
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Minor
> Fix For: 1.18.0
>
>
> The SplitPersistence is a simple, utility implementation of the 
> SegmentNodeStorePersistence interface. It should be possible to use it in 
> other bundles implementing the SegmentNodeStorePersistence service, so let's 
> move it to the bundle SPI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8600) [Direct Binary Access] Log exceptions at debug level for expected exceptions

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8600.
---

> [Direct Binary Access] Log exceptions at debug level for expected exceptions
> 
>
> Key: OAK-8600
> URL: https://issues.apache.org/jira/browse/OAK-8600
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: blob-cloud, blob-cloud-azure
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Major
> Fix For: 1.18.0
>
>
> Recent data store optimizations to reduce network API calls means a greater 
> reliance on exception handling to minimize the number of calls, and catching 
> thrown exceptions from these API calls (for example, calling a network API 
> and handling a thrown exception for a missing blob instead of checking for 
> blob existence first, then calling the other network API).
> We need to change any logging of these issues to debug level, and/or change 
> the log messages to avoid looking like there are problems or uncaught 
> exceptions in the logs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8550) Update commons-codec dependency to 1.13

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8550.
---

> Update commons-codec dependency to 1.13
> ---
>
> Key: OAK-8550
> URL: https://issues.apache.org/jira/browse/OAK-8550
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8634) Decouple CommitDiff from DocumentNodeStore

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8634.
---

> Decouple CommitDiff from DocumentNodeStore
> --
>
> Key: OAK-8634
> URL: https://issues.apache.org/jira/browse/OAK-8634
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.18.0
>
>
> The {{CommitDiff}} keeps a reference to a {{DocumentNodeStore}} even though 
> it is only used in the public constructor to get the 
> {{BundlingConfigHandler}}. The class would be leaner and easier to test if it 
> doesn't depend on a {{DocumentNodeStore}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8530) Ensure MBean are deregistered if the repository fails to start

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8530.
---

> Ensure MBean are deregistered if the repository fails to start
> --
>
> Key: OAK-8530
> URL: https://issues.apache.org/jira/browse/OAK-8530
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: core
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: 1.18.0
>
>
> When used in OSGi environments the repository service is unfortunately prone 
> to restarts ( see SLING-7811 for the gory details ). Besides the performance 
> problem, the repository typically fails to restart since MBeans that were 
> registered once were not deregistered. The failures happen before repository 
> is constructed, so there is no instance to close.
> A typical stack trace is
> {noformat}
> 06.08.2019 09:55:03.894 *ERROR* [Apache Sling Repository Startup Thread #4] 
> org.apache.aries.jmx.whiteboard.MBeanHolder register: Failure registering 
> MBean org.apache.jackrabbit.oak.management.RepositoryManager@5e05b159
> javax.management.InstanceAlreadyExistsException: 
> org.apache.jackrabbit.oak:name=repository manager,type=RepositoryManagement
>   at com.sun.jmx.mbeanserver.Repository.addMBean(Repository.java:437)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(DefaultMBeanServerInterceptor.java:1898)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(DefaultMBeanServerInterceptor.java:966)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(DefaultMBeanServerInterceptor.java:900)
>   at 
> com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(DefaultMBeanServerInterceptor.java:324)
>   at 
> com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(JmxMBeanServer.java:522)
>   at 
> org.apache.aries.jmx.whiteboard.MBeanHolder.register(MBeanHolder.java:114)
>   at 
> org.apache.aries.jmx.whiteboard.JmxWhiteboardSupport.registerMBean(JmxWhiteboardSupport.java:88)
>   at 
> org.apache.aries.jmx.whiteboard.Activator$MBeanTracker.addingService(Activator.java:102)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871)
>   at 
> org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256)
>   at org.osgi.util.tracker.AbstractTracked.track(AbstractTracked.java:229)
>   at 
> org.osgi.util.tracker.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:903)
>   at 
> org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990)
>   at 
> org.apache.felix.framework.EventDispatcher.fireEventImmediately(EventDispatcher.java:838)
>   at 
> org.apache.felix.framework.EventDispatcher.fireServiceEvent(EventDispatcher.java:545)
>   at org.apache.felix.framework.Felix.fireServiceEvent(Felix.java:4833)
>   at org.apache.felix.framework.Felix.registerService(Felix.java:3804)
>   at 
> org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:328)
>   at 
> org.apache.felix.framework.BundleContextImpl.registerService(BundleContextImpl.java:302)
>   at 
> org.apache.jackrabbit.oak.osgi.OsgiWhiteboard.register(OsgiWhiteboard.java:79)
>   at 
> org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardUtils.registerMBean(WhiteboardUtils.java:115)
>  [org.apache.jackrabbit.oak-core-spi:1.18.0.SNAPSHOT]
>   at 
> org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardUtils.registerMBean(WhiteboardUtils.java:99)
>  [org.apache.jackrabbit.oak-core-spi:1.18.0.SNAPSHOT]
>   at 
> org.apache.jackrabbit.oak.Oak.createNewContentRepository(Oak.java:772) 
> [org.apache.jackrabbit.oak-core:1.18.0.SNAPSHOT]
>   at org.apache.jackrabbit.oak.Oak.createContentRepository(Oak.java:671) 
> [org.apache.jackrabbit.oak-core:1.18.0.SNAPSHOT]
>   at 
> org.apache.jackrabbit.oak.jcr.Jcr.createContentRepository(Jcr.java:376) 
> [org.apache.jackrabbit.oak-jcr:1.18.0.SNAPSHOT]
>   at 
> org.apache.sling.jcr.oak.server.internal.OakSlingRepositoryManager.acquireRepository(OakSlingRepositoryManager.java:152)
>  [org.apache.sling.jcr.oak.server:1.2.2]
>   at 
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.initializeAndRegisterRepositoryService(AbstractSlingRepositoryManager.java:481)
>  [org.apache.sling.jcr.base:3.0.6]
>   at 
> org.apache.sling.jcr.base.AbstractSlingRepositoryManager.access$300(AbstractSlingRepositoryManager.java:86)
>  [org.apache.sling.jcr.base:3.0.6]
> {noformat}
> I will propose a patch shortly.



--
This message was sent by 

[jira] [Closed] (OAK-8568) RDB*Store: update mysql jdbc driver reference to 8.0.17

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8568.
---

> RDB*Store: update mysql jdbc driver reference to 8.0.17
> ---
>
> Key: OAK-8568
> URL: https://issues.apache.org/jira/browse/OAK-8568
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8619) Enable text extraction timeout recovery from disk

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8619.
---

> Enable text extraction timeout recovery from disk
> -
>
> Key: OAK-8619
> URL: https://issues.apache.org/jira/browse/OAK-8619
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: elastic-search
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>Priority: Minor
> Fix For: 1.18.0
>
>
> Same as for _oak-lucene_, {{ExtractedTextCache}} may have to be persisted and 
> loaded due to extraction timeout, for this to work a directory on disk needs 
> to be supplied from {{ElasticsearchIndexProviderService}} too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8635) Use LMSEstimator for Oak ES SizeEstimator

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8635.
---

> Use LMSEstimator for Oak ES SizeEstimator
> -
>
> Key: OAK-8635
> URL: https://issues.apache.org/jira/browse/OAK-8635
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: elastic-search, oak-search, solr
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>Priority: Major
> Fix For: 1.18.0
>
>
> {{LMSEstimator}} is currently used in Solr index to avoid network traffic in 
> result size estimation.
> It might be beneficial to reuse it for the same scope within Oak ES, by 
> moving {{LMSEstimator}} into _oak-search_.
> Note that this implies _oak-solr-core_ will start depending on _oak-search_ 
> which was anyway planned for a while already.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8637) Add convergence testing coverage for LMSEstimator

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8637.
---

> Add convergence testing coverage for LMSEstimator
> -
>
> Key: OAK-8637
> URL: https://issues.apache.org/jira/browse/OAK-8637
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: oak-search
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>Priority: Major
> Fix For: 1.18.0
>
>
> {{LMSEstimator}} should have a test to make sure it converges (commits lower 
> and lower error over time).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8629) Node bundling exposes hidden properties

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8629.
---

> Node bundling exposes hidden properties
> ---
>
> Key: OAK-8629
> URL: https://issues.apache.org/jira/browse/OAK-8629
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.16.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
>  Labels: candidate_oak_1_10, candidate_oak_1_6, candidate_oak_1_8
> Fix For: 1.18.0
>
> Attachments: OAK-8629.patch
>
>
> The DocumentNodeStore node bundling feature may expose a hidden internal 
> property when a bundled node structure is deleted and re-created with a 
> non-bundling nodetype.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8542) Test failure: ConcurrentCopyOnReadDirectoryTest.concurrentPrefetchWithTimeout

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8542.
---

> Test failure: ConcurrentCopyOnReadDirectoryTest.concurrentPrefetchWithTimeout
> -
>
> Key: OAK-8542
> URL: https://issues.apache.org/jira/browse/OAK-8542
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration, lucene
>Reporter: Hudson
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.18.0
>
>
> No description is provided
> The build Jackrabbit Oak #2318 has failed.
> First failed run: [Jackrabbit Oak 
> #2318|https://builds.apache.org/job/Jackrabbit%20Oak/2318/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2318/console]
> {noformat}
> java.lang.NullPointerException
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.ConcurrentCopyOnReadDirectoryTest.concurrentPrefetchWithTimeout(ConcurrentCopyOnReadDirectoryTest.java:154)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8614) Update httpclient/mime dependencies to 4.5.10

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8614.
---

> Update httpclient/mime dependencies to 4.5.10
> -
>
> Key: OAK-8614
> URL: https://issues.apache.org/jira/browse/OAK-8614
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8590) Direct Binary Access doc links to jackrabbit-api are broken

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8590.
---

> Direct Binary Access doc links to jackrabbit-api are broken
> ---
>
> Key: OAK-8590
> URL: https://issues.apache.org/jira/browse/OAK-8590
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: doc
>Affects Versions: 1.16.0
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Major
> Fix For: 1.18.0
>
>
> The javadoc links on 
> [https://jackrabbit.apache.org/oak/docs/features/direct-binary-access.html] 
> are broken because the jackrabbit-api trunk URLs no longer work and return 
> 404.
> This is probably due to changes made in OAK-8339.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8612) Make the Azure Data Store compatible with Guava 15 and 26

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8612.
---

> Make the Azure Data Store compatible with Guava 15 and 26
> -
>
> Key: OAK-8612
> URL: https://issues.apache.org/jira/browse/OAK-8612
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: blob-plugins
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.18.0
>
> Attachments: OAK-8612.patch
>
>
> I was recently working on some potential usage of gRPC in Oak. I'll create an 
> issue shortly, explaining the idea. For now, I'd like to use the gRPC in the 
> same class loader as Azure Data Store. The gRPC uses Guava 26 and can't be 
> downgraded. In Oak, we're using Guava 15.
> We'll probably upgrade the Oak to Guava 26 in the future, but it'll be a 
> bigger task. I was wondering if there's a workaround that allows to use APIs 
> which are common to Guava 15 and 26 in the Azure Data Store. It seems that 
> we're using the APIs removed from Guava 26 just in two places of the 
> UploadStagingCache class:
> * in the file traverser in UploadStagingCache#build()
> * in the future handling in UploadStagingCache#stage()
> [~amitjain], I was wondering if you'd be OK with changing these two places, 
> so they are compatible both with Guava 15 and 26. It'd help me with 
> proceeding with the PoC I mentioned. And again: the current version works 
> completely fine.
> For the file traversing, we can use the Java 8 file traverse utils. For the 
> future listening, I copied the SameThreadExecutorService from Guava and used 
> it as an extra parameter, required in the newer versions.
> WDYT?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8543) Javadoc of IndexCopier#waitForCopyCompletion refers to boolean return

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8543.
---

> Javadoc of IndexCopier#waitForCopyCompletion refers to boolean return
> -
>
> Key: OAK-8543
> URL: https://issues.apache.org/jira/browse/OAK-8543
> Project: Jackrabbit Oak
>  Issue Type: Documentation
>  Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Minor
> Fix For: 1.18.0
>
>
> As noted by [~frm] at https://twitter.com/frm1025/status/1161640994787536896, 
> javadoc of {{IndexCopier#waitForCopyCompletion}} shouldn't talk about false 
> return when the method returns void.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8587) Document feature vector similarity search

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8587.
---

> Document feature vector similarity search
> -
>
> Key: OAK-8587
> URL: https://issues.apache.org/jira/browse/OAK-8587
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: lucene
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>Priority: Major
> Fix For: 1.18.0
>
>
> Feature vector similarity search still needs documentation, see OAK-7575, 
> OAK-8118, OAK-7824, OAK-8119, OAK-7962.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8515) Make the Azure Persistence timeouts configurable

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8515.
---

> Make the Azure Persistence timeouts configurable
> 
>
> Key: OAK-8515
> URL: https://issues.apache.org/jira/browse/OAK-8515
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-azure
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.18.0
>
> Attachments: OAK-8515.patch
>
>
> OAK-8406 introduced timeout for the server-side execution in Azure cloud. 
> This may cause issues like this:
> {noformat}
> Exception in thread "main" java.util.NoSuchElementException: An error 
> occurred while enumerating the result, check the original exception for 
> details.
> at 
> com.microsoft.azure.storage.core.LazySegmentedIterator.hasNext(LazySegmentedIterator.java:113)
> at java.util.Iterator.forEachRemaining(Iterator.java:115)
> at 
> java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1801)
> at 
> java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
> at 
> java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
> at 
> java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
> at 
> java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
> at 
> java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
> at 
> org.apache.jackrabbit.oak.segment.azure.AzureSegmentArchiveReader.(AzureSegmentArchiveReader.java:61)
> at 
> org.apache.jackrabbit.oak.segment.azure.AzureArchiveManager.forceOpen(AzureArchiveManager.java:103)
> at 
> org.apache.jackrabbit.oak.segment.azure.tool.SegmentStoreMigrator.migrateArchives(SegmentStoreMigrator.java:149)
> at 
> org.apache.jackrabbit.oak.segment.azure.tool.SegmentStoreMigrator.migrate(SegmentStoreMigrator.java:87)
> [...]
> Caused by: com.microsoft.azure.storage.StorageException: The client could not 
> finish the operation within specified maximum execution timeout.
> at 
> com.microsoft.azure.storage.core.ExecutionEngine.executeWithRetry(ExecutionEngine.java:233)
> at 
> com.microsoft.azure.storage.core.LazySegmentedIterator.hasNext(LazySegmentedIterator.java:109)
> ... 14 more
> Caused by: java.util.concurrent.TimeoutException: The client could not finish 
> the operation within specified maximum execution timeout.
> at 
> com.microsoft.azure.storage.core.ExecutionEngine.executeWithRetry(ExecutionEngine.java:232)
> ... 15 more
> {noformat}
> Let's make the timeouts configurable.
> //cc: [~frm], [~ierandra]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8641) log uses of API methods to be removed as part of OAK-7358

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8641.
---

> log uses of API methods to be removed as part of OAK-7358
> -
>
> Key: OAK-8641
> URL: https://issues.apache.org/jira/browse/OAK-8641
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: security
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.18.0
>
> Attachments: OAK-8641-2.diff, OAK-8641-3.diff, OAK-8641.diff
>
>
> Start with DEBUG level, and start increasing log levels with subsequent OAK 
> releases. Make Log level configurable using system property 
> {{org.apache.jackrabbit.oak.spi.tools.AclGroupDeprecation.LOGLEVEL}} (for 
> instance, set it to "ERROR" to get maximum visibility).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8400) adjust baseline comparison version for oak-jackrabbit-api after release of 1.16.0

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8400.
---

> adjust baseline comparison version for oak-jackrabbit-api after release of 
> 1.16.0
> -
>
> Key: OAK-8400
> URL: https://issues.apache.org/jira/browse/OAK-8400
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: jackrabbit-api
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Blocker
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8566) Empty segment archives breaks the Azure Persistence

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8566.
---

> Empty segment archives breaks the Azure Persistence
> ---
>
> Key: OAK-8566
> URL: https://issues.apache.org/jira/browse/OAK-8566
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: segment-azure
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.18.0
>
>
> If we have a segment archive the valid {{.}} segment, it'll be 
> recovered into another invalid archive:
> {noformat}
> 21.08.2019 06:50:28.606 *INFO* [FelixStartLevel] 
> org.apache.jackrabbit.oak.segment.azure.AzureRepositoryLock Acquired lease 
> 1eaec54a-3e14-4705-8f94-2e43f3448cc9
> 21.08.2019 06:50:29.392 *WARN* [FelixStartLevel] 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader Could not read tar file 
> data00368a.tar, skipping...
> java.io.IOException: The archive data00368a.tar hasn't been closed correctly.
> at 
> org.apache.jackrabbit.oak.segment.azure.AzureArchiveManager.open(AzureArchiveManager.java:92)
>  [org.apache.jackrabbit.oak-segment-azure:1.16.0.R1864511]
> at 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader.openFirstFileWithValidIndex(TarReader.java:236)
>  [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> at 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader.open(TarReader.java:90) 
> [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> 21.08.2019 06:50:29.393 *WARN* [FelixStartLevel] 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader Could not find a valid 
> tar index in [data00368a.tar], recovering...
> 21.08.2019 06:50:29.393 *INFO* [FelixStartLevel] 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader Recovering segments from 
> tar file data00368a.tar
> 21.08.2019 06:50:32.219 *WARN* [FelixStartLevel] 
> org.apache.jackrabbit.oak.segment.azure.AzureSegmentArchiveReader Missing 
> entry .??? when recovering data00368a.tar. No more segments will be read.
> 21.08.2019 06:50:34.094 *INFO* [FelixStartLevel] 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader Backing up 
> data00368a.tar to data00368a.tar.2.bak
> 21.08.2019 06:50:42.328 *INFO* [FelixStartLevel] 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader Regenerating tar file 
> data00368a.tar
> 21.08.2019 06:50:42.369 *WARN* [FelixStartLevel] 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader Could not read tar file 
> data00368a.tar, skipping...
> java.io.IOException: The archive data00368a.tar hasn't been closed correctly.
> at 
> org.apache.jackrabbit.oak.segment.azure.AzureArchiveManager.open(AzureArchiveManager.java:92)
>  [org.apache.jackrabbit.oak-segment-azure:1.16.0.R1864511]
> at 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader.openFirstFileWithValidIndex(TarReader.java:236)
>  [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> at 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader.open(TarReader.java:106) 
> [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> 21.08.2019 06:50:42.370 *ERROR* [FelixStartLevel] 
> org.apache.jackrabbit.oak-segment-tar bundle 
> org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511 
> (144)[org.apache.jackrabbit.oak.segment.SegmentNodeStoreFactory(204)] : The 
> activate method has thrown an exception (java.io.IOException: Failed to open 
> recovered tar file data00368a.tar)
> java.io.IOException: Failed to open recovered tar file data00368a.tar
> at 
> org.apache.jackrabbit.oak.segment.file.tar.TarReader.open(TarReader.java:110) 
> [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> at 
> org.apache.jackrabbit.oak.segment.file.tar.TarFiles.(TarFiles.java:395) 
> [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> at 
> org.apache.jackrabbit.oak.segment.file.tar.TarFiles.(TarFiles.java:65) 
> [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> at 
> org.apache.jackrabbit.oak.segment.file.tar.TarFiles$Builder.build(TarFiles.java:213)
>  [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> at 
> org.apache.jackrabbit.oak.segment.file.FileStore.(FileStore.java:171) 
> [org.apache.jackrabbit.oak-segment-tar:1.16.0.R1864511]
> {noformat}
> We should cleanup the archives without the valid {{.}} segment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8625) oak-upgrade leaks empty test folders

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8625.
---

> oak-upgrade leaks empty test folders
> 
>
> Key: OAK-8625
> URL: https://issues.apache.org/jira/browse/OAK-8625
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: upgrade
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0
>
> Attachments: OAK-8625.diff
>
>
> This is because of using {{com.google.common.io.Files#createTempDir()}} 
> without cleanup up afterwards.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8575) Minimize network calls required when calling getRecord()

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8575.
---

> Minimize network calls required when calling getRecord()
> 
>
> Key: OAK-8575
> URL: https://issues.apache.org/jira/browse/OAK-8575
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob-cloud, blob-cloud-azure
>Affects Versions: 1.16.0, 1.10.4
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Major
> Fix For: 1.18.0
>
>
> The {{getRecord()}} method first checks existence of the blob and then 
> retrieves metadata to construct the resulting {{DataRecord}}.  If the call to 
> get metadata fails in a way we can handle if the blob does not exist, we can 
> skip the {{exists()}} call and just try to get the metadata, avoiding one 
> network API call.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8610) Pass the full blob name to the IOMonitor for Azure

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8610.
---

> Pass the full blob name to the IOMonitor for Azure
> --
>
> Key: OAK-8610
> URL: https://issues.apache.org/jira/browse/OAK-8610
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-azure
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8544) Nullable/Notnull Annotations for Authentication API

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8544.
---

> Nullable/Notnull Annotations for Authentication API
> ---
>
> Key: OAK-8544
> URL: https://issues.apache.org/jira/browse/OAK-8544
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: jackrabbit-api
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: 1.18.0
>
> Attachments: OAK-8544.patch
>
>
> subtasks for _org.apache.jackrabbit.api.security.authentication.*_ package 
> space, which currently only contains {{TokenCredentials}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8583) getNodeByIdentifier may fail with RuntimeException

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8583.
---

> getNodeByIdentifier may fail with RuntimeException
> --
>
> Key: OAK-8583
> URL: https://issues.apache.org/jira/browse/OAK-8583
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: jcr
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8604) Keep the last journal entry in metadata

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8604.
---

> Keep the last journal entry in metadata
> ---
>
> Key: OAK-8604
> URL: https://issues.apache.org/jira/browse/OAK-8604
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: segment-azure
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.18.0
>
>
> In the oak-segment-azure, reading the whole journal may be a time consuming 
> task, as the blob appends are a bit slow to read. We may try to keep the most 
> recent journal entry as a metadata and fall back to the actual blob contents 
> if the JournalReader.nextLine() is invoked subsequently.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8564) Add metric for MongoDB total and used disk space

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8564.
---

> Add metric for MongoDB total and used disk space
> 
>
> Key: OAK-8564
> URL: https://issues.apache.org/jira/browse/OAK-8564
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk, mongomk
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Minor
> Fix For: 1.18.0
>
>
> There are existing metrics collected by MongoDocumentStoreMetrics for 
> collection stats. Add two new metrics that track total and used disk space of 
> a MongoDB.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8547) Nullable/Notnull Annotations for Principal Management API

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8547.
---

> Nullable/Notnull Annotations for Principal Management API
> -
>
> Key: OAK-8547
> URL: https://issues.apache.org/jira/browse/OAK-8547
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: jackrabbit-api
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.18.0
>
> Attachments: OAK-8547-implementations.patch, OAK-8547.patch
>
>
> subtask for _org.apache.jackrabbit.api.security.principal_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8533) Rat plugin failure in oak-it-osgi

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8533.
---

> Rat plugin failure in oak-it-osgi
> -
>
> Key: OAK-8533
> URL: https://issues.apache.org/jira/browse/OAK-8533
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.18.0
>
>
> The build Jackrabbit Oak #2313 has failed.
> First failed run: [Jackrabbit Oak 
> #2313|https://builds.apache.org/job/Jackrabbit%20Oak/2313/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2313/console]
> Also, failed with
> The build Jackrabbit Oak #2314 has failed.
> First failed run: [Jackrabbit Oak 
> #2314|https://builds.apache.org/job/Jackrabbit%20Oak/2314/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2314/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8640) Allow to only copy last journal entry in the SegmentStoreMigrator

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8640.
---

> Allow to only copy last journal entry in the SegmentStoreMigrator
> -
>
> Key: OAK-8640
> URL: https://issues.apache.org/jira/browse/OAK-8640
> Project: Jackrabbit Oak
>  Issue Type: Story
>  Components: segment-azure
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Major
> Fix For: 1.18.0
>
>
> In the oak-segment-azure, reading the whole journal may be a time consuming 
> task, as the blob appends are a bit slow to read. The OAK-8604 introduces an 
> improvement, by keeping the most recent journal entry saved as a metadata in 
> the journal.log blob. We should allow to use this optimization in 
> SegmentStoreMigrator, by adding a new migration parameter - 
> {{onlyLastJournalEntry}}. This way, only the last entry in the journal will 
> be migrated and it won't require to read the whole journal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8513) Concurrent index access via CopyOnRead directory can lead to reading directly off of remote

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8513.
---

> Concurrent index access via CopyOnRead directory can lead to reading directly 
> off of remote
> ---
>
> Key: OAK-8513
> URL: https://issues.apache.org/jira/browse/OAK-8513
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Vikas Saurabh
>Assignee: Vikas Saurabh
>Priority: Major
> Fix For: 1.18.0
>
>
> Even with prefetch enabled having 2 CopyOnRead directories pointing to same 
> index can lead to one of the instance reading index files directly off of 
> remote index.
> The reason this happens is because {{COR#copyFilesToLocal}} explicitly 
> chooses to work with remote if index copier reports that a copy is in 
> progress.
> This wasn't a problem earlier when COR was only used via IndexTracker so 
> concurrent COR instances weren't expected (COR's avoid local for conc copy 
> was probably worried about non-prefetch case).
> But with OAK-8097, {{DefaultDirectoryFactory}} also uses COR to bring the 
> files. Which means that if there's a query against an index which is getting 
> updated as well then either of COR instance could read directly from remote.
> The condition should only be relevant during early app start up but since 
> this can happen in default configuration, we should attempt to fix this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8598) Update httpcore dependency to 4.4.12

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8598.
---

> Update httpcore dependency to 4.4.12
> 
>
> Key: OAK-8598
> URL: https://issues.apache.org/jira/browse/OAK-8598
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.18.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8638) Revert java 12 specific javadoc workaround

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8638.
---

> Revert java 12 specific javadoc workaround
> --
>
> Key: OAK-8638
> URL: https://issues.apache.org/jira/browse/OAK-8638
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Priority: Minor
> Fix For: 1.18.0
>
> Attachments: OAK-8638.diff
>
>
> With the arrival of Java 13, the workaround done for Java 12 (OAK-8149) can 
> be removed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8578) Introduce API to check whether blob inlined in Id

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8578.
---

> Introduce API to check whether blob inlined in Id
> -
>
> Key: OAK-8578
> URL: https://issues.apache.org/jira/browse/OAK-8578
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: blob-cloud, blob-cloud-azure
>Reporter: Amit Jain
>Assignee: Amit Jain
>Priority: Major
> Fix For: 1.18.0
>
>
> New API in blob to check whether blob inlined in Id. This will replace calls 
> to getReference which was used as a proxy to check whether blob inlined and 
> avoid remote calls to the backend (potentially expensive ones over cloud).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8603) Composite Node Store + Counter Index: allow indexing from scratch / reindex

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8603.
---

> Composite Node Store + Counter Index: allow indexing from scratch / reindex
> ---
>
> Key: OAK-8603
> URL: https://issues.apache.org/jira/browse/OAK-8603
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: composite, indexing
>Reporter: Terry Mueller
>Assignee: Vikas Saurabh
>Priority: Major
>  Labels: fabriziofortino
> Fix For: 1.18.0
>
> Attachments: OAK-8603.patch, OAK-8603_2.patch, OAK-8603_3_fix.patch, 
> OAK-8603_3_refactor.patch
>
>
> When using the composite node store with a read-only portion of the 
> repository, the counter index does not allow to index from scratch / reindex.
> Index from scratch is needed in case the async checkpoint is lost. Reindex is 
> started by setting the "reindex" flag to true.
> Currently the failure is:
> {noformat}
> 05.09.2019 09:29:21.892 *WARN* [async-index-update-async] 
> org.apache.jackrabbit.oak.plugins.index.AsyncIndexUpdate [async] The index 
> update is still failing
> java.lang.UnsupportedOperationException: This builder is read-only.
>   at 
> org.apache.jackrabbit.oak.spi.state.ReadOnlyBuilder.unsupported(ReadOnlyBuilder.java:44)
>  [org.apache.jackrabbit.oak-store-spi:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.spi.state.ReadOnlyBuilder.child(ReadOnlyBuilder.java:189)
>  [org.apache.jackrabbit.oak-store-spi:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.spi.state.ReadOnlyBuilder.child(ReadOnlyBuilder.java:34)
>  [org.apache.jackrabbit.oak-store-spi:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.getBuilder(NodeCounterEditor.java:184)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.leaveNew(NodeCounterEditor.java:162)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.plugins.index.counter.NodeCounterEditor.leave(NodeCounterEditor.java:114)
>  [org.apache.jackrabbit.oak-core:1.16.0.R1866113]
>   at 
> org.apache.jackrabbit.oak.spi.commit.CompositeEditor.leave(CompositeEditor.java:73)
>  [org.apache.jackrabbit.oak-store-spi:1.16.0.R1866113]
>   at 
> 

[jira] [Closed] (OAK-8574) Minimize network calls required when completing direct upload

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8574.
---

> Minimize network calls required when completing direct upload
> -
>
> Key: OAK-8574
> URL: https://issues.apache.org/jira/browse/OAK-8574
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: blob-cloud, blob-cloud-azure
>Affects Versions: 1.16.0, 1.10.4
>Reporter: Matt Ryan
>Assignee: Matt Ryan
>Priority: Major
> Fix For: 1.18.0
>
>
> The {{completeHttpUpload()}} in the cloud data store backends can be improved 
> in terms of quantity of cloud storage service API calls.
> Suggestions include:
>  * Try a single {{getRecord()}} call at the beginning instead of calling 
> {{exists()}}.  If an exception is thrown, catch it - this means the record 
> doesn't exist and can be written.  If a record is returned, we don't write - 
> and instead return this record.
>  * Don't check for existence after writing the record; instead assume that 
> the record is written correctly if no error or exception from SDK.  Verify 
> this behavior in unit tests.
>  * After writing the record, construct the record directly instead of calling 
> {{getRecord()}} to do it.
> This removes two network API calls if the record is written and one if the 
> record already exists.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8545) Nullable/Notnull Annotations for Authorization API

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8545.
---

> Nullable/Notnull Annotations for Authorization API
> --
>
> Key: OAK-8545
> URL: https://issues.apache.org/jira/browse/OAK-8545
> Project: Jackrabbit Oak
>  Issue Type: Sub-task
>  Components: jackrabbit-api
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: 1.18.0
>
> Attachments: OAK-8545-implementations.patch, OAK-8545.patch
>
>
> subtasks for _org.apache.jackrabbit.api.security_ and 
> _org.apache.jackrabbit.api.security.authorization_ package space.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8609) Make the MemoryNodeBuilder#isRoot() public

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8609.
---

> Make the MemoryNodeBuilder#isRoot() public
> --
>
> Key: OAK-8609
> URL: https://issues.apache.org/jira/browse/OAK-8609
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: store-spi
>Reporter: Tomek Rękawek
>Assignee: Tomek Rękawek
>Priority: Minor
> Fix For: 1.18.0
>
>
> The {{MemoryNodeBuilder#isRoot()}} method allows to check whether the given 
> builder is a root builder, which is required for the {{NodeStore#merge()}}. 
> Method should be public for customer, memory-based node store implementations.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8556) CugImporter.handleProperty: unreachable default handling for importBehavior

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8556.
---

> CugImporter.handleProperty: unreachable default handling for importBehavior
> ---
>
> Key: OAK-8556
> URL: https://issues.apache.org/jira/browse/OAK-8556
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: authorization-cug
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: 1.18.0
>
>
> depending on the configured importbehavior, {{CugImporter.handlePropInfo}} 
> behaves differently when the value refers to an unknown principal. however, 
> due to {{CugUtil.getImportBehavior}} the importbehavior will always be one of 
> the 3 predefined values, making the 'default' statement unreachable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OAK-8562) Improve cug tests

2019-09-30 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke closed OAK-8562.
---

> Improve cug tests
> -
>
> Key: OAK-8562
> URL: https://issues.apache.org/jira/browse/OAK-8562
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: authorization-cug
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: 1.18.0
>
>
> - drop usage of deprecated NodeUtil
> - improve coverage
> - ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >