[jira] [Created] (OAK-8740) Build Jackrabbit Oak #2479 failed

2019-11-01 Thread Hudson (Jira)
Hudson created OAK-8740:
---

 Summary: Build Jackrabbit Oak #2479 failed
 Key: OAK-8740
 URL: https://issues.apache.org/jira/browse/OAK-8740
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: continuous integration
Reporter: Hudson


No description is provided

The build Jackrabbit Oak #2479 has failed.
First failed run: [Jackrabbit Oak 
#2479|https://builds.apache.org/job/Jackrabbit%20Oak/2479/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2479/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7160) Update commons-codec dependency to 1.11

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7160:

Fix Version/s: 1.4.25

> Update commons-codec dependency to 1.11
> ---
>
> Key: OAK-7160
> URL: https://issues.apache.org/jira/browse/OAK-7160
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_4
> Fix For: 1.9.0, 1.10.0, 1.8.4, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-7160) Update commons-codec dependency to 1.11

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879670#comment-16879670
 ] 

Julian Reschke edited comment on OAK-7160 at 11/1/19 5:48 PM:
--

trunk: (1.9.0) [r1829534|http://svn.apache.org/r1829534] 
[r1821360|http://svn.apache.org/r1821360] 
[r1821221|http://svn.apache.org/r1821221]
1.8: (1.8.4) [r1832315|http://svn.apache.org/r1832315]
1.6: (1.6.18) [r1862658|http://svn.apache.org/r1862658]
1.4: [r1869273|http://svn.apache.org/r1869273]



was (Author: reschke):
trunk: (1.9.0) [r1829534|http://svn.apache.org/r1829534] 
[r1821360|http://svn.apache.org/r1821360] 
[r1821221|http://svn.apache.org/r1821221]
1.8: (1.8.4) [r1832315|http://svn.apache.org/r1832315]
1.6: [r1862658|http://svn.apache.org/r1862658]


> Update commons-codec dependency to 1.11
> ---
>
> Key: OAK-7160
> URL: https://issues.apache.org/jira/browse/OAK-7160
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.9.0, 1.10.0, 1.8.4, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8736) Build Jackrabbit Oak #2476 failed

2019-11-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16965007#comment-16965007
 ] 

Hudson commented on OAK-8736:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#2478|https://builds.apache.org/job/Jackrabbit%20Oak/2478/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2478/console]

> Build Jackrabbit Oak #2476 failed
> -
>
> Key: OAK-8736
> URL: https://issues.apache.org/jira/browse/OAK-8736
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2476 has failed.
> First failed run: [Jackrabbit Oak 
> #2476|https://builds.apache.org/job/Jackrabbit%20Oak/2476/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2476/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964852#comment-16964852
 ] 

Julian Reschke edited comment on OAK-8162 at 11/1/19 5:01 PM:
--

Backport to 1.10 was purely mechanical.

Will look at 1.8 once the next 1.10 release is out.


was (Author: reschke):
If it's purely mechanical, I can do it :-)

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: candidate_oak_1_8
> Fix For: 1.14.0, 1.10.6
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8739) Simplify ExternalLoginModule

2019-11-01 Thread Angela Schreiber (Jira)
Angela Schreiber created OAK-8739:
-

 Summary: Simplify ExternalLoginModule
 Key: OAK-8739
 URL: https://issues.apache.org/jira/browse/OAK-8739
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: auth-external
Reporter: Angela Schreiber
Assignee: Angela Schreiber


there is IMO some for improvement in {{ExternalLoginModule}} in terms of 
readability and code duplication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8162:

Fix Version/s: 1.10.6

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.14.0, 1.10.6
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8162:

Labels: candidate_oak_1_8  (was: candidate_oak_1_10 candidate_oak_1_8)

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: candidate_oak_1_8
> Fix For: 1.14.0, 1.10.6
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964928#comment-16964928
 ] 

Julian Reschke edited comment on OAK-8162 at 11/1/19 5:01 PM:
--

trunk: (1.14.0) [r1857996|http://svn.apache.org/r1857996]
1.10: [r1869270|http://svn.apache.org/r1869270]



was (Author: reschke):
trunk: (1.14.0) [r1857996|http://svn.apache.org/r1857996]

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: candidate_oak_1_8
> Fix For: 1.14.0, 1.10.6
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-8738) DefaultSyncContext: separate private method for conditional log output

2019-11-01 Thread Angela Schreiber (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved OAK-8738.
---
Resolution: Fixed

Committed revision 1869269.


> DefaultSyncContext: separate private method for conditional log output
> --
>
> Key: OAK-8738
> URL: https://issues.apache.org/jira/browse/OAK-8738
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: auth-external
>Reporter: Angela Schreiber
>Priority: Minor
> Fix For: 1.20.0
>
>
> the {{DefaultSyncContext}} contains quite some condition log output on DEBUG 
> level in the form of
> {code}
> if (log.isDebugEnabled()) {
> log.debug(mgs, objects);
> }
> {code}
> in order to improve readability of the code, i would move that to a private 
> method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8738) DefaultSyncContext: separate private method for conditional log output

2019-11-01 Thread Angela Schreiber (Jira)
Angela Schreiber created OAK-8738:
-

 Summary: DefaultSyncContext: separate private method for 
conditional log output
 Key: OAK-8738
 URL: https://issues.apache.org/jira/browse/OAK-8738
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: auth-external
Reporter: Angela Schreiber
 Fix For: 1.20.0


the {{DefaultSyncContext}} contains quite some condition log output on DEBUG 
level in the form of

{code}
if (log.isDebugEnabled()) {
log.debug(mgs, objects);
}
{code}

in order to improve readability of the code, i would move that to a private 
method.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-8737) Extract SyncConfigTracker and SyncHandlerMappingTracker from ExternalPrincipalConfiguration

2019-11-01 Thread Angela Schreiber (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Angela Schreiber resolved OAK-8737.
---
Resolution: Fixed

Committed revision 1869267.


> Extract SyncConfigTracker and SyncHandlerMappingTracker from 
> ExternalPrincipalConfiguration
> ---
>
> Key: OAK-8737
> URL: https://issues.apache.org/jira/browse/OAK-8737
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: auth-external
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Trivial
> Fix For: 1.20.0
>
>
> simplify {{ExternalPrincipalConfiguration}} by extracting the inner classes 
> {{SyncConfigTracker}} and {{SyncHandlerMappingTracker}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-7579) remove obsolete findbugs reference from reactor pom

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603086#comment-16603086
 ] 

Julian Reschke edited comment on OAK-7579 at 11/1/19 4:43 PM:
--

trunk: (1.9.5) [r1834117|http://svn.apache.org/r1834117]
1.8: (1.8.8) [r1840045|http://svn.apache.org/r1840045]
1.6: (1.6.18) [r1862738|http://svn.apache.org/r1862738]
1.4: [r1869265|http://svn.apache.org/r1869265]



was (Author: reschke):
trunk: (1.9.5) [r1834117|http://svn.apache.org/r1834117]
1.8: (1.8.8) [r1840045|http://svn.apache.org/r1840045]
1.6: [r1862738|http://svn.apache.org/r1862738]


> remove obsolete findbugs reference from reactor pom
> ---
>
> Key: OAK-7579
> URL: https://issues.apache.org/jira/browse/OAK-7579
> Project: Jackrabbit Oak
>  Issue Type: Task
>Affects Versions: 1.10.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.10.0, 1.9.5, 1.8.8, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7579) remove obsolete findbugs reference from reactor pom

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7579:

Fix Version/s: 1.4.25

> remove obsolete findbugs reference from reactor pom
> ---
>
> Key: OAK-7579
> URL: https://issues.apache.org/jira/browse/OAK-7579
> Project: Jackrabbit Oak
>  Issue Type: Task
>Affects Versions: 1.10.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>  Labels: candidate_oak_1_4
> Fix For: 1.10.0, 1.9.5, 1.8.8, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7579) remove obsolete findbugs reference from reactor pom

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7579:

Labels:   (was: candidate_oak_1_4)

> remove obsolete findbugs reference from reactor pom
> ---
>
> Key: OAK-7579
> URL: https://issues.apache.org/jira/browse/OAK-7579
> Project: Jackrabbit Oak
>  Issue Type: Task
>Affects Versions: 1.10.0
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.10.0, 1.9.5, 1.8.8, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8737) Extract SyncConfigTracker and SyncHandlerMappingTracker from ExternalPrincipalConfiguration

2019-11-01 Thread Angela Schreiber (Jira)
Angela Schreiber created OAK-8737:
-

 Summary: Extract SyncConfigTracker and SyncHandlerMappingTracker 
from ExternalPrincipalConfiguration
 Key: OAK-8737
 URL: https://issues.apache.org/jira/browse/OAK-8737
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: auth-external
Reporter: Angela Schreiber
Assignee: Angela Schreiber
 Fix For: 1.20.0


simplify {{ExternalPrincipalConfiguration}} by extracting the inner classes 
{{SyncConfigTracker}} and {{SyncHandlerMappingTracker}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964928#comment-16964928
 ] 

Julian Reschke commented on OAK-8162:
-

trunk: (1.14.0) [r1857996|http://svn.apache.org/r1857996]

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.14.0
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8725) Improve tests for oak-external-auth

2019-11-01 Thread Angela Schreiber (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963877#comment-16963877
 ] 

Angela Schreiber edited comment on OAK-8725 at 11/1/19 3:33 PM:


Committed revision 1869208.
Committed revision 1869241.
Committed revision 1869242.
Committed revision 1869264.





was (Author: anchela):
Committed revision 1869208.
Committed revision 1869241.
Committed revision 1869242.



> Improve tests for oak-external-auth
> ---
>
> Key: OAK-8725
> URL: https://issues.apache.org/jira/browse/OAK-8725
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: auth-external
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>
> equivalent to OAK-8320 for all packages in _oak-auth-external_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7586) Update bundle plugin to 3.5.0

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7586:

Labels:   (was: candidate_oak_1_4)

> Update bundle plugin to 3.5.0
> -
>
> Key: OAK-7586
> URL: https://issues.apache.org/jira/browse/OAK-7586
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.10.0, 1.9.5, 1.8.13, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-7583) oak-examples/webapp: update jetty-maven-plugin dependency

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605329#comment-16605329
 ] 

Julian Reschke edited comment on OAK-7583 at 11/1/19 3:32 PM:
--

trunk: (1.9.5) [r1834291|http://svn.apache.org/r1834291]
1.10: (1.9.5) [r1834291|http://svn.apache.org/r1834291]
1.8: (1.8.8) [r1840183|http://svn.apache.org/r1840183]
1.6: (1.6.18) [r1862793|http://svn.apache.org/r1862793]
1.4: [r1869263|http://svn.apache.org/r1869263]



was (Author: reschke):
trunk: (1.9.5) [r1834291|http://svn.apache.org/r1834291]
1.8: (1.8.8) [r1840183|http://svn.apache.org/r1840183]
1.6: [r1862793|http://svn.apache.org/r1862793]


> oak-examples/webapp: update jetty-maven-plugin dependency
> -
>
> Key: OAK-7583
> URL: https://issues.apache.org/jira/browse/OAK-7583
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: examples
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.10.0, 1.9.5, 1.8.8, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7583) oak-examples/webapp: update jetty-maven-plugin dependency

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7583:

Labels:   (was: candidate_oak_1_4)

> oak-examples/webapp: update jetty-maven-plugin dependency
> -
>
> Key: OAK-7583
> URL: https://issues.apache.org/jira/browse/OAK-7583
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: examples
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.10.0, 1.9.5, 1.8.8, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7583) oak-examples/webapp: update jetty-maven-plugin dependency

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7583:

Fix Version/s: 1.4.25

> oak-examples/webapp: update jetty-maven-plugin dependency
> -
>
> Key: OAK-7583
> URL: https://issues.apache.org/jira/browse/OAK-7583
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: examples
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_4
> Fix For: 1.10.0, 1.9.5, 1.8.8, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-7581) oak-examples: remove special case for failsafe plugin

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605255#comment-16605255
 ] 

Julian Reschke edited comment on OAK-7581 at 11/1/19 2:43 PM:
--

trunk: (1.9.5) [r1834287|http://svn.apache.org/r1834287]
1.8: (1.8.8) [r1840178|http://svn.apache.org/r1840178]
1.6: (1.6.18) [r1862739|http://svn.apache.org/r1862739]
1.4: [r1869262|http://svn.apache.org/r1869262]



was (Author: reschke):
trunk: (1.9.5) [r1834287|http://svn.apache.org/r1834287]
1.8: (1.8.8) [r1840178|http://svn.apache.org/r1840178]
1.6: [r1862739|http://svn.apache.org/r1862739]


> oak-examples: remove special case for failsafe plugin
> -
>
> Key: OAK-7581
> URL: https://issues.apache.org/jira/browse/OAK-7581
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: examples
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.10.0, 1.9.7, 1.8.8, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8736) Build Jackrabbit Oak #2476 failed

2019-11-01 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964859#comment-16964859
 ] 

Hudson commented on OAK-8736:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit Oak 
#2477|https://builds.apache.org/job/Jackrabbit%20Oak/2477/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2477/console]

> Build Jackrabbit Oak #2476 failed
> -
>
> Key: OAK-8736
> URL: https://issues.apache.org/jira/browse/OAK-8736
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit Oak #2476 has failed.
> First failed run: [Jackrabbit Oak 
> #2476|https://builds.apache.org/job/Jackrabbit%20Oak/2476/] [console 
> log|https://builds.apache.org/job/Jackrabbit%20Oak/2476/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7581) oak-examples: remove special case for failsafe plugin

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7581:

Labels:   (was: candidate_oak_1_4)

> oak-examples: remove special case for failsafe plugin
> -
>
> Key: OAK-7581
> URL: https://issues.apache.org/jira/browse/OAK-7581
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: examples
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.10.0, 1.9.7, 1.8.8, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7581) oak-examples: remove special case for failsafe plugin

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7581:

Fix Version/s: 1.4.25

> oak-examples: remove special case for failsafe plugin
> -
>
> Key: OAK-7581
> URL: https://issues.apache.org/jira/browse/OAK-7581
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: examples
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_4
> Fix For: 1.10.0, 1.9.7, 1.8.8, 1.4.25, 1.6.18
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964852#comment-16964852
 ] 

Julian Reschke commented on OAK-8162:
-

If it's purely mechanical, I can do it :-)

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.14.0
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-7886) Re-registering node type may corrupt registry

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872114#comment-16872114
 ] 

Julian Reschke edited comment on OAK-7886 at 11/1/19 1:31 PM:
--

trunk: (1.9.11) [r1846162|http://svn.apache.org/r1846162] 
[r1846057|http://svn.apache.org/r1846057]
1.10: (1.9.11) [r1846162|http://svn.apache.org/r1846162] 
[r1846057|http://svn.apache.org/r1846057]
1.8: (1.8.14) [r1862036|http://svn.apache.org/r1862036] (1.8.10) 
[r1846170|http://svn.apache.org/r1846170]
1.6: (1.6.18) [r1862820|http://svn.apache.org/r1862820] (1.6.15) 
[r1846171|http://svn.apache.org/r1846171]
1.4: [r1869256|http://svn.apache.org/r1869256] (1.4.24) 
[r1846175|http://svn.apache.org/r1846175]
1.2: (1.2.31) [r1846176|http://svn.apache.org/r1846176]
1.0: [r1846177|http://svn.apache.org/r1846177]




was (Author: reschke):
trunk: (1.9.11) [r1846162|http://svn.apache.org/r1846162] 
[r1846057|http://svn.apache.org/r1846057]
1.10: (1.9.11) [r1846162|http://svn.apache.org/r1846162] 
[r1846057|http://svn.apache.org/r1846057]
1.8: (1.8.14) [r1862036|http://svn.apache.org/r1862036] (1.8.10) 
[r1846170|http://svn.apache.org/r1846170]
1.6: (1.6.18) [r1862820|http://svn.apache.org/r1862820] (1.6.15) 
[r1846171|http://svn.apache.org/r1846171]
1.4: [r1869256|http://svn.apache.org/r1869256] (1.4.24) 
[r1846175|http://svn.apache.org/r1846175]


> Re-registering node type may corrupt registry
> -
>
> Key: OAK-7886
> URL: https://issues.apache.org/jira/browse/OAK-7886
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.0, 1.2, 1.4.0, 1.6.0, 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.10.0, 1.9.11, 1.4.25, 1.6.18, 1.8.14
>
> Attachments: OAK-7886.patch
>
>
> Re-registering an existing node type may corrupt the registry. This happens 
> for node types that are not mixins and do not extend from other primary types 
> (except for the implicit {{nt:base}}). After re-registering such a node type 
> the {{jcr:supertypes}} list does not have the {{nt:base}} anymore.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-7886) Re-registering node type may corrupt registry

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872114#comment-16872114
 ] 

Julian Reschke edited comment on OAK-7886 at 11/1/19 1:30 PM:
--

trunk: (1.9.11) [r1846162|http://svn.apache.org/r1846162] 
[r1846057|http://svn.apache.org/r1846057]
1.10: (1.9.11) [r1846162|http://svn.apache.org/r1846162] 
[r1846057|http://svn.apache.org/r1846057]
1.8: (1.8.14) [r1862036|http://svn.apache.org/r1862036] (1.8.10) 
[r1846170|http://svn.apache.org/r1846170]
1.6: (1.6.18) [r1862820|http://svn.apache.org/r1862820] (1.6.15) 
[r1846171|http://svn.apache.org/r1846171]
1.4: [r1869256|http://svn.apache.org/r1869256] (1.4.24) 
[r1846175|http://svn.apache.org/r1846175]



was (Author: reschke):
trunk: (1.9.11) [r1846162|http://svn.apache.org/r1846162] 
[r1846057|http://svn.apache.org/r1846057]
1.8: (1.8.14) [r1862036|http://svn.apache.org/r1862036] (1.8.10) 
[r1846170|http://svn.apache.org/r1846170]
1.6: (1.6.18) [r1862820|http://svn.apache.org/r1862820] (1.6.15) 
[r1846171|http://svn.apache.org/r1846171]
1.4: (1.4.24) [r1846175|http://svn.apache.org/r1846175]
1.2: (1.2.31) [r1846176|http://svn.apache.org/r1846176]
1.0: [r1846177|http://svn.apache.org/r1846177]


> Re-registering node type may corrupt registry
> -
>
> Key: OAK-7886
> URL: https://issues.apache.org/jira/browse/OAK-7886
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.0, 1.2, 1.4.0, 1.6.0, 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.10.0, 1.9.11, 1.4.25, 1.6.18, 1.8.14
>
> Attachments: OAK-7886.patch
>
>
> Re-registering an existing node type may corrupt the registry. This happens 
> for node types that are not mixins and do not extend from other primary types 
> (except for the implicit {{nt:base}}). After re-registering such a node type 
> the {{jcr:supertypes}} list does not have the {{nt:base}} anymore.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7886) Re-registering node type may corrupt registry

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7886:

Labels: candidate_oak_1_0 candidate_oak_1_2  (was: candidate_oak_1_0 
candidate_oak_1_2 candidate_oak_1_4)

> Re-registering node type may corrupt registry
> -
>
> Key: OAK-7886
> URL: https://issues.apache.org/jira/browse/OAK-7886
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.0, 1.2, 1.4.0, 1.6.0, 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.10.0, 1.9.11, 1.4.25, 1.6.18, 1.8.14
>
> Attachments: OAK-7886.patch
>
>
> Re-registering an existing node type may corrupt the registry. This happens 
> for node types that are not mixins and do not extend from other primary types 
> (except for the implicit {{nt:base}}). After re-registering such a node type 
> the {{jcr:supertypes}} list does not have the {{nt:base}} anymore.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7886) Re-registering node type may corrupt registry

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7886:

Fix Version/s: 1.4.25

> Re-registering node type may corrupt registry
> -
>
> Key: OAK-7886
> URL: https://issues.apache.org/jira/browse/OAK-7886
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.0, 1.2, 1.4.0, 1.6.0, 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10.0, 1.9.11, 1.4.25, 1.6.18, 1.8.14
>
> Attachments: OAK-7886.patch
>
>
> Re-registering an existing node type may corrupt the registry. This happens 
> for node types that are not mixins and do not extend from other primary types 
> (except for the implicit {{nt:base}}). After re-registering such a node type 
> the {{jcr:supertypes}} list does not have the {{nt:base}} anymore.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Thomas Mueller (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964823#comment-16964823
 ] 

Thomas Mueller commented on OAK-8162:
-

[~reschke] you are right, it would be good to backport this to Oak 1.10 and 
1.8. I don't think Oak 1.6 is needed, as it doesn't support index tags. Do you 
want me to do this?

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.14.0
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Thomas Mueller (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller updated OAK-8162:

Labels: candidate_oak_1_10 candidate_oak_1_8  (was: )

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
>  Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.14.0
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Thomas Mueller (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller updated OAK-8162:

Affects Version/s: (was: 1.6.18)

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.14.0
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8162) When query with OR is divided into union of queries, options (like index tag) are not passed into subqueries.

2019-11-01 Thread Thomas Mueller (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller updated OAK-8162:

Affects Version/s: 1.6.18
   1.8.17

> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries. 
> --
>
> Key: OAK-8162
> URL: https://issues.apache.org/jira/browse/OAK-8162
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.10.2, 1.6.18, 1.8.17
>Reporter: Piotr Tajduś
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.14.0
>
>
> When query with OR is divided into union of queries, options (like index tag) 
> are not passed into subqueries - in effect alternative query  sometimes f.e. 
> uses indexes it shouldn't use.
>  {noformat}
> org.apache.jackrabbit.oak.query.QueryImpl.buildAlternativeQuery()
> org.apache.jackrabbit.oak.query.QueryImpl.copyOf()
>  
> 2019-03-21 16:32:25,600 DEBUG 
> [org.apache.jackrabbit.oak.query.QueryEngineImpl] (default task-1) Parsing 
> JCR-SQL2 statement: select distinct d.* from [crkid:document] as d where 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AX' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') or 
> ([d].[metadane/inneMetadane/*/wartosc] = 'AB' and 
> [d].[metadane/inneMetadane/*/klucz] = 'InnyKod') option(index tag 
> crkid_dokument_month_2019_3)
> 2019-03-21 16:32:25,607 DEBUG [org.apache.jackrabbit.oak.query.QueryImpl] 
> (default task-1) cost using filter Filter(query=select distinct d.* from 
> [crkid:document] as d where ([d].[metadane/inneMetadane/*/wartosc] = 'AB') 
> and ([d].[metadane/inneMetadane/*/klucz] = 'InnyKod'), path=*, 
> property=[metadane/inneMetadane/*/klucz=[InnyKod], 
> metadane/inneMetadane/*/wartosc=[AB]])
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964783#comment-16964783
 ] 

Julian Reschke edited comment on OAK-8735 at 11/1/19 1:08 PM:
--

trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]
1.8: [r1869247|http://svn.apache.org/r1869247]
1.6: [r1869248|http://svn.apache.org/r1869248]
1.4: [r1869250|http://svn.apache.org/r1869250]
1.2: [r1869251|http://svn.apache.org/r1869251]
1.0: [r1869252|http://svn.apache.org/r1869252]



was (Author: reschke):
trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]
1.8: [r1869247|http://svn.apache.org/r1869247]
1.6: [r1869248|http://svn.apache.org/r1869248]
1.4: [r1869250|http://svn.apache.org/r1869250]
1.2: [r1869251|http://svn.apache.org/r1869251]


> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.43, 1.4.25, 1.2.32, 1.20.0, 1.8.18, 1.10.6, 1.6.19
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Fix Version/s: 1.0.43

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.0.43, 1.4.25, 1.2.32, 1.20.0, 1.8.18, 1.10.6, 1.6.19
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964783#comment-16964783
 ] 

Julian Reschke edited comment on OAK-8735 at 11/1/19 12:58 PM:
---

trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]
1.8: [r1869247|http://svn.apache.org/r1869247]
1.6: [r1869248|http://svn.apache.org/r1869248]
1.4: [r1869250|http://svn.apache.org/r1869250]
1.2: [r1869251|http://svn.apache.org/r1869251]



was (Author: reschke):
trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]
1.8: [r1869247|http://svn.apache.org/r1869247]
1.6: [r1869248|http://svn.apache.org/r1869248]
1.4: [r1869250|http://svn.apache.org/r1869250]


> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.4.25, 1.2.32, 1.20.0, 1.8.18, 1.10.6, 1.6.19
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Fix Version/s: 1.2.32

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.4.25, 1.2.32, 1.20.0, 1.8.18, 1.10.6, 1.6.19
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964783#comment-16964783
 ] 

Julian Reschke edited comment on OAK-8735 at 11/1/19 12:45 PM:
---

trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]
1.8: [r1869247|http://svn.apache.org/r1869247]
1.6: [r1869248|http://svn.apache.org/r1869248]
1.4: [r1869250|http://svn.apache.org/r1869250]



was (Author: reschke):
trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]
1.8: [r1869247|http://svn.apache.org/r1869247]
1.6: [r1869248|http://svn.apache.org/r1869248]


> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.4.25, 1.20.0, 1.8.18, 1.10.6, 1.6.19
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Fix Version/s: 1.4.25

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.4.25, 1.20.0, 1.8.18, 1.10.6, 1.6.19
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-7886) Re-registering node type may corrupt registry

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16872114#comment-16872114
 ] 

Julian Reschke edited comment on OAK-7886 at 11/1/19 12:36 PM:
---

trunk: (1.9.11) [r1846162|http://svn.apache.org/r1846162] 
[r1846057|http://svn.apache.org/r1846057]
1.8: (1.8.14) [r1862036|http://svn.apache.org/r1862036] (1.8.10) 
[r1846170|http://svn.apache.org/r1846170]
1.6: (1.6.18) [r1862820|http://svn.apache.org/r1862820] (1.6.15) 
[r1846171|http://svn.apache.org/r1846171]
1.4: (1.4.24) [r1846175|http://svn.apache.org/r1846175]
1.2: (1.2.31) [r1846176|http://svn.apache.org/r1846176]
1.0: [r1846177|http://svn.apache.org/r1846177]



was (Author: reschke):
trunk: (1.9.11) [r1846162|http://svn.apache.org/r1846162] 
[r1846057|http://svn.apache.org/r1846057]
1.8: (1.8.14) [r1862036|http://svn.apache.org/r1862036] (1.8.10) 
[r1846170|http://svn.apache.org/r1846170]
1.6: [r1862820|http://svn.apache.org/r1862820] (1.6.15) 
[r1846171|http://svn.apache.org/r1846171]
1.4: (1.4.24) [r1846175|http://svn.apache.org/r1846175]
1.2: (1.2.31) [r1846176|http://svn.apache.org/r1846176]
1.0: [r1846177|http://svn.apache.org/r1846177]


> Re-registering node type may corrupt registry
> -
>
> Key: OAK-7886
> URL: https://issues.apache.org/jira/browse/OAK-7886
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.0, 1.2, 1.4.0, 1.6.0, 1.8.0
>Reporter: Marcel Reutegger
>Assignee: Marcel Reutegger
>Priority: Major
>  Labels: candidate_oak_1_0, candidate_oak_1_2, candidate_oak_1_4
> Fix For: 1.10.0, 1.9.11, 1.6.18, 1.8.14
>
> Attachments: OAK-7886.patch
>
>
> Re-registering an existing node type may corrupt the registry. This happens 
> for node types that are not mixins and do not extend from other primary types 
> (except for the implicit {{nt:base}}). After re-registering such a node type 
> the {{jcr:supertypes}} list does not have the {{nt:base}} anymore.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-7833) oak-examples/webapp: update groovy dependency

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797242#comment-16797242
 ] 

Julian Reschke edited comment on OAK-7833 at 11/1/19 12:33 PM:
---

trunk: (1.9.9) [r1843905|http://svn.apache.org/r1843905]
1.8: (1.8.13) [r1855913|http://svn.apache.org/r1855913]
1.6: (1.6.18) [r1862936|http://svn.apache.org/r1862936]
1.4: [r1869249|http://svn.apache.org/r1869249]



was (Author: reschke):
trunk: (1.9.9) [r1843905|http://svn.apache.org/r1843905]
1.8: (1.8.13) [r1855913|http://svn.apache.org/r1855913]
1.6: [r1862936|http://svn.apache.org/r1862936]


> oak-examples/webapp: update groovy dependency
> -
>
> Key: OAK-7833
> URL: https://issues.apache.org/jira/browse/OAK-7833
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: examples
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.10.0, 1.9.10, 1.4.25, 1.8.13, 1.6.18
>
>
> Currently 2.3.6, but see https://www.cvedetails.com/cve/CVE-2016-6814/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7833) oak-examples/webapp: update groovy dependency

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7833:

Labels:   (was: candidate_oak_1_4)

> oak-examples/webapp: update groovy dependency
> -
>
> Key: OAK-7833
> URL: https://issues.apache.org/jira/browse/OAK-7833
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: examples
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.10.0, 1.9.10, 1.4.25, 1.8.13, 1.6.18
>
>
> Currently 2.3.6, but see https://www.cvedetails.com/cve/CVE-2016-6814/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-7833) oak-examples/webapp: update groovy dependency

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-7833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-7833:

Fix Version/s: 1.4.25

> oak-examples/webapp: update groovy dependency
> -
>
> Key: OAK-7833
> URL: https://issues.apache.org/jira/browse/OAK-7833
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: examples
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_4
> Fix For: 1.10.0, 1.9.10, 1.4.25, 1.8.13, 1.6.18
>
>
> Currently 2.3.6, but see https://www.cvedetails.com/cve/CVE-2016-6814/



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964783#comment-16964783
 ] 

Julian Reschke edited comment on OAK-8735 at 11/1/19 12:29 PM:
---

trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]
1.8: [r1869247|http://svn.apache.org/r1869247]
1.6: [r1869248|http://svn.apache.org/r1869248]



was (Author: reschke):
trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]
1.8: [r1869247|http://svn.apache.org/r1869247]


> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0, 1.8.18, 1.10.6, 1.6.19
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Fix Version/s: 1.6.19

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0, 1.8.18, 1.10.6, 1.6.19
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8736) Build Jackrabbit Oak #2476 failed

2019-11-01 Thread Hudson (Jira)
Hudson created OAK-8736:
---

 Summary: Build Jackrabbit Oak #2476 failed
 Key: OAK-8736
 URL: https://issues.apache.org/jira/browse/OAK-8736
 Project: Jackrabbit Oak
  Issue Type: Bug
  Components: continuous integration
Reporter: Hudson


No description is provided

The build Jackrabbit Oak #2476 has failed.
First failed run: [Jackrabbit Oak 
#2476|https://builds.apache.org/job/Jackrabbit%20Oak/2476/] [console 
log|https://builds.apache.org/job/Jackrabbit%20Oak/2476/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964783#comment-16964783
 ] 

Julian Reschke edited comment on OAK-8735 at 11/1/19 12:12 PM:
---

trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]
1.8: [r1869247|http://svn.apache.org/r1869247]



was (Author: reschke):
trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]


> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0, 1.8.18, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Labels:   (was: candidate_oak_1_8)

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0, 1.8.18, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Fix Version/s: 1.8.18

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.20.0, 1.8.18, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Labels: candidate_oak_1_8  (was: )

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_8
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964783#comment-16964783
 ] 

Julian Reschke edited comment on OAK-8735 at 11/1/19 12:02 PM:
---

trunk: [r1869245|http://svn.apache.org/r1869245]
1.10: [r1869246|http://svn.apache.org/r1869246]



was (Author: reschke):
trunk: [r1869245|http://svn.apache.org/r1869245]

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Labels:   (was: candidate_oak_1_10)

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Fix Version/s: 1.10.6

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.20.0, 1.10.6
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Labels: candidate_oak_1_10  (was: )

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_10
> Fix For: 1.20.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964783#comment-16964783
 ] 

Julian Reschke commented on OAK-8735:
-

trunk: [r1869245|http://svn.apache.org/r1869245]

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved OAK-8735.
-
Fix Version/s: 1.20.0
   Resolution: Fixed

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.20.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version and use https

2019-11-01 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-8735:

Summary: Jackrabbit Javadoc link should be consistent with used 
jackrabbit.version and use https  (was: Jackrabbit Javadoc link should be 
consistent with used jackrabbit.version)

> Jackrabbit Javadoc link should be consistent with used jackrabbit.version and 
> use https
> ---
>
> Key: OAK-8735
> URL: https://issues.apache.org/jira/browse/OAK-8735
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8735) Jackrabbit Javadoc link should be consistent with used jackrabbit.version

2019-11-01 Thread Julian Reschke (Jira)
Julian Reschke created OAK-8735:
---

 Summary: Jackrabbit Javadoc link should be consistent with used 
jackrabbit.version
 Key: OAK-8735
 URL: https://issues.apache.org/jira/browse/OAK-8735
 Project: Jackrabbit Oak
  Issue Type: Improvement
  Components: parent
Reporter: Julian Reschke
Assignee: Julian Reschke






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8673) Determine and possibly adjust size of eagerCacheSize

2019-11-01 Thread Thomas Mueller (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964764#comment-16964764
 ] 

Thomas Mueller commented on OAK-8673:
-

> 0 should be possible can run those in addition

I would probably do that, and check if it really works as expected (the cache 
is really empty). Or maybe hardcode some logic that means if 0, then don't use 
the cache (might be a bit hard).

> the lazy-loading doesn't seems to have a beneficial effect (except for 
> reading really few items, which in AEM is rarely the case)

Do you assume that with a small EagerCacheSize, lazy loading isn't used at all? 
I don't know the code, but it sounds like it's better to somehow disable the 
lazy loading logic, in order to be sure it's not used by some unexpected code 
path.

> Determine and possibly adjust size of eagerCacheSize
> 
>
> Key: OAK-8673
> URL: https://issues.apache.org/jira/browse/OAK-8673
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: core, security
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>
> The initial results of the {{EagerCacheSizeTest}} seem to indicate that we 
> almost never benefit from the lazy permission evaluation (compared to reading 
> all permission entries right away). From my understanding of the results the 
> only exception are those cases where only very few items are being accessed 
> (e.g. reading 100 items).
> However, I am not totally sure if this is not a artifact of the random-read. 
> I therefore started extending the benchmark with an option to re-read a 
> randomly picked item more that once, which according to some analysis done 
> quite some time ago is a common scenario specially when using Oak in 
> combination with Apache Sling.
> Result are attached to OAK-8662 (possibly more to come).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8725) Improve tests for oak-external-auth

2019-11-01 Thread Angela Schreiber (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963877#comment-16963877
 ] 

Angela Schreiber edited comment on OAK-8725 at 11/1/19 10:28 AM:
-

Committed revision 1869208.
Committed revision 1869241.
Committed revision 1869242.




was (Author: anchela):
Committed revision 1869208.
Committed revision 1869241.


> Improve tests for oak-external-auth
> ---
>
> Key: OAK-8725
> URL: https://issues.apache.org/jira/browse/OAK-8725
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: auth-external
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>
> equivalent to OAK-8320 for all packages in _oak-auth-external_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-8725) Improve tests for oak-external-auth

2019-11-01 Thread Angela Schreiber (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16963877#comment-16963877
 ] 

Angela Schreiber edited comment on OAK-8725 at 11/1/19 10:23 AM:
-

Committed revision 1869208.
Committed revision 1869241.



was (Author: anchela):
Committed revision 1869208.


> Improve tests for oak-external-auth
> ---
>
> Key: OAK-8725
> URL: https://issues.apache.org/jira/browse/OAK-8725
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: auth-external
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>
> equivalent to OAK-8320 for all packages in _oak-auth-external_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8673) Determine and possibly adjust size of eagerCacheSize

2019-11-01 Thread Angela Schreiber (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964747#comment-16964747
 ] 

Angela Schreiber commented on OAK-8673:
---

[~thomasm], 0 should be possible can run those in addition. but what IMO 
already seem apparent in the existing runs is that with bigger number of access 
control entries the lazy-loading doesn't seems to have a beneficial effect 
(except for reading really few items, which in AEM is rarely the case). i would 
have rather expected some sort of optimum/threshold.

> Determine and possibly adjust size of eagerCacheSize
> 
>
> Key: OAK-8673
> URL: https://issues.apache.org/jira/browse/OAK-8673
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: core, security
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>
> The initial results of the {{EagerCacheSizeTest}} seem to indicate that we 
> almost never benefit from the lazy permission evaluation (compared to reading 
> all permission entries right away). From my understanding of the results the 
> only exception are those cases where only very few items are being accessed 
> (e.g. reading 100 items).
> However, I am not totally sure if this is not a artifact of the random-read. 
> I therefore started extending the benchmark with an option to re-read a 
> randomly picked item more that once, which according to some analysis done 
> quite some time ago is a common scenario specially when using Oak in 
> combination with Apache Sling.
> Result are attached to OAK-8662 (possibly more to come).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8729) Lucene Directory concurrency issue

2019-11-01 Thread Thomas Mueller (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964741#comment-16964741
 ] 

Thomas Mueller commented on OAK-8729:
-

I tried writing a special test case, but it is not easy... I could sometimes 
reproduce the issue, but only if the existing test is run many times, and only 
when instrumenting the MemoryNodeBuilder.

> Lucene Directory concurrency issue
> --
>
> Key: OAK-8729
> URL: https://issues.apache.org/jira/browse/OAK-8729
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Affects Versions: 1.12.0, 1.14.0, 1.16.0, 1.18.0
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: OAK-8729.patch
>
>
> There is a concurrency issue in the DefaultDirectoryFactory. It is 
> reproducible sometimes using CopyOnWriteDirectoryTest.copyOnWrite(), if run 
> in a loop (1000 times). The problem is that the MemoryNodeBuilder is used 
> concurrently:
> * thread 1 is closing the directory (after writing to it)
> * thread 2 is trying to create a new file
> {noformat}
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setProperty(MemoryNodeBuilder.java:525)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.close(OakDirectory.java:264)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.close(BufferedOakDirectory.java:217)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory$2.run(CopyOnReadDirectory.java:305)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:362)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:356)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.child(MemoryNodeBuilder.java:342)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.createOutput(OakDirectory.java:214)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.createOutput(BufferedOakDirectory.java:178)
>   at org.apache.lucene.store.Directory.copy(Directory.java:184)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:322)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:1)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:105)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:1)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8729) Lucene Directory concurrency issue

2019-11-01 Thread Thomas Mueller (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964739#comment-16964739
 ] 

Thomas Mueller commented on OAK-8729:
-

Attached a patch for review, [~catholicon] [~nitigupt][~tihom88].

> Lucene Directory concurrency issue
> --
>
> Key: OAK-8729
> URL: https://issues.apache.org/jira/browse/OAK-8729
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Affects Versions: 1.12.0, 1.14.0, 1.16.0, 1.18.0
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: OAK-8729.patch
>
>
> There is a concurrency issue in the DefaultDirectoryFactory. It is 
> reproducible sometimes using CopyOnWriteDirectoryTest.copyOnWrite(), if run 
> in a loop (1000 times). The problem is that the MemoryNodeBuilder is used 
> concurrently:
> * thread 1 is closing the directory (after writing to it)
> * thread 2 is trying to create a new file
> {noformat}
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setProperty(MemoryNodeBuilder.java:525)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.close(OakDirectory.java:264)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.close(BufferedOakDirectory.java:217)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory$2.run(CopyOnReadDirectory.java:305)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:362)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:356)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.child(MemoryNodeBuilder.java:342)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.createOutput(OakDirectory.java:214)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.createOutput(BufferedOakDirectory.java:178)
>   at org.apache.lucene.store.Directory.copy(Directory.java:184)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:322)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:1)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:105)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:1)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8729) Lucene Directory concurrency issue

2019-11-01 Thread Thomas Mueller (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller updated OAK-8729:

Attachment: OAK-8729.patch

> Lucene Directory concurrency issue
> --
>
> Key: OAK-8729
> URL: https://issues.apache.org/jira/browse/OAK-8729
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Affects Versions: 1.12.0, 1.14.0, 1.16.0, 1.18.0
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.20.0
>
> Attachments: OAK-8729.patch
>
>
> There is a concurrency issue in the DefaultDirectoryFactory. It is 
> reproducible sometimes using CopyOnWriteDirectoryTest.copyOnWrite(), if run 
> in a loop (1000 times). The problem is that the MemoryNodeBuilder is used 
> concurrently:
> * thread 1 is closing the directory (after writing to it)
> * thread 2 is trying to create a new file
> {noformat}
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setProperty(MemoryNodeBuilder.java:525)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.close(OakDirectory.java:264)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.close(BufferedOakDirectory.java:217)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory$2.run(CopyOnReadDirectory.java:305)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:362)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:356)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.child(MemoryNodeBuilder.java:342)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.createOutput(OakDirectory.java:214)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.createOutput(BufferedOakDirectory.java:178)
>   at org.apache.lucene.store.Directory.copy(Directory.java:184)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:322)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:1)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:105)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:1)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8729) Lucene Directory concurrency issue

2019-11-01 Thread Thomas Mueller (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller updated OAK-8729:

Affects Version/s: 1.12.0
   1.14.0
   1.16.0
   1.18.0

> Lucene Directory concurrency issue
> --
>
> Key: OAK-8729
> URL: https://issues.apache.org/jira/browse/OAK-8729
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Affects Versions: 1.12.0, 1.14.0, 1.16.0, 1.18.0
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
>
> There is a concurrency issue in the DefaultDirectoryFactory. It is 
> reproducible sometimes using CopyOnWriteDirectoryTest.copyOnWrite(), if run 
> in a loop (1000 times). The problem is that the MemoryNodeBuilder is used 
> concurrently:
> * thread 1 is closing the directory (after writing to it)
> * thread 2 is trying to create a new file
> {noformat}
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setProperty(MemoryNodeBuilder.java:525)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.close(OakDirectory.java:264)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.close(BufferedOakDirectory.java:217)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory$2.run(CopyOnReadDirectory.java:305)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:362)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:356)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.child(MemoryNodeBuilder.java:342)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.createOutput(OakDirectory.java:214)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.createOutput(BufferedOakDirectory.java:178)
>   at org.apache.lucene.store.Directory.copy(Directory.java:184)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:322)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:1)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:105)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:1)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8729) Lucene Directory concurrency issue

2019-11-01 Thread Thomas Mueller (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller updated OAK-8729:

Fix Version/s: 1.20.0

> Lucene Directory concurrency issue
> --
>
> Key: OAK-8729
> URL: https://issues.apache.org/jira/browse/OAK-8729
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Affects Versions: 1.12.0, 1.14.0, 1.16.0, 1.18.0
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.20.0
>
>
> There is a concurrency issue in the DefaultDirectoryFactory. It is 
> reproducible sometimes using CopyOnWriteDirectoryTest.copyOnWrite(), if run 
> in a loop (1000 times). The problem is that the MemoryNodeBuilder is used 
> concurrently:
> * thread 1 is closing the directory (after writing to it)
> * thread 2 is trying to create a new file
> {noformat}
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setProperty(MemoryNodeBuilder.java:525)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.close(OakDirectory.java:264)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.close(BufferedOakDirectory.java:217)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory$2.run(CopyOnReadDirectory.java:305)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:362)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:356)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.child(MemoryNodeBuilder.java:342)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.createOutput(OakDirectory.java:214)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.createOutput(BufferedOakDirectory.java:178)
>   at org.apache.lucene.store.Directory.copy(Directory.java:184)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:322)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:1)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:105)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:1)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OAK-8729) Lucene Directory concurrency issue

2019-11-01 Thread Thomas Mueller (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Mueller reassigned OAK-8729:
---

Assignee: Thomas Mueller

> Lucene Directory concurrency issue
> --
>
> Key: OAK-8729
> URL: https://issues.apache.org/jira/browse/OAK-8729
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: lucene
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
>
> There is a concurrency issue in the DefaultDirectoryFactory. It is 
> reproducible sometimes using CopyOnWriteDirectoryTest.copyOnWrite(), if run 
> in a loop (1000 times). The problem is that the MemoryNodeBuilder is used 
> concurrently:
> * thread 1 is closing the directory (after writing to it)
> * thread 2 is trying to create a new file
> {noformat}
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setProperty(MemoryNodeBuilder.java:525)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.close(OakDirectory.java:264)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.close(BufferedOakDirectory.java:217)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnReadDirectory$2.run(CopyOnReadDirectory.java:305)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.exists(MemoryNodeBuilder.java:284)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:362)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.setChildNode(MemoryNodeBuilder.java:356)
>   at 
> org.apache.jackrabbit.oak.plugins.memory.MemoryNodeBuilder.child(MemoryNodeBuilder.java:342)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.OakDirectory.createOutput(OakDirectory.java:214)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.BufferedOakDirectory.createOutput(BufferedOakDirectory.java:178)
>   at org.apache.lucene.store.Directory.copy(Directory.java:184)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:322)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$3.call(CopyOnWriteDirectory.java:1)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:105)
>   at 
> org.apache.jackrabbit.oak.plugins.index.lucene.directory.CopyOnWriteDirectory$2$1.call(CopyOnWriteDirectory.java:1)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8673) Determine and possibly adjust size of eagerCacheSize

2019-11-01 Thread Thomas Mueller (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964729#comment-16964729
 ] 

Thomas Mueller commented on OAK-8673:
-

> the threshold to move from eagerly-loading all permission entries to lazy 
> loading is defined by the EagerCacheSize.

So, maybe test with EagerCacheSize = 0, or (if that's not possible) 1?

> Determine and possibly adjust size of eagerCacheSize
> 
>
> Key: OAK-8673
> URL: https://issues.apache.org/jira/browse/OAK-8673
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: core, security
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>
> The initial results of the {{EagerCacheSizeTest}} seem to indicate that we 
> almost never benefit from the lazy permission evaluation (compared to reading 
> all permission entries right away). From my understanding of the results the 
> only exception are those cases where only very few items are being accessed 
> (e.g. reading 100 items).
> However, I am not totally sure if this is not a artifact of the random-read. 
> I therefore started extending the benchmark with an option to re-read a 
> randomly picked item more that once, which according to some analysis done 
> quite some time ago is a common scenario specially when using Oak in 
> combination with Apache Sling.
> Result are attached to OAK-8662 (possibly more to come).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8673) Determine and possibly adjust size of eagerCacheSize

2019-11-01 Thread Angela Schreiber (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964727#comment-16964727
 ] 

Angela Schreiber commented on OAK-8673:
---

[~thomasm], yes sort of except for the fact that there is currently no way 
to completely disable the lazy-evaluation mechanism altogether the 
threshold to move from eagerly-loading all permission entries to lazy loading 
is defined by the {{EagerCacheSize}}. that's why the result contain series of 
increasing number of access control entries, number of principals and 
cache-size.

i will take a closer look at the results from repeated-read again today and 
compare it to the totally random reading as repeated-reading will benefit from 
the map in the {{DefaultPermissionCache}}, whereas totally random reading might 
in the worst case never hit that map (while always reading from the cached 
entries as long as eager-cache-size is not reached.

> Determine and possibly adjust size of eagerCacheSize
> 
>
> Key: OAK-8673
> URL: https://issues.apache.org/jira/browse/OAK-8673
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: core, security
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>
> The initial results of the {{EagerCacheSizeTest}} seem to indicate that we 
> almost never benefit from the lazy permission evaluation (compared to reading 
> all permission entries right away). From my understanding of the results the 
> only exception are those cases where only very few items are being accessed 
> (e.g. reading 100 items).
> However, I am not totally sure if this is not a artifact of the random-read. 
> I therefore started extending the benchmark with an option to re-read a 
> randomly picked item more that once, which according to some analysis done 
> quite some time ago is a common scenario specially when using Oak in 
> combination with Apache Sling.
> Result are attached to OAK-8662 (possibly more to come).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-8718) LuceneIndexStatsUpdateCallback is slow and synchronous which leads to slowness

2019-11-01 Thread Mohit Kataria (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mohit Kataria updated OAK-8718:
---
Fix Version/s: 1.10.6

> LuceneIndexStatsUpdateCallback is slow and synchronous which leads to slowness
> --
>
> Key: OAK-8718
> URL: https://issues.apache.org/jira/browse/OAK-8718
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: indexing
>Reporter: Mohit Kataria
>Assignee: Mohit Kataria
>Priority: Major
> Fix For: 1.20.0, 1.10.6
>
> Attachments: OAK-8718.patch
>
>
> LuceneIndexStatsUpdateCallback is slow and  synchronous which lead to 
> slowness.
> Resolution:
> Make this callback to be executed only in asyncIndexUpdate and also make this 
> configurable
> i.e. call only if  previous call + currentTime > configured time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8673) Determine and possibly adjust size of eagerCacheSize

2019-11-01 Thread Thomas Mueller (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964711#comment-16964711
 ] 

Thomas Mueller commented on OAK-8673:
-

> we almost never benefit from the lazy permission evaluation (compared to 
> reading all permission entries right away). 

Just to make sure: It sounds like "lazy permission evaluation disabled" means 
"reading all permission entries right away"... right? And then it sounds like 
you consider disabling lazy permission evaluation?

Which benchmark results show data for "lazy permission evaluation disabled", 
and which results show results for "lazy permission evaluation enabled"? I only 
see different settings for 

* Items to Read
* Repeat Read
* Number of ACEs
* Number of Principals
* EagerCacheSize


> Determine and possibly adjust size of eagerCacheSize
> 
>
> Key: OAK-8673
> URL: https://issues.apache.org/jira/browse/OAK-8673
> Project: Jackrabbit Oak
>  Issue Type: Technical task
>  Components: core, security
>Reporter: Angela Schreiber
>Assignee: Angela Schreiber
>Priority: Major
>
> The initial results of the {{EagerCacheSizeTest}} seem to indicate that we 
> almost never benefit from the lazy permission evaluation (compared to reading 
> all permission entries right away). From my understanding of the results the 
> only exception are those cases where only very few items are being accessed 
> (e.g. reading 100 items).
> However, I am not totally sure if this is not a artifact of the random-read. 
> I therefore started extending the benchmark with an option to re-read a 
> randomly picked item more that once, which according to some analysis done 
> quite some time ago is a common scenario specially when using Oak in 
> combination with Apache Sling.
> Result are attached to OAK-8662 (possibly more to come).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OAK-8734) Sorted query with multiple path restrictions and sorting performs very slowly if one of the passed paths is a traversal

2019-11-01 Thread Nitin Gupta (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Gupta reassigned OAK-8734:


Assignee: Nitin Gupta

> Sorted query with multiple path restrictions and sorting performs very slowly 
> if one of the passed paths is a traversal 
> 
>
> Key: OAK-8734
> URL: https://issues.apache.org/jira/browse/OAK-8734
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
>
> A query like [1] with multiple path restrictions and an order can be 
> extremely slow .
>  * Removing the orderby makes it much faste.
>  * Removing one path will make it faster.
> The issue appears to be that, as soon as one path-restricred subquery is not 
> handled at the index (ie its a traversal, since the cost of traversal on an 
> empty path is 0), it appears that the entire sorting happens in the query 
> engine which makes the query very very slow if there are lots of items (and 
> defeats optimisations like guessTotal which prevent iteration / inflation of 
> the complete result set). 
>  [1]
> {code:java}
> (
>   /jcr:root/content/dam/products//element(*, dam:Asset)
> |
>   /jcr:root/content/dam/projects//element(*, dam:Asset))
>   order by jcr:content/@jcr:lastModified descendin
> )
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OAK-8734) Sorted query with multiple path restrictions and sorting performs very slowly if one of the passed paths is a traversal

2019-11-01 Thread Nitin Gupta (Jira)
Nitin Gupta created OAK-8734:


 Summary: Sorted query with multiple path restrictions and sorting 
performs very slowly if one of the passed paths is a traversal 
 Key: OAK-8734
 URL: https://issues.apache.org/jira/browse/OAK-8734
 Project: Jackrabbit Oak
  Issue Type: Bug
Reporter: Nitin Gupta


A query like [1] with multiple path restrictions and an order can be extremely 
slow .
 * Removing the orderby makes it much faste.
 * Removing one path will make it faster.

The issue appears to be that, as soon as one path-restricred subquery is not 
handled at the index (ie its a traversal, since the cost of traversal on an 
empty path is 0), it appears that the entire sorting happens in the query 
engine which makes the query very very slow if there are lots of items (and 
defeats optimisations like guessTotal which prevent iteration / inflation of 
the complete result set). 
 [1]
{code:java}
(
  /jcr:root/content/dam/products//element(*, dam:Asset)
|
  /jcr:root/content/dam/projects//element(*, dam:Asset))
  order by jcr:content/@jcr:lastModified descendin
)
{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-8710) AbstractLoginModule#logout() may fail in the presence of unknown principals

2019-11-01 Thread Angela Schreiber (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16964675#comment-16964675
 ] 

Angela Schreiber commented on OAK-8710:
---

[~baedke], I don't think this is correct. If you look at the principal 
interfaces defined just with Oak you will notice that not all of them are 
{{JackrabbitPrincipal}}. IMO this assumption is not accurate. However, given 
your comment above and the given the fact that {{AbstractLoginModule}} actually 
has methods for {{getCredentials}} and {{getPrincipals}}, we already have the 
basic functionality in place to actually know the credentials/principals that 
have been used for the login/commit. Having said that, I feel that the fix 
needs a bit of a broader effort, as we probably don't want to re-calculate 
either of them... I will think about a solution.

Also, I still think the test case you provided above is not properly reflecting 
the scenario you are describing. So, I think there is some additional effort 
needed on the testing side as well.

> AbstractLoginModule#logout() may fail in the presence of unknown principals
> ---
>
> Key: OAK-8710
> URL: https://issues.apache.org/jira/browse/OAK-8710
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: security-spi
>Reporter: Manfred Baedke
>Priority: Major
>
> See 
> https://github.com/apache/jackrabbit-oak/blob/9569d659f0655d3ba16c1cfe1fbb5f53959f701f/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/AbstractLoginModule.java#L189:
> The criterion for logout() to succeed is
> {code}!subject.getPrincipals().isEmpty() && 
> !subject.getPublicCredentials(Credentials.class).isEmpty(){code}
> This did not work in a case where the subject was created by a thread 
> handling an authenticated JMX connection (and later passed on to other 
> threads due to AccessControlContext inheritage).
> I'd propose to make logout() succeed unconditionally, but I'm not entirely 
> sure about side effects.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)