[jira] [Reopened] (OAK-8737) Extract SyncConfigTracker and SyncHandlerMappingTracker from ExternalPrincipalConfiguration
[
https://issues.apache.org/jira/browse/OAK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke reopened OAK-8737:
-
Assignee: Julian Reschke (was: Angela Schreiber)
Rat check failing:
[WARNING] Files with unapproved licenses:
src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/SyncConfigTracker.java
src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/SyncHandlerMappingTracker.java
> Extract SyncConfigTracker and SyncHandlerMappingTracker from
> ExternalPrincipalConfiguration
> ---
>
> Key: OAK-8737
> URL: https://issues.apache.org/jira/browse/OAK-8737
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
>Reporter: Angela Schreiber
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.20.0
>
>
> simplify {{ExternalPrincipalConfiguration}} by extracting the inner classes
> {{SyncConfigTracker}} and {{SyncHandlerMappingTracker}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8737) Extract SyncConfigTracker and SyncHandlerMappingTracker from ExternalPrincipalConfiguration
[
https://issues.apache.org/jira/browse/OAK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965294#comment-16965294
]
Julian Reschke commented on OAK-8737:
-
trunk: [r1869267|http://svn.apache.org/r1869267]
> Extract SyncConfigTracker and SyncHandlerMappingTracker from
> ExternalPrincipalConfiguration
> ---
>
> Key: OAK-8737
> URL: https://issues.apache.org/jira/browse/OAK-8737
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
>Reporter: Angela Schreiber
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.20.0
>
>
> simplify {{ExternalPrincipalConfiguration}} by extracting the inner classes
> {{SyncConfigTracker}} and {{SyncHandlerMappingTracker}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (OAK-8737) Extract SyncConfigTracker and SyncHandlerMappingTracker from ExternalPrincipalConfiguration
[
https://issues.apache.org/jira/browse/OAK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved OAK-8737.
-
Resolution: Fixed
(license added)
> Extract SyncConfigTracker and SyncHandlerMappingTracker from
> ExternalPrincipalConfiguration
> ---
>
> Key: OAK-8737
> URL: https://issues.apache.org/jira/browse/OAK-8737
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
>Reporter: Angela Schreiber
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.20.0
>
>
> simplify {{ExternalPrincipalConfiguration}} by extracting the inner classes
> {{SyncConfigTracker}} and {{SyncHandlerMappingTracker}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Issue Comment Deleted] (OAK-8737) Extract SyncConfigTracker and SyncHandlerMappingTracker from ExternalPrincipalConfiguration
[
https://issues.apache.org/jira/browse/OAK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8737:
Comment: was deleted
(was: trunk: [r1869267|http://svn.apache.org/r1869267])
> Extract SyncConfigTracker and SyncHandlerMappingTracker from
> ExternalPrincipalConfiguration
> ---
>
> Key: OAK-8737
> URL: https://issues.apache.org/jira/browse/OAK-8737
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
>Reporter: Angela Schreiber
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.20.0
>
>
> simplify {{ExternalPrincipalConfiguration}} by extracting the inner classes
> {{SyncConfigTracker}} and {{SyncHandlerMappingTracker}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-8737) Extract SyncConfigTracker and SyncHandlerMappingTracker from ExternalPrincipalConfiguration
[
https://issues.apache.org/jira/browse/OAK-8737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965301#comment-16965301
]
Julian Reschke commented on OAK-8737:
-
trunk: [r1869289|http://svn.apache.org/r1869289]
[r1869267|http://svn.apache.org/r1869267]
> Extract SyncConfigTracker and SyncHandlerMappingTracker from
> ExternalPrincipalConfiguration
> ---
>
> Key: OAK-8737
> URL: https://issues.apache.org/jira/browse/OAK-8737
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
>Reporter: Angela Schreiber
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.20.0
>
>
> simplify {{ExternalPrincipalConfiguration}} by extracting the inner classes
> {{SyncConfigTracker}} and {{SyncHandlerMappingTracker}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8376) update commons-codec dependency to 1.12
[ https://issues.apache.org/jira/browse/OAK-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8376: Fix Version/s: 1.6.19 > update commons-codec dependency to 1.12 > --- > > Key: OAK-8376 > URL: https://issues.apache.org/jira/browse/OAK-8376 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_4 > Fix For: 1.10.3, 1.14.0, 1.6.18, 1.8.14, 1.6.19 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8376) update commons-codec dependency to 1.12
[ https://issues.apache.org/jira/browse/OAK-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8376: Labels: (was: candidate_oak_1_4) > update commons-codec dependency to 1.12 > --- > > Key: OAK-8376 > URL: https://issues.apache.org/jira/browse/OAK-8376 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.10.3, 1.14.0, 1.6.18, 1.8.14, 1.6.19 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8376) update commons-codec dependency to 1.12
[ https://issues.apache.org/jira/browse/OAK-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16863446#comment-16863446 ] Julian Reschke edited comment on OAK-8376 at 11/2/19 10:25 AM: --- trunk: (1.14.0) [r1860548|http://svn.apache.org/r1860548] 1.10: (1.10.3) [r1861299|http://svn.apache.org/r1861299] 1.8: (1.8.14) [r1861940|http://svn.apache.org/r1861940] 1.6: (1.6.18) [r1862662|http://svn.apache.org/r1862662] 1.4: [r1869290|http://svn.apache.org/r1869290] was (Author: reschke): trunk: (1.14.0) [r1860548|http://svn.apache.org/r1860548] 1.10: (1.10.3) [r1861299|http://svn.apache.org/r1861299] 1.8: (1.8.14) [r1861940|http://svn.apache.org/r1861940] 1.6: [r1862662|http://svn.apache.org/r1862662] > update commons-codec dependency to 1.12 > --- > > Key: OAK-8376 > URL: https://issues.apache.org/jira/browse/OAK-8376 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.10.3, 1.14.0, 1.6.18, 1.8.14, 1.6.19 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8740) Build Jackrabbit Oak #2479 failed
[ https://issues.apache.org/jira/browse/OAK-8740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16965319#comment-16965319 ] Hudson commented on OAK-8740: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #2480|https://builds.apache.org/job/Jackrabbit%20Oak/2480/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/2480/console] > Build Jackrabbit Oak #2479 failed > - > > Key: OAK-8740 > URL: https://issues.apache.org/jira/browse/OAK-8740 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #2479 has failed. > First failed run: [Jackrabbit Oak > #2479|https://builds.apache.org/job/Jackrabbit%20Oak/2479/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/2479/console] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8016) RDBDocumentStore: minor improvements to GZIP compression of BLOB contents
[ https://issues.apache.org/jira/browse/OAK-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8016: Fix Version/s: 1.4.25 > RDBDocumentStore: minor improvements to GZIP compression of BLOB contents > - > > Key: OAK-8016 > URL: https://issues.apache.org/jira/browse/OAK-8016 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_4 > Fix For: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.6.18 > > > 1. Ensure GZIPOutputStream is closed in the unlikely event of error when > writing to ByteArrayOutputStream > 2. Optionally log sizes and ratios > 3. Slightly improve initial size estimate for ByteArrayOutputStream -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8016) RDBDocumentStore: minor improvements to GZIP compression of BLOB contents
[ https://issues.apache.org/jira/browse/OAK-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8016: Labels: (was: candidate_oak_1_4) > RDBDocumentStore: minor improvements to GZIP compression of BLOB contents > - > > Key: OAK-8016 > URL: https://issues.apache.org/jira/browse/OAK-8016 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.6.18 > > > 1. Ensure GZIPOutputStream is closed in the unlikely event of error when > writing to ByteArrayOutputStream > 2. Optionally log sizes and ratios > 3. Slightly improve initial size estimate for ByteArrayOutputStream -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8016) RDBDocumentStore: minor improvements to GZIP compression of BLOB contents
[ https://issues.apache.org/jira/browse/OAK-8016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757303#comment-16757303 ] Julian Reschke edited comment on OAK-8016 at 11/2/19 3:27 PM: -- trunk: (1.12.0) [r1852601|http://svn.apache.org/r1852601] 1.10: (1.10.1) [r1854060|http://svn.apache.org/r1854060] 1.8: (1.8.13) [r1855837|http://svn.apache.org/r1855837] 1.6: (1.6.18) [r1862925|http://svn.apache.org/r1862925] 1.4: [r1869294|http://svn.apache.org/r1869294] was (Author: reschke): trunk: (1.12.0) [r1852601|http://svn.apache.org/r1852601] 1.10: (1.10.1) [r1854060|http://svn.apache.org/r1854060] 1.8: (1.8.13) [r1855837|http://svn.apache.org/r1855837] 1.6: [r1862925|http://svn.apache.org/r1862925] > RDBDocumentStore: minor improvements to GZIP compression of BLOB contents > - > > Key: OAK-8016 > URL: https://issues.apache.org/jira/browse/OAK-8016 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.12.0, 1.4.25, 1.10.1, 1.8.13, 1.6.18 > > > 1. Ensure GZIPOutputStream is closed in the unlikely event of error when > writing to ByteArrayOutputStream > 2. Optionally log sizes and ratios > 3. Slightly improve initial size estimate for ByteArrayOutputStream -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-7272) improve BackgroundLeaseUpdate warning messages
[
https://issues.apache.org/jira/browse/OAK-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7272:
Labels: (was: candidate_oak_1_4)
> improve BackgroundLeaseUpdate warning messages
> --
>
> Key: OAK-7272
> URL: https://issues.apache.org/jira/browse/OAK-7272
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.13, 1.4.25
>
> Attachments: OAK-7272.diff, OAK-7272.diff
>
>
> Example for current logging:
> {noformat}
> *WARN* [DocumentNodeStore lease update thread (1)]
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore
> BackgroundLeaseUpdate.execute: time since last renewClusterIdLease() call
> longer than expected: 5338ms
> {noformat}
> Source:
> {noformat}
> @Override
> protected void execute(@Nonnull DocumentNodeStore nodeStore) {
> // OAK-4859 : keep track of invocation time of renewClusterIdLease
> // and warn if time since last call is longer than 5sec
> final long now = System.currentTimeMillis();
> if (lastRenewClusterIdLeaseCall <= 0) {
> lastRenewClusterIdLeaseCall = now;
> } else {
> final long diff = now - lastRenewClusterIdLeaseCall;
> if (diff > 5000) {
> LOG.warn("BackgroundLeaseUpdate.execute: time since last
> renewClusterIdLease() call longer than expected: {}ms", diff);
> }
> lastRenewClusterIdLeaseCall = now;
> }
> // first renew the clusterId lease
> nodeStore.renewClusterIdLease();
> }
> {noformat}
> Observations:
> - the warning message doesn't actually say what the expected delay is
> - we only log when it's exceeded by factor 5
> - the threshold is hardwired; it should be computed based on the actual
> config (I think)
> Also:
> - we don't measure the time of the actual update operation, so we don't know
> whether it's a thread scheduling problem or a persistence problem (again, I
> think)
> [~stefanegli], [~mreutegg] - feedback appreciated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-7272) improve BackgroundLeaseUpdate warning messages
[
https://issues.apache.org/jira/browse/OAK-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-7272:
Fix Version/s: 1.4.25
> improve BackgroundLeaseUpdate warning messages
> --
>
> Key: OAK-7272
> URL: https://issues.apache.org/jira/browse/OAK-7272
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_4
> Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.13, 1.4.25
>
> Attachments: OAK-7272.diff, OAK-7272.diff
>
>
> Example for current logging:
> {noformat}
> *WARN* [DocumentNodeStore lease update thread (1)]
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore
> BackgroundLeaseUpdate.execute: time since last renewClusterIdLease() call
> longer than expected: 5338ms
> {noformat}
> Source:
> {noformat}
> @Override
> protected void execute(@Nonnull DocumentNodeStore nodeStore) {
> // OAK-4859 : keep track of invocation time of renewClusterIdLease
> // and warn if time since last call is longer than 5sec
> final long now = System.currentTimeMillis();
> if (lastRenewClusterIdLeaseCall <= 0) {
> lastRenewClusterIdLeaseCall = now;
> } else {
> final long diff = now - lastRenewClusterIdLeaseCall;
> if (diff > 5000) {
> LOG.warn("BackgroundLeaseUpdate.execute: time since last
> renewClusterIdLease() call longer than expected: {}ms", diff);
> }
> lastRenewClusterIdLeaseCall = now;
> }
> // first renew the clusterId lease
> nodeStore.renewClusterIdLease();
> }
> {noformat}
> Observations:
> - the warning message doesn't actually say what the expected delay is
> - we only log when it's exceeded by factor 5
> - the threshold is hardwired; it should be computed based on the actual
> config (I think)
> Also:
> - we don't measure the time of the actual update operation, so we don't know
> whether it's a thread scheduling problem or a persistence problem (again, I
> think)
> [~stefanegli], [~mreutegg] - feedback appreciated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OAK-7272) improve BackgroundLeaseUpdate warning messages
[
https://issues.apache.org/jira/browse/OAK-7272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16553827#comment-16553827
]
Julian Reschke edited comment on OAK-7272 at 11/2/19 5:40 PM:
--
trunk: (1.9.0) [r1825065|http://svn.apache.org/r1825065]
1.8: (1.8.4) [r1832241|http://svn.apache.org/r1832241]
1.6: (1.6.13) [r1836528|http://svn.apache.org/r1836528]
1.4: [r1869299|http://svn.apache.org/r1869299]
was (Author: reschke):
trunk: (1.9.0) [r1825065|http://svn.apache.org/r1825065]
1.8: (1.8.4) [r1832241|http://svn.apache.org/r1832241]
1.6: (1.6.13) [r1836528|http://svn.apache.org/r1836528]
> improve BackgroundLeaseUpdate warning messages
> --
>
> Key: OAK-7272
> URL: https://issues.apache.org/jira/browse/OAK-7272
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.9.0, 1.10.0, 1.8.4, 1.6.13, 1.4.25
>
> Attachments: OAK-7272.diff, OAK-7272.diff
>
>
> Example for current logging:
> {noformat}
> *WARN* [DocumentNodeStore lease update thread (1)]
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore
> BackgroundLeaseUpdate.execute: time since last renewClusterIdLease() call
> longer than expected: 5338ms
> {noformat}
> Source:
> {noformat}
> @Override
> protected void execute(@Nonnull DocumentNodeStore nodeStore) {
> // OAK-4859 : keep track of invocation time of renewClusterIdLease
> // and warn if time since last call is longer than 5sec
> final long now = System.currentTimeMillis();
> if (lastRenewClusterIdLeaseCall <= 0) {
> lastRenewClusterIdLeaseCall = now;
> } else {
> final long diff = now - lastRenewClusterIdLeaseCall;
> if (diff > 5000) {
> LOG.warn("BackgroundLeaseUpdate.execute: time since last
> renewClusterIdLease() call longer than expected: {}ms", diff);
> }
> lastRenewClusterIdLeaseCall = now;
> }
> // first renew the clusterId lease
> nodeStore.renewClusterIdLease();
> }
> {noformat}
> Observations:
> - the warning message doesn't actually say what the expected delay is
> - we only log when it's exceeded by factor 5
> - the threshold is hardwired; it should be computed based on the actual
> config (I think)
> Also:
> - we don't measure the time of the actual update operation, so we don't know
> whether it's a thread scheduling problem or a persistence problem (again, I
> think)
> [~stefanegli], [~mreutegg] - feedback appreciated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
