[jira] [Created] (OAK-8781) Add debug logs before and after cache purge to get the uploadCache size info
Ankita Agarwal created OAK-8781: --- Summary: Add debug logs before and after cache purge to get the uploadCache size info Key: OAK-8781 URL: https://issues.apache.org/jira/browse/OAK-8781 Project: Jackrabbit Oak Issue Type: Bug Reporter: Ankita Agarwal Add debug logs before and after cache purge to get the uploadCache size info -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8780) Remove the synchronized block on the FSBackend
Ankita Agarwal created OAK-8780: --- Summary: Remove the synchronized block on the FSBackend Key: OAK-8780 URL: https://issues.apache.org/jira/browse/OAK-8780 Project: Jackrabbit Oak Issue Type: Bug Reporter: Ankita Agarwal Initial upload requests are all within 5sec. Once the upload staging cache is getting filled up the response time of upload request gets degraded. Only one thread at a time is runnable and rest remains in blocked state after upload staging cache fills up -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8776) Build Jackrabbit Oak #2504 failed
[ https://issues.apache.org/jira/browse/OAK-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979372#comment-16979372 ] Hudson commented on OAK-8776: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #2508|https://builds.apache.org/job/Jackrabbit%20Oak/2508/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/2508/console] > Build Jackrabbit Oak #2504 failed > - > > Key: OAK-8776 > URL: https://issues.apache.org/jira/browse/OAK-8776 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #2504 has failed. > First failed run: [Jackrabbit Oak > #2504|https://builds.apache.org/job/Jackrabbit%20Oak/2504/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/2504/console] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8763) LoginContextProviderImpl uses any subject found in the AccessControlContext.
[ https://issues.apache.org/jira/browse/OAK-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979352#comment-16979352 ] Manfred Baedke commented on OAK-8763: - [~angela], Please find attached two test cases. #testLoginLogoutPreexistingSubject() verifies that ContentSessionImpl#close() does not log an exception. #testLoginNullCredentialsPreexistingSubject() verifies that a login with null credentials will fail. Both tests will fail with the current trunk. > LoginContextProviderImpl uses any subject found in the AccessControlContext. > > > Key: OAK-8763 > URL: https://issues.apache.org/jira/browse/OAK-8763 > Project: Jackrabbit Oak > Issue Type: Bug > Components: security-spi >Reporter: Manfred Baedke >Assignee: Angela Schreiber >Priority: Major > Attachments: OAK-8763-tests.patch, OAK-8763.patch > > > LoginContextProviderImpl#getLoginContext(...) extracts the most recent > subject from the AccessControlContext and then uses it for either a > PreAuthContext or a JaasLoginContext. This is wrong, because there is no > reason to assume that such a subject has anything to do with Oak. It > particularly hurts when it's readonly, because JAAS will then silently fail > to add principals and credentials. > We would need a way to identify pre-authenticated subjects and subjects that > are not pre-authenticated should not be used to create a JaasLoginContext. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8763) LoginContextProviderImpl uses any subject found in the AccessControlContext.
[ https://issues.apache.org/jira/browse/OAK-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated OAK-8763: Attachment: (was: OAK-8763-tests.patch) > LoginContextProviderImpl uses any subject found in the AccessControlContext. > > > Key: OAK-8763 > URL: https://issues.apache.org/jira/browse/OAK-8763 > Project: Jackrabbit Oak > Issue Type: Bug > Components: security-spi >Reporter: Manfred Baedke >Assignee: Angela Schreiber >Priority: Major > Attachments: OAK-8763-tests.patch, OAK-8763.patch > > > LoginContextProviderImpl#getLoginContext(...) extracts the most recent > subject from the AccessControlContext and then uses it for either a > PreAuthContext or a JaasLoginContext. This is wrong, because there is no > reason to assume that such a subject has anything to do with Oak. It > particularly hurts when it's readonly, because JAAS will then silently fail > to add principals and credentials. > We would need a way to identify pre-authenticated subjects and subjects that > are not pre-authenticated should not be used to create a JaasLoginContext. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8763) LoginContextProviderImpl uses any subject found in the AccessControlContext.
[ https://issues.apache.org/jira/browse/OAK-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated OAK-8763: Attachment: OAK-8763-tests.patch > LoginContextProviderImpl uses any subject found in the AccessControlContext. > > > Key: OAK-8763 > URL: https://issues.apache.org/jira/browse/OAK-8763 > Project: Jackrabbit Oak > Issue Type: Bug > Components: security-spi >Reporter: Manfred Baedke >Assignee: Angela Schreiber >Priority: Major > Attachments: OAK-8763-tests.patch, OAK-8763.patch > > > LoginContextProviderImpl#getLoginContext(...) extracts the most recent > subject from the AccessControlContext and then uses it for either a > PreAuthContext or a JaasLoginContext. This is wrong, because there is no > reason to assume that such a subject has anything to do with Oak. It > particularly hurts when it's readonly, because JAAS will then silently fail > to add principals and credentials. > We would need a way to identify pre-authenticated subjects and subjects that > are not pre-authenticated should not be used to create a JaasLoginContext. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8763) LoginContextProviderImpl uses any subject found in the AccessControlContext.
[ https://issues.apache.org/jira/browse/OAK-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke updated OAK-8763: Attachment: OAK-8763-tests.patch > LoginContextProviderImpl uses any subject found in the AccessControlContext. > > > Key: OAK-8763 > URL: https://issues.apache.org/jira/browse/OAK-8763 > Project: Jackrabbit Oak > Issue Type: Bug > Components: security-spi >Reporter: Manfred Baedke >Assignee: Angela Schreiber >Priority: Major > Attachments: OAK-8763-tests.patch, OAK-8763.patch > > > LoginContextProviderImpl#getLoginContext(...) extracts the most recent > subject from the AccessControlContext and then uses it for either a > PreAuthContext or a JaasLoginContext. This is wrong, because there is no > reason to assume that such a subject has anything to do with Oak. It > particularly hurts when it's readonly, because JAAS will then silently fail > to add principals and credentials. > We would need a way to identify pre-authenticated subjects and subjects that > are not pre-authenticated should not be used to create a JaasLoginContext. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8679) RDB*Store: update postgresql jdbc driver reference to 42.2.8
[ https://issues.apache.org/jira/browse/OAK-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944979#comment-16944979 ] Julian Reschke edited comment on OAK-8679 at 11/21/19 2:50 PM: --- trunk: (1.20.0) [r1867993|http://svn.apache.org/r1867993] 1.10: [r1870090|http://svn.apache.org/r1870090] was (Author: reschke): trunk: [r1867993|http://svn.apache.org/r1867993] > RDB*Store: update postgresql jdbc driver reference to 42.2.8 > > > Key: OAK-8679 > URL: https://issues.apache.org/jira/browse/OAK-8679 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8679) RDB*Store: update postgresql jdbc driver reference to 42.2.8
[ https://issues.apache.org/jira/browse/OAK-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8679: Fix Version/s: 1.10.7 > RDB*Store: update postgresql jdbc driver reference to 42.2.8 > > > Key: OAK-8679 > URL: https://issues.apache.org/jira/browse/OAK-8679 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8679) RDB*Store: update postgresql jdbc driver reference to 42.2.8
[ https://issues.apache.org/jira/browse/OAK-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8679: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > RDB*Store: update postgresql jdbc driver reference to 42.2.8 > > > Key: OAK-8679 > URL: https://issues.apache.org/jira/browse/OAK-8679 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: parent >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8779) QueryImpl: indexPlan used for logging always is null
[
https://issues.apache.org/jira/browse/OAK-8779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979313#comment-16979313
]
Thomas Mueller commented on OAK-8779:
-
You are right.
I saw this as well some time ago, but so far didn't log an issue.
I will add that to the technical dept list.
> QueryImpl: indexPlan used for logging always is null
>
>
> Key: OAK-8779
> URL: https://issues.apache.org/jira/browse/OAK-8779
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core
>Reporter: Julian Reschke
>Priority: Minor
>
>
> {noformat}
> if (indexPlan != null && indexPlan.getPlanName() != null) {
> indexName += "[" + indexPlan.getPlanName() + "]";
> } {noformat}
>
> (indexPlan always is null, maybe caused by code being moved around)
>
> cc: [~chetanm] [~thomasm]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OAK-8779) QueryImpl: indexPlan used for logging always is null
Julian Reschke created OAK-8779:
---
Summary: QueryImpl: indexPlan used for logging always is null
Key: OAK-8779
URL: https://issues.apache.org/jira/browse/OAK-8779
Project: Jackrabbit Oak
Issue Type: Bug
Components: core
Reporter: Julian Reschke
{noformat}
if (indexPlan != null && indexPlan.getPlanName() != null) {
indexName += "[" + indexPlan.getPlanName() + "]";
} {noformat}
(indexPlan always is null, maybe caused by code being moved around)
cc: [~chetanm] [~thomasm]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (OAK-8778) NodeImpl: remove unnecessary null check
[ https://issues.apache.org/jira/browse/OAK-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-8778. - Resolution: Fixed > NodeImpl: remove unnecessary null check > --- > > Key: OAK-8778 > URL: https://issues.apache.org/jira/browse/OAK-8778 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: jcr >Affects Versions: 1.20.0 >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Fix For: 1.22.0 > > > Introduced in OAK-8633 - value is already assumed to be non-null before. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8778) NodeImpl: remove unnecessary null check
[ https://issues.apache.org/jira/browse/OAK-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979277#comment-16979277 ] Julian Reschke commented on OAK-8778: - trunk: [r1870088|http://svn.apache.org/r1870088] > NodeImpl: remove unnecessary null check > --- > > Key: OAK-8778 > URL: https://issues.apache.org/jira/browse/OAK-8778 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: jcr >Affects Versions: 1.20.0 >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Fix For: 1.22.0 > > > Introduced in OAK-8633 - value is already assumed to be non-null before. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8778) NodeImpl: remove unnecessary null check
[ https://issues.apache.org/jira/browse/OAK-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8778: Description: Introduced in OAK-8633 - value is already assumed to be non-null before. (was: Introduced in OAK-8633.) > NodeImpl: remove unnecessary null check > --- > > Key: OAK-8778 > URL: https://issues.apache.org/jira/browse/OAK-8778 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: jcr >Affects Versions: 1.20.0 >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Trivial > Fix For: 1.22.0 > > > Introduced in OAK-8633 - value is already assumed to be non-null before. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-8778) NodeImpl: remove unnecessary null check
Julian Reschke created OAK-8778: --- Summary: NodeImpl: remove unnecessary null check Key: OAK-8778 URL: https://issues.apache.org/jira/browse/OAK-8778 Project: Jackrabbit Oak Issue Type: Improvement Components: jcr Affects Versions: 1.20.0 Reporter: Julian Reschke Assignee: Julian Reschke Fix For: 1.22.0 Introduced in OAK-8633. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8774) oak-benchmarks: update commons-compress dependency to 1.19
[ https://issues.apache.org/jira/browse/OAK-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8774: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > oak-benchmarks: update commons-compress dependency to 1.19 > -- > > Key: OAK-8774 > URL: https://issues.apache.org/jira/browse/OAK-8774 > Project: Jackrabbit Oak > Issue Type: Task > Components: benchmarks >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8774) oak-benchmarks: update commons-compress dependency to 1.19
[ https://issues.apache.org/jira/browse/OAK-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8774: Fix Version/s: 1.10.7 > oak-benchmarks: update commons-compress dependency to 1.19 > -- > > Key: OAK-8774 > URL: https://issues.apache.org/jira/browse/OAK-8774 > Project: Jackrabbit Oak > Issue Type: Task > Components: benchmarks >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8774) oak-benchmarks: update commons-compress dependency to 1.19
[ https://issues.apache.org/jira/browse/OAK-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16976613#comment-16976613 ] Julian Reschke edited comment on OAK-8774 at 11/21/19 1:15 PM: --- trunk: (1.20.0) [r1869976|http://svn.apache.org/r1869976] 1.10: [r1870087|http://svn.apache.org/r1870087] was (Author: reschke): trunk: [r1869976|http://svn.apache.org/r1869976] > oak-benchmarks: update commons-compress dependency to 1.19 > -- > > Key: OAK-8774 > URL: https://issues.apache.org/jira/browse/OAK-8774 > Project: Jackrabbit Oak > Issue Type: Task > Components: benchmarks >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8722) dead locking related code in NodeDelegate.updateMixins
[
https://issues.apache.org/jira/browse/OAK-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8722:
Labels: candidate_oak_1_8 (was: candidate_oak_1_10)
> dead locking related code in NodeDelegate.updateMixins
> --
>
> Key: OAK-8722
> URL: https://issues.apache.org/jira/browse/OAK-8722
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_8
> Fix For: 1.20.0, 1.10.7
>
> Attachments: OAK-8722.diff
>
>
> {noformat}
> // 3. deal with locked nodes
> boolean wasLockable = isNodeType(MIX_LOCKABLE);
> boolean isLockable = isNodeType(MIX_LOCKABLE);
> if (wasLockable && !isLockable && holdsLock(false)) {
> // TODO: This should probably be done in a commit hook
> unlock();
> sessionDelegate.refresh(true);
> }
> {noformat}
> AFAICT, this code block will never be executed. Clean up, [~angela]?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OAK-8722) dead locking related code in NodeDelegate.updateMixins
[
https://issues.apache.org/jira/browse/OAK-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966672#comment-16966672
]
Julian Reschke edited comment on OAK-8722 at 11/21/19 12:10 PM:
trunk: (1.20.0) [r1869367|http://svn.apache.org/r1869367]
1.10: [r1870084|http://svn.apache.org/r1870084]
was (Author: reschke):
trunk: [r1869367|http://svn.apache.org/r1869367]
> dead locking related code in NodeDelegate.updateMixins
> --
>
> Key: OAK-8722
> URL: https://issues.apache.org/jira/browse/OAK-8722
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_8
> Fix For: 1.20.0, 1.10.7
>
> Attachments: OAK-8722.diff
>
>
> {noformat}
> // 3. deal with locked nodes
> boolean wasLockable = isNodeType(MIX_LOCKABLE);
> boolean isLockable = isNodeType(MIX_LOCKABLE);
> if (wasLockable && !isLockable && holdsLock(false)) {
> // TODO: This should probably be done in a commit hook
> unlock();
> sessionDelegate.refresh(true);
> }
> {noformat}
> AFAICT, this code block will never be executed. Clean up, [~angela]?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-8722) dead locking related code in NodeDelegate.updateMixins
[
https://issues.apache.org/jira/browse/OAK-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-8722:
Fix Version/s: 1.10.7
> dead locking related code in NodeDelegate.updateMixins
> --
>
> Key: OAK-8722
> URL: https://issues.apache.org/jira/browse/OAK-8722
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Labels: candidate_oak_1_10
> Fix For: 1.20.0, 1.10.7
>
> Attachments: OAK-8722.diff
>
>
> {noformat}
> // 3. deal with locked nodes
> boolean wasLockable = isNodeType(MIX_LOCKABLE);
> boolean isLockable = isNodeType(MIX_LOCKABLE);
> if (wasLockable && !isLockable && holdsLock(false)) {
> // TODO: This should probably be done in a commit hook
> unlock();
> sessionDelegate.refresh(true);
> }
> {noformat}
> AFAICT, this code block will never be executed. Clean up, [~angela]?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OAK-8775) update Tomcat JDBC dependency to 8.5.47
[ https://issues.apache.org/jira/browse/OAK-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977331#comment-16977331 ] Julian Reschke edited comment on OAK-8775 at 11/21/19 11:07 AM: trunk: (1.20.0) [r1870014|http://svn.apache.org/r1870014] [r1870013|http://svn.apache.org/r1870013] [r1870012|http://svn.apache.org/r1870012] 1.10: [r1870082|http://svn.apache.org/r1870082] was (Author: reschke): trunk: [r1870014|http://svn.apache.org/r1870014] [r1870013|http://svn.apache.org/r1870013] [r1870012|http://svn.apache.org/r1870012] > update Tomcat JDBC dependency to 8.5.47 > --- > > Key: OAK-8775 > URL: https://issues.apache.org/jira/browse/OAK-8775 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8775) update Tomcat JDBC dependency to 8.5.47
[ https://issues.apache.org/jira/browse/OAK-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8775: Fix Version/s: 1.10.7 > update Tomcat JDBC dependency to 8.5.47 > --- > > Key: OAK-8775 > URL: https://issues.apache.org/jira/browse/OAK-8775 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8775) update Tomcat JDBC dependency to 8.5.47
[ https://issues.apache.org/jira/browse/OAK-8775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8775: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > update Tomcat JDBC dependency to 8.5.47 > --- > > Key: OAK-8775 > URL: https://issues.apache.org/jira/browse/OAK-8775 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8773) Some potential ArrayIndexOutOfBounds Exception
[ https://issues.apache.org/jira/browse/OAK-8773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979166#comment-16979166 ] Qian Chen commented on OAK-8773: Hi, we have reported the bugs a while ago would you please take a look and confirm if they are real bugs. We have been conducting an experiment to measure the accuracy of our static checker. We would be deeply appreciated if you can provide some feedback! > Some potential ArrayIndexOutOfBounds Exception > -- > > Key: OAK-8773 > URL: https://issues.apache.org/jira/browse/OAK-8773 > Project: Jackrabbit Oak > Issue Type: Bug >Reporter: Qian Chen >Priority: Major > > Hi all, > Our bug scanner has reported some potential ArrayIndexOutOfBounds bugs. > The first one ia at > [DebugTimer.java#L60|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/DebugTimer.java#L60] > since there may be no element in the array. Some similar situations appear > at > [PropertiesUtil.java#L303|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/PropertiesUtil.java#L303] > , > [Profiler.java#L384|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/Profiler.java#L384] > , > [CacheLIRS.java#L184|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheLIRS.java#L184] > , > [GenericDescriptors.java#L108|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/spi/descriptors/GenericDescriptors.java#L108] > , > [LikePattern.java#L156|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/fulltext/LikePattern.java#L156] > , > [PrivilegeBits.java#L818|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/privilege/PrivilegeBits.java#L818] > and > [PrivilegeBits.java#L839|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/privilege/PrivilegeBits.java#L839] > The second one is at > [JsopTokenizer.java#L369|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopTokenizer.java#L369] > since the index may not be in the valid range. Some similar situations are > at JsopStream.java , from > [Line35|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopStream.java#L35] > to > [Line62|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopStream.java#L62] > , > [Line192|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopStream.java#L192] > to > [Line325|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/json/JsopStream.java#L325] > , > [ManagementOperation.java#L335|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/commons/jmx/ManagementOperation.java#L335] > , CacheLIRS.java > [Line211|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheLIRS.java#L211] > , > [Line212|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheLIRS.java#L212] > , > [Line434|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheLIRS.java#L434] > , > [Line1156|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheLIRS.java#L1156] > , > [Line1157|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheLIRS.java#L1157] > , > [Line1186|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheLIRS.java#L1186] > , > [Line1191|https://github.com/apache/jackrabbit-oak/blob/jackrabbit-oak-1.18.0/oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/CacheLIRS.java#L1191] > , >
[jira] [Commented] (OAK-8762) Several potential NullPointerException bugs
[
https://issues.apache.org/jira/browse/OAK-8762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979164#comment-16979164
]
Qian Chen commented on OAK-8762:
Hi, we have reported the bugs a while ago would you please take a look and
confirm if they are real bugs. We have been conducting an experiment to measure
the accuracy of our static checker. We would be deeply appreciated if you can
provide some feedback!
> Several potential NullPointerException bugs
> ---
>
> Key: OAK-8762
> URL: https://issues.apache.org/jira/browse/OAK-8762
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Qian Chen
>Priority: Major
>
> Hi all,
> Our bug scanner has reported some NPE bugs.
> The bugs are caused by the
> {code:java}
> return null
> {code}
> in function
> [retrieve()|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/query/QueryLogAnalyzer.java#L155]
> Since the return value of the method retrieve() may be null , a NPE bug may
> take place in
> [retrieve()|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/query/QueryLogAnalyzer.java#L156]
> when the return value of the method retrieve() was [passed
> to|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/query/QueryLogAnalyzer.java#L63]
> the first parameter of the method retrieve() .
> And when the return value of the method retrieve() was [passed
> to|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/query/QueryLogAnalyzer.java#L64]
> the parameter of the method filterParams() , a NPE bug may also
> [occur|https://github.com/apache/jackrabbit-oak/tree/trunk/oak-core/src/test/java/org/apache/jackrabbit/oak/query/QueryLogAnalyzer.java#L137].
> Thanks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OAK-8712) oak-blob-* and oak-segment-azure need to declare nullability annotations dependency
[ https://issues.apache.org/jira/browse/OAK-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957201#comment-16957201 ] Julian Reschke edited comment on OAK-8712 at 11/21/19 9:39 AM: --- trunk: (1.20.0) [r1868767|http://svn.apache.org/r1868767] 1.10: [r1870079|http://svn.apache.org/r1870079] was (Author: reschke): trunk: [r1868767|http://svn.apache.org/r1868767] > oak-blob-* and oak-segment-azure need to declare nullability annotations > dependency > --- > > Key: OAK-8712 > URL: https://issues.apache.org/jira/browse/OAK-8712 > Project: Jackrabbit Oak > Issue Type: Task > Components: blob-cloud, blob-cloud-azure, segment-azure >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: cand# > Fix For: 1.20.0, 1.10.7 > > > Currently inherited transitively through jackrabbit-data... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8712) oak-blob-* and oak-segment-azure need to declare nullability annotations dependency
[ https://issues.apache.org/jira/browse/OAK-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8712: Fix Version/s: 1.10.7 > oak-blob-* and oak-segment-azure need to declare nullability annotations > dependency > --- > > Key: OAK-8712 > URL: https://issues.apache.org/jira/browse/OAK-8712 > Project: Jackrabbit Oak > Issue Type: Task > Components: blob-cloud, blob-cloud-azure, segment-azure >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.20.0, 1.10.7 > > > Currently inherited transitively through jackrabbit-data... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8712) oak-blob-* and oak-segment-azure need to declare nullability annotations dependency
[ https://issues.apache.org/jira/browse/OAK-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8712: Labels: cand# (was: candidate_oak_1_10) > oak-blob-* and oak-segment-azure need to declare nullability annotations > dependency > --- > > Key: OAK-8712 > URL: https://issues.apache.org/jira/browse/OAK-8712 > Project: Jackrabbit Oak > Issue Type: Task > Components: blob-cloud, blob-cloud-azure, segment-azure >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: cand# > Fix For: 1.20.0, 1.10.7 > > > Currently inherited transitively through jackrabbit-data... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8651) Update mockito dependency to 2.28.2
[ https://issues.apache.org/jira/browse/OAK-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16939333#comment-16939333 ] Julian Reschke edited comment on OAK-8651 at 11/21/19 8:19 AM: --- trunk: (1.20.0) [r1867629|http://svn.apache.org/r1867629] 1.10: [r1870071|http://svn.apache.org/r1870071] was (Author: reschke): trunk: [r1867629|http://svn.apache.org/r1867629] > Update mockito dependency to 2.28.2 > --- > > Key: OAK-8651 > URL: https://issues.apache.org/jira/browse/OAK-8651 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent, test >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8651) Update mockito dependency to 2.28.2
[ https://issues.apache.org/jira/browse/OAK-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8651: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > Update mockito dependency to 2.28.2 > --- > > Key: OAK-8651 > URL: https://issues.apache.org/jira/browse/OAK-8651 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent, test >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_8 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8651) Update mockito dependency to 2.28.2
[ https://issues.apache.org/jira/browse/OAK-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8651: Fix Version/s: 1.10.7 > Update mockito dependency to 2.28.2 > --- > > Key: OAK-8651 > URL: https://issues.apache.org/jira/browse/OAK-8651 > Project: Jackrabbit Oak > Issue Type: Task > Components: parent, test >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.20.0, 1.10.7 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
