[jira] [Comment Edited] (OAK-8913) RDB*Store: extract "additionalDiagnostics" code into separate class for re-use from RDBBlobStore
[ https://issues.apache.org/jira/browse/OAK-8913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17039465#comment-17039465 ] Julian Reschke edited comment on OAK-8913 at 3/5/20, 6:18 AM: -- trunk: [r1874174|http://svn.apache.org/r1874174] 1.22: [r1874819|http://svn.apache.org/r1874819] was (Author: reschke): trunk: [r1874174|http://svn.apache.org/r1874174] > RDB*Store: extract "additionalDiagnostics" code into separate class for > re-use from RDBBlobStore > > > Key: OAK-8913 > URL: https://issues.apache.org/jira/browse/OAK-8913 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > Attachments: OAK-8913.diff > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8913) RDB*Store: extract "additionalDiagnostics" code into separate class for re-use from RDBBlobStore
[ https://issues.apache.org/jira/browse/OAK-8913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8913: Labels: candidate_oak_1_10 (was: candidate_oak_1_22) > RDB*Store: extract "additionalDiagnostics" code into separate class for > re-use from RDBBlobStore > > > Key: OAK-8913 > URL: https://issues.apache.org/jira/browse/OAK-8913 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > Attachments: OAK-8913.diff > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8913) RDB*Store: extract "additionalDiagnostics" code into separate class for re-use from RDBBlobStore
[ https://issues.apache.org/jira/browse/OAK-8913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8913: Fix Version/s: 1.22.2 > RDB*Store: extract "additionalDiagnostics" code into separate class for > re-use from RDBBlobStore > > > Key: OAK-8913 > URL: https://issues.apache.org/jira/browse/OAK-8913 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_22 > Fix For: 1.26.0, 1.22.2 > > Attachments: OAK-8913.diff > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8882) RDBBlobStore: dump table structure on startup
[ https://issues.apache.org/jira/browse/OAK-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025954#comment-17025954 ] Julian Reschke edited comment on OAK-8882 at 3/5/20, 5:01 AM: -- trunk: [r1874246|http://svn.apache.org/r1874246] [r1874097|http://svn.apache.org/r1874097] [r1873308|http://svn.apache.org/r1873308] 1.22: [r1874816|http://svn.apache.org/r1874816] was (Author: reschke): trunk: [r1874246|http://svn.apache.org/r1874246] [r1874097|http://svn.apache.org/r1874097] [r1873308|http://svn.apache.org/r1873308] > RDBBlobStore: dump table structure on startup > - > > Key: OAK-8882 > URL: https://issues.apache.org/jira/browse/OAK-8882 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8882) RDBBlobStore: dump table structure on startup
[ https://issues.apache.org/jira/browse/OAK-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8882: Fix Version/s: 1.22.2 > RDBBlobStore: dump table structure on startup > - > > Key: OAK-8882 > URL: https://issues.apache.org/jira/browse/OAK-8882 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_22 > Fix For: 1.26.0, 1.22.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8882) RDBBlobStore: dump table structure on startup
[ https://issues.apache.org/jira/browse/OAK-8882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8882: Labels: candidate_oak_1_10 (was: candidate_oak_1_22) > RDBBlobStore: dump table structure on startup > - > > Key: OAK-8882 > URL: https://issues.apache.org/jira/browse/OAK-8882 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-7671) [oak-run] Deprecate the datastorecheck command in favor of datastore
[ https://issues.apache.org/jira/browse/OAK-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051801#comment-17051801 ] Nitin Gupta commented on OAK-7671: -- Updated the final PR with tests [https://github.com/oak-indexing/jackrabbit-oak/pull/45/files] . To sum up, this is what's done - # Added operations to dump id and dump references in the new DataStore Command # Added a regex option to be used along with --verboseRootPath , this should limit the number of nodes that need to be scanned/traversed (useful if we know a the specific type of paths that we need to scan for blob references , for example in case of lucene blobs it is /oak:index/*/:data and /oak:index/*/:suggest-data) # Added the tests around the above 2 points and a few small changes in the test code. I see , [~thomasm] already approved the main code changes in PR (post that I only added the tests). I will merge by EOD today, but further reviews are still welcome. cc : [~amitjain] , [~tihom88] , [~fabrizio.fort...@gmail.com] > [oak-run] Deprecate the datastorecheck command in favor of datastore > > > Key: OAK-7671 > URL: https://issues.apache.org/jira/browse/OAK-7671 > Project: Jackrabbit Oak > Issue Type: Task > Components: run >Reporter: Amit Jain >Assignee: Nitin Gupta >Priority: Major > Fix For: 1.26.0 > > > With the introduction of \{{datastore}} command which supports both garbage > collection as well as consistency check the \{{datastorecheck}} command > should be deprecated and delegated internally to use that implementation. > Besides some options which are currently not supported by the new command > should also be implemented e.g. --ids, --refs -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8909) RDBBlobStore: when creating META table for SQL Server, assign readable name for PK
[ https://issues.apache.org/jira/browse/OAK-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037876#comment-17037876 ] Julian Reschke edited comment on OAK-8909 at 3/4/20, 9:52 PM: -- trunk: [r1874084|http://svn.apache.org/r1874084] 1.22: [r1874811|http://svn.apache.org/r1874811] was (Author: reschke): trunk: [r1874084|http://svn.apache.org/r1874084] > RDBBlobStore: when creating META table for SQL Server, assign readable name > for PK > -- > > Key: OAK-8909 > URL: https://issues.apache.org/jira/browse/OAK-8909 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8909) RDBBlobStore: when creating META table for SQL Server, assign readable name for PK
[ https://issues.apache.org/jira/browse/OAK-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8909: Labels: candidate_oak_1_10 (was: candidate_oak_1_22) > RDBBlobStore: when creating META table for SQL Server, assign readable name > for PK > -- > > Key: OAK-8909 > URL: https://issues.apache.org/jira/browse/OAK-8909 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8909) RDBBlobStore: when creating META table for SQL Server, assign readable name for PK
[ https://issues.apache.org/jira/browse/OAK-8909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8909: Fix Version/s: 1.22.2 > RDBBlobStore: when creating META table for SQL Server, assign readable name > for PK > -- > > Key: OAK-8909 > URL: https://issues.apache.org/jira/browse/OAK-8909 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_22 > Fix For: 1.26.0, 1.22.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8907) RDBDocumentStore: change diagnostics from String to Map
[ https://issues.apache.org/jira/browse/OAK-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17037007#comment-17037007 ] Julian Reschke edited comment on OAK-8907 at 3/4/20, 7:43 PM: -- trunk: [r1874023|http://svn.apache.org/r1874023] 1.22: [r1874810|http://svn.apache.org/r1874810] was (Author: reschke): trunk: [r1874023|http://svn.apache.org/r1874023] > RDBDocumentStore: change diagnostics from String to Map > --- > > Key: OAK-8907 > URL: https://issues.apache.org/jira/browse/OAK-8907 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > > ...so they can be inspected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8907) RDBDocumentStore: change diagnostics from String to Map
[ https://issues.apache.org/jira/browse/OAK-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8907: Fix Version/s: 1.22.2 > RDBDocumentStore: change diagnostics from String to Map > --- > > Key: OAK-8907 > URL: https://issues.apache.org/jira/browse/OAK-8907 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_22 > Fix For: 1.26.0, 1.22.2 > > > ...so they can be inspected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8907) RDBDocumentStore: change diagnostics from String to Map
[ https://issues.apache.org/jira/browse/OAK-8907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8907: Labels: candidate_oak_1_10 (was: candidate_oak_1_22) > RDBDocumentStore: change diagnostics from String to Map > --- > > Key: OAK-8907 > URL: https://issues.apache.org/jira/browse/OAK-8907 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > > ...so they can be inspected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions
[ https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051502#comment-17051502 ] Julian Reschke commented on OAK-8936: - It can stay closed. 1.24.0 will be replaced by 1.26.0; there is no branch for 1.24. Just merge the change into the 1.22 branch and then set the FixVersion. > ValueImpl does not properly set domain override flag of BlobDownloadOptions > --- > > Key: OAK-8936 > URL: https://issues.apache.org/jira/browse/OAK-8936 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob-cloud >Affects Versions: 1.22.1 >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Critical > Labels: candidate_oak_1_22 > Fix For: 1.26.0 > > > In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} > when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the > conversion does not take the domain override flag into account. This flag > must be preserved in the conversion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions
[ https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8936: Affects Version/s: (was: 1.24.0) (was: 1.22.0) > ValueImpl does not properly set domain override flag of BlobDownloadOptions > --- > > Key: OAK-8936 > URL: https://issues.apache.org/jira/browse/OAK-8936 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob-cloud >Affects Versions: 1.22.1 >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Critical > Fix For: 1.26.0 > > > In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} > when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the > conversion does not take the domain override flag into account. This flag > must be preserved in the conversion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions
[ https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-8936. - Resolution: Fixed > ValueImpl does not properly set domain override flag of BlobDownloadOptions > --- > > Key: OAK-8936 > URL: https://issues.apache.org/jira/browse/OAK-8936 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob-cloud >Affects Versions: 1.22.0, 1.24.0, 1.22.1 >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Critical > Fix For: 1.26.0 > > > In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} > when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the > conversion does not take the domain override flag into account. This flag > must be preserved in the conversion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions
[ https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8936: Labels: candidate_oak_1_22 (was: ) > ValueImpl does not properly set domain override flag of BlobDownloadOptions > --- > > Key: OAK-8936 > URL: https://issues.apache.org/jira/browse/OAK-8936 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob-cloud >Affects Versions: 1.22.1 >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Critical > Labels: candidate_oak_1_22 > Fix For: 1.26.0 > > > In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} > when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the > conversion does not take the domain override flag into account. This flag > must be preserved in the conversion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions
[ https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Ryan reopened OAK-8936: Reopening to do the necessary backports. > ValueImpl does not properly set domain override flag of BlobDownloadOptions > --- > > Key: OAK-8936 > URL: https://issues.apache.org/jira/browse/OAK-8936 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob-cloud >Affects Versions: 1.22.0, 1.24.0, 1.22.1 >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Critical > Fix For: 1.26.0 > > > In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} > when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the > conversion does not take the domain override flag into account. This flag > must be preserved in the conversion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions
[ https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051415#comment-17051415 ] Matt Ryan commented on OAK-8936: I was thinking about that. It probably would be good to backport. The associated feature was introduced in 1.22.0. So I assume it needs to be backported to 1.24 and 1.22.1. Does it also need to be backported to 1.22.0? > ValueImpl does not properly set domain override flag of BlobDownloadOptions > --- > > Key: OAK-8936 > URL: https://issues.apache.org/jira/browse/OAK-8936 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob-cloud >Affects Versions: 1.22.0, 1.24.0, 1.22.1 >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Critical > Fix For: 1.26.0 > > > In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} > when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the > conversion does not take the domain override flag into account. This flag > must be preserved in the conversion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions
[ https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Ryan updated OAK-8936: --- Affects Version/s: 1.22.0 1.22.1 > ValueImpl does not properly set domain override flag of BlobDownloadOptions > --- > > Key: OAK-8936 > URL: https://issues.apache.org/jira/browse/OAK-8936 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob-cloud >Affects Versions: 1.22.0, 1.24.0, 1.22.1 >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Critical > Fix For: 1.26.0 > > > In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} > when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the > conversion does not take the domain override flag into account. This flag > must be preserved in the conversion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8906) RDBDocumentStore on SQL Server (additional diags) log DB creation time
[ https://issues.apache.org/jira/browse/OAK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8906: Labels: candidate_oak_1_10 (was: candidate_oak_1_22) > RDBDocumentStore on SQL Server (additional diags) log DB creation time > -- > > Key: OAK-8906 > URL: https://issues.apache.org/jira/browse/OAK-8906 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8906) RDBDocumentStore on SQL Server (additional diags) log DB creation time
[ https://issues.apache.org/jira/browse/OAK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17036983#comment-17036983 ] Julian Reschke edited comment on OAK-8906 at 3/4/20, 4:08 PM: -- trunk: [r1874021|http://svn.apache.org/r1874021] 1.22: [r1874804|http://svn.apache.org/r1874804] was (Author: reschke): trunk: [r1874021|http://svn.apache.org/r1874021] > RDBDocumentStore on SQL Server (additional diags) log DB creation time > -- > > Key: OAK-8906 > URL: https://issues.apache.org/jira/browse/OAK-8906 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8906) RDBDocumentStore on SQL Server (additional diags) log DB creation time
[ https://issues.apache.org/jira/browse/OAK-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8906: Fix Version/s: 1.22.2 > RDBDocumentStore on SQL Server (additional diags) log DB creation time > -- > > Key: OAK-8906 > URL: https://issues.apache.org/jira/browse/OAK-8906 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_22 > Fix For: 1.26.0, 1.22.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8933) Build Jackrabbit Oak #2648 failed
[ https://issues.apache.org/jira/browse/OAK-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051316#comment-17051316 ] Hudson commented on OAK-8933: - Previously failing build now is OK. Passed run: [Jackrabbit Oak #2650|https://builds.apache.org/job/Jackrabbit%20Oak/2650/] [console log|https://builds.apache.org/job/Jackrabbit%20Oak/2650/console] > Build Jackrabbit Oak #2648 failed > - > > Key: OAK-8933 > URL: https://issues.apache.org/jira/browse/OAK-8933 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit Oak #2648 has failed. > First failed run: [Jackrabbit Oak > #2648|https://builds.apache.org/job/Jackrabbit%20Oak/2648/] [console > log|https://builds.apache.org/job/Jackrabbit%20Oak/2648/console] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8932) RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm
[ https://issues.apache.org/jira/browse/OAK-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049242#comment-17049242 ] Julian Reschke edited comment on OAK-8932 at 3/4/20, 1:54 PM: -- trunk: [r1874692|http://svn.apache.org/r1874692] 1.22: [r1874781|http://svn.apache.org/r1874781] 1.10: [r1874783|http://svn.apache.org/r1874783] 1.8: [r1874794|http://svn.apache.org/r1874794] was (Author: reschke): trunk: [r1874692|http://svn.apache.org/r1874692] 1.22: [r1874781|http://svn.apache.org/r1874781] 1.10: [r1874783|http://svn.apache.org/r1874783] > RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm > -- > > Key: OAK-8932 > URL: https://issues.apache.org/jira/browse/OAK-8932 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_6 > Fix For: 1.26.0, 1.10.9, 1.8.21, 1.22.2 > > Attachments: OAK-8932.diff > > > The current (new) algorithm (introduced in OAK-5855) may cause SELECT and > DELETE statements to run concurrently, which might cause problems on certain > DBs, such as SQL Server. > Added a fallback (triggered by a system property) to the older (but slower) > algorithm. Select it by setting system property like that: > {noformat} > -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBVersionGCSupport.MODE=1 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8932) RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm
[ https://issues.apache.org/jira/browse/OAK-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8932: Fix Version/s: 1.8.21 > RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm > -- > > Key: OAK-8932 > URL: https://issues.apache.org/jira/browse/OAK-8932 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.26.0, 1.10.9, 1.8.21, 1.22.2 > > Attachments: OAK-8932.diff > > > The current (new) algorithm (introduced in OAK-5855) may cause SELECT and > DELETE statements to run concurrently, which might cause problems on certain > DBs, such as SQL Server. > Added a fallback (triggered by a system property) to the older (but slower) > algorithm. Select it by setting system property like that: > {noformat} > -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBVersionGCSupport.MODE=1 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8932) RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm
[ https://issues.apache.org/jira/browse/OAK-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8932: Labels: candidate_oak_1_6 (was: candidate_oak_1_8) > RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm > -- > > Key: OAK-8932 > URL: https://issues.apache.org/jira/browse/OAK-8932 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_6 > Fix For: 1.26.0, 1.10.9, 1.8.21, 1.22.2 > > Attachments: OAK-8932.diff > > > The current (new) algorithm (introduced in OAK-5855) may cause SELECT and > DELETE statements to run concurrently, which might cause problems on certain > DBs, such as SQL Server. > Added a fallback (triggered by a system property) to the older (but slower) > algorithm. Select it by setting system property like that: > {noformat} > -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBVersionGCSupport.MODE=1 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8934) Indexing: filter entries with a regular expression
[ https://issues.apache.org/jira/browse/OAK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051214#comment-17051214 ] Thomas Mueller edited comment on OAK-8934 at 3/4/20, 1:11 PM: -- [http://svn.apache.org/r1874786|http://svn.apache.org/r1874786] was (Author: tmueller): [http://svn.apache.org/r1874786|http://svn/] > Indexing: filter entries with a regular expression > -- > > Key: OAK-8934 > URL: https://issues.apache.org/jira/browse/OAK-8934 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: indexing >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Labels: amrit > > We should provide a way to filter the index using a regular expression. For > example, only index nodes that contain a reference to another node. (Not a > JCR reference, but a reference within the value itself). For example, index a > node if one of the properties contains: > * /content/abc > * > * and so on > This will allow to run a query to find if /content/abc is referenced. The > index and the query will probably need to use a tag, and the cost of the > index needs to be high. Otherwise the query engine can't know when this index > should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OAK-8934) Indexing: filter entries with a regular expression
[ https://issues.apache.org/jira/browse/OAK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller resolved OAK-8934. - Resolution: Fixed > Indexing: filter entries with a regular expression > -- > > Key: OAK-8934 > URL: https://issues.apache.org/jira/browse/OAK-8934 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: indexing >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Labels: amrit > Fix For: 1.26.0 > > > We should provide a way to filter the index using a regular expression. For > example, only index nodes that contain a reference to another node. (Not a > JCR reference, but a reference within the value itself). For example, index a > node if one of the properties contains: > * /content/abc > * > * and so on > This will allow to run a query to find if /content/abc is referenced. The > index and the query will probably need to use a tag, and the cost of the > index needs to be high. Otherwise the query engine can't know when this index > should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8934) Indexing: filter entries with a regular expression
[ https://issues.apache.org/jira/browse/OAK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Mueller updated OAK-8934: Fix Version/s: 1.26.0 > Indexing: filter entries with a regular expression > -- > > Key: OAK-8934 > URL: https://issues.apache.org/jira/browse/OAK-8934 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: indexing >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Labels: amrit > Fix For: 1.26.0 > > > We should provide a way to filter the index using a regular expression. For > example, only index nodes that contain a reference to another node. (Not a > JCR reference, but a reference within the value itself). For example, index a > node if one of the properties contains: > * /content/abc > * > * and so on > This will allow to run a query to find if /content/abc is referenced. The > index and the query will probably need to use a tag, and the cost of the > index needs to be high. Otherwise the query engine can't know when this index > should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8934) Indexing: filter entries with a regular expression
[ https://issues.apache.org/jira/browse/OAK-8934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051214#comment-17051214 ] Thomas Mueller commented on OAK-8934: - [http://svn.apache.org/r1874786|http://svn/] > Indexing: filter entries with a regular expression > -- > > Key: OAK-8934 > URL: https://issues.apache.org/jira/browse/OAK-8934 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: indexing >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Labels: amrit > > We should provide a way to filter the index using a regular expression. For > example, only index nodes that contain a reference to another node. (Not a > JCR reference, but a reference within the value itself). For example, index a > node if one of the properties contains: > * /content/abc > * > * and so on > This will allow to run a query to find if /content/abc is referenced. The > index and the query will probably need to use a tag, and the cost of the > index needs to be high. Otherwise the query engine can't know when this index > should be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8932) RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm
[ https://issues.apache.org/jira/browse/OAK-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049242#comment-17049242 ] Julian Reschke edited comment on OAK-8932 at 3/4/20, 12:36 PM: --- trunk: [r1874692|http://svn.apache.org/r1874692] 1.22: [r1874781|http://svn.apache.org/r1874781] 1.10: [r1874783|http://svn.apache.org/r1874783] was (Author: reschke): trunk: [r1874692|http://svn.apache.org/r1874692] 1.22: [r1874781|http://svn.apache.org/r1874781] > RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm > -- > > Key: OAK-8932 > URL: https://issues.apache.org/jira/browse/OAK-8932 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.26.0, 1.10.9, 1.22.2 > > Attachments: OAK-8932.diff > > > The current (new) algorithm (introduced in OAK-5855) may cause SELECT and > DELETE statements to run concurrently, which might cause problems on certain > DBs, such as SQL Server. > Added a fallback (triggered by a system property) to the older (but slower) > algorithm. Select it by setting system property like that: > {noformat} > -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBVersionGCSupport.MODE=1 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8932) RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm
[ https://issues.apache.org/jira/browse/OAK-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8932: Labels: candidate_oak_1_8 (was: candidate_oak_1_10) > RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm > -- > > Key: OAK-8932 > URL: https://issues.apache.org/jira/browse/OAK-8932 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_8 > Fix For: 1.26.0, 1.10.9, 1.22.2 > > Attachments: OAK-8932.diff > > > The current (new) algorithm (introduced in OAK-5855) may cause SELECT and > DELETE statements to run concurrently, which might cause problems on certain > DBs, such as SQL Server. > Added a fallback (triggered by a system property) to the older (but slower) > algorithm. Select it by setting system property like that: > {noformat} > -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBVersionGCSupport.MODE=1 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8932) RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm
[ https://issues.apache.org/jira/browse/OAK-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8932: Fix Version/s: 1.10.9 > RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm > -- > > Key: OAK-8932 > URL: https://issues.apache.org/jira/browse/OAK-8932 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.10.9, 1.22.2 > > Attachments: OAK-8932.diff > > > The current (new) algorithm (introduced in OAK-5855) may cause SELECT and > DELETE statements to run concurrently, which might cause problems on certain > DBs, such as SQL Server. > Added a fallback (triggered by a system property) to the older (but slower) > algorithm. Select it by setting system property like that: > {noformat} > -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBVersionGCSupport.MODE=1 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8932) RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm
[ https://issues.apache.org/jira/browse/OAK-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8932: Labels: candidate_oak_1_10 (was: candidate_oak_1_22) > RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm > -- > > Key: OAK-8932 > URL: https://issues.apache.org/jira/browse/OAK-8932 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > Attachments: OAK-8932.diff > > > The current (new) algorithm (introduced in OAK-5855) may cause SELECT and > DELETE statements to run concurrently, which might cause problems on certain > DBs, such as SQL Server. > Added a fallback (triggered by a system property) to the older (but slower) > algorithm. Select it by setting system property like that: > {noformat} > -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBVersionGCSupport.MODE=1 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OAK-8932) RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm
[ https://issues.apache.org/jira/browse/OAK-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17049242#comment-17049242 ] Julian Reschke edited comment on OAK-8932 at 3/4/20, 10:59 AM: --- trunk: [r1874692|http://svn.apache.org/r1874692] 1.22: [r1874781|http://svn.apache.org/r1874781] was (Author: reschke): trunk: [r1874692|http://svn.apache.org/r1874692] > RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm > -- > > Key: OAK-8932 > URL: https://issues.apache.org/jira/browse/OAK-8932 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_10 > Fix For: 1.26.0, 1.22.2 > > Attachments: OAK-8932.diff > > > The current (new) algorithm (introduced in OAK-5855) may cause SELECT and > DELETE statements to run concurrently, which might cause problems on certain > DBs, such as SQL Server. > Added a fallback (triggered by a system property) to the older (but slower) > algorithm. Select it by setting system property like that: > {noformat} > -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBVersionGCSupport.MODE=1 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8932) RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm
[ https://issues.apache.org/jira/browse/OAK-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8932: Fix Version/s: 1.22.2 > RDBDocumentStore: allow RDBVersionGC support fallback to simpler algorithm > -- > > Key: OAK-8932 > URL: https://issues.apache.org/jira/browse/OAK-8932 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Major > Labels: candidate_oak_1_22 > Fix For: 1.26.0, 1.22.2 > > Attachments: OAK-8932.diff > > > The current (new) algorithm (introduced in OAK-5855) may cause SELECT and > DELETE statements to run concurrently, which might cause problems on certain > DBs, such as SQL Server. > Added a fallback (triggered by a system property) to the older (but slower) > algorithm. Select it by setting system property like that: > {noformat} > -Dorg.apache.jackrabbit.oak.plugins.document.rdb.RDBVersionGCSupport.MODE=1 > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8918) RDBBlobStore: warn when legacy (SQLServer) default collation is active
[ https://issues.apache.org/jira/browse/OAK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051077#comment-17051077 ] Julian Reschke commented on OAK-8918: - trunk: [r1874271|http://svn.apache.org/r1874271] > RDBBlobStore: warn when legacy (SQLServer) default collation is active > -- > > Key: OAK-8918 > URL: https://issues.apache.org/jira/browse/OAK-8918 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_22 > Fix For: 1.26.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8918) RDBBlobStore: warn when legacy (SQLServer) default collation is active
[ https://issues.apache.org/jira/browse/OAK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8918: Labels: candidate_oak_1_22 (was: ) > RDBBlobStore: warn when legacy (SQLServer) default collation is active > -- > > Key: OAK-8918 > URL: https://issues.apache.org/jira/browse/OAK-8918 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_22 > Fix For: 1.26.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OAK-8918) RDBBlobStore: warn when legacy (SQLServer) default collation is active
[ https://issues.apache.org/jira/browse/OAK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-8918. - Resolution: Fixed > RDBBlobStore: warn when legacy (SQLServer) default collation is active > -- > > Key: OAK-8918 > URL: https://issues.apache.org/jira/browse/OAK-8918 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Fix For: 1.26.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8926) add RDBBlobStore performance test
[ https://issues.apache.org/jira/browse/OAK-8926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051075#comment-17051075 ] Julian Reschke commented on OAK-8926: - Example output (in unit test log): {noformat} inserted 2126 blocks of size 1500 into RDB-DB2 (0 errors) in 2000ms (1063 blocks/s) inserted 11348 blocks of size 1500 into RDB-H2(file) (0 errors) in 2000ms (5674 blocks/s) inserted 4396 blocks of size 1500 into RDB-Derby(embedded) (0 errors) in 2000ms (2198 blocks/s) inserted 323 blocks of size 1500 into RDB-MSSql (0 errors) in 2000ms (161 blocks/s) inserted 153 blocks of size 1500 into RDB-MySQL (0 errors) in 2000ms (76 blocks/s) inserted 1729 blocks of size 1500 into RDB-Oracle (0 errors) in 2000ms (864 blocks/s) inserted 1954 blocks of size 1500 into RDB-Postgres (0 errors) in 2000ms (977 blocks/s) {noformat} So SQL Server and MySQL stand out. This might be because they do not handle "large" character primary keys well. > add RDBBlobStore performance test > - > > Key: OAK-8926 > URL: https://issues.apache.org/jira/browse/OAK-8926 > Project: Jackrabbit Oak > Issue Type: Technical task > Components: rdbmk >Reporter: Julian Reschke >Assignee: Julian Reschke >Priority: Minor > Labels: candidate_oak_1_22 > Fix For: 1.26.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions
[ https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17051064#comment-17051064 ] Julian Reschke commented on OAK-8936: - Does this require backports? > ValueImpl does not properly set domain override flag of BlobDownloadOptions > --- > > Key: OAK-8936 > URL: https://issues.apache.org/jira/browse/OAK-8936 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob-cloud >Affects Versions: 1.24.0 >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Critical > Fix For: 1.26.0 > > > In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} > when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the > conversion does not take the domain override flag into account. This flag > must be preserved in the conversion. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OAK-8936) ValueImpl does not properly set domain override flag of BlobDownloadOptions
[ https://issues.apache.org/jira/browse/OAK-8936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-8936: Component/s: blob-cloud > ValueImpl does not properly set domain override flag of BlobDownloadOptions > --- > > Key: OAK-8936 > URL: https://issues.apache.org/jira/browse/OAK-8936 > Project: Jackrabbit Oak > Issue Type: Bug > Components: blob-cloud >Affects Versions: 1.24.0 >Reporter: Matt Ryan >Assignee: Matt Ryan >Priority: Critical > Fix For: 1.26.0 > > > In {{org.apache.jackrabbit.oak.plugins.value.jcr.ValueImpl.getDownloadURI()}} > when converting a {{BinaryDownloadOptions}} to a {{BlobDownloadOptions}}, the > conversion does not take the domain override flag into account. This flag > must be preserved in the conversion. -- This message was sent by Atlassian Jira (v8.3.4#803005)