[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364619#comment-17364619 ] Aaron Anderson commented on OAK-7182: - Thanks for all of the excellent work on this issue. I am able to run the AWS SegmentNodeStore with the latest version of Oak (1.40) and Guava without any problem. I have encountered a few incompatibilities when using the RDMDocumentStore though. org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder -> needs a method update from com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor to com.google.common.util.concurrent.MoreExecutors.newDirectExecutorService org.apache.jackrabbit.oak.cache.AbstractCacheStats and org.apache.jackrabbit.oak.plugins.blob.StagingCacheStats -> needs a class update from com.google.common.base.Objects.toStringHelper to com.google.common.base.MoreObjects.toStringHelper In my application I am using ASM to correct these minor incompatibilities in the bytecode. Since "36. Remove (Guava) com.google.common.base.Objects.ToStringHelper" has been done elsewhere perhaps a quick change can be made to the CacheStats classes and the sameThreadExecutor utility could possibly be replaced with something simple like [this Camel|https://github.com/apache/camel/blob/main/core/camel-util/src/main/java/org/apache/camel/util/concurrent/SynchronousExecutorService.java] class. > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Priority: Minor > Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, > OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, > guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (OAK-9464) Suggestion Results are not deduplicated when ES indexes are used
[
https://issues.apache.org/jira/browse/OAK-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nitin Gupta resolved OAK-9464.
--
Fix Version/s: 1.42.0
Resolution: Fixed
> Suggestion Results are not deduplicated when ES indexes are used
>
>
> Key: OAK-9464
> URL: https://issues.apache.org/jira/browse/OAK-9464
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Critical
> Fix For: 1.42.0
>
>
> When running the following ES query:
> {code:java}
> POST cm-p11553-e21096-publish._damassetelastic-7-custom-2/_search
> {
> "query": {
> "bool": {
> "must": [
> {
> "nested": {
> "path": ":suggest",
> "query": {
> "match_phrase_prefix": {
> ":suggest.value": {
> "query": "jav"
> }
> }
> }
> }
> }
> ],
> "adjust_pure_negative": true,
> "boost": 1
> }
> }
> }
> {code}
> Following results are retrieved:
> {code:java}
> "NPR-9066 - Backport GRANITE-10700/CQ-65390 to AEM 6.1 - javax.inject
> conflicts"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"{code}
>
>
> Hitting a suggestion query like
> SELECT [rep:suggest()] FROM [dam:Asset] as s WHERE SUGGEST('jav')
> on lucene returns unique results. However with ES, duplicate results are also
> returned.
>
> We need to handle the duplication in oak.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OAK-9464) Suggestion Results are not deduplicated when ES indexes are used
[
https://issues.apache.org/jira/browse/OAK-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364373#comment-17364373
]
Nitin Gupta commented on OAK-9464:
--
[https://svn.apache.org/viewvc?view=revision=1890836]
> Suggestion Results are not deduplicated when ES indexes are used
>
>
> Key: OAK-9464
> URL: https://issues.apache.org/jira/browse/OAK-9464
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Critical
>
> When running the following ES query:
> {code:java}
> POST cm-p11553-e21096-publish._damassetelastic-7-custom-2/_search
> {
> "query": {
> "bool": {
> "must": [
> {
> "nested": {
> "path": ":suggest",
> "query": {
> "match_phrase_prefix": {
> ":suggest.value": {
> "query": "jav"
> }
> }
> }
> }
> }
> ],
> "adjust_pure_negative": true,
> "boost": 1
> }
> }
> }
> {code}
> Following results are retrieved:
> {code:java}
> "NPR-9066 - Backport GRANITE-10700/CQ-65390 to AEM 6.1 - javax.inject
> conflicts"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"{code}
>
>
> Hitting a suggestion query like
> SELECT [rep:suggest()] FROM [dam:Asset] as s WHERE SUGGEST('jav')
> on lucene returns unique results. However with ES, duplicate results are also
> returned.
>
> We need to handle the duplication in oak.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OAK-9467) PersistentDiskCacheTest failures on JDK11
Andrei Dulceanu created OAK-9467:
Summary: PersistentDiskCacheTest failures on JDK11
Key: OAK-9467
URL: https://issues.apache.org/jira/browse/OAK-9467
Project: Jackrabbit Oak
Issue Type: Bug
Components: segment-azure, segment-tar
Reporter: Andrei Dulceanu
Assignee: Andrei Dulceanu
When building Oak with JDK 11 the following error is reported for
{{PersistentDiskCacheTest}}:
{noformat}
[INFO] Running
org.apache.jackrabbit.oak.segment.remote.persistentcache.PersistentDiskCacheTest
[ERROR] Tests run: 6, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.782 s
<<< FAILURE! - in
org.apache.jackrabbit.oak.segment.remote.persistentcache.PersistentDiskCacheTest
[ERROR]
cleanupTest(org.apache.jackrabbit.oak.segment.remote.persistentcache.PersistentDiskCacheTest)
Time elapsed: 1.464 s <<< ERROR!
java.lang.IllegalArgumentException: Comparison method violates its general
contract!
at
org.apache.jackrabbit.oak.segment.remote.persistentcache.PersistentDiskCacheTest.cleanupTest(PersistentDiskCacheTest.java:92)
{noformat}
/cc [~angela]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OAK-9466) APIs to determine the equality of blobs
[ https://issues.apache.org/jira/browse/OAK-9466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ankita Agarwal updated OAK-9466: Description: Very large files that have the same size, but different content hash, Oak (the segment store) downloads the whole binaries to compare them, which is very slow. (was: very large files that have the same size, but different content hash, and Oak (the segment store) downloads the whole binaries to compare them, which is very slow.) > APIs to determine the equality of blobs > > > Key: OAK-9466 > URL: https://issues.apache.org/jira/browse/OAK-9466 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Ankita Agarwal >Priority: Major > > Very large files that have the same size, but different content hash, Oak > (the segment store) downloads the whole binaries to compare them, which is > very slow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OAK-9466) APIs to determine the equality of blobs
Ankita Agarwal created OAK-9466: --- Summary: APIs to determine the equality of blobs Key: OAK-9466 URL: https://issues.apache.org/jira/browse/OAK-9466 Project: Jackrabbit Oak Issue Type: Improvement Reporter: Ankita Agarwal very large files that have the same size, but different content hash, and Oak (the segment store) downloads the whole binaries to compare them, which is very slow. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OAK-9464) Suggestion Results are not deduplicated when ES indexes are used
[
https://issues.apache.org/jira/browse/OAK-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364187#comment-17364187
]
Nitin Gupta commented on OAK-9464:
--
PR [https://github.com/oak-indexing/jackrabbit-oak/pull/509]
> Suggestion Results are not deduplicated when ES indexes are used
>
>
> Key: OAK-9464
> URL: https://issues.apache.org/jira/browse/OAK-9464
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Nitin Gupta
>Priority: Critical
>
> When running the following ES query:
> {code:java}
> POST cm-p11553-e21096-publish._damassetelastic-7-custom-2/_search
> {
> "query": {
> "bool": {
> "must": [
> {
> "nested": {
> "path": ":suggest",
> "query": {
> "match_phrase_prefix": {
> ":suggest.value": {
> "query": "jav"
> }
> }
> }
> }
> }
> ],
> "adjust_pure_negative": true,
> "boost": 1
> }
> }
> }
> {code}
> Following results are retrieved:
> {code:java}
> "NPR-9066 - Backport GRANITE-10700/CQ-65390 to AEM 6.1 - javax.inject
> conflicts"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"{code}
>
>
> Hitting a suggestion query like
> SELECT [rep:suggest()] FROM [dam:Asset] as s WHERE SUGGEST('jav')
> on lucene returns unique results. However with ES, duplicate results are also
> returned.
>
> We need to handle the duplication in oak.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OAK-9464) Suggestion Results are not deduplicated when ES indexes are used
[
https://issues.apache.org/jira/browse/OAK-9464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nitin Gupta reassigned OAK-9464:
Assignee: Nitin Gupta
> Suggestion Results are not deduplicated when ES indexes are used
>
>
> Key: OAK-9464
> URL: https://issues.apache.org/jira/browse/OAK-9464
> Project: Jackrabbit Oak
> Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Critical
>
> When running the following ES query:
> {code:java}
> POST cm-p11553-e21096-publish._damassetelastic-7-custom-2/_search
> {
> "query": {
> "bool": {
> "must": [
> {
> "nested": {
> "path": ":suggest",
> "query": {
> "match_phrase_prefix": {
> ":suggest.value": {
> "query": "jav"
> }
> }
> }
> }
> }
> ],
> "adjust_pure_negative": true,
> "boost": 1
> }
> }
> }
> {code}
> Following results are retrieved:
> {code:java}
> "NPR-9066 - Backport GRANITE-10700/CQ-65390 to AEM 6.1 - javax.inject
> conflicts"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"
> "Oracle Java SE Development Kit 11.0.4"{code}
>
>
> Hitting a suggestion query like
> SELECT [rep:suggest()] FROM [dam:Asset] as s WHERE SUGGEST('jav')
> on lucene returns unique results. However with ES, duplicate results are also
> returned.
>
> We need to handle the duplication in oak.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OAK-9465) [Index Management] Versioned elastic index will get ignored during query execution
Nitin Gupta created OAK-9465: Summary: [Index Management] Versioned elastic index will get ignored during query execution Key: OAK-9465 URL: https://issues.apache.org/jira/browse/OAK-9465 Project: Jackrabbit Oak Issue Type: Bug Reporter: Nitin Gupta Assignee: Nitin Gupta Any elastic index definition with versioned name (elasticTest-1 or elasticTest-1-custom-2 etc) will be ignored during query evaluation. [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/query/IndexName.java]If the indexname is versioned, it will check if the index is active or not // An index is active if it has a hidden child node that starts with ":oak:mount-", // OR if it is an active merged index (have merged property) both of the above properties are not present on elastic indexes, so any elastic index with name elasticTest-1 will get ignored. -- This message was sent by Atlassian Jira (v8.3.4#803005)
