[jira] [Assigned] (OAK-9498) Enable Maven parallel build by default

2021-10-20 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned OAK-9498:


Assignee: (was: Konrad Windszus)

> Enable Maven parallel build by default
> --
>
> Key: OAK-9498
> URL: https://issues.apache.org/jira/browse/OAK-9498
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Priority: Major
>
> To speed up multi module builds [Maven parallel 
> builds|https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3]
>  should be enabled by default via 
> [.mvn/maven.config|https://maven.apache.org/configure.html#mvn-maven-config-file].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-7182) Make it possible to update Guava

2021-10-20 Thread Marco Piovesana (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431277#comment-17431277
 ] 

Marco Piovesana commented on OAK-7182:
--

I'll do that then, thanks [~reschke]

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-9597) Build Jackrabbit/jackrabbit-oak-trunk #368 failed

2021-10-20 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-9597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431250#comment-17431250
 ] 

Hudson commented on OAK-9597:
-

Previously failing build now is OK.
 Passed run: [Jackrabbit/jackrabbit-oak-trunk 
#377|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/377/] 
[console 
log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/377/console]

> Build Jackrabbit/jackrabbit-oak-trunk #368 failed
> -
>
> Key: OAK-9597
> URL: https://issues.apache.org/jira/browse/OAK-9597
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: continuous integration
>Reporter: Hudson
>Priority: Major
>
> No description is provided
> The build Jackrabbit/jackrabbit-oak-trunk #368 has failed.
> First failed run: [Jackrabbit/jackrabbit-oak-trunk 
> #368|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/368/]
>  [console 
> log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/368/console]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-9498) Enable Maven parallel build by default

2021-10-20 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431231#comment-17431231
 ] 

Konrad Windszus commented on OAK-9498:
--

This requires some more preparation as at least the Mongo DB is shared 
(https://github.com/apache/jackrabbit-oak/pull/325#issuecomment-881444200).

> Enable Maven parallel build by default
> --
>
> Key: OAK-9498
> URL: https://issues.apache.org/jira/browse/OAK-9498
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> To speed up multi module builds [Maven parallel 
> builds|https://cwiki.apache.org/confluence/display/MAVEN/Parallel+builds+in+Maven+3]
>  should be enabled by default via 
> [.mvn/maven.config|https://maven.apache.org/configure.html#mvn-maven-config-file].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-7182) Make it possible to update Guava

2021-10-20 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431186#comment-17431186
 ] 

Julian Reschke commented on OAK-7182:
-

I believe the next thing that needs to be done is 
https://issues.apache.org/jira/browse/OAK-8717 - removing all Guava signatures 
from APIs. Last activity on this was exactly two years ago; hopefully no new 
cases have been introduced since.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-7182) Make it possible to update Guava

2021-10-20 Thread Marco Piovesana (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431184#comment-17431184
 ] 

Marco Piovesana commented on OAK-7182:
--

Hi [~angela], that will definitely work for me. Since I have little experience 
with the code, do you think there's something I should start from to get 
familiar with the architecture? Is there anything that conflicts with the issue 
in progress?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-7182) Make it possible to update Guava

2021-10-20 Thread Angela Schreiber (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431149#comment-17431149
 ] 

Angela Schreiber commented on OAK-7182:
---

hi [~iosonomarco], sure you can help i would suggest you pick up any 
remaining issue you would like to contribute and create a PR (oak has been 
migrated from svn to git in the mean time and collaborating on patches is 
probably easier now). would that work for you?

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OAK-7182) Make it possible to update Guava

2021-10-20 Thread Marco Piovesana (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17431117#comment-17431117
 ] 

Marco Piovesana commented on OAK-7182:
--

Hi guys,
is it possible to help in any way with the remaining work required to complete 
this issue? It's getting really hard for us to work around this in our 
application.

Marco.

> Make it possible to update Guava
> 
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
>  Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (OAK-9601) Refine logging to help detect dangling previous document pointers

2021-10-20 Thread Stefan Egli (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-9601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Egli resolved OAK-9601.
--
Resolution: Fixed

> Refine logging to help detect dangling previous document pointers
> -
>
> Key: OAK-9601
> URL: https://issues.apache.org/jira/browse/OAK-9601
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Affects Versions: 1.40.0
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: 1.42.0
>
>
> The log warns similar to the below pattern occur rather regularly:
> {noformat}
> org.apache.jackrabbit.oak.plugins.document.NodeDocument Document with 
> previous revisions not found: 3:p/:async/r1795b3e463c-0-2/0
> {noformat}
> While the root cause is not yet clear, it is likely that this is "only a 
> dangling pointer".
> There were previous cases where something similar occurred: OAK-2377 (also 
> see the referenced OAK-1791)
> In fact, in OAK-2377 the log has been lowered to debug but in the remaining 2 
> cases it is still at warn: NodeDocument.getPreviousDoc and getPreviousDocs.
> This ticket here is about 2 things:
> * lowering the frequency of logging that warn, since it can flood log files 
> if it applies to a frequently read document
> * add some more details to a suspect root cause for further analysis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OAK-9591) Implement hashcode() and equals() method in ItemDefinitionImpl

2021-10-20 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17424464#comment-17424464
 ] 

Konrad Windszus edited comment on OAK-9591 at 10/20/21, 6:42 AM:
-

Fixed in 
# 
https://github.com/apache/jackrabbit-oak/commit/1235d9f24dc26a404b447aef9d6354b45651182c
 (trunk, 1.42)
# 
https://github.com/apache/jackrabbit-oak/commit/826f322f23da4eb3bc15e6fc2c56b7b5f9019ad0
 (1.22)
# 
https://github.com/apache/jackrabbit-oak/commit/957b8370e561b15591bfdebdcfdc50a052c19919
 (1.8)
[~ankitaagar] Thanks for the contribution.


was (Author: kwin):
Fixed in 
https://github.com/apache/jackrabbit-oak/commit/1235d9f24dc26a404b447aef9d6354b45651182c.
[~ankitaagar] Thanks for the contribution.

> Implement hashcode() and equals() method in ItemDefinitionImpl
> --
>
> Key: OAK-9591
> URL: https://issues.apache.org/jira/browse/OAK-9591
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.40.0
>Reporter: Ankita Agarwal
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 1.42.0
>
>
> This is useful in the context of FileVault for this algorithm:
>  * get the {{NodeDefinition}} of the child node that is to be deleted.
>  * loop through all child nodes and count the ones that have the same 
> nodedef. {color:#00875a}To compare that the nodedef is same, it was 
> recommended to add an equals method in ItemDefinitionImpl as per the 
> conversation done on PR 
> [https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r711728698]
>  {color}
>  * if the nodedef is mandatory and there are more than 1 nodes with this 
> nodedef, we can delete it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OAK-9591) Implement hashcode() and equals() method in ItemDefinitionImpl

2021-10-20 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-9591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated OAK-9591:
-
Fix Version/s: 1.22.10
   1.8.25

> Implement hashcode() and equals() method in ItemDefinitionImpl
> --
>
> Key: OAK-9591
> URL: https://issues.apache.org/jira/browse/OAK-9591
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: core
>Affects Versions: 1.40.0
>Reporter: Ankita Agarwal
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 1.8.25, 1.42.0, 1.22.10
>
>
> This is useful in the context of FileVault for this algorithm:
>  * get the {{NodeDefinition}} of the child node that is to be deleted.
>  * loop through all child nodes and count the ones that have the same 
> nodedef. {color:#00875a}To compare that the nodedef is same, it was 
> recommended to add an equals method in ItemDefinitionImpl as per the 
> conversation done on PR 
> [https://github.com/apache/jackrabbit-filevault/pull/163#discussion_r711728698]
>  {color}
>  * if the nodedef is mandatory and there are more than 1 nodes with this 
> nodedef, we can delete it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)