[jira] [Comment Edited] (OAK-9708) Invalid logging of 'improper' regex WARN

[Tom Blackford (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498621#comment-17498621
 ] 

Tom Blackford edited comment on OAK-9708 at 2/27/22, 4:35 PM:
--

PR merged; now any property restriction beginning with ':' (ie :indexName, 
:indexTag etc) will be ignored.


was (Author: rma61...@adobe.com):
PR merged.

> Invalid logging of 'improper' regex WARN
> 
>
> Key: OAK-9708
> URL: https://issues.apache.org/jira/browse/OAK-9708
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing
>Reporter: Tom Blackford
>Priority: Minor
>
> A query like this:
> {code}
> //*[jcr:contains(., '"/my/path"')] option(index tag testTag) 
> {code}
> ...which uses an index with a path regex, will log a WARN like :
> {code}
> Potentially improper use of index /oak:index/regexIndex with queryFilterRegex 
> (["']|^)/ to search for value testTag
> {code}
> because of the presence of the property restriction ":indexTag" (from the 
> index tag option) being incorrectly considered to be a property restriction 
> which must match regex.
> This should be ignored in the logic here -  
> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/query/FulltextIndexPlanner.java#L308-L319



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (OAK-9708) Invalid logging of 'improper' regex WARN

[Tom Blackford (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-9708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17498621#comment-17498621
 ] 

Tom Blackford commented on OAK-9708:


PR merged.

> Invalid logging of 'improper' regex WARN
> 
>
> Key: OAK-9708
> URL: https://issues.apache.org/jira/browse/OAK-9708
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: indexing
>Reporter: Tom Blackford
>Priority: Minor
>
> A query like this:
> {code}
> //*[jcr:contains(., '"/my/path"')] option(index tag testTag) 
> {code}
> ...which uses an index with a path regex, will log a WARN like :
> {code}
> Potentially improper use of index /oak:index/regexIndex with queryFilterRegex 
> (["']|^)/ to search for value testTag
> {code}
> because of the presence of the property restriction ":indexTag" (from the 
> index tag option) being incorrectly considered to be a property restriction 
> which must match regex.
> This should be ignored in the logic here -  
> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-search/src/main/java/org/apache/jackrabbit/oak/plugins/index/search/spi/query/FulltextIndexPlanner.java#L308-L319



--
This message was sent by Atlassian Jira
(v8.20.1#820001)