[jira] [Created] (OAK-9815) Add Path to the Node in the logs in order to better debug
Patrique Legault created OAK-9815: - Summary: Add Path to the Node in the logs in order to better debug Key: OAK-9815 URL: https://issues.apache.org/jira/browse/OAK-9815 Project: Jackrabbit Oak Issue Type: Improvement Components: core Reporter: Patrique Legault When debugging issues related to Oak it would be nice to see the path that was attempted to be operated in order to understand where the Oak error started from. Can we include the Node Path in the logs that caused the IllegalArgumentException *https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/core/MutableTree.java#L351* -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-9805) Build Jackrabbit/jackrabbit-oak-trunk #538 failed
[ https://issues.apache.org/jira/browse/OAK-9805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558458#comment-17558458 ] Hudson commented on OAK-9805: - Previously failing build now is OK. Passed run: [Jackrabbit/jackrabbit-oak-trunk #550|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/550/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/550/console] > Build Jackrabbit/jackrabbit-oak-trunk #538 failed > - > > Key: OAK-9805 > URL: https://issues.apache.org/jira/browse/OAK-9805 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit/jackrabbit-oak-trunk #538 has failed. > First failed run: [Jackrabbit/jackrabbit-oak-trunk > #538|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/538/] > [console > log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/538/console] -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558439#comment-17558439 ] Julian Reschke commented on OAK-7182: - As far as I recall, we have all Guava-tainted APIs deprecated and replacements in place (unless somebody introduced new ones since). Before we can *remove* the deprecated APIs, we'll need to figure out the consequences of that in the projects that use Oak. Onfortunately, that doesn't get the attention it should. Once we have removedthe deprecated APIs in Oak, we are free to decide on the next steps. > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Priority: Minor > Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, > OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, > guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558438#comment-17558438 ] Dawid Iwo Cokan commented on OAK-7182: -- I am available to support decoupling task. As I understand next task would be to replace guava references for other bundles (OAK-8857). But from this thread I understood there are public APIs that depends on Guava. What is a plan for those? We still have to depend on Guava to avoid major upgrade, correct? > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Priority: Minor > Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, > OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, > guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558430#comment-17558430 ] Julian Reschke commented on OAK-7182: - The issue is that there are *users* of Oak who currently assume Guava 15 is present; we need to decouple our own use from everybody else's use to make progress, I understand the update issue. If there is a new Guava issue, that means we'll have to update and release Guava; but that's not that different from any other security issue. > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Priority: Minor > Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, > OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, > guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558428#comment-17558428
]
Dawid Iwo Cokan commented on OAK-7182:
--
{quote}the question whether we use Guava, and if so how (directly, or by
shading it) becomes secondary.
{quote}
Yes. But it has serious implication. Personally I am not fan of shading for
following reason. Consider you shade Guava and noone has to care about version
used. At the same time noone can change it. What if tomorrow new security
vulnerability is detected? In such case anyone who uses OAK with given version
cannot get rid of it until we release new OAK that will embed fixed Guava.
Saying this I feel shading stands in a contrary with idea of maven and other
packages management tool.
If you feel upgrade to Guava 22 makes sense I can prepare patch. I tried
locally seems to be easy adoption
> Make it possible to update Guava
>
>
> Key: OAK-7182
> URL: https://issues.apache.org/jira/browse/OAK-7182
> Project: Jackrabbit Oak
> Issue Type: Wish
>Reporter: Julian Reschke
>Priority: Minor
> Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff,
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff,
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in
> order to make updates possible.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558382#comment-17558382 ] Julian Reschke commented on OAK-7182: - bq. Depend on 22.0 Guava It sounds plausible, but my recollection is that we decided to erase Guava from our exported APIs. When we have done that, the question whether we use Guava, and if so how (directly, or by shading it) becomes secondary. Of course more discussion is good; in essence it's about how much we want to trust Guava's evolution (and whether it's even needed given evolution of JDKs). > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Priority: Minor > Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, > OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, > guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OAK-7182) Make it possible to update Guava
[ https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558379#comment-17558379 ] Julian Reschke commented on OAK-7182: - bq. Include Guava Beta Checker in build chain to ensure no code depends on code that potentially does not exist in future releases We already have that configured; try "mvn clean install -Pguavabetachecks -DskipTests" > Make it possible to update Guava > > > Key: OAK-7182 > URL: https://issues.apache.org/jira/browse/OAK-7182 > Project: Jackrabbit Oak > Issue Type: Wish >Reporter: Julian Reschke >Priority: Minor > Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, > OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, > guava.diff > > > We currently rely on Guava 15, and this affects all users of Oak because they > essentially need to use the same version. > This is an overall issue to investigate what would need to be done in Oak in > order to make updates possible. -- This message was sent by Atlassian Jira (v8.20.7#820007)
