[jira] [Commented] (OAK-10144) release:prepare fails for oak-run due to Javadoc issues
[
https://issues.apache.org/jira/browse/OAK-10144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700755#comment-17700755
]
Julian Reschke commented on OAK-10144:
--
Reproducable with:
{noformat}
mvn clean install -DskipTests javadoc:javadoc
{noformat}
from reactor pom. Bisecting gives:
{noformat}
commit caf43a19c505bb02afa237153c55d68c2630817f
Author: Julian Reschke
Date: Fri Jan 27 18:12:55 2023 +0100
OAK-10001: Bump up minimal Java version to 11 (#823)
{noformat}
Not completely surprisingly...
> release:prepare fails for oak-run due to Javadoc issues
> ---
>
> Key: OAK-10144
> URL: https://issues.apache.org/jira/browse/OAK-10144
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: run
>Reporter: Julian Reschke
>Priority: Major
>
> mvn clean install -Papache-release:
> {noformat}
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 57:41 min
> [INFO] Finished at: 2023-03-14T15:08:48+01:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.4.1:jar (attach-javadocs) on
> project oak-run: MavenReportException: Error while generating Javadoc:
> [ERROR] Exit code: 1 -
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/index/SegmentPropertyIndexEditorProvider.java:46:
> error: package org.jetbrains.annotations is not visible
> [ERROR] import org.jetbrains.annotations.NotNull;
> [ERROR] ^
> [ERROR] (package org.jetbrains.annotations is declared in the unnamed
> module, but module org.jetbrains.annotations does not read it)
> [ERROR]
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/index/SegmentPropertyIndexEditorProvider.java:47:
> error: package org.jetbrains.annotations is not visible
> [ERROR] import org.jetbrains.annotations.Nullable;
> [ERROR] ^
> [ERROR] (package org.jetbrains.annotations is declared in the unnamed
> module, but module org.jetbrains.annotations does not read it)
> [ERROR]
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/index/IndexCommand.java:49:
> error: package java.lang.management is not visible
> [ERROR] import java.lang.management.ManagementFactory;
> [ERROR] ^
> [ERROR] (package java.lang.management is declared in module
> java.management, but module com.fasterxml.jackson.dataformat.cbor does not
> read it)
> [ERROR]
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/explorer/Explorer.java:26:
> error: package javax.swing is not visible
> [ERROR] import javax.swing.*;
> [ERROR] ^
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-10144) release:prepare fails for oak-run due to Javadoc issues
[
https://issues.apache.org/jira/browse/OAK-10144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700666#comment-17700666
]
Julian Reschke commented on OAK-10144:
--
(mvn javadoc:javadoc in same subproject works ok)
> release:prepare fails for oak-run due to Javadoc issues
> ---
>
> Key: OAK-10144
> URL: https://issues.apache.org/jira/browse/OAK-10144
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: run
>Reporter: Julian Reschke
>Priority: Major
>
> mvn clean install -Papache-release:
> {noformat}
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 57:41 min
> [INFO] Finished at: 2023-03-14T15:08:48+01:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.4.1:jar (attach-javadocs) on
> project oak-run: MavenReportException: Error while generating Javadoc:
> [ERROR] Exit code: 1 -
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/index/SegmentPropertyIndexEditorProvider.java:46:
> error: package org.jetbrains.annotations is not visible
> [ERROR] import org.jetbrains.annotations.NotNull;
> [ERROR] ^
> [ERROR] (package org.jetbrains.annotations is declared in the unnamed
> module, but module org.jetbrains.annotations does not read it)
> [ERROR]
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/index/SegmentPropertyIndexEditorProvider.java:47:
> error: package org.jetbrains.annotations is not visible
> [ERROR] import org.jetbrains.annotations.Nullable;
> [ERROR] ^
> [ERROR] (package org.jetbrains.annotations is declared in the unnamed
> module, but module org.jetbrains.annotations does not read it)
> [ERROR]
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/index/IndexCommand.java:49:
> error: package java.lang.management is not visible
> [ERROR] import java.lang.management.ManagementFactory;
> [ERROR] ^
> [ERROR] (package java.lang.management is declared in module
> java.management, but module com.fasterxml.jackson.dataformat.cbor does not
> read it)
> [ERROR]
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/explorer/Explorer.java:26:
> error: package javax.swing is not visible
> [ERROR] import javax.swing.*;
> [ERROR] ^
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-10116) Performance problem when importing nodes with many binary properties and remote blobstore
[
https://issues.apache.org/jira/browse/OAK-10116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700549#comment-17700549
]
Timothee Maret commented on OAK-10116:
--
Assuming that checking for the blob presence is required, it may be possible to
check by batches and/or check asynchronously.
> Performance problem when importing nodes with many binary properties and
> remote blobstore
> -
>
> Key: OAK-10116
> URL: https://issues.apache.org/jira/browse/OAK-10116
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: blob-cloud, blob-plugins, jcr
>Affects Versions: 1.48.0
>Reporter: Joerg Hoh
>Priority: Major
>
> We often import binaryless packages (using JR filevault) into our Oak
> instances, which are using a remote blobstore.
> We observe bad performance when we import nodes with binary properties. In
> this case stacktraces often look like this:
> {noformat}
> "Queue Processor for Subscriber agent publishSubscriber" #311 daemon prio=5
> os_prio=0 cpu=298928.76ms elapsed=576.04s tid=0x563f968c6800 nid=0x1644
> runnable [0x7f2a609e3000]
>java.lang.Thread.State: RUNNABLE
> at java.net.SocketInputStream.socketRead0(java.base@11.0.15/Native
> Method)
> at
> java.net.SocketInputStream.socketRead(java.base@11.0.15/SocketInputStream.java:115)
> at
> java.net.SocketInputStream.read(java.base@11.0.15/SocketInputStream.java:168)
> at
> java.net.SocketInputStream.read(java.base@11.0.15/SocketInputStream.java:140)
> at
> sun.security.ssl.SSLSocketInputRecord.read(java.base@11.0.15/SSLSocketInputRecord.java:478)
> at
> sun.security.ssl.SSLSocketInputRecord.readHeader(java.base@11.0.15/SSLSocketInputRecord.java:472)
> at
> sun.security.ssl.SSLSocketInputRecord.bytesInCompletePacket(java.base@11.0.15/SSLSocketInputRecord.java:70)
> at
> sun.security.ssl.SSLSocketImpl.readApplicationRecord(java.base@11.0.15/SSLSocketImpl.java:1328)
> at
> sun.security.ssl.SSLSocketImpl$AppInputStream.read(java.base@11.0.15/SSLSocketImpl.java:971)
> at
> java.io.BufferedInputStream.fill(java.base@11.0.15/BufferedInputStream.java:252)
> at
> java.io.BufferedInputStream.read1(java.base@11.0.15/BufferedInputStream.java:292)
> at
> java.io.BufferedInputStream.read(java.base@11.0.15/BufferedInputStream.java:351)
> - locked <0x0007d98d0ca8> (a java.io.BufferedInputStream)
> at
> sun.net.www.http.HttpClient.parseHTTPHeader(java.base@11.0.15/HttpClient.java:746)
> at
> sun.net.www.http.HttpClient.parseHTTP(java.base@11.0.15/HttpClient.java:689)
> at
> sun.net.www.protocol.http.HttpURLConnection.getInputStream0(java.base@11.0.15/HttpURLConnection.java:1615)
> - locked <0x0007d98cb480> (a
> sun.net.www.protocol.https.DelegateHttpsURLConnection)
> at
> sun.net.www.protocol.http.HttpURLConnection.getInputStream(java.base@11.0.15/HttpURLConnection.java:1520)
> - locked <0x0007d98cb480> (a
> sun.net.www.protocol.https.DelegateHttpsURLConnection)
> at
> java.net.HttpURLConnection.getResponseCode(java.base@11.0.15/HttpURLConnection.java:527)
> at
> sun.net.www.protocol.https.HttpsURLConnectionImpl.getResponseCode(java.base@11.0.15/HttpsURLConnectionImpl.java:334)
> at
> com.microsoft.azure.storage.core.ExecutionEngine.executeWithRetry(ExecutionEngine.java:115)
> at
> com.microsoft.azure.storage.blob.CloudBlob.downloadAttributes(CloudBlob.java:1414)
> at
> com.microsoft.azure.storage.blob.CloudBlob.downloadAttributes(CloudBlob.java:1381)
> at
> org.apache.jackrabbit.oak.blob.cloud.azure.blobstorage.AzureBlobStoreBackend.getRecord(AzureBlobStoreBackend.java:408)
> at
> org.apache.jackrabbit.oak.plugins.blob.AbstractSharedCachingDataStore.getRecordIfStored(AbstractSharedCachingDataStore.java:210)
> at
> org.apache.jackrabbit.core.data.AbstractDataStore.getRecordFromReference(AbstractDataStore.java:72)
> at
> org.apache.jackrabbit.oak.plugins.blob.datastore.DataStoreBlobStore.getBlobId(DataStoreBlobStore.java:402)
> at
> org.apache.jackrabbit.oak.segment.SegmentNodeStore.getBlob(SegmentNodeStore.java:257)
> at
> org.apache.jackrabbit.oak.composite.CompositeNodeStore.getBlob(CompositeNodeStore.java:202)
> at
> org.apache.jackrabbit.oak.core.MutableRoot.getBlob(MutableRoot.java:342)
> at
> org.apache.jackrabbit.oak.plugins.value.jcr.ValueFactoryImpl.createValue(ValueFactoryImpl.java:111)
> at
> org.apache.jackrabbit.vault.util.DocViewProperty.apply(DocViewProperty.java:413)
> at
>
