[jira] [Assigned] (OAK-10114) Node diff with many changes uses excessive memory
[ https://issues.apache.org/jira/browse/OAK-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger reassigned OAK-10114: -- Assignee: Marcel Reutegger > Node diff with many changes uses excessive memory > - > > Key: OAK-10114 > URL: https://issues.apache.org/jira/browse/OAK-10114 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Rishabh Kumar >Assignee: Marcel Reutegger >Priority: Major > > Calculating the diff on a node with many changes on child nodes uses > excessive memory. The implementation in Oak loads all NodeDocuments into > memory that changed between two given revisions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-10114) Node diff with many changes uses excessive memory
[ https://issues.apache.org/jira/browse/OAK-10114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marcel Reutegger resolved OAK-10114. Fix Version/s: 1.50.0 Resolution: Fixed PR looks good. Merged it into trunk. > Node diff with many changes uses excessive memory > - > > Key: OAK-10114 > URL: https://issues.apache.org/jira/browse/OAK-10114 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Rishabh Kumar >Assignee: Marcel Reutegger >Priority: Major > Fix For: 1.50.0 > > > Calculating the diff on a node with many changes on child nodes uses > excessive memory. The implementation in Oak loads all NodeDocuments into > memory that changed between two given revisions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-10143) Issue when oak-upgrade fetch all the namespaces from very old jackrabbit 2 repository
[ https://issues.apache.org/jira/browse/OAK-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miguel Moquillon updated OAK-10143: --- Affects Version/s: 1.48.0 > Issue when oak-upgrade fetch all the namespaces from very old jackrabbit 2 > repository > - > > Key: OAK-10143 > URL: https://issues.apache.org/jira/browse/OAK-10143 > Project: Jackrabbit Oak > Issue Type: Bug >Affects Versions: 1.48.0 >Reporter: Miguel Moquillon >Priority: Major > Attachments: ns_reg.properties > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-10143) Issue when oak-upgrade fetch all the namespaces from very old jackrabbit 2 repository
[ https://issues.apache.org/jira/browse/OAK-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miguel Moquillon updated OAK-10143: --- Component/s: upgrade > Issue when oak-upgrade fetch all the namespaces from very old jackrabbit 2 > repository > - > > Key: OAK-10143 > URL: https://issues.apache.org/jira/browse/OAK-10143 > Project: Jackrabbit Oak > Issue Type: Bug > Components: upgrade >Affects Versions: 1.48.0 >Reporter: Miguel Moquillon >Priority: Major > Attachments: ns_reg.properties > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] (OAK-10143) Issue when oak-upgrade fetch all the namespaces from very old jackrabbit 2 repository
[ https://issues.apache.org/jira/browse/OAK-10143 ]
Miguel Moquillon deleted comment on OAK-10143:
was (Author: mmoquillon):
With some old jackrabbit 2 repositories, the
{code:java}
JCR_HOME/repository/namespaces/ns_reg.properties{code}
file contains as namespace an empty string instead of the predefined name
_empty.key_ for empty namespace.
See attachments as an example.
In such circumstances, the upgrade of the Jackrabbit 2 JCR to the Oak one fails
because the preconditions of a non null or a non empty property name isn't
satisfied (checked by {{{}AbstractNodeState#checkValidName(String){}}}).
A way to avoid this is to check the emptiness of the {{prefixHint}} variable in
{{RepositoryUpgrade#copyNamespaces(...)}} like this:
{code:java}
if (".empty.key".equals(prefixHint) || prefixHint.isEmpty()) {
prefix = ""; // the default empty mapping is not stored
} else {
prefix = addCustomMapping(namespaces, uri, prefixHint);
}{code}
> Issue when oak-upgrade fetch all the namespaces from very old jackrabbit 2
> repository
> -
>
> Key: OAK-10143
> URL: https://issues.apache.org/jira/browse/OAK-10143
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Affects Versions: 1.48.0
>Reporter: Miguel Moquillon
>Priority: Major
> Attachments: ns_reg.properties
>
>
> With some old jackrabbit 2 repositories, the
> {code:java}
> JCR_HOME/repository/namespaces/ns_reg.properties{code}
> file contains as namespace an empty string instead of the predefined name
> _empty.key_ for empty namespace.
> See attachments as an example.
> In such circumstances, the upgrade of the Jackrabbit 2 JCR to the Oak one
> fails because the preconditions of a non null or a non empty property name
> isn't satisfied (checked by {{{}AbstractNodeState#checkValidName(String){}}}).
> A way to avoid this is to check the emptiness of the {{prefixHint}} variable
> in {{RepositoryUpgrade#copyNamespaces(...)}} like this:
> {code:java}
> if (".empty.key".equals(prefixHint) || prefixHint.isEmpty()) {
> prefix = ""; // the default empty mapping is not stored
> } else {
> prefix = addCustomMapping(namespaces, uri, prefixHint);
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-10143) Issue when oak-upgrade fetch all the namespaces from very old jackrabbit 2 repository
[
https://issues.apache.org/jira/browse/OAK-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Miguel Moquillon updated OAK-10143:
---
Description:
With some old jackrabbit 2 repositories, the
{code:java}
JCR_HOME/repository/namespaces/ns_reg.properties{code}
file contains as namespace an empty string instead of the predefined name
_empty.key_ for empty namespace.
See attachments as an example.
In such circumstances, the upgrade of the Jackrabbit 2 JCR to the Oak one fails
because the preconditions of a non null or a non empty property name isn't
satisfied (checked by {{{}AbstractNodeState#checkValidName(String){}}}).
A way to avoid this is to check the emptiness of the {{prefixHint}} variable in
{{RepositoryUpgrade#copyNamespaces(...)}} like this:
{code:java}
if (".empty.key".equals(prefixHint) || prefixHint.isEmpty()) {
prefix = ""; // the default empty mapping is not stored
} else {
prefix = addCustomMapping(namespaces, uri, prefixHint);
}{code}
> Issue when oak-upgrade fetch all the namespaces from very old jackrabbit 2
> repository
> -
>
> Key: OAK-10143
> URL: https://issues.apache.org/jira/browse/OAK-10143
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: upgrade
>Affects Versions: 1.48.0
>Reporter: Miguel Moquillon
>Priority: Major
> Attachments: ns_reg.properties
>
>
> With some old jackrabbit 2 repositories, the
> {code:java}
> JCR_HOME/repository/namespaces/ns_reg.properties{code}
> file contains as namespace an empty string instead of the predefined name
> _empty.key_ for empty namespace.
> See attachments as an example.
> In such circumstances, the upgrade of the Jackrabbit 2 JCR to the Oak one
> fails because the preconditions of a non null or a non empty property name
> isn't satisfied (checked by {{{}AbstractNodeState#checkValidName(String){}}}).
> A way to avoid this is to check the emptiness of the {{prefixHint}} variable
> in {{RepositoryUpgrade#copyNamespaces(...)}} like this:
> {code:java}
> if (".empty.key".equals(prefixHint) || prefixHint.isEmpty()) {
> prefix = ""; // the default empty mapping is not stored
> } else {
> prefix = addCustomMapping(namespaces, uri, prefixHint);
> }{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-10142) Build Jackrabbit/jackrabbit-oak-trunk #852 failed
[ https://issues.apache.org/jira/browse/OAK-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701095#comment-17701095 ] Hudson commented on OAK-10142: -- Build is still failing. Failed run: [Jackrabbit/jackrabbit-oak-trunk #858|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/858/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/858/console] > Build Jackrabbit/jackrabbit-oak-trunk #852 failed > - > > Key: OAK-10142 > URL: https://issues.apache.org/jira/browse/OAK-10142 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit/jackrabbit-oak-trunk #852 has failed. > First failed run: [Jackrabbit/jackrabbit-oak-trunk > #852|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/852/] > [console > log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/852/console] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10144) release:prepare fails for oak-run due to Javadoc issues
[
https://issues.apache.org/jira/browse/OAK-10144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701124#comment-17701124
]
Julian Reschke commented on OAK-10144:
--
Observation: In oak-run:
{noformat}
mvn clean javadoc:javadoc
{noformat}
passes, but
{noformat}
mvn clean install javadoc:javadoc
{noformat}
fails. So it seems to be related to the actual build step - maybe wrt how we
assemble the oak-run jar?
> release:prepare fails for oak-run due to Javadoc issues
> ---
>
> Key: OAK-10144
> URL: https://issues.apache.org/jira/browse/OAK-10144
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: run
>Reporter: Julian Reschke
>Priority: Major
>
> mvn clean install -Papache-release:
> {noformat}
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 57:41 min
> [INFO] Finished at: 2023-03-14T15:08:48+01:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.4.1:jar (attach-javadocs) on
> project oak-run: MavenReportException: Error while generating Javadoc:
> [ERROR] Exit code: 1 -
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/index/SegmentPropertyIndexEditorProvider.java:46:
> error: package org.jetbrains.annotations is not visible
> [ERROR] import org.jetbrains.annotations.NotNull;
> [ERROR] ^
> [ERROR] (package org.jetbrains.annotations is declared in the unnamed
> module, but module org.jetbrains.annotations does not read it)
> [ERROR]
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/index/SegmentPropertyIndexEditorProvider.java:47:
> error: package org.jetbrains.annotations is not visible
> [ERROR] import org.jetbrains.annotations.Nullable;
> [ERROR] ^
> [ERROR] (package org.jetbrains.annotations is declared in the unnamed
> module, but module org.jetbrains.annotations does not read it)
> [ERROR]
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/index/IndexCommand.java:49:
> error: package java.lang.management is not visible
> [ERROR] import java.lang.management.ManagementFactory;
> [ERROR] ^
> [ERROR] (package java.lang.management is declared in module
> java.management, but module com.fasterxml.jackson.dataformat.cbor does not
> read it)
> [ERROR]
> /home/jre/jackrabbit-oak/oak-run/src/main/java/org/apache/jackrabbit/oak/explorer/Explorer.java:26:
> error: package javax.swing is not visible
> [ERROR] import javax.swing.*;
> [ERROR] ^
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OAK-10146) oak-search-elastic: similarity search does not work for some nodes
Fabrizio Fortino created OAK-10146: -- Summary: oak-search-elastic: similarity search does not work for some nodes Key: OAK-10146 URL: https://issues.apache.org/jira/browse/OAK-10146 Project: Jackrabbit Oak Issue Type: Bug Components: elastic-search Reporter: Fabrizio Fortino Assignee: Fabrizio Fortino -- This message was sent by Atlassian Jira (v8.20.10#820010)
