[jira] [Commented] (OAK-10535) Clean up old revisions in a document

2024-03-04 Thread Jira


[ 
https://issues.apache.org/jira/browse/OAK-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823233#comment-17823233
 ] 

José Andrés Cordero Benítez commented on OAK-10535:
---

Created PR [https://github.com/apache/jackrabbit-oak/pull/1328] with current 
status.

To be refined after https://issues.apache.org/jira/browse/OAK-10535 is ready, 
in DetailedGC branch.

> Clean up old revisions in a document
> 
>
> Key: OAK-10535
> URL: https://issues.apache.org/jira/browse/OAK-10535
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Minor
>
> Introduce a way to safely detect and delete old revisions in a document. This 
> could be useful to cleanup documents that sometimes grows above the supported 
> size in MongoDB (16MB).
> It could be also integrate into the detailed GC.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10689) Extend oak-run revisions command with "detail" garbage collection

2024-03-04 Thread Jira


[ 
https://issues.apache.org/jira/browse/OAK-10689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823232#comment-17823232
 ] 

José Andrés Cordero Benítez commented on OAK-10689:
---

Contained as part of PR: [https://github.com/apache/jackrabbit-oak/pull/1328] 

Note part of that PR is prototype code that will be refined in the DetailedGC 
branch after https://issues.apache.org/jira/browse/OAK-10688 is ready.

> Extend oak-run revisions command with "detail" garbage collection
> -
>
> Key: OAK-10689
> URL: https://issues.apache.org/jira/browse/OAK-10689
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: oak-run
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Minor
>
> Extend the oak-run revisions command to perform a detailed cleanup on a given 
> document.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10526) split doc can contain still referenced revisions without _sdMaxRevTime indicating so

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823224#comment-17823224
 ] 

Julian Reschke commented on OAK-10526:
--

trunk: 
[6c3b65812f|https://github.com/apache/jackrabbit-oak/commit/6c3b65812fa0a7088b353488e0219c93f3dde30b]
 (1.60.0) 
[e73cb97510|https://github.com/apache/jackrabbit-oak/commit/e73cb9751072a5733d3045c8f1ffd42405a663e5]
 
[5be575223d|https://github.com/apache/jackrabbit-oak/commit/5be575223d2f60470e795ffb10a78520f76195cb]
 
[9f8b7d8502|https://github.com/apache/jackrabbit-oak/commit/9f8b7d8502e2e61c74d6d593e831bd2b5ced5a3f]

> split doc can contain still referenced revisions without _sdMaxRevTime 
> indicating so
> 
>
> Key: OAK-10526
> URL: https://issues.apache.org/jira/browse/OAK-10526
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Affects Versions: 1.58.0
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: 1.60.0
>
>
> When a document grows too large, part of it is split into previous documents. 
> Those also called split documents are marked with _sdMaxRevTime reflecting 
> the newest (max) revision timestamp the document contains. GC later can 
> delete split documents where _sdMaxRevTime is older than 24h or any existing 
> checkpoint. This is based on the assumption that _sdMaxRevTime can be 
> compared to "older than 24h or any existing checkpoint" - while _sdMaxRevTime 
> only indicates the newest revision contained within. There can thus be a 
> situation when a split document contains a revision that is still referenced 
> by a current (not older than 24h) head revision or a checkpoint - but 
> _sdMaxRevTime is old enough for GC to remove that split doc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10626) Rework oak-segment-azure OSGi wirings after embedding azure libraries needed for service principals support

2024-03-04 Thread Miroslav Smiljanic (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823222#comment-17823222
 ] 

Miroslav Smiljanic commented on OAK-10626:
--

hi [~reschke], I will check this out. 

> Rework oak-segment-azure OSGi wirings after embedding azure libraries needed 
> for service principals support
> ---
>
> Key: OAK-10626
> URL: https://issues.apache.org/jira/browse/OAK-10626
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: osgi, segment-azure
>Reporter: Andrei Dulceanu
>Assignee: Miroslav Smiljanic
>Priority: Minor
> Fix For: 1.62.0
>
>
> After fixing OAK-10604 I observed that there is a series of warnings which 
> appear at each build:
> {noformat}
> [INFO] --- maven-bundle-plugin:5.1.8:bundle (default-bundle) @ 
> oak-segment-azure ---
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Unused 
> Import-Package instructions: [com.nimbusds.jose*, com.nimbusds.oauth2.sdk*, 
> com.nimbusds.openid.connect.sdk*, com.nimbusds.secevent.sdk*]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage,  has 4,  private references 
> [com.microsoft.azure.storage.analytics, com.microsoft.azure.storage.file, 
> com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.core,  has 2,  private references 
> [com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.blob,  has 2,  private references 
> [com.microsoft.azure.keyvault.core, com.microsoft.azure.storage.file]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.azure.identity,  has 5,  private references 
> [com.azure.core.client.traits, com.azure.core.exception, com.azure.core.http, 
> com.azure.core.http.policy, com.azure.core.util] {noformat}
> It would be nice to fix these, to remove unnecessary clutter from the build 
> log.
> /cc [~miroslav]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10591) Bump netty dependency from 4.1.96.Final to 4.1.104.Final

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823221#comment-17823221
 ] 

Julian Reschke commented on OAK-10591:
--

trunk: 
[6e5b58060b|https://github.com/apache/jackrabbit-oak/commit/6e5b58060bca300e3a0e9a43e8be1c7a52b95840]
1.22: 
[b348485e4c|https://github.com/apache/jackrabbit-oak/commit/b348485e4c938a685136f56849c06235f1209aaa]


> Bump netty dependency from 4.1.96.Final to 4.1.104.Final
> 
>
> Key: OAK-10591
> URL: https://issues.apache.org/jira/browse/OAK-10591
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: segment-tar
>Reporter: Andrei Dulceanu
>Assignee: Andrei Dulceanu
>Priority: Major
>  Labels: vulnerability
> Fix For: 1.22.19, 1.62.0
>
>
> *File Matche(s):*
> /netty-common-4.1.96.Final.jar
> *Vulnerabilitie(s)*
> This artifact embeds Netty Project 4.1.96.Final which contains the following 
> vulnerabilitie(s):
> *BDSA-2023-2732/CVE-2023-44487* in version 4.1.96.Final (CVSS 7.5 High): The 
> HTTP/2 protocol contains a flaw related to the stream multiplexing feature 
> that can allow for excessive resource consumption on servers operating 
> implementations of the HTTP/2 protocol. The HTTP/2 protocol allows clients to 
> signal to a server to cancel a previously opened stream by sending an 
> `RST_STREAM` frame. Attackers can abuse this stream canceling ability by 
> opening a large number of streams at once immediately followed by 
> `RST_STREAM` frames. In most HTTP/2 implementations this bypasses concurrent 
> open stream limits and causes servers to spend processing time first handling 
> request frames and then performing stream tear downs. For the server, these 
> operations can pile up whereas the attacker client paid minuscule bandwidth 
> and processing costs. 
> [Amazon](https://aws.amazon.com/security/security-bulletins/AWS-2023-011/), 
> [Cloudflare](https://blog.cloudflare.com/technical-breakdown-http2-rapid-reset-ddos-attack/)
>  and 
> [Google](https://cloud.google.com/blog/products/identity-security/google-cloud-mitigated-largest-ddos-attack-peaking-above-398-million-rps/)
>  have reported that this vulnerability has been exploited in the wild from 
> August to October 2023. This vulnerability is listed as exploitable by the 
> Cybersecurity & Infrastructure Security Agency in their [Known Exploited 
> Vulnerabilities 
> Catalog](https://www.cisa.gov/known-exploited-vulnerabilities-catalog).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10626) Rework oak-segment-azure OSGi wirings after embedding azure libraries needed for service principals support

2024-03-04 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-10626:
-
Fix Version/s: 1.62.0

> Rework oak-segment-azure OSGi wirings after embedding azure libraries needed 
> for service principals support
> ---
>
> Key: OAK-10626
> URL: https://issues.apache.org/jira/browse/OAK-10626
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: osgi, segment-azure
>Reporter: Andrei Dulceanu
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.62.0
>
>
> After fixing OAK-10604 I observed that there is a series of warnings which 
> appear at each build:
> {noformat}
> [INFO] --- maven-bundle-plugin:5.1.8:bundle (default-bundle) @ 
> oak-segment-azure ---
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Unused 
> Import-Package instructions: [com.nimbusds.jose*, com.nimbusds.oauth2.sdk*, 
> com.nimbusds.openid.connect.sdk*, com.nimbusds.secevent.sdk*]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage,  has 4,  private references 
> [com.microsoft.azure.storage.analytics, com.microsoft.azure.storage.file, 
> com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.core,  has 2,  private references 
> [com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.blob,  has 2,  private references 
> [com.microsoft.azure.keyvault.core, com.microsoft.azure.storage.file]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.azure.identity,  has 5,  private references 
> [com.azure.core.client.traits, com.azure.core.exception, com.azure.core.http, 
> com.azure.core.http.policy, com.azure.core.util] {noformat}
> It would be nice to fix these, to remove unnecessary clutter from the build 
> log.
> /cc [~miroslav]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OAK-10626) Rework oak-segment-azure OSGi wirings after embedding azure libraries needed for service principals support

2024-03-04 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned OAK-10626:


Assignee: Miroslav Smiljanic  (was: Julian Reschke)

> Rework oak-segment-azure OSGi wirings after embedding azure libraries needed 
> for service principals support
> ---
>
> Key: OAK-10626
> URL: https://issues.apache.org/jira/browse/OAK-10626
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: osgi, segment-azure
>Reporter: Andrei Dulceanu
>Assignee: Miroslav Smiljanic
>Priority: Minor
> Fix For: 1.62.0
>
>
> After fixing OAK-10604 I observed that there is a series of warnings which 
> appear at each build:
> {noformat}
> [INFO] --- maven-bundle-plugin:5.1.8:bundle (default-bundle) @ 
> oak-segment-azure ---
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Unused 
> Import-Package instructions: [com.nimbusds.jose*, com.nimbusds.oauth2.sdk*, 
> com.nimbusds.openid.connect.sdk*, com.nimbusds.secevent.sdk*]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage,  has 4,  private references 
> [com.microsoft.azure.storage.analytics, com.microsoft.azure.storage.file, 
> com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.core,  has 2,  private references 
> [com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.blob,  has 2,  private references 
> [com.microsoft.azure.keyvault.core, com.microsoft.azure.storage.file]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.azure.identity,  has 5,  private references 
> [com.azure.core.client.traits, com.azure.core.exception, com.azure.core.http, 
> com.azure.core.http.policy, com.azure.core.util] {noformat}
> It would be nice to fix these, to remove unnecessary clutter from the build 
> log.
> /cc [~miroslav]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OAK-10626) Rework oak-segment-azure OSGi wirings after embedding azure libraries needed for service principals support

2024-03-04 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned OAK-10626:


Assignee: Julian Reschke  (was: Miroslav Smiljanic)

> Rework oak-segment-azure OSGi wirings after embedding azure libraries needed 
> for service principals support
> ---
>
> Key: OAK-10626
> URL: https://issues.apache.org/jira/browse/OAK-10626
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: osgi, segment-azure
>Reporter: Andrei Dulceanu
>Assignee: Julian Reschke
>Priority: Minor
>
> After fixing OAK-10604 I observed that there is a series of warnings which 
> appear at each build:
> {noformat}
> [INFO] --- maven-bundle-plugin:5.1.8:bundle (default-bundle) @ 
> oak-segment-azure ---
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Unused 
> Import-Package instructions: [com.nimbusds.jose*, com.nimbusds.oauth2.sdk*, 
> com.nimbusds.openid.connect.sdk*, com.nimbusds.secevent.sdk*]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage,  has 4,  private references 
> [com.microsoft.azure.storage.analytics, com.microsoft.azure.storage.file, 
> com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.core,  has 2,  private references 
> [com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.blob,  has 2,  private references 
> [com.microsoft.azure.keyvault.core, com.microsoft.azure.storage.file]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.azure.identity,  has 5,  private references 
> [com.azure.core.client.traits, com.azure.core.exception, com.azure.core.http, 
> com.azure.core.http.policy, com.azure.core.util] {noformat}
> It would be nice to fix these, to remove unnecessary clutter from the build 
> log.
> /cc [~miroslav]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10626) Rework oak-segment-azure OSGi wirings after embedding azure libraries needed for service principals support

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823213#comment-17823213
 ] 

Julian Reschke commented on OAK-10626:
--

[~miroslav] - can you please check whether this one can be closed?


> Rework oak-segment-azure OSGi wirings after embedding azure libraries needed 
> for service principals support
> ---
>
> Key: OAK-10626
> URL: https://issues.apache.org/jira/browse/OAK-10626
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: osgi, segment-azure
>Reporter: Andrei Dulceanu
>Assignee: Miroslav Smiljanic
>Priority: Minor
>
> After fixing OAK-10604 I observed that there is a series of warnings which 
> appear at each build:
> {noformat}
> [INFO] --- maven-bundle-plugin:5.1.8:bundle (default-bundle) @ 
> oak-segment-azure ---
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Unused 
> Import-Package instructions: [com.nimbusds.jose*, com.nimbusds.oauth2.sdk*, 
> com.nimbusds.openid.connect.sdk*, com.nimbusds.secevent.sdk*]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage,  has 4,  private references 
> [com.microsoft.azure.storage.analytics, com.microsoft.azure.storage.file, 
> com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.core,  has 2,  private references 
> [com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.blob,  has 2,  private references 
> [com.microsoft.azure.keyvault.core, com.microsoft.azure.storage.file]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.azure.identity,  has 5,  private references 
> [com.azure.core.client.traits, com.azure.core.exception, com.azure.core.http, 
> com.azure.core.http.policy, com.azure.core.util] {noformat}
> It would be nice to fix these, to remove unnecessary clutter from the build 
> log.
> /cc [~miroslav]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OAK-10626) Rework oak-segment-azure OSGi wirings after embedding azure libraries needed for service principals support

2024-03-04 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned OAK-10626:


Assignee: Julian Reschke  (was: Andrei Dulceanu)

> Rework oak-segment-azure OSGi wirings after embedding azure libraries needed 
> for service principals support
> ---
>
> Key: OAK-10626
> URL: https://issues.apache.org/jira/browse/OAK-10626
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: osgi, segment-azure
>Reporter: Andrei Dulceanu
>Assignee: Julian Reschke
>Priority: Minor
>
> After fixing OAK-10604 I observed that there is a series of warnings which 
> appear at each build:
> {noformat}
> [INFO] --- maven-bundle-plugin:5.1.8:bundle (default-bundle) @ 
> oak-segment-azure ---
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Unused 
> Import-Package instructions: [com.nimbusds.jose*, com.nimbusds.oauth2.sdk*, 
> com.nimbusds.openid.connect.sdk*, com.nimbusds.secevent.sdk*]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage,  has 4,  private references 
> [com.microsoft.azure.storage.analytics, com.microsoft.azure.storage.file, 
> com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.core,  has 2,  private references 
> [com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.blob,  has 2,  private references 
> [com.microsoft.azure.keyvault.core, com.microsoft.azure.storage.file]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.azure.identity,  has 5,  private references 
> [com.azure.core.client.traits, com.azure.core.exception, com.azure.core.http, 
> com.azure.core.http.policy, com.azure.core.util] {noformat}
> It would be nice to fix these, to remove unnecessary clutter from the build 
> log.
> /cc [~miroslav]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OAK-10626) Rework oak-segment-azure OSGi wirings after embedding azure libraries needed for service principals support

2024-03-04 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke reassigned OAK-10626:


Assignee: Miroslav Smiljanic  (was: Julian Reschke)

> Rework oak-segment-azure OSGi wirings after embedding azure libraries needed 
> for service principals support
> ---
>
> Key: OAK-10626
> URL: https://issues.apache.org/jira/browse/OAK-10626
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: osgi, segment-azure
>Reporter: Andrei Dulceanu
>Assignee: Miroslav Smiljanic
>Priority: Minor
>
> After fixing OAK-10604 I observed that there is a series of warnings which 
> appear at each build:
> {noformat}
> [INFO] --- maven-bundle-plugin:5.1.8:bundle (default-bundle) @ 
> oak-segment-azure ---
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Unused 
> Import-Package instructions: [com.nimbusds.jose*, com.nimbusds.oauth2.sdk*, 
> com.nimbusds.openid.connect.sdk*, com.nimbusds.secevent.sdk*]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage,  has 4,  private references 
> [com.microsoft.azure.storage.analytics, com.microsoft.azure.storage.file, 
> com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.core,  has 2,  private references 
> [com.microsoft.azure.storage.queue, com.microsoft.azure.storage.table]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.microsoft.azure.storage.blob,  has 2,  private references 
> [com.microsoft.azure.keyvault.core, com.microsoft.azure.storage.file]
> [WARNING] Manifest 
> org.apache.jackrabbit:oak-segment-azure:bundle:1.61-SNAPSHOT : Export 
> com.azure.identity,  has 5,  private references 
> [com.azure.core.client.traits, com.azure.core.exception, com.azure.core.http, 
> com.azure.core.http.policy, com.azure.core.util] {noformat}
> It would be nice to fix these, to remove unnecessary clutter from the build 
> log.
> /cc [~miroslav]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10688) Keep only traversed state, remove all other revisions

2024-03-04 Thread Stefan Egli (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823203#comment-17823203
 ] 

Stefan Egli edited comment on OAK-10688 at 3/4/24 2:02 PM:
---

Working on this in [this 
branch|https://github.com/apache/jackrabbit-oak/tree/OAK-10688] which is forked 
from the current [DetailedGC 
branch|https://github.com/apache/jackrabbit-oak/tree/DetailedGC/OAK-10199]


was (Author: egli):
Working on in [this 
branch|https://github.com/apache/jackrabbit-oak/tree/OAK-10688] which is forked 
of the current [DetailedGC 
branch|https://github.com/apache/jackrabbit-oak/tree/DetailedGC/OAK-10199]

> Keep only traversed state, remove all other revisions
> -
>
> Key: OAK-10688
> URL: https://issues.apache.org/jira/browse/OAK-10688
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> As a slightly different algorithm to OAK-10535 this ticket suggests to 
> calculate the traversedState of a node, then keeps only those revisions 
> needed for that traversedState and removes all others. The main difference is 
> an inversion of logic, where instead of analysing for each revision whether 
> it must be kept or not - this first derives the revision that must be "kept" 
> from the traversedState - then deletes all others.
> This mechanism applies to all (normal and bundled) properties as well as some 
> DocumentNodeStore internal ones, such as "_deleted".
> Below are a list of assumptions to back this:
> * DetailedGC runs only up to the older between the oldest checkpoint and 
> maxRevisionAge (24h by default). Thus a document analysed by DetailedGC is 
> guaranteed to have only 1 revision (per property) that must be kept - as it 
> is guaranteed to not have modifications (revisions) younger than any 
> checkpoint or maxRevisionAge (24h)
> * To find out which revision(s) must be kept, the node tree is traversed from 
> root (based on current head revision) to the target document.
> * Given the first bullet (that we're only looking at nodes that have only 1 
> revision (each, per property) to keep, this traversed node state thus 
> contains the values of those.
> * Hence, based on each of the property key of the traversed state, the 
> corresponding "commit revision" in the document-local map must be calculated. 
> That local map entry must be kept - all others can be deleted.
> * Note that this also cleans up overwritten branch commits of the same branch 
> (as only the last, relevant one is kept)
> As a result of the above, certain other entries can be deleted, namely:
> * any "_commitRoot" entry no longer referenced by the local document
> * any "_bc" entry no longer referenced by the local document
> Independent of the traversedState and the outcome of the cleanup what can 
> also be removed is:
> * any "_revisions" entry older than the current sweepRev
> However: "_revisions" entry that might not be referenced by the local 
> document and are younger than the sweepRev must still be kept, as they might 
> be referenced by child documents (through their "_commitRoot" pointing to the 
> current document). Without checking for children and double-checking the 
> actual use, there could as a result still be some garbage "_revisions" 
> entries left.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10688) Keep only traversed state, remove all other revisions

2024-03-04 Thread Stefan Egli (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823203#comment-17823203
 ] 

Stefan Egli commented on OAK-10688:
---

Working on in [this 
branch|https://github.com/apache/jackrabbit-oak/tree/OAK-10688] which is forked 
of the current [DetailedGC 
branch|https://github.com/apache/jackrabbit-oak/tree/DetailedGC/OAK-10199]

> Keep only traversed state, remove all other revisions
> -
>
> Key: OAK-10688
> URL: https://issues.apache.org/jira/browse/OAK-10688
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> As a slightly different algorithm to OAK-10535 this ticket suggests to 
> calculate the traversedState of a node, then keeps only those revisions 
> needed for that traversedState and removes all others. The main difference is 
> an inversion of logic, where instead of analysing for each revision whether 
> it must be kept or not - this first derives the revision that must be "kept" 
> from the traversedState - then deletes all others.
> This mechanism applies to all (normal and bundled) properties as well as some 
> DocumentNodeStore internal ones, such as "_deleted".
> Below are a list of assumptions to back this:
> * DetailedGC runs only up to the older between the oldest checkpoint and 
> maxRevisionAge (24h by default). Thus a document analysed by DetailedGC is 
> guaranteed to have only 1 revision (per property) that must be kept - as it 
> is guaranteed to not have modifications (revisions) younger than any 
> checkpoint or maxRevisionAge (24h)
> * To find out which revision(s) must be kept, the node tree is traversed from 
> root (based on current head revision) to the target document.
> * Given the first bullet (that we're only looking at nodes that have only 1 
> revision (each, per property) to keep, this traversed node state thus 
> contains the values of those.
> * Hence, based on each of the property key of the traversed state, the 
> corresponding "commit revision" in the document-local map must be calculated. 
> That local map entry must be kept - all others can be deleted.
> * Note that this also cleans up overwritten branch commits of the same branch 
> (as only the last, relevant one is kept)
> As a result of the above, certain other entries can be deleted, namely:
> * any "_commitRoot" entry no longer referenced by the local document
> * any "_bc" entry no longer referenced by the local document
> Independent of the traversedState and the outcome of the cleanup what can 
> also be removed is:
> * any "_revisions" entry older than the current sweepRev
> However: "_revisions" entry that might not be referenced by the local 
> document and are younger than the sweepRev must still be kept, as they might 
> be referenced by child documents (through their "_commitRoot" pointing to the 
> current document). Without checking for children and double-checking the 
> actual use, there could as a result still be some garbage "_revisions" 
> entries left.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OAK-10689) Extend oak-run revisions command with "detail" garbage collection

2024-03-04 Thread Jira
José Andrés Cordero Benítez created OAK-10689:
-

 Summary: Extend oak-run revisions command with "detail" garbage 
collection
 Key: OAK-10689
 URL: https://issues.apache.org/jira/browse/OAK-10689
 Project: Jackrabbit Oak
  Issue Type: Task
  Components: oak-run
Reporter: José Andrés Cordero Benítez
Assignee: José Andrés Cordero Benítez


Extend the oak-run revisions command to perform a detailed cleanup on a given 
document.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Manfred Baedke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823195#comment-17823195
 ] 

Manfred Baedke edited comment on OAK-10551 at 3/4/24 1:48 PM:
--

Labels exist officially: 
https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.metatype.html
We'd need an OCD. Should we care?


was (Author: baedke):
Labels exist officially: 
https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.metatype.html

> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Manfred Baedke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823195#comment-17823195
 ] 

Manfred Baedke commented on OAK-10551:
--

Labels exist officially: 
https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.metatype.html

> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Julian Reschke (Jira)


[ https://issues.apache.org/jira/browse/OAK-10551 ]


Julian Reschke deleted comment on OAK-10551:
--

was (Author: reschke):
Did some more digging.

In Felix SCR, "label" has only an effect when component meta type generation is 
enabled.

Trying
{noformat}
--- 
a/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/osgi/RepositoryManager.java
+++ 
b/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/osgi/RepositoryManager.java
@@ -58,7 +58,7 @@ import org.osgi.framework.ServiceRegistration;
  * create repository. This is done to prevent repository creation in scenarios 
where repository needs
  * to be configured in a custom way
  */
-@Component(policy = ConfigurationPolicy.REQUIRE)
+@Component(metatype = true, policy = ConfigurationPolicy.REQUIRE)
 @References({
 @Reference(referenceInterface = StatisticsProvider.class,
 strategy = ReferenceStrategy.LOOKUP
@@ -104,20 +104,20 @@ public class RepositoryManager {

 @Property(
 intValue = DEFAULT_OBSERVATION_QUEUE_LENGTH,
-name = "Observation queue length",
+label = "Observation queue length",
 description = "Maximum number of pending revisions in a observation 
listener queue")
 private static final String OBSERVATION_QUEUE_LENGTH = 
"oak.observation.queue-length";

 @Property(
 boolValue = DEFAULT_COMMIT_RATE_LIMIT,
-name = "Commit rate limiter",
+label = "Commit rate limiter",
 description = "Limit the commit rate once the number of pending 
revisions in the observation " +
 "queue exceed 90% of its capacity.")
 private static final String COMMIT_RATE_LIMIT = 
"oak.observation.limit-commit-rate";

 @Property(
 boolValue = DEFAULT_FAST_QUERY_RESULT_SIZE,
-name = "Fast query result size",
+label = "Fast query result size",
 description = "Whether the query result size should return an 
estimation (or -1 if disabled) for large queries")
 private static final String FAST_QUERY_RESULT_SIZE = 
"oak.query.fastResultSize";
{noformat}

I get the labels into 
target/classes/OSGI-INF/metatype/org.apache.jackrabbit.oak.jcr.osgi.RepositoryManager.properties


> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823190#comment-17823190
 ] 

Julian Reschke commented on OAK-10551:
--

Did some more digging.

In Felix SCR, "label" has only an effect when component meta type generation is 
enabled.

Trying
{noformat}
--- 
a/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/osgi/RepositoryManager.java
+++ 
b/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/osgi/RepositoryManager.java
@@ -58,7 +58,7 @@ import org.osgi.framework.ServiceRegistration;
  * create repository. This is done to prevent repository creation in scenarios 
where repository needs
  * to be configured in a custom way
  */
-@Component(policy = ConfigurationPolicy.REQUIRE)
+@Component(metatype = true, policy = ConfigurationPolicy.REQUIRE)
 @References({
 @Reference(referenceInterface = StatisticsProvider.class,
 strategy = ReferenceStrategy.LOOKUP
@@ -104,20 +104,20 @@ public class RepositoryManager {

 @Property(
 intValue = DEFAULT_OBSERVATION_QUEUE_LENGTH,
-name = "Observation queue length",
+label = "Observation queue length",
 description = "Maximum number of pending revisions in a observation 
listener queue")
 private static final String OBSERVATION_QUEUE_LENGTH = 
"oak.observation.queue-length";

 @Property(
 boolValue = DEFAULT_COMMIT_RATE_LIMIT,
-name = "Commit rate limiter",
+label = "Commit rate limiter",
 description = "Limit the commit rate once the number of pending 
revisions in the observation " +
 "queue exceed 90% of its capacity.")
 private static final String COMMIT_RATE_LIMIT = 
"oak.observation.limit-commit-rate";

 @Property(
 boolValue = DEFAULT_FAST_QUERY_RESULT_SIZE,
-name = "Fast query result size",
+label = "Fast query result size",
 description = "Whether the query result size should return an 
estimation (or -1 if disabled) for large queries")
 private static final String FAST_QUERY_RESULT_SIZE = 
"oak.query.fastResultSize";
{noformat}

I get the labels into 
target/classes/OSGI-INF/metatype/org.apache.jackrabbit.oak.jcr.osgi.RepositoryManager.properties


> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Manfred Baedke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823181#comment-17823181
 ] 

Manfred Baedke edited comment on OAK-10551 at 3/4/24 1:25 PM:
--

I tried it out. These appear nowhere except in the component description at 
runtime (http://localhost:4502/system/console/components). ConfigAdmin 
apparently doesn't use them.


was (Author: baedke):
I tried it out. These appear nowhere except in the component description at 
runtime (http://localhost:4502/system/console/components).

> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10535) Clean up old revisions in a document

2024-03-04 Thread Stefan Egli (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823183#comment-17823183
 ] 

Stefan Egli commented on OAK-10535:
---

Note that OAK-10688 contains an alternative approach

> Clean up old revisions in a document
> 
>
> Key: OAK-10535
> URL: https://issues.apache.org/jira/browse/OAK-10535
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Minor
>
> Introduce a way to safely detect and delete old revisions in a document. This 
> could be useful to cleanup documents that sometimes grows above the supported 
> size in MongoDB (16MB).
> It could be also integrate into the detailed GC.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Manfred Baedke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823181#comment-17823181
 ] 

Manfred Baedke edited comment on OAK-10551 at 3/4/24 1:24 PM:
--

I tried it out. These appear nowhere except in the component description at 
runtime (http://localhost:4502/system/console/components).


was (Author: baedke):
I tried it out. These appear nowhere exception in the component description at 
runtime (http://localhost:4502/system/console/components).

> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OAK-10688) Keep only traversed state, remove all other revisions

2024-03-04 Thread Stefan Egli (Jira)
Stefan Egli created OAK-10688:
-

 Summary: Keep only traversed state, remove all other revisions
 Key: OAK-10688
 URL: https://issues.apache.org/jira/browse/OAK-10688
 Project: Jackrabbit Oak
  Issue Type: Task
  Components: documentmk
Reporter: Stefan Egli
Assignee: Stefan Egli


As a slightly different algorithm to OAK-10535 this ticket suggests to 
calculate the traversedState of a node, then keeps only those revisions needed 
for that traversedState and removes all others. The main difference is an 
inversion of logic, where instead of analysing for each revision whether it 
must be kept or not - this first derives the revision that must be "kept" from 
the traversedState - then deletes all others.

This mechanism applies to all (normal and bundled) properties as well as some 
DocumentNodeStore internal ones, such as "_deleted".

Below are a list of assumptions to back this:
* DetailedGC runs only up to the older between the oldest checkpoint and 
maxRevisionAge (24h by default). Thus a document analysed by DetailedGC is 
guaranteed to have only 1 revision (per property) that must be kept - as it is 
guaranteed to not have modifications (revisions) younger than any checkpoint or 
maxRevisionAge (24h)
* To find out which revision(s) must be kept, the node tree is traversed from 
root (based on current head revision) to the target document.
* Given the first bullet (that we're only looking at nodes that have only 1 
revision (each, per property) to keep, this traversed node state thus contains 
the values of those.
* Hence, based on each of the property key of the traversed state, the 
corresponding "commit revision" in the document-local map must be calculated. 
That local map entry must be kept - all others can be deleted.
* Note that this also cleans up overwritten branch commits of the same branch 
(as only the last, relevant one is kept)

As a result of the above, certain other entries can be deleted, namely:
* any "_commitRoot" entry no longer referenced by the local document
* any "_bc" entry no longer referenced by the local document

Independent of the traversedState and the outcome of the cleanup what can also 
be removed is:
* any "_revisions" entry older than the current sweepRev

However: "_revisions" entry that might not be referenced by the local document 
and are younger than the sweepRev must still be kept, as they might be 
referenced by child documents (through their "_commitRoot" pointing to the 
current document). Without checking for children and double-checking the actual 
use, there could as a result still be some garbage "_revisions" entries left.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Manfred Baedke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823181#comment-17823181
 ] 

Manfred Baedke commented on OAK-10551:
--

I tried it out. These appear nowhere exception in the component description at 
runtime (http://localhost:4502/system/console/components).

> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823178#comment-17823178
 ] 

Julian Reschke commented on OAK-10551:
--

Thanks.

IIUC, the field "label" does not exist in the official OSGi annotations anyway? 
(As opposed to "description"?)

> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Carsten Ziegeler (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823175#comment-17823175
 ] 

Carsten Ziegeler commented on OAK-10551:


It depends, the code is using the correct name, see 
https://github.com/apache/jackrabbit-oak/pull/1213/files#diff-ad75ff5d95b26111bda45ae72cb9d7390a033841418634cb89b2961936b00f70L138
So if an OSGi configuration is using those, all is good and works as expected
I guess setting the values via the OSGi web console does not work and the 
properties will be ignored. Same happens if an OSGi configuration is used 
"Observation queue length" etc.

> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823171#comment-17823171
 ] 

Julian Reschke commented on OAK-10551:
--

These are clearly incorrect. Looking around, maybe the intent was to use those 
as *labels*?

What I'm not sure yet is what this means in practice. If somebody would try to 
configure these through OSGi, wouldn't he/she see incorrect property names, and 
thus be unable to set the config.

If this hasn't been noticed before, does this mean nobody has tried?

> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10687) Restore and cleanup SCM information

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823162#comment-17823162
 ] 

Julian Reschke commented on OAK-10687:
--

trunk: 
[6f784d0627|https://github.com/apache/jackrabbit-oak-/commit/6f784d06276d760413d7bcdf23959171a6e2f159]

> Restore and cleanup SCM information
> ---
>
> Key: OAK-10687
> URL: https://issues.apache.org/jira/browse/OAK-10687
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_22
> Fix For: 1.62.0
>
>
> Align with Jackrabbit (see JCR-5011).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (OAK-10687) Restore and cleanup SCM information

2024-03-04 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved OAK-10687.
--
Fix Version/s: 1.62.0
   Resolution: Fixed

> Restore and cleanup SCM information
> ---
>
> Key: OAK-10687
> URL: https://issues.apache.org/jira/browse/OAK-10687
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
> Fix For: 1.62.0
>
>
> Align with Jackrabbit (see JCR-5011).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10687) Restore and cleanup SCM information

2024-03-04 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-10687:
-
Labels: candidate_oak_1_22  (was: )

> Restore and cleanup SCM information
> ---
>
> Key: OAK-10687
> URL: https://issues.apache.org/jira/browse/OAK-10687
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_22
> Fix For: 1.62.0
>
>
> Align with Jackrabbit (see JCR-5011).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10551) o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used at all

2024-03-04 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-10551:
-
Summary: o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that 
are not used at all  (was: o.a.j.o.jcr.osgi.RepositoryManager declares OSGi 
properties that are not used at all.)

> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used 
> at all
> 
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: jcr
>Reporter: Manfred Baedke
>Assignee: Manfred Baedke
>Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate 
> limiter" and "Fast query result size". The names the code actually uses are 
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and 
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just 
> confusing.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OAK-10628) Azure Service Principal Support in oak-run

2024-03-04 Thread Miroslav Smiljanic (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miroslav Smiljanic reassigned OAK-10628:


Assignee: Miroslav Smiljanic  (was: Andrei Dulceanu)

> Azure Service Principal Support in oak-run
> --
>
> Key: OAK-10628
> URL: https://issues.apache.org/jira/browse/OAK-10628
> Project: Jackrabbit Oak
>  Issue Type: Story
>  Components: oak-run, segment-azure
>Reporter: Andrei Dulceanu
>Assignee: Miroslav Smiljanic
>Priority: Major
>
> Azure Service Principal Support in oak-run. Goal is to allow Azure 
> authentication via:
>  * clientId - Id of the Service Principal object / App registered with the 
> Active Directory.
>  * clientSecret - Application password.
>  * tenantId - Azure Active Directory Id.
> Affected commands: datastore, explore.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (OAK-10670) Azure service principal support in oak-upgrade

2024-03-04 Thread Miroslav Smiljanic (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miroslav Smiljanic resolved OAK-10670.
--
Fix Version/s: 1.62.0
   Resolution: Fixed

> Azure service principal support in oak-upgrade
> --
>
> Key: OAK-10670
> URL: https://issues.apache.org/jira/browse/OAK-10670
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: upgrade
>Affects Versions: 1.60.0
>Reporter: Tushar Rana
>Assignee: Miroslav Smiljanic
>Priority: Major
> Fix For: 1.62.0
>
>
> Azure Service Principal Support in oak-segment-azure. Goal is to allow Azure 
> authentication via:
>  * clientId - Id of the Service Principal object / App registered with the 
> Active Directory.
>  * clientSecret - Application password.
>  * tenantId - Azure Active Directory Id.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10670) Azure service principal support in oak-upgrade

2024-03-04 Thread Miroslav Smiljanic (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miroslav Smiljanic updated OAK-10670:
-
Affects Version/s: 1.60.0

> Azure service principal support in oak-upgrade
> --
>
> Key: OAK-10670
> URL: https://issues.apache.org/jira/browse/OAK-10670
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: upgrade
>Affects Versions: 1.60.0
>Reporter: Tushar Rana
>Assignee: Miroslav Smiljanic
>Priority: Major
>
> Azure Service Principal Support in oak-segment-azure. Goal is to allow Azure 
> authentication via:
>  * clientId - Id of the Service Principal object / App registered with the 
> Active Directory.
>  * clientSecret - Application password.
>  * tenantId - Azure Active Directory Id.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10670) Azure service principal support in oak-upgrade

2024-03-04 Thread Miroslav Smiljanic (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823117#comment-17823117
 ] 

Miroslav Smiljanic commented on OAK-10670:
--

[~t-rana] Thank you for contributing to the project with the code in the linked 
PR. 

> Azure service principal support in oak-upgrade
> --
>
> Key: OAK-10670
> URL: https://issues.apache.org/jira/browse/OAK-10670
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Reporter: Tushar Rana
>Assignee: Miroslav Smiljanic
>Priority: Major
>
> Azure Service Principal Support in oak-segment-azure. Goal is to allow Azure 
> authentication via:
>  * clientId - Id of the Service Principal object / App registered with the 
> Active Directory.
>  * clientSecret - Application password.
>  * tenantId - Azure Active Directory Id.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OAK-10670) Azure service principal support in oak-upgrade

2024-03-04 Thread Miroslav Smiljanic (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miroslav Smiljanic updated OAK-10670:
-
Component/s: upgrade

> Azure service principal support in oak-upgrade
> --
>
> Key: OAK-10670
> URL: https://issues.apache.org/jira/browse/OAK-10670
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>  Components: upgrade
>Reporter: Tushar Rana
>Assignee: Miroslav Smiljanic
>Priority: Major
>
> Azure Service Principal Support in oak-segment-azure. Goal is to allow Azure 
> authentication via:
>  * clientId - Id of the Service Principal object / App registered with the 
> Active Directory.
>  * clientSecret - Application password.
>  * tenantId - Azure Active Directory Id.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (OAK-10670) Azure service principal support in oak-upgrade

2024-03-04 Thread Miroslav Smiljanic (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Miroslav Smiljanic reassigned OAK-10670:


Assignee: Miroslav Smiljanic

> Azure service principal support in oak-upgrade
> --
>
> Key: OAK-10670
> URL: https://issues.apache.org/jira/browse/OAK-10670
> Project: Jackrabbit Oak
>  Issue Type: Improvement
>Reporter: Tushar Rana
>Assignee: Miroslav Smiljanic
>Priority: Major
>
> Azure Service Principal Support in oak-segment-azure. Goal is to allow Azure 
> authentication via:
>  * clientId - Id of the Service Principal object / App registered with the 
> Active Directory.
>  * clientSecret - Application password.
>  * tenantId - Azure Active Directory Id.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10686) parent: add project.build.outputTimestamp property for Reproducable Builds

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823104#comment-17823104
 ] 

Julian Reschke commented on OAK-10686:
--

trunk: 
[00255b1957|https://github.com/apache/jackrabbit-oak-/commit/00255b1957b9a9e978e9ecf160ef47bd4d7996cd]

> parent: add project.build.outputTimestamp property for Reproducable Builds
> --
>
> Key: OAK-10686
> URL: https://issues.apache.org/jira/browse/OAK-10686
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_22
> Fix For: 1.62.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Resolved] (OAK-10686) parent: add project.build.outputTimestamp property for Reproducable Builds

2024-03-04 Thread Julian Reschke (Jira)


 [ 
https://issues.apache.org/jira/browse/OAK-10686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke resolved OAK-10686.
--
Fix Version/s: 1.62.0
   Resolution: Fixed

> parent: add project.build.outputTimestamp property for Reproducable Builds
> --
>
> Key: OAK-10686
> URL: https://issues.apache.org/jira/browse/OAK-10686
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: parent
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Minor
>  Labels: candidate_oak_1_22
> Fix For: 1.62.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (OAK-10687) Restore and cleanup SCM information

2024-03-04 Thread Julian Reschke (Jira)
Julian Reschke created OAK-10687:


 Summary: Restore and cleanup SCM information
 Key: OAK-10687
 URL: https://issues.apache.org/jira/browse/OAK-10687
 Project: Jackrabbit Oak
  Issue Type: Task
  Components: parent
Reporter: Julian Reschke
Assignee: Julian Reschke


Align with Jackrabbit (see JCR-5011).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (OAK-10645) MongoDS docker container: set default Mongo version to 4.4

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823096#comment-17823096
 ] 

Julian Reschke edited comment on OAK-10645 at 3/4/24 9:13 AM:
--

[~stefanegli] - should we also update Oak 1.22 to use Mongo 4.0? (as per 
https://jackrabbit.apache.org/oak/docs/nodestore/document/mongo-document-store.html)


was (Author: reschke):
[~stefanegli] - should we also update Oak 1.22 to use Mongo 4.0?

> MongoDS docker container: set default Mongo version to 4.4
> --
>
> Key: OAK-10645
> URL: https://issues.apache.org/jira/browse/OAK-10645
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.62.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10645) MongoDS docker container: set default Mongo version to 4.4

2024-03-04 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823096#comment-17823096
 ] 

Julian Reschke commented on OAK-10645:
--

[~stefanegli] - should we also update Oak 1.22 to use Mongo 4.0?

> MongoDS docker container: set default Mongo version to 4.4
> --
>
> Key: OAK-10645
> URL: https://issues.apache.org/jira/browse/OAK-10645
> Project: Jackrabbit Oak
>  Issue Type: Task
>  Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
> Fix For: 1.62.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)