[jira] [Commented] (OAK-11256) Build Jackrabbit/jackrabbit-oak-trunk #1846 failed
[ https://issues.apache.org/jira/browse/OAK-11256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896762#comment-17896762 ] Hudson commented on OAK-11256: -- Previously failing build now is OK. Passed run: [Jackrabbit/jackrabbit-oak-trunk #1850|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1850/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1850/console] > Build Jackrabbit/jackrabbit-oak-trunk #1846 failed > -- > > Key: OAK-11256 > URL: https://issues.apache.org/jira/browse/OAK-11256 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit/jackrabbit-oak-trunk #1846 has failed. > First failed run: [Jackrabbit/jackrabbit-oak-trunk > #1846|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/] > [console > log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/console] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11260) Speed up Lucene cost estimation
[
https://issues.apache.org/jira/browse/OAK-11260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Mueller resolved OAK-11260.
--
Fix Version/s: 1.74.0
Resolution: Fixed
> Speed up Lucene cost estimation
> ---
>
> Key: OAK-11260
> URL: https://issues.apache.org/jira/browse/OAK-11260
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
> Fix For: 1.74.0
>
>
> Cost estimation for queries with many "union" parts is slow. With profiling,
> I found the bottleneck is:
> {noformat}
> at
> org.apache.jackrabbit.oak.plugins.nodetype.ReadOnlyNodeTypeManager.isNodeType(ReadOnlyNodeTypeManager.java:322)
> at
> org.apache.jackrabbit.oak.plugins.index.search.IndexDefinition.collectIndexRules(IndexDefinition.java:936)
> at
> org.apache.jackrabbit.oak.plugins.index.search.IndexDefinition.(IndexDefinition.java:446)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexDefinition.(LuceneIndexDefinition.java:72)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexDefinition.(LuceneIndexDefinition.java:68)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.getIndexDefinition(IndexTracker.java:303)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexLookupUtil.getOldFullTextIndexPath(LuceneIndexLookupUtil.java:48)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex.getPlans(LuceneIndex.java:206)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (OAK-11259) Bump testcontainers to v1.20.3 / toxiproxy 2.11.0
[ https://issues.apache.org/jira/browse/OAK-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabrizio Fortino resolved OAK-11259. Fix Version/s: 1.74.0 Resolution: Fixed > Bump testcontainers to v1.20.3 / toxiproxy 2.11.0 > - > > Key: OAK-11259 > URL: https://issues.apache.org/jira/browse/OAK-11259 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: parent >Reporter: Fabrizio Fortino >Assignee: Fabrizio Fortino >Priority: Minor > Fix For: 1.74.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11262) Build Jackrabbit/jackrabbit-oak-trunk-java17 #73 failed
Hudson created OAK-11262: Summary: Build Jackrabbit/jackrabbit-oak-trunk-java17 #73 failed Key: OAK-11262 URL: https://issues.apache.org/jira/browse/OAK-11262 Project: Jackrabbit Oak Issue Type: Bug Components: continuous integration Reporter: Hudson No description is provided The build Jackrabbit/jackrabbit-oak-trunk-java17 #73 has failed. First failed run: [Jackrabbit/jackrabbit-oak-trunk-java17 #73|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-java17/73/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-java17/73/console] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11261) Flaky test preventing Oak release: BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren
[ https://issues.apache.org/jira/browse/OAK-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Andrés Cordero Benítez updated OAK-11261: -- Summary: Flaky test preventing Oak release: BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren (was: Flaky test preventing Oak release) > Flaky test preventing Oak release: > BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren > --- > > Key: OAK-11261 > URL: https://issues.apache.org/jira/browse/OAK-11261 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: José Andrés Cordero Benítez >Assignee: José Andrés Cordero Benítez >Priority: Major > Labels: DetailedGC > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11260) Speed up Lucene cost estimation
[
https://issues.apache.org/jira/browse/OAK-11260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896664#comment-17896664
]
Thomas Mueller commented on OAK-11260:
--
https://github.com/apache/jackrabbit-oak/pull/1858
> Speed up Lucene cost estimation
> ---
>
> Key: OAK-11260
> URL: https://issues.apache.org/jira/browse/OAK-11260
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: lucene
>Reporter: Thomas Mueller
>Assignee: Thomas Mueller
>Priority: Major
>
> Cost estimation for queries with many "union" parts is slow. With profiling,
> I found the bottleneck is:
> {noformat}
> at
> org.apache.jackrabbit.oak.plugins.nodetype.ReadOnlyNodeTypeManager.isNodeType(ReadOnlyNodeTypeManager.java:322)
> at
> org.apache.jackrabbit.oak.plugins.index.search.IndexDefinition.collectIndexRules(IndexDefinition.java:936)
> at
> org.apache.jackrabbit.oak.plugins.index.search.IndexDefinition.(IndexDefinition.java:446)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexDefinition.(LuceneIndexDefinition.java:72)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexDefinition.(LuceneIndexDefinition.java:68)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.getIndexDefinition(IndexTracker.java:303)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexLookupUtil.getOldFullTextIndexPath(LuceneIndexLookupUtil.java:48)
> at
> org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex.getPlans(LuceneIndex.java:206)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (OAK-11261) Flaky test preventing Oak release: BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren
[
https://issues.apache.org/jira/browse/OAK-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Andrés Cordero Benítez resolved OAK-11261.
---
Resolution: Fixed
> Flaky test preventing Oak release:
> BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren
> ---
>
> Key: OAK-11261
> URL: https://issues.apache.org/jira/browse/OAK-11261
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Major
> Labels: DetailedGC
> Fix For: 1.74.0
>
>
>
> {code:java}
> [2024-11-08T12:29:29.450Z] [ERROR] Failures:
> [2024-11-08T12:29:29.450Z] [ERROR]
> BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren:225
> ORPHANS_EMPTYPROPS_KEEP_ONE_USER_PROPS/props - staticStore : Nodes:
> [2024-11-08T12:29:29.450Z] Path: 0:/
> [2024-11-08T12:29:29.450Z] _children=true
> [2024-11-08T12:29:29.450Z] _bc={r1930bba820b-0-1=true, r1930bba81e3-0-1=true}
> [2024-11-08T12:29:29.450Z] _deleted={r1930bba81b4-0-1=false}
> [2024-11-08T12:29:29.450Z] _collisions={}
> [2024-11-08T12:29:29.450Z] _commitRoot={}
> [2024-11-08T12:29:29.450Z] _sweepRev={r0-0-1=r1930bba8213-0-1}
> [2024-11-08T12:29:29.450Z] _revisions={r1930bba820b-0-1=c-r1930bba8213-0-1,
> r1930bba81e3-0-1=c-r1930bba81ef-0-1, r1930bba81b4-0-1=c}
> [2024-11-08T12:29:29.450Z] _id=0:/
> [2024-11-08T12:29:29.450Z] _modified=1731068590
> [2024-11-08T12:29:29.450Z] _lastRev={r0-0-1=r1930bba8213-0-1}
> [2024-11-08T12:29:29.450Z]
> [2024-11-08T12:29:29.450Z] expected:<1> but was:<0>{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-11261) Flaky test preventing Oak release: BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren
[
https://issues.apache.org/jira/browse/OAK-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Andrés Cordero Benítez updated OAK-11261:
--
Fix Version/s: 1.74.0
> Flaky test preventing Oak release:
> BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren
> ---
>
> Key: OAK-11261
> URL: https://issues.apache.org/jira/browse/OAK-11261
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Major
> Labels: DetailedGC
> Fix For: 1.74.0
>
>
>
> {code:java}
> [2024-11-08T12:29:29.450Z] [ERROR] Failures:
> [2024-11-08T12:29:29.450Z] [ERROR]
> BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren:225
> ORPHANS_EMPTYPROPS_KEEP_ONE_USER_PROPS/props - staticStore : Nodes:
> [2024-11-08T12:29:29.450Z] Path: 0:/
> [2024-11-08T12:29:29.450Z] _children=true
> [2024-11-08T12:29:29.450Z] _bc={r1930bba820b-0-1=true, r1930bba81e3-0-1=true}
> [2024-11-08T12:29:29.450Z] _deleted={r1930bba81b4-0-1=false}
> [2024-11-08T12:29:29.450Z] _collisions={}
> [2024-11-08T12:29:29.450Z] _commitRoot={}
> [2024-11-08T12:29:29.450Z] _sweepRev={r0-0-1=r1930bba8213-0-1}
> [2024-11-08T12:29:29.450Z] _revisions={r1930bba820b-0-1=c-r1930bba8213-0-1,
> r1930bba81e3-0-1=c-r1930bba81ef-0-1, r1930bba81b4-0-1=c}
> [2024-11-08T12:29:29.450Z] _id=0:/
> [2024-11-08T12:29:29.450Z] _modified=1731068590
> [2024-11-08T12:29:29.450Z] _lastRev={r0-0-1=r1930bba8213-0-1}
> [2024-11-08T12:29:29.450Z]
> [2024-11-08T12:29:29.450Z] expected:<1> but was:<0>{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-11261) Flaky test preventing Oak release: BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren
[
https://issues.apache.org/jira/browse/OAK-11261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Andrés Cordero Benítez updated OAK-11261:
--
Description:
{code:java}
[2024-11-08T12:29:29.450Z] [ERROR] Failures:
[2024-11-08T12:29:29.450Z] [ERROR]
BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren:225
ORPHANS_EMPTYPROPS_KEEP_ONE_USER_PROPS/props - staticStore : Nodes:
[2024-11-08T12:29:29.450Z] Path: 0:/
[2024-11-08T12:29:29.450Z] _children=true
[2024-11-08T12:29:29.450Z] _bc={r1930bba820b-0-1=true, r1930bba81e3-0-1=true}
[2024-11-08T12:29:29.450Z] _deleted={r1930bba81b4-0-1=false}
[2024-11-08T12:29:29.450Z] _collisions={}
[2024-11-08T12:29:29.450Z] _commitRoot={}
[2024-11-08T12:29:29.450Z] _sweepRev={r0-0-1=r1930bba8213-0-1}
[2024-11-08T12:29:29.450Z] _revisions={r1930bba820b-0-1=c-r1930bba8213-0-1,
r1930bba81e3-0-1=c-r1930bba81ef-0-1, r1930bba81b4-0-1=c}
[2024-11-08T12:29:29.450Z] _id=0:/
[2024-11-08T12:29:29.450Z] _modified=1731068590
[2024-11-08T12:29:29.450Z] _lastRev={r0-0-1=r1930bba8213-0-1}
[2024-11-08T12:29:29.450Z]
[2024-11-08T12:29:29.450Z] expected:<1> but was:<0>{code}
> Flaky test preventing Oak release:
> BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren
> ---
>
> Key: OAK-11261
> URL: https://issues.apache.org/jira/browse/OAK-11261
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Major
> Labels: DetailedGC
>
>
> {code:java}
> [2024-11-08T12:29:29.450Z] [ERROR] Failures:
> [2024-11-08T12:29:29.450Z] [ERROR]
> BranchCommitGCTest.unmergedAddThenMergedAddAndRemoveChildren:225
> ORPHANS_EMPTYPROPS_KEEP_ONE_USER_PROPS/props - staticStore : Nodes:
> [2024-11-08T12:29:29.450Z] Path: 0:/
> [2024-11-08T12:29:29.450Z] _children=true
> [2024-11-08T12:29:29.450Z] _bc={r1930bba820b-0-1=true, r1930bba81e3-0-1=true}
> [2024-11-08T12:29:29.450Z] _deleted={r1930bba81b4-0-1=false}
> [2024-11-08T12:29:29.450Z] _collisions={}
> [2024-11-08T12:29:29.450Z] _commitRoot={}
> [2024-11-08T12:29:29.450Z] _sweepRev={r0-0-1=r1930bba8213-0-1}
> [2024-11-08T12:29:29.450Z] _revisions={r1930bba820b-0-1=c-r1930bba8213-0-1,
> r1930bba81e3-0-1=c-r1930bba81ef-0-1, r1930bba81b4-0-1=c}
> [2024-11-08T12:29:29.450Z] _id=0:/
> [2024-11-08T12:29:29.450Z] _modified=1731068590
> [2024-11-08T12:29:29.450Z] _lastRev={r0-0-1=r1930bba8213-0-1}
> [2024-11-08T12:29:29.450Z]
> [2024-11-08T12:29:29.450Z] expected:<1> but was:<0>{code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OAK-11261) Flaky test preventing Oak release
José Andrés Cordero Benítez created OAK-11261: - Summary: Flaky test preventing Oak release Key: OAK-11261 URL: https://issues.apache.org/jira/browse/OAK-11261 Project: Jackrabbit Oak Issue Type: Improvement Components: documentmk Reporter: José Andrés Cordero Benítez Assignee: José Andrés Cordero Benítez -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11260) Speed up Lucene cost estimation
Thomas Mueller created OAK-11260:
Summary: Speed up Lucene cost estimation
Key: OAK-11260
URL: https://issues.apache.org/jira/browse/OAK-11260
Project: Jackrabbit Oak
Issue Type: Improvement
Components: lucene
Reporter: Thomas Mueller
Assignee: Thomas Mueller
Cost estimation for queries with many "union" parts is slow. With profiling, I
found the bottleneck is:
{noformat}
at
org.apache.jackrabbit.oak.plugins.nodetype.ReadOnlyNodeTypeManager.isNodeType(ReadOnlyNodeTypeManager.java:322)
at
org.apache.jackrabbit.oak.plugins.index.search.IndexDefinition.collectIndexRules(IndexDefinition.java:936)
at
org.apache.jackrabbit.oak.plugins.index.search.IndexDefinition.(IndexDefinition.java:446)
at
org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexDefinition.(LuceneIndexDefinition.java:72)
at
org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexDefinition.(LuceneIndexDefinition.java:68)
at
org.apache.jackrabbit.oak.plugins.index.lucene.IndexTracker.getIndexDefinition(IndexTracker.java:303)
at
org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndexLookupUtil.getOldFullTextIndexPath(LuceneIndexLookupUtil.java:48)
at
org.apache.jackrabbit.oak.plugins.index.lucene.LuceneIndex.getPlans(LuceneIndex.java:206)
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-9447) Upgrade Mongo java driver to 5.2
[ https://issues.apache.org/jira/browse/OAK-9447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896653#comment-17896653 ] Raffaele Gambelli commented on OAK-9447: Hi all, I'm trying to debug ReplicaSetDefaultWriteConcernIT test, I've checked that the replica set is started correctly, that test sometimes passes sometimes fails, it's really strange... I try to investigate further... > Upgrade Mongo java driver to 5.2 > > > Key: OAK-9447 > URL: https://issues.apache.org/jira/browse/OAK-9447 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: José Andrés Cordero Benítez >Priority: Major > Attachments: > compatibility-version-matrix-between-oak-and-mongodb.png, > image-2024-10-04-16-33-13-089.png > > > Upgrade Mongo java driver to 4.2+ -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11259) Bump testcontainers to v1.20.3 / toxiproxy 2.11.0
Fabrizio Fortino created OAK-11259: -- Summary: Bump testcontainers to v1.20.3 / toxiproxy 2.11.0 Key: OAK-11259 URL: https://issues.apache.org/jira/browse/OAK-11259 Project: Jackrabbit Oak Issue Type: Improvement Components: parent Reporter: Fabrizio Fortino Assignee: Fabrizio Fortino Fix For: 1.70.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11259) Bump testcontainers to v1.20.3 / toxiproxy 2.11.0
[ https://issues.apache.org/jira/browse/OAK-11259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabrizio Fortino updated OAK-11259: --- Fix Version/s: (was: 1.70.0) > Bump testcontainers to v1.20.3 / toxiproxy 2.11.0 > - > > Key: OAK-11259 > URL: https://issues.apache.org/jira/browse/OAK-11259 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: parent >Reporter: Fabrizio Fortino >Assignee: Fabrizio Fortino >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11256) Build Jackrabbit/jackrabbit-oak-trunk #1846 failed
[ https://issues.apache.org/jira/browse/OAK-11256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896327#comment-17896327 ] Hudson commented on OAK-11256: -- Previously failing build now is OK. Passed run: [Jackrabbit/jackrabbit-oak-trunk #1849|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1849/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1849/console] > Build Jackrabbit/jackrabbit-oak-trunk #1846 failed > -- > > Key: OAK-11256 > URL: https://issues.apache.org/jira/browse/OAK-11256 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit/jackrabbit-oak-trunk #1846 has failed. > First failed run: [Jackrabbit/jackrabbit-oak-trunk > #1846|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/] > [console > log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/console] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11256) Build Jackrabbit/jackrabbit-oak-trunk #1846 failed
[ https://issues.apache.org/jira/browse/OAK-11256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896265#comment-17896265 ] Hudson commented on OAK-11256: -- Previously failing build now is OK. Passed run: [Jackrabbit/jackrabbit-oak-trunk #1848|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1848/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1848/console] > Build Jackrabbit/jackrabbit-oak-trunk #1846 failed > -- > > Key: OAK-11256 > URL: https://issues.apache.org/jira/browse/OAK-11256 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit/jackrabbit-oak-trunk #1846 has failed. > First failed run: [Jackrabbit/jackrabbit-oak-trunk > #1846|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/] > [console > log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/console] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11258) validation branch for re-reverting PR#1852, #1853, #1854
[ https://issues.apache.org/jira/browse/OAK-11258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896251#comment-17896251 ] Stefan Egli commented on OAK-11258: --- two commits in the https://github.com/apache/jackrabbit-oak/tree/OAK-11258 branch : * [1855|https://github.com/apache/jackrabbit-oak/pull/1855] which is the main revert of [1854|https://github.com/apache/jackrabbit-oak/pull/1854] * manual revert (by reapplying the one-liner) of [1848|https://github.com/apache/jackrabbit-oak/pull/1848] in https://github.com/apache/jackrabbit-oak/commit/9520e95edbc370292c69e77f0368169d164732ef > validation branch for re-reverting PR#1852, #1853, #1854 > > > Key: OAK-11258 > URL: https://issues.apache.org/jira/browse/OAK-11258 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Major > > This is just a book keeping ticket for having a branch that (re-)reverts > [1852|https://github.com/apache/jackrabbit-oak/pull/1852] > [1853|https://github.com/apache/jackrabbit-oak/pull/1853] > [1854|https://github.com/apache/jackrabbit-oak/pull/1854] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11258) validation branch for re-reverting PR#1852, #1853, #1854
[ https://issues.apache.org/jira/browse/OAK-11258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896249#comment-17896249 ] Stefan Egli commented on OAK-11258: --- * branch created https://github.com/apache/jackrabbit-oak/tree/OAK-11258 > validation branch for re-reverting PR#1852, #1853, #1854 > > > Key: OAK-11258 > URL: https://issues.apache.org/jira/browse/OAK-11258 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Major > > This is just a book keeping ticket for having a branch that (re-)reverts > [1852|https://github.com/apache/jackrabbit-oak/pull/1852] > [1853|https://github.com/apache/jackrabbit-oak/pull/1853] > [1854|https://github.com/apache/jackrabbit-oak/pull/1854] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11258) validation branch for re-reverting PR#1852, #1853, #1854
Stefan Egli created OAK-11258: - Summary: validation branch for re-reverting PR#1852, #1853, #1854 Key: OAK-11258 URL: https://issues.apache.org/jira/browse/OAK-11258 Project: Jackrabbit Oak Issue Type: Task Reporter: Stefan Egli Assignee: Stefan Egli This is just a book keeping ticket for having a branch that (re-)reverts [1852|https://github.com/apache/jackrabbit-oak/pull/1852] [1853|https://github.com/apache/jackrabbit-oak/pull/1853] [1854|https://github.com/apache/jackrabbit-oak/pull/1854] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11243) oak-segment-azure tests have broken package names
[
https://issues.apache.org/jira/browse/OAK-11243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke resolved OAK-11243.
--
Resolution: Fixed
> oak-segment-azure tests have broken package names
> -
>
> Key: OAK-11243
> URL: https://issues.apache.org/jira/browse/OAK-11243
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-azure
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.72.0
>
>
> {noformat}
> ./pom.xml
> ./src
> ./src/main
> ./src/main/java
> ./src/main/java/org
> ./src/main/java/org/apache
> ./src/main/java/org/apache/jackrabbit
> ./src/main/java/org/apache/jackrabbit/oak
> ./src/main/java/org/apache/jackrabbit/oak/segment
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureBlobMetadata.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureGCJournalFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureManifestFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureRepositoryLock.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveReader.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveWriter.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentStoreService.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureStorageCredentialManager.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/Configuration.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/package-info.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/ReverseFileReader.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCheck.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCompact.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentCopy.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentStoreMigrator.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureConfigurationParserUtils.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureRequestOptions.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/CaseInsensitiveKeysMapAccess.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/Environment.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/Retrier.java
> ./src/test
> ./src/test/java
> ./src/test/java/oak
> ./src/test/java/oak/apache
> ./src/test/java/oak/apache/jackrabbit
> ./src/test/java/oak/apache/jackrabbit/oak
> ./src/test/java/oak/apache/jackrabbit/oak/segment
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureSasToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureServicePrincipalToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyTarToAzureTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyTestBase.java
> ./src/test/java/org
> ./src/test/java/org/apache
> ./src/test/java/org/apache/jackrabbit
> ./src/test/java/org/apache/jackrabbit/oak
> ./src/test/java/org/apache/jackrabbit/oak/segment
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManagerTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureBlobMetadataTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureGCJournalTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFileConcurrencyIT.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFileTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureMa
[jira] [Created] (OAK-11257) Release Oak 1.72.0
Julian Reschke created OAK-11257: Summary: Release Oak 1.72.0 Key: OAK-11257 URL: https://issues.apache.org/jira/browse/OAK-11257 Project: Jackrabbit Oak Issue Type: Task Reporter: Julian Reschke Assignee: Julian Reschke -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11253) flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
[
https://issues.apache.org/jira/browse/OAK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-11253:
-
Fix Version/s: (was: 1.72.0)
> flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
> -
>
> Key: OAK-11253
> URL: https://issues.apache.org/jira/browse/OAK-11253
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk, rdbmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> There is a new flakyness which looks like below
> {noformat}
> [ERROR] Tests run: 8, Failures: 0, Errors: 2, Skipped: 1, Time elapsed:
> 11.822 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT
> [ERROR] modifiedResetWithDiff[RDBFixture:
> RDB-H2(file)](org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT)
> Time elapsed: 0.361 s <<< ERROR!
> java.lang.IllegalStateException: missing root document
> {noformat}
> while it shows up on modifiedResetWithDiff it is likely introduced by
> unmergedCommitOnRoot.
> excluding also the second flavour of unmergedCommitOnRoot for RDB for now
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (OAK-11248) Create util to close all feature toggles in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reopened OAK-11248: -- > Create util to close all feature toggles in DocumentNodeStore > - > > Key: OAK-11248 > URL: https://issues.apache.org/jira/browse/OAK-11248 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Rishabh Daim >Assignee: Rishabh Daim >Priority: Minor > Fix For: 1.72.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (OAK-11253) flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
[
https://issues.apache.org/jira/browse/OAK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke reopened OAK-11253:
--
> flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
> -
>
> Key: OAK-11253
> URL: https://issues.apache.org/jira/browse/OAK-11253
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk, rdbmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: 1.72.0
>
>
> There is a new flakyness which looks like below
> {noformat}
> [ERROR] Tests run: 8, Failures: 0, Errors: 2, Skipped: 1, Time elapsed:
> 11.822 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT
> [ERROR] modifiedResetWithDiff[RDBFixture:
> RDB-H2(file)](org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT)
> Time elapsed: 0.361 s <<< ERROR!
> java.lang.IllegalStateException: missing root document
> {noformat}
> while it shows up on modifiedResetWithDiff it is likely introduced by
> unmergedCommitOnRoot.
> excluding also the second flavour of unmergedCommitOnRoot for RDB for now
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-11248) Create util to close all feature toggles in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-11248: - Fix Version/s: (was: 1.72.0) > Create util to close all feature toggles in DocumentNodeStore > - > > Key: OAK-11248 > URL: https://issues.apache.org/jira/browse/OAK-11248 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Rishabh Daim >Assignee: Rishabh Daim >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11256) Build Jackrabbit/jackrabbit-oak-trunk #1846 failed
[ https://issues.apache.org/jira/browse/OAK-11256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896147#comment-17896147 ] Hudson commented on OAK-11256: -- Previously failing build now is OK. Passed run: [Jackrabbit/jackrabbit-oak-trunk #1847|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1847/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1847/console] > Build Jackrabbit/jackrabbit-oak-trunk #1846 failed > -- > > Key: OAK-11256 > URL: https://issues.apache.org/jira/browse/OAK-11256 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit/jackrabbit-oak-trunk #1846 has failed. > First failed run: [Jackrabbit/jackrabbit-oak-trunk > #1846|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/] > [console > log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/console] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11256) Build Jackrabbit/jackrabbit-oak-trunk #1846 failed
Hudson created OAK-11256: Summary: Build Jackrabbit/jackrabbit-oak-trunk #1846 failed Key: OAK-11256 URL: https://issues.apache.org/jira/browse/OAK-11256 Project: Jackrabbit Oak Issue Type: Bug Components: continuous integration Reporter: Hudson No description is provided The build Jackrabbit/jackrabbit-oak-trunk #1846 has failed. First failed run: [Jackrabbit/jackrabbit-oak-trunk #1846|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk/1846/console] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11247) Migrate oak-pojosr groovy files to Java
[ https://issues.apache.org/jira/browse/OAK-11247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17896057#comment-17896057 ] Alejandro Moratinos commented on OAK-11247: --- [~reschke] [~angela] I've created a new PR moving oak-pojosr groovy test classes to Java. [https://github.com/apache/jackrabbit-oak/pull/1851] They are hard to compare as groovy files appear as deleted and java files appear as new but almost every change is related on how maps are initialised and replacing asserts with junit asserts. I cannot assign reviewers to the PR so if you consider that someone needs to review it please let me know. > Migrate oak-pojosr groovy files to Java > --- > > Key: OAK-11247 > URL: https://issues.apache.org/jira/browse/OAK-11247 > Project: Jackrabbit Oak > Issue Type: Sub-task > Components: pojosr >Reporter: Alejandro Moratinos >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11248) Create util to close all feature toggles in DocumentNodeStore
[ https://issues.apache.org/jira/browse/OAK-11248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishabh Daim resolved OAK-11248. Fix Version/s: 1.72.0 Resolution: Fixed > Create util to close all feature toggles in DocumentNodeStore > - > > Key: OAK-11248 > URL: https://issues.apache.org/jira/browse/OAK-11248 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Rishabh Daim >Assignee: Rishabh Daim >Priority: Minor > Fix For: 1.72.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11251) Improve warning in collectFullGC
[
https://issues.apache.org/jira/browse/OAK-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli resolved OAK-11251.
---
Resolution: Done
Marking done, [PR|https://github.com/apache/jackrabbit-oak/pull/1844] is
merged, and we should have a clean plate for the release
> Improve warning in collectFullGC
>
>
> Key: OAK-11251
> URL: https://issues.apache.org/jira/browse/OAK-11251
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Minor
> Labels: DetailedGC
>
> This warning could be improved:
> [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java#L941]
> For some reason that is still unclear to me, it seems to log the warning for
> all documents traversed. Example on a test repository:
> {code:java}
> [sling-oak-2-org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService$RevisionGCJob]
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector
> collectFullGC : document has older _modified than query boundary : 1730593015
> (from: 1730593015001 [2024-11-03 00:16:55.001], to: 173059302 [2024-11-03
> 00:17:00.000]) {code}
> Both _modified and boundaries are converted to milliseconds during
> comparison, but in this example _modified has a value of 1730593015000 (in
> ms) and the lower boundary 1730593015001. {*}There is one extra millisecond
> in the from boundary{*}, making the warning to be logged in all the cases.
> I still don't know where and why that extra millisecond is added, but since
> Oak 1.72 should have FullGC ready, I think this warning should be improved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-11253) flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
[
https://issues.apache.org/jira/browse/OAK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated OAK-11253:
--
Fix Version/s: 1.72.0
> flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
> -
>
> Key: OAK-11253
> URL: https://issues.apache.org/jira/browse/OAK-11253
> Project: Jackrabbit Oak
> Issue Type: Test
>Reporter: Stefan Egli
>Priority: Major
> Fix For: 1.72.0
>
>
> There is a new flakyness which looks like below
> {noformat}
> [ERROR] Tests run: 8, Failures: 0, Errors: 2, Skipped: 1, Time elapsed:
> 11.822 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT
> [ERROR] modifiedResetWithDiff[RDBFixture:
> RDB-H2(file)](org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT)
> Time elapsed: 0.361 s <<< ERROR!
> java.lang.IllegalStateException: missing root document
> {noformat}
> while it shows up on modifiedResetWithDiff it is likely introduced by
> unmergedCommitOnRoot.
> excluding also the second flavour of unmergedCommitOnRoot for RDB for now
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-11254) backgroundPurge interferes with fullgc tests
[ https://issues.apache.org/jira/browse/OAK-11254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-11254: -- Description: DocumentNodeStore.backgroundPurge is started in the background and runs right after initialization. Amongst others this method cleans up unmerged branch commits on root, as noticed by [~baedke] offline. FullGC tests have seen flakyness with exactly "missing" unmerged branch commits on root. We need a way to disable backgroundPurge for certain tests - to exclude such interference. As a short-term fix however, the first idea is to add a sleep(1000) to tests that have shown flakyness. was: DocumentNodeStore.backgroundPurge is started in the background and runs right after initialization. Amongst others this method cleans up unmerged branch commits on root. FullGC tests have seen flakyness with exactly "missing" unmerged branch commits on root. We need a way to disable backgroundPurge for certain tests - to exclude such interference. As a short-term fix however, the first idea is to add a sleep(1000) to tests that have shown flakyness. > backgroundPurge interferes with fullgc tests > > > Key: OAK-11254 > URL: https://issues.apache.org/jira/browse/OAK-11254 > Project: Jackrabbit Oak > Issue Type: Test > Components: documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Critical > > DocumentNodeStore.backgroundPurge is started in the background and runs right > after initialization. Amongst others this method cleans up unmerged branch > commits on root, as noticed by [~baedke] offline. FullGC tests have seen > flakyness with exactly "missing" unmerged branch commits on root. > We need a way to disable backgroundPurge for certain tests - to exclude such > interference. > As a short-term fix however, the first idea is to add a sleep(1000) to tests > that have shown flakyness. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11251) Improve warning in collectFullGC
[
https://issues.apache.org/jira/browse/OAK-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895923#comment-17895923
]
Stefan Egli commented on OAK-11251:
---
Could this be due to the fact that we're rounding the {{fromModified}} (which
is in millis) to seconds
[here|https://github.com/apache/jackrabbit-oak/blob/51389a887d312762a40fbcd27f8113db6a491b45/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoVersionGCSupport.java#L260-L266]
(either round it to 1 or 5 seconds)? In which case, the fromModified could be
rounded down - and thus an actually found document could be older..?
In which case the warning would be unnecessary indeed and the fix to check for
rounded seconds appropriate.
> Improve warning in collectFullGC
>
>
> Key: OAK-11251
> URL: https://issues.apache.org/jira/browse/OAK-11251
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Minor
> Labels: DetailedGC
>
> This warning could be improved:
> [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java#L941]
> For some reason that is still unclear to me, it seems to log the warning for
> all documents traversed. Example on a test repository:
> {code:java}
> [sling-oak-2-org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService$RevisionGCJob]
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector
> collectFullGC : document has older _modified than query boundary : 1730593015
> (from: 1730593015001 [2024-11-03 00:16:55.001], to: 173059302 [2024-11-03
> 00:17:00.000]) {code}
> Both _modified and boundaries are converted to milliseconds during
> comparison, but in this example _modified has a value of 1730593015000 (in
> ms) and the lower boundary 1730593015001. {*}There is one extra millisecond
> in the from boundary{*}, making the warning to be logged in all the cases.
> I still don't know where and why that extra millisecond is added, but since
> Oak 1.72 should have FullGC ready, I think this warning should be improved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-11251) Improve warning in collectFullGC
[
https://issues.apache.org/jira/browse/OAK-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895928#comment-17895928
]
José Andrés Cordero Benítez commented on OAK-11251:
---
Shouldn't be because of this. First, the warning was appearing before adding
this fix to the query. Second, this rounding is done inside the
_getModifiedDocs_ method, so it shouldn't propagate outside of it.
> Improve warning in collectFullGC
>
>
> Key: OAK-11251
> URL: https://issues.apache.org/jira/browse/OAK-11251
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Minor
> Labels: DetailedGC
>
> This warning could be improved:
> [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java#L941]
> For some reason that is still unclear to me, it seems to log the warning for
> all documents traversed. Example on a test repository:
> {code:java}
> [sling-oak-2-org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService$RevisionGCJob]
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector
> collectFullGC : document has older _modified than query boundary : 1730593015
> (from: 1730593015001 [2024-11-03 00:16:55.001], to: 173059302 [2024-11-03
> 00:17:00.000]) {code}
> Both _modified and boundaries are converted to milliseconds during
> comparison, but in this example _modified has a value of 1730593015000 (in
> ms) and the lower boundary 1730593015001. {*}There is one extra millisecond
> in the from boundary{*}, making the warning to be logged in all the cases.
> I still don't know where and why that extra millisecond is added, but since
> Oak 1.72 should have FullGC ready, I think this warning should be improved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-11253) flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
[
https://issues.apache.org/jira/browse/OAK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895929#comment-17895929
]
Stefan Egli commented on OAK-11253:
---
PR created : https://github.com/apache/jackrabbit-oak/pull/1848
> flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
> -
>
> Key: OAK-11253
> URL: https://issues.apache.org/jira/browse/OAK-11253
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk, rdbmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: 1.72.0
>
>
> There is a new flakyness which looks like below
> {noformat}
> [ERROR] Tests run: 8, Failures: 0, Errors: 2, Skipped: 1, Time elapsed:
> 11.822 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT
> [ERROR] modifiedResetWithDiff[RDBFixture:
> RDB-H2(file)](org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT)
> Time elapsed: 0.361 s <<< ERROR!
> java.lang.IllegalStateException: missing root document
> {noformat}
> while it shows up on modifiedResetWithDiff it is likely introduced by
> unmergedCommitOnRoot.
> excluding also the second flavour of unmergedCommitOnRoot for RDB for now
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (OAK-11253) flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
[
https://issues.apache.org/jira/browse/OAK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli resolved OAK-11253.
---
Resolution: Fixed
merged. marking resolved. the test yet needs to be re-enabled at some point
though, but flakyness should be fixed.
> flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
> -
>
> Key: OAK-11253
> URL: https://issues.apache.org/jira/browse/OAK-11253
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk, rdbmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: 1.72.0
>
>
> There is a new flakyness which looks like below
> {noformat}
> [ERROR] Tests run: 8, Failures: 0, Errors: 2, Skipped: 1, Time elapsed:
> 11.822 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT
> [ERROR] modifiedResetWithDiff[RDBFixture:
> RDB-H2(file)](org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT)
> Time elapsed: 0.361 s <<< ERROR!
> java.lang.IllegalStateException: missing root document
> {noformat}
> while it shows up on modifiedResetWithDiff it is likely introduced by
> unmergedCommitOnRoot.
> excluding also the second flavour of unmergedCommitOnRoot for RDB for now
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OAK-11253) flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
[
https://issues.apache.org/jira/browse/OAK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli reassigned OAK-11253:
-
Assignee: Stefan Egli
> flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
> -
>
> Key: OAK-11253
> URL: https://issues.apache.org/jira/browse/OAK-11253
> Project: Jackrabbit Oak
> Issue Type: Test
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: 1.72.0
>
>
> There is a new flakyness which looks like below
> {noformat}
> [ERROR] Tests run: 8, Failures: 0, Errors: 2, Skipped: 1, Time elapsed:
> 11.822 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT
> [ERROR] modifiedResetWithDiff[RDBFixture:
> RDB-H2(file)](org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT)
> Time elapsed: 0.361 s <<< ERROR!
> java.lang.IllegalStateException: missing root document
> {noformat}
> while it shows up on modifiedResetWithDiff it is likely introduced by
> unmergedCommitOnRoot.
> excluding also the second flavour of unmergedCommitOnRoot for RDB for now
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-11253) flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
[
https://issues.apache.org/jira/browse/OAK-11253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli updated OAK-11253:
--
Component/s: documentmk
rdbmk
> flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
> -
>
> Key: OAK-11253
> URL: https://issues.apache.org/jira/browse/OAK-11253
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk, rdbmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
> Fix For: 1.72.0
>
>
> There is a new flakyness which looks like below
> {noformat}
> [ERROR] Tests run: 8, Failures: 0, Errors: 2, Skipped: 1, Time elapsed:
> 11.822 s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT
> [ERROR] modifiedResetWithDiff[RDBFixture:
> RDB-H2(file)](org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT)
> Time elapsed: 0.361 s <<< ERROR!
> java.lang.IllegalStateException: missing root document
> {noformat}
> while it shows up on modifiedResetWithDiff it is likely introduced by
> unmergedCommitOnRoot.
> excluding also the second flavour of unmergedCommitOnRoot for RDB for now
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-11254) backgroundPurge interferes with fullgc tests
[ https://issues.apache.org/jira/browse/OAK-11254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895959#comment-17895959 ] Stefan Egli commented on OAK-11254: --- Created OAK-11255 to look into doing this properly (after 1.72) > backgroundPurge interferes with fullgc tests > > > Key: OAK-11254 > URL: https://issues.apache.org/jira/browse/OAK-11254 > Project: Jackrabbit Oak > Issue Type: Test > Components: documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Critical > > DocumentNodeStore.backgroundPurge is started in the background and runs right > after initialization. Amongst others this method cleans up unmerged branch > commits on root, as noticed by [~baedke] offline. FullGC tests have seen > flakyness with exactly "missing" unmerged branch commits on root. > We need a way to disable backgroundPurge for certain tests - to exclude such > interference. > As a short-term fix however, the first idea is to add a sleep(1000) to tests > that have shown flakyness. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11254) backgroundPurge interferes with fullgc tests
Stefan Egli created OAK-11254: - Summary: backgroundPurge interferes with fullgc tests Key: OAK-11254 URL: https://issues.apache.org/jira/browse/OAK-11254 Project: Jackrabbit Oak Issue Type: Test Components: documentmk Reporter: Stefan Egli Assignee: Stefan Egli DocumentNodeStore.backgroundPurge is started in the background and runs right after initialization. Amongst others this method cleans up unmerged branch commits on root. FullGC tests have seen flakyness with exactly "missing" unmerged branch commits on root. We need a way to disable backgroundPurge for certain tests - to exclude such interference. As a short-term fix however, the first idea is to add a sleep(1000) to tests that have shown flakyness. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11253) flakyness in DocumentNodeStoreIT with new prevNoProp tests introduced
Stefan Egli created OAK-11253:
-
Summary: flakyness in DocumentNodeStoreIT with new prevNoProp
tests introduced
Key: OAK-11253
URL: https://issues.apache.org/jira/browse/OAK-11253
Project: Jackrabbit Oak
Issue Type: Test
Reporter: Stefan Egli
There is a new flakyness which looks like below
{noformat}
[ERROR] Tests run: 8, Failures: 0, Errors: 2, Skipped: 1, Time elapsed: 11.822
s <<< FAILURE! - in
org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT
[ERROR] modifiedResetWithDiff[RDBFixture:
RDB-H2(file)](org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreIT)
Time elapsed: 0.361 s <<< ERROR!
java.lang.IllegalStateException: missing root document
{noformat}
while it shows up on modifiedResetWithDiff it is likely introduced by
unmergedCommitOnRoot.
excluding also the second flavour of unmergedCommitOnRoot for RDB for now
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-11255) backgroundPurge should be stoppable for tests (and stopped in fullgc tests)
[ https://issues.apache.org/jira/browse/OAK-11255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-11255: -- Affects Version/s: 1.72.0 > backgroundPurge should be stoppable for tests (and stopped in fullgc tests) > --- > > Key: OAK-11255 > URL: https://issues.apache.org/jira/browse/OAK-11255 > Project: Jackrabbit Oak > Issue Type: Test > Components: documentmk >Affects Versions: 1.72.0 >Reporter: Stefan Egli >Priority: Minor > > In OAK-11254 we're doing a short-term fix (a 1sec sleep after startup) to > reduce flakyness due to backgroundPurge interfering with fullgc test. We > should replace that 1sec sleep with something more proper. For example by > introducing a disableBackgroundPurge (used by testing only) - or some way to > do that on the builder - or some other way - just not sleep(1sec) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11254) backgroundPurge interferes with fullgc tests
[ https://issues.apache.org/jira/browse/OAK-11254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli updated OAK-11254: -- Fix Version/s: 1.72.0 > backgroundPurge interferes with fullgc tests > > > Key: OAK-11254 > URL: https://issues.apache.org/jira/browse/OAK-11254 > Project: Jackrabbit Oak > Issue Type: Test > Components: documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Critical > Fix For: 1.72.0 > > > DocumentNodeStore.backgroundPurge is started in the background and runs right > after initialization. Amongst others this method cleans up unmerged branch > commits on root, as noticed by [~baedke] offline. FullGC tests have seen > flakyness with exactly "missing" unmerged branch commits on root. > We need a way to disable backgroundPurge for certain tests - to exclude such > interference. > As a short-term fix however, the first idea is to add a sleep(1000) to tests > that have shown flakyness. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11255) backgroundPurge should be stoppable for tests (and stopped in fullgc tests)
Stefan Egli created OAK-11255: - Summary: backgroundPurge should be stoppable for tests (and stopped in fullgc tests) Key: OAK-11255 URL: https://issues.apache.org/jira/browse/OAK-11255 Project: Jackrabbit Oak Issue Type: Test Components: documentmk Reporter: Stefan Egli In OAK-11254 we're doing a short-term fix (a 1sec sleep after startup) to reduce flakyness due to backgroundPurge interfering with fullgc test. We should replace that 1sec sleep with something more proper. For example by introducing a disableBackgroundPurge (used by testing only) - or some way to do that on the builder - or some other way - just not sleep(1sec) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11254) backgroundPurge interferes with fullgc tests
[ https://issues.apache.org/jira/browse/OAK-11254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Egli resolved OAK-11254. --- Resolution: Fixed > backgroundPurge interferes with fullgc tests > > > Key: OAK-11254 > URL: https://issues.apache.org/jira/browse/OAK-11254 > Project: Jackrabbit Oak > Issue Type: Test > Components: documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Critical > Fix For: 1.72.0 > > > DocumentNodeStore.backgroundPurge is started in the background and runs right > after initialization. Amongst others this method cleans up unmerged branch > commits on root, as noticed by [~baedke] offline. FullGC tests have seen > flakyness with exactly "missing" unmerged branch commits on root. > We need a way to disable backgroundPurge for certain tests - to exclude such > interference. > As a short-term fix however, the first idea is to add a sleep(1000) to tests > that have shown flakyness. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11254) backgroundPurge interferes with fullgc tests
[ https://issues.apache.org/jira/browse/OAK-11254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895950#comment-17895950 ] Stefan Egli commented on OAK-11254: --- PR created : https://github.com/apache/jackrabbit-oak/pull/1849 > backgroundPurge interferes with fullgc tests > > > Key: OAK-11254 > URL: https://issues.apache.org/jira/browse/OAK-11254 > Project: Jackrabbit Oak > Issue Type: Test > Components: documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Critical > > DocumentNodeStore.backgroundPurge is started in the background and runs right > after initialization. Amongst others this method cleans up unmerged branch > commits on root, as noticed by [~baedke] offline. FullGC tests have seen > flakyness with exactly "missing" unmerged branch commits on root. > We need a way to disable backgroundPurge for certain tests - to exclude such > interference. > As a short-term fix however, the first idea is to add a sleep(1000) to tests > that have shown flakyness. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11254) backgroundPurge interferes with fullgc tests
[ https://issues.apache.org/jira/browse/OAK-11254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895964#comment-17895964 ] Stefan Egli commented on OAK-11254: --- PR merged : https://github.com/apache/jackrabbit-oak/pull/1849 OAK-11255 will take care of doing this more appropriately later Marking this as resolved > backgroundPurge interferes with fullgc tests > > > Key: OAK-11254 > URL: https://issues.apache.org/jira/browse/OAK-11254 > Project: Jackrabbit Oak > Issue Type: Test > Components: documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Critical > Fix For: 1.72.0 > > > DocumentNodeStore.backgroundPurge is started in the background and runs right > after initialization. Amongst others this method cleans up unmerged branch > commits on root, as noticed by [~baedke] offline. FullGC tests have seen > flakyness with exactly "missing" unmerged branch commits on root. > We need a way to disable backgroundPurge for certain tests - to exclude such > interference. > As a short-term fix however, the first idea is to add a sleep(1000) to tests > that have shown flakyness. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11252) flaky BranchCommitGCTest.unmergedRemoveChild
Stefan Egli created OAK-11252:
-
Summary: flaky BranchCommitGCTest.unmergedRemoveChild
Key: OAK-11252
URL: https://issues.apache.org/jira/browse/OAK-11252
Project: Jackrabbit Oak
Issue Type: Test
Components: documentmk
Reporter: Stefan Egli
Assignee: Stefan Egli
increased recent flakyness like below:
{noformat}
[2024-11-05T23:38:28.210Z] [ERROR] unmergedRemoveChild[17: MongoFixture:
MongoDB with
ORPHANS_EMPTYPROPS_UNMERGED_BC](org.apache.jackrabbit.oak.plugins.document.BranchCommitGCTest)
Time elapsed: 0.024 s <<< FAILURE!
[2024-11-05T23:38:28.210Z] java.lang.AssertionError:
[2024-11-05T23:38:28.210Z] ORPHANS_EMPTYPROPS_UNMERGED_BC/internalProps -
staticStore : Nodes:
[2024-11-05T23:38:28.210Z] Path: 0:/
[2024-11-05T23:38:28.210Z] _children=true
[2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
[2024-11-05T23:38:28.210Z] _deleted={r192feb1a056-0-1=false}
[2024-11-05T23:38:28.210Z] _collisions={r192feb1a0a6-0-1=r192feb1a0ad-0-1,
r192feb1a09f-0-1=r192feb1a0a6-0-1, r192feb1a098-0-1=r192feb1a09f-0-1,
r192feb1a093-0-1=r192feb1a098-0-1}
[2024-11-05T23:38:28.210Z] _commitRoot={}
[2024-11-05T23:38:28.210Z] _sweepRev={r0-0-1=r192feb1a071-0-1}
[2024-11-05T23:38:28.210Z] _revisions={r192feb1a067-0-1=c-r192feb1a071-0-1,
r192feb1a056-0-1=c}
[2024-11-05T23:38:28.210Z] _id=0:/
[2024-11-05T23:38:28.210Z] _modified=1730849905
[2024-11-05T23:38:28.210Z] _lastRev={r0-0-1=r192feb1a071-0-1}
[2024-11-05T23:38:28.210Z]
[2024-11-05T23:38:28.210Z] Path: 1:/bar
[2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
[2024-11-05T23:38:28.210Z] _deleted={r192feb1a067-0-1=false}
[2024-11-05T23:38:28.210Z] _commitRoot={r192feb1a067-0-1=0}
[2024-11-05T23:38:28.210Z] _id=1:/bar
[2024-11-05T23:38:28.210Z] _modified=1730849905
[2024-11-05T23:38:28.210Z]
[2024-11-05T23:38:28.210Z] Path: 1:/foo
[2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
[2024-11-05T23:38:28.210Z] _deleted={r192feb1a067-0-1=false}
[2024-11-05T23:38:28.210Z] _commitRoot={r192feb1a067-0-1=0}
[2024-11-05T23:38:28.210Z] _id=1:/foo
[2024-11-05T23:38:28.210Z] _modified=1730849905
[2024-11-05T23:38:28.210Z]
[2024-11-05T23:38:28.210Z] expected:<1> but was:<0>
[2024-11-05T23:38:28.210Z] at org.junit.Assert.fail(Assert.java:89)
[2024-11-05T23:38:28.210Z] at
org.junit.Assert.failNotEquals(Assert.java:835)
[2024-11-05T23:38:28.210Z] at
org.junit.Assert.assertEquals(Assert.java:647)
[2024-11-05T23:38:28.210Z] at
org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT.doAssertEquals(VersionGarbageCollectorIT.java:1533)
[2024-11-05T23:38:28.210Z] at
org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT.assertStatsCountsEqual(VersionGarbageCollectorIT.java:1518)
[2024-11-05T23:38:28.210Z] at
org.apache.jackrabbit.oak.plugins.document.BranchCommitGCTest.unmergedRemoveChild(BranchCommitGCTest.java:600)
[2024-11-05T23:38:28.210Z] at
jdk.internal.reflect.GeneratedMethodAccessor219.invoke(Unknown Source)
[2024-11-05T23:38:28.210Z] at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[2024-11-05T23:38:28.210Z] at
java.base/java.lang.reflect.Method.invoke(Method.java:566)
[2024-11-05T23:38:28.210Z] at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
[2024-11-05T23:38:28.210Z] at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
[2024-11-05T23:38:28.210Z] at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
[2024-11-05T23:38:28.210Z] at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
[2024-11-05T23:38:28.210Z] at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
[2024-11-05T23:38:28.210Z] at
org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
[2024-11-05T23:38:28.211Z] at
org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
[2024-11-05T23:38:28.211Z] at
org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
[2024-11-05T23:38:28.211Z] at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
[2024-11-05T23:38:28.211Z] at
org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
[2024-11-05T23:38:28.211Z] at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
[2024-11-05T23:38:28.211Z] at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
[2024-11-05T23:38:28.211Z] at
org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
[2024-11-05T23:38:28.211Z] at
org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
[2024-11-05T23:38:28.211Z] at
org.junit.runners.Par
[jira] [Commented] (OAK-11252) flaky BranchCommitGCTest.unmergedRemoveChild
[
https://issues.apache.org/jira/browse/OAK-11252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895915#comment-17895915
]
Stefan Egli commented on OAK-11252:
---
PR merged : https://github.com/apache/jackrabbit-oak/pull/1847
> flaky BranchCommitGCTest.unmergedRemoveChild
>
>
> Key: OAK-11252
> URL: https://issues.apache.org/jira/browse/OAK-11252
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> increased recent flakyness like below:
> {noformat}
> [2024-11-05T23:38:28.210Z] [ERROR] unmergedRemoveChild[17: MongoFixture:
> MongoDB with
> ORPHANS_EMPTYPROPS_UNMERGED_BC](org.apache.jackrabbit.oak.plugins.document.BranchCommitGCTest)
> Time elapsed: 0.024 s <<< FAILURE!
> [2024-11-05T23:38:28.210Z] java.lang.AssertionError:
> [2024-11-05T23:38:28.210Z] ORPHANS_EMPTYPROPS_UNMERGED_BC/internalProps -
> staticStore : Nodes:
> [2024-11-05T23:38:28.210Z] Path: 0:/
> [2024-11-05T23:38:28.210Z] _children=true
> [2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
> [2024-11-05T23:38:28.210Z] _deleted={r192feb1a056-0-1=false}
> [2024-11-05T23:38:28.210Z] _collisions={r192feb1a0a6-0-1=r192feb1a0ad-0-1,
> r192feb1a09f-0-1=r192feb1a0a6-0-1, r192feb1a098-0-1=r192feb1a09f-0-1,
> r192feb1a093-0-1=r192feb1a098-0-1}
> [2024-11-05T23:38:28.210Z] _commitRoot={}
> [2024-11-05T23:38:28.210Z] _sweepRev={r0-0-1=r192feb1a071-0-1}
> [2024-11-05T23:38:28.210Z] _revisions={r192feb1a067-0-1=c-r192feb1a071-0-1,
> r192feb1a056-0-1=c}
> [2024-11-05T23:38:28.210Z] _id=0:/
> [2024-11-05T23:38:28.210Z] _modified=1730849905
> [2024-11-05T23:38:28.210Z] _lastRev={r0-0-1=r192feb1a071-0-1}
> [2024-11-05T23:38:28.210Z]
> [2024-11-05T23:38:28.210Z] Path: 1:/bar
> [2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
> [2024-11-05T23:38:28.210Z] _deleted={r192feb1a067-0-1=false}
> [2024-11-05T23:38:28.210Z] _commitRoot={r192feb1a067-0-1=0}
> [2024-11-05T23:38:28.210Z] _id=1:/bar
> [2024-11-05T23:38:28.210Z] _modified=1730849905
> [2024-11-05T23:38:28.210Z]
> [2024-11-05T23:38:28.210Z] Path: 1:/foo
> [2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
> [2024-11-05T23:38:28.210Z] _deleted={r192feb1a067-0-1=false}
> [2024-11-05T23:38:28.210Z] _commitRoot={r192feb1a067-0-1=0}
> [2024-11-05T23:38:28.210Z] _id=1:/foo
> [2024-11-05T23:38:28.210Z] _modified=1730849905
> [2024-11-05T23:38:28.210Z]
> [2024-11-05T23:38:28.210Z] expected:<1> but was:<0>
> [2024-11-05T23:38:28.210Z]at org.junit.Assert.fail(Assert.java:89)
> [2024-11-05T23:38:28.210Z]at
> org.junit.Assert.failNotEquals(Assert.java:835)
> [2024-11-05T23:38:28.210Z]at
> org.junit.Assert.assertEquals(Assert.java:647)
> [2024-11-05T23:38:28.210Z]at
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT.doAssertEquals(VersionGarbageCollectorIT.java:1533)
> [2024-11-05T23:38:28.210Z]at
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT.assertStatsCountsEqual(VersionGarbageCollectorIT.java:1518)
> [2024-11-05T23:38:28.210Z]at
> org.apache.jackrabbit.oak.plugins.document.BranchCommitGCTest.unmergedRemoveChild(BranchCommitGCTest.java:600)
> [2024-11-05T23:38:28.210Z]at
> jdk.internal.reflect.GeneratedMethodAccessor219.invoke(Unknown Source)
> [2024-11-05T23:38:28.210Z]at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [2024-11-05T23:38:28.210Z]at
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> [2024-11-05T23:38:28.210Z]at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> [2024-11-05T23:38:28.210Z]at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> [2024-11-05T23:38:28.210Z]at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> [2024-11-05T23:38:28.210Z]at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> [2024-11-05T23:38:28.210Z]at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> [2024-11-05T23:38:28.210Z]at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> [2024-11-05T23:38:28.211Z]at
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> [2024-11-05T23:38:28.211Z]at
> org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> [2024-11-05T23:38:28.211Z]
[jira] [Commented] (OAK-11252) flaky BranchCommitGCTest.unmergedRemoveChild
[
https://issues.apache.org/jira/browse/OAK-11252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895914#comment-17895914
]
Stefan Egli commented on OAK-11252:
---
PR created : https://github.com/apache/jackrabbit-oak/pull/1847
> flaky BranchCommitGCTest.unmergedRemoveChild
>
>
> Key: OAK-11252
> URL: https://issues.apache.org/jira/browse/OAK-11252
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> increased recent flakyness like below:
> {noformat}
> [2024-11-05T23:38:28.210Z] [ERROR] unmergedRemoveChild[17: MongoFixture:
> MongoDB with
> ORPHANS_EMPTYPROPS_UNMERGED_BC](org.apache.jackrabbit.oak.plugins.document.BranchCommitGCTest)
> Time elapsed: 0.024 s <<< FAILURE!
> [2024-11-05T23:38:28.210Z] java.lang.AssertionError:
> [2024-11-05T23:38:28.210Z] ORPHANS_EMPTYPROPS_UNMERGED_BC/internalProps -
> staticStore : Nodes:
> [2024-11-05T23:38:28.210Z] Path: 0:/
> [2024-11-05T23:38:28.210Z] _children=true
> [2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
> [2024-11-05T23:38:28.210Z] _deleted={r192feb1a056-0-1=false}
> [2024-11-05T23:38:28.210Z] _collisions={r192feb1a0a6-0-1=r192feb1a0ad-0-1,
> r192feb1a09f-0-1=r192feb1a0a6-0-1, r192feb1a098-0-1=r192feb1a09f-0-1,
> r192feb1a093-0-1=r192feb1a098-0-1}
> [2024-11-05T23:38:28.210Z] _commitRoot={}
> [2024-11-05T23:38:28.210Z] _sweepRev={r0-0-1=r192feb1a071-0-1}
> [2024-11-05T23:38:28.210Z] _revisions={r192feb1a067-0-1=c-r192feb1a071-0-1,
> r192feb1a056-0-1=c}
> [2024-11-05T23:38:28.210Z] _id=0:/
> [2024-11-05T23:38:28.210Z] _modified=1730849905
> [2024-11-05T23:38:28.210Z] _lastRev={r0-0-1=r192feb1a071-0-1}
> [2024-11-05T23:38:28.210Z]
> [2024-11-05T23:38:28.210Z] Path: 1:/bar
> [2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
> [2024-11-05T23:38:28.210Z] _deleted={r192feb1a067-0-1=false}
> [2024-11-05T23:38:28.210Z] _commitRoot={r192feb1a067-0-1=0}
> [2024-11-05T23:38:28.210Z] _id=1:/bar
> [2024-11-05T23:38:28.210Z] _modified=1730849905
> [2024-11-05T23:38:28.210Z]
> [2024-11-05T23:38:28.210Z] Path: 1:/foo
> [2024-11-05T23:38:28.210Z] _bc={r192feb1a067-0-1=true}
> [2024-11-05T23:38:28.210Z] _deleted={r192feb1a067-0-1=false}
> [2024-11-05T23:38:28.210Z] _commitRoot={r192feb1a067-0-1=0}
> [2024-11-05T23:38:28.210Z] _id=1:/foo
> [2024-11-05T23:38:28.210Z] _modified=1730849905
> [2024-11-05T23:38:28.210Z]
> [2024-11-05T23:38:28.210Z] expected:<1> but was:<0>
> [2024-11-05T23:38:28.210Z]at org.junit.Assert.fail(Assert.java:89)
> [2024-11-05T23:38:28.210Z]at
> org.junit.Assert.failNotEquals(Assert.java:835)
> [2024-11-05T23:38:28.210Z]at
> org.junit.Assert.assertEquals(Assert.java:647)
> [2024-11-05T23:38:28.210Z]at
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT.doAssertEquals(VersionGarbageCollectorIT.java:1533)
> [2024-11-05T23:38:28.210Z]at
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollectorIT.assertStatsCountsEqual(VersionGarbageCollectorIT.java:1518)
> [2024-11-05T23:38:28.210Z]at
> org.apache.jackrabbit.oak.plugins.document.BranchCommitGCTest.unmergedRemoveChild(BranchCommitGCTest.java:600)
> [2024-11-05T23:38:28.210Z]at
> jdk.internal.reflect.GeneratedMethodAccessor219.invoke(Unknown Source)
> [2024-11-05T23:38:28.210Z]at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> [2024-11-05T23:38:28.210Z]at
> java.base/java.lang.reflect.Method.invoke(Method.java:566)
> [2024-11-05T23:38:28.210Z]at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> [2024-11-05T23:38:28.210Z]at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> [2024-11-05T23:38:28.210Z]at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> [2024-11-05T23:38:28.210Z]at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> [2024-11-05T23:38:28.210Z]at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> [2024-11-05T23:38:28.210Z]at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> [2024-11-05T23:38:28.211Z]at
> org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:54)
> [2024-11-05T23:38:28.211Z]at
> org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> [2024-11-05T23:38:28.211Z]
[jira] [Updated] (OAK-11220) Remove usage of Guava Sets.newConcurrentHashSet
[ https://issues.apache.org/jira/browse/OAK-11220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishabh Daim updated OAK-11220: --- Description: Replace Sets.newConcurrentHashSet with newly created api CollectionUtils.newConcurrentHashSet() in OAK-11226. > Remove usage of Guava Sets.newConcurrentHashSet > --- > > Key: OAK-11220 > URL: https://issues.apache.org/jira/browse/OAK-11220 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Rishabh Daim >Assignee: Rishabh Daim >Priority: Major > > Replace Sets.newConcurrentHashSet with newly created api > CollectionUtils.newConcurrentHashSet() in OAK-11226. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11220) Remove usage of Guava Sets.newConcurrentHashSet
[
https://issues.apache.org/jira/browse/OAK-11220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rishabh Daim updated OAK-11220:
---
Description: Replace {code}Sets.newConcurrentHashSet{code} with newly
created API {code}CollectionUtils.newConcurrentHashSet(){code} in OAK-11226.
(was: Replace `Sets.newConcurrentHashSet` with newly created API
`CollectionUtils.newConcurrentHashSet()` in OAK-11226.)
> Remove usage of Guava Sets.newConcurrentHashSet
> ---
>
> Key: OAK-11220
> URL: https://issues.apache.org/jira/browse/OAK-11220
> Project: Jackrabbit Oak
> Issue Type: Technical task
>Reporter: Rishabh Daim
>Assignee: Rishabh Daim
>Priority: Major
>
> Replace {code}Sets.newConcurrentHashSet{code} with newly created API
> {code}CollectionUtils.newConcurrentHashSet(){code} in OAK-11226.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-11220) Remove usage of Guava Sets.newConcurrentHashSet
[ https://issues.apache.org/jira/browse/OAK-11220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishabh Daim updated OAK-11220: --- Description: Replace `Sets.newConcurrentHashSet` with newly created API `CollectionUtils.newConcurrentHashSet()` in OAK-11226. (was: Replace Sets.newConcurrentHashSet with newly created api CollectionUtils.newConcurrentHashSet() in OAK-11226.) > Remove usage of Guava Sets.newConcurrentHashSet > --- > > Key: OAK-11220 > URL: https://issues.apache.org/jira/browse/OAK-11220 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Rishabh Daim >Assignee: Rishabh Daim >Priority: Major > > Replace `Sets.newConcurrentHashSet` with newly created API > `CollectionUtils.newConcurrentHashSet()` in OAK-11226. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11251) Improve warning in collectFullGC
[
https://issues.apache.org/jira/browse/OAK-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895827#comment-17895827
]
José Andrés Cordero Benítez commented on OAK-11251:
---
I see 3 possible improvements, I am ordering them from less to more required
changes:
# Simplest fix. As proposed [on PR
1844|[https://github.com/apache/jackrabbit-oak/pull/1844]|https://github.com/apache/jackrabbit-oak/pull/1844]:]:
Instead of converting _modified to milliseconds, convert the boundaries to
seconds granularity for this comparison. This will discard any extra
milliseconds added to the boundaries. I know this is not the proper fix, but
it's the easiest solution to avoid printing this for each single document
(alternatively we could simply reduce it to _debug_ level too, but we may lose
interesting cases).
# Actually debug it and see what is adding the extra millisecond, understand
how it happens, and fix it or find a better way to reduce the noise of the
warning.
# Most complex change. Do we really need milliseconds granularity on those
boundaries? The _modified value is always stored as seconds, so probably we
could simply use seconds instead of milliseconds. But this would require a
bigger change in FullGC logic.
/cc [~stefanegli] [~rishudaim]
> Improve warning in collectFullGC
>
>
> Key: OAK-11251
> URL: https://issues.apache.org/jira/browse/OAK-11251
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Minor
> Labels: DetailedGC
>
> This warning could be improved:
> [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java#L941]
> For some reason that is still unclear to me, it seems to log the warning for
> all documents traversed. Example on a test repository:
> {code:java}
> [sling-oak-2-org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService$RevisionGCJob]
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector
> collectFullGC : document has older _modified than query boundary : 1730593015
> (from: 1730593015001 [2024-11-03 00:16:55.001], to: 173059302 [2024-11-03
> 00:17:00.000]) {code}
> Both _modified and boundaries are converted to milliseconds during
> comparison, but in this example _modified has a value of 1730593015000 (in
> ms) and the lower boundary 1730593015001. {*}There is one extra millisecond
> in the from boundary{*}, making the warning to be logged in all the cases.
> I still don't know where and why that extra millisecond is added, but since
> Oak 1.72 should have FullGC ready, I think this warning should be improved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OAK-11251) Improve warning in collectFullGC
[
https://issues.apache.org/jira/browse/OAK-11251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Andrés Cordero Benítez updated OAK-11251:
--
Description:
This warning could be improved:
[https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java#L941]
For some reason that is still unclear to me, it seems to log the warning for
all documents traversed. Example on a test repository:
{code:java}
[sling-oak-2-org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService$RevisionGCJob]
org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector
collectFullGC : document has older _modified than query boundary : 1730593015
(from: 1730593015001 [2024-11-03 00:16:55.001], to: 173059302 [2024-11-03
00:17:00.000]) {code}
Both _modified and boundaries are converted to milliseconds during comparison,
but in this example _modified has a value of 1730593015000 (in ms) and the
lower boundary 1730593015001. {*}There is one extra millisecond in the from
boundary{*}, making the warning to be logged in all the cases.
I still don't know where and why that extra millisecond is added, but since Oak
1.72 should have FullGC ready, I think this warning should be improved.
was:
This warning could be improved:
[https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java#L941]
For some reason that is still unclear to me, it seems to log the warning for
all documents traversed. Example on a test repository:
{code:java}
[sling-oak-2-org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService$RevisionGCJob]
org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector
collectFullGC : document has older _modified than query boundary : 1730593015
(from: 1730593015001 [2024-11-03 00:16:55.001], to: 173059302 [2024-11-03
00:17:00.000]) {code}
Both _modified and boundaries are converted to milliseconds during comparison,
but in this example _modified has a value of 1730593015000 (in ms) and the
lower boundary 1730593015001. There is one extra millisecond in the from
boundary, making the warning to be logged in all the cases.
I still don't know where and why that extra millisecond is added, but since Oak
1.72 should have FullGC ready, I think this warning should be improved.
> Improve warning in collectFullGC
>
>
> Key: OAK-11251
> URL: https://issues.apache.org/jira/browse/OAK-11251
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
>Reporter: José Andrés Cordero Benítez
>Assignee: José Andrés Cordero Benítez
>Priority: Minor
> Labels: DetailedGC
>
> This warning could be improved:
> [https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java#L941]
> For some reason that is still unclear to me, it seems to log the warning for
> all documents traversed. Example on a test repository:
> {code:java}
> [sling-oak-2-org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService$RevisionGCJob]
> org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector
> collectFullGC : document has older _modified than query boundary : 1730593015
> (from: 1730593015001 [2024-11-03 00:16:55.001], to: 173059302 [2024-11-03
> 00:17:00.000]) {code}
> Both _modified and boundaries are converted to milliseconds during
> comparison, but in this example _modified has a value of 1730593015000 (in
> ms) and the lower boundary 1730593015001. {*}There is one extra millisecond
> in the from boundary{*}, making the warning to be logged in all the cases.
> I still don't know where and why that extra millisecond is added, but since
> Oak 1.72 should have FullGC ready, I think this warning should be improved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OAK-11251) Improve warning in collectFullGC
José Andrés Cordero Benítez created OAK-11251:
-
Summary: Improve warning in collectFullGC
Key: OAK-11251
URL: https://issues.apache.org/jira/browse/OAK-11251
Project: Jackrabbit Oak
Issue Type: Improvement
Components: documentmk
Reporter: José Andrés Cordero Benítez
Assignee: José Andrés Cordero Benítez
This warning could be improved:
[https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java#L941]
For some reason that is still unclear to me, it seems to log the warning for
all documents traversed. Example on a test repository:
{code:java}
[sling-oak-2-org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreService$RevisionGCJob]
org.apache.jackrabbit.oak.plugins.document.VersionGarbageCollector
collectFullGC : document has older _modified than query boundary : 1730593015
(from: 1730593015001 [2024-11-03 00:16:55.001], to: 173059302 [2024-11-03
00:17:00.000]) {code}
Both _modified and boundaries are converted to milliseconds during comparison,
but in this example _modified has a value of 1730593015000 (in ms) and the
lower boundary 1730593015001. There is one extra millisecond in the from
boundary, making the warning to be logged in all the cases.
I still don't know where and why that extra millisecond is added, but since Oak
1.72 should have FullGC ready, I think this warning should be improved.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-11240) Build Jackrabbit/jackrabbit-oak-trunk-documentns #363 failed
[ https://issues.apache.org/jira/browse/OAK-11240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895819#comment-17895819 ] Hudson commented on OAK-11240: -- Previously failing build now is OK. Passed run: [Jackrabbit/jackrabbit-oak-trunk-documentns #372|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-documentns/372/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-documentns/372/console] > Build Jackrabbit/jackrabbit-oak-trunk-documentns #363 failed > > > Key: OAK-11240 > URL: https://issues.apache.org/jira/browse/OAK-11240 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit/jackrabbit-oak-trunk-documentns #363 has failed. > First failed run: [Jackrabbit/jackrabbit-oak-trunk-documentns > #363|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-documentns/363/] > [console > log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-documentns/363/console] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11242) AzureRepositoryLock: Thread should not die silently on any kind of error
[ https://issues.apache.org/jira/browse/OAK-11242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-11242. -- Fix Version/s: 1.72.0 Resolution: Fixed > AzureRepositoryLock: Thread should not die silently on any kind of error > > > Key: OAK-11242 > URL: https://issues.apache.org/jira/browse/OAK-11242 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure >Affects Versions: 1.70.0 >Reporter: Axel Hanikel >Priority: Major > Fix For: 1.72.0 > > > This is a follow-up to OAK-11069: Apparently the refresher thread still dies > without a trace. I'm therefore assuming some java.lang.Error occurs, which is > hidden behind the executor. An approach could be to avoid the executor in > favour of creating the thread ourselves, and catching all Throwables to make > sure we handle them. We leave fatal errors such as OOME to pop up in other > parts of the code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OAK-11242) AzureRepositoryLock: Thread should not die silently on any kind of error
[ https://issues.apache.org/jira/browse/OAK-11242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned OAK-11242: Assignee: Axel Hanikel > AzureRepositoryLock: Thread should not die silently on any kind of error > > > Key: OAK-11242 > URL: https://issues.apache.org/jira/browse/OAK-11242 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure >Affects Versions: 1.70.0 >Reporter: Axel Hanikel >Assignee: Axel Hanikel >Priority: Major > Fix For: 1.72.0 > > > This is a follow-up to OAK-11069: Apparently the refresher thread still dies > without a trace. I'm therefore assuming some java.lang.Error occurs, which is > hidden behind the executor. An approach could be to avoid the executor in > favour of creating the thread ourselves, and catching all Throwables to make > sure we handle them. We leave fatal errors such as OOME to pop up in other > parts of the code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11242) AzureRepositoryLock: Thread should not die silently on any kind of error
[ https://issues.apache.org/jira/browse/OAK-11242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895672#comment-17895672 ] Miroslav Smiljanic commented on OAK-11242: -- Yes, it should. I was reviewing the PR, and since it was only referencing the old issue https://issues.apache.org/jira/browse/OAK-11069, I have created a new one https://issues.apache.org/jira/browse/OAK-11249. > AzureRepositoryLock: Thread should not die silently on any kind of error > > > Key: OAK-11242 > URL: https://issues.apache.org/jira/browse/OAK-11242 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure >Affects Versions: 1.70.0 >Reporter: Axel Hanikel >Priority: Major > > This is a follow-up to OAK-11069: Apparently the refresher thread still dies > without a trace. I'm therefore assuming some java.lang.Error occurs, which is > hidden behind the executor. An approach could be to avoid the executor in > favour of creating the thread ourselves, and catching all Throwables to make > sure we handle them. We leave fatal errors such as OOME to pop up in other > parts of the code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11240) Build Jackrabbit/jackrabbit-oak-trunk-documentns #363 failed
[ https://issues.apache.org/jira/browse/OAK-11240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895670#comment-17895670 ] Hudson commented on OAK-11240: -- Previously failing build now is OK. Passed run: [Jackrabbit/jackrabbit-oak-trunk-documentns #371|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-documentns/371/] [console log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-documentns/371/console] > Build Jackrabbit/jackrabbit-oak-trunk-documentns #363 failed > > > Key: OAK-11240 > URL: https://issues.apache.org/jira/browse/OAK-11240 > Project: Jackrabbit Oak > Issue Type: Bug > Components: continuous integration >Reporter: Hudson >Priority: Major > > No description is provided > The build Jackrabbit/jackrabbit-oak-trunk-documentns #363 has failed. > First failed run: [Jackrabbit/jackrabbit-oak-trunk-documentns > #363|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-documentns/363/] > [console > log|https://ci-builds.apache.org/job/Jackrabbit/job/jackrabbit-oak-trunk-documentns/363/console] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11233) Don't apply MongoDockerRule if the Mongo Docker image isn't actually used.
[ https://issues.apache.org/jira/browse/OAK-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke updated OAK-11233: - Fix Version/s: 1.72.0 > Don't apply MongoDockerRule if the Mongo Docker image isn't actually used. > -- > > Key: OAK-11233 > URL: https://issues.apache.org/jira/browse/OAK-11233 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Fix For: 1.72.0 > > > There is no need to start a MongoDB Docker container if a preconfigured > connection to a running MongoDB server is used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11250) flaky RDBConnectionHandlerTest
[
https://issues.apache.org/jira/browse/OAK-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895671#comment-17895671
]
Julian Reschke commented on OAK-11250:
--
Any idea *which* fixture was failing?
> flaky RDBConnectionHandlerTest
> --
>
> Key: OAK-11250
> URL: https://issues.apache.org/jira/browse/OAK-11250
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: rdbmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: 1.72.0
>
>
> Have seen this test fail with different values, 60 something and below with
> 41 :
> {noformat}
> [INFO] Running
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.105
> s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest
> [ERROR]
> logging(org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest)
> Time elapsed: 0.104 s <<< FAILURE!
> java.lang.AssertionError: unexpected elapsed time between two fetches of
> connections: 41
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest.logging(RDBConnectionHandlerTest.java:48)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (OAK-11250) flaky RDBConnectionHandlerTest
[
https://issues.apache.org/jira/browse/OAK-11250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli resolved OAK-11250.
---
Fix Version/s: 1.72.0
Resolution: Fixed
PR https://github.com/apache/jackrabbit-oak/pull/1843 merged
> flaky RDBConnectionHandlerTest
> --
>
> Key: OAK-11250
> URL: https://issues.apache.org/jira/browse/OAK-11250
> Project: Jackrabbit Oak
> Issue Type: Test
> Components: rdbmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Minor
> Fix For: 1.72.0
>
>
> Have seen this test fail with different values, 60 something and below with
> 41 :
> {noformat}
> [INFO] Running
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.105
> s <<< FAILURE! - in
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest
> [ERROR]
> logging(org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest)
> Time elapsed: 0.104 s <<< FAILURE!
> java.lang.AssertionError: unexpected elapsed time between two fetches of
> connections: 41
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at
> org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest.logging(RDBConnectionHandlerTest.java:48)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OAK-11250) flaky RDBConnectionHandlerTest
Stefan Egli created OAK-11250:
-
Summary: flaky RDBConnectionHandlerTest
Key: OAK-11250
URL: https://issues.apache.org/jira/browse/OAK-11250
Project: Jackrabbit Oak
Issue Type: Test
Components: rdbmk
Reporter: Stefan Egli
Assignee: Stefan Egli
Have seen this test fail with different values, 60 something and below with 41 :
{noformat}
[INFO] Running
org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.105 s
<<< FAILURE! - in
org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest
[ERROR]
logging(org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest)
Time elapsed: 0.104 s <<< FAILURE!
java.lang.AssertionError: unexpected elapsed time between two fetches of
connections: 41
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.assertTrue(Assert.java:42)
at
org.apache.jackrabbit.oak.plugins.document.rdb.RDBConnectionHandlerTest.logging(RDBConnectionHandlerTest.java:48)
{noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (OAK-11226) Create Sets.newConcurrentHashSet api in oak-commons
[ https://issues.apache.org/jira/browse/OAK-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishabh Daim resolved OAK-11226. Fix Version/s: 1.72.0 Resolution: Fixed > Create Sets.newConcurrentHashSet api in oak-commons > --- > > Key: OAK-11226 > URL: https://issues.apache.org/jira/browse/OAK-11226 > Project: Jackrabbit Oak > Issue Type: Task > Components: commons >Reporter: Rishabh Daim >Assignee: Rishabh Daim >Priority: Major > Fix For: 1.72.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11233) Don't apply MongoDockerRule if the Mongo Docker image isn't actually used.
[ https://issues.apache.org/jira/browse/OAK-11233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manfred Baedke resolved OAK-11233. -- Resolution: Fixed > Don't apply MongoDockerRule if the Mongo Docker image isn't actually used. > -- > > Key: OAK-11233 > URL: https://issues.apache.org/jira/browse/OAK-11233 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > > There is no need to start a MongoDB Docker container if a preconfigured > connection to a running MongoDB server is used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11242) AzureRepositoryLock: Thread should not die silently on any kind of error
[ https://issues.apache.org/jira/browse/OAK-11242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895608#comment-17895608 ] Julian Reschke commented on OAK-11242: -- [~ahanikel] - I assume this can be set to "resolved"? > AzureRepositoryLock: Thread should not die silently on any kind of error > > > Key: OAK-11242 > URL: https://issues.apache.org/jira/browse/OAK-11242 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure >Affects Versions: 1.70.0 >Reporter: Axel Hanikel >Priority: Major > > This is a follow-up to OAK-11069: Apparently the refresher thread still dies > without a trace. I'm therefore assuming some java.lang.Error occurs, which is > hidden behind the executor. An approach could be to avoid the executor in > favour of creating the thread ourselves, and catching all Throwables to make > sure we handle them. We leave fatal errors such as OOME to pop up in other > parts of the code. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11235) Tree store path iterator filter: nextIncludedPath bugfix
[ https://issues.apache.org/jira/browse/OAK-11235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895606#comment-17895606 ] Julian Reschke commented on OAK-11235: -- [~thomasm] - I assume this can be set to "resolved"? > Tree store path iterator filter: nextIncludedPath bugfix > > > Key: OAK-11235 > URL: https://issues.apache.org/jira/browse/OAK-11235 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Fix For: 1.72.0 > > > The PathIteratorFilter in oak-run-commons (currently used only by the tree > store) returns the wrong "next path" in some cases: > * If the included path is not the root, e.g. /content > * If there is a node that is alphabetically larger than this, but smaller > than the children (/content/abc). For example, /content-test > For these cases, the nextIncludedPath of /content-test needs to return > /content/. Otherwise, the child nodes of /content are skipped. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11235) Tree store path iterator filter: nextIncludedPath bugfix
[ https://issues.apache.org/jira/browse/OAK-11235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-11235. -- Fix Version/s: 1.72.0 Resolution: Fixed > Tree store path iterator filter: nextIncludedPath bugfix > > > Key: OAK-11235 > URL: https://issues.apache.org/jira/browse/OAK-11235 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Fix For: 1.72.0 > > > The PathIteratorFilter in oak-run-commons (currently used only by the tree > store) returns the wrong "next path" in some cases: > * If the included path is not the root, e.g. /content > * If there is a node that is alphabetically larger than this, but smaller > than the children (/content/abc). For example, /content-test > For these cases, the nextIncludedPath of /content-test needs to return > /content/. Otherwise, the child nodes of /content are skipped. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-10957) oak-run datastorecheck broken for AWS since 1.22.14
[
https://issues.apache.org/jira/browse/OAK-10957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-10957:
-
Fix Version/s: (was: 1.22.22)
> oak-run datastorecheck broken for AWS since 1.22.14
> ---
>
> Key: OAK-10957
> URL: https://issues.apache.org/jira/browse/OAK-10957
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: oak-run
>Affects Versions: 1.22.14, 1.66.0
>Reporter: Wim Symons
>Assignee: Manfred Baedke
>Priority: Major
> Labels: candidate_oak_1_22
> Fix For: 1.72.0
>
> Attachments: oak-run-1.22.13.txt, oak-run-1.22.14.txt
>
>
> {{datastorecheck}} fails as of 1.22.14 (1.22.13 was last working version).
> Example command line:
> {code:java}
> java -jar oak-run-1.22.20.jar datastorecheck --consistency --store
> aem/crx-quickstart/repository/segmentstore --repoHome
> aem/crx-quickstart/repository --s3ds
> aem/crx-quickstart/install/crx3/org.apache.jackrabbit.oak.plugins.blob.datastore.SharedS3DataStore.config{code}
> Example output from 1.22.13:
> {code:java}
> Apache Jackrabbit Oak 1.22.13
> WARNING: An illegal reflective access operation has occurred
> WARNING: Illegal reflective access by
> org.codehaus.groovy.reflection.CachedClass
> (file:/data/apps/aem/tools/oak-run-1.22.13.jar) to method
> java.lang.Object.finalize()
> WARNING: Please consider reporting this to the maintainers of
> org.codehaus.groovy.reflection.CachedClass
> WARNING: Use --illegal-access=warn to enable warnings of further illegal
> reflective access operations
> WARNING: All illegal access operations will be denied in a future release
> Starting dump of blob ids
> 1259030 blob ids found
> Finished in 1753 seconds
> Starting dump of blob references
> 3163 blob references found
> Finished in 0 seconds
> Starting consistency check
> Consistency check found 0 missing blobs
> Finished in 0 seconds
> {code}
> As of version 1.22.14, this becomes:
> {code:java}
> Apache Jackrabbit Oak 1.22.14
> java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory
> at
> com.amazonaws.AmazonWebServiceClient.(AmazonWebServiceClient.java:80)
> at
> org.apache.jackrabbit.oak.blob.cloud.s3.Utils.openService(Utils.java:96)
> at
> org.apache.jackrabbit.oak.blob.cloud.s3.S3Backend.init(S3Backend.java:168)
> at
> org.apache.jackrabbit.oak.plugins.blob.AbstractSharedCachingDataStore.init(AbstractSharedCachingDataStore.java:161)
> at
> org.apache.jackrabbit.oak.run.Utils.bootstrapDataStore(Utils.java:270)
> at
> org.apache.jackrabbit.oak.run.DataStoreCheckCommand.checkDataStore(DataStoreCheckCommand.java:201)
> at
> org.apache.jackrabbit.oak.run.DataStoreCheckCommand.execute(DataStoreCheckCommand.java:110)
> at org.apache.jackrabbit.oak.run.Main.main(Main.java:49)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.commons.logging.LogFactory
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
> at
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
> ... 8 more
> {code}
> And that is the same up to version 1.66.0 (latest release):
> {code:java}
> Apache Jackrabbit Oak 1.66.0
> java.lang.NoClassDefFoundError: org/apache/commons/logging/LogFactory
> at
> com.amazonaws.AmazonWebServiceClient.(AmazonWebServiceClient.java:82)
> at
> org.apache.jackrabbit.oak.blob.cloud.s3.Utils.openService(Utils.java:96)
> at
> org.apache.jackrabbit.oak.blob.cloud.s3.S3Backend.init(S3Backend.java:170)
> at
> org.apache.jackrabbit.oak.plugins.blob.AbstractSharedCachingDataStore.init(AbstractSharedCachingDataStore.java:162)
> at
> org.apache.jackrabbit.oak.run.Utils.bootstrapDataStore(Utils.java:304)
> at
> org.apache.jackrabbit.oak.run.DataStoreCheckCommand.checkDataStore(DataStoreCheckCommand.java:211)
> at
> org.apache.jackrabbit.oak.run.DataStoreCheckCommand.execute(DataStoreCheckCommand.java:114)
> at org.apache.jackrabbit.oak.run.Main.main(Main.java:49)
> Caused by: java.lang.ClassNotFoundException:
> org.apache.commons.logging.LogFactory
> at
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
> at
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
> ... 8 more {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (OAK-10759) JavaDoc of o.a.j.o.namepath.PathMapper is inaccurate
[ https://issues.apache.org/jira/browse/OAK-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-10759. -- Fix Version/s: 1.72.0 Resolution: Fixed > JavaDoc of o.a.j.o.namepath.PathMapper is inaccurate > > > Key: OAK-10759 > URL: https://issues.apache.org/jira/browse/OAK-10759 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: core-spi >Reporter: Manfred Baedke >Assignee: Manfred Baedke >Priority: Minor > Fix For: 1.72.0 > > > The JavaDoc states "The Oak representation of a path consists of a forward > slash followed by ...", indicating that only absolute paths should be mapped, > which clearly is not the case. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11139) Allow downloading only recently changed nodes from MongoDB
[ https://issues.apache.org/jira/browse/OAK-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-11139. -- Fix Version/s: 1.72.0 Resolution: Fixed This can be set to "resolved", right? > Allow downloading only recently changed nodes from MongoDB > -- > > Key: OAK-11139 > URL: https://issues.apache.org/jira/browse/OAK-11139 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: indexing >Reporter: Thomas Mueller >Assignee: Thomas Mueller >Priority: Major > Fix For: 1.72.0 > > > Oak-run indexing allows to download all nodes from MongoDB to the tree store. > However, sometimes we only need the set of recently changed nodes, and not > all nodes. For example to update an existing index, or for backup purposes. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11243) oak-segment-azure tests have broken package names
[
https://issues.apache.org/jira/browse/OAK-11243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895580#comment-17895580
]
Julian Reschke commented on OAK-11243:
--
trunk:
[e0b0bd032f|https://github.com/apache/jackrabbit-oak/commit/e0b0bd032f964aece509eebc080f2ba2c2383497]
> oak-segment-azure tests have broken package names
> -
>
> Key: OAK-11243
> URL: https://issues.apache.org/jira/browse/OAK-11243
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-azure
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.72.0
>
>
> {noformat}
> ./pom.xml
> ./src
> ./src/main
> ./src/main/java
> ./src/main/java/org
> ./src/main/java/org/apache
> ./src/main/java/org/apache/jackrabbit
> ./src/main/java/org/apache/jackrabbit/oak
> ./src/main/java/org/apache/jackrabbit/oak/segment
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureBlobMetadata.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureGCJournalFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureManifestFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureRepositoryLock.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveReader.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveWriter.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentStoreService.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureStorageCredentialManager.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/Configuration.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/package-info.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/ReverseFileReader.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCheck.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCompact.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentCopy.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentStoreMigrator.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureConfigurationParserUtils.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureRequestOptions.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/CaseInsensitiveKeysMapAccess.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/Environment.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/Retrier.java
> ./src/test
> ./src/test/java
> ./src/test/java/oak
> ./src/test/java/oak/apache
> ./src/test/java/oak/apache/jackrabbit
> ./src/test/java/oak/apache/jackrabbit/oak
> ./src/test/java/oak/apache/jackrabbit/oak/segment
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureSasToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureServicePrincipalToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyTarToAzureTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyTestBase.java
> ./src/test/java/org
> ./src/test/java/org/apache
> ./src/test/java/org/apache/jackrabbit
> ./src/test/java/org/apache/jackrabbit/oak
> ./src/test/java/org/apache/jackrabbit/oak/segment
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManagerTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureBlobMetadataTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureGCJournalTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFileConcurrencyIT
[jira] [Updated] (OAK-11243) oak-segment-azure tests have broken package names
[
https://issues.apache.org/jira/browse/OAK-11243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-11243:
-
Summary: oak-segment-azure tests have broken package names (was:
oak-segment-azure tests have package names)
> oak-segment-azure tests have broken package names
> -
>
> Key: OAK-11243
> URL: https://issues.apache.org/jira/browse/OAK-11243
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-azure
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.72.0
>
>
> {noformat}
> ./pom.xml
> ./src
> ./src/main
> ./src/main/java
> ./src/main/java/org
> ./src/main/java/org/apache
> ./src/main/java/org/apache/jackrabbit
> ./src/main/java/org/apache/jackrabbit/oak
> ./src/main/java/org/apache/jackrabbit/oak/segment
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureBlobMetadata.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureGCJournalFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureManifestFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureRepositoryLock.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveReader.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveWriter.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentStoreService.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureStorageCredentialManager.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/Configuration.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/package-info.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/ReverseFileReader.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCheck.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCompact.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentCopy.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentStoreMigrator.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureConfigurationParserUtils.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureRequestOptions.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/CaseInsensitiveKeysMapAccess.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/Environment.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/Retrier.java
> ./src/test
> ./src/test/java
> ./src/test/java/oak
> ./src/test/java/oak/apache
> ./src/test/java/oak/apache/jackrabbit
> ./src/test/java/oak/apache/jackrabbit/oak
> ./src/test/java/oak/apache/jackrabbit/oak/segment
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureSasToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureServicePrincipalToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyTarToAzureTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyTestBase.java
> ./src/test/java/org
> ./src/test/java/org/apache
> ./src/test/java/org/apache/jackrabbit
> ./src/test/java/org/apache/jackrabbit/oak
> ./src/test/java/org/apache/jackrabbit/oak/segment
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManagerTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureBlobMetadataTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureGCJournalTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFileConcurrencyIT.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureJo
[jira] [Assigned] (OAK-11243) oak-segment-azure tests have package names
[
https://issues.apache.org/jira/browse/OAK-11243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke reassigned OAK-11243:
Assignee: Julian Reschke
> oak-segment-azure tests have package names
> --
>
> Key: OAK-11243
> URL: https://issues.apache.org/jira/browse/OAK-11243
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-azure
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Major
> Fix For: 1.72.0
>
>
> {noformat}
> ./pom.xml
> ./src
> ./src/main
> ./src/main/java
> ./src/main/java/org
> ./src/main/java/org/apache
> ./src/main/java/org/apache/jackrabbit
> ./src/main/java/org/apache/jackrabbit/oak
> ./src/main/java/org/apache/jackrabbit/oak/segment
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureBlobMetadata.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureGCJournalFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureManifestFile.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureRepositoryLock.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveReader.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveWriter.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentStoreService.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureStorageCredentialManager.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/Configuration.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/package-info.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/ReverseFileReader.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCheck.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCompact.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentCopy.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentStoreMigrator.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureConfigurationParserUtils.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureRequestOptions.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/CaseInsensitiveKeysMapAccess.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/Environment.java
> ./src/main/java/org/apache/jackrabbit/oak/segment/azure/util/Retrier.java
> ./src/test
> ./src/test/java
> ./src/test/java/oak
> ./src/test/java/oak/apache
> ./src/test/java/oak/apache/jackrabbit
> ./src/test/java/oak/apache/jackrabbit/oak
> ./src/test/java/oak/apache/jackrabbit/oak/segment
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureSasToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureServicePrincipalToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureToTarTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyTarToAzureTest.java
> ./src/test/java/oak/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyTestBase.java
> ./src/test/java/org
> ./src/test/java/org/apache
> ./src/test/java/org/apache/jackrabbit
> ./src/test/java/org/apache/jackrabbit/oak
> ./src/test/java/org/apache/jackrabbit/oak/segment
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManagerTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureBlobMetadataTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureGCJournalTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFileConcurrencyIT.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFileTest.java
> ./src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureManifestFi
[jira] [Updated] (OAK-11231) FullGC iterates same documents on certain cases
[ https://issues.apache.org/jira/browse/OAK-11231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Andrés Cordero Benítez updated OAK-11231: -- Labels: DetailedGC (was: ) > FullGC iterates same documents on certain cases > --- > > Key: OAK-11231 > URL: https://issues.apache.org/jira/browse/OAK-11231 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Reporter: José Andrés Cordero Benítez >Assignee: José Andrés Cordero Benítez >Priority: Major > Labels: DetailedGC > Fix For: 1.72.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11249) Lease refresh thread in AzureRepositoryLock should catch and log Throwable
Miroslav Smiljanic created OAK-11249: Summary: Lease refresh thread in AzureRepositoryLock should catch and log Throwable Key: OAK-11249 URL: https://issues.apache.org/jira/browse/OAK-11249 Project: Jackrabbit Oak Issue Type: Bug Reporter: Miroslav Smiljanic -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11249) Lease refresh thread in AzureRepositoryLock should catch and log Throwable
[ https://issues.apache.org/jira/browse/OAK-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miroslav Smiljanic resolved OAK-11249. -- Fix Version/s: 1.72.0 Resolution: Fixed > Lease refresh thread in AzureRepositoryLock should catch and log Throwable > --- > > Key: OAK-11249 > URL: https://issues.apache.org/jira/browse/OAK-11249 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure >Affects Versions: 1.70.0 >Reporter: Miroslav Smiljanic >Assignee: Miroslav Smiljanic >Priority: Major > Fix For: 1.72.0 > > > If the lease refresh thread in AzureRepositoryLock dies because of Throwable > which is not an Exception, it will not be logged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OAK-11249) Lease refresh thread in AzureRepositoryLock should catch and log Throwable
[ https://issues.apache.org/jira/browse/OAK-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miroslav Smiljanic reassigned OAK-11249: Assignee: Miroslav Smiljanic > Lease refresh thread in AzureRepositoryLock should catch and log Throwable > --- > > Key: OAK-11249 > URL: https://issues.apache.org/jira/browse/OAK-11249 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure >Affects Versions: 1.70.0 >Reporter: Miroslav Smiljanic >Assignee: Miroslav Smiljanic >Priority: Major > > If the lease refresh thread in AzureRepositoryLock dies because of Throwable > which is not an Exception, it will not be logged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11249) Lease refresh thread in AzureRepositoryLock should catch and log Throwable
[ https://issues.apache.org/jira/browse/OAK-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miroslav Smiljanic updated OAK-11249: - Description: If lease refresh thread in AzureRepositoryLock dies because of Throwable which is not an Exception, it will not be logged. > Lease refresh thread in AzureRepositoryLock should catch and log Throwable > --- > > Key: OAK-11249 > URL: https://issues.apache.org/jira/browse/OAK-11249 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure >Affects Versions: 1.70.0 >Reporter: Miroslav Smiljanic >Priority: Major > > If lease refresh thread in AzureRepositoryLock dies because of Throwable > which is not an Exception, it will not be logged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11249) Lease refresh thread in AzureRepositoryLock should catch and log Throwable
[ https://issues.apache.org/jira/browse/OAK-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miroslav Smiljanic updated OAK-11249: - Description: If the lease refresh thread in AzureRepositoryLock dies because of Throwable which is not an Exception, it will not be logged. (was: If lease refresh thread in AzureRepositoryLock dies because of Throwable which is not an Exception, it will not be logged. ) > Lease refresh thread in AzureRepositoryLock should catch and log Throwable > --- > > Key: OAK-11249 > URL: https://issues.apache.org/jira/browse/OAK-11249 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure >Affects Versions: 1.70.0 >Reporter: Miroslav Smiljanic >Priority: Major > > If the lease refresh thread in AzureRepositoryLock dies because of Throwable > which is not an Exception, it will not be logged. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11249) Lease refresh thread in AzureRepositoryLock should catch and log Throwable
[ https://issues.apache.org/jira/browse/OAK-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miroslav Smiljanic updated OAK-11249: - Component/s: segment-azure > Lease refresh thread in AzureRepositoryLock should catch and log Throwable > --- > > Key: OAK-11249 > URL: https://issues.apache.org/jira/browse/OAK-11249 > Project: Jackrabbit Oak > Issue Type: Bug > Components: segment-azure >Affects Versions: 1.70.0 >Reporter: Miroslav Smiljanic >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11249) Lease refresh thread in AzureRepositoryLock should catch and log Throwable
[ https://issues.apache.org/jira/browse/OAK-11249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Miroslav Smiljanic updated OAK-11249: - Affects Version/s: 1.70.0 > Lease refresh thread in AzureRepositoryLock should catch and log Throwable > --- > > Key: OAK-11249 > URL: https://issues.apache.org/jira/browse/OAK-11249 > Project: Jackrabbit Oak > Issue Type: Bug >Affects Versions: 1.70.0 >Reporter: Miroslav Smiljanic >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11248) Create util to close all feature toggles in DocumentNodeStore
Rishabh Daim created OAK-11248: -- Summary: Create util to close all feature toggles in DocumentNodeStore Key: OAK-11248 URL: https://issues.apache.org/jira/browse/OAK-11248 Project: Jackrabbit Oak Issue Type: Task Components: documentmk Reporter: Rishabh Daim Assignee: Rishabh Daim -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11231) FullGC iterates same documents on certain cases
[ https://issues.apache.org/jira/browse/OAK-11231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Andrés Cordero Benítez updated OAK-11231: -- Fix Version/s: 1.72.0 > FullGC iterates same documents on certain cases > --- > > Key: OAK-11231 > URL: https://issues.apache.org/jira/browse/OAK-11231 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Reporter: José Andrés Cordero Benítez >Assignee: José Andrés Cordero Benítez >Priority: Major > Fix For: 1.72.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11231) FullGC iterates same documents on certain cases
[ https://issues.apache.org/jira/browse/OAK-11231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Andrés Cordero Benítez resolved OAK-11231. --- Resolution: Fixed > FullGC iterates same documents on certain cases > --- > > Key: OAK-11231 > URL: https://issues.apache.org/jira/browse/OAK-11231 > Project: Jackrabbit Oak > Issue Type: Bug > Components: documentmk >Reporter: José Andrés Cordero Benítez >Assignee: José Andrés Cordero Benítez >Priority: Major > Fix For: 1.72.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11241) Document mechanism for registering MBeans
[ https://issues.apache.org/jira/browse/OAK-11241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-11241. -- Resolution: Fixed > Document mechanism for registering MBeans > -- > > Key: OAK-11241 > URL: https://issues.apache.org/jira/browse/OAK-11241 > Project: Jackrabbit Oak > Issue Type: Documentation > Components: docs >Affects Versions: 1.70.0 >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Minor > Fix For: 1.72.0 > > > It is not immediately obvious how the Whiteboard Mean registration works. We > should add a link to the Aries JMX whiteboard documentation. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OAK-11225) remove unused Guava related imports (ongoing)
[
https://issues.apache.org/jira/browse/OAK-11225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Reschke updated OAK-11225:
-
Description:
To check, run
{noformat}
mvn checkstyle:check -Dcheckstyle.maxAllowedViolations=100 | fgrep Unused |
fgrep guava
{noformat}
> remove unused Guava related imports (ongoing)
> -
>
> Key: OAK-11225
> URL: https://issues.apache.org/jira/browse/OAK-11225
> Project: Jackrabbit Oak
> Issue Type: Technical task
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>Priority: Trivial
>
> To check, run
> {noformat}
> mvn checkstyle:check -Dcheckstyle.maxAllowedViolations=100 | fgrep Unused
> | fgrep guava
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (OAK-10685) reduce overall usage of (shaded) Guava
[
https://issues.apache.org/jira/browse/OAK-10685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17889596#comment-17889596
]
Julian Reschke edited comment on OAK-10685 at 11/4/24 3:39 PM:
---
{code}
1 import org.apache.jackrabbit.guava.common.collect.ImmutableListMultimap;
1 import org.apache.jackrabbit.guava.common.escape.Escapers;
1 import org.apache.jackrabbit.guava.common.graph.SuccessorsFunction;
1 import org.apache.jackrabbit.guava.common.graph.Traverser;
1 import org.apache.jackrabbit.guava.common.hash.Funnel;
1 import org.apache.jackrabbit.guava.common.hash.Funnels;
1 import org.apache.jackrabbit.guava.common.hash.HashCode;
1 import org.apache.jackrabbit.guava.common.hash.PrimitiveSink;
1 import org.apache.jackrabbit.guava.common.primitives.Chars;
1 import org.apache.jackrabbit.guava.common.primitives.UnsignedBytes;
1 import
org.apache.jackrabbit.guava.common.util.concurrent.AbstractListeningExecutorService;
1 import
org.apache.jackrabbit.guava.common.util.concurrent.FutureCallback;
1 import org.apache.jackrabbit.guava.common.util.concurrent.Monitor.Guard;
1 import static
org.apache.jackrabbit.guava.common.base.Preconditions.checkPositionIndex;
1 import static
org.apache.jackrabbit.guava.common.base.Throwables.getStackTraceAsString;
1 import static
org.apache.jackrabbit.guava.common.cache.CacheBuilder.newBuilder;
1 import static
org.apache.jackrabbit.guava.common.cache.RemovalCause.COLLECTED;
1 import static
org.apache.jackrabbit.guava.common.cache.RemovalCause.EXPIRED;
1 import static
org.apache.jackrabbit.guava.common.cache.RemovalCause.SIZE;
1 import static
org.apache.jackrabbit.guava.common.collect.Collections2.transform;
1 import static
org.apache.jackrabbit.guava.common.collect.ImmutableMap.copyOf;
1 import static org.apache.jackrabbit.guava.common.collect.Iterables.all;
1 import static
org.apache.jackrabbit.guava.common.collect.Iterables.cycle;
1 import static
org.apache.jackrabbit.guava.common.collect.Iterables.elementsEqual;
1 import static
org.apache.jackrabbit.guava.common.collect.Iterables.limit;
1 import static
org.apache.jackrabbit.guava.common.collect.Iterables.mergeSorted;
1 import static
org.apache.jackrabbit.guava.common.collect.Iterators.partition;
1 import static
org.apache.jackrabbit.guava.common.collect.Iterators.peekingIterator;
1 import static org.apache.jackrabbit.guava.common.collect.Iterators.size;
1 import static org.apache.jackrabbit.guava.common.collect.Sets.filter;
1 import static
org.apache.jackrabbit.guava.common.collect.Sets.intersection;
1 import static
org.apache.jackrabbit.guava.common.escape.Escapers.builder;
1 import static org.apache.jackrabbit.guava.common.io.ByteStreams.read;
1 import static
org.apache.jackrabbit.guava.common.io.FileWriteMode.APPEND;
1 import static org.apache.jackrabbit.guava.common.io.Files.asByteSink;
1 import static
org.apache.jackrabbit.guava.common.math.DoubleMath.fuzzyCompare;
1 import static
org.apache.jackrabbit.guava.common.math.DoubleMath.fuzzyEquals;
2 import org.apache.jackrabbit.guava.common.base.CaseFormat;
2 import org.apache.jackrabbit.guava.common.base.Throwables;
2 import org.apache.jackrabbit.guava.common.cache.AbstractCache;
2 import org.apache.jackrabbit.guava.common.collect.HashMultimap;
2 import org.apache.jackrabbit.guava.common.collect.LinkedListMultimap;
2 import org.apache.jackrabbit.guava.common.hash.BloomFilter;
2 import org.apache.jackrabbit.guava.common.hash.Hasher;
2 import org.apache.jackrabbit.guava.common.io.BaseEncoding;
2 import org.apache.jackrabbit.guava.common.util.concurrent.Futures;
2 import
org.apache.jackrabbit.guava.common.util.concurrent.ListenableFutureTask;
2 import org.apache.jackrabbit.guava.common.util.concurrent.Striped;
2 import static
org.apache.jackrabbit.guava.common.base.Stopwatch.createStarted;
2 import static
org.apache.jackrabbit.guava.common.base.Suppliers.ofInstance;
2 import static
org.apache.jackrabbit.guava.common.collect.Iterables.isEmpty;
2 import static
org.apache.jackrabbit.guava.common.collect.Iterators.concat;
2 import static
org.apache.jackrabbit.guava.common.collect.Iterators.singletonIterator;
2 import static org.apache.jackrabbit.guava.common.collect.Lists.reverse;
2 import static
org.apache.jackrabbit.guava.common.collect.Maps.filterValues;
2 import static
org.apache.jackrabbit.guava.common.collect.Maps.immutableEntry;
2 import static
org.apache.jackrabbit.guava.common.collect.Sets.difference;
2 import static
org.apache.jackrabbit.guava.common.collect.Sets.newConcurrentHas
[jira] [Commented] (OAK-11023) Remove usage of Guava newArrayList
[ https://issues.apache.org/jira/browse/OAK-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895336#comment-17895336 ] Julian Reschke commented on OAK-11023: -- trunk: [89e0b814fc|https://github.com/apache/jackrabbit-oak/commit/89e0b814fc1d9490eaf95406e5ba3f44100b7a24] > Remove usage of Guava newArrayList > -- > > Key: OAK-11023 > URL: https://issues.apache.org/jira/browse/OAK-11023 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Rishabh Daim >Assignee: Julian Reschke >Priority: Major > Fix For: 1.72.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (OAK-11023) Remove usage of Guava newArrayList
[ https://issues.apache.org/jira/browse/OAK-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke resolved OAK-11023. -- Fix Version/s: 1.72.0 Resolution: Fixed > Remove usage of Guava newArrayList > -- > > Key: OAK-11023 > URL: https://issues.apache.org/jira/browse/OAK-11023 > Project: Jackrabbit Oak > Issue Type: Technical task >Reporter: Rishabh Daim >Assignee: Julian Reschke >Priority: Major > Fix For: 1.72.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OAK-11247) Migrate oak-pojosr groovy files to Java
Alejandro Moratinos created OAK-11247: - Summary: Migrate oak-pojosr groovy files to Java Key: OAK-11247 URL: https://issues.apache.org/jira/browse/OAK-11247 Project: Jackrabbit Oak Issue Type: Sub-task Components: pojosr Reporter: Alejandro Moratinos -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OAK-11244) Migrate Groovy code to Java
[ https://issues.apache.org/jira/browse/OAK-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Reschke reassigned OAK-11244: Assignee: Alejandro Moratinos > Migrate Groovy code to Java > --- > > Key: OAK-11244 > URL: https://issues.apache.org/jira/browse/OAK-11244 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Julian Reschke >Assignee: Alejandro Moratinos >Priority: Major > > We have a fest classes written in Groovy. > This poses problems when > - people not fluent in Groovy need to make changes or debug the code > - updating Java versions > There are only a few, we should just convert them to proper Java code. > [~stefanegli] [~mreutegg] [~angela] wdyt? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11244) Migrate Groovy code to Java
[ https://issues.apache.org/jira/browse/OAK-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895301#comment-17895301 ] Alejandro Moratinos commented on OAK-11244: --- I've checked the groovy files in the oak-run package and looks like those are related to the groovy console created when the _oak-run_ package is executed. To me those shouldn't be migrated. I'll be creating subtasks to migrate the files by packages if that sounds reasonable. > Migrate Groovy code to Java > --- > > Key: OAK-11244 > URL: https://issues.apache.org/jira/browse/OAK-11244 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Julian Reschke >Priority: Major > > We have a fest classes written in Groovy. > This poses problems when > - people not fluent in Groovy need to make changes or debug the code > - updating Java versions > There are only a few, we should just convert them to proper Java code. > [~stefanegli] [~mreutegg] [~angela] wdyt? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11244) Migrate Groovy code to Java
[ https://issues.apache.org/jira/browse/OAK-11244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895272#comment-17895272 ] Julian Reschke commented on OAK-11244: -- One issue is that some of these (in oak-run) might not have test coverage... > Migrate Groovy code to Java > --- > > Key: OAK-11244 > URL: https://issues.apache.org/jira/browse/OAK-11244 > Project: Jackrabbit Oak > Issue Type: Task >Reporter: Julian Reschke >Priority: Major > > We have a fest classes written in Groovy. > This poses problems when > - people not fluent in Groovy need to make changes or debug the code > - updating Java versions > There are only a few, we should just convert them to proper Java code. > [~stefanegli] [~mreutegg] [~angela] wdyt? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-11184) Resolving a node with an unmerged or not-yet-visible revision as the only revision results in previous document scan (which can be expensive on root)
[
https://issues.apache.org/jira/browse/OAK-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17895267#comment-17895267
]
Stefan Egli commented on OAK-11184:
---
Added feature toggle and marked
[PR|https://github.com/apache/jackrabbit-oak/pull/1779] as ready for review
> Resolving a node with an unmerged or not-yet-visible revision as the only
> revision results in previous document scan (which can be expensive on root)
> -
>
> Key: OAK-11184
> URL: https://issues.apache.org/jira/browse/OAK-11184
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> Consider a scenario with 2 cluster nodes (running DocumentNodeStore):
> * cluster node A with cluster node id 1
> * cluster node B with cluster node id 2
> Now cluster node A is doing a merge that includes changes (eg a property) on
> root. Such a merge includes two updates towards DocumentStore (followed by
> background stuff) :
> * the first update has the actual changes on the properties (that would
> include any other document other than root - but that's not so relevant
> here). Say that happens with revision {{"rn-0-1"}}
> * the second update is marking the revision as committed - which is done by
> adding an entry to "_revisions" with {{"rn-0-1" : "c"}}
> * after the merge, the usual backgroundWrite(on A)/backgroundRead(on B) will
> follow.
> At some point cluster node B reads the root node and does a
> getNodeAtRevision. The behavior slightly differs between the two cases:
> * after step 1 it will read {{"rn-0-1"}} in an unmerged state (it has no
> commit value yet)
> * after step 2 it will read the revision in a not yet visible state
> Either way this revision value resolves to null. As a result of which it
> greedily reads through previous documents to *find a split-away property
> value* only to find nothing. If there are many previous documents, which is
> likely on root, this is a significant performance hit.
> This situation persists until a full backgroundWrite/Read are done, so until
> step 3 above is done.
> Now backgroundRead requires the exclusive lock on the backgroundOperationLock
> as part of updating a fresh main root. If B happens to have that exclusive
> lock occupied by anyone else, it has to wait.
> As part of a regular merge though, the "read/non-exclusive" lock of
> backgroundOperationLock is acquired.
> If there are a number of threads "ahead" of backgroundRead all acquiring the
> read-lock of backgroundOperationLock, the backgroundRead will have to wait
> until all commits are done.
> So if B is in such a situation, with all merge operations when updating root
> going through previous documents, it can result in an overall significant
> delay.
> (This issue can also happen on any other node - but it is only a problem if
> there are many previous documents. And root usually does have many, hence the
> problem is primarily on root)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OAK-11184) Resolving a node with an unmerged or not-yet-visible revision as the only revision results in previous document scan (which can be expensive on root)
[
https://issues.apache.org/jira/browse/OAK-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli reassigned OAK-11184:
-
Assignee: Stefan Egli
> Resolving a node with an unmerged or not-yet-visible revision as the only
> revision results in previous document scan (which can be expensive on root)
> -
>
> Key: OAK-11184
> URL: https://issues.apache.org/jira/browse/OAK-11184
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> Consider a scenario with 2 cluster nodes (running DocumentNodeStore):
> * cluster node A with cluster node id 1
> * cluster node B with cluster node id 2
> Now cluster node A is doing a merge that includes changes (eg a property) on
> root. Such a merge includes two updates towards DocumentStore (followed by
> background stuff) :
> * the first update has the actual changes on the properties (that would
> include any other document other than root - but that's not so relevant
> here). Say that happens with revision {{"rn-0-1"}}
> * the second update is marking the revision as committed - which is done by
> adding an entry to "_revisions" with {{"rn-0-1" : "c"}}
> * after the merge, the usual backgroundWrite(on A)/backgroundRead(on B) will
> follow.
> At some point cluster node B reads the root node and does a
> getNodeAtRevision. The behavior slightly differs between the two cases:
> * after step 1 it will read {{"rn-0-1"}} in an unmerged state (it has no
> commit value yet)
> * after step 2 it will read the revision in a not yet visible state
> Either way this revision value resolves to null. As a result of which it
> greedily reads through previous documents to *find a split-away property
> value* only to find nothing. If there are many previous documents, which is
> likely on root, this is a significant performance hit.
> This situation persists until a full backgroundWrite/Read are done, so until
> step 3 above is done.
> Now backgroundRead requires the exclusive lock on the backgroundOperationLock
> as part of updating a fresh main root. If B happens to have that exclusive
> lock occupied by anyone else, it has to wait.
> As part of a regular merge though, the "read/non-exclusive" lock of
> backgroundOperationLock is acquired.
> If there are a number of threads "ahead" of backgroundRead all acquiring the
> read-lock of backgroundOperationLock, the backgroundRead will have to wait
> until all commits are done.
> So if B is in such a situation, with all merge operations when updating root
> going through previous documents, it can result in an overall significant
> delay.
> (This issue can also happen on any other node - but it is only a problem if
> there are many previous documents. And root usually does have many, hence the
> problem is primarily on root)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OAK-11246) Introduce config for perflogger to log very slow operations at info
Ionut Pirlogea created OAK-11246:
Summary: Introduce config for perflogger to log very slow
operations at info
Key: OAK-11246
URL: https://issues.apache.org/jira/browse/OAK-11246
Project: Jackrabbit Oak
Issue Type: Task
Components: mongomk
Reporter: Ionut Pirlogea
In oak we have a
[PerfLogger|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/PerfLogger.java#L48]
which can be used to log slow operations. It is used in a variety of places,
most prominent:
* DocumentNodeStore
* MongoDocumentStore
* EventGenerator
* DocumentNodeStoreBranch
* AbstractDocumentNodeState
* NodeObserver
* and in several places in indexing code
* as well as in RDB case
Currently we use only the DEBUG thresholds, we're not using the INFO
thresholds. That means, we only would see logs when the level is at DEBUG, we
see nothing by default at INFO.
We could however consider logging very slow operations at INFO by default. Much
like mongo logs requests slower than 100ms always, by default.
In AEM's case we might have many slow operations though, so choosing a low
threshold would potentially flood the log and cause troubles that way.
Additionally, there isn't a (global) config that can be tweaked to set this
threshold. So far it is all hard-coded - and the threshold is actually
Long.MAX_VALUE (so essentially never).
Suggesting hereby to introduce such a config - perhaps it doens't have to be
global, it could be for example covering a few classes. But having such a
config, then having that tweakable via skyline-ops, could be a useful feature.
We could then set for example a threshold of 60 seconds and monitor the amount
of logs generated by that throughout Skyline. If the number is low enough, we
can go lower to eg 30 sec or ideally eventually 10 sec. Always given we are not
flooding splunk that way. But the prerequisite for something like that is. a
skyline-ops configurable perflogger threshold (and wire that to the
corresponding {{Perflogger.end()}} methods at places we want it to be.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (OAK-11232) indexing-job - Simplify download from Mongo logic by traversing only by _modified instead of (_modified, _id)
[ https://issues.apache.org/jira/browse/OAK-11232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nuno Santos resolved OAK-11232. --- Fix Version/s: 1.72.0 Resolution: Done > indexing-job - Simplify download from Mongo logic by traversing only by > _modified instead of (_modified, _id) > - > > Key: OAK-11232 > URL: https://issues.apache.org/jira/browse/OAK-11232 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: indexing >Reporter: Nuno Santos >Priority: Major > Fix For: 1.72.0 > > > The downloader from Mongo in the indexing job traverses the repository by > order of the fields (_modified, _id). In case of disconnection from Mongo, > this allows resuming the download from where it was interrupted without > redownloading any document. > However, we can relax the requirement of not downloading duplicate documents, > because the merge-sort stage of the pipelined strategy discards duplicates. > Therefore, avoiding downloading duplicates is only a performance > optimization, which applies only in the case of disconnections from Mongo, so > only in the relatively rare case of failure. > We could alternatively download only ordering by _modified. This greatly > simplifies the logic of the downloader, as it does not need to track two > fields, and provides a slight performance boost for the normal case, as the > download thread no longer needs to decode the _id field from the binary > buffer representing the document, it only needs the _modified field. > In case of failure, we would have to download all documents with the last > seen _modified value, which would likely include some duplicate documents. > But this would likely take just a few seconds. Consider that _modified has a > resolution of 5 seconds, so the number of documents with the same _modified > value is limited by how much Oak can write to Mongo in a 5 minutes window. > The downloader is streaming the results directly using a Mongo query, > therefore it downloads much faster than what Oak can write. So likely, the > downloader will take much less than 5 seconds to download all the documents > with the same _modified value, which is an acceptable overhead in the rare > case of disconnection from Mongo. -- This message was sent by Atlassian Jira (v8.20.10#820010)
