[jira] [Comment Edited] (OAK-5876) SplitDocumentCleanup should implement Closeable

2017-03-07 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899415#comment-15899415
 ] 

Julian Reschke edited comment on OAK-5876 at 3/7/17 3:44 PM:
-

trunk: [r1785283|http://svn.apache.org/r1785283]
1.6: [r1785837|http://svn.apache.org/r1785837]
1.4: [r1785840|http://svn.apache.org/r1785840]
1.2: [r1785842|http://svn.apache.org/r1785842]
1.0: [r1785848|http://svn.apache.org/r1785848]





was (Author: reschke):
trunk: [r1785283|http://svn.apache.org/r1785283]
1.6: [r1785837|http://svn.apache.org/r1785837]
1.4: [r1785840|http://svn.apache.org/r1785840]
1.2: [r1785842|http://svn.apache.org/r1785842]




> SplitDocumentCleanup should implement Closeable
> ---
>
> Key: OAK-5876
> URL: https://issues.apache.org/jira/browse/OAK-5876
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
> Fix For: 1.4.15, 1.7.0, 1.8, 1.0.38, 1.6.2, 1.2.25
>
> Attachments: OAK-5876.diff
>
>
> {{SplitDocumentCleanup}} currently does not close the {{Iterable}} holding 
> {{splitDocGarbage}}. It should implement {{Closeable}} and forward calls to 
> {{close()}} to the {{Iterable}}, if that happens to be {{Closeable}}.
> Likewise, {{VersionGCSupport}} should call {{close()}} on 
> {{SplitDocumentCleanup}} when done.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Comment Edited] (OAK-5876) SplitDocumentCleanup should implement Closeable

2017-03-07 Thread Julian Reschke (JIRA) 

[ 
https://issues.apache.org/jira/browse/OAK-5876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899415#comment-15899415
 ] 

Julian Reschke edited comment on OAK-5876 at 3/7/17 1:59 PM:
-

trunk: [r1785283|http://svn.apache.org/r1785283]
1.6: [r1785837|http://svn.apache.org/r1785837]
1.4: [r1785840|http://svn.apache.org/r1785840]



was (Author: reschke):
trunk: [r1785283|http://svn.apache.org/r1785283]
1.6: [r1785837|http://svn.apache.org/r1785837]


> SplitDocumentCleanup should implement Closeable
> ---
>
> Key: OAK-5876
> URL: https://issues.apache.org/jira/browse/OAK-5876
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: Julian Reschke
>Assignee: Julian Reschke
>  Labels: candidate_oak_1_0, candidate_oak_1_2
> Fix For: 1.4.15, 1.7.0, 1.8, 1.6.2
>
> Attachments: OAK-5876.diff
>
>
> {{SplitDocumentCleanup}} currently does not close the {{Iterable}} holding 
> {{splitDocGarbage}}. It should implement {{Closeable}} and forward calls to 
> {{close()}} to the {{Iterable}}, if that happens to be {{Closeable}}.
> Likewise, {{VersionGCSupport}} should call {{close()}} on 
> {{SplitDocumentCleanup}} when done.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)