[jira] [Comment Edited] (OAK-6265) Remove Mounts.defaultMount methods
[
https://issues.apache.org/jira/browse/OAK-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024663#comment-16024663
]
Robert Munteanu edited comment on OAK-6265 at 5/25/17 12:32 PM:
Yes, that's where I'm right now. Not sure if to remove or deprecate. I slightly
tend towards removing, and if no one complains I'll do that.
And you're right, I converted this to a task.
was (Author: rombert):
Yes, that's where I'm right now. Not sure if to remove or deprecate. I slightly
tend towards removing, and if no one complains I'll do that.
> Remove Mounts.defaultMount methods
> --
>
> Key: OAK-6265
> URL: https://issues.apache.org/jira/browse/OAK-6265
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: composite
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.7.1
>
> Attachments: 0001-OAK-6265-Remove-Mounts.defaultMount-methods.patch,
> 0002-OAK-6265-Remove-Mounts.defaultMount-methods.patch
>
>
> These methods break the abstraction of constructing a composite setup
> and should not be used. Since the exported package version of
> {{org.apache.jackrabbit.oak.spi.mount}} is set to 3.0.0 for 1.8-SNAPSHOT and
> it was 2.2.0 in 1.6.1 it's safe to remove these methods if we do it before a
> release from the 1.8 stream is cut.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Comment Edited] (OAK-6265) Remove Mounts.defaultMount methods
[
https://issues.apache.org/jira/browse/OAK-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024661#comment-16024661
]
Chetan Mehrotra edited comment on OAK-6265 at 5/25/17 12:31 PM:
Makes sense. Removing them would be right but then that leads to major version
increase. In most cases people would only using MountInfoProvider and not using
these utility methods.
So to avoid increasing the major version we can
# Deprecate them
# Throw UnsupportedOperationException
Or we can probably go ahead and remove this. MountInfoProvider feature was
present in 1.6 release but experimental so it should not be in use (some of Oak
features still does not support it). So I do not expect any actual user of this
api outside of Oak. Hence fine to remove it
BTW I would term this as an improvement or task and not consider this as bug!
was (Author: chetanm):
Makes sense. Removing them would be right but then that leads to major version
increase. In most cases people would only using MountInfoProvider and not using
these utility methods.
So to avoid increasing the major version we can
# Deprecate them
# Throw UnsupportedOperationException
Or we can probably go ahead and remove this. MountInfoProvider feature was
present in 1.6 release but experimental so it should not be in use (some of Oak
features still does not support it). So I do not expect any actual user of this
api outside of Oak. Hence fine to remove it
> Remove Mounts.defaultMount methods
> --
>
> Key: OAK-6265
> URL: https://issues.apache.org/jira/browse/OAK-6265
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: composite
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: 1.7.1
>
> Attachments: 0001-OAK-6265-Remove-Mounts.defaultMount-methods.patch,
> 0002-OAK-6265-Remove-Mounts.defaultMount-methods.patch
>
>
> These methods break the abstraction of constructing a composite setup
> and should not be used. Since the exported package version of
> {{org.apache.jackrabbit.oak.spi.mount}} is set to 3.0.0 for 1.8-SNAPSHOT and
> it was 2.2.0 in 1.6.1 it's safe to remove these methods if we do it before a
> release from the 1.8 stream is cut.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
