[jira] [Comment Edited] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784916#comment-17784916 ] Manfred Baedke edited comment on OAK-6741 at 11/10/23 12:29 PM: [~reschke] , all the changes already done work with R7 as well. If you have an idea how to deal with hyphens in R6, please share. was (Author: baedke): [~reschke] , all the changes already done work with R7 as well. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17784909#comment-17784909 ] Manfred Baedke edited comment on OAK-6741 at 11/10/23 12:24 PM: All the sub task titles suggest that we are switching to R6 annotations. I guess that is not deliberate, is it? R7 annotations would make it possible to use hyphens in the names of attribute definitions and e.g. oak-jcr actually uses hyphens there. was (Author: baedke): All the sub tasks titles suggest we are switching to R6 annotations. I guess that is not deliberate, is it? R7 annotations would make it possible to use hyphens in the names of attribute definitions and e.g. oak-jcr actually uses hyphens there. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OAK-6741) Switch to official OSGi component and metatype annotations
[ https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774877#comment-17774877 ] Julian Reschke edited comment on OAK-6741 at 10/13/23 11:14 AM: Potentially helpful comparison tool: https://github.com/jsedding/osgi-ds-metatype-diff was (Author: reschke): Potentially helpful comparison tool. > Switch to official OSGi component and metatype annotations > -- > > Key: OAK-6741 > URL: https://issues.apache.org/jira/browse/OAK-6741 > Project: Jackrabbit Oak > Issue Type: Improvement >Reporter: Robert Munteanu >Priority: Major > Attachments: OAK-6741-proposed-changes-chetans-feedback.patch, > osgi-metadata-1.7.8.json, osgi-metadata-trunk.json > > > We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi > R6 annotations. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194264#comment-16194264
]
Julian Sedding edited comment on OAK-6741 at 10/6/17 8:00 AM:
--
bq. Julian Sedding you might want to check your facts before pointing the
finger. we already have a test for this [0]. why this test is not failing with
the changed annotation, is a different question (it's probably the test
framework that does not respect the wiring, but I'm no OSGi expert).
_edit_: removed less constructive comment, replaced with hopefully more
constructive one
The test uses Sling's osgi-mocks via {{OsgiContext}}. This is (currently) not
backed by a true OSGi implementation and re-implements certain features like
Declarative Services and MetaType. Sometimes this can lead to problems, which
usually manifest in lacking features. However, in this case, I think that the
test should have been adjusted to bind multiple {{CredentialsSupport}} services
when OAK-6753 was done.
was (Author: jsedding):
bq. Julian Sedding you might want to check your facts before pointing the
finger. we already have a test for this [0]. why this test is not failing with
the changed annotation, is a different question (it's probably the test
framework that does not respect the wiring, but I'm no OSGi expert).
With all due respect [~stillalex], I think your quoting me out of context. As
for the facts, you say yourself that the test does not fail. So we don't have a
test that covers the scenario imlemented in OAK-6753. This is evident by the
fact that the test was not adjusted when OAK-6753 was implemented.
Anyway, we're splitting hairs. If you would like me to revert the patch, please
tell me so.
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
> Attachments: osgi-metadata-1.7.8.json, osgi-metadata-trunk.json
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193478#comment-16193478
]
Chetan Mehrotra edited comment on OAK-6741 at 10/5/17 7:19 PM:
---
I tried to implement a hacky script [1] to generate report for the DS and
Metatype xml as json.
The script can be used like below (requires Groovy installed)
{noformat}
groovy
https://gist.githubusercontent.com/chetanmeh/3cf69a690e67f9ceb9c1abcbfadc495b/raw/analyzeOsgiMetadata.groovy
/path/to/jackrabbit-oak
{noformat}
The script would search for all jar files and would then extract the metatype
and ds xml and convert them into sorted json. This json can then be compared
with a diff tool. The script does some adaptation so noise level is very less
now
See attached [trunk json|^osgi-metadata-trunk.json] and [Oak 1.7.8 tag
json|^osgi-metadata-1.7.8.json]
Diff show some false positive so need to be checked once manually. For now it
reports following issues (listing some)
* No 'Designate' found in
OSGI-INF/metatype/org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl$Configuration.xml
- Looks like AuthorizationConfigurationImpl does not have designate specified
* COWNodeStoreService is having the "role" property missing. Which is required
* DocumentNodeStoreService - Missing props
** updateLimit
** repository.home
** role
* SecondaryStoreCacheService - immediate missing
* MountInfoProviderService - supportFragment missing (may be it was changed so
valid)
* AuthenticationConfigurationImpl
** org.apache.jackrabbit.oak.authentication.appName missing
** org.apache.jackrabbit.oak.authentication.configSpiName missing
* DefaultAuthorizableActionProvider - label and value swapped
There are few I may have missed from quick look at diff. So have a look again.
Hope this would be useful in this migration effort
[1] https://gist.github.com/chetanmeh/3cf69a690e67f9ceb9c1abcbfadc495b
was (Author: chetanm):
I tried to implement a hacky script [1] to generate report for the DS and
Metatype xml as json.
The script can be used like below (requires Groovy installed)
{noformat}
groovy
https://gist.githubusercontent.com/chetanmeh/3cf69a690e67f9ceb9c1abcbfadc495b/raw/analyzeOsgiMetadata.groovy
/path/to/jackrabbit-oak
{noformat}
The script would search for all jar files and would then extract the metatype
and ds xml and convert them into sorted json. This json can then be compared
with a diff tool
See attached [trunk json|^osgi-metadata-trunk.json] and [Oak 1.7.8 tag
json|^osgi-metadata-1.7.8.json]
Diff show some false positive so need to be checked once manually. For now it
reports following issues (listing some)
* No 'Designate' found in
OSGI-INF/metatype/org.apache.jackrabbit.oak.security.authorization.AuthorizationConfigurationImpl$Configuration.xml
- Looks like AuthorizationConfigurationImpl does not have designate specified
* COWNodeStoreService is having the "role" property missing. Which is required
* DocumentNodeStoreService - Missing props
** updateLimit
** repository.home
** role
* SecondaryStoreCacheService - immediate missing
* MountInfoProviderService - supportFragment missing (may be it was changed so
valid)
* AuthenticationConfigurationImpl
** org.apache.jackrabbit.oak.authentication.appName missing
** org.apache.jackrabbit.oak.authentication.configSpiName missing
* DefaultAuthorizableActionProvider - label and value swapped
There are few I may have missed from quick look at diff. So have a look again.
Hope this would be useful in this migration effort
[1] https://gist.github.com/chetanmeh/3cf69a690e67f9ceb9c1abcbfadc495b
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
> Attachments: osgi-metadata-1.7.8.json, osgi-metadata-trunk.json
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184224#comment-16184224
]
Julian Sedding edited comment on OAK-6741 at 9/28/17 2:12 PM:
--
Fixed for {{oak-core}} and {{oak-store-document}} in
[r1810002|https://svn.apache.org/r1810002].
Thanks for your help [~rombert]!
was (Author: jsedding):
Fixed for {{oak-core}} and {{oak-store-document}} in
[r1810002|https://svn.apache.org/r1810002].
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (OAK-6741) Switch to official OSGi component and metatype annotations
[
https://issues.apache.org/jira/browse/OAK-6741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184224#comment-16184224
]
Julian Sedding edited comment on OAK-6741 at 9/28/17 2:11 PM:
--
Fixed for {{oak-core}} and {{oak-store-document}} in
[r1810002|https://svn.apache.org/r1810002].
was (Author: jsedding):
Fixed for {{oak-core}} and {{oak-store-document}} in
[rr1810002|https://svn.apache.org/r1810002].
> Switch to official OSGi component and metatype annotations
> --
>
> Key: OAK-6741
> URL: https://issues.apache.org/jira/browse/OAK-6741
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Reporter: Robert Munteanu
> Fix For: 1.8, 1.7.9
>
>
> We should remove the 'old' Felix SCR annotations and move to the 'new' OSGi
> R6 annotations.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
