[jira] [Commented] (OAK-10137) Static variable referenced from a non-static context

2023-03-09 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698698#comment-17698698
 ] 

Nitin Gupta commented on OAK-10137:
---

trunk: 
https://github.com/apache/jackrabbit-oak/commit/431c8dcaa380e18c1ae678212f1757d233f4639a
 

> Static variable referenced from a non-static context
> 
>
> Key: OAK-10137
> URL: https://issues.apache.org/jira/browse/OAK-10137
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
>
> https://github.com/apache/jackrabbit-oak/blame/trunk/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java#L188
> waitForESAcknowledgement is a static variable which is accessed from a 
> non-static context. It is set to true only at initialization, in a static 
> context. So if at some point it is set to false, it will never again become 
> true during the runtime of the JVM. And the BuikProcessor instance is not 
> static, so there may be many instances created in the same JVM execution



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10137) Static variable referenced from a non-static context

2023-03-09 Thread Nitin Gupta (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698447#comment-17698447
 ] 

Nitin Gupta commented on OAK-10137:
---

PR - https://github.com/apache/jackrabbit-oak/pull/870/files 


> Static variable referenced from a non-static context
> 
>
> Key: OAK-10137
> URL: https://issues.apache.org/jira/browse/OAK-10137
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Nitin Gupta
>Assignee: Nitin Gupta
>Priority: Major
>
> https://github.com/apache/jackrabbit-oak/blame/trunk/oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticBulkProcessorHandler.java#L188
> waitForESAcknowledgement is a static variable which is accessed from a 
> non-static context. It is set to true only at initialization, in a static 
> context. So if at some point it is set to false, it will never again become 
> true during the runtime of the JVM. And the BuikProcessor instance is not 
> static, so there may be many instances created in the same JVM execution



--
This message was sent by Atlassian Jira
(v8.20.10#820010)