[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708263#comment-17708263
 ] 

Angela Schreiber commented on OAK-10151:


[~reschke], fine with me.

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708246#comment-17708246
 ] 

Julian Reschke commented on OAK-10151:
--

The caching module and the bloom filters might be hard to replace.

As for this bug; I think we can just close it. It's a Guava problem, and we are 
not going to use that Guava version.

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708244#comment-17708244
 ] 

Angela Schreiber commented on OAK-10151:


if 'everywhere' includes code not inside oak then you are right. but for 
oak i think we should start getting rid of it and if needed write our own 
replacements either in oak-commons or in an other module.

my short term goal here is to get this bug resolved asap :)

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708241#comment-17708241
 ] 

Julian Reschke commented on OAK-10151:
--

If this was possible everywhere, that would indeed be good.

AFAIU, our consensus though was that we can't.

When converting subprojects to Shaded Guava, I'll have an eye on the easy 
replacements, though.

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708240#comment-17708240
 ] 

Angela Schreiber commented on OAK-10151:


[~reschke], wouldn't it be easier to slowly get rid of guava usage altogether? 
for me that would feel natural.

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707235#comment-17707235
 ] 

Julian Reschke commented on OAK-10151:
--

So my concrete proposal would be to use the laetst Guava in the shaded project 
right away; I'll figure out how to deal with the removed/changed methods as I 
convert the subprojects.

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707034#comment-17707034
 ] 

Julian Reschke commented on OAK-10151:
--

Just clarifying: the third option is not to use Guava {*}20{*}. That would mean 
that we start with shading the latest Guava version. The downside is that our 
code will actual need changes due to incompatible changes, and that we don't 
have a transition perion for that (so either old-style Guava 15 or shaded 
current Guava).

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Angela Schreiber (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707017#comment-17707017
 ] 

Angela Schreiber commented on OAK-10151:


[~reschke], not sure if getting rid of guava is feasible without major effort. 
but i would replace _every_ usage of Iterators.concat in oak by either a 
variant 1 or variant 2. no strong pref.

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17706931#comment-17706931
 ] 

Julian Reschke commented on OAK-10151:
--

So apparently concat() is broken in 20.0; see 
.

We now have several choices:
 * when using concat(), put the iterators into wrapper classes so that the 
broken optimization doesn't happen
 * avoid concat() altogether, by using our own utilty (as proposed by [~angela] 
)
 * simply do not use Guava 20; but this will make the transition harder (Guava 
20 deprecated certain stuff and added replacements for it)

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704017#comment-17704017
 ] 

Julian Reschke commented on OAK-10151:
--

Tested with the Guava versions up to 19.0, and found it's indeed the step from 
19.0 to 20.0 causing this (check with "-Dguava.version=19.0").

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Minor
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Commented] (OAK-10151) oak-auth-external tests fail with Guava 20

[Julian Reschke (Jira)]

[ 
https://issues.apache.org/jira/browse/OAK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703743#comment-17703743
 ] 

Julian Reschke commented on OAK-10151:
--

To repro:

"mvn clean install -Pguava-latest"

> oak-auth-external tests fail with Guava 20
> --
>
> Key: OAK-10151
> URL: https://issues.apache.org/jira/browse/OAK-10151
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: auth-external
>Reporter: Julian Reschke
>Assignee: Angela Schreiber
>Priority: Major
> Fix For: 1.52.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)