[jira] [Commented] (OAK-10559) Suspected flakyness in LastRevRecoveryRandomizedIT

2023-11-25 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789692#comment-17789692
 ] 

Julian Reschke commented on OAK-10559:
--

Further debugging shows that it may have to do with the way the RDB DS is 
configured ("drop tables on close" of course only works when the instance 
dropping it is disposed last). Let me debug some more tomorrow.

> Suspected flakyness in LastRevRecoveryRandomizedIT
> --
>
> Key: OAK-10559
> URL: https://issues.apache.org/jira/browse/OAK-10559
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> Following test failure in LastRevRecoveryRandomizedIT was witnessed:
> {noformat}
> 18:31:23  [ERROR] 
> randomized(org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryRandomizedIT)
>   Time elapsed: 0.586 s  <<< ERROR!
> 18:31:23  org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: 
> Configured cluster node id 1 already in use: needs recovery and was unable to 
> perform it myself
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfo.createInstance(ClusterNodeInfo.java:629)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfo.getInstance(ClusterNodeInfo.java:471)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:607)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.build(DocumentNodeStoreBuilder.java:176)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:481)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryRandomizedIT.checkStore(LastRevRecoveryRandomizedIT.java:262)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10559) Suspected flakyness in LastRevRecoveryRandomizedIT

2023-11-25 Thread Julian Reschke (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789641#comment-17789641
 ] 

Julian Reschke commented on OAK-10559:
--

https://github.com/apache/jackrabbit-oak/commit/41adb88c8513754c14d4787d45a87aea95763647

I have looked at this some more, and it seems that the wohl use of a secondary 
node store in this class is incorrect. For tests that simulate cluster 
activities, we need a DS impl that supports clustering, and MemoryDS does not. 
We have a parameter for the {{fixtures}} to select that subset.

We probably should split that test class into into two; and find out why 
closing the secondary node store sometimes fails even for RDB.

> Suspected flakyness in LastRevRecoveryRandomizedIT
> --
>
> Key: OAK-10559
> URL: https://issues.apache.org/jira/browse/OAK-10559
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> Following test failure in LastRevRecoveryRandomizedIT was witnessed:
> {noformat}
> 18:31:23  [ERROR] 
> randomized(org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryRandomizedIT)
>   Time elapsed: 0.586 s  <<< ERROR!
> 18:31:23  org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: 
> Configured cluster node id 1 already in use: needs recovery and was unable to 
> perform it myself
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfo.createInstance(ClusterNodeInfo.java:629)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfo.getInstance(ClusterNodeInfo.java:471)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:607)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.build(DocumentNodeStoreBuilder.java:176)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:481)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryRandomizedIT.checkStore(LastRevRecoveryRandomizedIT.java:262)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10559) Suspected flakyness in LastRevRecoveryRandomizedIT

2023-11-23 Thread Stefan Egli (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789056#comment-17789056
 ] 

Stefan Egli commented on OAK-10559:
---

* second https://github.com/apache/jackrabbit-oak/pull/1230
* third https://github.com/apache/jackrabbit-oak/pull/1231
* fourth https://github.com/apache/jackrabbit-oak/pull/1232

> Suspected flakyness in LastRevRecoveryRandomizedIT
> --
>
> Key: OAK-10559
> URL: https://issues.apache.org/jira/browse/OAK-10559
> Project: Jackrabbit Oak
>  Issue Type: Bug
>  Components: documentmk
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> Following test failure in LastRevRecoveryRandomizedIT was witnessed:
> {noformat}
> 18:31:23  [ERROR] 
> randomized(org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryRandomizedIT)
>   Time elapsed: 0.586 s  <<< ERROR!
> 18:31:23  org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: 
> Configured cluster node id 1 already in use: needs recovery and was unable to 
> perform it myself
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfo.createInstance(ClusterNodeInfo.java:629)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfo.getInstance(ClusterNodeInfo.java:471)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:607)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.build(DocumentNodeStoreBuilder.java:176)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:481)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryRandomizedIT.checkStore(LastRevRecoveryRandomizedIT.java:262)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OAK-10559) Suspected flakyness in LastRevRecoveryRandomizedIT

2023-11-22 Thread Stefan Egli (Jira)


[ 
https://issues.apache.org/jira/browse/OAK-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17788850#comment-17788850
 ] 

Stefan Egli commented on OAK-10559:
---

* temporarily adding more infos to an exception via 
https://github.com/apache/jackrabbit-oak/pull/1229

> Suspected flakyness in LastRevRecoveryRandomizedIT
> --
>
> Key: OAK-10559
> URL: https://issues.apache.org/jira/browse/OAK-10559
> Project: Jackrabbit Oak
>  Issue Type: Bug
>Reporter: Stefan Egli
>Assignee: Stefan Egli
>Priority: Major
>
> Following test failure in LastRevRecoveryRandomizedIT was witnessed:
> {noformat}
> 18:31:23  [ERROR] 
> randomized(org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryRandomizedIT)
>   Time elapsed: 0.586 s  <<< ERROR!
> 18:31:23  org.apache.jackrabbit.oak.plugins.document.DocumentStoreException: 
> Configured cluster node id 1 already in use: needs recovery and was unable to 
> perform it myself
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfo.createInstance(ClusterNodeInfo.java:629)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.ClusterNodeInfo.getInstance(ClusterNodeInfo.java:471)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStore.(DocumentNodeStore.java:607)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder.build(DocumentNodeStoreBuilder.java:176)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.DocumentMK$Builder.getNodeStore(DocumentMK.java:481)
> 18:31:23  at 
> org.apache.jackrabbit.oak.plugins.document.LastRevRecoveryRandomizedIT.checkStore(LastRevRecoveryRandomizedIT.java:262)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)