[jira] [Commented] (OAK-10662) improve Reproducible Builds
[ https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842936#comment-17842936 ] Julian Reschke commented on OAK-10662: -- When was 3.5.3 released? > improve Reproducible Builds > --- > > Key: OAK-10662 > URL: https://issues.apache.org/jira/browse/OAK-10662 > Project: Jackrabbit Oak > Issue Type: Improvement >Affects Versions: 1.60.0 >Reporter: Herve Boutemy >Assignee: Julian Reschke >Priority: Major > > release 1.60.0 is quite good: 143 ok, 11 ko > there are some easy fixes > and probably harder ones later > see > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10662) improve Reproducible Builds
[ https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841961#comment-17841961 ] Manfred Baedke commented on OAK-10662: -- [~reschke], I'm confused [MSHADE-471|https://issues.apache.org/jira/browse/MSHADE-471] has fix version 3.5.3, while [OAK-10684|https://issues.apache.org/jira/browse/OAK-10684] updates to 3.5.2. Is that deliberate? > improve Reproducible Builds > --- > > Key: OAK-10662 > URL: https://issues.apache.org/jira/browse/OAK-10662 > Project: Jackrabbit Oak > Issue Type: Improvement >Affects Versions: 1.60.0 >Reporter: Herve Boutemy >Assignee: Julian Reschke >Priority: Major > > release 1.60.0 is quite good: 143 ok, 11 ko > there are some easy fixes > and probably harder ones later > see > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10662) improve Reproducible Builds
[ https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837180#comment-17837180 ] Manfred Baedke commented on OAK-10662: -- For OAK-6756, OAK-6766, OAK-6772 there are pull requests available waiting to be reviewed. Once they are merged, all OSGI-INF/l10n/*.properties files should disappear. > improve Reproducible Builds > --- > > Key: OAK-10662 > URL: https://issues.apache.org/jira/browse/OAK-10662 > Project: Jackrabbit Oak > Issue Type: Improvement >Affects Versions: 1.60.0 >Reporter: Herve Boutemy >Assignee: Julian Reschke >Priority: Major > > release 1.60.0 is quite good: 143 ok, 11 ko > there are some easy fixes > and probably harder ones later > see > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10662) improve Reproducible Builds
[ https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836835#comment-17836835 ] Herve Boutemy commented on OAK-10662: - see MSHADE-471 > improve Reproducible Builds > --- > > Key: OAK-10662 > URL: https://issues.apache.org/jira/browse/OAK-10662 > Project: Jackrabbit Oak > Issue Type: Improvement >Affects Versions: 1.60.0 >Reporter: Herve Boutemy >Assignee: Julian Reschke >Priority: Major > > release 1.60.0 is quite good: 143 ok, 11 ko > there are some easy fixes > and probably harder ones later > see > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10662) improve Reproducible Builds
[ https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835289#comment-17835289 ] Julian Reschke commented on OAK-10662: -- [~hboutemy] - thanks for helping here. 1. These are AFAIU understand by the historic Felix SCR plugin; from which we are trying to migrate away (issues shoubd be linked) 2. These IMHO should not be in the release; will have to check what's going on (and yes, that's important given what just happened two weeks ago) 3. Does that bug have a ticket? > improve Reproducible Builds > --- > > Key: OAK-10662 > URL: https://issues.apache.org/jira/browse/OAK-10662 > Project: Jackrabbit Oak > Issue Type: Improvement >Affects Versions: 1.60.0 >Reporter: Herve Boutemy >Assignee: Julian Reschke >Priority: Major > > release 1.60.0 is quite good: 143 ok, 11 ko > there are some easy fixes > and probably harder ones later > see > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10662) improve Reproducible Builds
[
https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835144#comment-17835144
]
Herve Boutemy commented on OAK-10662:
-
here is the remaining diffs for 1.62.0
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/jackrabbit-oak-1.62.0.diffoscope
:
1. majority of issues are timestamp in comments from
{{OSGI-INF/l10n/*.properties}}: how are these properties files generated?
2. there are also missing files, like {{document*.mv.db}} or
{{solr/oak/data/**}}: it looks like test data that was inserted into reference
build but not rebuild (and probably not reproducible: not having them is
finally better...)
3. and a bug in maven-shade-plugin
> improve Reproducible Builds
> ---
>
> Key: OAK-10662
> URL: https://issues.apache.org/jira/browse/OAK-10662
> Project: Jackrabbit Oak
> Issue Type: Improvement
>Affects Versions: 1.60.0
>Reporter: Herve Boutemy
>Priority: Major
>
> release 1.60.0 is quite good: 143 ok, 11 ko
> there are some easy fixes
> and probably harder ones later
> see
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OAK-10662) improve Reproducible Builds
[ https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822867#comment-17822867 ] Julian Reschke commented on OAK-10662: -- Thanks for the explanation. > improve Reproducible Builds > --- > > Key: OAK-10662 > URL: https://issues.apache.org/jira/browse/OAK-10662 > Project: Jackrabbit Oak > Issue Type: Improvement >Affects Versions: 1.60.0 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.62.0 > > > release 1.60.0 is quite good: 143 ok, 11 ko > there are some easy fixes > and probably harder ones later > see > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10662) improve Reproducible Builds
[ https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822802#comment-17822802 ] Herve Boutemy commented on OAK-10662: - it seems there has been a bug while executing maven-release-plugin in the past that kept a wrong value in the development flow: and the release plugin protects the value user defined in the development flow, then the situation after the bug happened never fixes auto-magically if there is no human manual fix that's why I proposed a basic human fix while doing some little improvements as you see, this value is not well known nor used, then you can be confident that the new value if not worse than previous one :) and believe me it is better, because it points to your current branch: for those who want to trust the value during development, the new value is better as you can see, at release time, the tag point to the good tag value https://github.com/apache/jackrabbit-oak/commit/4e1d965b7b49c9bfa12b262ee828461c0230546a#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8L94 then your release does not suffer the problem is just that the release plugin restores previous wrong value just after https://github.com/apache/jackrabbit-oak/commit/98db7b61544b3931c2b2d34ab187112b2ef359aa#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8L94 > improve Reproducible Builds > --- > > Key: OAK-10662 > URL: https://issues.apache.org/jira/browse/OAK-10662 > Project: Jackrabbit Oak > Issue Type: Improvement >Affects Versions: 1.60.0 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.62.0 > > > release 1.60.0 is quite good: 143 ok, 11 ko > there are some easy fixes > and probably harder ones later > see > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10662) improve Reproducible Builds
[ https://issues.apache.org/jira/browse/OAK-10662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822620#comment-17822620 ] Julian Reschke commented on OAK-10662: -- [~hboutemy] - I'm confused about the role of the scm/tag element. Yes, it's clearly incorrect, but then, it doesn't seem to matter? Maybe we could just remove it? In any case, the current value was set by the release plugin: https://github.com/apache/jackrabbit-oak/blame/ba989d762e8bdd242cd5d25d20390361f8a18365/oak-parent/pom.xml#L1344 Do we have a bug here? > improve Reproducible Builds > --- > > Key: OAK-10662 > URL: https://issues.apache.org/jira/browse/OAK-10662 > Project: Jackrabbit Oak > Issue Type: Improvement >Affects Versions: 1.60.0 >Reporter: Herve Boutemy >Priority: Major > Fix For: 1.62.0 > > > release 1.60.0 is quite good: 143 ok, 11 ko > there are some easy fixes > and probably harder ones later > see > https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/oak/README.md -- This message was sent by Atlassian Jira (v8.20.10#820010)
