[jira] [Commented] (OAK-10733) Filter out hidden properties from content in FlatFileStore
[ https://issues.apache.org/jira/browse/OAK-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833528#comment-17833528 ] Julian Reschke commented on OAK-10733: -- Is this bug resolved with the PR being merged? > Filter out hidden properties from content in FlatFileStore > -- > > Key: OAK-10733 > URL: https://issues.apache.org/jira/browse/OAK-10733 > Project: Jackrabbit Oak > Issue Type: Task > Components: run-commons >Reporter: Nitin Gupta >Assignee: Nitin Gupta >Priority: Major > > Currently we ignore/filter out hidden nodes while building the FFS but not > the hidden properties. > We however ignore any changes to hidden properties (using the VisibleEditor) > during async indexing cycles, so it makes little sense to have these in the > FFS. > > This task is to see if these can be removed, and if gives some benefit during > reindexing phase. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10733) Filter out hidden properties from content in FlatFileStore
[ https://issues.apache.org/jira/browse/OAK-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833537#comment-17833537 ] Nitin Gupta commented on OAK-10733: --- trunk : [https://github.com/apache/jackrabbit-oak/commit/2b27df56b9901fe107bcad6aed03c402234f590a] > Filter out hidden properties from content in FlatFileStore > -- > > Key: OAK-10733 > URL: https://issues.apache.org/jira/browse/OAK-10733 > Project: Jackrabbit Oak > Issue Type: Task > Components: run-commons >Reporter: Nitin Gupta >Assignee: Nitin Gupta >Priority: Major > > Currently we ignore/filter out hidden nodes while building the FFS but not > the hidden properties. > We however ignore any changes to hidden properties (using the VisibleEditor) > during async indexing cycles, so it makes little sense to have these in the > FFS. > > This task is to see if these can be removed, and if gives some benefit during > reindexing phase. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10733) Filter out hidden properties from content in FlatFileStore
[ https://issues.apache.org/jira/browse/OAK-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833650#comment-17833650 ] Julian Reschke commented on OAK-10733: -- This might cause an IT failure: > Filter out hidden properties from content in FlatFileStore > -- > > Key: OAK-10733 > URL: https://issues.apache.org/jira/browse/OAK-10733 > Project: Jackrabbit Oak > Issue Type: Task > Components: run-commons >Reporter: Nitin Gupta >Assignee: Nitin Gupta >Priority: Major > Fix For: 1.62.0 > > > Currently we ignore/filter out hidden nodes while building the FFS but not > the hidden properties. > We however ignore any changes to hidden properties (using the VisibleEditor) > during async indexing cycles, so it makes little sense to have these in the > FFS. > > This task is to see if these can be removed, and if gives some benefit during > reindexing phase. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10733) Filter out hidden properties from content in FlatFileStore
[ https://issues.apache.org/jira/browse/OAK-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833657#comment-17833657 ] Nitin Gupta commented on OAK-10733: --- Reverted the commit here [https://github.com/apache/jackrabbit-oak/commit/e220c69ec73f1cf8012d6f702a8eb1d386a4418e] . The seems to be due to the isEmpty() check. I will create a new PR. > Filter out hidden properties from content in FlatFileStore > -- > > Key: OAK-10733 > URL: https://issues.apache.org/jira/browse/OAK-10733 > Project: Jackrabbit Oak > Issue Type: Task > Components: run-commons >Reporter: Nitin Gupta >Assignee: Nitin Gupta >Priority: Major > > Currently we ignore/filter out hidden nodes while building the FFS but not > the hidden properties. > We however ignore any changes to hidden properties (using the VisibleEditor) > during async indexing cycles, so it makes little sense to have these in the > FFS. > > This task is to see if these can be removed, and if gives some benefit during > reindexing phase. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10733) Filter out hidden properties from content in FlatFileStore
[ https://issues.apache.org/jira/browse/OAK-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837943#comment-17837943 ] Nitin Gupta commented on OAK-10733: --- No longer required. > Filter out hidden properties from content in FlatFileStore > -- > > Key: OAK-10733 > URL: https://issues.apache.org/jira/browse/OAK-10733 > Project: Jackrabbit Oak > Issue Type: Task > Components: run-commons >Reporter: Nitin Gupta >Assignee: Nitin Gupta >Priority: Major > > Currently we ignore/filter out hidden nodes while building the FFS but not > the hidden properties. > We however ignore any changes to hidden properties (using the VisibleEditor) > during async indexing cycles, so it makes little sense to have these in the > FFS. > > This task is to see if these can be removed, and if gives some benefit during > reindexing phase. -- This message was sent by Atlassian Jira (v8.20.10#820010)
