[jira] [Commented] (OAK-10764) gap orphans improvement : only lookup greatest existing ancestor, then cache
[ https://issues.apache.org/jira/browse/OAK-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837383#comment-17837383 ] Stefan Egli commented on OAK-10764: --- note : created PR on top of the previous one : https://github.com/apache/jackrabbit-oak/pull/1421 > gap orphans improvement : only lookup greatest existing ancestor, then cache > > > Key: OAK-10764 > URL: https://issues.apache.org/jira/browse/OAK-10764 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Major > Labels: DetailedGC > > Follow-up of OAK-10761 : to further improve gap vs non-gap orphan type > detection, lookup only the direct child of the greatest existing ancestor, > then cache that result. Upon further type detection, use that cache to start > with. That eliminates the tree traversal, plus using the cache should further > limit the number of lookups in the first place. The cache can be small (eg > 64) and assuming paths aren't excessive (say max 10k) the resulting memory > usage would still be small (eg 64k characters). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OAK-10764) gap orphans improvement : only lookup greatest existing ancestor, then cache
[ https://issues.apache.org/jira/browse/OAK-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837381#comment-17837381 ] Stefan Egli commented on OAK-10764: --- PR created at https://github.com/apache/jackrabbit-oak/pull/1420 > gap orphans improvement : only lookup greatest existing ancestor, then cache > > > Key: OAK-10764 > URL: https://issues.apache.org/jira/browse/OAK-10764 > Project: Jackrabbit Oak > Issue Type: Task > Components: documentmk >Reporter: Stefan Egli >Assignee: Stefan Egli >Priority: Major > Labels: DetailedGC > > Follow-up of OAK-10761 : to further improve gap vs non-gap orphan type > detection, lookup only the direct child of the greatest existing ancestor, > then cache that result. Upon further type detection, use that cache to start > with. That eliminates the tree traversal, plus using the cache should further > limit the number of lookups in the first place. The cache can be small (eg > 64) and assuming paths aren't excessive (say max 10k) the resulting memory > usage would still be small (eg 64k characters). -- This message was sent by Atlassian Jira (v8.20.10#820010)
